Re: [I] [FEATURE] Support table format output for SchemaDetails command [gravitino]
justinmclean closed issue #5957: [FEATURE] Support table format output for SchemaDetails command URL: https://github.com/apache/gravitino/issues/5957 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [I] [FEATURE] Support table format output for SchemaDetails command [gravitino]
Abyss-lord commented on issue #5957: URL: https://github.com/apache/gravitino/issues/5957#issuecomment-2683793236 @waukin @justinmclean The feature has been implemented, and the issue can be closed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [I] [FEATURE] Support table format output for SchemaDetails command [gravitino]
waukin commented on issue #5957: URL: https://github.com/apache/gravitino/issues/5957#issuecomment-2562758155 > You can leave the existing method as `output(catalogs)` and just have that method output "No catalogs exist." if null is passed into it. I’ve kept the existing method as `output(catalogs)`. For the `ListCatalogs` command, if there are no catalogs, `client.listCatalogsInfo()` returns an empty array, not null. I’ve made some refactoring changes in this PR: https://github.com/apache/gravitino/pull/6015. If you have some free time, please take a look. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [I] [FEATURE] Support table format output for SchemaDetails command [gravitino]
justinmclean commented on issue #5957: URL: https://github.com/apache/gravitino/issues/5957#issuecomment-2562015624 You can leave the existing method as `output(catalogs)` and just have that method output "No catalogs exist." if null is passed into it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [I] [FEATURE] Support table format output for SchemaDetails command [gravitino]
waukin commented on issue #5957: URL: https://github.com/apache/gravitino/issues/5957#issuecomment-2561575925 Hi @Abyss-lord, I see. We can handle that by having the `output` method accept a string argument and simply printing it. I'll open another issue to make it clearer. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [I] [FEATURE] Support table format output for SchemaDetails command [gravitino]
Abyss-lord commented on issue #5957: URL: https://github.com/apache/gravitino/issues/5957#issuecomment-2561525035 Hi @waukin , In the `ListXXX` method, if there is No data, CLI should give a hint, such as "No metalakes exist. "The current implementation is implemented by two methods: `System.out.println` and `output`. In #5942 , the reviewer wants to combine the implementation into a single method.  -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [I] [FEATURE] Support table format output for SchemaDetails command [gravitino]
waukin commented on issue #5957: URL: https://github.com/apache/gravitino/issues/5957#issuecomment-2561154657 Hi @Abyss-lord, I’m still confused about the requirement that the `output` method should accept string argument. In the previous implementation, the `output` method accepted different types of arguments, such as `Metalake` and `Catalog`. For example, you can refer to `MetalakeDetails` and `CatalogDetails`. Could you please provide a more detailed explanation? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [I] [FEATURE] Support table format output for SchemaDetails command [gravitino]
Abyss-lord commented on issue #5957: URL: https://github.com/apache/gravitino/issues/5957#issuecomment-2560574358 > > @waukin BTW, `output` method should accept string argument, Please amend it here.  > > @Abyss-lord, why does it need to accept string argument? See this pr #5924 , If no data is available, a hint should be given They wanted to unify the output method. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [I] [FEATURE] Support table format output for SchemaDetails command [gravitino]
waukin commented on issue #5957: URL: https://github.com/apache/gravitino/issues/5957#issuecomment-2560560910 > @waukin BTW, `output` method should accept string argument, Please amend it here.  @Abyss-lord, why does it need to accept string argument? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [I] [FEATURE] Support table format output for SchemaDetails command [gravitino]
Abyss-lord commented on issue #5957: URL: https://github.com/apache/gravitino/issues/5957#issuecomment-2560520907 @waukin BTW, `output` method should accept string argument, Please amend it here.  -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [I] [FEATURE] Support table format output for SchemaDetails command [gravitino]
waukin commented on issue #5957: URL: https://github.com/apache/gravitino/issues/5957#issuecomment-2560513458 @xunliu please assign this issue to me. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [I] [FEATURE] Support table format output for SchemaDetails command [gravitino]
waukin commented on issue #5957: URL: https://github.com/apache/gravitino/issues/5957#issuecomment-2560513158 > > Hi @Abyss-lord, I’m halfway through implementing the feature. If you don’t mind, I’d like to continue working on it. > > that's ok, since you wrote the previous code, it would be great if you could continue working on it. Thank you for your understanding. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [I] [FEATURE] Support table format output for SchemaDetails command [gravitino]
Abyss-lord commented on issue #5957: URL: https://github.com/apache/gravitino/issues/5957#issuecomment-2560501712 > Hi @Abyss-lord, I’m halfway through implementing the feature. If you don’t mind, I’d like to continue working on it. that's ok, since you wrote the previous code, it would be great if you could continue working on it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [I] [FEATURE] Support table format output for SchemaDetails command [gravitino]
waukin commented on issue #5957: URL: https://github.com/apache/gravitino/issues/5957#issuecomment-2560467034 Hi @Abyss-lord, I’m halfway through implementing the issue. If you don’t mind, I’d like to continue working on it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [I] [FEATURE] Support table format output for SchemaDetails command [gravitino]
Abyss-lord commented on issue #5957: URL: https://github.com/apache/gravitino/issues/5957#issuecomment-2560063480 I would like to work on it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
