Re: [I] [Improvement] HTTPClient.java has no unit tests/coverage [gravitino]

2024-12-05 Thread via GitHub


justinmclean commented on issue #2182:
URL: https://github.com/apache/gravitino/issues/2182#issuecomment-2521907102

   OK I think we can close this issue.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



Re: [I] [Improvement] HTTPClient.java has no unit tests/coverage [gravitino]

2024-12-05 Thread via GitHub


justinmclean closed issue #2182: [Improvement] HTTPClient.java has no unit 
tests/coverage
URL: https://github.com/apache/gravitino/issues/2182


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



Re: [I] [Improvement] HTTPClient.java has no unit tests/coverage [gravitino]

2024-12-05 Thread via GitHub


chenyuan99 commented on issue #2182:
URL: https://github.com/apache/gravitino/issues/2182#issuecomment-2521847540

   @justinmclean agree, it already got coverage in 
https://github.com/apache/gravitino/blob/6990036d5637e4a70690cad2f198466ac3612d1b/clients/client-java/src/test/java/org/apache/gravitino/client/TestHTTPClient.java


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



Re: [I] [Improvement] HTTPClient.java has no unit tests/coverage [gravitino]

2024-08-05 Thread via GitHub


zzzk1 commented on issue #2182:
URL: https://github.com/apache/gravitino/issues/2182#issuecomment-2269345176

   > @zzzk1 how are you going with this issue?
   
   Sorry for the late reply. It looks like HTTPClient.java already has a test 
case. I am trying to improve the test coverage.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



Re: [I] [Improvement] HTTPClient.java has no unit tests/coverage [gravitino]

2024-08-04 Thread via GitHub


justinmclean commented on issue #2182:
URL: https://github.com/apache/gravitino/issues/2182#issuecomment-2267460125

   @zzzk1 how are you going with this issue?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



Re: [I] [Improvement] HTTPClient.java has no unit tests/coverage [gravitino]

2024-08-03 Thread via GitHub


mrkartik00 commented on issue #2182:
URL: https://github.com/apache/gravitino/issues/2182#issuecomment-2266708055

   where to provide the test code


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



Re: [I] [Improvement] HTTPClient.java has no unit tests/coverage [gravitino]

2024-07-30 Thread via GitHub


zzzk1 commented on issue #2182:
URL: https://github.com/apache/gravitino/issues/2182#issuecomment-2259009782

   @justinmclean can i pick up this issue thx?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]