Re: [PR] [#3232] fix(client): Fix the deleting role issues with irregular name [gravitino]
jerryshao merged PR #4524: URL: https://github.com/apache/gravitino/pull/4524 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] [#3232] fix(client): Fix the deleting role issues with irregular name [gravitino]
jerryshao closed pull request #4524: [#3232] fix(client): Fix the deleting role issues with irregular name URL: https://github.com/apache/gravitino/pull/4524 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] [#3232] fix(client): Fix the deleting role issues with irregular name [gravitino]
jerryshao merged PR #4501: URL: https://github.com/apache/gravitino/pull/4501 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] [#3232] fix(client): Fix the deleting role issues with irregular name [gravitino]
jerqi commented on code in PR #4501:
URL: https://github.com/apache/gravitino/pull/4501#discussion_r1716895790
##
clients/client-java/src/main/java/org/apache/gravitino/client/GravitinoClient.java:
##
@@ -242,6 +242,7 @@ public boolean deleteRole(String role) throws
NoSuchMetalakeException {
* @return The created Role instance.
* @throws RoleAlreadyExistsException If a Role with the same name already
exists.
* @throws NoSuchMetalakeException If the Metalake with the given name does
not exist.
+ * @throws NoSuchMetadataObjectException If securable object doesn't exist
* @throws RuntimeException If creating the Role encounters storage issues.
*/
public Role createRole(
Review Comment:
Added.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] [#3232] fix(client): Fix the deleting role issues with irregular name [gravitino]
jerryshao commented on code in PR #4501:
URL: https://github.com/apache/gravitino/pull/4501#discussion_r1716889588
##
clients/client-java/src/main/java/org/apache/gravitino/client/GravitinoClient.java:
##
@@ -242,6 +242,7 @@ public boolean deleteRole(String role) throws
NoSuchMetalakeException {
* @return The created Role instance.
* @throws RoleAlreadyExistsException If a Role with the same name already
exists.
* @throws NoSuchMetalakeException If the Metalake with the given name does
not exist.
+ * @throws NoSuchMetadataObjectException If securable object doesn't exist
* @throws RuntimeException If creating the Role encounters storage issues.
*/
public Role createRole(
Review Comment:
Should you also add this exception to the interface signature?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] [#3232] fix(client): Fix the deleting role issues with irregular name [gravitino]
jerqi commented on code in PR #4501:
URL: https://github.com/apache/gravitino/pull/4501#discussion_r1716867437
##
integration-test/src/test/java/org/apache/gravitino/integration/test/authorization/AccessControlIT.java:
##
@@ -0,0 +1,260 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.gravitino.integration.test.authorization;
+
+import com.google.common.collect.Lists;
+import com.google.common.collect.Maps;
+import java.util.Collections;
+import java.util.Map;
+import org.apache.gravitino.Configs;
+import org.apache.gravitino.auth.AuthConstants;
+import org.apache.gravitino.authorization.Group;
+import org.apache.gravitino.authorization.Privilege;
+import org.apache.gravitino.authorization.Privileges;
+import org.apache.gravitino.authorization.Role;
+import org.apache.gravitino.authorization.SecurableObject;
+import org.apache.gravitino.authorization.SecurableObjects;
+import org.apache.gravitino.authorization.User;
+import org.apache.gravitino.client.GravitinoMetalake;
+import org.apache.gravitino.exceptions.GroupAlreadyExistsException;
+import org.apache.gravitino.exceptions.NoSuchGroupException;
+import org.apache.gravitino.exceptions.NoSuchRoleException;
+import org.apache.gravitino.exceptions.NoSuchUserException;
+import org.apache.gravitino.exceptions.UserAlreadyExistsException;
+import org.apache.gravitino.integration.test.util.AbstractIT;
+import org.apache.gravitino.utils.RandomNameUtils;
+import org.junit.jupiter.api.Assertions;
+import org.junit.jupiter.api.BeforeAll;
+import org.junit.jupiter.api.Test;
+
+public class AccessControlIT extends AbstractIT {
+
+ private static String metalakeName =
RandomNameUtils.genRandomName("metalake");
+ private static GravitinoMetalake metalake;
+
+ @BeforeAll
+ public static void startIntegrationTest() throws Exception {
+Map configs = Maps.newHashMap();
+configs.put(Configs.ENABLE_AUTHORIZATION.getKey(), String.valueOf(true));
+configs.put(Configs.SERVICE_ADMINS.getKey(), AuthConstants.ANONYMOUS_USER);
+registerCustomConfigs(configs);
+AbstractIT.startIntegrationTest();
+metalake = client.createMetalake(metalakeName, "metalake comment",
Collections.emptyMap());
+ }
+
+ @Test
+ void testManageUsers() {
+String username = "user1#123";
+User user = metalake.addUser(username);
+Assertions.assertEquals(username, user.name());
+Assertions.assertTrue(user.roles().isEmpty());
+
+// Add an existed user
+Assertions.assertThrows(UserAlreadyExistsException.class, () ->
metalake.addUser(username));
+
+user = metalake.getUser(username);
+Assertions.assertEquals(username, user.name());
+Assertions.assertTrue(user.roles().isEmpty());
+
+// Get a not-existed user
+Assertions.assertThrows(NoSuchUserException.class, () ->
metalake.getUser("not-existed"));
+
+Assertions.assertTrue(metalake.removeUser(username));
+Assertions.assertFalse(metalake.removeUser(username));
+ }
+
+ @Test
+ void testManageGroups() {
+String groupName = "group1#123";
+Group group = metalake.addGroup(groupName);
+Assertions.assertEquals(group.name(), groupName);
+Assertions.assertTrue(group.roles().isEmpty());
+
+// Added an existed group
+Assertions.assertThrows(GroupAlreadyExistsException.class, () ->
metalake.addGroup(groupName));
+
+group = metalake.getGroup(groupName);
+Assertions.assertEquals(group.name(), groupName);
+Assertions.assertTrue(group.roles().isEmpty());
+
+// Get a not-existed group
+Assertions.assertThrows(NoSuchGroupException.class, () ->
metalake.getGroup("not-existed"));
+
+Assertions.assertTrue(metalake.removeGroup(groupName));
+Assertions.assertFalse(metalake.removeGroup(groupName));
+ }
+
+ @Test
+ void testManageRoles() {
+String roleName = "role#123";
+Map properties = Maps.newHashMap();
+properties.put("k1", "v1");
+SecurableObject metalakeObject =
+SecurableObjects.ofMetalake(
+metalakeName,
Lists.newArrayList(Privileges.CreateCatalog.allow()));
+Role role = metalake.createRole(roleName, properties,
Lists.newArrayList(metalakeObject));
+
+Assertions.assertEquals(roleName, role.name
Re: [PR] [#3232] fix(client): Fix the deleting role issues with irregular name [gravitino]
jerqi commented on code in PR #4501:
URL: https://github.com/apache/gravitino/pull/4501#discussion_r1716822420
##
common/src/main/java/org/apache/gravitino/dto/authorization/SecurableObjectDTO.java:
##
@@ -31,44 +31,41 @@
/** Data transfer object representing a securable object. */
public class SecurableObjectDTO implements SecurableObject {
- @JsonProperty("fullName")
- private String fullName;
-
@JsonProperty("type")
private Type type;
@JsonProperty("privileges")
private PrivilegeDTO[] privileges;
- private String parent;
- private String name;
-
- /** Default constructor for Jackson deserialization. */
- protected SecurableObjectDTO() {}
+ /** @return The full name of the securable object. */
+ @JsonProperty("fullName")
+ public String getFullName() {
+return fullName();
+ }
/**
- * Creates a new instance of SecurableObject DTO.
+ * Sets the full name of the securable object. Only used by Jackson
deserializer.
*
- * @param privileges The privileges of the SecurableObject DTO.
- * @param fullName The name of the SecurableObject DTO.
- * @param type The type of the securable object.
+ * @param fullName The full name of the metadata object.
*/
- protected SecurableObjectDTO(String fullName, Type type, PrivilegeDTO[]
privileges) {
-this.type = type;
-this.fullName = fullName;
+ @JsonProperty("fullName")
+ public void setFullName(String fullName) {
int index = fullName.lastIndexOf(".");
-
if (index == -1) {
- this.parent = null;
- this.name = fullName;
+ parent = null;
+ name = fullName;
} else {
- this.parent = fullName.substring(0, index);
- this.name = fullName.substring(index + 1);
+ parent = fullName.substring(0, index);
+ name = fullName.substring(index + 1);
}
-
-this.privileges = privileges;
}
+ private String parent;
+ private String name;
+
+ /** Default constructor for Jackson deserialization. */
+ protected SecurableObjectDTO() {}
Review Comment:
I will.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] [#3232] fix(client): Fix the deleting role issues with irregular name [gravitino]
jerryshao commented on code in PR #4501:
URL: https://github.com/apache/gravitino/pull/4501#discussion_r1716816486
##
integration-test/src/test/java/org/apache/gravitino/integration/test/authorization/AccessControlIT.java:
##
@@ -0,0 +1,260 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.gravitino.integration.test.authorization;
+
+import com.google.common.collect.Lists;
+import com.google.common.collect.Maps;
+import java.util.Collections;
+import java.util.Map;
+import org.apache.gravitino.Configs;
+import org.apache.gravitino.auth.AuthConstants;
+import org.apache.gravitino.authorization.Group;
+import org.apache.gravitino.authorization.Privilege;
+import org.apache.gravitino.authorization.Privileges;
+import org.apache.gravitino.authorization.Role;
+import org.apache.gravitino.authorization.SecurableObject;
+import org.apache.gravitino.authorization.SecurableObjects;
+import org.apache.gravitino.authorization.User;
+import org.apache.gravitino.client.GravitinoMetalake;
+import org.apache.gravitino.exceptions.GroupAlreadyExistsException;
+import org.apache.gravitino.exceptions.NoSuchGroupException;
+import org.apache.gravitino.exceptions.NoSuchRoleException;
+import org.apache.gravitino.exceptions.NoSuchUserException;
+import org.apache.gravitino.exceptions.UserAlreadyExistsException;
+import org.apache.gravitino.integration.test.util.AbstractIT;
+import org.apache.gravitino.utils.RandomNameUtils;
+import org.junit.jupiter.api.Assertions;
+import org.junit.jupiter.api.BeforeAll;
+import org.junit.jupiter.api.Test;
+
+public class AccessControlIT extends AbstractIT {
+
+ private static String metalakeName =
RandomNameUtils.genRandomName("metalake");
+ private static GravitinoMetalake metalake;
+
+ @BeforeAll
+ public static void startIntegrationTest() throws Exception {
+Map configs = Maps.newHashMap();
+configs.put(Configs.ENABLE_AUTHORIZATION.getKey(), String.valueOf(true));
+configs.put(Configs.SERVICE_ADMINS.getKey(), AuthConstants.ANONYMOUS_USER);
+registerCustomConfigs(configs);
+AbstractIT.startIntegrationTest();
+metalake = client.createMetalake(metalakeName, "metalake comment",
Collections.emptyMap());
+ }
+
+ @Test
+ void testManageUsers() {
+String username = "user1#123";
+User user = metalake.addUser(username);
+Assertions.assertEquals(username, user.name());
+Assertions.assertTrue(user.roles().isEmpty());
+
+// Add an existed user
+Assertions.assertThrows(UserAlreadyExistsException.class, () ->
metalake.addUser(username));
+
+user = metalake.getUser(username);
+Assertions.assertEquals(username, user.name());
+Assertions.assertTrue(user.roles().isEmpty());
+
+// Get a not-existed user
+Assertions.assertThrows(NoSuchUserException.class, () ->
metalake.getUser("not-existed"));
+
+Assertions.assertTrue(metalake.removeUser(username));
+Assertions.assertFalse(metalake.removeUser(username));
+ }
+
+ @Test
+ void testManageGroups() {
+String groupName = "group1#123";
+Group group = metalake.addGroup(groupName);
+Assertions.assertEquals(group.name(), groupName);
+Assertions.assertTrue(group.roles().isEmpty());
+
+// Added an existed group
+Assertions.assertThrows(GroupAlreadyExistsException.class, () ->
metalake.addGroup(groupName));
+
+group = metalake.getGroup(groupName);
+Assertions.assertEquals(group.name(), groupName);
+Assertions.assertTrue(group.roles().isEmpty());
+
+// Get a not-existed group
+Assertions.assertThrows(NoSuchGroupException.class, () ->
metalake.getGroup("not-existed"));
+
+Assertions.assertTrue(metalake.removeGroup(groupName));
+Assertions.assertFalse(metalake.removeGroup(groupName));
+ }
+
+ @Test
+ void testManageRoles() {
+String roleName = "role#123";
+Map properties = Maps.newHashMap();
+properties.put("k1", "v1");
+SecurableObject metalakeObject =
+SecurableObjects.ofMetalake(
+metalakeName,
Lists.newArrayList(Privileges.CreateCatalog.allow()));
+Role role = metalake.createRole(roleName, properties,
Lists.newArrayList(metalakeObject));
+
+Assertions.assertEquals(roleName, role.
Re: [PR] [#3232] fix(client): Fix the deleting role issues with irregular name [gravitino]
jerryshao commented on code in PR #4501:
URL: https://github.com/apache/gravitino/pull/4501#discussion_r1716793421
##
common/src/main/java/org/apache/gravitino/dto/authorization/SecurableObjectDTO.java:
##
@@ -31,44 +31,41 @@
/** Data transfer object representing a securable object. */
public class SecurableObjectDTO implements SecurableObject {
- @JsonProperty("fullName")
- private String fullName;
-
@JsonProperty("type")
private Type type;
@JsonProperty("privileges")
private PrivilegeDTO[] privileges;
- private String parent;
- private String name;
-
- /** Default constructor for Jackson deserialization. */
- protected SecurableObjectDTO() {}
+ /** @return The full name of the securable object. */
+ @JsonProperty("fullName")
+ public String getFullName() {
+return fullName();
+ }
/**
- * Creates a new instance of SecurableObject DTO.
+ * Sets the full name of the securable object. Only used by Jackson
deserializer.
*
- * @param privileges The privileges of the SecurableObject DTO.
- * @param fullName The name of the SecurableObject DTO.
- * @param type The type of the securable object.
+ * @param fullName The full name of the metadata object.
*/
- protected SecurableObjectDTO(String fullName, Type type, PrivilegeDTO[]
privileges) {
-this.type = type;
-this.fullName = fullName;
+ @JsonProperty("fullName")
+ public void setFullName(String fullName) {
int index = fullName.lastIndexOf(".");
-
if (index == -1) {
- this.parent = null;
- this.name = fullName;
+ parent = null;
+ name = fullName;
} else {
- this.parent = fullName.substring(0, index);
- this.name = fullName.substring(index + 1);
+ parent = fullName.substring(0, index);
+ name = fullName.substring(index + 1);
}
-
-this.privileges = privileges;
}
+ private String parent;
+ private String name;
+
+ /** Default constructor for Jackson deserialization. */
+ protected SecurableObjectDTO() {}
Review Comment:
Why don't you move these lines to the top of the class?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] [#3232] fix(client): Fix the deleting role issues with irregular name [gravitino]
jerqi commented on code in PR #4501:
URL: https://github.com/apache/gravitino/pull/4501#discussion_r1716790361
##
common/src/main/java/org/apache/gravitino/dto/authorization/SecurableObjectDTO.java:
##
@@ -31,44 +31,41 @@
/** Data transfer object representing a securable object. */
public class SecurableObjectDTO implements SecurableObject {
- @JsonProperty("fullName")
- private String fullName;
-
@JsonProperty("type")
private Type type;
@JsonProperty("privileges")
private PrivilegeDTO[] privileges;
- private String parent;
- private String name;
-
- /** Default constructor for Jackson deserialization. */
- protected SecurableObjectDTO() {}
+ /** @return The full name of the securable object. */
+ @JsonProperty("fullName")
+ public String getFullName() {
+return fullName();
+ }
/**
- * Creates a new instance of SecurableObject DTO.
+ * Sets the full name of the securable object. Only used by Jackson
deserializer.
*
- * @param privileges The privileges of the SecurableObject DTO.
- * @param fullName The name of the SecurableObject DTO.
- * @param type The type of the securable object.
+ * @param fullName The full name of the metadata object.
*/
- protected SecurableObjectDTO(String fullName, Type type, PrivilegeDTO[]
privileges) {
-this.type = type;
-this.fullName = fullName;
+ @JsonProperty("fullName")
+ public void setFullName(String fullName) {
int index = fullName.lastIndexOf(".");
-
if (index == -1) {
- this.parent = null;
- this.name = fullName;
+ parent = null;
+ name = fullName;
} else {
- this.parent = fullName.substring(0, index);
- this.name = fullName.substring(index + 1);
+ parent = fullName.substring(0, index);
+ name = fullName.substring(index + 1);
Review Comment:
I removed the constructor method. This is method `setFullName`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] [#3232] fix(client): Fix the deleting role issues with irregular name [gravitino]
jerryshao commented on code in PR #4501:
URL: https://github.com/apache/gravitino/pull/4501#discussion_r1716784575
##
common/src/main/java/org/apache/gravitino/dto/authorization/SecurableObjectDTO.java:
##
@@ -31,44 +31,41 @@
/** Data transfer object representing a securable object. */
public class SecurableObjectDTO implements SecurableObject {
- @JsonProperty("fullName")
- private String fullName;
-
@JsonProperty("type")
private Type type;
@JsonProperty("privileges")
private PrivilegeDTO[] privileges;
- private String parent;
- private String name;
-
- /** Default constructor for Jackson deserialization. */
- protected SecurableObjectDTO() {}
+ /** @return The full name of the securable object. */
+ @JsonProperty("fullName")
+ public String getFullName() {
+return fullName();
+ }
/**
- * Creates a new instance of SecurableObject DTO.
+ * Sets the full name of the securable object. Only used by Jackson
deserializer.
*
- * @param privileges The privileges of the SecurableObject DTO.
- * @param fullName The name of the SecurableObject DTO.
- * @param type The type of the securable object.
+ * @param fullName The full name of the metadata object.
*/
- protected SecurableObjectDTO(String fullName, Type type, PrivilegeDTO[]
privileges) {
-this.type = type;
-this.fullName = fullName;
+ @JsonProperty("fullName")
+ public void setFullName(String fullName) {
int index = fullName.lastIndexOf(".");
-
if (index == -1) {
- this.parent = null;
- this.name = fullName;
+ parent = null;
+ name = fullName;
} else {
- this.parent = fullName.substring(0, index);
- this.name = fullName.substring(index + 1);
+ parent = fullName.substring(0, index);
+ name = fullName.substring(index + 1);
Review Comment:
Why do you remove `this.` in here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] [#3232] fix(client): Fix the deleting role issues with irregular name [gravitino]
jerqi commented on code in PR #4501:
URL: https://github.com/apache/gravitino/pull/4501#discussion_r1716429331
##
common/src/main/java/org/apache/gravitino/dto/authorization/SecurableObjectDTO.java:
##
@@ -31,44 +31,41 @@
/** Data transfer object representing a securable object. */
public class SecurableObjectDTO implements SecurableObject {
- @JsonProperty("fullName")
Review Comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] [#3232] fix(client): Fix the deleting role issues with irregular name [gravitino]
FANNG1 commented on code in PR #4501:
URL: https://github.com/apache/gravitino/pull/4501#discussion_r1716415235
##
common/src/main/java/org/apache/gravitino/dto/authorization/SecurableObjectDTO.java:
##
@@ -31,44 +31,41 @@
/** Data transfer object representing a securable object. */
public class SecurableObjectDTO implements SecurableObject {
- @JsonProperty("fullName")
Review Comment:
The PR has mixed fixing, could you add more contexts in `What changes were
proposed in this pull request` ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] [#3232] fix(client): Fix the deleting role issues with irregular name [gravitino]
jerqi commented on PR #4501: URL: https://github.com/apache/gravitino/pull/4501#issuecomment-2287948247 > Should we have some constraints on the user&group&role names? Yes, we can create an issue to track it. But we can discuss further. For this issue, some companies have used the roles with irregular names.So I want to fix this first. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] [#3232] fix(client): Fix the deleting role issues with irregular name [gravitino]
jerqi commented on code in PR #4501:
URL: https://github.com/apache/gravitino/pull/4501#discussion_r1716367087
##
common/src/main/java/org/apache/gravitino/dto/authorization/SecurableObjectDTO.java:
##
@@ -31,44 +31,41 @@
/** Data transfer object representing a securable object. */
public class SecurableObjectDTO implements SecurableObject {
- @JsonProperty("fullName")
Review Comment:
When I added the e2e tests, I find an issue. So I fix it by the way.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] [#3232] fix(client): Fix the deleting role issues with irregular name [gravitino]
FANNG1 commented on PR #4501: URL: https://github.com/apache/gravitino/pull/4501#issuecomment-2287805949 Should we have some constraints on the user&group&role names? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] [#3232] fix(client): Fix the deleting role issues with irregular name [gravitino]
FANNG1 commented on code in PR #4501:
URL: https://github.com/apache/gravitino/pull/4501#discussion_r1716272070
##
common/src/main/java/org/apache/gravitino/dto/authorization/SecurableObjectDTO.java:
##
@@ -31,44 +31,41 @@
/** Data transfer object representing a securable object. */
public class SecurableObjectDTO implements SecurableObject {
- @JsonProperty("fullName")
Review Comment:
why changing this class?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
