Re: [PR] [#34] add Gravitino Spark connector to playground [gravitino-playground]
yuqi1129 merged PR #45: URL: https://github.com/apache/gravitino-playground/pull/45 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] [#34] add Gravitino Spark connector to playground [gravitino-playground]
FANNG1 commented on code in PR #45: URL: https://github.com/apache/gravitino-playground/pull/45#discussion_r1735627733 ## README.md: ## @@ -75,17 +75,31 @@ docker exec -it playground-trino bash trino@container_id:/$ trino ``` -### Using Jupiter Notebook +## Using Jupiter Notebook Review Comment: done -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] [#34] add Gravitino Spark connector to playground [gravitino-playground]
jerqi commented on code in PR #45: URL: https://github.com/apache/gravitino-playground/pull/45#discussion_r1735620756 ## README.md: ## @@ -75,17 +75,31 @@ docker exec -it playground-trino bash trino@container_id:/$ trino ``` -### Using Jupiter Notebook +## Using Jupiter Notebook Review Comment: Jupyter -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] [#34] add Gravitino Spark connector to playground [gravitino-playground]
FANNG1 commented on PR #45: URL: https://github.com/apache/gravitino-playground/pull/45#issuecomment-2316742333 @jerqi , I have tested spark trino and Iceberg REST service part, please help to review again -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] [#34] add Gravitino Spark connector to playground [gravitino-playground]
FANNG1 commented on code in PR #45: URL: https://github.com/apache/gravitino-playground/pull/45#discussion_r1732892912 ## init/gravitino/gravitino.conf: ## @@ -67,3 +67,4 @@ gravitino.auxService.iceberg-rest.warehouse = hdfs://hive:9000/user/iceberg/ware gravitino.auxService.iceberg-rest.jdbc.user = mysql gravitino.auxService.iceberg-rest.jdbc.password = mysql gravitino.auxService.iceberg-rest.jdbc-driver = com.mysql.cj.jdbc.Driver +gravitino.auxService.iceberg-rest.catalog-backend-name = catalog_iceberg Review Comment: let REST catalog use the same catalog name with Gravitino Iceberg catalog, so they could query same table. cc @jerqi -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] [#34] add Gravitino Spark connector to playground [gravitino-playground]
FANNG1 commented on PR #45: URL: https://github.com/apache/gravitino-playground/pull/45#issuecomment-2296214111 > Will it influence the demo of Iceberg REST catalog? Is it clear for user to use Spark connector and REST service catalog. It is a confusing for user. The original document makes Spark and Trino use same catalog name `iceberg_catalog`, but they are different, maybe we could add some comment to tell user `iceberg_catalog` and `rest_catalog` refer to the same underlying catalog, WDYT? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] [#34] add Gravitino Spark connector to playground [gravitino-playground]
jerqi commented on PR #45: URL: https://github.com/apache/gravitino-playground/pull/45#issuecomment-2296099930 You should submit the document to the main repo, too. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] [#34] add Gravitino Spark connector to playground [gravitino-playground]
jerqi commented on PR #45: URL: https://github.com/apache/gravitino-playground/pull/45#issuecomment-2274896145 Will it influence the demo of Iceberg REST catalog? Is it clear for user to use Spark connector and REST service catalog. It is a confusing for user. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] [#34] add Gravitino Spark connector to playground [gravitino-playground]
FANNG1 commented on code in PR #45: URL: https://github.com/apache/gravitino-playground/pull/45#discussion_r1708534154 ## init/spark/init.sh: ## @@ -4,5 +4,8 @@ # mkdir -p /opt/spark/conf cp /tmp/spark/spark-defaults.conf /opt/spark/conf -wget https://repo1.maven.org/maven2/org/apache/iceberg/iceberg-spark-runtime-3.4_2.12/1.3.1/iceberg-spark-runtime-3.4_2.12-1.3.1.jar -O /opt/spark/jars/iceberg-spark-runtime-3.4_2.12-1.3.1.jar Review Comment: ok, any other comments? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] [#34] add Gravitino Spark connector to playground [gravitino-playground]
jerqi commented on code in PR #45: URL: https://github.com/apache/gravitino-playground/pull/45#discussion_r1708531197 ## init/spark/init.sh: ## @@ -4,5 +4,8 @@ # mkdir -p /opt/spark/conf cp /tmp/spark/spark-defaults.conf /opt/spark/conf -wget https://repo1.maven.org/maven2/org/apache/iceberg/iceberg-spark-runtime-3.4_2.12/1.3.1/iceberg-spark-runtime-3.4_2.12-1.3.1.jar -O /opt/spark/jars/iceberg-spark-runtime-3.4_2.12-1.3.1.jar Review Comment: Maybe we should merge this pull request after we release the 0.6.0. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] [#34] add Gravitino Spark connector to playground [gravitino-playground]
FANNG1 commented on PR #45: URL: https://github.com/apache/gravitino-playground/pull/45#issuecomment-2270977993 @jerqi , update the document, please help to review again -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
