Re: [PR] [#3758] Improvement(PyGVFS): Support OAuth2 authentication in Python GVFS [gravitino]
jerryshao merged PR #5030: URL: https://github.com/apache/gravitino/pull/5030 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] [#3758] Improvement(PyGVFS): Support OAuth2 authentication in Python GVFS [gravitino]
xloya commented on code in PR #5030: URL: https://github.com/apache/gravitino/pull/5030#discussion_r1792736506 ## docs/how-to-use-gvfs.md: ## @@ -538,7 +542,7 @@ print(documents) ### Authentication -Currently, Gravitino Virtual File System in Python only supports one kind of authentication types to access Gravitino server: `simple`. +Currently, Gravitino Virtual File System in Python supports two kinds of authentication types to access Gravitino server: `simple` and `oatuh2`. Review Comment: Done -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] [#3758] Improvement(PyGVFS): Support OAuth2 authentication in Python GVFS [gravitino]
jerqi commented on code in PR #5030: URL: https://github.com/apache/gravitino/pull/5030#discussion_r1792719168 ## docs/how-to-use-gvfs.md: ## @@ -538,7 +542,7 @@ print(documents) ### Authentication -Currently, Gravitino Virtual File System in Python only supports one kind of authentication types to access Gravitino server: `simple`. +Currently, Gravitino Virtual File System in Python supports two kinds of authentication types to access Gravitino server: `simple` and `oatuh2`. Review Comment: `oathu2` -> `oauth2`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] [#3758] Improvement(PyGVFS): Support Oauth2 authentication in Python GVFS [gravitino]
jerqi commented on code in PR #5030:
URL: https://github.com/apache/gravitino/pull/5030#discussion_r1779891468
##
clients/client-python/gravitino/filesystem/gvfs.py:
##
@@ -362,11 +395,19 @@ def open(
:param kwargs: Extra args
:return A file-like object from the filesystem
"""
-context: FilesetContext = self._get_fileset_context(path)
-return context.get_fs().open(
-self._strip_storage_protocol(
-context.get_storage_type(), context.get_actual_path()
-),
+if mode.startswith("w"):
Review Comment:
What's the format of the mode? It could be `rw`?
##
clients/client-python/gravitino/filesystem/gvfs.py:
##
@@ -118,6 +104,31 @@ def __init__(
metalake_name=metalake_name,
auth_data_provider=SimpleAuthProvider(),
)
+elif auth_type == GVFSConfig.OAUTH2_AUTH_TYPE:
Review Comment:
The code above should be `auth_type == GVFSConfig.SIMPLE_AUTH_TYPE`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] [#3758] Improvement(PyGVFS): Support Oauth2 authentication in Python GVFS [gravitino]
jerqi commented on PR #5030: URL: https://github.com/apache/gravitino/pull/5030#issuecomment-2381068460 Could you correct your typo about Oauth? It should be OAuth. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] [#3758] Improvement(PyGVFS): Support Oauth2 authentication in Python GVFS [gravitino]
jerryshao commented on PR #5030: URL: https://github.com/apache/gravitino/pull/5030#issuecomment-2379043954 @jerqi would you please help to review this PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
