Re: [PR] [#5665] fect(auth): Underlying datasource authorization privilege abstraction [gravitino]
xunliu commented on code in PR #5674:
URL: https://github.com/apache/gravitino/pull/5674#discussion_r1860306415
##
core/src/main/java/org/apache/gravitino/authorization/AuthorizationPrivilege.java:
##
@@ -16,12 +16,10 @@
* specific language governing permissions and limitations
* under the License.
*/
-package org.apache.gravitino.authorization.ranger;
+package org.apache.gravitino.authorization;
-import org.apache.gravitino.authorization.Privilege;
-
-/** RangerPrivilege interface is used to define the Ranger privileges. */
-public interface RangerPrivilege {
+/** AuthorizationPrivilege interface is used to define the underlying data
source privileges. */
+public interface AuthorizationPrivilege {
String getName();
Privilege.Condition condition();
Review Comment:
Because we are only needs compare AuthorizationPrivilege.name.
##
core/src/main/java/org/apache/gravitino/authorization/AuthorizationMetadataObject.java:
##
@@ -0,0 +1,111 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.gravitino.authorization;
+
+import com.google.common.base.Joiner;
+import com.google.common.base.Preconditions;
+import com.google.common.base.Splitter;
+import java.util.List;
+import javax.annotation.Nullable;
+import org.apache.gravitino.MetadataObject;
+
+/**
+ * AuthorizationMetadataObject interface is used to define the underlying data
source metadata
+ * object.
+ */
+public interface AuthorizationMetadataObject {
Review Comment:
This PR only reorganization structure, So we didn't change any codes.
##
core/src/main/java/org/apache/gravitino/authorization/AuthorizationPrivilegesMappingProvider.java:
##
@@ -0,0 +1,83 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.gravitino.authorization;
+
+import java.util.List;
+import java.util.Map;
+import java.util.Set;
+import org.apache.gravitino.MetadataObject;
+
+/**
+ * Authorization use this provider to mapping Gravitino privilege to the
underlying data source
+ * privileges. We can use this it to support the different data source, such
as Hive, HDFS, HBase,
+ * etc.
+ */
+public interface AuthorizationPrivilegesMappingProvider {
+ /**
+ * Set the mapping Gravitino privilege name to the underlying data source
privileges rule.
+ *
+ * @return The mapping Gravitino privilege name to the underlying data
source privileges rule.
+ */
+ Map> privilegesMappingRule();
+
+ /**
+ * Set the owner underlying data source privileges rule.
+ *
+ * @return The owner underlying data source privileges rule.
+ */
+ Set ownerMappingRule();
+
+ /**
+ * Allow Gravitino privilege operation defines rule.
+ *
+ * @return The allow Gravitino privilege operation defines rule.
+ */
+ Set allowPrivilegesRule();
+
+ /**
+ * Allow Gravitino MetadataObject type defines rule.
+ *
+ * @return To allow Gravitino MetadataObject type defines rule.
+ */
+ Set allowMetadataObjectTypesRule();
+
+ /**
+ * Translate the Gravitino securable object to the underlying data source
securable object.
+ *
+ * @param securableObject The Gravitino securable object.
+ * @return The underlying data source securable object list.
+ */
+ List translatePrivilege(SecurableObject
securableObject);
+
+ /**
+ * Translate the Gravitino securable object to the underlying data source
owner securable object.
+ *
+ * @param metada
Re: [PR] [#5665] fect(auth): Underlying datasource authorization privilege abstraction [gravitino]
jerqi commented on PR #5674: URL: https://github.com/apache/gravitino/pull/5674#issuecomment-2503386915 LGTM If we don't change any code. You should fix the typo `fect` -> `improvement` or `refactor`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@gravitino.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [#5665] fect(auth): Underlying datasource authorization privilege abstraction [gravitino]
jerqi commented on code in PR #5674:
URL: https://github.com/apache/gravitino/pull/5674#discussion_r1860288086
##
core/src/main/java/org/apache/gravitino/authorization/AuthorizationPrivilegesMappingProvider.java:
##
@@ -0,0 +1,83 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.gravitino.authorization;
+
+import java.util.List;
+import java.util.Map;
+import java.util.Set;
+import org.apache.gravitino.MetadataObject;
+
+/**
+ * Authorization use this provider to mapping Gravitino privilege to the
underlying data source
+ * privileges. We can use this it to support the different data source, such
as Hive, HDFS, HBase,
+ * etc.
+ */
+public interface AuthorizationPrivilegesMappingProvider {
+ /**
+ * Set the mapping Gravitino privilege name to the underlying data source
privileges rule.
+ *
+ * @return The mapping Gravitino privilege name to the underlying data
source privileges rule.
+ */
+ Map> privilegesMappingRule();
+
+ /**
+ * Set the owner underlying data source privileges rule.
+ *
+ * @return The owner underlying data source privileges rule.
+ */
+ Set ownerMappingRule();
+
+ /**
+ * Allow Gravitino privilege operation defines rule.
+ *
+ * @return The allow Gravitino privilege operation defines rule.
+ */
+ Set allowPrivilegesRule();
+
+ /**
+ * Allow Gravitino MetadataObject type defines rule.
+ *
+ * @return To allow Gravitino MetadataObject type defines rule.
+ */
+ Set allowMetadataObjectTypesRule();
+
+ /**
+ * Translate the Gravitino securable object to the underlying data source
securable object.
+ *
+ * @param securableObject The Gravitino securable object.
+ * @return The underlying data source securable object list.
+ */
+ List translatePrivilege(SecurableObject
securableObject);
+
+ /**
+ * Translate the Gravitino securable object to the underlying data source
owner securable object.
+ *
+ * @param metadataObject The Gravitino metadata object.
+ * @return The underlying data source owner securable object list.
+ */
+ List translateOwner(MetadataObject
metadataObject);
+
+ /**
+ * Translate the Gravitino metadata object to the underlying data source
metadata object.
+ *
+ * @param metadataObject The Gravitino metadata object.
+ * @return The underlying data source metadata object.
+ */
+ AuthorizationMetadataObject translateMetadataObject(MetadataObject
metadataObject);
Review Comment:
Maybe we should use a mapping between `MetadataObject` and
`AuthorizationMetadataObject`. Maybe a meta data object should return a list of
authorization objects.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@gravitino.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] [#5665] fect(auth): Underlying datasource authorization privilege abstraction [gravitino]
jerqi commented on code in PR #5674:
URL: https://github.com/apache/gravitino/pull/5674#discussion_r1860282998
##
core/src/main/java/org/apache/gravitino/authorization/AuthorizationPrivilegesMappingProvider.java:
##
@@ -0,0 +1,83 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.gravitino.authorization;
+
+import java.util.List;
+import java.util.Map;
+import java.util.Set;
+import org.apache.gravitino.MetadataObject;
+
+/**
+ * Authorization use this provider to mapping Gravitino privilege to the
underlying data source
+ * privileges. We can use this it to support the different data source, such
as Hive, HDFS, HBase,
+ * etc.
+ */
+public interface AuthorizationPrivilegesMappingProvider {
+ /**
+ * Set the mapping Gravitino privilege name to the underlying data source
privileges rule.
+ *
+ * @return The mapping Gravitino privilege name to the underlying data
source privileges rule.
+ */
+ Map> privilegesMappingRule();
Review Comment:
How about `privilegesMapping` instead of `privilegesMappingRule`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@gravitino.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] [#5665] fect(auth): Underlying datasource authorization privilege abstraction [gravitino]
jerqi commented on code in PR #5674:
URL: https://github.com/apache/gravitino/pull/5674#discussion_r1858302284
##
core/src/main/java/org/apache/gravitino/authorization/AuthorizationMetadataObject.java:
##
@@ -0,0 +1,111 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.gravitino.authorization;
+
+import com.google.common.base.Joiner;
+import com.google.common.base.Preconditions;
+import com.google.common.base.Splitter;
+import java.util.List;
+import javax.annotation.Nullable;
+import org.apache.gravitino.MetadataObject;
+
+/**
+ * AuthorizationMetadataObject interface is used to define the underlying data
source metadata
+ * object.
+ */
+public interface AuthorizationMetadataObject {
Review Comment:
Is this the internal resource in our system? How to present a location?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@gravitino.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] [#5665] fect(auth): Underlying datasource authorization privilege abstraction [gravitino]
jerqi commented on code in PR #5674:
URL: https://github.com/apache/gravitino/pull/5674#discussion_r1858300605
##
core/src/main/java/org/apache/gravitino/authorization/AuthorizationPrivilege.java:
##
@@ -16,12 +16,10 @@
* specific language governing permissions and limitations
* under the License.
*/
-package org.apache.gravitino.authorization.ranger;
+package org.apache.gravitino.authorization;
-import org.apache.gravitino.authorization.Privilege;
-
-/** RangerPrivilege interface is used to define the Ranger privileges. */
-public interface RangerPrivilege {
+/** AuthorizationPrivilege interface is used to define the underlying data
source privileges. */
+public interface AuthorizationPrivilege {
String getName();
Privilege.Condition condition();
Review Comment:
Why do need the method `equalsTo` instead of `Object::equals`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@gravitino.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
