Re: [PR] [#5724] fix(bug): testCatalogDetailsCommand() failed in the CI [gravitino]
mchades merged PR #5725: URL: https://github.com/apache/gravitino/pull/5725 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] [#5724] fix(bug): testCatalogDetailsCommand() failed in the CI [gravitino]
xunliu commented on code in PR #5725:
URL: https://github.com/apache/gravitino/pull/5725#discussion_r1867169260
##
clients/cli/build.gradle.kts:
##
@@ -67,3 +67,14 @@ tasks.jar {
from(dependencies)
duplicatesStrategy = DuplicatesStrategy.EXCLUDE
}
+
+tasks.test {
+ val skipITs = project.hasProperty("skipITs")
+ if (skipITs) {
+// Exclude integration tests
+exclude("**/integration/test/**")
+ } else {
+dependsOn(tasks.jar)
Review Comment:
hi @mchades
We need to add this depends,
because clients-cli need to compile a `Main-Class` jar.
https://github.com/apache/gravitino/blob/main/clients/cli/build.gradle.kts#L59
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] [#5724] fix(bug): testCatalogDetailsCommand() failed in the CI [gravitino]
xunliu commented on code in PR #5725:
URL: https://github.com/apache/gravitino/pull/5725#discussion_r1867167082
##
clients/cli/build.gradle.kts:
##
@@ -67,3 +67,14 @@ tasks.jar {
from(dependencies)
duplicatesStrategy = DuplicatesStrategy.EXCLUDE
}
+
+tasks.test {
+ val skipITs = project.hasProperty("skipITs")
+ if (skipITs) {
+// Exclude integration tests
+exclude("**/integration/test/**")
+ } else {
+dependsOn(tasks.jar)
+dependsOn(":catalogs:catalog-jdbc-postgresql:jar",
":catalogs:catalog-jdbc-postgresql:runtimeJars")
Review Comment:
We only use `catalog-jdbc-postgresql` to run the integration test.
We didn't need support from many different catalogs to test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] [#5724] fix(bug): testCatalogDetailsCommand() failed in the CI [gravitino]
yuqi1129 commented on code in PR #5725:
URL: https://github.com/apache/gravitino/pull/5725#discussion_r1867108266
##
clients/cli/build.gradle.kts:
##
@@ -67,3 +67,14 @@ tasks.jar {
from(dependencies)
duplicatesStrategy = DuplicatesStrategy.EXCLUDE
}
+
+tasks.test {
+ val skipITs = project.hasProperty("skipITs")
+ if (skipITs) {
+// Exclude integration tests
+exclude("**/integration/test/**")
+ } else {
+dependsOn(tasks.jar)
+dependsOn(":catalogs:catalog-jdbc-postgresql:jar",
":catalogs:catalog-jdbc-postgresql:runtimeJars")
Review Comment:
Why does it only depends on `jdbc-postgresql`,do we need to add `jdbc-mysql`
here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] [#5724] fix(bug): testCatalogDetailsCommand() failed in the CI [gravitino]
mchades commented on code in PR #5725:
URL: https://github.com/apache/gravitino/pull/5725#discussion_r1867105491
##
clients/cli/build.gradle.kts:
##
@@ -67,3 +67,14 @@ tasks.jar {
from(dependencies)
duplicatesStrategy = DuplicatesStrategy.EXCLUDE
}
+
+tasks.test {
+ val skipITs = project.hasProperty("skipITs")
+ if (skipITs) {
+// Exclude integration tests
+exclude("**/integration/test/**")
+ } else {
+dependsOn(tasks.jar)
Review Comment:
unnecessary?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] [#5724] fix(bug): testCatalogDetailsCommand() failed in the CI [gravitino]
mchades commented on code in PR #5725:
URL: https://github.com/apache/gravitino/pull/5725#discussion_r1867103105
##
clients/cli/build.gradle.kts:
##
@@ -67,3 +67,14 @@ tasks.jar {
from(dependencies)
duplicatesStrategy = DuplicatesStrategy.EXCLUDE
}
+
+tasks.test {
+ val skipITs = project.hasProperty("skipITs")
+ if (skipITs) {
+// Exclude integration tests
+exclude("**/integration/test/**")
+ } else {
+dependsOn(tasks.jar)
+dependsOn(":catalogs:catalog-jdbc-postgresql:jar",
":catalogs:catalog-jdbc-postgresql:runtimeJars")
Review Comment:
FYI:
https://github.com/apache/gravitino/blob/986af9279caab991a9a5b51eec7a3507ef723b78/clients/client-java/build.gradle.kts#L60-L61
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] [#5724] fix(bug): testCatalogDetailsCommand() failed in the CI [gravitino]
mchades commented on code in PR #5725:
URL: https://github.com/apache/gravitino/pull/5725#discussion_r1867103105
##
clients/cli/build.gradle.kts:
##
@@ -67,3 +67,14 @@ tasks.jar {
from(dependencies)
duplicatesStrategy = DuplicatesStrategy.EXCLUDE
}
+
+tasks.test {
+ val skipITs = project.hasProperty("skipITs")
+ if (skipITs) {
+// Exclude integration tests
+exclude("**/integration/test/**")
+ } else {
+dependsOn(tasks.jar)
+dependsOn(":catalogs:catalog-jdbc-postgresql:jar",
":catalogs:catalog-jdbc-postgresql:runtimeJars")
Review Comment:
FYI:
https://github.com/apache/gravitino/blob/986af9279caab991a9a5b51eec7a3507ef723b78/clients/client-java/build.gradle.kts#L60-L61
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] [#5724] fix(bug): testCatalogDetailsCommand() failed in the CI [gravitino]
xunliu commented on PR #5725: URL: https://github.com/apache/gravitino/pull/5725#issuecomment-2513585125 @mchades Please help me review this PR, Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
