Re: [PR] [#9506][followup] improvement(authz): Add GCS integration tests for fileset credential vending [gravitino]
jerqi merged PR #9552: URL: https://github.com/apache/gravitino/pull/9552 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] [#9506][followup] improvement(authz): Add GCS integration tests for fileset credential vending [gravitino]
yuqi1129 commented on PR #9552: URL: https://github.com/apache/gravitino/pull/9552#issuecomment-3691924772 > > > . > > > > > > Does @danhuawang have the accounts? > > Danhua doesn't have the account. I see, and the current changes LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] [#9506][followup] improvement(authz): Add GCS integration tests for fileset credential vending [gravitino]
jerqi commented on PR #9552: URL: https://github.com/apache/gravitino/pull/9552#issuecomment-3691923506 > > . > > Does @danhuawang have the accounts? Danhua doesn't have the account. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] [#9506][followup] improvement(authz): Add GCS integration tests for fileset credential vending [gravitino]
yuqi1129 commented on PR #9552: URL: https://github.com/apache/gravitino/pull/9552#issuecomment-3691898566 > . Does @danhuawang have the accounts? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] [#9506][followup] improvement(authz): Add GCS integration tests for fileset credential vending [gravitino]
jerqi commented on PR #9552: URL: https://github.com/apache/gravitino/pull/9552#issuecomment-3691228355 > @jerqi What about OSS and Azure Cloud Storage? Will you submit corresponding changes in separate PRs? I don't have resource to test them. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] [#9506][followup] improvement(authz): Add GCS integration tests for fileset credential vending [gravitino]
yuqi1129 commented on PR #9552: URL: https://github.com/apache/gravitino/pull/9552#issuecomment-3691199801 @jerqi What about OSS and Azure Cloud Storage? Will you submit corresponding changes in separate PRs? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] [#9506][followup] improvement(authz): Add GCS integration tests for fileset credential vending [gravitino]
jerqi commented on code in PR #9552:
URL: https://github.com/apache/gravitino/pull/9552#discussion_r2646734633
##
clients/filesystem-hadoop3/src/test/java/org/apache/gravitino/filesystem/hadoop/integration/test/AbstractFileSystemCredentialAuthorizationIT.java:
##
@@ -196,9 +173,10 @@ public void tearDown() throws IOException {
}
}
+ // Public tests
Review Comment:
I can remove these.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] [#9506][followup] improvement(authz): Add GCS integration tests for fileset credential vending [gravitino]
yuqi1129 commented on code in PR #9552:
URL: https://github.com/apache/gravitino/pull/9552#discussion_r2646617147
##
clients/filesystem-hadoop3/src/test/java/org/apache/gravitino/filesystem/hadoop/integration/test/AbstractFileSystemCredentialAuthorizationIT.java:
##
@@ -196,9 +173,10 @@ public void tearDown() throws IOException {
}
}
+ // Public tests
Review Comment:
What do you mean by `Public tests` here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
