Re: [PR] [MINOR] docs: Polish Gravitino Flink connector document [gravitino]

2025-01-17 Thread via GitHub


jerryshao merged PR #6319:
URL: https://github.com/apache/gravitino/pull/6319


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



Re: [PR] [MINOR] docs: Polish Gravitino Flink connector document [gravitino]

2025-01-17 Thread via GitHub


FANNG1 closed pull request #6319: [MINOR] docs: Polish Gravitino Flink 
connector document
URL: https://github.com/apache/gravitino/pull/6319


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



Re: [PR] [MINOR] docs: Polish Gravitino Flink connector document [gravitino]

2025-01-17 Thread via GitHub


FANNG1 merged PR #6315:
URL: https://github.com/apache/gravitino/pull/6315


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



Re: [PR] [MINOR] docs: Polish Gravitino Flink connector document [gravitino]

2025-01-17 Thread via GitHub


FANNG1 commented on code in PR #6315:
URL: https://github.com/apache/gravitino/pull/6315#discussion_r1919760222


##
docs/flink-connector/flink-catalog-paimon.md:
##
@@ -32,27 +33,26 @@ Supports most DDL and DML operations in Flink SQL, except 
such operations:
 
 * Paimon 0.8
 
-Higher version like 0.9 or above may also supported but have not been tested 
fully.
+Higher version like 0.9 or above may also support but have not been tested 
fully.
 
 ## Getting Started
 
 ### Prerequisites
 
 Place the following JAR files in the lib directory of your Flink installation:
 
-* paimon-flink-1.18-0.8.2.jar
-
-* gravitino-flink-connector-runtime-\${flinkMajorVersion}_$scalaVersion.jar
+- `paimon-flink-1.18-{paimon-version}.jar`

Review Comment:
   updated



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



Re: [PR] [MINOR] docs: Polish Gravitino Flink connector document [gravitino]

2025-01-17 Thread via GitHub


jerryshao commented on code in PR #6315:
URL: https://github.com/apache/gravitino/pull/6315#discussion_r1919752726


##
docs/flink-connector/flink-catalog-paimon.md:
##
@@ -32,27 +33,26 @@ Supports most DDL and DML operations in Flink SQL, except 
such operations:
 
 * Paimon 0.8
 
-Higher version like 0.9 or above may also supported but have not been tested 
fully.
+Higher version like 0.9 or above may also support but have not been tested 
fully.
 
 ## Getting Started
 
 ### Prerequisites
 
 Place the following JAR files in the lib directory of your Flink installation:
 
-* paimon-flink-1.18-0.8.2.jar
-
-* gravitino-flink-connector-runtime-\${flinkMajorVersion}_$scalaVersion.jar
+- `paimon-flink-1.18-{paimon-version}.jar`

Review Comment:
   Do you want to add `$` here also like the below line. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]