[jira] [Commented] (GUACAMOLE-688) Docker Version ldap-user-search-filter is missing
[ https://issues.apache.org/jira/browse/GUACAMOLE-688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16738468#comment-16738468 ] Jörn Lentes commented on GUACAMOLE-688: --- I have created a pull request for this: https://github.com/apache/guacamole-client/pull/354 > Docker Version ldap-user-search-filter is missing > - > > Key: GUACAMOLE-688 > URL: https://issues.apache.org/jira/browse/GUACAMOLE-688 > Project: Guacamole > Issue Type: Improvement > Components: guacamole-docker >Affects Versions: 0.9.14 >Reporter: Harald Fielker >Priority: Minor > > "ldap-user-search-filter" is missing as Enviormnent Variable in > > [https://github.com/apache/guacamole-client/blob/78f1ae1b4eac25501d532ddee94fd1d8588e56dc/guacamole-docker/bin/start.sh] > > Please add this to the section in the start.sh file > set_optional_property \ > "ldap-user-search-filter" \ > "$LDAP_USER_SEARCH_FILTER" > > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (GUACAMOLE-688) Docker Version ldap-user-search-filter is missing
[ https://issues.apache.org/jira/browse/GUACAMOLE-688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16735334#comment-16735334 ] Harald Fielker commented on GUACAMOLE-688: -- Thank you for your answer. I will consider this. > Docker Version ldap-user-search-filter is missing > - > > Key: GUACAMOLE-688 > URL: https://issues.apache.org/jira/browse/GUACAMOLE-688 > Project: Guacamole > Issue Type: Improvement > Components: guacamole-docker >Affects Versions: 0.9.14 >Reporter: Harald Fielker >Priority: Minor > > "ldap-user-search-filter" is missing as Enviormnent Variable in > > [https://github.com/apache/guacamole-client/blob/78f1ae1b4eac25501d532ddee94fd1d8588e56dc/guacamole-docker/bin/start.sh] > > Please add this to the section in the start.sh file > set_optional_property \ > "ldap-user-search-filter" \ > "$LDAP_USER_SEARCH_FILTER" > > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (GUACAMOLE-688) Docker Version ldap-user-search-filter is missing
[
https://issues.apache.org/jira/browse/GUACAMOLE-688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16735333#comment-16735333
]
Michael Jumper commented on GUACAMOLE-688:
--
[~HaraldFielker], if you would like to contribute, please open a pull request.
From [https://github.com/apache/guacamole-client/blob/master/CONTRIBUTING]:
{quote}
{code:none}
...
2) Make and test your changes locally
The Guacamole source is maintained in git repositories hosted on GitHub:
https://github.com/apache/guacamole-client
https://github.com/apache/guacamole-manual
https://github.com/apache/guacamole-server
https://github.com/apache/guacamole-website
To make your changes, fork the applicable repositories and make commits
to a topic branch in your fork. Commits should be made in logical units
and must reference the JIRA issue number:
$ git commit -m "GUACAMOLE-123: High-level message describing the changes."
Avoid commits which cover multiple, distinct goals that could (and should)
be handled separately.
If you do not already have an account on GitHub, you will need to create
one before making your changes.
3) Submit your changes via a pull request on GitHub
Once your changes are ready, submit them by creating a pull request for
the corresponding topic branch you created when you began working on your
changes.
The Guacamole team will then review your changes and, if they pass review,
your changes will be merged.
{code}
{quote}
> Docker Version ldap-user-search-filter is missing
> -
>
> Key: GUACAMOLE-688
> URL: https://issues.apache.org/jira/browse/GUACAMOLE-688
> Project: Guacamole
> Issue Type: Improvement
> Components: guacamole-docker
>Affects Versions: 0.9.14
>Reporter: Harald Fielker
>Priority: Minor
>
> "ldap-user-search-filter" is missing as Enviormnent Variable in
>
> [https://github.com/apache/guacamole-client/blob/78f1ae1b4eac25501d532ddee94fd1d8588e56dc/guacamole-docker/bin/start.sh]
>
> Please add this to the section in the start.sh file
> set_optional_property \
> "ldap-user-search-filter" \
> "$LDAP_USER_SEARCH_FILTER"
>
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (GUACAMOLE-688) Docker Version ldap-user-search-filter is missing
[ https://issues.apache.org/jira/browse/GUACAMOLE-688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16735329#comment-16735329 ] Harald Fielker commented on GUACAMOLE-688: -- Add to line 318 in start.sh set_optional_property \ "ldap-user-search-filter" \ "$LDAP_USER_SEARCH_FILTER" > Docker Version ldap-user-search-filter is missing > - > > Key: GUACAMOLE-688 > URL: https://issues.apache.org/jira/browse/GUACAMOLE-688 > Project: Guacamole > Issue Type: Improvement > Components: guacamole-docker >Affects Versions: 0.9.14 >Reporter: Harald Fielker >Priority: Minor > > "ldap-user-search-filter" is missing as Enviormnent Variable in > > [https://github.com/apache/guacamole-client/blob/78f1ae1b4eac25501d532ddee94fd1d8588e56dc/guacamole-docker/bin/start.sh] > > Please add this to the section in the start.sh file > set_optional_property \ > "ldap-user-search-filter" \ > "$LDAP_USER_SEARCH_FILTER" > > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (GUACAMOLE-688) Docker Version ldap-user-search-filter is missing
[ https://issues.apache.org/jira/browse/GUACAMOLE-688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16735320#comment-16735320 ] Michael Jumper commented on GUACAMOLE-688: -- Contributions are very welcome, [~HaraldFielker]. If you've already prepared the required changes, how about opening a PR? https://github.com/apache/guacamole-client/blob/master/CONTRIBUTING > Docker Version ldap-user-search-filter is missing > - > > Key: GUACAMOLE-688 > URL: https://issues.apache.org/jira/browse/GUACAMOLE-688 > Project: Guacamole > Issue Type: Improvement > Components: guacamole-docker >Affects Versions: 0.9.14 >Reporter: Harald Fielker >Priority: Minor > > "ldap-user-search-filter" is missing as Enviormnent Variable in > > [https://github.com/apache/guacamole-client/blob/78f1ae1b4eac25501d532ddee94fd1d8588e56dc/guacamole-docker/bin/start.sh] > > Please add this to the section in the start.sh file > set_optional_property \ > "ldap-user-search-filter" \ > "$LDAP_USER_SEARCH_FILTER" > > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
