HBASE-20391 close out stale or finished PRs on github. * closes #51 - > 1 month since notification * closes #61 - HBASE-18928 has already closed * closes #62 - HBASE-18929 has already closed * closes #67 - HBASE-19386 has already closed * closes #68 - HBASE-19387 has already closed
Also adds a section to the committer guide in the reference guide about closing PRs. Signed-off-by: Mike Drob <md...@apache.org> Project: http://git-wip-us.apache.org/repos/asf/hbase/repo Commit: http://git-wip-us.apache.org/repos/asf/hbase/commit/a5408820 Tree: http://git-wip-us.apache.org/repos/asf/hbase/tree/a5408820 Diff: http://git-wip-us.apache.org/repos/asf/hbase/diff/a5408820 Branch: refs/heads/HBASE-19064 Commit: a5408820b58dd5b726e8f756b4fe66c101acd8f6 Parents: 8f1ac01 Author: Sean Busbey <bus...@apache.org> Authored: Wed Apr 11 16:30:56 2018 -0500 Committer: Sean Busbey <bus...@cloudera.com> Committed: Fri Apr 13 10:39:13 2018 -0500 ---------------------------------------------------------------------- src/main/asciidoc/_chapters/developer.adoc | 6 ++++++ 1 file changed, 6 insertions(+) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/hbase/blob/a5408820/src/main/asciidoc/_chapters/developer.adoc ---------------------------------------------------------------------- diff --git a/src/main/asciidoc/_chapters/developer.adoc b/src/main/asciidoc/_chapters/developer.adoc index 9d9f564..7cbf404 100644 --- a/src/main/asciidoc/_chapters/developer.adoc +++ b/src/main/asciidoc/_chapters/developer.adoc @@ -2177,6 +2177,12 @@ When the amending author is different from the original committer, add notice of - [DISCUSSION] Best practice when amending commits cherry picked from master to branch]. +====== Close related GitHub PRs + +As a project we work to ensure there's a JIRA associated with each change, but we don't mandate any particular tool be used for reviews. Due to implementation details of the ASF's integration between hosted git repositories and GitHub, the PMC has no ability to directly close PRs on our GitHub repo. In the event that a contributor makes a Pull Request on GitHub, either because the contributor finds that easier than attaching a patch to JIRA or because a reviewer prefers that UI for examining changes, it's important to make note of the PR in the commit that goes to the master branch so that PRs are kept up to date. + +To read more about the details of what kinds of commit messages will work with the GitHub "close via keyword in commit" mechanism see link:https://help.github.com/articles/closing-issues-using-keywords/[the GitHub documentation for "Closing issues using keywords"]. In summary, you should include a line with the phrase "closes #XXX", where the XXX is the pull request id. The pull request id is usually given in the GitHub UI in grey at the end of the subject heading. + [[committer.tests]] ====== Committers are responsible for making sure commits do not break the build or tests
