[jira] [Commented] (HELIX-675) Cluster Monitor may not be closed or init correctly when leadership changes
[ https://issues.apache.org/jira/browse/HELIX-675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16397926#comment-16397926 ] Hudson commented on HELIX-675: -- FAILURE: Integrated in Jenkins build helix #1410 (See [https://builds.apache.org/job/helix/1410/]) [HELIX-675] Refactor controller start/cleanup logic to ensure monitor (ericwang1985: rev b6fd8cb8396e1453afba404b669534883ce796a7) * (edit) helix-core/src/main/java/org/apache/helix/monitoring/mbeans/ClusterStatusMonitor.java * (edit) helix-core/src/test/java/org/apache/helix/monitoring/TestClusterStatusMonitorLifecycle.java * (edit) helix-core/src/test/java/org/apache/helix/monitoring/mbeans/TestTopStateHandoffMetrics.java * (edit) helix-core/src/main/java/org/apache/helix/controller/GenericHelixController.java * (edit) helix-core/src/main/java/org/apache/helix/controller/stages/ExternalViewComputeStage.java * (edit) helix-core/src/test/java/org/apache/helix/monitoring/TestClusterEventStatusMonitor.java * (edit) helix-core/src/test/java/org/apache/helix/monitoring/mbeans/TestClusterStatusMonitor.java * (edit) helix-core/src/test/java/org/apache/helix/monitoring/mbeans/TestRebalancerMetrics.java * (edit) helix-core/src/main/java/org/apache/helix/manager/zk/DistributedLeaderElection.java * (edit) helix-core/src/main/java/org/apache/helix/controller/stages/TaskAssignmentStage.java * (edit) helix-core/src/main/java/org/apache/helix/task/TaskRebalancer.java * (edit) helix-core/src/main/java/org/apache/helix/controller/stages/CurrentStateComputationStage.java > Cluster Monitor may not be closed or init correctly when leadership changes > --- > > Key: HELIX-675 > URL: https://issues.apache.org/jira/browse/HELIX-675 > Project: Apache Helix > Issue Type: Task >Reporter: Jiajun Wang >Assignee: Jiajun Wang >Priority: Major > > Due to different possible event process order, controller init event might be > processed later or earlier than expected. > This cause inconsistency when even handler thread process and record > information in the cluster monitor. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HELIX-675) Cluster Monitor may not be closed or init correctly when leadership changes
[ https://issues.apache.org/jira/browse/HELIX-675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16397805#comment-16397805 ] ASF GitHub Bot commented on HELIX-675: -- Github user asfgit closed the pull request at: https://github.com/apache/helix/pull/142 > Cluster Monitor may not be closed or init correctly when leadership changes > --- > > Key: HELIX-675 > URL: https://issues.apache.org/jira/browse/HELIX-675 > Project: Apache Helix > Issue Type: Task >Reporter: Jiajun Wang >Assignee: Jiajun Wang >Priority: Major > > Due to different possible event process order, controller init event might be > processed later or earlier than expected. > This cause inconsistency when even handler thread process and record > information in the cluster monitor. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HELIX-675) Cluster Monitor may not be closed or init correctly when leadership changes
[ https://issues.apache.org/jira/browse/HELIX-675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16392193#comment-16392193 ] ASF GitHub Bot commented on HELIX-675: -- GitHub user jiajunwang opened a pull request: https://github.com/apache/helix/pull/142 [HELIX-675] Refactor controller start/cleanup logic to ensure monitor… … register/reset is handled in any event orders. Due to different possible event process order, controller init event might be processed later or earlier than expected. This cause inconsistency when even handler thread process and record information in the cluster monitor. This change ensures cluster monitor is off when the leadership changes to other node. So no extra metric data will be generated. Also upgrade related test cases to verify MBean counts. You can merge this pull request into a Git repository by running: $ git pull https://github.com/jiajunwang/helix helix-675 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/helix/pull/142.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #142 commit f5017c35d2971bb8a5de7b8defca77c0ffdd13bb Author: jiajunwang Date: 2018-03-09T00:51:37Z [HELIX-675] Refactor controller start/cleanup logic to ensure monitor register/reset is handled in any event orders. Due to different possible event process order, controller init event might be processed later or earlier than expected. This cause inconsistency when even handler thread process and record information in the cluster monitor. This change ensures cluster monitor is off when the leadership changes to other node. So no extra metric data will be generated. Also upgrade related test cases to verify MBean counts. > Cluster Monitor may not be closed or init correctly when leadership changes > --- > > Key: HELIX-675 > URL: https://issues.apache.org/jira/browse/HELIX-675 > Project: Apache Helix > Issue Type: Task >Reporter: Jiajun Wang >Assignee: Jiajun Wang >Priority: Major > > Due to different possible event process order, controller init event might be > processed later or earlier than expected. > This cause inconsistency when even handler thread process and record > information in the cluster monitor. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
