[GitHub] Code0x58 commented on a change in pull request #2975: Docker Ubuntu tweaks

2018-08-11 Thread GitBox
Code0x58 commented on a change in pull request #2975: Docker Ubuntu tweaks URL: https://github.com/apache/incubator-heron/pull/2975#discussion_r209436212 ## File path: docker/scripts/build-base.sh ## @@ -75,7 +75,7 @@ case $# in echo " " echo "Usage: $0 "

[GitHub] nlu90 commented on a change in pull request #2978: first checkin for heron ml

2018-08-11 Thread GitBox
nlu90 commented on a change in pull request #2978: first checkin for heron ml URL: https://github.com/apache/incubator-heron/pull/2978#discussion_r209443422 ## File path: heron/mlmgr/src/main/java/org/apache/heron/LocalStormDoTask.java ## @@ -0,0 +1,82 @@ +package

[GitHub] nlu90 commented on a change in pull request #2980: Extending update command to allow number of containers to be modified at runtime

2018-08-11 Thread GitBox
nlu90 commented on a change in pull request #2980: Extending update command to allow number of containers to be modified at runtime URL: https://github.com/apache/incubator-heron/pull/2980#discussion_r209443111 ## File path:

[GitHub] nlu90 commented on a change in pull request #2977: update license information

2018-08-11 Thread GitBox
nlu90 commented on a change in pull request #2977: update license information URL: https://github.com/apache/incubator-heron/pull/2977#discussion_r209443467 ## File path: NOTICE ## @@ -1,4 +1,4 @@ -Apache Incubator-Heron +Apache Heron Review comment: @sijie suggested

[GitHub] nlu90 commented on issue #2977: update license information

2018-08-11 Thread GitBox
nlu90 commented on issue #2977: update license information URL: https://github.com/apache/incubator-heron/pull/2977#issuecomment-412319931 @sijie Could you help take a look whenever you have some time? This is an automated