[GitHub] [hudi] veenaypatil commented on a change in pull request #3092: [HUDI-1910] [WIP] Commit Offset to Kafka after successful Hudi commit

veenaypatil commented on a change in pull request #3092: URL: https://github.com/apache/hudi/pull/3092#discussion_r654938113 ## File path: hudi-utilities/src/test/java/org/apache/hudi/utilities/sources/TestKafkaSource.java ## @@ -58,7 +67,7 @@ @BeforeAll public static

[GitHub] [hudi] hudi-bot commented on pull request #3010: Improving Hudi CLI tool docs

hudi-bot commented on pull request #3010: URL: https://github.com/apache/hudi/pull/3010#issuecomment-864597581 ## CI report: * 41b7708cff642483f9e1de9fba04f396151e2bdd UNKNOWN Bot commands @hudi-bot supports the following commands: - `@hudi-bot run travis`

[GitHub] [hudi] fanaticjo commented on a change in pull request #3035: [HUDI-1936] Introduce a optional property for conditional upsert

fanaticjo commented on a change in pull request #3035: URL: https://github.com/apache/hudi/pull/3035#discussion_r654948338 ## File path: hudi-common/src/main/java/org/apache/hudi/common/model/OverwriteWithCustomAvroPayload.java ## @@ -0,0 +1,107 @@ +/* + * Licensed to the

[GitHub] [hudi] pratyakshsharma commented on pull request #3010: Improving Hudi CLI tool docs

pratyakshsharma commented on pull request #3010: URL: https://github.com/apache/hudi/pull/3010#issuecomment-864594445 Sure. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [hudi] veenaypatil commented on a change in pull request #3092: [HUDI-1910] [WIP] Commit Offset to Kafka after successful Hudi commit

veenaypatil commented on a change in pull request #3092: URL: https://github.com/apache/hudi/pull/3092#discussion_r654937577 ## File path: hudi-utilities/src/main/java/org/apache/hudi/utilities/sources/helpers/KafkaOffsetGen.java ## @@ -297,7 +293,35 @@ public String

[GitHub] [hudi] veenaypatil commented on pull request #3092: [HUDI-1910] Commit Offset to Kafka after successful Hudi commit

veenaypatil commented on pull request #3092: URL: https://github.com/apache/hudi/pull/3092#issuecomment-864579008 @n3nash @vinothchandar all the changes are done and tested, can you please review -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [hudi] codecov-commenter commented on pull request #3092: [HUDI-1910] [WIP] Commit Offset to Kafka after successful Hudi commit

codecov-commenter commented on pull request #3092: URL: https://github.com/apache/hudi/pull/3092#issuecomment-864517429 # [Codecov](https://codecov.io/gh/apache/hudi/pull/3092?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)

[GitHub] [hudi] codecov-commenter edited a comment on pull request #3092: [HUDI-1910] [WIP] Commit Offset to Kafka after successful Hudi commit

codecov-commenter edited a comment on pull request #3092: URL: https://github.com/apache/hudi/pull/3092#issuecomment-864517429 #

[GitHub] [hudi] codecov-commenter edited a comment on pull request #3092: [HUDI-1910] [WIP] Commit Offset to Kafka after successful Hudi commit

codecov-commenter edited a comment on pull request #3092: URL: https://github.com/apache/hudi/pull/3092#issuecomment-864517429 #

[GitHub] [hudi] codecov-commenter edited a comment on pull request #3092: [HUDI-1910] [WIP] Commit Offset to Kafka after successful Hudi commit

codecov-commenter edited a comment on pull request #3092: URL: https://github.com/apache/hudi/pull/3092#issuecomment-864517429 #

[GitHub] [hudi] codecov-commenter edited a comment on pull request #3092: [HUDI-1910] [WIP] Commit Offset to Kafka after successful Hudi commit

codecov-commenter edited a comment on pull request #3092: URL: https://github.com/apache/hudi/pull/3092#issuecomment-864517429 #

[GitHub] [hudi] hudi-bot edited a comment on pull request #3092: [HUDI-1910] [WIP] Commit Offset to Kafka after successful Hudi commit

hudi-bot edited a comment on pull request #3092: URL: https://github.com/apache/hudi/pull/3092#issuecomment-862136673 ## CI report: * 7dc7b1f9434ea3e602e2886e357bc467ab56aaf3 Azure:

[GitHub] [hudi] hudi-bot edited a comment on pull request #3092: [HUDI-1910] [WIP] Commit Offset to Kafka after successful Hudi commit

hudi-bot edited a comment on pull request #3092: URL: https://github.com/apache/hudi/pull/3092#issuecomment-862136673 ## CI report: * cd25e8a35b0dba2de3479d3a5b58f60d7b758e02 Azure:

[GitHub] [hudi] yuzhaojing commented on a change in pull request #3105: [HUDI-2038] Rollback pending compaction when schedule new compaction

yuzhaojing commented on a change in pull request #3105: URL: https://github.com/apache/hudi/pull/3105#discussion_r654898311 ## File path: hudi-client/hudi-flink-client/src/main/java/org/apache/hudi/table/action/compact/FlinkScheduleCompactionActionExecutor.java ## @@ -72,6

[GitHub] [hudi] hudi-bot edited a comment on pull request #3092: [HUDI-1910] [WIP] Commit Offset to Kafka after successful Hudi commit

hudi-bot edited a comment on pull request #3092: URL: https://github.com/apache/hudi/pull/3092#issuecomment-862136673 ## CI report: * cd25e8a35b0dba2de3479d3a5b58f60d7b758e02 Azure:

[GitHub] [hudi] garyli1019 commented on pull request #3093: [HUDI-2031] JVM occasionally crashes during compaction when spark speculative execution is enabled

garyli1019 commented on pull request #3093: URL: https://github.com/apache/hudi/pull/3093#issuecomment-864544552 > Change looks reasonable. let me think bit more around the scenarios before merging this. > > Anyway we can write a unit test around this scenario? We found

[GitHub] [hudi] xushiyan opened a new pull request #3118: [MINOR] try fix azure ci cache

xushiyan opened a new pull request #3118: URL: https://github.com/apache/hudi/pull/3118 ## *Tips* - *Thank you very much for contributing to Apache Hudi.* - *Please review https://hudi.apache.org/contributing.html before opening a pull request.* ## What is the purpose of the

[GitHub] [hudi] codecov-commenter commented on pull request #3118: [MINOR] try fix azure ci cache

codecov-commenter commented on pull request #3118: URL: https://github.com/apache/hudi/pull/3118#issuecomment-86460 # [Codecov](https://codecov.io/gh/apache/hudi/pull/3118?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)

[GitHub] [hudi] hudi-bot edited a comment on pull request #2906: [HUDI-393] remove travis

hudi-bot edited a comment on pull request #2906: URL: https://github.com/apache/hudi/pull/2906#issuecomment-830929050 ## CI report: * e96f2c03ab0f4fd6deb6803479fa6624eb21ed73 UNKNOWN * 0985b9b4a64b8015257eae8d85dfd899acf7a910 UNKNOWN *

[GitHub] [hudi] codecov-commenter edited a comment on pull request #3100: [HUDI-2034] Support explicit partition compaction strategy for flink …

codecov-commenter edited a comment on pull request #3100: URL: https://github.com/apache/hudi/pull/3100#issuecomment-862906759 #

[GitHub] [hudi] hudi-bot edited a comment on pull request #2906: [HUDI-393] remove travis

hudi-bot edited a comment on pull request #2906: URL: https://github.com/apache/hudi/pull/2906#issuecomment-830929050 ## CI report: * e96f2c03ab0f4fd6deb6803479fa6624eb21ed73 UNKNOWN * 0985b9b4a64b8015257eae8d85dfd899acf7a910 UNKNOWN *

[GitHub] [hudi] codecov-commenter edited a comment on pull request #3100: [HUDI-2034] Support explicit partition compaction strategy for flink …

codecov-commenter edited a comment on pull request #3100: URL: https://github.com/apache/hudi/pull/3100#issuecomment-862906759 #

[GitHub] [hudi] codecov-commenter edited a comment on pull request #3118: [MINOR] try fix azure ci cache

codecov-commenter edited a comment on pull request #3118: URL: https://github.com/apache/hudi/pull/3118#issuecomment-86460 #

[GitHub] [hudi] codecov-commenter edited a comment on pull request #3118: [MINOR] try fix azure ci cache

codecov-commenter edited a comment on pull request #3118: URL: https://github.com/apache/hudi/pull/3118#issuecomment-86460 #

[hudi] branch master updated: [MINOR] Put Azure cache tasks first (#3118)

This is an automated email from the ASF dual-hosted git repository. xushiyan pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/hudi.git The following commit(s) were added to refs/heads/master by this push: new e41f13f [MINOR] Put Azure cache tasks first

[GitHub] [hudi] xushiyan merged pull request #3118: [MINOR] Put Azure cache tasks first

xushiyan merged pull request #3118: URL: https://github.com/apache/hudi/pull/3118 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [hudi] hudi-bot edited a comment on pull request #2906: [HUDI-393] remove travis

hudi-bot edited a comment on pull request #2906: URL: https://github.com/apache/hudi/pull/2906#issuecomment-830929050 ## CI report: * e96f2c03ab0f4fd6deb6803479fa6624eb21ed73 UNKNOWN * 0985b9b4a64b8015257eae8d85dfd899acf7a910 UNKNOWN *

[GitHub] [hudi] swuferhong opened a new pull request #3100: [HUDI-2034] Support explicit partition compaction strategy for flink …

swuferhong opened a new pull request #3100: URL: https://github.com/apache/hudi/pull/3100 …batch compaction ## *Tips* - *Thank you very much for contributing to Apache Hudi.* - *Please review https://hudi.apache.org/contributing.html before opening a pull request.* ##

[GitHub] [hudi] swuferhong closed pull request #3100: [HUDI-2034] Support explicit partition compaction strategy for flink …

swuferhong closed pull request #3100: URL: https://github.com/apache/hudi/pull/3100 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [hudi] codecov-commenter edited a comment on pull request #3100: [HUDI-2034] Support explicit partition compaction strategy for flink …

codecov-commenter edited a comment on pull request #3100: URL: https://github.com/apache/hudi/pull/3100#issuecomment-862906759 #

[GitHub] [hudi] codecov-commenter edited a comment on pull request #3100: [HUDI-2034] Support explicit partition compaction strategy for flink …

codecov-commenter edited a comment on pull request #3100: URL: https://github.com/apache/hudi/pull/3100#issuecomment-862906759 #

[GitHub] [hudi] hudi-bot commented on pull request #3118: [MINOR] try fix azure ci cache

hudi-bot commented on pull request #3118: URL: https://github.com/apache/hudi/pull/3118#issuecomment-864608349 ## CI report: * 0b565a29c6ef34cf59edaac71b1075ce8c1ccfde UNKNOWN Bot commands @hudi-bot supports the following commands: - `@hudi-bot run travis`

[GitHub] [hudi] tandonraghav commented on issue #3078: [SUPPORT] combineAndGetUpdateValue is not getting called when Schema evolution happens

tandonraghav commented on issue #3078: URL: https://github.com/apache/hudi/issues/3078#issuecomment-864611953 @n3nash I am not able to resolve this. `preCombine` can be called even if there are no duplicates in the incoming records? Can you please explain with a sample ? I fail

[GitHub] [hudi] hudi-bot edited a comment on pull request #3118: [MINOR] try fix azure ci cache

hudi-bot edited a comment on pull request #3118: URL: https://github.com/apache/hudi/pull/3118#issuecomment-864608349 ## CI report: * 0b565a29c6ef34cf59edaac71b1075ce8c1ccfde Azure:

[GitHub] [hudi] codecov-commenter edited a comment on pull request #3118: [MINOR] try fix azure ci cache

codecov-commenter edited a comment on pull request #3118: URL: https://github.com/apache/hudi/pull/3118#issuecomment-86460 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [hudi] hudi-bot edited a comment on pull request #3118: [MINOR] try fix azure ci cache

hudi-bot edited a comment on pull request #3118: URL: https://github.com/apache/hudi/pull/3118#issuecomment-864608349 ## CI report: * 0b565a29c6ef34cf59edaac71b1075ce8c1ccfde Azure:

[GitHub] [hudi] fengjian428 commented on a change in pull request #2784: [HUDI-1740] Fix insert-overwrite API archival

fengjian428 commented on a change in pull request #2784: URL: https://github.com/apache/hudi/pull/2784#discussion_r654191440 ## File path: hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/utils/MetadataConversionUtils.java ## @@ -72,10 +73,21 @@ public

[GitHub] [hudi] hudi-bot commented on pull request #2927: [HUDI-1129] Improving schema evolution support in hudi

hudi-bot commented on pull request #2927: URL: https://github.com/apache/hudi/pull/2927#issuecomment-864700767 ## CI report: * 2667501ff9689af403ed7de7101375ea74ce407b UNKNOWN Bot commands @hudi-bot supports the following commands: - `@hudi-bot run travis`

[jira] [Commented] (HUDI-1248) [UMBRELLA] Tests cleanup and fixes

[ https://issues.apache.org/jira/browse/HUDI-1248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17366370#comment-17366370 ] Vinoth Chandar commented on HUDI-1248: -- First one seems related to ORC.  > [UMBRELLA] Tests cleanup

[GitHub] [hudi] xushiyan commented on pull request #2906: [HUDI-393] remove travis

xushiyan commented on pull request #2906: URL: https://github.com/apache/hudi/pull/2906#issuecomment-864725931 @hudi-bot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [hudi] vinothchandar commented on pull request #3093: [HUDI-2031] JVM occasionally crashes during compaction when spark speculative execution is enabled

vinothchandar commented on pull request #3093: URL: https://github.com/apache/hudi/pull/3093#issuecomment-864728997 Generally speaking, I am bit skeptical on overall use of speculative execution. Most of the policies are pretty naive. Anyways, @garyli1019 Would love to get a JIRA with

[GitHub] [hudi] hudi-bot edited a comment on pull request #2903: [HUDI-1850] Fixing read of a empty table but with failed write

hudi-bot edited a comment on pull request #2903: URL: https://github.com/apache/hudi/pull/2903#issuecomment-864727710 ## CI report: * f474fba1301a32298a4297f4a9dffc2bd99f518b Azure:

[GitHub] [hudi] nsivabalan commented on a change in pull request #2927: [HUDI-1129] Improving schema evolution support in hudi

nsivabalan commented on a change in pull request #2927: URL: https://github.com/apache/hudi/pull/2927#discussion_r655052508 ## File path: hudi-spark-datasource/hudi-spark/src/main/scala/org/apache/hudi/HoodieSparkUtils.scala ## @@ -89,22 +89,45 @@ object HoodieSparkUtils

[GitHub] [hudi] hudi-bot edited a comment on pull request #2927: [HUDI-1129] Improving schema evolution support in hudi

hudi-bot edited a comment on pull request #2927: URL: https://github.com/apache/hudi/pull/2927#issuecomment-864700767 ## CI report: * 2667501ff9689af403ed7de7101375ea74ce407b Azure:

[GitHub] [hudi] vinothchandar merged pull request #3110: [HUDI-1248] Increase timeout for deltaStreamerTestRunner in TestHoodi…

vinothchandar merged pull request #3110: URL: https://github.com/apache/hudi/pull/3110 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[hudi] branch master updated: [HUDI-1248] Increase timeout for deltaStreamerTestRunner in TestHoodieDeltaStreamer (#3110)

This is an automated email from the ASF dual-hosted git repository. vinoth pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/hudi.git The following commit(s) were added to refs/heads/master by this push: new 429e9fb [HUDI-1248] Increase timeout for

[GitHub] [hudi] vinothchandar commented on pull request #3110: [HUDI-1248] Increase timeout for deltaStreamerTestRunner in TestHoodi…

vinothchandar commented on pull request #3110: URL: https://github.com/apache/hudi/pull/3110#issuecomment-864722244 Let's merge this for now to get CI be lil happy again. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [hudi] hudi-bot commented on pull request #2903: [HUDI-1850] Fixing read of a empty table but with failed write

hudi-bot commented on pull request #2903: URL: https://github.com/apache/hudi/pull/2903#issuecomment-864727710 ## CI report: * f474fba1301a32298a4297f4a9dffc2bd99f518b UNKNOWN Bot commands @hudi-bot supports the following commands: - `@hudi-bot run travis`

[GitHub] [hudi] hudi-bot edited a comment on pull request #2906: [HUDI-393] remove travis

hudi-bot edited a comment on pull request #2906: URL: https://github.com/apache/hudi/pull/2906#issuecomment-830929050 ## CI report: * e96f2c03ab0f4fd6deb6803479fa6624eb21ed73 UNKNOWN * 0985b9b4a64b8015257eae8d85dfd899acf7a910 UNKNOWN *

[GitHub] [hudi] nsivabalan commented on a change in pull request #2927: [HUDI-1129] Improving schema evolution support in hudi

nsivabalan commented on a change in pull request #2927: URL: https://github.com/apache/hudi/pull/2927#discussion_r655052508 ## File path: hudi-spark-datasource/hudi-spark/src/main/scala/org/apache/hudi/HoodieSparkUtils.scala ## @@ -89,22 +89,45 @@ object HoodieSparkUtils

[GitHub] [hudi] hudi-bot edited a comment on pull request #2927: [HUDI-1129] Improving schema evolution support in hudi

hudi-bot edited a comment on pull request #2927: URL: https://github.com/apache/hudi/pull/2927#issuecomment-864700767 ## CI report: * 2667501ff9689af403ed7de7101375ea74ce407b Azure:

[GitHub] [hudi] vinothchandar commented on a change in pull request #3109: [HUDI-2043] HoodieDefaultTimeline$filterPendingCompactionTImeline() m…

vinothchandar commented on a change in pull request #3109: URL: https://github.com/apache/hudi/pull/3109#discussion_r655069369 ## File path: hudi-common/src/main/java/org/apache/hudi/common/table/timeline/HoodieDefaultTimeline.java ## @@ -127,7 +127,7 @@ public HoodieTimeline

[GitHub] [hudi] vinothchandar commented on a change in pull request #2903: [HUDI-1850] Fixing read of a empty table but with failed write

vinothchandar commented on a change in pull request #2903: URL: https://github.com/apache/hudi/pull/2903#discussion_r655073962 ## File path: hudi-spark-datasource/hudi-spark/src/test/scala/org/apache/hudi/functional/HoodieSparkSqlWriterSuite.scala ## @@ -229,7 +231,42 @@

[GitHub] [hudi] xushiyan opened a new pull request #3119: test commit

xushiyan opened a new pull request #3119: URL: https://github.com/apache/hudi/pull/3119 ## *Tips* - *Thank you very much for contributing to Apache Hudi.* - *Please review https://hudi.apache.org/contributing.html before opening a pull request.* ## What is the purpose of the

[GitHub] [hudi] hudi-bot edited a comment on pull request #2903: [HUDI-1850] Fixing read of a empty table but with failed write

hudi-bot edited a comment on pull request #2903: URL: https://github.com/apache/hudi/pull/2903#issuecomment-864727710 ## CI report: * f474fba1301a32298a4297f4a9dffc2bd99f518b Azure:

[GitHub] [hudi] hudi-bot edited a comment on pull request #2906: [HUDI-393] remove travis

hudi-bot edited a comment on pull request #2906: URL: https://github.com/apache/hudi/pull/2906#issuecomment-830929050 ## CI report: * e96f2c03ab0f4fd6deb6803479fa6624eb21ed73 UNKNOWN * 0985b9b4a64b8015257eae8d85dfd899acf7a910 UNKNOWN *