[GitHub] [incubator-hudi] pratyakshsharma commented on a change in pull request #1075: [HUDI-114]: added option to overwrite payload implementation in hoodie.properties file
pratyakshsharma commented on a change in pull request #1075: [HUDI-114]: added option to overwrite payload implementation in hoodie.properties file URL: https://github.com/apache/incubator-hudi/pull/1075#discussion_r361804460 ## File path: hudi-cli/src/main/java/org/apache/hudi/cli/HoodieCLI.java ## @@ -74,7 +74,8 @@ public static void initFS(boolean force) throws IOException { } public static void refreshTableMetadata() { -setTableMetaClient(new HoodieTableMetaClient(HoodieCLI.conf, basePath, false, HoodieCLI.consistencyGuardConfig)); +setTableMetaClient(new HoodieTableMetaClient(HoodieCLI.conf, basePath, false, HoodieCLI.consistencyGuardConfig, Review comment: Made the changes @n3nash This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-hudi] pratyakshsharma commented on a change in pull request #1075: [HUDI-114]: added option to overwrite payload implementation in hoodie.properties file
pratyakshsharma commented on a change in pull request #1075: [HUDI-114]: added option to overwrite payload implementation in hoodie.properties file URL: https://github.com/apache/incubator-hudi/pull/1075#discussion_r355880698 ## File path: hudi-utilities/src/main/java/org/apache/hudi/utilities/deltastreamer/HoodieDeltaStreamer.java ## @@ -228,6 +228,10 @@ public Operation convert(String value) throws ParameterException { + " source-fetch -> Transform -> Hudi Write in loop") public Boolean continuousMode = false; +@Parameter(names = {"--update-payload-class"}, description = "Update payload class in hoodie.properties file if needed, " Review comment: Done with the changes @n3nash This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-hudi] pratyakshsharma commented on a change in pull request #1075: [HUDI-114]: added option to overwrite payload implementation in hoodie.properties file
pratyakshsharma commented on a change in pull request #1075: [HUDI-114]: added option to overwrite payload implementation in hoodie.properties file URL: https://github.com/apache/incubator-hudi/pull/1075#discussion_r353191882 ## File path: hudi-utilities/src/main/java/org/apache/hudi/utilities/deltastreamer/HoodieDeltaStreamer.java ## @@ -228,6 +228,10 @@ public Operation convert(String value) throws ParameterException { + " source-fetch -> Transform -> Hudi Write in loop") public Boolean continuousMode = false; +@Parameter(names = {"--update-payload-class"}, description = "Update payload class in hoodie.properties file if needed, " Review comment: @vinothchandar someone might give different payload class by mistake as well. Just to be sure he/she really wants to update it in hoodie.properties file, I added this flag here. The same was discussed with @n3nash. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services