[GitHub] [incubator-hudi] smarthi commented on issue #1159: [HUDI-479] Eliminate or Minimize use of Guava if possible
smarthi commented on issue #1159: [HUDI-479] Eliminate or Minimize use of Guava if possible URL: https://github.com/apache/incubator-hudi/pull/1159#issuecomment-605043851 > ``` > [INFO] There is 1 error reported by Checkstyle 8.18 with style/checkstyle.xml ruleset. > 593[ERROR] src/main/java/org/apache/hudi/avro/MercifulJsonConverter.java:[33] (imports) AvoidStarImport: Using the '.*' form of import should be avoided - java.util.*. > ``` > > there are check style failures? to be resolved? Resolved This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-hudi] smarthi commented on issue #1159: [HUDI-479] Eliminate or Minimize use of Guava if possible
smarthi commented on issue #1159: [HUDI-479] Eliminate or Minimize use of Guava if possible URL: https://github.com/apache/incubator-hudi/pull/1159#issuecomment-604547864 > @smarthi The CollectionUtils IMO does not seem to reuse any code from guava actually.. it just wraps Java Streams/Collection apis in most cases.. SO we need not attribute anything in LICENSE/NOTICE.. Please clarify that's Correct. No attribution needed in LICENSE or NOTICe whatsoever. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-hudi] smarthi commented on issue #1159: [HUDI-479] Eliminate or Minimize use of Guava if possible
smarthi commented on issue #1159: [HUDI-479] Eliminate or Minimize use of Guava if possible URL: https://github.com/apache/incubator-hudi/pull/1159#issuecomment-604166428 > @smarthi is this ready for final review? Have we eliminated Guava at this point? @vinothchandar please review This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-hudi] smarthi commented on issue #1159: [HUDI-479] Eliminate or Minimize use of Guava if possible
smarthi commented on issue #1159: [HUDI-479] Eliminate or Minimize use of Guava if possible URL: https://github.com/apache/incubator-hudi/pull/1159#issuecomment-588425612 > @smarthi when you reach the bottom of the barrel, can we also add a rule here to disallow guava? > > https://github.com/apache/incubator-hudi/blob/master/style/checkstyle.xml#L266 > > I can then do a final review and merge.. (Looks like there is one clean up pending before this one) Its done now - PR is ready for review and feedback. I would merge this post-0.5.2 release though. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
