[GitHub] [incubator-hudi] yanghua commented on issue #1057: Hudi Test Suite
yanghua commented on issue #1057: Hudi Test Suite URL: https://github.com/apache/incubator-hudi/pull/1057#issuecomment-564340367 > @yanghua Thanks for the details, I've squashed the commits. Thanks, if you do not mind, I'd like to rename your squashed commit message and carry `HUDI-394` at the beginning of the commit message so that all the works can be tracked via Jira issues. It can provide a more detailed context for the community. WDYT? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-hudi] yanghua commented on issue #1057: Hudi Test Suite
yanghua commented on issue #1057: Hudi Test Suite URL: https://github.com/apache/incubator-hudi/pull/1057#issuecomment-564339647 > @yanghua thanks! So I take it that HUDI-394 is what @n3nash owns via fixes you mentioned? Yes, it's the first step of HUDI-289 and it blocks other subtasks. It has been done and just mapping the exists implementation provided by @n3nash . This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-hudi] yanghua commented on issue #1057: Hudi Test Suite
yanghua commented on issue #1057: Hudi Test Suite URL: https://github.com/apache/incubator-hudi/pull/1057#issuecomment-563148174 I have made [HUDI-289](https://issues.apache.org/jira/browse/HUDI-289) as an umbrella issue and created some subtasks to measure detailed subtasks. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-hudi] yanghua commented on issue #1057: Hudi Test Suite
yanghua commented on issue #1057: Hudi Test Suite URL: https://github.com/apache/incubator-hudi/pull/1057#issuecomment-563051606 I suggest we stop paying attention and explain the past, it is normal for distributed development to have such problems. We should focus on the future. We should maintain close and timely communication, synchronize our information and progress in a timely manner, and ensure that we are on the track of correct and rapid iteration. I've started to verify the existing implementation based on @n3nash 's branch, let's go back to the previous branch(The price is not high, I did not go too far on another branch). @vinothchandar In addition, there is currently no additional JIRA task to describe it except HUDI-289. I suggest that we still strictly follow the regular Jira and PR corresponding process to promote this feature. We can continue this rule even on feature branches. We can create groups of this feature on Slack to facilitate our communication, even though we may not be able to use it under normal circumstances. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-hudi] yanghua commented on issue #1057: Hudi Test Suite
yanghua commented on issue #1057: Hudi Test Suite URL: https://github.com/apache/incubator-hudi/pull/1057#issuecomment-562401410 > @yanghua Can we continue to use the same branch `hudi_test_suite_refactor` please ? You can continue to PR against that branch. I've also fixed the issue with POM that was causing the test case failure, you may want to rebase this PR against that branch. I am comfortable that no matter use which branch. The reason why I pushed a new `hudi_test_suite` branch is [here](https://github.com/apache/incubator-hudi/pull/991#issuecomment-559362785). I pinged you and gave a time gap to wait for the suggestion. And I got the suggestion from @vinothchandar . If you can fix the conflicts based on master brach, I can return back to the `hudi_test_suite_refactor` branch. Another option, you can cherry pick your commits about pom issues into my new branch and I can rename the branch name. > Secondly, I think we should name the package - `hudi-test-suite` instead of `hudi-end-to-end-tests`, it's more concise, WDYT ? Ok, agree. After coming to an agreement on the branch problem, we can fix the module naming problem. > > Also, can we execute on the following plan : > > 1. Please go over all the changes in the existing PR - I've addressed most of the comments. There were too many comments in the old PR #991. Reviewing that PR will spend too much time, let's review the new PR to eliminate interruptions of outdate comments. It's a more effective way. WDYT? > 2. Let's rename the package - like you've already done OK, agree. > 3. Both of us can start to use the test suite and run them locally for 2-3 days. This will give us confidence whether the test suite is ready to test large features. OK, will try it. > 4. Let's merge this first version of the test suite to master so folks can start using it I will let @vinothchandar make the decision to see if it's the right time to merge it into the master branch. > 5. Both of us can continue to enhance the test suite - a) You can add some of the things that you mentioned earlier like DIstributedTestDataSource etc b) I want to add more use-cases > OK > Let me know if this sounds fair to you. First of all, you can see I kept your code and your git commits. Something I have done is just squashed them into one to fix the conflicts. Some things may be caused by our insufficiency in communication. If we can respond to each other's information more efficiently, then maybe our work will be more efficient. Personally, I try to respond to my Github messages every day, except on weekends or long holidays. @n3nash Do you pay more attention to Slack? If so, I can communicate with you via Slack. Or can we create a test suite Slack group? However, IMO, communicate via Github is a better way because we can discuss code. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-hudi] yanghua commented on issue #1057: Hudi Test Suite
yanghua commented on issue #1057: Hudi Test Suite URL: https://github.com/apache/incubator-hudi/pull/1057#issuecomment-561077900 I have pushed a new branch named `hudi_test_suite` and will keep this PR syncing with the branch. This PR used to discuss. If there is no objection, will delete the old branch `hudi_test_suite_refactor`. WDYT? @vinothchandar @n3nash This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-hudi] yanghua commented on issue #1057: Hudi Test Suite
yanghua commented on issue #1057: Hudi Test Suite URL: https://github.com/apache/incubator-hudi/pull/1057#issuecomment-559385540 Hi @n3nash and @vinothchandar I rebased the original PR #623 (hudi_test_suite_refactor feature branch). However, It seems I can not combine with the old commits. So I created a new draft PR. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
