Re: [PR] [MINOR] Fix NPE in getInputFileSlices when RO path filter returns empty partition [hudi]
nsivabalan merged PR #18639: URL: https://github.com/apache/hudi/pull/18639 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] [MINOR] Fix NPE in getInputFileSlices when RO path filter returns empty partition [hudi]
hudi-bot commented on PR #18639: URL: https://github.com/apache/hudi/pull/18639#issuecomment-4654899970 ## CI report: * eab38a9b9aa9b34c170f945327455001ac506f5b Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=14518) Bot commands @hudi-bot supports the following commands: - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] [MINOR] Fix NPE in getInputFileSlices when RO path filter returns empty partition [hudi]
codecov-commenter commented on PR #18639: URL: https://github.com/apache/hudi/pull/18639#issuecomment-4654795924 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18639?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `80.0%` with `1 line` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 68.21%. Comparing base ([`aac975c`](https://app.codecov.io/gh/apache/hudi/commit/aac975c9ff34eca3261f13d539d82f383c3bb090?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`eab38a9`](https://app.codecov.io/gh/apache/hudi/commit/eab38a9b9aa9b34c170f945327455001ac506f5b?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 1 commits behind head on master. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18639?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...java/org/apache/hudi/BaseHoodieTableFileIndex.java](https://app.codecov.io/gh/apache/hudi/pull/18639?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2FBaseHoodieTableFileIndex.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvQmFzZUhvb2RpZVRhYmxlRmlsZUluZGV4LmphdmE=) | 80.00% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18639?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18639 +/- ## + Coverage 68.20% 68.21% +0.01% - Complexity2945829460 +2 Files 2542 2542 Lines142545 142549 +4 Branches 1777817779 +1 + Hits 9721897238 +20 + Misses3731637297 -19 - Partials 8011 8014 +3 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.69% <80.00%> (+0.01%)` | :arrow_up: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.76% <0.00%> (+0.02%)` | :arrow_up: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.04% <0.00%> (+<0.01%)` | :arrow_up: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.78% <80.00%> (+0.01%)` | :arrow_up: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.86% <0.00%> (+0.01%)` | :arrow_up: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.27% <0.00%> (-0.01%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18639?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| |
Re: [PR] [MINOR] Fix NPE in getInputFileSlices when RO path filter returns empty partition [hudi]
codecov-commenter commented on PR #18639: URL: https://github.com/apache/hudi/pull/18639#issuecomment-4654757680 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18639?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `80.0%` with `1 line` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 68.21%. Comparing base ([`aac975c`](https://app.codecov.io/gh/apache/hudi/commit/aac975c9ff34eca3261f13d539d82f383c3bb090?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`eab38a9`](https://app.codecov.io/gh/apache/hudi/commit/eab38a9b9aa9b34c170f945327455001ac506f5b?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 1 commits behind head on master. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18639?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...java/org/apache/hudi/BaseHoodieTableFileIndex.java](https://app.codecov.io/gh/apache/hudi/pull/18639?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2FBaseHoodieTableFileIndex.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvQmFzZUhvb2RpZVRhYmxlRmlsZUluZGV4LmphdmE=) | 80.00% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18639?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18639 +/- ## + Coverage 68.20% 68.21% +0.01% - Complexity2945829460 +2 Files 2542 2542 Lines142545 142549 +4 Branches 1777817779 +1 + Hits 9721897238 +20 + Misses3731637297 -19 - Partials 8011 8014 +3 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.69% <80.00%> (+0.01%)` | :arrow_up: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.76% <0.00%> (+0.02%)` | :arrow_up: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.04% <0.00%> (+<0.01%)` | :arrow_up: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.78% <80.00%> (+0.01%)` | :arrow_up: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.86% <0.00%> (+0.01%)` | :arrow_up: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.27% <0.00%> (-0.01%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18639?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| |
Re: [PR] [MINOR] Fix NPE in getInputFileSlices when RO path filter returns empty partition [hudi]
codecov-commenter commented on PR #18639: URL: https://github.com/apache/hudi/pull/18639#issuecomment-4654702021 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18639?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `80.0%` with `1 line` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 68.21%. Comparing base ([`aac975c`](https://app.codecov.io/gh/apache/hudi/commit/aac975c9ff34eca3261f13d539d82f383c3bb090?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`eab38a9`](https://app.codecov.io/gh/apache/hudi/commit/eab38a9b9aa9b34c170f945327455001ac506f5b?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18639?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...java/org/apache/hudi/BaseHoodieTableFileIndex.java](https://app.codecov.io/gh/apache/hudi/pull/18639?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2FBaseHoodieTableFileIndex.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvQmFzZUhvb2RpZVRhYmxlRmlsZUluZGV4LmphdmE=) | 80.00% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18639?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18639 +/- ## + Coverage 68.20% 68.21% +0.01% - Complexity2945829460 +2 Files 2542 2542 Lines142545 142549 +4 Branches 1777817779 +1 + Hits 9721897236 +18 + Misses3731637299 -17 - Partials 8011 8014 +3 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.69% <80.00%> (+0.01%)` | :arrow_up: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.76% <0.00%> (+0.02%)` | :arrow_up: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.04% <0.00%> (+<0.01%)` | :arrow_up: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.75% <80.00%> (-0.02%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.86% <0.00%> (+0.01%)` | :arrow_up: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.27% <0.00%> (-0.01%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18639?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| |
Re: [PR] [MINOR] Fix NPE in getInputFileSlices when RO path filter returns empty partition [hudi]
codecov-commenter commented on PR #18639: URL: https://github.com/apache/hudi/pull/18639#issuecomment-4654694823 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18639?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `80.0%` with `1 line` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 68.21%. Comparing base ([`aac975c`](https://app.codecov.io/gh/apache/hudi/commit/aac975c9ff34eca3261f13d539d82f383c3bb090?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`eab38a9`](https://app.codecov.io/gh/apache/hudi/commit/eab38a9b9aa9b34c170f945327455001ac506f5b?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18639?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...java/org/apache/hudi/BaseHoodieTableFileIndex.java](https://app.codecov.io/gh/apache/hudi/pull/18639?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2FBaseHoodieTableFileIndex.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvQmFzZUhvb2RpZVRhYmxlRmlsZUluZGV4LmphdmE=) | 80.00% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18639?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18639 +/- ## + Coverage 68.20% 68.21% +0.01% - Complexity2945829460 +2 Files 2542 2542 Lines142545 142549 +4 Branches 1777817779 +1 + Hits 9721897236 +18 + Misses3731637299 -17 - Partials 8011 8014 +3 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.69% <80.00%> (+0.01%)` | :arrow_up: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.76% <0.00%> (+0.02%)` | :arrow_up: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.04% <0.00%> (+<0.01%)` | :arrow_up: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.73% <80.00%> (-0.05%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.86% <0.00%> (+0.01%)` | :arrow_up: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.27% <0.00%> (-0.01%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18639?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| |
Re: [PR] [MINOR] Fix NPE in getInputFileSlices when RO path filter returns empty partition [hudi]
codecov-commenter commented on PR #18639: URL: https://github.com/apache/hudi/pull/18639#issuecomment-4654689175 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18639?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `80.0%` with `1 line` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 68.16%. Comparing base ([`aac975c`](https://app.codecov.io/gh/apache/hudi/commit/aac975c9ff34eca3261f13d539d82f383c3bb090?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`eab38a9`](https://app.codecov.io/gh/apache/hudi/commit/eab38a9b9aa9b34c170f945327455001ac506f5b?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18639?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...java/org/apache/hudi/BaseHoodieTableFileIndex.java](https://app.codecov.io/gh/apache/hudi/pull/18639?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2FBaseHoodieTableFileIndex.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvQmFzZUhvb2RpZVRhYmxlRmlsZUluZGV4LmphdmE=) | 80.00% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18639?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18639 +/- ## - Coverage 68.20% 68.16% -0.04% + Complexity2945829431 -27 Files 2542 2542 Lines142545 142549 +4 Branches 1777817779 +1 - Hits 9721897173 -45 - Misses3731637374 +58 + Partials 8011 8002 -9 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.69% <80.00%> (+0.01%)` | :arrow_up: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.76% <0.00%> (+0.02%)` | :arrow_up: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.04% <0.00%> (+<0.01%)` | :arrow_up: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.73% <80.00%> (-0.05%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.78% <0.00%> (-0.08%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.27% <0.00%> (-0.01%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18639?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| |
Re: [PR] [MINOR] Fix NPE in getInputFileSlices when RO path filter returns empty partition [hudi]
codecov-commenter commented on PR #18639: URL: https://github.com/apache/hudi/pull/18639#issuecomment-4654685926 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18639?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `80.0%` with `1 line` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 68.13%. Comparing base ([`aac975c`](https://app.codecov.io/gh/apache/hudi/commit/aac975c9ff34eca3261f13d539d82f383c3bb090?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`eab38a9`](https://app.codecov.io/gh/apache/hudi/commit/eab38a9b9aa9b34c170f945327455001ac506f5b?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18639?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...java/org/apache/hudi/BaseHoodieTableFileIndex.java](https://app.codecov.io/gh/apache/hudi/pull/18639?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2FBaseHoodieTableFileIndex.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvQmFzZUhvb2RpZVRhYmxlRmlsZUluZGV4LmphdmE=) | 80.00% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18639?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18639 +/- ## - Coverage 68.20% 68.13% -0.07% + Complexity2945829408 -50 Files 2542 2542 Lines142545 142549 +4 Branches 1777817779 +1 - Hits 9721897121 -97 - Misses3731637432 +116 + Partials 8011 7996 -15 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.69% <80.00%> (+0.01%)` | :arrow_up: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.76% <0.00%> (+0.02%)` | :arrow_up: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.04% <0.00%> (+<0.01%)` | :arrow_up: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.72% <80.00%> (-0.05%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.69% <0.00%> (-0.16%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.27% <0.00%> (-0.01%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18639?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| |
Re: [PR] [MINOR] Fix NPE in getInputFileSlices when RO path filter returns empty partition [hudi]
codecov-commenter commented on PR #18639: URL: https://github.com/apache/hudi/pull/18639#issuecomment-4654682925 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18639?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `80.0%` with `1 line` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 68.07%. Comparing base ([`aac975c`](https://app.codecov.io/gh/apache/hudi/commit/aac975c9ff34eca3261f13d539d82f383c3bb090?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`eab38a9`](https://app.codecov.io/gh/apache/hudi/commit/eab38a9b9aa9b34c170f945327455001ac506f5b?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18639?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...java/org/apache/hudi/BaseHoodieTableFileIndex.java](https://app.codecov.io/gh/apache/hudi/pull/18639?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2FBaseHoodieTableFileIndex.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvQmFzZUhvb2RpZVRhYmxlRmlsZUluZGV4LmphdmE=) | 80.00% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18639?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18639 +/- ## - Coverage 68.20% 68.07% -0.13% + Complexity2945829378 -80 Files 2542 2542 Lines142545 142549 +4 Branches 1777817779 +1 - Hits 9721897044 -174 - Misses3731637510 +194 + Partials 8011 7995 -16 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.69% <80.00%> (+0.01%)` | :arrow_up: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.76% <0.00%> (+0.02%)` | :arrow_up: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.04% <0.00%> (+<0.01%)` | :arrow_up: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.48% <80.00%> (-0.29%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.69% <0.00%> (-0.16%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.27% <0.00%> (-0.01%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18639?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| |
Re: [PR] [MINOR] Fix NPE in getInputFileSlices when RO path filter returns empty partition [hudi]
codecov-commenter commented on PR #18639: URL: https://github.com/apache/hudi/pull/18639#issuecomment-4654681466 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18639?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `80.0%` with `1 line` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 68.06%. Comparing base ([`aac975c`](https://app.codecov.io/gh/apache/hudi/commit/aac975c9ff34eca3261f13d539d82f383c3bb090?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`eab38a9`](https://app.codecov.io/gh/apache/hudi/commit/eab38a9b9aa9b34c170f945327455001ac506f5b?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18639?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...java/org/apache/hudi/BaseHoodieTableFileIndex.java](https://app.codecov.io/gh/apache/hudi/pull/18639?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2FBaseHoodieTableFileIndex.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvQmFzZUhvb2RpZVRhYmxlRmlsZUluZGV4LmphdmE=) | 80.00% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18639?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18639 +/- ## - Coverage 68.20% 68.06% -0.14% + Complexity2945829371 -87 Files 2542 2542 Lines142545 142549 +4 Branches 1777817779 +1 - Hits 9721897027 -191 - Misses3731637532 +216 + Partials 8011 7990 -21 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.69% <80.00%> (+0.01%)` | :arrow_up: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.76% <0.00%> (+0.02%)` | :arrow_up: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.04% <0.00%> (+<0.01%)` | :arrow_up: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.46% <80.00%> (-0.31%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.69% <0.00%> (-0.16%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.27% <0.00%> (-0.01%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18639?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| |
Re: [PR] [MINOR] Fix NPE in getInputFileSlices when RO path filter returns empty partition [hudi]
codecov-commenter commented on PR #18639: URL: https://github.com/apache/hudi/pull/18639#issuecomment-4654678757 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18639?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `80.0%` with `1 line` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 68.02%. Comparing base ([`aac975c`](https://app.codecov.io/gh/apache/hudi/commit/aac975c9ff34eca3261f13d539d82f383c3bb090?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`eab38a9`](https://app.codecov.io/gh/apache/hudi/commit/eab38a9b9aa9b34c170f945327455001ac506f5b?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18639?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...java/org/apache/hudi/BaseHoodieTableFileIndex.java](https://app.codecov.io/gh/apache/hudi/pull/18639?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2FBaseHoodieTableFileIndex.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvQmFzZUhvb2RpZVRhYmxlRmlsZUluZGV4LmphdmE=) | 80.00% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18639?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18639 +/- ## - Coverage 68.20% 68.02% -0.18% + Complexity2945829348 -110 Files 2542 2542 Lines142545 142549 +4 Branches 1777817779 +1 - Hits 9721896973 -245 - Misses3731637599 +283 + Partials 8011 7977 -34 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.69% <80.00%> (+0.01%)` | :arrow_up: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.76% <0.00%> (+0.02%)` | :arrow_up: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.04% <0.00%> (+<0.01%)` | :arrow_up: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.25% <80.00%> (-0.52%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.69% <0.00%> (-0.16%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.27% <0.00%> (-0.01%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18639?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| |
Re: [PR] [MINOR] Fix NPE in getInputFileSlices when RO path filter returns empty partition [hudi]
codecov-commenter commented on PR #18639: URL: https://github.com/apache/hudi/pull/18639#issuecomment-4654677193 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18639?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `80.0%` with `1 line` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 67.98%. Comparing base ([`aac975c`](https://app.codecov.io/gh/apache/hudi/commit/aac975c9ff34eca3261f13d539d82f383c3bb090?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`eab38a9`](https://app.codecov.io/gh/apache/hudi/commit/eab38a9b9aa9b34c170f945327455001ac506f5b?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18639?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...java/org/apache/hudi/BaseHoodieTableFileIndex.java](https://app.codecov.io/gh/apache/hudi/pull/18639?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2FBaseHoodieTableFileIndex.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvQmFzZUhvb2RpZVRhYmxlRmlsZUluZGV4LmphdmE=) | 80.00% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18639?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18639 +/- ## - Coverage 68.20% 67.98% -0.22% + Complexity2945829310 -148 Files 2542 2542 Lines142545 142549 +4 Branches 1777817779 +1 - Hits 9721896910 -308 - Misses3731637670 +354 + Partials 8011 7969 -42 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.69% <80.00%> (+0.01%)` | :arrow_up: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.76% <0.00%> (+0.02%)` | :arrow_up: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.04% <0.00%> (+<0.01%)` | :arrow_up: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.02% <80.00%> (-0.75%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.69% <0.00%> (-0.16%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.27% <0.00%> (-0.01%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18639?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| |
Re: [PR] [MINOR] Fix NPE in getInputFileSlices when RO path filter returns empty partition [hudi]
codecov-commenter commented on PR #18639: URL: https://github.com/apache/hudi/pull/18639#issuecomment-4654668431 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18639?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `80.0%` with `1 line` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 65.34%. Comparing base ([`aac975c`](https://app.codecov.io/gh/apache/hudi/commit/aac975c9ff34eca3261f13d539d82f383c3bb090?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`eab38a9`](https://app.codecov.io/gh/apache/hudi/commit/eab38a9b9aa9b34c170f945327455001ac506f5b?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18639?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...java/org/apache/hudi/BaseHoodieTableFileIndex.java](https://app.codecov.io/gh/apache/hudi/pull/18639?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2FBaseHoodieTableFileIndex.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvQmFzZUhvb2RpZVRhYmxlRmlsZUluZGV4LmphdmE=) | 80.00% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18639?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18639 +/- ## - Coverage 68.20% 65.34% -2.86% + Complexity2945828191-1267 Files 2542 2542 Lines142545 142549 +4 Branches 1777817779 +1 - Hits 9721893149-4069 - Misses3731641332+4016 - Partials 8011 8068 +57 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.69% <80.00%> (+0.01%)` | :arrow_up: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.76% <0.00%> (+0.02%)` | :arrow_up: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.04% <0.00%> (+<0.01%)` | :arrow_up: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `31.33% <0.00%> (-17.44%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.59% <0.00%> (-0.26%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.27% <0.00%> (-0.01%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18639?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| |
Re: [PR] [MINOR] Fix NPE in getInputFileSlices when RO path filter returns empty partition [hudi]
codecov-commenter commented on PR #18639: URL: https://github.com/apache/hudi/pull/18639#issuecomment-4654672885 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18639?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `80.0%` with `1 line` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 67.07%. Comparing base ([`aac975c`](https://app.codecov.io/gh/apache/hudi/commit/aac975c9ff34eca3261f13d539d82f383c3bb090?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`eab38a9`](https://app.codecov.io/gh/apache/hudi/commit/eab38a9b9aa9b34c170f945327455001ac506f5b?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18639?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...java/org/apache/hudi/BaseHoodieTableFileIndex.java](https://app.codecov.io/gh/apache/hudi/pull/18639?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2FBaseHoodieTableFileIndex.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvQmFzZUhvb2RpZVRhYmxlRmlsZUluZGV4LmphdmE=) | 80.00% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18639?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18639 +/- ## - Coverage 68.20% 67.07% -1.13% + Complexity2945828898 -560 Files 2542 2542 Lines142545 142549 +4 Branches 1777817779 +1 - Hits 9721895612-1606 - Misses3731638904+1588 - Partials 8011 8033 +22 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.69% <80.00%> (+0.01%)` | :arrow_up: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.76% <0.00%> (+0.02%)` | :arrow_up: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.04% <0.00%> (+<0.01%)` | :arrow_up: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `41.79% <0.00%> (-6.98%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.69% <0.00%> (-0.16%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.27% <0.00%> (-0.01%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18639?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| |
Re: [PR] [MINOR] Fix NPE in getInputFileSlices when RO path filter returns empty partition [hudi]
codecov-commenter commented on PR #18639: URL: https://github.com/apache/hudi/pull/18639#issuecomment-4654658156 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18639?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `80.0%` with `1 line` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 65.30%. Comparing base ([`aac975c`](https://app.codecov.io/gh/apache/hudi/commit/aac975c9ff34eca3261f13d539d82f383c3bb090?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`eab38a9`](https://app.codecov.io/gh/apache/hudi/commit/eab38a9b9aa9b34c170f945327455001ac506f5b?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18639?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...java/org/apache/hudi/BaseHoodieTableFileIndex.java](https://app.codecov.io/gh/apache/hudi/pull/18639?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2FBaseHoodieTableFileIndex.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvQmFzZUhvb2RpZVRhYmxlRmlsZUluZGV4LmphdmE=) | 80.00% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18639?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18639 +/- ## - Coverage 68.20% 65.30% -2.90% + Complexity2945828189-1269 Files 2542 2542 Lines142545 142549 +4 Branches 1777817779 +1 - Hits 9721893094-4124 - Misses3731641367+4051 - Partials 8011 8088 +77 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.69% <80.00%> (+0.01%)` | :arrow_up: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.76% <0.00%> (+0.02%)` | :arrow_up: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.04% <0.00%> (+<0.01%)` | :arrow_up: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `31.33% <0.00%> (-17.44%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.53% <0.00%> (-0.32%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.27% <0.00%> (-0.01%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18639?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| |
Re: [PR] [MINOR] Fix NPE in getInputFileSlices when RO path filter returns empty partition [hudi]
codecov-commenter commented on PR #18639: URL: https://github.com/apache/hudi/pull/18639#issuecomment-4654649051 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18639?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `80.0%` with `1 line` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 65.25%. Comparing base ([`aac975c`](https://app.codecov.io/gh/apache/hudi/commit/aac975c9ff34eca3261f13d539d82f383c3bb090?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`eab38a9`](https://app.codecov.io/gh/apache/hudi/commit/eab38a9b9aa9b34c170f945327455001ac506f5b?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18639?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...java/org/apache/hudi/BaseHoodieTableFileIndex.java](https://app.codecov.io/gh/apache/hudi/pull/18639?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2FBaseHoodieTableFileIndex.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvQmFzZUhvb2RpZVRhYmxlRmlsZUluZGV4LmphdmE=) | 80.00% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18639?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18639 +/- ## - Coverage 68.20% 65.25% -2.95% + Complexity2945828157-1301 Files 2542 2542 Lines142545 142549 +4 Branches 1777817779 +1 - Hits 9721893026-4192 - Misses3731641455+4139 - Partials 8011 8068 +57 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.69% <80.00%> (+0.01%)` | :arrow_up: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.76% <0.00%> (+0.02%)` | :arrow_up: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.04% <0.00%> (+<0.01%)` | :arrow_up: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `31.33% <0.00%> (-17.44%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.44% <0.00%> (-0.41%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.27% <0.00%> (-0.01%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18639?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| |
Re: [PR] [MINOR] Fix NPE in getInputFileSlices when RO path filter returns empty partition [hudi]
codecov-commenter commented on PR #18639: URL: https://github.com/apache/hudi/pull/18639#issuecomment-4654609921 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18639?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `80.0%` with `1 line` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 60.77%. Comparing base ([`aac975c`](https://app.codecov.io/gh/apache/hudi/commit/aac975c9ff34eca3261f13d539d82f383c3bb090?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`eab38a9`](https://app.codecov.io/gh/apache/hudi/commit/eab38a9b9aa9b34c170f945327455001ac506f5b?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18639?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...java/org/apache/hudi/BaseHoodieTableFileIndex.java](https://app.codecov.io/gh/apache/hudi/pull/18639?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2FBaseHoodieTableFileIndex.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvQmFzZUhvb2RpZVRhYmxlRmlsZUluZGV4LmphdmE=) | 80.00% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18639?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | > :exclamation: There is a different number of reports uploaded between BASE (aac975c) and HEAD (eab38a9). Click for more details. > > HEAD has 18 uploads less than BASE > >| Flag | BASE (aac975c) | HEAD (eab38a9) | >|--|--|--| >|spark-scala-tests|12|6| >|spark-java-tests|18|6| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18639 +/- ## - Coverage 68.20% 60.77% -7.44% + Complexity2945826225-3233 Files 2542 2542 Lines142545 142549 +4 Branches 1777817779 +1 - Hits 9721886629 -10589 - Misses3731648289 +10973 + Partials 8011 7631 -380 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.69% <80.00%> (+0.01%)` | :arrow_up: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.76% <0.00%> (+0.02%)` | :arrow_up: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.04% <0.00%> (+<0.01%)` | :arrow_up: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `31.33% <0.00%> (-17.44%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.51% <0.00%> (-12.34%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.27% <0.00%> (-0.01%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing
Re: [PR] [MINOR] Fix NPE in getInputFileSlices when RO path filter returns empty partition [hudi]
codecov-commenter commented on PR #18639: URL: https://github.com/apache/hudi/pull/18639#issuecomment-4654608420 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18639?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `80.0%` with `1 line` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 60.77%. Comparing base ([`aac975c`](https://app.codecov.io/gh/apache/hudi/commit/aac975c9ff34eca3261f13d539d82f383c3bb090?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`eab38a9`](https://app.codecov.io/gh/apache/hudi/commit/eab38a9b9aa9b34c170f945327455001ac506f5b?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18639?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...java/org/apache/hudi/BaseHoodieTableFileIndex.java](https://app.codecov.io/gh/apache/hudi/pull/18639?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2FBaseHoodieTableFileIndex.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvQmFzZUhvb2RpZVRhYmxlRmlsZUluZGV4LmphdmE=) | 80.00% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18639?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | > :exclamation: There is a different number of reports uploaded between BASE (aac975c) and HEAD (eab38a9). Click for more details. > > HEAD has 18 uploads less than BASE > >| Flag | BASE (aac975c) | HEAD (eab38a9) | >|--|--|--| >|spark-scala-tests|12|6| >|spark-java-tests|18|6| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18639 +/- ## - Coverage 68.20% 60.77% -7.44% + Complexity2945826225-3233 Files 2542 2542 Lines142545 142549 +4 Branches 1777817779 +1 - Hits 9721886629 -10589 - Misses3731648289 +10973 + Partials 8011 7631 -380 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.69% <80.00%> (+0.01%)` | :arrow_up: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.76% <0.00%> (+0.02%)` | :arrow_up: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.04% <0.00%> (+<0.01%)` | :arrow_up: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `31.33% <0.00%> (-17.44%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.51% <0.00%> (-12.34%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.27% <0.00%> (-0.01%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing
Re: [PR] [MINOR] Fix NPE in getInputFileSlices when RO path filter returns empty partition [hudi]
codecov-commenter commented on PR #18639: URL: https://github.com/apache/hudi/pull/18639#issuecomment-4654602338 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18639?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `0%` with `5 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 53.22%. Comparing base ([`aac975c`](https://app.codecov.io/gh/apache/hudi/commit/aac975c9ff34eca3261f13d539d82f383c3bb090?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`eab38a9`](https://app.codecov.io/gh/apache/hudi/commit/eab38a9b9aa9b34c170f945327455001ac506f5b?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18639?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...java/org/apache/hudi/BaseHoodieTableFileIndex.java](https://app.codecov.io/gh/apache/hudi/pull/18639?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2FBaseHoodieTableFileIndex.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvQmFzZUhvb2RpZVRhYmxlRmlsZUluZGV4LmphdmE=) | 0.00% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18639?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | > :exclamation: There is a different number of reports uploaded between BASE (aac975c) and HEAD (eab38a9). Click for more details. > > HEAD has 20 uploads less than BASE > >| Flag | BASE (aac975c) | HEAD (eab38a9) | >|--|--|--| >|spark-scala-tests|12|5| >|spark-java-tests|18|6| >|common-and-other-modules|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18639 +/- ## = - Coverage 68.20% 53.22% -14.99% + Complexity2945818939-10519 = Files 2542 2065 -477 Lines142545 118070-24475 Branches 1777815447 -2331 = - Hits 9721862838-34380 - Misses3731648479+11163 + Partials 8011 6753 -1258 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.76% <0.00%> (+0.02%)` | :arrow_up: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.04% <0.00%> (+<0.01%)` | :arrow_up: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `31.33% <0.00%> (-17.44%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.69% <0.00%> (-12.17%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.27% <0.00%> (-0.01%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing
Re: [PR] [MINOR] Fix NPE in getInputFileSlices when RO path filter returns empty partition [hudi]
codecov-commenter commented on PR #18639: URL: https://github.com/apache/hudi/pull/18639#issuecomment-4654600862 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18639?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `0%` with `5 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 47.30%. Comparing base ([`aac975c`](https://app.codecov.io/gh/apache/hudi/commit/aac975c9ff34eca3261f13d539d82f383c3bb090?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`eab38a9`](https://app.codecov.io/gh/apache/hudi/commit/eab38a9b9aa9b34c170f945327455001ac506f5b?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18639?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...java/org/apache/hudi/BaseHoodieTableFileIndex.java](https://app.codecov.io/gh/apache/hudi/pull/18639?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2FBaseHoodieTableFileIndex.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvQmFzZUhvb2RpZVRhYmxlRmlsZUluZGV4LmphdmE=) | 0.00% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18639?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | > :exclamation: There is a different number of reports uploaded between BASE (aac975c) and HEAD (eab38a9). Click for more details. > > HEAD has 21 uploads less than BASE > >| Flag | BASE (aac975c) | HEAD (eab38a9) | >|--|--|--| >|spark-scala-tests|12|5| >|spark-java-tests|18|6| >|common-and-other-modules|1|0| >|utilities|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18639 +/- ## = - Coverage 68.20% 47.30% -20.90% + Complexity2945817006-12452 = Files 2542 2065 -477 Lines142545 118070-24475 Branches 1777815447 -2331 = - Hits 9721855854-41364 - Misses3731656079+18763 + Partials 8011 6137 -1874 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.76% <0.00%> (+0.02%)` | :arrow_up: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.04% <0.00%> (+<0.01%)` | :arrow_up: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `31.33% <0.00%> (-17.44%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.69% <0.00%> (-12.17%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing
Re: [PR] [MINOR] Fix NPE in getInputFileSlices when RO path filter returns empty partition [hudi]
codecov-commenter commented on PR #18639: URL: https://github.com/apache/hudi/pull/18639#issuecomment-4654591542 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18639?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `0%` with `5 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 46.67%. Comparing base ([`aac975c`](https://app.codecov.io/gh/apache/hudi/commit/aac975c9ff34eca3261f13d539d82f383c3bb090?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`eab38a9`](https://app.codecov.io/gh/apache/hudi/commit/eab38a9b9aa9b34c170f945327455001ac506f5b?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18639?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...java/org/apache/hudi/BaseHoodieTableFileIndex.java](https://app.codecov.io/gh/apache/hudi/pull/18639?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2FBaseHoodieTableFileIndex.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvQmFzZUhvb2RpZVRhYmxlRmlsZUluZGV4LmphdmE=) | 0.00% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18639?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | > :exclamation: There is a different number of reports uploaded between BASE (aac975c) and HEAD (eab38a9). Click for more details. > > HEAD has 23 uploads less than BASE > >| Flag | BASE (aac975c) | HEAD (eab38a9) | >|--|--|--| >|spark-scala-tests|12|3| >|spark-java-tests|18|6| >|common-and-other-modules|1|0| >|utilities|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18639 +/- ## = - Coverage 68.20% 46.67% -21.54% + Complexity2945816676-12782 = Files 2542 2065 -477 Lines142545 118070-24475 Branches 1777815447 -2331 = - Hits 9721855105-42113 - Misses3731657046+19730 + Partials 8011 5919 -2092 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.76% <0.00%> (+0.02%)` | :arrow_up: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.04% <0.00%> (+<0.01%)` | :arrow_up: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `31.33% <0.00%> (-17.44%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.86% <0.00%> (-11.99%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing
Re: [PR] [MINOR] Fix NPE in getInputFileSlices when RO path filter returns empty partition [hudi]
codecov-commenter commented on PR #18639: URL: https://github.com/apache/hudi/pull/18639#issuecomment-4654578246 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18639?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `0%` with `5 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 47.36%. Comparing base ([`aac975c`](https://app.codecov.io/gh/apache/hudi/commit/aac975c9ff34eca3261f13d539d82f383c3bb090?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`eab38a9`](https://app.codecov.io/gh/apache/hudi/commit/eab38a9b9aa9b34c170f945327455001ac506f5b?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18639?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...java/org/apache/hudi/BaseHoodieTableFileIndex.java](https://app.codecov.io/gh/apache/hudi/pull/18639?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2FBaseHoodieTableFileIndex.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvQmFzZUhvb2RpZVRhYmxlRmlsZUluZGV4LmphdmE=) | 0.00% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18639?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | > :exclamation: There is a different number of reports uploaded between BASE (aac975c) and HEAD (eab38a9). Click for more details. > > HEAD has 26 uploads less than BASE > >| Flag | BASE (aac975c) | HEAD (eab38a9) | >|--|--|--| >|spark-scala-tests|12|3| >|spark-java-tests|18|3| >|common-and-other-modules|1|0| >|utilities|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18639 +/- ## = - Coverage 68.20% 47.36% -20.84% + Complexity2945816582-12876 = Files 2542 2044 -498 Lines142545 115519-27026 Branches 1777814903 -2875 = - Hits 9721854715-42503 - Misses3731654961+17645 + Partials 8011 5843 -2168 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.76% <0.00%> (+0.02%)` | :arrow_up: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.04% <0.00%> (+<0.01%)` | :arrow_up: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.02% <0.00%> (-16.75%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.86% <0.00%> (-11.99%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing
Re: [PR] [MINOR] Fix NPE in getInputFileSlices when RO path filter returns empty partition [hudi]
codecov-commenter commented on PR #18639: URL: https://github.com/apache/hudi/pull/18639#issuecomment-4654576798 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18639?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `0%` with `5 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 48.87%. Comparing base ([`aac975c`](https://app.codecov.io/gh/apache/hudi/commit/aac975c9ff34eca3261f13d539d82f383c3bb090?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`eab38a9`](https://app.codecov.io/gh/apache/hudi/commit/eab38a9b9aa9b34c170f945327455001ac506f5b?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18639?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...java/org/apache/hudi/BaseHoodieTableFileIndex.java](https://app.codecov.io/gh/apache/hudi/pull/18639?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2FBaseHoodieTableFileIndex.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvQmFzZUhvb2RpZVRhYmxlRmlsZUluZGV4LmphdmE=) | 0.00% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18639?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | > :exclamation: There is a different number of reports uploaded between BASE (aac975c) and HEAD (eab38a9). Click for more details. > > HEAD has 28 uploads less than BASE > >| Flag | BASE (aac975c) | HEAD (eab38a9) | >|--|--|--| >|spark-scala-tests|12|3| >|spark-java-tests|18|1| >|common-and-other-modules|1|0| >|utilities|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18639 +/- ## = - Coverage 68.20% 48.87% -19.34% + Complexity2945816385-13073 = Files 2542 1992 -550 Lines142545 110281-32264 Branches 1777813785 -3993 = - Hits 9721853896-43322 - Misses3731650729+13413 + Partials 8011 5656 -2355 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.76% <0.00%> (+0.02%)` | :arrow_up: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.04% <0.00%> (+<0.01%)` | :arrow_up: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.80% <0.00%> (-15.97%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.86% <0.00%> (-11.99%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing
Re: [PR] [MINOR] Fix NPE in getInputFileSlices when RO path filter returns empty partition [hudi]
codecov-commenter commented on PR #18639: URL: https://github.com/apache/hudi/pull/18639#issuecomment-4654570873 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18639?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `0%` with `5 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 48.83%. Comparing base ([`aac975c`](https://app.codecov.io/gh/apache/hudi/commit/aac975c9ff34eca3261f13d539d82f383c3bb090?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`eab38a9`](https://app.codecov.io/gh/apache/hudi/commit/eab38a9b9aa9b34c170f945327455001ac506f5b?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18639?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...java/org/apache/hudi/BaseHoodieTableFileIndex.java](https://app.codecov.io/gh/apache/hudi/pull/18639?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2FBaseHoodieTableFileIndex.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvQmFzZUhvb2RpZVRhYmxlRmlsZUluZGV4LmphdmE=) | 0.00% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18639?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | > :exclamation: There is a different number of reports uploaded between BASE (aac975c) and HEAD (eab38a9). Click for more details. > > HEAD has 29 uploads less than BASE > >| Flag | BASE (aac975c) | HEAD (eab38a9) | >|--|--|--| >|spark-scala-tests|12|2| >|spark-java-tests|18|1| >|common-and-other-modules|1|0| >|utilities|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18639 +/- ## = - Coverage 68.20% 48.83% -19.37% + Complexity2945816383-13075 = Files 2542 1992 -550 Lines142545 110281-32264 Branches 1777813785 -3993 = - Hits 9721853855-43363 - Misses3731650755+13439 + Partials 8011 5671 -2340 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.76% <0.00%> (+0.02%)` | :arrow_up: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.04% <0.00%> (+<0.01%)` | :arrow_up: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.80% <0.00%> (-15.97%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.77% <0.00%> (-12.08%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing
Re: [PR] [MINOR] Fix NPE in getInputFileSlices when RO path filter returns empty partition [hudi]
codecov-commenter commented on PR #18639: URL: https://github.com/apache/hudi/pull/18639#issuecomment-4654553276 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18639?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `0%` with `5 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 45.98%. Comparing base ([`aac975c`](https://app.codecov.io/gh/apache/hudi/commit/aac975c9ff34eca3261f13d539d82f383c3bb090?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`eab38a9`](https://app.codecov.io/gh/apache/hudi/commit/eab38a9b9aa9b34c170f945327455001ac506f5b?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18639?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...java/org/apache/hudi/BaseHoodieTableFileIndex.java](https://app.codecov.io/gh/apache/hudi/pull/18639?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2FBaseHoodieTableFileIndex.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvQmFzZUhvb2RpZVRhYmxlRmlsZUluZGV4LmphdmE=) | 0.00% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18639?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | > :exclamation: There is a different number of reports uploaded between BASE (aac975c) and HEAD (eab38a9). Click for more details. > > HEAD has 30 uploads less than BASE > >| Flag | BASE (aac975c) | HEAD (eab38a9) | >|--|--|--| >|spark-scala-tests|12|2| >|spark-java-tests|18|0| >|common-and-other-modules|1|0| >|utilities|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18639 +/- ## = - Coverage 68.20% 45.98% -22.22% + Complexity2945815492-13966 = Files 2542 1992 -550 Lines142545 110263-32282 Branches 1777813693 -4085 = - Hits 9721850705-46513 - Misses3731654079+16763 + Partials 8011 5479 -2532 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.76% <0.00%> (+0.02%)` | :arrow_up: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.04% <0.00%> (+<0.01%)` | :arrow_up: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.77% <0.00%> (-12.08%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing
Re: [PR] [MINOR] Fix NPE in getInputFileSlices when RO path filter returns empty partition [hudi]
codecov-commenter commented on PR #18639: URL: https://github.com/apache/hudi/pull/18639#issuecomment-4654530141 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18639?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `0%` with `5 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 39.28%. Comparing base ([`aac975c`](https://app.codecov.io/gh/apache/hudi/commit/aac975c9ff34eca3261f13d539d82f383c3bb090?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`eab38a9`](https://app.codecov.io/gh/apache/hudi/commit/eab38a9b9aa9b34c170f945327455001ac506f5b?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18639?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...java/org/apache/hudi/BaseHoodieTableFileIndex.java](https://app.codecov.io/gh/apache/hudi/pull/18639?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2FBaseHoodieTableFileIndex.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvQmFzZUhvb2RpZVRhYmxlRmlsZUluZGV4LmphdmE=) | 0.00% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18639?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | > :exclamation: There is a different number of reports uploaded between BASE (aac975c) and HEAD (eab38a9). Click for more details. > > HEAD has 31 uploads less than BASE > >| Flag | BASE (aac975c) | HEAD (eab38a9) | >|--|--|--| >|spark-client-hadoop-common|1|0| >|spark-scala-tests|12|2| >|spark-java-tests|18|0| >|common-and-other-modules|1|0| >|utilities|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18639 +/- ## = - Coverage 68.20% 39.28% -28.92% + Complexity2945812818-16640 = Files 2542 1992 -550 Lines142545 110263-32282 Branches 1777813693 -4085 = - Hits 9721843320-53898 - Misses3731661547+24231 + Partials 8011 5396 -2615 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.76% <0.00%> (+0.02%)` | :arrow_up: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.77% <0.00%> (-12.08%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing
Re: [PR] [MINOR] Fix NPE in getInputFileSlices when RO path filter returns empty partition [hudi]
codecov-commenter commented on PR #18639: URL: https://github.com/apache/hudi/pull/18639#issuecomment-4654503652 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18639?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `0%` with `5 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 39.61%. Comparing base ([`aac975c`](https://app.codecov.io/gh/apache/hudi/commit/aac975c9ff34eca3261f13d539d82f383c3bb090?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`eab38a9`](https://app.codecov.io/gh/apache/hudi/commit/eab38a9b9aa9b34c170f945327455001ac506f5b?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18639?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...java/org/apache/hudi/BaseHoodieTableFileIndex.java](https://app.codecov.io/gh/apache/hudi/pull/18639?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2FBaseHoodieTableFileIndex.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvQmFzZUhvb2RpZVRhYmxlRmlsZUluZGV4LmphdmE=) | 0.00% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18639?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | > :exclamation: There is a different number of reports uploaded between BASE (aac975c) and HEAD (eab38a9). Click for more details. > > HEAD has 32 uploads less than BASE > >| Flag | BASE (aac975c) | HEAD (eab38a9) | >|--|--|--| >|spark-client-hadoop-common|1|0| >|spark-scala-tests|12|1| >|spark-java-tests|18|0| >|common-and-other-modules|1|0| >|utilities|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18639 +/- ## = - Coverage 68.20% 39.61% -28.59% + Complexity2945812611-16847 = Files 2542 1975 -567 Lines142545 107891-34654 Branches 1777813184 -4594 = - Hits 9721842742-54476 - Misses3731659942+22626 + Partials 8011 5207 -2804 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.76% <0.00%> (+0.02%)` | :arrow_up: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.95% <0.00%> (-11.90%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing
Re: [PR] [MINOR] Fix NPE in getInputFileSlices when RO path filter returns empty partition [hudi]
codecov-commenter commented on PR #18639: URL: https://github.com/apache/hudi/pull/18639#issuecomment-4654418074 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18639?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `0%` with `5 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 44.76%. Comparing base ([`aac975c`](https://app.codecov.io/gh/apache/hudi/commit/aac975c9ff34eca3261f13d539d82f383c3bb090?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`eab38a9`](https://app.codecov.io/gh/apache/hudi/commit/eab38a9b9aa9b34c170f945327455001ac506f5b?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18639?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...java/org/apache/hudi/BaseHoodieTableFileIndex.java](https://app.codecov.io/gh/apache/hudi/pull/18639?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2FBaseHoodieTableFileIndex.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvQmFzZUhvb2RpZVRhYmxlRmlsZUluZGV4LmphdmE=) | 0.00% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18639?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | > :exclamation: There is a different number of reports uploaded between BASE (aac975c) and HEAD (eab38a9). Click for more details. > > HEAD has 33 uploads less than BASE > >| Flag | BASE (aac975c) | HEAD (eab38a9) | >|--|--|--| >|spark-client-hadoop-common|1|0| >|spark-scala-tests|12|0| >|spark-java-tests|18|0| >|common-and-other-modules|1|0| >|utilities|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18639 +/- ## = - Coverage 68.20% 44.76% -23.44% + Complexity29458 8528-20930 = Files 2542 1202 -1340 Lines14254562813-79732 Branches 17778 6867-10911 = - Hits 9721828118-69100 + Misses3731631572 -5744 + Partials 8011 3123 -4888 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.76% <0.00%> (+0.02%)` | :arrow_up: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18639?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
Re: [PR] [MINOR] Fix NPE in getInputFileSlices when RO path filter returns empty partition [hudi]
hudi-bot commented on PR #18639: URL: https://github.com/apache/hudi/pull/18639#issuecomment-4654385546 ## CI report: * 8672f5a2e49b977425781da43d41af4573f5f4f9 Azure: [FAILURE](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13706) * eab38a9b9aa9b34c170f945327455001ac506f5b Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=14518) Bot commands @hudi-bot supports the following commands: - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] [MINOR] Fix NPE in getInputFileSlices when RO path filter returns empty partition [hudi]
hudi-agent commented on code in PR #18639:
URL: https://github.com/apache/hudi/pull/18639#discussion_r3376867735
##
hudi-common/src/main/java/org/apache/hudi/BaseHoodieTableFileIndex.java:
##
@@ -326,7 +331,11 @@ private Map>
generatePartitionFileSlicesPostROTab
// Add the FileSlice to partitionToFileSlices
PartitionPath partitionPathObj = partitionsMap.get(relPartitionPath);
if (partitionPathObj != null) {
-List fileSlices =
partitionToFileSlices.computeIfAbsent(partitionPathObj, k -> new ArrayList<>());
+List fileSlices =
partitionToFileSlices.get(partitionPathObj);
+if (fileSlices.isEmpty()) {
Review Comment:
🤖 nit: using `isEmpty()` as the guard is a bit subtle — it works only
because `Collections.emptyList()` is always empty, but a reader unfamiliar with
the pre-population above might wonder what happens with a legitimately empty
mutable list. Could you consider pre-populating with `new ArrayList<>()`
instead and restoring the original `computeIfAbsent` one-liner? That makes it
self-evident the slot is always safe to add into.
- AI-generated; verify before applying. React 👍/👎 to flag
quality.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] [MINOR] Fix NPE in getInputFileSlices when RO path filter returns empty partition [hudi]
hudi-bot commented on PR #18639: URL: https://github.com/apache/hudi/pull/18639#issuecomment-4654363114 ## CI report: * 8672f5a2e49b977425781da43d41af4573f5f4f9 Azure: [FAILURE](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13706) * eab38a9b9aa9b34c170f945327455001ac506f5b UNKNOWN Bot commands @hudi-bot supports the following commands: - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] [MINOR] Fix NPE in getInputFileSlices when RO path filter returns empty partition [hudi]
codecov-commenter commented on PR #18639: URL: https://github.com/apache/hudi/pull/18639#issuecomment-4461936993 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18639?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 68.07%. Comparing base ([`642e1d3`](https://app.codecov.io/gh/apache/hudi/commit/642e1d33e12073060a620788987c3ce4b7f84e36?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`8672f5a`](https://app.codecov.io/gh/apache/hudi/commit/8672f5a2e49b977425781da43d41af4573f5f4f9?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 40 commits behind head on master. Additional details and impacted files ```diff @@Coverage Diff@@ ## master #18639 +/- ## = Coverage 68.06% 68.07% + Complexity2891928911-8 = Files 2518 2518 Lines140570 140571+1 Branches 1741617419+3 = + Hits 9568095692 +12 + Misses3703337022 -11 Partials 7857 7857 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.37% <100.00%> (+<0.01%)` | :arrow_up: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.84% <0.00%> (+<0.01%)` | :arrow_up: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.43% <0.00%> (+<0.01%)` | :arrow_up: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.63% <100.00%> (-0.02%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.69% <0.00%> (-0.01%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.68% <0.00%> (+<0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18639?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...java/org/apache/hudi/BaseHoodieTableFileIndex.java](https://app.codecov.io/gh/apache/hudi/pull/18639?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2FBaseHoodieTableFileIndex.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvQmFzZUhvb2RpZVRhYmxlRmlsZUluZGV4LmphdmE=) | `89.34% <100.00%> (+5.80%)` | :arrow_up: | ... and [10 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18639/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) :rocket: New features to boost your workflow: - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:
Re: [PR] [MINOR] Fix NPE in getInputFileSlices when RO path filter returns empty partition [hudi]
codecov-commenter commented on PR #18639: URL: https://github.com/apache/hudi/pull/18639#issuecomment-4395140558 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18639?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 68.07%. Comparing base ([`642e1d3`](https://app.codecov.io/gh/apache/hudi/commit/642e1d33e12073060a620788987c3ce4b7f84e36?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`8672f5a`](https://app.codecov.io/gh/apache/hudi/commit/8672f5a2e49b977425781da43d41af4573f5f4f9?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 19 commits behind head on master. Additional details and impacted files ```diff @@Coverage Diff@@ ## master #18639 +/- ## = Coverage 68.06% 68.07% + Complexity2891928911-8 = Files 2518 2518 Lines140570 140571+1 Branches 1741617419+3 = + Hits 9568095692 +12 + Misses3703337022 -11 Partials 7857 7857 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.37% <100.00%> (+<0.01%)` | :arrow_up: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.84% <0.00%> (+<0.01%)` | :arrow_up: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.43% <0.00%> (+<0.01%)` | :arrow_up: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.63% <100.00%> (-0.02%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.69% <0.00%> (-0.01%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.68% <0.00%> (+<0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18639?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...java/org/apache/hudi/BaseHoodieTableFileIndex.java](https://app.codecov.io/gh/apache/hudi/pull/18639?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2FBaseHoodieTableFileIndex.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvQmFzZUhvb2RpZVRhYmxlRmlsZUluZGV4LmphdmE=) | `89.34% <100.00%> (+5.80%)` | :arrow_up: | ... and [10 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18639/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) :rocket: New features to boost your workflow: - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:
Re: [PR] [MINOR] Fix NPE in getInputFileSlices when RO path filter returns empty partition [hudi]
danny0405 commented on code in PR #18639: URL: https://github.com/apache/hudi/pull/18639#discussion_r3158262682 ## hudi-common/src/main/java/org/apache/hudi/BaseHoodieTableFileIndex.java: ## @@ -314,6 +314,11 @@ private Map> generatePartitionFileSlicesPostROTab Map partitionsMap = new HashMap<>(); partitions.forEach(p -> partitionsMap.put(p.path, p)); Map> partitionToFileSlices = new HashMap<>(); +// Pre-populate so partitions with no files still appear in the result map. +// Without this, the caller's Collectors.toMap(identity, cache::get) NPEs on empty partitions +// because cache.get returns null and toMap rejects null values. This matches the contract +// already honored by filterFiles, which iterates over partitions rather than over files. +partitions.forEach(p -> partitionToFileSlices.put(p, new ArrayList<>())); Review Comment: +1, can we use `Collecitons.emptyList` instead of `new ArrayList<>()` ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] [MINOR] Fix NPE in getInputFileSlices when RO path filter returns empty partition [hudi]
codecov-commenter commented on PR #18639: URL: https://github.com/apache/hudi/pull/18639#issuecomment-4340476495 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18639?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 68.07%. Comparing base ([`642e1d3`](https://app.codecov.io/gh/apache/hudi/commit/642e1d33e12073060a620788987c3ce4b7f84e36?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`8672f5a`](https://app.codecov.io/gh/apache/hudi/commit/8672f5a2e49b977425781da43d41af4573f5f4f9?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). Additional details and impacted files ```diff @@Coverage Diff@@ ## master #18639 +/- ## = Coverage 68.06% 68.07% + Complexity2891928911-8 = Files 2518 2518 Lines140570 140571+1 Branches 1741617419+3 = + Hits 9568095692 +12 + Misses3703337022 -11 Partials 7857 7857 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.37% <100.00%> (+<0.01%)` | :arrow_up: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.84% <0.00%> (+<0.01%)` | :arrow_up: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.43% <0.00%> (+<0.01%)` | :arrow_up: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.63% <100.00%> (-0.02%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.69% <0.00%> (-0.01%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.68% <0.00%> (+<0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18639?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...java/org/apache/hudi/BaseHoodieTableFileIndex.java](https://app.codecov.io/gh/apache/hudi/pull/18639?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2FBaseHoodieTableFileIndex.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvQmFzZUhvb2RpZVRhYmxlRmlsZUluZGV4LmphdmE=) | `89.34% <100.00%> (+5.80%)` | :arrow_up: | ... and [10 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18639/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) :rocket: New features to boost your workflow: - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this
Re: [PR] [MINOR] Fix NPE in getInputFileSlices when RO path filter returns empty partition [hudi]
codecov-commenter commented on PR #18639: URL: https://github.com/apache/hudi/pull/18639#issuecomment-4340452088 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18639?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 68.07%. Comparing base ([`642e1d3`](https://app.codecov.io/gh/apache/hudi/commit/642e1d33e12073060a620788987c3ce4b7f84e36?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`8672f5a`](https://app.codecov.io/gh/apache/hudi/commit/8672f5a2e49b977425781da43d41af4573f5f4f9?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). Additional details and impacted files ```diff @@Coverage Diff@@ ## master #18639 +/- ## = Coverage 68.06% 68.07% + Complexity2891928911-8 = Files 2518 2518 Lines140570 140571+1 Branches 1741617419+3 = + Hits 9568095692 +12 + Misses3703337022 -11 Partials 7857 7857 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.37% <100.00%> (+<0.01%)` | :arrow_up: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.84% <0.00%> (+<0.01%)` | :arrow_up: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.43% <0.00%> (+<0.01%)` | :arrow_up: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.60% <100.00%> (-0.05%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.69% <0.00%> (-0.01%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.68% <0.00%> (+<0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18639?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...java/org/apache/hudi/BaseHoodieTableFileIndex.java](https://app.codecov.io/gh/apache/hudi/pull/18639?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2FBaseHoodieTableFileIndex.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvQmFzZUhvb2RpZVRhYmxlRmlsZUluZGV4LmphdmE=) | `89.34% <100.00%> (+5.80%)` | :arrow_up: | ... and [10 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18639/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) :rocket: New features to boost your workflow: - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this
Re: [PR] [MINOR] Fix NPE in getInputFileSlices when RO path filter returns empty partition [hudi]
codecov-commenter commented on PR #18639: URL: https://github.com/apache/hudi/pull/18639#issuecomment-4340445706 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18639?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 68.07%. Comparing base ([`642e1d3`](https://app.codecov.io/gh/apache/hudi/commit/642e1d33e12073060a620788987c3ce4b7f84e36?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`8672f5a`](https://app.codecov.io/gh/apache/hudi/commit/8672f5a2e49b977425781da43d41af4573f5f4f9?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). Additional details and impacted files ```diff @@Coverage Diff@@ ## master #18639 +/- ## = Coverage 68.06% 68.07% + Complexity2891928910-9 = Files 2518 2518 Lines140570 140571+1 Branches 1741617419+3 = + Hits 9568095691 +11 + Misses3703337022 -11 - Partials 7857 7858+1 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.37% <100.00%> (+<0.01%)` | :arrow_up: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.84% <0.00%> (+<0.01%)` | :arrow_up: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.43% <0.00%> (+<0.01%)` | :arrow_up: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.60% <100.00%> (-0.05%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.69% <0.00%> (-0.01%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.68% <0.00%> (+<0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18639?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...java/org/apache/hudi/BaseHoodieTableFileIndex.java](https://app.codecov.io/gh/apache/hudi/pull/18639?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2FBaseHoodieTableFileIndex.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvQmFzZUhvb2RpZVRhYmxlRmlsZUluZGV4LmphdmE=) | `89.34% <100.00%> (+5.80%)` | :arrow_up: | ... and [10 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18639/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) :rocket: New features to boost your workflow: - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this
Re: [PR] [MINOR] Fix NPE in getInputFileSlices when RO path filter returns empty partition [hudi]
danny0405 commented on code in PR #18639: URL: https://github.com/apache/hudi/pull/18639#discussion_r3158262682 ## hudi-common/src/main/java/org/apache/hudi/BaseHoodieTableFileIndex.java: ## @@ -314,6 +314,11 @@ private Map> generatePartitionFileSlicesPostROTab Map partitionsMap = new HashMap<>(); partitions.forEach(p -> partitionsMap.put(p.path, p)); Map> partitionToFileSlices = new HashMap<>(); +// Pre-populate so partitions with no files still appear in the result map. +// Without this, the caller's Collectors.toMap(identity, cache::get) NPEs on empty partitions +// because cache.get returns null and toMap rejects null values. This matches the contract +// already honored by filterFiles, which iterates over partitions rather than over files. +partitions.forEach(p -> partitionToFileSlices.put(p, new ArrayList<>())); Review Comment: > When Path A is taken, `cachedAllInputFileSlices` is left without entries for empty partitions. should we fix the path A `generatePartitionFileSlicesPostROTablePathFilter` to set up the cache correctly with empty list instead of nulls? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] [MINOR] Fix NPE in getInputFileSlices when RO path filter returns empty partition [hudi]
codecov-commenter commented on PR #18639: URL: https://github.com/apache/hudi/pull/18639#issuecomment-4340415694 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18639?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 68.07%. Comparing base ([`642e1d3`](https://app.codecov.io/gh/apache/hudi/commit/642e1d33e12073060a620788987c3ce4b7f84e36?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`8672f5a`](https://app.codecov.io/gh/apache/hudi/commit/8672f5a2e49b977425781da43d41af4573f5f4f9?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). Additional details and impacted files ```diff @@Coverage Diff@@ ## master #18639 +/- ## = Coverage 68.06% 68.07% + Complexity2891928909 -10 = Files 2518 2518 Lines140570 140571+1 Branches 1741617419+3 = + Hits 9568095688+8 + Misses3703337025-8 - Partials 7857 7858+1 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.37% <100.00%> (+<0.01%)` | :arrow_up: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.84% <0.00%> (+<0.01%)` | :arrow_up: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.43% <0.00%> (+<0.01%)` | :arrow_up: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.57% <100.00%> (-0.09%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.69% <0.00%> (-0.01%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.68% <0.00%> (+<0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18639?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...java/org/apache/hudi/BaseHoodieTableFileIndex.java](https://app.codecov.io/gh/apache/hudi/pull/18639?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2FBaseHoodieTableFileIndex.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvQmFzZUhvb2RpZVRhYmxlRmlsZUluZGV4LmphdmE=) | `89.34% <100.00%> (+5.80%)` | :arrow_up: | ... and [13 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18639/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) :rocket: New features to boost your workflow: - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this
Re: [PR] [MINOR] Fix NPE in getInputFileSlices when RO path filter returns empty partition [hudi]
codecov-commenter commented on PR #18639: URL: https://github.com/apache/hudi/pull/18639#issuecomment-4340410510 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18639?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 68.06%. Comparing base ([`642e1d3`](https://app.codecov.io/gh/apache/hudi/commit/642e1d33e12073060a620788987c3ce4b7f84e36?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`8672f5a`](https://app.codecov.io/gh/apache/hudi/commit/8672f5a2e49b977425781da43d41af4573f5f4f9?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). Additional details and impacted files ```diff @@Coverage Diff@@ ## master #18639 +/- ## = Coverage 68.06% 68.06% + Complexity2891928908 -11 = Files 2518 2518 Lines140570 140571+1 Branches 1741617419+3 = + Hits 9568095684+4 + Misses3703337028-5 - Partials 7857 7859+2 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.37% <100.00%> (+<0.01%)` | :arrow_up: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.84% <0.00%> (+<0.01%)` | :arrow_up: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.43% <0.00%> (+<0.01%)` | :arrow_up: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.54% <100.00%> (-0.11%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.69% <0.00%> (-0.01%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.68% <0.00%> (+<0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18639?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...java/org/apache/hudi/BaseHoodieTableFileIndex.java](https://app.codecov.io/gh/apache/hudi/pull/18639?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2FBaseHoodieTableFileIndex.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvQmFzZUhvb2RpZVRhYmxlRmlsZUluZGV4LmphdmE=) | `89.34% <100.00%> (+5.80%)` | :arrow_up: | ... and [15 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18639/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) :rocket: New features to boost your workflow: - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this
Re: [PR] [MINOR] Fix NPE in getInputFileSlices when RO path filter returns empty partition [hudi]
codecov-commenter commented on PR #18639: URL: https://github.com/apache/hudi/pull/18639#issuecomment-4340407211 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18639?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 68.06%. Comparing base ([`642e1d3`](https://app.codecov.io/gh/apache/hudi/commit/642e1d33e12073060a620788987c3ce4b7f84e36?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`8672f5a`](https://app.codecov.io/gh/apache/hudi/commit/8672f5a2e49b977425781da43d41af4573f5f4f9?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). Additional details and impacted files ```diff @@Coverage Diff@@ ## master #18639 +/- ## = Coverage 68.06% 68.06% + Complexity2891928908 -11 = Files 2518 2518 Lines140570 140571+1 Branches 1741617419+3 = + Hits 9568095684+4 + Misses3703337028-5 - Partials 7857 7859+2 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.37% <100.00%> (+<0.01%)` | :arrow_up: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.84% <0.00%> (+<0.01%)` | :arrow_up: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.43% <0.00%> (+<0.01%)` | :arrow_up: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.51% <100.00%> (-0.14%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.69% <0.00%> (-0.01%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.68% <0.00%> (+<0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18639?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...java/org/apache/hudi/BaseHoodieTableFileIndex.java](https://app.codecov.io/gh/apache/hudi/pull/18639?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2FBaseHoodieTableFileIndex.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvQmFzZUhvb2RpZVRhYmxlRmlsZUluZGV4LmphdmE=) | `89.34% <100.00%> (+5.80%)` | :arrow_up: | ... and [15 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18639/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) :rocket: New features to boost your workflow: - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this
Re: [PR] [MINOR] Fix NPE in getInputFileSlices when RO path filter returns empty partition [hudi]
codecov-commenter commented on PR #18639: URL: https://github.com/apache/hudi/pull/18639#issuecomment-4340402079 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18639?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 68.04%. Comparing base ([`642e1d3`](https://app.codecov.io/gh/apache/hudi/commit/642e1d33e12073060a620788987c3ce4b7f84e36?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`8672f5a`](https://app.codecov.io/gh/apache/hudi/commit/8672f5a2e49b977425781da43d41af4573f5f4f9?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18639 +/- ## - Coverage 68.06% 68.04% -0.03% + Complexity2891928897 -22 Files 2518 2518 Lines140570 140571 +1 Branches 1741617419 +3 - Hits 9568095649 -31 - Misses3703337078 +45 + Partials 7857 7844 -13 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.37% <100.00%> (+<0.01%)` | :arrow_up: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.84% <0.00%> (+<0.01%)` | :arrow_up: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.43% <0.00%> (+<0.01%)` | :arrow_up: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.38% <100.00%> (-0.27%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.69% <0.00%> (-0.01%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.68% <0.00%> (+<0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18639?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...java/org/apache/hudi/BaseHoodieTableFileIndex.java](https://app.codecov.io/gh/apache/hudi/pull/18639?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2FBaseHoodieTableFileIndex.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvQmFzZUhvb2RpZVRhYmxlRmlsZUluZGV4LmphdmE=) | `89.34% <100.00%> (+5.80%)` | :arrow_up: | ... and [20 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18639/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) :rocket: New features to boost your workflow: - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:
Re: [PR] [MINOR] Fix NPE in getInputFileSlices when RO path filter returns empty partition [hudi]
codecov-commenter commented on PR #18639: URL: https://github.com/apache/hudi/pull/18639#issuecomment-4340398634 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18639?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 67.29%. Comparing base ([`642e1d3`](https://app.codecov.io/gh/apache/hudi/commit/642e1d33e12073060a620788987c3ce4b7f84e36?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`8672f5a`](https://app.codecov.io/gh/apache/hudi/commit/8672f5a2e49b977425781da43d41af4573f5f4f9?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18639 +/- ## - Coverage 68.06% 67.29% -0.77% + Complexity2891928594 -325 Files 2518 2518 Lines140570 140571 +1 Branches 1741617419 +3 - Hits 9568094602-1078 - Misses3703338067+1034 - Partials 7857 7902 +45 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.37% <100.00%> (+<0.01%)` | :arrow_up: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.84% <0.00%> (+<0.01%)` | :arrow_up: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.43% <0.00%> (+<0.01%)` | :arrow_up: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.04% <100.00%> (-3.62%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.69% <0.00%> (-0.01%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.68% <0.00%> (+<0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18639?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...java/org/apache/hudi/BaseHoodieTableFileIndex.java](https://app.codecov.io/gh/apache/hudi/pull/18639?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2FBaseHoodieTableFileIndex.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvQmFzZUhvb2RpZVRhYmxlRmlsZUluZGV4LmphdmE=) | `89.34% <100.00%> (+5.80%)` | :arrow_up: | ... and [138 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18639/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) :rocket: New features to boost your workflow: - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:
Re: [PR] [MINOR] Fix NPE in getInputFileSlices when RO path filter returns empty partition [hudi]
codecov-commenter commented on PR #18639: URL: https://github.com/apache/hudi/pull/18639#issuecomment-4340396974 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18639?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 67.14%. Comparing base ([`642e1d3`](https://app.codecov.io/gh/apache/hudi/commit/642e1d33e12073060a620788987c3ce4b7f84e36?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`8672f5a`](https://app.codecov.io/gh/apache/hudi/commit/8672f5a2e49b977425781da43d41af4573f5f4f9?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18639 +/- ## - Coverage 68.06% 67.14% -0.93% + Complexity2891928491 -428 Files 2518 2518 Lines140570 140571 +1 Branches 1741617419 +3 - Hits 9568094382-1298 - Misses3703338313+1280 - Partials 7857 7876 +19 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.37% <100.00%> (+<0.01%)` | :arrow_up: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.84% <0.00%> (+<0.01%)` | :arrow_up: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.43% <0.00%> (+<0.01%)` | :arrow_up: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.68% <100.00%> (-3.97%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.61% <0.00%> (-0.09%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.68% <0.00%> (+<0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18639?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...java/org/apache/hudi/BaseHoodieTableFileIndex.java](https://app.codecov.io/gh/apache/hudi/pull/18639?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2FBaseHoodieTableFileIndex.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvQmFzZUhvb2RpZVRhYmxlRmlsZUluZGV4LmphdmE=) | `89.34% <100.00%> (+5.80%)` | :arrow_up: | ... and [162 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18639/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) :rocket: New features to boost your workflow: - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:
Re: [PR] [MINOR] Fix NPE in getInputFileSlices when RO path filter returns empty partition [hudi]
codecov-commenter commented on PR #18639: URL: https://github.com/apache/hudi/pull/18639#issuecomment-4340394071 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18639?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `0%` with `1 line` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 62.78%. Comparing base ([`642e1d3`](https://app.codecov.io/gh/apache/hudi/commit/642e1d33e12073060a620788987c3ce4b7f84e36?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`8672f5a`](https://app.codecov.io/gh/apache/hudi/commit/8672f5a2e49b977425781da43d41af4573f5f4f9?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18639?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...java/org/apache/hudi/BaseHoodieTableFileIndex.java](https://app.codecov.io/gh/apache/hudi/pull/18639?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2FBaseHoodieTableFileIndex.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvQmFzZUhvb2RpZVRhYmxlRmlsZUluZGV4LmphdmE=) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18639?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | > :exclamation: There is a different number of reports uploaded between BASE (642e1d3) and HEAD (8672f5a). Click for more details. > > HEAD has 13 uploads less than BASE > >| Flag | BASE (642e1d3) | HEAD (8672f5a) | >|--|--|--| >|spark-scala-tests|12|10| >|spark-java-tests|18|8| >|common-and-other-modules|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18639 +/- ## - Coverage 68.06% 62.78% -5.29% + Complexity2891922242-6677 Files 2518 2047 -471 Lines140570 116952 -23618 Branches 1741615205-2211 - Hits 9568073429 -22251 + Misses3703336309 -724 + Partials 7857 7214 -643 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.84% <0.00%> (+<0.01%)` | :arrow_up: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.43% <0.00%> (+<0.01%)` | :arrow_up: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `42.28% <0.00%> (-6.38%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.61% <0.00%> (-0.10%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.68% <0.00%> (+<0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing
Re: [PR] [MINOR] Fix NPE in getInputFileSlices when RO path filter returns empty partition [hudi]
danny0405 commented on code in PR #18639: URL: https://github.com/apache/hudi/pull/18639#discussion_r3158262682 ## hudi-common/src/main/java/org/apache/hudi/BaseHoodieTableFileIndex.java: ## @@ -314,6 +314,11 @@ private Map> generatePartitionFileSlicesPostROTab Map partitionsMap = new HashMap<>(); partitions.forEach(p -> partitionsMap.put(p.path, p)); Map> partitionToFileSlices = new HashMap<>(); +// Pre-populate so partitions with no files still appear in the result map. +// Without this, the caller's Collectors.toMap(identity, cache::get) NPEs on empty partitions +// because cache.get returns null and toMap rejects null values. This matches the contract +// already honored by filterFiles, which iterates over partitions rather than over files. +partitions.forEach(p -> partitionToFileSlices.put(p, new ArrayList<>())); Review Comment: why put the nulls instead of empty list in the cache then? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] [MINOR] Fix NPE in getInputFileSlices when RO path filter returns empty partition [hudi]
codecov-commenter commented on PR #18639: URL: https://github.com/apache/hudi/pull/18639#issuecomment-4340385716 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18639?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `0%` with `1 line` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 62.75%. Comparing base ([`642e1d3`](https://app.codecov.io/gh/apache/hudi/commit/642e1d33e12073060a620788987c3ce4b7f84e36?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`8672f5a`](https://app.codecov.io/gh/apache/hudi/commit/8672f5a2e49b977425781da43d41af4573f5f4f9?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18639?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...java/org/apache/hudi/BaseHoodieTableFileIndex.java](https://app.codecov.io/gh/apache/hudi/pull/18639?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2FBaseHoodieTableFileIndex.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvQmFzZUhvb2RpZVRhYmxlRmlsZUluZGV4LmphdmE=) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18639?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | > :exclamation: There is a different number of reports uploaded between BASE (642e1d3) and HEAD (8672f5a). Click for more details. > > HEAD has 14 uploads less than BASE > >| Flag | BASE (642e1d3) | HEAD (8672f5a) | >|--|--|--| >|spark-scala-tests|12|10| >|spark-java-tests|18|7| >|common-and-other-modules|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18639 +/- ## - Coverage 68.06% 62.75% -5.32% + Complexity2891922230-6689 Files 2518 2047 -471 Lines140570 116952 -23618 Branches 1741615205-2211 - Hits 9568073390 -22290 + Misses3703336363 -670 + Partials 7857 7199 -658 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.84% <0.00%> (+<0.01%)` | :arrow_up: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.43% <0.00%> (+<0.01%)` | :arrow_up: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `42.15% <0.00%> (-6.51%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.61% <0.00%> (-0.10%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.68% <0.00%> (+<0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing
Re: [PR] [MINOR] Fix NPE in getInputFileSlices when RO path filter returns empty partition [hudi]
codecov-commenter commented on PR #18639: URL: https://github.com/apache/hudi/pull/18639#issuecomment-4340382329 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18639?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `0%` with `1 line` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 62.70%. Comparing base ([`642e1d3`](https://app.codecov.io/gh/apache/hudi/commit/642e1d33e12073060a620788987c3ce4b7f84e36?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`8672f5a`](https://app.codecov.io/gh/apache/hudi/commit/8672f5a2e49b977425781da43d41af4573f5f4f9?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18639?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...java/org/apache/hudi/BaseHoodieTableFileIndex.java](https://app.codecov.io/gh/apache/hudi/pull/18639?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2FBaseHoodieTableFileIndex.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvQmFzZUhvb2RpZVRhYmxlRmlsZUluZGV4LmphdmE=) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18639?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | > :exclamation: There is a different number of reports uploaded between BASE (642e1d3) and HEAD (8672f5a). Click for more details. > > HEAD has 15 uploads less than BASE > >| Flag | BASE (642e1d3) | HEAD (8672f5a) | >|--|--|--| >|spark-scala-tests|12|9| >|spark-java-tests|18|7| >|common-and-other-modules|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18639 +/- ## - Coverage 68.06% 62.70% -5.37% + Complexity2891922197-6722 Files 2518 2047 -471 Lines140570 116952 -23618 Branches 1741615205-2211 - Hits 9568073331 -22349 + Misses3703336434 -599 + Partials 7857 7187 -670 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.84% <0.00%> (+<0.01%)` | :arrow_up: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.43% <0.00%> (+<0.01%)` | :arrow_up: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `42.15% <0.00%> (-6.51%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.53% <0.00%> (-0.17%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.68% <0.00%> (+<0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing
Re: [PR] [MINOR] Fix NPE in getInputFileSlices when RO path filter returns empty partition [hudi]
codecov-commenter commented on PR #18639: URL: https://github.com/apache/hudi/pull/18639#issuecomment-4340381366 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18639?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `0%` with `1 line` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 62.70%. Comparing base ([`642e1d3`](https://app.codecov.io/gh/apache/hudi/commit/642e1d33e12073060a620788987c3ce4b7f84e36?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`8672f5a`](https://app.codecov.io/gh/apache/hudi/commit/8672f5a2e49b977425781da43d41af4573f5f4f9?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18639?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...java/org/apache/hudi/BaseHoodieTableFileIndex.java](https://app.codecov.io/gh/apache/hudi/pull/18639?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2FBaseHoodieTableFileIndex.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvQmFzZUhvb2RpZVRhYmxlRmlsZUluZGV4LmphdmE=) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18639?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | > :exclamation: There is a different number of reports uploaded between BASE (642e1d3) and HEAD (8672f5a). Click for more details. > > HEAD has 15 uploads less than BASE > >| Flag | BASE (642e1d3) | HEAD (8672f5a) | >|--|--|--| >|spark-scala-tests|12|9| >|spark-java-tests|18|7| >|common-and-other-modules|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18639 +/- ## - Coverage 68.06% 62.70% -5.37% + Complexity2891922197-6722 Files 2518 2047 -471 Lines140570 116952 -23618 Branches 1741615205-2211 - Hits 9568073331 -22349 + Misses3703336434 -599 + Partials 7857 7187 -670 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.84% <0.00%> (+<0.01%)` | :arrow_up: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.43% <0.00%> (+<0.01%)` | :arrow_up: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `42.15% <0.00%> (-6.51%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.53% <0.00%> (-0.17%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.68% <0.00%> (+<0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing
Re: [PR] [MINOR] Fix NPE in getInputFileSlices when RO path filter returns empty partition [hudi]
codecov-commenter commented on PR #18639: URL: https://github.com/apache/hudi/pull/18639#issuecomment-4340373742 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18639?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `0%` with `1 line` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 62.45%. Comparing base ([`642e1d3`](https://app.codecov.io/gh/apache/hudi/commit/642e1d33e12073060a620788987c3ce4b7f84e36?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`8672f5a`](https://app.codecov.io/gh/apache/hudi/commit/8672f5a2e49b977425781da43d41af4573f5f4f9?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18639?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...java/org/apache/hudi/BaseHoodieTableFileIndex.java](https://app.codecov.io/gh/apache/hudi/pull/18639?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2FBaseHoodieTableFileIndex.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvQmFzZUhvb2RpZVRhYmxlRmlsZUluZGV4LmphdmE=) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18639?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | > :exclamation: There is a different number of reports uploaded between BASE (642e1d3) and HEAD (8672f5a). Click for more details. > > HEAD has 17 uploads less than BASE > >| Flag | BASE (642e1d3) | HEAD (8672f5a) | >|--|--|--| >|spark-scala-tests|12|7| >|spark-java-tests|18|7| >|common-and-other-modules|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18639 +/- ## - Coverage 68.06% 62.45% -5.61% + Complexity2891922103-6816 Files 2518 2047 -471 Lines140570 116952 -23618 Branches 1741615205-2211 - Hits 9568073045 -22635 + Misses3703336723 -310 + Partials 7857 7184 -673 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.84% <0.00%> (+<0.01%)` | :arrow_up: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.43% <0.00%> (+<0.01%)` | :arrow_up: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `42.15% <0.00%> (-6.51%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.10% <0.00%> (-0.61%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.68% <0.00%> (+<0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing
Re: [PR] [MINOR] Fix NPE in getInputFileSlices when RO path filter returns empty partition [hudi]
codecov-commenter commented on PR #18639: URL: https://github.com/apache/hudi/pull/18639#issuecomment-4340367803 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18639?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `0%` with `1 line` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 57.45%. Comparing base ([`642e1d3`](https://app.codecov.io/gh/apache/hudi/commit/642e1d33e12073060a620788987c3ce4b7f84e36?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`8672f5a`](https://app.codecov.io/gh/apache/hudi/commit/8672f5a2e49b977425781da43d41af4573f5f4f9?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18639?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...java/org/apache/hudi/BaseHoodieTableFileIndex.java](https://app.codecov.io/gh/apache/hudi/pull/18639?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2FBaseHoodieTableFileIndex.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvQmFzZUhvb2RpZVRhYmxlRmlsZUluZGV4LmphdmE=) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18639?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | > :exclamation: There is a different number of reports uploaded between BASE (642e1d3) and HEAD (8672f5a). Click for more details. > > HEAD has 18 uploads less than BASE > >| Flag | BASE (642e1d3) | HEAD (8672f5a) | >|--|--|--| >|spark-scala-tests|12|6| >|spark-java-tests|18|7| >|common-and-other-modules|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18639 +/- ## = - Coverage 68.06% 57.45% -10.61% + Complexity2891920329 -8590 = Files 2518 2047 -471 Lines140570 116952-23618 Branches 1741615205 -2211 = - Hits 9568067198-28482 - Misses3703342983 +5950 + Partials 7857 6771 -1086 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.84% <0.00%> (+<0.01%)` | :arrow_up: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.43% <0.00%> (+<0.01%)` | :arrow_up: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `42.15% <0.00%> (-6.51%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.55% <0.00%> (-12.16%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.68% <0.00%> (+<0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing
Re: [PR] [MINOR] Fix NPE in getInputFileSlices when RO path filter returns empty partition [hudi]
codecov-commenter commented on PR #18639: URL: https://github.com/apache/hudi/pull/18639#issuecomment-4340367213 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18639?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `0%` with `1 line` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 57.45%. Comparing base ([`642e1d3`](https://app.codecov.io/gh/apache/hudi/commit/642e1d33e12073060a620788987c3ce4b7f84e36?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`8672f5a`](https://app.codecov.io/gh/apache/hudi/commit/8672f5a2e49b977425781da43d41af4573f5f4f9?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18639?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...java/org/apache/hudi/BaseHoodieTableFileIndex.java](https://app.codecov.io/gh/apache/hudi/pull/18639?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2FBaseHoodieTableFileIndex.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvQmFzZUhvb2RpZVRhYmxlRmlsZUluZGV4LmphdmE=) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18639?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | > :exclamation: There is a different number of reports uploaded between BASE (642e1d3) and HEAD (8672f5a). Click for more details. > > HEAD has 18 uploads less than BASE > >| Flag | BASE (642e1d3) | HEAD (8672f5a) | >|--|--|--| >|spark-scala-tests|12|6| >|spark-java-tests|18|7| >|common-and-other-modules|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18639 +/- ## = - Coverage 68.06% 57.45% -10.61% + Complexity2891920329 -8590 = Files 2518 2047 -471 Lines140570 116952-23618 Branches 1741615205 -2211 = - Hits 9568067198-28482 - Misses3703342983 +5950 + Partials 7857 6771 -1086 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.84% <0.00%> (+<0.01%)` | :arrow_up: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.43% <0.00%> (+<0.01%)` | :arrow_up: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `42.15% <0.00%> (-6.51%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.55% <0.00%> (-12.16%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.68% <0.00%> (+<0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing
Re: [PR] [MINOR] Fix NPE in getInputFileSlices when RO path filter returns empty partition [hudi]
codecov-commenter commented on PR #18639: URL: https://github.com/apache/hudi/pull/18639#issuecomment-4340349691 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18639?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `0%` with `1 line` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 48.12%. Comparing base ([`642e1d3`](https://app.codecov.io/gh/apache/hudi/commit/642e1d33e12073060a620788987c3ce4b7f84e36?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`8672f5a`](https://app.codecov.io/gh/apache/hudi/commit/8672f5a2e49b977425781da43d41af4573f5f4f9?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18639?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...java/org/apache/hudi/BaseHoodieTableFileIndex.java](https://app.codecov.io/gh/apache/hudi/pull/18639?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2FBaseHoodieTableFileIndex.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvQmFzZUhvb2RpZVRhYmxlRmlsZUluZGV4LmphdmE=) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18639?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | > :exclamation: There is a different number of reports uploaded between BASE (642e1d3) and HEAD (8672f5a). Click for more details. > > HEAD has 24 uploads less than BASE > >| Flag | BASE (642e1d3) | HEAD (8672f5a) | >|--|--|--| >|spark-scala-tests|12|5| >|spark-java-tests|18|3| >|utilities|1|0| >|common-and-other-modules|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18639 +/- ## = - Coverage 68.06% 48.12% -19.95% + Complexity2891916810-12109 = Files 2518 2030 -488 Lines140570 114585-25985 Branches 1741614696 -2720 = - Hits 9568055141-40539 - Misses3703353502+16469 + Partials 7857 5942 -1915 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.84% <0.00%> (+<0.01%)` | :arrow_up: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.43% <0.00%> (+<0.01%)` | :arrow_up: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.33% <0.00%> (-16.32%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.73% <0.00%> (-11.98%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing
Re: [PR] [MINOR] Fix NPE in getInputFileSlices when RO path filter returns empty partition [hudi]
codecov-commenter commented on PR #18639: URL: https://github.com/apache/hudi/pull/18639#issuecomment-4340353614 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18639?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `0%` with `1 line` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 47.69%. Comparing base ([`642e1d3`](https://app.codecov.io/gh/apache/hudi/commit/642e1d33e12073060a620788987c3ce4b7f84e36?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`8672f5a`](https://app.codecov.io/gh/apache/hudi/commit/8672f5a2e49b977425781da43d41af4573f5f4f9?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18639?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...java/org/apache/hudi/BaseHoodieTableFileIndex.java](https://app.codecov.io/gh/apache/hudi/pull/18639?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2FBaseHoodieTableFileIndex.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvQmFzZUhvb2RpZVRhYmxlRmlsZUluZGV4LmphdmE=) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18639?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | > :exclamation: There is a different number of reports uploaded between BASE (642e1d3) and HEAD (8672f5a). Click for more details. > > HEAD has 20 uploads less than BASE > >| Flag | BASE (642e1d3) | HEAD (8672f5a) | >|--|--|--| >|spark-scala-tests|12|6| >|spark-java-tests|18|6| >|utilities|1|0| >|common-and-other-modules|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18639 +/- ## = - Coverage 68.06% 47.69% -20.38% + Complexity2891917030-11889 = Files 2518 2047 -471 Lines140570 116952-23618 Branches 1741615205 -2211 = - Hits 9568055781-39899 - Misses3703355053+18020 + Partials 7857 6118 -1739 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.84% <0.00%> (+<0.01%)` | :arrow_up: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.43% <0.00%> (+<0.01%)` | :arrow_up: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `31.61% <0.00%> (-17.05%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.55% <0.00%> (-12.16%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing
Re: [PR] [MINOR] Fix NPE in getInputFileSlices when RO path filter returns empty partition [hudi]
codecov-commenter commented on PR #18639: URL: https://github.com/apache/hudi/pull/18639#issuecomment-4340349101 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18639?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `0%` with `1 line` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 48.09%. Comparing base ([`642e1d3`](https://app.codecov.io/gh/apache/hudi/commit/642e1d33e12073060a620788987c3ce4b7f84e36?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`8672f5a`](https://app.codecov.io/gh/apache/hudi/commit/8672f5a2e49b977425781da43d41af4573f5f4f9?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18639?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...java/org/apache/hudi/BaseHoodieTableFileIndex.java](https://app.codecov.io/gh/apache/hudi/pull/18639?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2FBaseHoodieTableFileIndex.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvQmFzZUhvb2RpZVRhYmxlRmlsZUluZGV4LmphdmE=) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18639?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | > :exclamation: There is a different number of reports uploaded between BASE (642e1d3) and HEAD (8672f5a). Click for more details. > > HEAD has 25 uploads less than BASE > >| Flag | BASE (642e1d3) | HEAD (8672f5a) | >|--|--|--| >|spark-scala-tests|12|5| >|spark-java-tests|18|2| >|utilities|1|0| >|common-and-other-modules|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18639 +/- ## = - Coverage 68.06% 48.09% -19.98% + Complexity2891916800-12119 = Files 2518 2030 -488 Lines140570 114585-25985 Branches 1741614696 -2720 = - Hits 9568055108-40572 - Misses3703353531+16498 + Partials 7857 5946 -1911 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.84% <0.00%> (+<0.01%)` | :arrow_up: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.43% <0.00%> (+<0.01%)` | :arrow_up: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.76% <0.00%> (-15.90%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.73% <0.00%> (-11.98%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing
Re: [PR] [MINOR] Fix NPE in getInputFileSlices when RO path filter returns empty partition [hudi]
codecov-commenter commented on PR #18639: URL: https://github.com/apache/hudi/pull/18639#issuecomment-4340351198 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18639?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `0%` with `1 line` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 47.69%. Comparing base ([`642e1d3`](https://app.codecov.io/gh/apache/hudi/commit/642e1d33e12073060a620788987c3ce4b7f84e36?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`8672f5a`](https://app.codecov.io/gh/apache/hudi/commit/8672f5a2e49b977425781da43d41af4573f5f4f9?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18639?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...java/org/apache/hudi/BaseHoodieTableFileIndex.java](https://app.codecov.io/gh/apache/hudi/pull/18639?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2FBaseHoodieTableFileIndex.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvQmFzZUhvb2RpZVRhYmxlRmlsZUluZGV4LmphdmE=) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18639?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | > :exclamation: There is a different number of reports uploaded between BASE (642e1d3) and HEAD (8672f5a). Click for more details. > > HEAD has 21 uploads less than BASE > >| Flag | BASE (642e1d3) | HEAD (8672f5a) | >|--|--|--| >|spark-scala-tests|12|6| >|spark-java-tests|18|5| >|utilities|1|0| >|common-and-other-modules|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18639 +/- ## = - Coverage 68.06% 47.69% -20.38% + Complexity2891917030-11889 = Files 2518 2047 -471 Lines140570 116952-23618 Branches 1741615205 -2211 = - Hits 9568055781-39899 - Misses3703355053+18020 + Partials 7857 6118 -1739 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.84% <0.00%> (+<0.01%)` | :arrow_up: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.43% <0.00%> (+<0.01%)` | :arrow_up: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `31.61% <0.00%> (-17.05%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.55% <0.00%> (-12.16%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing
Re: [PR] [MINOR] Fix NPE in getInputFileSlices when RO path filter returns empty partition [hudi]
codecov-commenter commented on PR #18639: URL: https://github.com/apache/hudi/pull/18639#issuecomment-4340351595 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18639?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `0%` with `1 line` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 47.69%. Comparing base ([`642e1d3`](https://app.codecov.io/gh/apache/hudi/commit/642e1d33e12073060a620788987c3ce4b7f84e36?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`8672f5a`](https://app.codecov.io/gh/apache/hudi/commit/8672f5a2e49b977425781da43d41af4573f5f4f9?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18639?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...java/org/apache/hudi/BaseHoodieTableFileIndex.java](https://app.codecov.io/gh/apache/hudi/pull/18639?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2FBaseHoodieTableFileIndex.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvQmFzZUhvb2RpZVRhYmxlRmlsZUluZGV4LmphdmE=) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18639?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | > :exclamation: There is a different number of reports uploaded between BASE (642e1d3) and HEAD (8672f5a). Click for more details. > > HEAD has 21 uploads less than BASE > >| Flag | BASE (642e1d3) | HEAD (8672f5a) | >|--|--|--| >|spark-scala-tests|12|6| >|spark-java-tests|18|5| >|utilities|1|0| >|common-and-other-modules|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18639 +/- ## = - Coverage 68.06% 47.69% -20.38% + Complexity2891917030-11889 = Files 2518 2047 -471 Lines140570 116952-23618 Branches 1741615205 -2211 = - Hits 9568055781-39899 - Misses3703355053+18020 + Partials 7857 6118 -1739 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.84% <0.00%> (+<0.01%)` | :arrow_up: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.43% <0.00%> (+<0.01%)` | :arrow_up: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `31.61% <0.00%> (-17.05%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.55% <0.00%> (-12.16%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing
Re: [PR] [MINOR] Fix NPE in getInputFileSlices when RO path filter returns empty partition [hudi]
codecov-commenter commented on PR #18639: URL: https://github.com/apache/hudi/pull/18639#issuecomment-4340346022 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18639?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `0%` with `1 line` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 48.05%. Comparing base ([`642e1d3`](https://app.codecov.io/gh/apache/hudi/commit/642e1d33e12073060a620788987c3ce4b7f84e36?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`8672f5a`](https://app.codecov.io/gh/apache/hudi/commit/8672f5a2e49b977425781da43d41af4573f5f4f9?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18639?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...java/org/apache/hudi/BaseHoodieTableFileIndex.java](https://app.codecov.io/gh/apache/hudi/pull/18639?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2FBaseHoodieTableFileIndex.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvQmFzZUhvb2RpZVRhYmxlRmlsZUluZGV4LmphdmE=) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18639?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | > :exclamation: There is a different number of reports uploaded between BASE (642e1d3) and HEAD (8672f5a). Click for more details. > > HEAD has 26 uploads less than BASE > >| Flag | BASE (642e1d3) | HEAD (8672f5a) | >|--|--|--| >|spark-scala-tests|12|5| >|spark-java-tests|18|1| >|utilities|1|0| >|common-and-other-modules|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18639 +/- ## = - Coverage 68.06% 48.05% -20.02% + Complexity2891916786-12133 = Files 2518 2030 -488 Lines140570 114585-25985 Branches 1741614696 -2720 = - Hits 9568055061-40619 - Misses3703353566+16533 + Partials 7857 5958 -1899 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.84% <0.00%> (+<0.01%)` | :arrow_up: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.43% <0.00%> (+<0.01%)` | :arrow_up: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.14% <0.00%> (-15.52%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.73% <0.00%> (-11.98%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing
Re: [PR] [MINOR] Fix NPE in getInputFileSlices when RO path filter returns empty partition [hudi]
codecov-commenter commented on PR #18639: URL: https://github.com/apache/hudi/pull/18639#issuecomment-4340345334 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18639?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `0%` with `1 line` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 47.79%. Comparing base ([`642e1d3`](https://app.codecov.io/gh/apache/hudi/commit/642e1d33e12073060a620788987c3ce4b7f84e36?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`8672f5a`](https://app.codecov.io/gh/apache/hudi/commit/8672f5a2e49b977425781da43d41af4573f5f4f9?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18639?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...java/org/apache/hudi/BaseHoodieTableFileIndex.java](https://app.codecov.io/gh/apache/hudi/pull/18639?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2FBaseHoodieTableFileIndex.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvQmFzZUhvb2RpZVRhYmxlRmlsZUluZGV4LmphdmE=) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18639?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | > :exclamation: There is a different number of reports uploaded between BASE (642e1d3) and HEAD (8672f5a). Click for more details. > > HEAD has 27 uploads less than BASE > >| Flag | BASE (642e1d3) | HEAD (8672f5a) | >|--|--|--| >|spark-scala-tests|12|4| >|spark-java-tests|18|1| >|utilities|1|0| >|common-and-other-modules|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18639 +/- ## = - Coverage 68.06% 47.79% -20.28% + Complexity2891916645-12274 = Files 2518 2030 -488 Lines140570 114585-25985 Branches 1741614696 -2720 = - Hits 9568054766-40914 - Misses3703353960+16927 + Partials 7857 5859 -1998 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.84% <0.00%> (+<0.01%)` | :arrow_up: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.43% <0.00%> (+<0.01%)` | :arrow_up: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.14% <0.00%> (-15.52%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.92% <0.00%> (-11.79%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing
Re: [PR] [MINOR] Fix NPE in getInputFileSlices when RO path filter returns empty partition [hudi]
codecov-commenter commented on PR #18639: URL: https://github.com/apache/hudi/pull/18639#issuecomment-4340339734 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18639?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `0%` with `1 line` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 48.27%. Comparing base ([`642e1d3`](https://app.codecov.io/gh/apache/hudi/commit/642e1d33e12073060a620788987c3ce4b7f84e36?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`8672f5a`](https://app.codecov.io/gh/apache/hudi/commit/8672f5a2e49b977425781da43d41af4573f5f4f9?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18639?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...java/org/apache/hudi/BaseHoodieTableFileIndex.java](https://app.codecov.io/gh/apache/hudi/pull/18639?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2FBaseHoodieTableFileIndex.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvQmFzZUhvb2RpZVRhYmxlRmlsZUluZGV4LmphdmE=) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18639?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | > :exclamation: There is a different number of reports uploaded between BASE (642e1d3) and HEAD (8672f5a). Click for more details. > > HEAD has 28 uploads less than BASE > >| Flag | BASE (642e1d3) | HEAD (8672f5a) | >|--|--|--| >|spark-scala-tests|12|3| >|spark-java-tests|18|1| >|utilities|1|0| >|common-and-other-modules|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18639 +/- ## = - Coverage 68.06% 48.27% -19.80% + Complexity2891916441-12478 = Files 2518 2012 -506 Lines140570 112202-28368 Branches 1741614184 -3232 = - Hits 9568054163-41517 - Misses3703352373+15340 + Partials 7857 5666 -2191 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.84% <0.00%> (+<0.01%)` | :arrow_up: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.43% <0.00%> (+<0.01%)` | :arrow_up: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.14% <0.00%> (-15.52%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.07% <0.00%> (-11.63%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing
Re: [PR] [MINOR] Fix NPE in getInputFileSlices when RO path filter returns empty partition [hudi]
codecov-commenter commented on PR #18639: URL: https://github.com/apache/hudi/pull/18639#issuecomment-4340339238 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18639?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `0%` with `1 line` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 48.27%. Comparing base ([`642e1d3`](https://app.codecov.io/gh/apache/hudi/commit/642e1d33e12073060a620788987c3ce4b7f84e36?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`8672f5a`](https://app.codecov.io/gh/apache/hudi/commit/8672f5a2e49b977425781da43d41af4573f5f4f9?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18639?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...java/org/apache/hudi/BaseHoodieTableFileIndex.java](https://app.codecov.io/gh/apache/hudi/pull/18639?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2FBaseHoodieTableFileIndex.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvQmFzZUhvb2RpZVRhYmxlRmlsZUluZGV4LmphdmE=) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18639?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | > :exclamation: There is a different number of reports uploaded between BASE (642e1d3) and HEAD (8672f5a). Click for more details. > > HEAD has 28 uploads less than BASE > >| Flag | BASE (642e1d3) | HEAD (8672f5a) | >|--|--|--| >|spark-scala-tests|12|3| >|spark-java-tests|18|1| >|utilities|1|0| >|common-and-other-modules|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18639 +/- ## = - Coverage 68.06% 48.27% -19.80% + Complexity2891916441-12478 = Files 2518 2012 -506 Lines140570 112202-28368 Branches 1741614184 -3232 = - Hits 9568054163-41517 - Misses3703352373+15340 + Partials 7857 5666 -2191 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.84% <0.00%> (+<0.01%)` | :arrow_up: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.43% <0.00%> (+<0.01%)` | :arrow_up: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.14% <0.00%> (-15.52%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.07% <0.00%> (-11.63%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing
Re: [PR] [MINOR] Fix NPE in getInputFileSlices when RO path filter returns empty partition [hudi]
codecov-commenter commented on PR #18639: URL: https://github.com/apache/hudi/pull/18639#issuecomment-4340338591 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18639?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `0%` with `1 line` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 48.27%. Comparing base ([`642e1d3`](https://app.codecov.io/gh/apache/hudi/commit/642e1d33e12073060a620788987c3ce4b7f84e36?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`8672f5a`](https://app.codecov.io/gh/apache/hudi/commit/8672f5a2e49b977425781da43d41af4573f5f4f9?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18639?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...java/org/apache/hudi/BaseHoodieTableFileIndex.java](https://app.codecov.io/gh/apache/hudi/pull/18639?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2FBaseHoodieTableFileIndex.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvQmFzZUhvb2RpZVRhYmxlRmlsZUluZGV4LmphdmE=) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18639?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | > :exclamation: There is a different number of reports uploaded between BASE (642e1d3) and HEAD (8672f5a). Click for more details. > > HEAD has 28 uploads less than BASE > >| Flag | BASE (642e1d3) | HEAD (8672f5a) | >|--|--|--| >|spark-scala-tests|12|3| >|spark-java-tests|18|1| >|utilities|1|0| >|common-and-other-modules|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18639 +/- ## = - Coverage 68.06% 48.27% -19.80% + Complexity2891916441-12478 = Files 2518 2012 -506 Lines140570 112202-28368 Branches 1741614184 -3232 = - Hits 9568054163-41517 - Misses3703352373+15340 + Partials 7857 5666 -2191 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.84% <0.00%> (+<0.01%)` | :arrow_up: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.43% <0.00%> (+<0.01%)` | :arrow_up: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.14% <0.00%> (-15.52%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.07% <0.00%> (-11.63%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing
Re: [PR] [MINOR] Fix NPE in getInputFileSlices when RO path filter returns empty partition [hudi]
codecov-commenter commented on PR #18639: URL: https://github.com/apache/hudi/pull/18639#issuecomment-4340335862 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18639?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `0%` with `1 line` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 46.61%. Comparing base ([`642e1d3`](https://app.codecov.io/gh/apache/hudi/commit/642e1d33e12073060a620788987c3ce4b7f84e36?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`8672f5a`](https://app.codecov.io/gh/apache/hudi/commit/8672f5a2e49b977425781da43d41af4573f5f4f9?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18639?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...java/org/apache/hudi/BaseHoodieTableFileIndex.java](https://app.codecov.io/gh/apache/hudi/pull/18639?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2FBaseHoodieTableFileIndex.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvQmFzZUhvb2RpZVRhYmxlRmlsZUluZGV4LmphdmE=) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18639?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | > :exclamation: There is a different number of reports uploaded between BASE (642e1d3) and HEAD (8672f5a). Click for more details. > > HEAD has 31 uploads less than BASE > >| Flag | BASE (642e1d3) | HEAD (8672f5a) | >|--|--|--| >|spark-scala-tests|12|1| >|spark-java-tests|18|0| >|utilities|1|0| >|common-and-other-modules|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18639 +/- ## = - Coverage 68.06% 46.61% -21.45% + Complexity2891915232-13687 = Files 2518 1964 -554 Lines140570 106939-33631 Branches 1741613026 -4390 = - Hits 9568049853-45827 - Misses3703351889+14856 + Partials 7857 5197 -2660 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.84% <0.00%> (+<0.01%)` | :arrow_up: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.43% <0.00%> (+<0.01%)` | :arrow_up: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.07% <0.00%> (-11.64%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing
Re: [PR] [MINOR] Fix NPE in getInputFileSlices when RO path filter returns empty partition [hudi]
codecov-commenter commented on PR #18639: URL: https://github.com/apache/hudi/pull/18639#issuecomment-4340301142 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18639?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `0%` with `1 line` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 53.95%. Comparing base ([`642e1d3`](https://app.codecov.io/gh/apache/hudi/commit/642e1d33e12073060a620788987c3ce4b7f84e36?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`8672f5a`](https://app.codecov.io/gh/apache/hudi/commit/8672f5a2e49b977425781da43d41af4573f5f4f9?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18639?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...java/org/apache/hudi/BaseHoodieTableFileIndex.java](https://app.codecov.io/gh/apache/hudi/pull/18639?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2FBaseHoodieTableFileIndex.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvQmFzZUhvb2RpZVRhYmxlRmlsZUluZGV4LmphdmE=) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18639?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | > :exclamation: There is a different number of reports uploaded between BASE (642e1d3) and HEAD (8672f5a). Click for more details. > > HEAD has 32 uploads less than BASE > >| Flag | BASE (642e1d3) | HEAD (8672f5a) | >|--|--|--| >|spark-scala-tests|12|0| >|spark-java-tests|18|0| >|utilities|1|0| >|common-and-other-modules|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18639 +/- ## = - Coverage 68.06% 53.95% -14.12% + Complexity2891912405-16514 = Files 2518 1433 -1085 Lines14057071971-68599 Branches 17416 8204 -9212 = - Hits 9568038831-56849 + Misses3703329659 -7374 + Partials 7857 3481 -4376 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.84% <0.00%> (+<0.01%)` | :arrow_up: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.43% <0.00%> (+<0.01%)` | :arrow_up: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18639?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
Re: [PR] [MINOR] Fix NPE in getInputFileSlices when RO path filter returns empty partition [hudi]
hudi-bot commented on PR #18639: URL: https://github.com/apache/hudi/pull/18639#issuecomment-4340300597 ## CI report: * 8672f5a2e49b977425781da43d41af4573f5f4f9 Azure: [FAILURE](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13706) Bot commands @hudi-bot supports the following commands: - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] [MINOR] Fix NPE in getInputFileSlices when RO path filter returns empty partition [hudi]
codecov-commenter commented on PR #18639: URL: https://github.com/apache/hudi/pull/18639#issuecomment-4340240437 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18639?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `0%` with `1 line` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 44.84%. Comparing base ([`642e1d3`](https://app.codecov.io/gh/apache/hudi/commit/642e1d33e12073060a620788987c3ce4b7f84e36?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`8672f5a`](https://app.codecov.io/gh/apache/hudi/commit/8672f5a2e49b977425781da43d41af4573f5f4f9?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18639?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...java/org/apache/hudi/BaseHoodieTableFileIndex.java](https://app.codecov.io/gh/apache/hudi/pull/18639?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2FBaseHoodieTableFileIndex.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvQmFzZUhvb2RpZVRhYmxlRmlsZUluZGV4LmphdmE=) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18639?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | > :exclamation: There is a different number of reports uploaded between BASE (642e1d3) and HEAD (8672f5a). Click for more details. > > HEAD has 33 uploads less than BASE > >| Flag | BASE (642e1d3) | HEAD (8672f5a) | >|--|--|--| >|spark-client-hadoop-common|1|0| >|spark-scala-tests|12|0| >|spark-java-tests|18|0| >|utilities|1|0| >|common-and-other-modules|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18639 +/- ## = - Coverage 68.06% 44.84% -23.23% + Complexity28919 8519-20400 = Files 2518 1201 -1317 Lines14057062651-77919 Branches 17416 6778-10638 = - Hits 9568028094-67586 + Misses3703331470 -5563 + Partials 7857 3087 -4770 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.84% <0.00%> (+<0.01%)` | :arrow_up: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18639/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18639?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
Re: [PR] [MINOR] Fix NPE in getInputFileSlices when RO path filter returns empty partition [hudi]
hudi-bot commented on PR #18639: URL: https://github.com/apache/hudi/pull/18639#issuecomment-4340218545 ## CI report: * 8672f5a2e49b977425781da43d41af4573f5f4f9 Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13706) Bot commands @hudi-bot supports the following commands: - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] [MINOR] Fix NPE in getInputFileSlices when RO path filter returns empty partition [hudi]
hudi-bot commented on PR #18639: URL: https://github.com/apache/hudi/pull/18639#issuecomment-4340209515 ## CI report: * 8672f5a2e49b977425781da43d41af4573f5f4f9 UNKNOWN Bot commands @hudi-bot supports the following commands: - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] [MINOR] Fix NPE in getInputFileSlices when RO path filter returns empty partition [hudi]
hudi-agent commented on code in PR #18639:
URL: https://github.com/apache/hudi/pull/18639#discussion_r3158109334
##
hudi-common/src/test/java/org/apache/hudi/BaseHoodieTableFileIndexTest.java:
##
@@ -58,4 +68,63 @@ public void testGetMetadataConfigReturnsFieldValue() throws
Exception {
assertEquals(true, result.isBloomFilterIndexEnabled(), "Bloom filter index
should be enabled");
assertEquals(true, result.isColumnStatsIndexEnabled(), "Column stats index
should be enabled");
}
+
+ /**
+ * Regression test for the empty-partition NPE that surfaces in {@code
getInputFileSlices}
+ * when the {@code
hoodie.datasource.read.file.index.list.file.statuses.using.ro.path.filter}
+ * code path is exercised on a COW (or READ_OPTIMIZED) table that contains a
partition
+ * holding zero base files.
+ *
+ * Before the fix, {@link
BaseHoodieTableFileIndex#generatePartitionFileSlicesPostROTablePathFilter}
+ * built its result map by iterating over the file list, so a partition with
no files received
+ * no entry. The downstream {@code Collectors.toMap(identity, p ->
cache.get(p))} in
+ * {@code getInputFileSlices} then dereferenced a null value and threw NPE
inside
+ * {@code Collectors.uniqKeysMapAccumulator}.
+ *
+ * After the fix, every input partition appears in the returned map (with
an empty list
+ * for empty partitions), preserving the contract already honored by the
non-RO path
+ * ({@code filterFiles}).
+ */
+ @Test
+ public void
testGeneratePartitionFileSlicesPostROTablePathFilterIncludesEmptyPartitions()
throws Exception {
+BaseHoodieTableFileIndex fileIndex = mock(BaseHoodieTableFileIndex.class,
+org.mockito.Mockito.CALLS_REAL_METHODS);
Review Comment:
🤖 nit: `mock` on the line above is already statically imported, so it might
be worth adding `import static org.mockito.Mockito.CALLS_REAL_METHODS;` and
just writing `CALLS_REAL_METHODS` here for consistency.
- AI-generated; verify before applying. React 👍/👎 to flag
quality.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
