Re: [PR] feat(table-services): Emit archival metrics for monitoring and debugging [hudi]
codecov-commenter commented on PR #18133: URL: https://github.com/apache/hudi/pull/18133#issuecomment-3961903338 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18133?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `68.42105%` with `18 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 57.28%. Comparing base ([`894b817`](https://app.codecov.io/gh/apache/hudi/commit/894b817f79af42fa61179ed9d0842d61e7d3c07c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`ade22f9`](https://app.codecov.io/gh/apache/hudi/commit/ade22f9fa39582247d65d6434f66deb766433f03?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 4 commits behind head on master. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18133?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...ent/timeline/versioning/v1/TimelineArchiverV1.java](https://app.codecov.io/gh/apache/hudi/pull/18133?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv1%2FTimelineArchiverV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YxL1RpbWVsaW5lQXJjaGl2ZXJWMS5qYXZh) | 50.00% | [7 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18133?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...ent/timeline/versioning/v2/TimelineArchiverV2.java](https://app.codecov.io/gh/apache/hudi/pull/18133?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv2%2FTimelineArchiverV2.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YyL1RpbWVsaW5lQXJjaGl2ZXJWMi5qYXZh) | 50.00% | [7 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18133?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...ache/hudi/client/BaseHoodieTableServiceClient.java](https://app.codecov.io/gh/apache/hudi/pull/18133?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieTableServiceClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllVGFibGVTZXJ2aWNlQ2xpZW50LmphdmE=) | 75.00% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18133?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...e/hudi/client/timeline/HoodieTimelineArchiver.java](https://app.codecov.io/gh/apache/hudi/pull/18133?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2FHoodieTimelineArchiver.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS9Ib29kaWVUaW1lbGluZUFyY2hpdmVyLmphdmE=) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18133?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Additional details and impacted files ```diff @@Coverage Diff@@ ## master #18133 +/- ## = Coverage 57.28% 57.28% - Complexity1853518545 +10 = Files 1944 1945+1 Lines106137 106191 +54 Branches 1311913122+3 = + Hits 6079860831 +33 - Misses3961739637 +20 - Partials 5722 5723+1 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18133/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_cam
Re: [PR] feat(table-services): Emit archival metrics for monitoring and debugging [hudi]
codecov-commenter commented on PR #18133: URL: https://github.com/apache/hudi/pull/18133#issuecomment-3961879729 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18133?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `68.42105%` with `18 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 57.28%. Comparing base ([`894b817`](https://app.codecov.io/gh/apache/hudi/commit/894b817f79af42fa61179ed9d0842d61e7d3c07c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`ade22f9`](https://app.codecov.io/gh/apache/hudi/commit/ade22f9fa39582247d65d6434f66deb766433f03?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 4 commits behind head on master. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18133?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...ent/timeline/versioning/v1/TimelineArchiverV1.java](https://app.codecov.io/gh/apache/hudi/pull/18133?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv1%2FTimelineArchiverV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YxL1RpbWVsaW5lQXJjaGl2ZXJWMS5qYXZh) | 50.00% | [7 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18133?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...ent/timeline/versioning/v2/TimelineArchiverV2.java](https://app.codecov.io/gh/apache/hudi/pull/18133?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv2%2FTimelineArchiverV2.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YyL1RpbWVsaW5lQXJjaGl2ZXJWMi5qYXZh) | 50.00% | [7 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18133?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...ache/hudi/client/BaseHoodieTableServiceClient.java](https://app.codecov.io/gh/apache/hudi/pull/18133?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieTableServiceClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllVGFibGVTZXJ2aWNlQ2xpZW50LmphdmE=) | 75.00% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18133?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...e/hudi/client/timeline/HoodieTimelineArchiver.java](https://app.codecov.io/gh/apache/hudi/pull/18133?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2FHoodieTimelineArchiver.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS9Ib29kaWVUaW1lbGluZUFyY2hpdmVyLmphdmE=) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18133?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Additional details and impacted files ```diff @@Coverage Diff@@ ## master #18133 +/- ## = Coverage 57.28% 57.28% - Complexity1853518545 +10 = Files 1944 1945+1 Lines106137 106191 +54 Branches 1311913122+3 = + Hits 6079860831 +33 - Misses3961739637 +20 - Partials 5722 5723+1 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18133/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_cam
Re: [PR] feat(table-services): Emit archival metrics for monitoring and debugging [hudi]
codecov-commenter commented on PR #18133: URL: https://github.com/apache/hudi/pull/18133#issuecomment-3961856793 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18133?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `68.42105%` with `18 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 57.27%. Comparing base ([`894b817`](https://app.codecov.io/gh/apache/hudi/commit/894b817f79af42fa61179ed9d0842d61e7d3c07c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`ade22f9`](https://app.codecov.io/gh/apache/hudi/commit/ade22f9fa39582247d65d6434f66deb766433f03?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 4 commits behind head on master. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18133?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...ent/timeline/versioning/v1/TimelineArchiverV1.java](https://app.codecov.io/gh/apache/hudi/pull/18133?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv1%2FTimelineArchiverV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YxL1RpbWVsaW5lQXJjaGl2ZXJWMS5qYXZh) | 50.00% | [7 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18133?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...ent/timeline/versioning/v2/TimelineArchiverV2.java](https://app.codecov.io/gh/apache/hudi/pull/18133?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv2%2FTimelineArchiverV2.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YyL1RpbWVsaW5lQXJjaGl2ZXJWMi5qYXZh) | 50.00% | [7 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18133?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...ache/hudi/client/BaseHoodieTableServiceClient.java](https://app.codecov.io/gh/apache/hudi/pull/18133?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieTableServiceClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllVGFibGVTZXJ2aWNlQ2xpZW50LmphdmE=) | 75.00% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18133?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...e/hudi/client/timeline/HoodieTimelineArchiver.java](https://app.codecov.io/gh/apache/hudi/pull/18133?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2FHoodieTimelineArchiver.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS9Ib29kaWVUaW1lbGluZUFyY2hpdmVyLmphdmE=) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18133?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18133 +/- ## - Coverage 57.28% 57.27% -0.01% - Complexity1853518542 +7 Files 1944 1945 +1 Lines106137 106191 +54 Branches 1311913122 +3 + Hits 6079860823 +25 - Misses3961739642 +25 - Partials 5722 5726 +4 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18133/flags?src=pr&el=flags&utm_medium=referral&utm_so
Re: [PR] feat(table-services): Emit archival metrics for monitoring and debugging [hudi]
codecov-commenter commented on PR #18133: URL: https://github.com/apache/hudi/pull/18133#issuecomment-3961815269 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18133?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `68.42105%` with `18 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 55.55%. Comparing base ([`894b817`](https://app.codecov.io/gh/apache/hudi/commit/894b817f79af42fa61179ed9d0842d61e7d3c07c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`ade22f9`](https://app.codecov.io/gh/apache/hudi/commit/ade22f9fa39582247d65d6434f66deb766433f03?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 4 commits behind head on master. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18133?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...ent/timeline/versioning/v1/TimelineArchiverV1.java](https://app.codecov.io/gh/apache/hudi/pull/18133?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv1%2FTimelineArchiverV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YxL1RpbWVsaW5lQXJjaGl2ZXJWMS5qYXZh) | 50.00% | [7 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18133?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...ent/timeline/versioning/v2/TimelineArchiverV2.java](https://app.codecov.io/gh/apache/hudi/pull/18133?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv2%2FTimelineArchiverV2.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YyL1RpbWVsaW5lQXJjaGl2ZXJWMi5qYXZh) | 50.00% | [7 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18133?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...ache/hudi/client/BaseHoodieTableServiceClient.java](https://app.codecov.io/gh/apache/hudi/pull/18133?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieTableServiceClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllVGFibGVTZXJ2aWNlQ2xpZW50LmphdmE=) | 75.00% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18133?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...e/hudi/client/timeline/HoodieTimelineArchiver.java](https://app.codecov.io/gh/apache/hudi/pull/18133?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2FHoodieTimelineArchiver.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS9Ib29kaWVUaW1lbGluZUFyY2hpdmVyLmphdmE=) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18133?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18133 +/- ## - Coverage 57.28% 55.55% -1.74% + Complexity1853517928 -607 Files 1944 1945 +1 Lines106137 106191 +54 Branches 1311913122 +3 - Hits 6079858991-1807 - Misses3961741408+1791 - Partials 5722 5792 +70 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18133/flags?src=pr&el=flags&utm_medium=referral&utm_so
Re: [PR] feat(table-services): Emit archival metrics for monitoring and debugging [hudi]
codecov-commenter commented on PR #18133: URL: https://github.com/apache/hudi/pull/18133#issuecomment-3961808555 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18133?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `68.42105%` with `18 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 55.48%. Comparing base ([`894b817`](https://app.codecov.io/gh/apache/hudi/commit/894b817f79af42fa61179ed9d0842d61e7d3c07c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`ade22f9`](https://app.codecov.io/gh/apache/hudi/commit/ade22f9fa39582247d65d6434f66deb766433f03?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 4 commits behind head on master. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18133?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...ent/timeline/versioning/v1/TimelineArchiverV1.java](https://app.codecov.io/gh/apache/hudi/pull/18133?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv1%2FTimelineArchiverV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YxL1RpbWVsaW5lQXJjaGl2ZXJWMS5qYXZh) | 50.00% | [7 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18133?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...ent/timeline/versioning/v2/TimelineArchiverV2.java](https://app.codecov.io/gh/apache/hudi/pull/18133?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv2%2FTimelineArchiverV2.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YyL1RpbWVsaW5lQXJjaGl2ZXJWMi5qYXZh) | 50.00% | [7 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18133?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...ache/hudi/client/BaseHoodieTableServiceClient.java](https://app.codecov.io/gh/apache/hudi/pull/18133?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieTableServiceClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllVGFibGVTZXJ2aWNlQ2xpZW50LmphdmE=) | 75.00% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18133?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...e/hudi/client/timeline/HoodieTimelineArchiver.java](https://app.codecov.io/gh/apache/hudi/pull/18133?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2FHoodieTimelineArchiver.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS9Ib29kaWVUaW1lbGluZUFyY2hpdmVyLmphdmE=) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18133?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18133 +/- ## - Coverage 57.28% 55.48% -1.80% + Complexity1853517899 -636 Files 1944 1945 +1 Lines106137 106191 +54 Branches 1311913122 +3 - Hits 6079858918-1880 - Misses3961741469+1852 - Partials 5722 5804 +82 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18133/flags?src=pr&el=flags&utm_medium=referral&utm_so
Re: [PR] feat(table-services): Emit archival metrics for monitoring and debugging [hudi]
codecov-commenter commented on PR #18133: URL: https://github.com/apache/hudi/pull/18133#issuecomment-3961804899 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18133?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `68.42105%` with `18 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 55.44%. Comparing base ([`894b817`](https://app.codecov.io/gh/apache/hudi/commit/894b817f79af42fa61179ed9d0842d61e7d3c07c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`ade22f9`](https://app.codecov.io/gh/apache/hudi/commit/ade22f9fa39582247d65d6434f66deb766433f03?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 4 commits behind head on master. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18133?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...ent/timeline/versioning/v1/TimelineArchiverV1.java](https://app.codecov.io/gh/apache/hudi/pull/18133?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv1%2FTimelineArchiverV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YxL1RpbWVsaW5lQXJjaGl2ZXJWMS5qYXZh) | 50.00% | [7 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18133?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...ent/timeline/versioning/v2/TimelineArchiverV2.java](https://app.codecov.io/gh/apache/hudi/pull/18133?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv2%2FTimelineArchiverV2.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YyL1RpbWVsaW5lQXJjaGl2ZXJWMi5qYXZh) | 50.00% | [7 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18133?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...ache/hudi/client/BaseHoodieTableServiceClient.java](https://app.codecov.io/gh/apache/hudi/pull/18133?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieTableServiceClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllVGFibGVTZXJ2aWNlQ2xpZW50LmphdmE=) | 75.00% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18133?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...e/hudi/client/timeline/HoodieTimelineArchiver.java](https://app.codecov.io/gh/apache/hudi/pull/18133?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2FHoodieTimelineArchiver.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS9Ib29kaWVUaW1lbGluZUFyY2hpdmVyLmphdmE=) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18133?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18133 +/- ## - Coverage 57.28% 55.44% -1.85% + Complexity1853517886 -649 Files 1944 1945 +1 Lines106137 106191 +54 Branches 1311913122 +3 - Hits 6079858875-1923 - Misses3961741514+1897 - Partials 5722 5802 +80 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18133/flags?src=pr&el=flags&utm_medium=referral&utm_so
Re: [PR] feat(table-services): Emit archival metrics for monitoring and debugging [hudi]
codecov-commenter commented on PR #18133: URL: https://github.com/apache/hudi/pull/18133#issuecomment-3961803277 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18133?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `68.42105%` with `18 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 55.36%. Comparing base ([`894b817`](https://app.codecov.io/gh/apache/hudi/commit/894b817f79af42fa61179ed9d0842d61e7d3c07c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`ade22f9`](https://app.codecov.io/gh/apache/hudi/commit/ade22f9fa39582247d65d6434f66deb766433f03?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 4 commits behind head on master. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18133?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...ent/timeline/versioning/v1/TimelineArchiverV1.java](https://app.codecov.io/gh/apache/hudi/pull/18133?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv1%2FTimelineArchiverV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YxL1RpbWVsaW5lQXJjaGl2ZXJWMS5qYXZh) | 50.00% | [7 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18133?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...ent/timeline/versioning/v2/TimelineArchiverV2.java](https://app.codecov.io/gh/apache/hudi/pull/18133?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv2%2FTimelineArchiverV2.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YyL1RpbWVsaW5lQXJjaGl2ZXJWMi5qYXZh) | 50.00% | [7 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18133?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...ache/hudi/client/BaseHoodieTableServiceClient.java](https://app.codecov.io/gh/apache/hudi/pull/18133?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieTableServiceClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllVGFibGVTZXJ2aWNlQ2xpZW50LmphdmE=) | 75.00% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18133?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...e/hudi/client/timeline/HoodieTimelineArchiver.java](https://app.codecov.io/gh/apache/hudi/pull/18133?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2FHoodieTimelineArchiver.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS9Ib29kaWVUaW1lbGluZUFyY2hpdmVyLmphdmE=) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18133?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18133 +/- ## - Coverage 57.28% 55.36% -1.92% + Complexity1853517864 -671 Files 1944 1945 +1 Lines106137 106191 +54 Branches 1311913122 +3 - Hits 6079858793-2005 - Misses3961741581+1964 - Partials 5722 5817 +95 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18133/flags?src=pr&el=flags&utm_medium=referral&utm_so
Re: [PR] feat(table-services): Emit archival metrics for monitoring and debugging [hudi]
codecov-commenter commented on PR #18133: URL: https://github.com/apache/hudi/pull/18133#issuecomment-3961801346 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18133?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `68.42105%` with `18 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 55.19%. Comparing base ([`894b817`](https://app.codecov.io/gh/apache/hudi/commit/894b817f79af42fa61179ed9d0842d61e7d3c07c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`ade22f9`](https://app.codecov.io/gh/apache/hudi/commit/ade22f9fa39582247d65d6434f66deb766433f03?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 4 commits behind head on master. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18133?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...ent/timeline/versioning/v1/TimelineArchiverV1.java](https://app.codecov.io/gh/apache/hudi/pull/18133?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv1%2FTimelineArchiverV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YxL1RpbWVsaW5lQXJjaGl2ZXJWMS5qYXZh) | 50.00% | [7 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18133?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...ent/timeline/versioning/v2/TimelineArchiverV2.java](https://app.codecov.io/gh/apache/hudi/pull/18133?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv2%2FTimelineArchiverV2.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YyL1RpbWVsaW5lQXJjaGl2ZXJWMi5qYXZh) | 50.00% | [7 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18133?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...ache/hudi/client/BaseHoodieTableServiceClient.java](https://app.codecov.io/gh/apache/hudi/pull/18133?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieTableServiceClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllVGFibGVTZXJ2aWNlQ2xpZW50LmphdmE=) | 75.00% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18133?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...e/hudi/client/timeline/HoodieTimelineArchiver.java](https://app.codecov.io/gh/apache/hudi/pull/18133?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2FHoodieTimelineArchiver.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS9Ib29kaWVUaW1lbGluZUFyY2hpdmVyLmphdmE=) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18133?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18133 +/- ## - Coverage 57.28% 55.19% -2.09% + Complexity1853517827 -708 Files 1944 1945 +1 Lines106137 106191 +54 Branches 1311913122 +3 - Hits 6079858610-2188 - Misses3961741778+2161 - Partials 5722 5803 +81 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18133/flags?src=pr&el=flags&utm_medium=referral&utm_so
Re: [PR] feat(table-services): Emit archival metrics for monitoring and debugging [hudi]
codecov-commenter commented on PR #18133: URL: https://github.com/apache/hudi/pull/18133#issuecomment-3961791627 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18133?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `66.7%` with `19 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 43.55%. Comparing base ([`894b817`](https://app.codecov.io/gh/apache/hudi/commit/894b817f79af42fa61179ed9d0842d61e7d3c07c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`ade22f9`](https://app.codecov.io/gh/apache/hudi/commit/ade22f9fa39582247d65d6434f66deb766433f03?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 4 commits behind head on master. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18133?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...ent/timeline/versioning/v1/TimelineArchiverV1.java](https://app.codecov.io/gh/apache/hudi/pull/18133?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv1%2FTimelineArchiverV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YxL1RpbWVsaW5lQXJjaGl2ZXJWMS5qYXZh) | 43.75% | [8 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18133?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...ent/timeline/versioning/v2/TimelineArchiverV2.java](https://app.codecov.io/gh/apache/hudi/pull/18133?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv2%2FTimelineArchiverV2.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YyL1RpbWVsaW5lQXJjaGl2ZXJWMi5qYXZh) | 50.00% | [7 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18133?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...ache/hudi/client/BaseHoodieTableServiceClient.java](https://app.codecov.io/gh/apache/hudi/pull/18133?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieTableServiceClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllVGFibGVTZXJ2aWNlQ2xpZW50LmphdmE=) | 75.00% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18133?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...e/hudi/client/timeline/HoodieTimelineArchiver.java](https://app.codecov.io/gh/apache/hudi/pull/18133?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2FHoodieTimelineArchiver.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS9Ib29kaWVUaW1lbGluZUFyY2hpdmVyLmphdmE=) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18133?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | > :exclamation: There is a different number of reports uploaded between BASE (894b817) and HEAD (ade22f9). Click for more details. > > HEAD has 9 uploads less than BASE > >| Flag | BASE (894b817) | HEAD (ade22f9) | >|--|--|--| >|spark-scala-tests|6|3| >|spark-java-tests|9|3| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18133 +/- ## = - Coverage 57.28% 43.55% -13.74% + Complexity1853513846 -4689 = Files 1944 1945+1 Lines106137 106191 +54 Branches 1311913122
Re: [PR] feat(table-services): Emit archival metrics for monitoring and debugging [hudi]
codecov-commenter commented on PR #18133: URL: https://github.com/apache/hudi/pull/18133#issuecomment-3961757217 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18133?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `66.7%` with `19 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 43.51%. Comparing base ([`894b817`](https://app.codecov.io/gh/apache/hudi/commit/894b817f79af42fa61179ed9d0842d61e7d3c07c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`ade22f9`](https://app.codecov.io/gh/apache/hudi/commit/ade22f9fa39582247d65d6434f66deb766433f03?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 4 commits behind head on master. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18133?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...ent/timeline/versioning/v1/TimelineArchiverV1.java](https://app.codecov.io/gh/apache/hudi/pull/18133?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv1%2FTimelineArchiverV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YxL1RpbWVsaW5lQXJjaGl2ZXJWMS5qYXZh) | 43.75% | [8 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18133?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...ent/timeline/versioning/v2/TimelineArchiverV2.java](https://app.codecov.io/gh/apache/hudi/pull/18133?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv2%2FTimelineArchiverV2.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YyL1RpbWVsaW5lQXJjaGl2ZXJWMi5qYXZh) | 50.00% | [7 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18133?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...ache/hudi/client/BaseHoodieTableServiceClient.java](https://app.codecov.io/gh/apache/hudi/pull/18133?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieTableServiceClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllVGFibGVTZXJ2aWNlQ2xpZW50LmphdmE=) | 75.00% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18133?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...e/hudi/client/timeline/HoodieTimelineArchiver.java](https://app.codecov.io/gh/apache/hudi/pull/18133?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2FHoodieTimelineArchiver.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS9Ib29kaWVUaW1lbGluZUFyY2hpdmVyLmphdmE=) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18133?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | > :exclamation: There is a different number of reports uploaded between BASE (894b817) and HEAD (ade22f9). Click for more details. > > HEAD has 10 uploads less than BASE > >| Flag | BASE (894b817) | HEAD (ade22f9) | >|--|--|--| >|spark-scala-tests|6|3| >|spark-java-tests|9|2| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18133 +/- ## = - Coverage 57.28% 43.51% -13.77% + Complexity1853513835 -4700 = Files 1944 1945+1 Lines106137 106191 +54 Branches 131191312
Re: [PR] feat(table-services): Emit archival metrics for monitoring and debugging [hudi]
codecov-commenter commented on PR #18133: URL: https://github.com/apache/hudi/pull/18133#issuecomment-3961747805 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18133?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `66.7%` with `19 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 43.43%. Comparing base ([`894b817`](https://app.codecov.io/gh/apache/hudi/commit/894b817f79af42fa61179ed9d0842d61e7d3c07c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`ade22f9`](https://app.codecov.io/gh/apache/hudi/commit/ade22f9fa39582247d65d6434f66deb766433f03?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 4 commits behind head on master. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18133?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...ent/timeline/versioning/v1/TimelineArchiverV1.java](https://app.codecov.io/gh/apache/hudi/pull/18133?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv1%2FTimelineArchiverV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YxL1RpbWVsaW5lQXJjaGl2ZXJWMS5qYXZh) | 43.75% | [8 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18133?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...ent/timeline/versioning/v2/TimelineArchiverV2.java](https://app.codecov.io/gh/apache/hudi/pull/18133?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv2%2FTimelineArchiverV2.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YyL1RpbWVsaW5lQXJjaGl2ZXJWMi5qYXZh) | 50.00% | [7 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18133?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...ache/hudi/client/BaseHoodieTableServiceClient.java](https://app.codecov.io/gh/apache/hudi/pull/18133?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieTableServiceClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllVGFibGVTZXJ2aWNlQ2xpZW50LmphdmE=) | 75.00% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18133?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...e/hudi/client/timeline/HoodieTimelineArchiver.java](https://app.codecov.io/gh/apache/hudi/pull/18133?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2FHoodieTimelineArchiver.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS9Ib29kaWVUaW1lbGluZUFyY2hpdmVyLmphdmE=) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18133?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | > :exclamation: There is a different number of reports uploaded between BASE (894b817) and HEAD (ade22f9). Click for more details. > > HEAD has 11 uploads less than BASE > >| Flag | BASE (894b817) | HEAD (ade22f9) | >|--|--|--| >|spark-scala-tests|6|3| >|spark-java-tests|9|1| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18133 +/- ## = - Coverage 57.28% 43.43% -13.85% + Complexity1853513813 -4722 = Files 1944 1945+1 Lines106137 106191 +54 Branches 131191312
Re: [PR] feat(table-services): Emit archival metrics for monitoring and debugging [hudi]
codecov-commenter commented on PR #18133: URL: https://github.com/apache/hudi/pull/18133#issuecomment-3961742005 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18133?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `66.7%` with `19 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 39.73%. Comparing base ([`894b817`](https://app.codecov.io/gh/apache/hudi/commit/894b817f79af42fa61179ed9d0842d61e7d3c07c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`ade22f9`](https://app.codecov.io/gh/apache/hudi/commit/ade22f9fa39582247d65d6434f66deb766433f03?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 4 commits behind head on master. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18133?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...ent/timeline/versioning/v1/TimelineArchiverV1.java](https://app.codecov.io/gh/apache/hudi/pull/18133?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv1%2FTimelineArchiverV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YxL1RpbWVsaW5lQXJjaGl2ZXJWMS5qYXZh) | 43.75% | [8 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18133?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...ent/timeline/versioning/v2/TimelineArchiverV2.java](https://app.codecov.io/gh/apache/hudi/pull/18133?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv2%2FTimelineArchiverV2.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YyL1RpbWVsaW5lQXJjaGl2ZXJWMi5qYXZh) | 50.00% | [7 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18133?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...ache/hudi/client/BaseHoodieTableServiceClient.java](https://app.codecov.io/gh/apache/hudi/pull/18133?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieTableServiceClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllVGFibGVTZXJ2aWNlQ2xpZW50LmphdmE=) | 75.00% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18133?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...e/hudi/client/timeline/HoodieTimelineArchiver.java](https://app.codecov.io/gh/apache/hudi/pull/18133?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2FHoodieTimelineArchiver.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS9Ib29kaWVUaW1lbGluZUFyY2hpdmVyLmphdmE=) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18133?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | > :exclamation: There is a different number of reports uploaded between BASE (894b817) and HEAD (ade22f9). Click for more details. > > HEAD has 12 uploads less than BASE > >| Flag | BASE (894b817) | HEAD (ade22f9) | >|--|--|--| >|spark-scala-tests|6|3| >|spark-java-tests|9|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18133 +/- ## = - Coverage 57.28% 39.73% -17.55% + Complexity1853512590 -5945 = Files 1944 1945+1 Lines106137 106191 +54 Branches 131191312
Re: [PR] feat(table-services): Emit archival metrics for monitoring and debugging [hudi]
codecov-commenter commented on PR #18133: URL: https://github.com/apache/hudi/pull/18133#issuecomment-3961721572 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18133?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `66.7%` with `19 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 40.10%. Comparing base ([`894b817`](https://app.codecov.io/gh/apache/hudi/commit/894b817f79af42fa61179ed9d0842d61e7d3c07c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`ade22f9`](https://app.codecov.io/gh/apache/hudi/commit/ade22f9fa39582247d65d6434f66deb766433f03?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 4 commits behind head on master. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18133?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...ent/timeline/versioning/v1/TimelineArchiverV1.java](https://app.codecov.io/gh/apache/hudi/pull/18133?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv1%2FTimelineArchiverV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YxL1RpbWVsaW5lQXJjaGl2ZXJWMS5qYXZh) | 43.75% | [8 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18133?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...ent/timeline/versioning/v2/TimelineArchiverV2.java](https://app.codecov.io/gh/apache/hudi/pull/18133?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv2%2FTimelineArchiverV2.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YyL1RpbWVsaW5lQXJjaGl2ZXJWMi5qYXZh) | 50.00% | [7 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18133?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...ache/hudi/client/BaseHoodieTableServiceClient.java](https://app.codecov.io/gh/apache/hudi/pull/18133?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieTableServiceClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllVGFibGVTZXJ2aWNlQ2xpZW50LmphdmE=) | 75.00% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18133?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...e/hudi/client/timeline/HoodieTimelineArchiver.java](https://app.codecov.io/gh/apache/hudi/pull/18133?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2FHoodieTimelineArchiver.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS9Ib29kaWVUaW1lbGluZUFyY2hpdmVyLmphdmE=) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18133?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | > :exclamation: There is a different number of reports uploaded between BASE (894b817) and HEAD (ade22f9). Click for more details. > > HEAD has 13 uploads less than BASE > >| Flag | BASE (894b817) | HEAD (ade22f9) | >|--|--|--| >|spark-scala-tests|6|2| >|spark-java-tests|9|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18133 +/- ## = - Coverage 57.28% 40.10% -17.19% + Complexity1853512418 -6117 = Files 1944 1928 -16 Lines106137 103775 -2362 Branches 131191252
Re: [PR] feat(table-services): Emit archival metrics for monitoring and debugging [hudi]
codecov-commenter commented on PR #18133: URL: https://github.com/apache/hudi/pull/18133#issuecomment-3961714595 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18133?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `66.7%` with `19 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 40.54%. Comparing base ([`894b817`](https://app.codecov.io/gh/apache/hudi/commit/894b817f79af42fa61179ed9d0842d61e7d3c07c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`ade22f9`](https://app.codecov.io/gh/apache/hudi/commit/ade22f9fa39582247d65d6434f66deb766433f03?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 4 commits behind head on master. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18133?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...ent/timeline/versioning/v1/TimelineArchiverV1.java](https://app.codecov.io/gh/apache/hudi/pull/18133?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv1%2FTimelineArchiverV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YxL1RpbWVsaW5lQXJjaGl2ZXJWMS5qYXZh) | 43.75% | [8 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18133?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...ent/timeline/versioning/v2/TimelineArchiverV2.java](https://app.codecov.io/gh/apache/hudi/pull/18133?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv2%2FTimelineArchiverV2.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YyL1RpbWVsaW5lQXJjaGl2ZXJWMi5qYXZh) | 50.00% | [7 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18133?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...ache/hudi/client/BaseHoodieTableServiceClient.java](https://app.codecov.io/gh/apache/hudi/pull/18133?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieTableServiceClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllVGFibGVTZXJ2aWNlQ2xpZW50LmphdmE=) | 75.00% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18133?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...e/hudi/client/timeline/HoodieTimelineArchiver.java](https://app.codecov.io/gh/apache/hudi/pull/18133?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2FHoodieTimelineArchiver.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS9Ib29kaWVUaW1lbGluZUFyY2hpdmVyLmphdmE=) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18133?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | > :exclamation: There is a different number of reports uploaded between BASE (894b817) and HEAD (ade22f9). Click for more details. > > HEAD has 14 uploads less than BASE > >| Flag | BASE (894b817) | HEAD (ade22f9) | >|--|--|--| >|spark-scala-tests|6|1| >|spark-java-tests|9|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18133 +/- ## = - Coverage 57.28% 40.54% -16.74% + Complexity1853512253 -6282 = Files 1944 1911 -33 Lines106137 101440 -4697 Branches 131191202
Re: [PR] feat(table-services): Emit archival metrics for monitoring and debugging [hudi]
codecov-commenter commented on PR #18133: URL: https://github.com/apache/hudi/pull/18133#issuecomment-3961645241 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18133?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `66.7%` with `19 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 45.46%. Comparing base ([`894b817`](https://app.codecov.io/gh/apache/hudi/commit/894b817f79af42fa61179ed9d0842d61e7d3c07c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`ade22f9`](https://app.codecov.io/gh/apache/hudi/commit/ade22f9fa39582247d65d6434f66deb766433f03?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 4 commits behind head on master. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18133?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...ent/timeline/versioning/v1/TimelineArchiverV1.java](https://app.codecov.io/gh/apache/hudi/pull/18133?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv1%2FTimelineArchiverV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YxL1RpbWVsaW5lQXJjaGl2ZXJWMS5qYXZh) | 43.75% | [8 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18133?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...ent/timeline/versioning/v2/TimelineArchiverV2.java](https://app.codecov.io/gh/apache/hudi/pull/18133?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv2%2FTimelineArchiverV2.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YyL1RpbWVsaW5lQXJjaGl2ZXJWMi5qYXZh) | 50.00% | [7 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18133?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...ache/hudi/client/BaseHoodieTableServiceClient.java](https://app.codecov.io/gh/apache/hudi/pull/18133?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieTableServiceClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllVGFibGVTZXJ2aWNlQ2xpZW50LmphdmE=) | 75.00% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18133?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...e/hudi/client/timeline/HoodieTimelineArchiver.java](https://app.codecov.io/gh/apache/hudi/pull/18133?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2FHoodieTimelineArchiver.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS9Ib29kaWVUaW1lbGluZUFyY2hpdmVyLmphdmE=) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18133?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | > :exclamation: There is a different number of reports uploaded between BASE (894b817) and HEAD (ade22f9). Click for more details. > > HEAD has 15 uploads less than BASE > >| Flag | BASE (894b817) | HEAD (ade22f9) | >|--|--|--| >|spark-scala-tests|6|0| >|spark-java-tests|9|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18133 +/- ## = - Coverage 57.28% 45.46% -11.82% + Complexity18535 8392-10143 = Files 1944 1178 -766 Lines10613760293-45844 Branches 13119 641
Re: [PR] feat(table-services): Emit archival metrics for monitoring and debugging [hudi]
hudi-bot commented on PR #18133: URL: https://github.com/apache/hudi/pull/18133#issuecomment-3953082336 ## CI report: * ade22f9fa39582247d65d6434f66deb766433f03 Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12278) Bot commands @hudi-bot supports the following commands: - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] feat(table-services): Emit archival metrics for monitoring and debugging [hudi]
hudi-bot commented on PR #18133: URL: https://github.com/apache/hudi/pull/18133#issuecomment-3952392563 ## CI report: * 23a205e76d571cf699df8e9160cb05d360a61d2b Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12019) * ade22f9fa39582247d65d6434f66deb766433f03 Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12278) Bot commands @hudi-bot supports the following commands: - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] feat(table-services): Emit archival metrics for monitoring and debugging [hudi]
hudi-bot commented on PR #18133: URL: https://github.com/apache/hudi/pull/18133#issuecomment-3952361471 ## CI report: * 23a205e76d571cf699df8e9160cb05d360a61d2b Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12019) * ade22f9fa39582247d65d6434f66deb766433f03 UNKNOWN Bot commands @hudi-bot supports the following commands: - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] feat(table-services): Emit archival metrics for monitoring and debugging [hudi]
hudi-bot commented on PR #18133: URL: https://github.com/apache/hudi/pull/18133#issuecomment-3927951294 ## CI report: * 23a205e76d571cf699df8e9160cb05d360a61d2b Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12019) Bot commands @hudi-bot supports the following commands: - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] feat(table-services): Emit archival metrics for monitoring and debugging [hudi]
hudi-bot commented on PR #18133: URL: https://github.com/apache/hudi/pull/18133#issuecomment-3927931420 ## CI report: * 23a205e76d571cf699df8e9160cb05d360a61d2b Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12019) Bot commands @hudi-bot supports the following commands: - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] feat(table-services): Emit archival metrics for monitoring and debugging [hudi]
nada-attia commented on PR #18133: URL: https://github.com/apache/hudi/pull/18133#issuecomment-3927930227 @hudi-bot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] feat(table-services): Emit archival metrics for monitoring and debugging [hudi]
hudi-bot commented on PR #18133: URL: https://github.com/apache/hudi/pull/18133#issuecomment-3898672865 ## CI report: * 23a205e76d571cf699df8e9160cb05d360a61d2b Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12019) Bot commands @hudi-bot supports the following commands: - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] feat(table-services): Emit archival metrics for monitoring and debugging [hudi]
hudi-bot commented on PR #18133: URL: https://github.com/apache/hudi/pull/18133#issuecomment-3898274082 ## CI report: * 7b11dda49c475dd1e386d62dd8dda36c8ed49e54 Azure: [FAILURE](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=11899) * 23a205e76d571cf699df8e9160cb05d360a61d2b Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12019) Bot commands @hudi-bot supports the following commands: - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] feat(table-services): Emit archival metrics for monitoring and debugging [hudi]
nada-attia commented on code in PR #18133:
URL: https://github.com/apache/hudi/pull/18133#discussion_r2805190511
##
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/utils/ArchivalMetrics.java:
##
@@ -0,0 +1,34 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hudi.client.utils;
+
+/**
+ * Constants for archival metrics.
+ */
+public final class ArchivalMetrics {
Review Comment:
kept it as ArchivalMetrics since it now also contains utils method for
archival metrics. let me know if you agree on keeping it as ArchivalMetrics
##
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/utils/ArchivalMetrics.java:
##
@@ -0,0 +1,34 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hudi.client.utils;
+
+/**
+ * Constants for archival metrics.
+ */
+public final class ArchivalMetrics {
+ public static final String ARCHIVAL_OOM_FAILURE = "archivalOutOfMemory";
+ public static final String ARCHIVAL_NUM_ALL_COMMITS =
"archivalNumAllCommits";
+ public static final String ARCHIVAL_NUM_WRITE_COMMITS =
"archivalNumWriteCommits";
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] feat(table-services): Emit archival metrics for monitoring and debugging [hudi]
nada-attia commented on code in PR #18133: URL: https://github.com/apache/hudi/pull/18133#discussion_r2805187577 ## hudi-client/hudi-spark-client/src/test/java/org/apache/hudi/io/TestHoodieTimelineArchiver.java: ## @@ -2048,4 +2053,51 @@ private void assertInstantListEquals(List expected, List archiver.archiveIfRequired(context)); + +// Verify that OOM metric is recorded +Map metrics = archiver.getMetrics(); +assertEquals(1L, metrics.get(ArchivalMetrics.ARCHIVAL_OOM_FAILURE)); +assertEquals(17L, metrics.get(ArchivalMetrics.ARCHIVAL_NUM_ALL_COMMITS)); Review Comment: added another test case to verify the metric counts for all different types of commits archived (see testArchivalMetricsWithMixedActionTypes) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] feat(table-services): Emit archival metrics for monitoring and debugging [hudi]
nada-attia commented on code in PR #18133:
URL: https://github.com/apache/hudi/pull/18133#discussion_r2805177763
##
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/timeline/versioning/v1/TimelineArchiverV1.java:
##
@@ -160,6 +173,21 @@ public int archiveIfRequired(HoodieEngineContext context,
boolean acquireLock) t
}
}
+ @Override
+ public Map getMetrics() {
+return metrics;
+ }
+
+ private void addArchivalCommitMetrics(List instantsToArchive)
{
+Set completedInstants = instantsToArchive.stream()
+.filter(HoodieInstant::isCompleted)
+.collect(Collectors.toSet());
+metrics.put(ArchivalMetrics.ARCHIVAL_NUM_ALL_COMMITS, (long)
completedInstants.size());
+metrics.put(ArchivalMetrics.ARCHIVAL_NUM_WRITE_COMMITS,
completedInstants.stream()
+.filter(instant ->
CollectionUtils.createSet(HoodieTimeline.COMMIT_ACTION,
HoodieTimeline.REPLACE_COMMIT_ACTION)
Review Comment:
added
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] feat(table-services): Emit archival metrics for monitoring and debugging [hudi]
nada-attia commented on code in PR #18133: URL: https://github.com/apache/hudi/pull/18133#discussion_r2805184168 ## hudi-client/hudi-spark-client/src/test/java/org/apache/hudi/io/TestHoodieTimelineArchiver.java: ## @@ -2048,4 +2053,51 @@ private void assertInstantListEquals(List expected, List
Re: [PR] feat(table-services): Emit archival metrics for monitoring and debugging [hudi]
hudi-bot commented on PR #18133: URL: https://github.com/apache/hudi/pull/18133#issuecomment-3898258461 ## CI report: * 7b11dda49c475dd1e386d62dd8dda36c8ed49e54 Azure: [FAILURE](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=11899) * 23a205e76d571cf699df8e9160cb05d360a61d2b UNKNOWN Bot commands @hudi-bot supports the following commands: - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] feat(table-services): Emit archival metrics for monitoring and debugging [hudi]
nada-attia commented on code in PR #18133:
URL: https://github.com/apache/hudi/pull/18133#discussion_r2805181794
##
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/timeline/versioning/v2/TimelineArchiverV2.java:
##
@@ -125,14 +131,40 @@ public int archiveIfRequired(HoodieEngineContext context,
boolean acquireLock) t
} else {
log.info("No Instants to archive");
}
+ metrics.put(ArchivalMetrics.ARCHIVAL_STATUS, success ? 1L : -1L);
return instantsToArchive.size();
+} catch (OutOfMemoryError oom) {
+ metrics.put(ArchivalMetrics.ARCHIVAL_OOM_FAILURE, 1L);
+ throw oom;
+} catch (Exception e) {
+ String failureMetricName = String.join(".",
ArchivalMetrics.ARCHIVAL_FAILURE, e.getClass().getSimpleName());
+ metrics.put(failureMetricName, 1L);
+ throw e;
} finally {
if (acquireLock) {
txnManager.endStateChange(Option.empty());
}
}
}
+ @Override
+ public Map getMetrics() {
+return metrics;
+ }
+
+ private void addArchivalCommitMetrics(List instantsToArchive) {
Review Comment:
moved this to ArchivalMetrics class
##
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/metrics/HoodieMetrics.java:
##
@@ -360,6 +361,19 @@ public void updateArchiveMetrics(long durationInMs, int
numInstantsArchived) {
}
}
+ public void updateArchivalMetrics(Map archivalMetrics) {
+if (config.isMetricsOn()) {
+ log.info(String.format("Sending archival metrics %s", archivalMetrics));
+ archivalMetrics.forEach((metricName, metricValue) ->
metrics.registerGauge(getMetricsName("archival", metricName), metricValue));
+}
+ }
+
+ public void emitCleanFailure() {
Review Comment:
removed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] feat(table-services): Emit archival metrics for monitoring and debugging [hudi]
nsivabalan commented on code in PR #18133:
URL: https://github.com/apache/hudi/pull/18133#discussion_r2790410654
##
hudi-client/hudi-spark-client/src/test/java/org/apache/hudi/io/TestHoodieTimelineArchiver.java:
##
@@ -2048,4 +2053,51 @@ private void assertInstantListEquals(List
expected, List archivalMetrics) {
+if (config.isMetricsOn()) {
+ log.info(String.format("Sending archival metrics %s", archivalMetrics));
+ archivalMetrics.forEach((metricName, metricValue) ->
metrics.registerGauge(getMetricsName("archival", metricName), metricValue));
+}
+ }
+
+ public void emitCleanFailure() {
Review Comment:
was this supposed to a diff patch ?
##
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/utils/ArchivalMetrics.java:
##
@@ -0,0 +1,34 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hudi.client.utils;
+
+/**
+ * Constants for archival metrics.
+ */
+public final class ArchivalMetrics {
Review Comment:
can we name this as `ArchivalMetricsConstants`
##
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/timeline/versioning/v2/TimelineArchiverV2.java:
##
@@ -125,14 +131,40 @@ public int archiveIfRequired(HoodieEngineContext context,
boolean acquireLock) t
} else {
log.info("No Instants to archive");
}
+ metrics.put(ArchivalMetrics.ARCHIVAL_STATUS, success ? 1L : -1L);
return instantsToArchive.size();
+} catch (OutOfMemoryError oom) {
+ metrics.put(ArchivalMetrics.ARCHIVAL_OOM_FAILURE, 1L);
+ throw oom;
+} catch (Exception e) {
+ String failureMetricName = String.join(".",
ArchivalMetrics.ARCHIVAL_FAILURE, e.getClass().getSimpleName());
+ metrics.put(failureMetricName, 1L);
+ throw e;
} finally {
if (acquireLock) {
txnManager.endStateChange(Option.empty());
}
}
}
+ @Override
+ public Map getMetrics() {
+return metrics;
+ }
+
+ private void addArchivalCommitMetrics(List instantsToArchive) {
Review Comment:
we should move this to a common place and reuse across both V1 and V2
##
hudi-client/hudi-spark-client/src/test/java/org/apache/hudi/io/TestHoodieTimelineArchiver.java:
##
@@ -2048,4 +2053,51 @@ private void assertInstantListEquals(List
expected, List
archiver.archiveIfRequired(context));
+
+// Verify that OOM metric is recorded
+Map metrics = archiver.getMetrics();
+assertEquals(1L, metrics.get(ArchivalMetrics.ARCHIVAL_OOM_FAILURE));
+assertEquals(17L, metrics.get(ArchivalMetrics.ARCHIVAL_NUM_ALL_COMMITS));
Review Comment:
lets validate all other metrics we well.
Also, lets ensure timeline contains a mix of ingestion commits, replace
commits, clean, rollbacks and archival does archive subset in each of the
action types.
and the metrics reflect the right values
##
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/utils/ArchivalMetrics.java:
##
@@ -0,0 +1,34 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hudi.client.utils;
+
+/**
+ * Constants for archival metrics.
+ */
+public final class ArchivalMetrics {
+ public static final String ARCHIVAL_OOM_FAILURE = "archivalOutOfMemory";
+ public static final String ARCHIVAL_NUM_ALL_COMMITS =
"archivalNumAllCommits";
+ public static final String ARCHIVAL_
Re: [PR] feat(table-services): Emit archival metrics for monitoring and debugging [hudi]
nsivabalan commented on code in PR #18133:
URL: https://github.com/apache/hudi/pull/18133#discussion_r2790379085
##
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/timeline/versioning/v1/TimelineArchiverV1.java:
##
@@ -160,6 +173,21 @@ public int archiveIfRequired(HoodieEngineContext context,
boolean acquireLock) t
}
}
+ @Override
+ public Map getMetrics() {
+return metrics;
+ }
+
+ private void addArchivalCommitMetrics(List instantsToArchive)
{
+Set completedInstants = instantsToArchive.stream()
+.filter(HoodieInstant::isCompleted)
+.collect(Collectors.toSet());
+metrics.put(ArchivalMetrics.ARCHIVAL_NUM_ALL_COMMITS, (long)
completedInstants.size());
+metrics.put(ArchivalMetrics.ARCHIVAL_NUM_WRITE_COMMITS,
completedInstants.stream()
+.filter(instant ->
CollectionUtils.createSet(HoodieTimeline.COMMIT_ACTION,
HoodieTimeline.REPLACE_COMMIT_ACTION)
Review Comment:
DELTA_COMMIT_ACTION
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] feat(table-services): Emit archival metrics for monitoring and debugging [hudi]
hudi-bot commented on PR #18133: URL: https://github.com/apache/hudi/pull/18133#issuecomment-3879041646 ## CI report: * 7b11dda49c475dd1e386d62dd8dda36c8ed49e54 Azure: [FAILURE](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=11899) Bot commands @hudi-bot supports the following commands: - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] feat(table-services): Emit archival metrics for monitoring and debugging [hudi]
hudi-bot commented on PR #18133: URL: https://github.com/apache/hudi/pull/18133#issuecomment-3878872086 ## CI report: * 9909208bec89fce5f58dbcf010f1f01abc5f4daf Azure: [FAILURE](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=11869) * 7b11dda49c475dd1e386d62dd8dda36c8ed49e54 Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=11899) Bot commands @hudi-bot supports the following commands: - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] feat(table-services): Emit archival metrics for monitoring and debugging [hudi]
hudi-bot commented on PR #18133: URL: https://github.com/apache/hudi/pull/18133#issuecomment-3878830249 ## CI report: * 9909208bec89fce5f58dbcf010f1f01abc5f4daf Azure: [FAILURE](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=11869) * 7b11dda49c475dd1e386d62dd8dda36c8ed49e54 UNKNOWN Bot commands @hudi-bot supports the following commands: - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] feat(table-services): Emit archival metrics for monitoring and debugging [hudi]
hudi-bot commented on PR #18133: URL: https://github.com/apache/hudi/pull/18133#issuecomment-3875386264 ## CI report: * 9909208bec89fce5f58dbcf010f1f01abc5f4daf Azure: [FAILURE](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=11869) Bot commands @hudi-bot supports the following commands: - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] feat(table-services): Emit archival metrics for monitoring and debugging [hudi]
hudi-bot commented on PR #18133: URL: https://github.com/apache/hudi/pull/18133#issuecomment-3874777228 ## CI report: * 9909208bec89fce5f58dbcf010f1f01abc5f4daf Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=11869) Bot commands @hudi-bot supports the following commands: - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] feat(table-services): Emit archival metrics for monitoring and debugging [hudi]
hudi-bot commented on PR #18133: URL: https://github.com/apache/hudi/pull/18133#issuecomment-3874758998 ## CI report: * 9909208bec89fce5f58dbcf010f1f01abc5f4daf UNKNOWN Bot commands @hudi-bot supports the following commands: - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] feat(table-services): Emit archival metrics for monitoring and debugging [hudi]
hudi-bot commented on PR #18133: URL: https://github.com/apache/hudi/pull/18133#issuecomment-3867554048 ## CI report: * 33e3980c1f1992c7d059e72055cfc6292335bec1 UNKNOWN * 82aedab6faa6029a176620a0906d654c99aea7f4 UNKNOWN Bot commands @hudi-bot supports the following commands: - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] feat(table-services): Emit archival metrics for monitoring and debugging [hudi]
hudi-bot commented on PR #18133: URL: https://github.com/apache/hudi/pull/18133#issuecomment-3867549760 ## CI report: * 33e3980c1f1992c7d059e72055cfc6292335bec1 UNKNOWN Bot commands @hudi-bot supports the following commands: - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
