Re: [PR] feat: Adding support to block archival on last known ECTR for v6 tables [hudi]
yihua commented on code in PR #18380:
URL: https://github.com/apache/hudi/pull/18380#discussion_r3139699020
##
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/config/HoodieWriteConfig.java:
##
@@ -1975,6 +1975,10 @@ public int getCommitArchivalBatchSize() {
return getInt(HoodieArchivalConfig.COMMITS_ARCHIVAL_BATCH_SIZE);
}
+ public boolean shouldBlockArchivalOnCleanECTR() {
Review Comment:
@nsivabalan then it should use Camel case, i.e., `Ectr`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] feat: Adding support to block archival on last known ECTR for v6 tables [hudi]
nsivabalan merged PR #18380: URL: https://github.com/apache/hudi/pull/18380 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] feat: Adding support to block archival on last known ECTR for v6 tables [hudi]
codecov-commenter commented on PR #18380: URL: https://github.com/apache/hudi/pull/18380#issuecomment-4286623631 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18380?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `86.7%` with `4 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 68.78%. Comparing base ([`2f07364`](https://app.codecov.io/gh/apache/hudi/commit/2f073643dfe764d34fee5a139d95633df01d9292?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`ea12e76`](https://app.codecov.io/gh/apache/hudi/commit/ea12e76bc5ce1a6ebbbf8209cb3efcec27f5ec2e?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 85 commits behind head on master. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18380?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...ent/timeline/versioning/v1/TimelineArchiverV1.java](https://app.codecov.io/gh/apache/hudi/pull/18380?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv1%2FTimelineArchiverV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YxL1RpbWVsaW5lQXJjaGl2ZXJWMS5qYXZh) | 80.95% | [3 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18380?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18380 +/- ## + Coverage 68.36% 68.78% +0.41% - Complexity2756628342 +776 Files 2432 2468 +36 Lines133175 136025+2850 Branches 1602316501 +478 + Hits 9104793561+2514 + Misses3506835061 -7 - Partials 7060 7403 +343 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.60% <40.00%> (+0.28%)` | :arrow_up: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.73% <20.00%> (-0.42%)` | :arrow_down: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.57% <83.33%> (+<0.01%)` | :arrow_up: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.93% <40.00%> (+0.23%)` | :arrow_up: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.43% <23.33%> (+0.04%)` | :arrow_up: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.18% <36.66%> (-0.36%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18380?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...a/org/apache/hudi/config/HoodieArchivalConfig.jav
Re: [PR] feat: Adding support to block archival on last known ECTR for v6 tables [hudi]
codecov-commenter commented on PR #18380: URL: https://github.com/apache/hudi/pull/18380#issuecomment-4286610925 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18380?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `86.7%` with `4 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 68.78%. Comparing base ([`2f07364`](https://app.codecov.io/gh/apache/hudi/commit/2f073643dfe764d34fee5a139d95633df01d9292?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`ea12e76`](https://app.codecov.io/gh/apache/hudi/commit/ea12e76bc5ce1a6ebbbf8209cb3efcec27f5ec2e?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 85 commits behind head on master. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18380?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...ent/timeline/versioning/v1/TimelineArchiverV1.java](https://app.codecov.io/gh/apache/hudi/pull/18380?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv1%2FTimelineArchiverV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YxL1RpbWVsaW5lQXJjaGl2ZXJWMS5qYXZh) | 80.95% | [3 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18380?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18380 +/- ## + Coverage 68.36% 68.78% +0.41% - Complexity2756628342 +776 Files 2432 2468 +36 Lines133175 136025+2850 Branches 1602316501 +478 + Hits 9104793561+2514 + Misses3506835061 -7 - Partials 7060 7403 +343 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.60% <40.00%> (+0.28%)` | :arrow_up: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.73% <20.00%> (-0.42%)` | :arrow_down: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.57% <83.33%> (+<0.01%)` | :arrow_up: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.91% <40.00%> (+0.21%)` | :arrow_up: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.43% <23.33%> (+0.04%)` | :arrow_up: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.18% <36.66%> (-0.36%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18380?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...a/org/apache/hudi/config/HoodieArchivalConfig.jav
Re: [PR] feat: Adding support to block archival on last known ECTR for v6 tables [hudi]
codecov-commenter commented on PR #18380: URL: https://github.com/apache/hudi/pull/18380#issuecomment-4286445137 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18380?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `86.7%` with `4 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 68.78%. Comparing base ([`2f07364`](https://app.codecov.io/gh/apache/hudi/commit/2f073643dfe764d34fee5a139d95633df01d9292?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`ea12e76`](https://app.codecov.io/gh/apache/hudi/commit/ea12e76bc5ce1a6ebbbf8209cb3efcec27f5ec2e?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 85 commits behind head on master. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18380?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...ent/timeline/versioning/v1/TimelineArchiverV1.java](https://app.codecov.io/gh/apache/hudi/pull/18380?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv1%2FTimelineArchiverV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YxL1RpbWVsaW5lQXJjaGl2ZXJWMS5qYXZh) | 80.95% | [3 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18380?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18380 +/- ## + Coverage 68.36% 68.78% +0.41% - Complexity2756628341 +775 Files 2432 2468 +36 Lines133175 136025+2850 Branches 1602316501 +478 + Hits 9104793560+2513 + Misses3506835062 -6 - Partials 7060 7403 +343 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.60% <40.00%> (+0.28%)` | :arrow_up: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.73% <20.00%> (-0.42%)` | :arrow_down: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.57% <83.33%> (+<0.01%)` | :arrow_up: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.89% <40.00%> (+0.18%)` | :arrow_up: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.43% <23.33%> (+0.04%)` | :arrow_up: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.18% <36.66%> (-0.36%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18380?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...a/org/apache/hudi/config/HoodieArchivalConfig.jav
Re: [PR] feat: Adding support to block archival on last known ECTR for v6 tables [hudi]
hudi-bot commented on PR #18380: URL: https://github.com/apache/hudi/pull/18380#issuecomment-4285356668 ## CI report: * ea12e76bc5ce1a6ebbbf8209cb3efcec27f5ec2e Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13394) Bot commands @hudi-bot supports the following commands: - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] feat: Adding support to block archival on last known ECTR for v6 tables [hudi]
codecov-commenter commented on PR #18380: URL: https://github.com/apache/hudi/pull/18380#issuecomment-4285308612 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18380?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `86.7%` with `4 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 66.44%. Comparing base ([`2f07364`](https://app.codecov.io/gh/apache/hudi/commit/2f073643dfe764d34fee5a139d95633df01d9292?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`ea12e76`](https://app.codecov.io/gh/apache/hudi/commit/ea12e76bc5ce1a6ebbbf8209cb3efcec27f5ec2e?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 82 commits behind head on master. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18380?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...ent/timeline/versioning/v1/TimelineArchiverV1.java](https://app.codecov.io/gh/apache/hudi/pull/18380?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv1%2FTimelineArchiverV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YxL1RpbWVsaW5lQXJjaGl2ZXJWMS5qYXZh) | 80.95% | [3 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18380?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18380 +/- ## - Coverage 68.36% 66.44% -1.92% + Complexity2756622944-4622 Files 2432 2008 -424 Lines133175 112628 -20547 Branches 1602314308-1715 - Hits 9104774838 -16209 + Misses3506831272-3796 + Partials 7060 6518 -542 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.73% <20.00%> (-0.42%)` | :arrow_down: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.57% <83.33%> (+<0.01%)` | :arrow_up: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.88% <40.00%> (+0.18%)` | :arrow_up: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.43% <23.33%> (+0.04%)` | :arrow_up: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.18% <36.66%> (-0.36%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18380?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...a/org/apache/hudi/config/HoodieArchivalConfig.java](https://app.codecov.io/gh/apach
Re: [PR] feat: Adding support to block archival on last known ECTR for v6 tables [hudi]
codecov-commenter commented on PR #18380: URL: https://github.com/apache/hudi/pull/18380#issuecomment-4285310072 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18380?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `86.7%` with `4 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 66.44%. Comparing base ([`2f07364`](https://app.codecov.io/gh/apache/hudi/commit/2f073643dfe764d34fee5a139d95633df01d9292?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`ea12e76`](https://app.codecov.io/gh/apache/hudi/commit/ea12e76bc5ce1a6ebbbf8209cb3efcec27f5ec2e?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 82 commits behind head on master. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18380?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...ent/timeline/versioning/v1/TimelineArchiverV1.java](https://app.codecov.io/gh/apache/hudi/pull/18380?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv1%2FTimelineArchiverV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YxL1RpbWVsaW5lQXJjaGl2ZXJWMS5qYXZh) | 80.95% | [3 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18380?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18380 +/- ## - Coverage 68.36% 66.44% -1.92% + Complexity2756622944-4622 Files 2432 2008 -424 Lines133175 112628 -20547 Branches 1602314308-1715 - Hits 9104774838 -16209 + Misses3506831272-3796 + Partials 7060 6518 -542 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.73% <20.00%> (-0.42%)` | :arrow_down: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.57% <83.33%> (+<0.01%)` | :arrow_up: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.89% <40.00%> (+0.18%)` | :arrow_up: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.43% <23.33%> (+0.04%)` | :arrow_up: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.18% <36.66%> (-0.36%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18380?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...a/org/apache/hudi/config/HoodieArchivalConfig.java](https://app.codecov.io/gh/apach
Re: [PR] feat: Adding support to block archival on last known ECTR for v6 tables [hudi]
codecov-commenter commented on PR #18380: URL: https://github.com/apache/hudi/pull/18380#issuecomment-4285297277 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18380?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `86.7%` with `4 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 66.44%. Comparing base ([`2f07364`](https://app.codecov.io/gh/apache/hudi/commit/2f073643dfe764d34fee5a139d95633df01d9292?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`ea12e76`](https://app.codecov.io/gh/apache/hudi/commit/ea12e76bc5ce1a6ebbbf8209cb3efcec27f5ec2e?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 82 commits behind head on master. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18380?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...ent/timeline/versioning/v1/TimelineArchiverV1.java](https://app.codecov.io/gh/apache/hudi/pull/18380?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv1%2FTimelineArchiverV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YxL1RpbWVsaW5lQXJjaGl2ZXJWMS5qYXZh) | 80.95% | [3 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18380?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18380 +/- ## - Coverage 68.36% 66.44% -1.93% + Complexity2756622944-4622 Files 2432 2008 -424 Lines133175 112628 -20547 Branches 1602314308-1715 - Hits 9104774836 -16211 + Misses3506831274-3794 + Partials 7060 6518 -542 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.73% <20.00%> (-0.42%)` | :arrow_down: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.57% <83.33%> (+<0.01%)` | :arrow_up: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.85% <40.00%> (+0.14%)` | :arrow_up: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.43% <23.33%> (+0.04%)` | :arrow_up: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.18% <36.66%> (-0.36%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18380?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...a/org/apache/hudi/config/HoodieArchivalConfig.java](https://app.codecov.io/gh/apach
Re: [PR] feat: Adding support to block archival on last known ECTR for v6 tables [hudi]
codecov-commenter commented on PR #18380: URL: https://github.com/apache/hudi/pull/18380#issuecomment-4285282970 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18380?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `86.7%` with `4 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 66.44%. Comparing base ([`2f07364`](https://app.codecov.io/gh/apache/hudi/commit/2f073643dfe764d34fee5a139d95633df01d9292?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`ea12e76`](https://app.codecov.io/gh/apache/hudi/commit/ea12e76bc5ce1a6ebbbf8209cb3efcec27f5ec2e?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 82 commits behind head on master. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18380?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...ent/timeline/versioning/v1/TimelineArchiverV1.java](https://app.codecov.io/gh/apache/hudi/pull/18380?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv1%2FTimelineArchiverV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YxL1RpbWVsaW5lQXJjaGl2ZXJWMS5qYXZh) | 80.95% | [3 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18380?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18380 +/- ## - Coverage 68.36% 66.44% -1.93% + Complexity2756622944-4622 Files 2432 2008 -424 Lines133175 112628 -20547 Branches 1602314308-1715 - Hits 9104774835 -16212 + Misses3506831275-3793 + Partials 7060 6518 -542 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.73% <20.00%> (-0.42%)` | :arrow_down: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.57% <83.33%> (+<0.01%)` | :arrow_up: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.84% <40.00%> (+0.14%)` | :arrow_up: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.43% <23.33%> (+0.04%)` | :arrow_up: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.18% <36.66%> (-0.36%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18380?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...a/org/apache/hudi/config/HoodieArchivalConfig.java](https://app.codecov.io/gh/apach
Re: [PR] feat: Adding support to block archival on last known ECTR for v6 tables [hudi]
codecov-commenter commented on PR #18380: URL: https://github.com/apache/hudi/pull/18380#issuecomment-4285282510 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18380?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `86.7%` with `4 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 66.44%. Comparing base ([`2f07364`](https://app.codecov.io/gh/apache/hudi/commit/2f073643dfe764d34fee5a139d95633df01d9292?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`ea12e76`](https://app.codecov.io/gh/apache/hudi/commit/ea12e76bc5ce1a6ebbbf8209cb3efcec27f5ec2e?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 82 commits behind head on master. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18380?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...ent/timeline/versioning/v1/TimelineArchiverV1.java](https://app.codecov.io/gh/apache/hudi/pull/18380?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv1%2FTimelineArchiverV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YxL1RpbWVsaW5lQXJjaGl2ZXJWMS5qYXZh) | 80.95% | [3 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18380?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18380 +/- ## - Coverage 68.36% 66.44% -1.93% + Complexity2756622944-4622 Files 2432 2008 -424 Lines133175 112628 -20547 Branches 1602314308-1715 - Hits 9104774835 -16212 + Misses3506831275-3793 + Partials 7060 6518 -542 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.73% <20.00%> (-0.42%)` | :arrow_down: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.57% <83.33%> (+<0.01%)` | :arrow_up: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.84% <40.00%> (+0.14%)` | :arrow_up: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.43% <23.33%> (+0.04%)` | :arrow_up: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.18% <36.66%> (-0.36%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18380?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...a/org/apache/hudi/config/HoodieArchivalConfig.java](https://app.codecov.io/gh/apach
Re: [PR] feat: Adding support to block archival on last known ECTR for v6 tables [hudi]
codecov-commenter commented on PR #18380: URL: https://github.com/apache/hudi/pull/18380#issuecomment-4285278866 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18380?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `86.7%` with `4 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 66.26%. Comparing base ([`2f07364`](https://app.codecov.io/gh/apache/hudi/commit/2f073643dfe764d34fee5a139d95633df01d9292?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`ea12e76`](https://app.codecov.io/gh/apache/hudi/commit/ea12e76bc5ce1a6ebbbf8209cb3efcec27f5ec2e?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 82 commits behind head on master. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18380?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...ent/timeline/versioning/v1/TimelineArchiverV1.java](https://app.codecov.io/gh/apache/hudi/pull/18380?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv1%2FTimelineArchiverV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YxL1RpbWVsaW5lQXJjaGl2ZXJWMS5qYXZh) | 80.95% | [3 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18380?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18380 +/- ## - Coverage 68.36% 66.26% -2.11% + Complexity2756622842-4724 Files 2432 2008 -424 Lines133175 112628 -20547 Branches 1602314308-1715 - Hits 9104774631 -16416 + Misses3506831503-3565 + Partials 7060 6494 -566 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.73% <20.00%> (-0.42%)` | :arrow_down: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.57% <83.33%> (+<0.01%)` | :arrow_up: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.74% <40.00%> (+0.03%)` | :arrow_up: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.28% <23.33%> (-0.11%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.18% <36.66%> (-0.36%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18380?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...a/org/apache/hudi/config/HoodieArchivalConfig.java](https://app.codecov.io/gh/apa
Re: [PR] feat: Adding support to block archival on last known ECTR for v6 tables [hudi]
codecov-commenter commented on PR #18380: URL: https://github.com/apache/hudi/pull/18380#issuecomment-4285276187 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18380?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `86.7%` with `4 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 66.06%. Comparing base ([`2f07364`](https://app.codecov.io/gh/apache/hudi/commit/2f073643dfe764d34fee5a139d95633df01d9292?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`ea12e76`](https://app.codecov.io/gh/apache/hudi/commit/ea12e76bc5ce1a6ebbbf8209cb3efcec27f5ec2e?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 82 commits behind head on master. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18380?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...ent/timeline/versioning/v1/TimelineArchiverV1.java](https://app.codecov.io/gh/apache/hudi/pull/18380?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv1%2FTimelineArchiverV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YxL1RpbWVsaW5lQXJjaGl2ZXJWMS5qYXZh) | 80.95% | [3 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18380?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18380 +/- ## - Coverage 68.36% 66.06% -2.30% + Complexity2756622762-4804 Files 2432 2008 -424 Lines133175 112628 -20547 Branches 1602314308-1715 - Hits 9104774410 -16637 + Misses3506831750-3318 + Partials 7060 6468 -592 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.73% <20.00%> (-0.42%)` | :arrow_down: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.57% <83.33%> (+<0.01%)` | :arrow_up: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.57% <40.00%> (-0.13%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.10% <23.33%> (-0.29%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.18% <36.66%> (-0.36%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18380?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...a/org/apache/hudi/config/HoodieArchivalConfig.java](https://app.codecov.io/gh/a
Re: [PR] feat: Adding support to block archival on last known ECTR for v6 tables [hudi]
codecov-commenter commented on PR #18380: URL: https://github.com/apache/hudi/pull/18380#issuecomment-4285258487 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18380?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `86.7%` with `4 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 62.18%. Comparing base ([`2f07364`](https://app.codecov.io/gh/apache/hudi/commit/2f073643dfe764d34fee5a139d95633df01d9292?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`ea12e76`](https://app.codecov.io/gh/apache/hudi/commit/ea12e76bc5ce1a6ebbbf8209cb3efcec27f5ec2e?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 82 commits behind head on master. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18380?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...ent/timeline/versioning/v1/TimelineArchiverV1.java](https://app.codecov.io/gh/apache/hudi/pull/18380?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv1%2FTimelineArchiverV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YxL1RpbWVsaW5lQXJjaGl2ZXJWMS5qYXZh) | 80.95% | [3 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18380?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | > :exclamation: There is a different number of reports uploaded between BASE (2f07364) and HEAD (ea12e76). Click for more details. > > HEAD has 14 uploads less than BASE > >| Flag | BASE (2f07364) | HEAD (ea12e76) | >|--|--|--| >|spark-scala-tests|10|6| >|spark-java-tests|15|6| >|common-and-other-modules|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18380 +/- ## - Coverage 68.36% 62.18% -6.19% + Complexity2756621167-6399 Files 2432 2008 -424 Lines133175 112628 -20547 Branches 1602314308-1715 - Hits 9104770038 -21009 - Misses3506835884 +816 + Partials 7060 6706 -354 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.73% <20.00%> (-0.42%)` | :arrow_down: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.57% <83.33%> (+<0.01%)` | :arrow_up: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `40.62% <40.00%> (-8.08%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.88% <23.33%> (-0.51%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.18% <36.66%> (-0.36%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to
Re: [PR] feat: Adding support to block archival on last known ECTR for v6 tables [hudi]
codecov-commenter commented on PR #18380: URL: https://github.com/apache/hudi/pull/18380#issuecomment-4285254193 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18380?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `86.7%` with `4 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 56.41%. Comparing base ([`2f07364`](https://app.codecov.io/gh/apache/hudi/commit/2f073643dfe764d34fee5a139d95633df01d9292?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`ea12e76`](https://app.codecov.io/gh/apache/hudi/commit/ea12e76bc5ce1a6ebbbf8209cb3efcec27f5ec2e?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 82 commits behind head on master. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18380?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...ent/timeline/versioning/v1/TimelineArchiverV1.java](https://app.codecov.io/gh/apache/hudi/pull/18380?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv1%2FTimelineArchiverV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YxL1RpbWVsaW5lQXJjaGl2ZXJWMS5qYXZh) | 80.95% | [3 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18380?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | > :exclamation: There is a different number of reports uploaded between BASE (2f07364) and HEAD (ea12e76). Click for more details. > > HEAD has 15 uploads less than BASE > >| Flag | BASE (2f07364) | HEAD (ea12e76) | >|--|--|--| >|spark-scala-tests|10|5| >|spark-java-tests|15|6| >|common-and-other-modules|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18380 +/- ## = - Coverage 68.36% 56.41% -11.95% + Complexity2756619167 -8399 = Files 2432 2008 -424 Lines133175 112628-20547 Branches 1602314308 -1715 = - Hits 9104763543-27504 - Misses3506842834 +7766 + Partials 7060 6251 -809 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.73% <20.00%> (-0.42%)` | :arrow_down: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.57% <83.33%> (+<0.01%)` | :arrow_up: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `40.62% <40.00%> (-8.08%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.54% <20.00%> (-12.85%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.18% <36.66%> (-0.36%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request
Re: [PR] feat: Adding support to block archival on last known ECTR for v6 tables [hudi]
codecov-commenter commented on PR #18380: URL: https://github.com/apache/hudi/pull/18380#issuecomment-4285243567 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18380?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `83.3%` with `5 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 54.37%. Comparing base ([`2f07364`](https://app.codecov.io/gh/apache/hudi/commit/2f073643dfe764d34fee5a139d95633df01d9292?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`ea12e76`](https://app.codecov.io/gh/apache/hudi/commit/ea12e76bc5ce1a6ebbbf8209cb3efcec27f5ec2e?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 82 commits behind head on master. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18380?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...ent/timeline/versioning/v1/TimelineArchiverV1.java](https://app.codecov.io/gh/apache/hudi/pull/18380?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv1%2FTimelineArchiverV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YxL1RpbWVsaW5lQXJjaGl2ZXJWMS5qYXZh) | 80.95% | [3 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18380?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...java/org/apache/hudi/config/HoodieWriteConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18380?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2FHoodieWriteConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVXcml0ZUNvbmZpZy5qYXZh) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18380?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | > :exclamation: There is a different number of reports uploaded between BASE (2f07364) and HEAD (ea12e76). Click for more details. > > HEAD has 16 uploads less than BASE > >| Flag | BASE (2f07364) | HEAD (ea12e76) | >|--|--|--| >|spark-scala-tests|10|5| >|spark-java-tests|15|5| >|common-and-other-modules|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18380 +/- ## = - Coverage 68.36% 54.37% -14.00% + Complexity2756618491 -9075 = Files 2432 2008 -424 Lines133175 112628-20547 Branches 1602314308 -1715 = - Hits 9104761241-29806 - Misses3506845108+10040 + Partials 7060 6279 -781 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.73% <20.00%> (-0.42%)` | :arrow_down: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.57% <83.33%> (+<0.01%)` | :arrow_up: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.34% <20.00%> (-16.36%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/
Re: [PR] feat: Adding support to block archival on last known ECTR for v6 tables [hudi]
codecov-commenter commented on PR #18380: URL: https://github.com/apache/hudi/pull/18380#issuecomment-4285237536 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18380?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `83.3%` with `5 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 54.37%. Comparing base ([`2f07364`](https://app.codecov.io/gh/apache/hudi/commit/2f073643dfe764d34fee5a139d95633df01d9292?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`ea12e76`](https://app.codecov.io/gh/apache/hudi/commit/ea12e76bc5ce1a6ebbbf8209cb3efcec27f5ec2e?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 82 commits behind head on master. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18380?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...ent/timeline/versioning/v1/TimelineArchiverV1.java](https://app.codecov.io/gh/apache/hudi/pull/18380?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv1%2FTimelineArchiverV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YxL1RpbWVsaW5lQXJjaGl2ZXJWMS5qYXZh) | 80.95% | [3 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18380?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...java/org/apache/hudi/config/HoodieWriteConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18380?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2FHoodieWriteConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVXcml0ZUNvbmZpZy5qYXZh) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18380?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | > :exclamation: There is a different number of reports uploaded between BASE (2f07364) and HEAD (ea12e76). Click for more details. > > HEAD has 17 uploads less than BASE > >| Flag | BASE (2f07364) | HEAD (ea12e76) | >|--|--|--| >|spark-scala-tests|10|5| >|spark-java-tests|15|4| >|common-and-other-modules|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18380 +/- ## = - Coverage 68.36% 54.37% -14.00% + Complexity2756618491 -9075 = Files 2432 2008 -424 Lines133175 112628-20547 Branches 1602314308 -1715 = - Hits 9104761241-29806 - Misses3506845108+10040 + Partials 7060 6279 -781 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.73% <20.00%> (-0.42%)` | :arrow_down: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.57% <83.33%> (+<0.01%)` | :arrow_up: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.34% <20.00%> (-16.36%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/
Re: [PR] feat: Adding support to block archival on last known ECTR for v6 tables [hudi]
codecov-commenter commented on PR #18380: URL: https://github.com/apache/hudi/pull/18380#issuecomment-4285233392 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18380?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `83.3%` with `5 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 48.13%. Comparing base ([`2f07364`](https://app.codecov.io/gh/apache/hudi/commit/2f073643dfe764d34fee5a139d95633df01d9292?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`ea12e76`](https://app.codecov.io/gh/apache/hudi/commit/ea12e76bc5ce1a6ebbbf8209cb3efcec27f5ec2e?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 82 commits behind head on master. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18380?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...ent/timeline/versioning/v1/TimelineArchiverV1.java](https://app.codecov.io/gh/apache/hudi/pull/18380?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv1%2FTimelineArchiverV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YxL1RpbWVsaW5lQXJjaGl2ZXJWMS5qYXZh) | 80.95% | [3 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18380?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...java/org/apache/hudi/config/HoodieWriteConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18380?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2FHoodieWriteConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVXcml0ZUNvbmZpZy5qYXZh) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18380?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | > :exclamation: There is a different number of reports uploaded between BASE (2f07364) and HEAD (ea12e76). Click for more details. > > HEAD has 18 uploads less than BASE > >| Flag | BASE (2f07364) | HEAD (ea12e76) | >|--|--|--| >|spark-scala-tests|10|5| >|spark-java-tests|15|4| >|common-and-other-modules|1|0| >|utilities|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18380 +/- ## = - Coverage 68.36% 48.13% -20.24% + Complexity2756616545-11021 = Files 2432 2008 -424 Lines133175 112628-20547 Branches 1602314308 -1715 = - Hits 9104754212-36835 - Misses3506852747+17679 + Partials 7060 5669 -1391 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.73% <20.00%> (-0.42%)` | :arrow_down: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.57% <83.33%> (+<0.01%)` | :arrow_up: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.34% <20.00%> (-16.36%)` | :arrow_down: | | [spark-scala-tests](https://app.codeco
Re: [PR] feat: Adding support to block archival on last known ECTR for v6 tables [hudi]
codecov-commenter commented on PR #18380: URL: https://github.com/apache/hudi/pull/18380#issuecomment-4285230027 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18380?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `83.3%` with `5 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 48.10%. Comparing base ([`2f07364`](https://app.codecov.io/gh/apache/hudi/commit/2f073643dfe764d34fee5a139d95633df01d9292?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`ea12e76`](https://app.codecov.io/gh/apache/hudi/commit/ea12e76bc5ce1a6ebbbf8209cb3efcec27f5ec2e?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 82 commits behind head on master. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18380?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...ent/timeline/versioning/v1/TimelineArchiverV1.java](https://app.codecov.io/gh/apache/hudi/pull/18380?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv1%2FTimelineArchiverV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YxL1RpbWVsaW5lQXJjaGl2ZXJWMS5qYXZh) | 80.95% | [3 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18380?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...java/org/apache/hudi/config/HoodieWriteConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18380?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2FHoodieWriteConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVXcml0ZUNvbmZpZy5qYXZh) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18380?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | > :exclamation: There is a different number of reports uploaded between BASE (2f07364) and HEAD (ea12e76). Click for more details. > > HEAD has 19 uploads less than BASE > >| Flag | BASE (2f07364) | HEAD (ea12e76) | >|--|--|--| >|spark-scala-tests|10|5| >|spark-java-tests|15|3| >|common-and-other-modules|1|0| >|utilities|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18380 +/- ## = - Coverage 68.36% 48.10% -20.27% + Complexity2756616535-11031 = Files 2432 2008 -424 Lines133175 112628-20547 Branches 1602314308 -1715 = - Hits 9104754179-36868 - Misses3506852776+17708 + Partials 7060 5673 -1387 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.73% <20.00%> (-0.42%)` | :arrow_down: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.57% <83.33%> (+<0.01%)` | :arrow_up: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.75% <20.00%> (-15.96%)` | :arrow_down: | | [spark-scala-tests](https://app.codeco
Re: [PR] feat: Adding support to block archival on last known ECTR for v6 tables [hudi]
codecov-commenter commented on PR #18380: URL: https://github.com/apache/hudi/pull/18380#issuecomment-4285229546 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18380?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `83.3%` with `5 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 48.07%. Comparing base ([`2f07364`](https://app.codecov.io/gh/apache/hudi/commit/2f073643dfe764d34fee5a139d95633df01d9292?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`ea12e76`](https://app.codecov.io/gh/apache/hudi/commit/ea12e76bc5ce1a6ebbbf8209cb3efcec27f5ec2e?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 82 commits behind head on master. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18380?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...ent/timeline/versioning/v1/TimelineArchiverV1.java](https://app.codecov.io/gh/apache/hudi/pull/18380?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv1%2FTimelineArchiverV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YxL1RpbWVsaW5lQXJjaGl2ZXJWMS5qYXZh) | 80.95% | [3 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18380?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...java/org/apache/hudi/config/HoodieWriteConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18380?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2FHoodieWriteConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVXcml0ZUNvbmZpZy5qYXZh) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18380?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | > :exclamation: There is a different number of reports uploaded between BASE (2f07364) and HEAD (ea12e76). Click for more details. > > HEAD has 20 uploads less than BASE > >| Flag | BASE (2f07364) | HEAD (ea12e76) | >|--|--|--| >|spark-scala-tests|10|5| >|spark-java-tests|15|2| >|common-and-other-modules|1|0| >|utilities|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18380 +/- ## = - Coverage 68.36% 48.07% -20.30% + Complexity2756616522-11044 = Files 2432 2008 -424 Lines133175 112628-20547 Branches 1602314308 -1715 = - Hits 9104754143-36904 - Misses3506852808+17740 + Partials 7060 5677 -1383 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.73% <20.00%> (-0.42%)` | :arrow_down: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.57% <83.33%> (+<0.01%)` | :arrow_up: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.15% <20.00%> (-15.55%)` | :arrow_down: | | [spark-scala-tests](https://app.codeco
Re: [PR] feat: Adding support to block archival on last known ECTR for v6 tables [hudi]
codecov-commenter commented on PR #18380: URL: https://github.com/apache/hudi/pull/18380#issuecomment-4285219371 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18380?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `83.3%` with `5 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 48.55%. Comparing base ([`2f07364`](https://app.codecov.io/gh/apache/hudi/commit/2f073643dfe764d34fee5a139d95633df01d9292?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`ea12e76`](https://app.codecov.io/gh/apache/hudi/commit/ea12e76bc5ce1a6ebbbf8209cb3efcec27f5ec2e?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 82 commits behind head on master. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18380?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...ent/timeline/versioning/v1/TimelineArchiverV1.java](https://app.codecov.io/gh/apache/hudi/pull/18380?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv1%2FTimelineArchiverV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YxL1RpbWVsaW5lQXJjaGl2ZXJWMS5qYXZh) | 80.95% | [3 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18380?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...java/org/apache/hudi/config/HoodieWriteConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18380?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2FHoodieWriteConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVXcml0ZUNvbmZpZy5qYXZh) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18380?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | > :exclamation: There is a different number of reports uploaded between BASE (2f07364) and HEAD (ea12e76). Click for more details. > > HEAD has 22 uploads less than BASE > >| Flag | BASE (2f07364) | HEAD (ea12e76) | >|--|--|--| >|spark-scala-tests|10|4| >|spark-java-tests|15|1| >|common-and-other-modules|1|0| >|utilities|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18380 +/- ## = - Coverage 68.36% 48.55% -19.82% + Complexity2756616297-11269 = Files 2432 1979 -453 Lines133175 110025-23150 Branches 1602313754 -2269 = - Hits 9104753423-37624 - Misses3506851080+16012 + Partials 7060 5522 -1538 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.73% <20.00%> (-0.42%)` | :arrow_down: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.57% <83.33%> (+<0.01%)` | :arrow_up: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.53% <20.00%> (-15.17%)` | :arrow_down: | | [spark-scala-tests](https://app.codeco
Re: [PR] feat: Adding support to block archival on last known ECTR for v6 tables [hudi]
codecov-commenter commented on PR #18380: URL: https://github.com/apache/hudi/pull/18380#issuecomment-4285211088 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18380?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `83.3%` with `5 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 49.16%. Comparing base ([`2f07364`](https://app.codecov.io/gh/apache/hudi/commit/2f073643dfe764d34fee5a139d95633df01d9292?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`ea12e76`](https://app.codecov.io/gh/apache/hudi/commit/ea12e76bc5ce1a6ebbbf8209cb3efcec27f5ec2e?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 82 commits behind head on master. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18380?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...ent/timeline/versioning/v1/TimelineArchiverV1.java](https://app.codecov.io/gh/apache/hudi/pull/18380?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv1%2FTimelineArchiverV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YxL1RpbWVsaW5lQXJjaGl2ZXJWMS5qYXZh) | 80.95% | [3 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18380?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...java/org/apache/hudi/config/HoodieWriteConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18380?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2FHoodieWriteConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVXcml0ZUNvbmZpZy5qYXZh) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18380?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | > :exclamation: There is a different number of reports uploaded between BASE (2f07364) and HEAD (ea12e76). Click for more details. > > HEAD has 23 uploads less than BASE > >| Flag | BASE (2f07364) | HEAD (ea12e76) | >|--|--|--| >|spark-scala-tests|10|3| >|spark-java-tests|15|1| >|common-and-other-modules|1|0| >|utilities|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18380 +/- ## = - Coverage 68.36% 49.16% -19.21% + Complexity2756616135-11431 = Files 2432 1961 -471 Lines133175 107664-25511 Branches 1602313250 -2773 = - Hits 9104752933-38114 - Misses3506849353+14285 + Partials 7060 5378 -1682 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.73% <20.00%> (-0.42%)` | :arrow_down: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.57% <83.33%> (+<0.01%)` | :arrow_up: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.53% <20.00%> (-15.17%)` | :arrow_down: | | [spark-scala-tests](https://app.codeco
Re: [PR] feat: Adding support to block archival on last known ECTR for v6 tables [hudi]
codecov-commenter commented on PR #18380: URL: https://github.com/apache/hudi/pull/18380#issuecomment-4285198760 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18380?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `83.3%` with `5 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 49.77%. Comparing base ([`2f07364`](https://app.codecov.io/gh/apache/hudi/commit/2f073643dfe764d34fee5a139d95633df01d9292?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`ea12e76`](https://app.codecov.io/gh/apache/hudi/commit/ea12e76bc5ce1a6ebbbf8209cb3efcec27f5ec2e?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 82 commits behind head on master. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18380?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...ent/timeline/versioning/v1/TimelineArchiverV1.java](https://app.codecov.io/gh/apache/hudi/pull/18380?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv1%2FTimelineArchiverV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YxL1RpbWVsaW5lQXJjaGl2ZXJWMS5qYXZh) | 80.95% | [3 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18380?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...java/org/apache/hudi/config/HoodieWriteConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18380?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2FHoodieWriteConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVXcml0ZUNvbmZpZy5qYXZh) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18380?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | > :exclamation: There is a different number of reports uploaded between BASE (2f07364) and HEAD (ea12e76). Click for more details. > > HEAD has 25 uploads less than BASE > >| Flag | BASE (2f07364) | HEAD (ea12e76) | >|--|--|--| >|spark-scala-tests|10|1| >|spark-java-tests|15|1| >|common-and-other-modules|1|0| >|utilities|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18380 +/- ## = - Coverage 68.36% 49.77% -18.60% + Complexity2756615971-11595 = Files 2432 1944 -488 Lines133175 105319-27856 Branches 1602312749 -3274 = - Hits 9104752420-38627 - Misses3506847664+12596 + Partials 7060 5235 -1825 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.73% <20.00%> (-0.42%)` | :arrow_down: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.57% <83.33%> (+<0.01%)` | :arrow_up: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.53% <20.00%> (-15.17%)` | :arrow_down: | | [spark-scala-tests](https://app.codeco
Re: [PR] feat: Adding support to block archival on last known ECTR for v6 tables [hudi]
codecov-commenter commented on PR #18380: URL: https://github.com/apache/hudi/pull/18380#issuecomment-4285195054 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18380?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `83.3%` with `5 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 46.77%. Comparing base ([`2f07364`](https://app.codecov.io/gh/apache/hudi/commit/2f073643dfe764d34fee5a139d95633df01d9292?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`ea12e76`](https://app.codecov.io/gh/apache/hudi/commit/ea12e76bc5ce1a6ebbbf8209cb3efcec27f5ec2e?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 82 commits behind head on master. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18380?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...ent/timeline/versioning/v1/TimelineArchiverV1.java](https://app.codecov.io/gh/apache/hudi/pull/18380?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv1%2FTimelineArchiverV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YxL1RpbWVsaW5lQXJjaGl2ZXJWMS5qYXZh) | 80.95% | [3 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18380?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...java/org/apache/hudi/config/HoodieWriteConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18380?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2FHoodieWriteConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVXcml0ZUNvbmZpZy5qYXZh) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18380?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | > :exclamation: There is a different number of reports uploaded between BASE (2f07364) and HEAD (ea12e76). Click for more details. > > HEAD has 26 uploads less than BASE > >| Flag | BASE (2f07364) | HEAD (ea12e76) | >|--|--|--| >|spark-scala-tests|10|1| >|spark-java-tests|15|0| >|common-and-other-modules|1|0| >|utilities|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18380 +/- ## = - Coverage 68.36% 46.77% -21.60% + Complexity2756615060-12506 = Files 2432 1944 -488 Lines133175 105302-27873 Branches 1602312665 -3358 = - Hits 9104749253-41794 - Misses3506850993+15925 + Partials 7060 5056 -2004 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.73% <20.00%> (-0.42%)` | :arrow_down: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.57% <83.33%> (+<0.01%)` | :arrow_up: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?
Re: [PR] feat: Adding support to block archival on last known ECTR for v6 tables [hudi]
codecov-commenter commented on PR #18380: URL: https://github.com/apache/hudi/pull/18380#issuecomment-4285192249 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18380?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `20.0%` with `24 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 39.80%. Comparing base ([`2f07364`](https://app.codecov.io/gh/apache/hudi/commit/2f073643dfe764d34fee5a139d95633df01d9292?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`ea12e76`](https://app.codecov.io/gh/apache/hudi/commit/ea12e76bc5ce1a6ebbbf8209cb3efcec27f5ec2e?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 82 commits behind head on master. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18380?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...ent/timeline/versioning/v1/TimelineArchiverV1.java](https://app.codecov.io/gh/apache/hudi/pull/18380?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv1%2FTimelineArchiverV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YxL1RpbWVsaW5lQXJjaGl2ZXJWMS5qYXZh) | 0.00% | [21 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18380?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...a/org/apache/hudi/config/HoodieArchivalConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18380?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2FHoodieArchivalConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVBcmNoaXZhbENvbmZpZy5qYXZh) | 75.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18380?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...java/org/apache/hudi/config/HoodieWriteConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18380?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2FHoodieWriteConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVXcml0ZUNvbmZpZy5qYXZh) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18380?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | > :exclamation: There is a different number of reports uploaded between BASE (2f07364) and HEAD (ea12e76). Click for more details. > > HEAD has 27 uploads less than BASE > >| Flag | BASE (2f07364) | HEAD (ea12e76) | >|--|--|--| >|spark-client-hadoop-common|1|0| >|spark-scala-tests|10|1| >|spark-java-tests|15|0| >|common-and-other-modules|1|0| >|utilities|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18380 +/- ## = - Coverage 68.36% 39.80% -28.57% + Complexity2756612414-15152 = Files 2432 1944 -488 Lines133175 105302-27873 Branches 1602312665 -3358 = - Hits 9104741916-49131 - Misses3506858419+23351 + Partials 7060 4967 -2093 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18380/fl
Re: [PR] feat: Adding support to block archival on last known ECTR for v6 tables [hudi]
codecov-commenter commented on PR #18380: URL: https://github.com/apache/hudi/pull/18380#issuecomment-4285120543 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18380?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `20.0%` with `24 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 44.73%. Comparing base ([`2f07364`](https://app.codecov.io/gh/apache/hudi/commit/2f073643dfe764d34fee5a139d95633df01d9292?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`ea12e76`](https://app.codecov.io/gh/apache/hudi/commit/ea12e76bc5ce1a6ebbbf8209cb3efcec27f5ec2e?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 81 commits behind head on master. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18380?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...ent/timeline/versioning/v1/TimelineArchiverV1.java](https://app.codecov.io/gh/apache/hudi/pull/18380?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv1%2FTimelineArchiverV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YxL1RpbWVsaW5lQXJjaGl2ZXJWMS5qYXZh) | 0.00% | [21 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18380?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...a/org/apache/hudi/config/HoodieArchivalConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18380?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2FHoodieArchivalConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVBcmNoaXZhbENvbmZpZy5qYXZh) | 75.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18380?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...java/org/apache/hudi/config/HoodieWriteConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18380?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2FHoodieWriteConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVXcml0ZUNvbmZpZy5qYXZh) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18380?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | > :exclamation: There is a different number of reports uploaded between BASE (2f07364) and HEAD (ea12e76). Click for more details. > > HEAD has 28 uploads less than BASE > >| Flag | BASE (2f07364) | HEAD (ea12e76) | >|--|--|--| >|spark-client-hadoop-common|1|0| >|spark-scala-tests|10|0| >|spark-java-tests|15|0| >|common-and-other-modules|1|0| >|utilities|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18380 +/- ## = - Coverage 68.36% 44.73% -23.64% + Complexity27566 8487-19079 = Files 2432 1198 -1234 Lines13317562372-70803 Branches 16023 6737 -9286 = - Hits 9104727899-63148 + Misses3506831436 -3632 + Partials 7060 3037 -4023 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18380/fl
Re: [PR] feat: Adding support to block archival on last known ECTR for v6 tables [hudi]
hudi-bot commented on PR #18380: URL: https://github.com/apache/hudi/pull/18380#issuecomment-4285094814 ## CI report: * c33f5100a0a238b77c5674383170d6ac54ad9c80 Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13294) * ea12e76bc5ce1a6ebbbf8209cb3efcec27f5ec2e Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13394) Bot commands @hudi-bot supports the following commands: - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] feat: Adding support to block archival on last known ECTR for v6 tables [hudi]
hudi-bot commented on PR #18380: URL: https://github.com/apache/hudi/pull/18380#issuecomment-4285085008 ## CI report: * c33f5100a0a238b77c5674383170d6ac54ad9c80 Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13294) * ea12e76bc5ce1a6ebbbf8209cb3efcec27f5ec2e UNKNOWN Bot commands @hudi-bot supports the following commands: - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] feat: Adding support to block archival on last known ECTR for v6 tables [hudi]
nsivabalan commented on PR #18380: URL: https://github.com/apache/hudi/pull/18380#issuecomment-4285072806 @yihua : addressed all feedback -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] feat: Adding support to block archival on last known ECTR for v6 tables [hudi]
nsivabalan commented on code in PR #18380:
URL: https://github.com/apache/hudi/pull/18380#discussion_r3114309935
##
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/timeline/versioning/v1/TimelineArchiverV1.java:
##
@@ -271,7 +272,31 @@ private Stream getCommitInstantsToArchive()
throws IOException {
Option oldestInstantToRetainForClustering =
ClusteringUtils.getEarliestInstantToRetainForClustering(table.getActiveTimeline(),
table.getMetaClient(), config.getCleanerPolicy());
+ // If enabled, block archival based on ECTR from the last completed
clean to ensure we don't archive
+ // commits that have data files that haven't been cleaned yet.
+ Option oldestInstantToRetainForClean = Option.empty();
+ if (config.shouldBlockArchivalOnCleanECTR()) {
+Option lastCleanInstant =
table.getCleanTimeline().filterCompletedInstants().lastInstant();
+if (lastCleanInstant.isPresent()) {
+ try {
+org.apache.hudi.avro.model.HoodieCleanMetadata cleanMetadata =
+
table.getActiveTimeline().readCleanMetadata(lastCleanInstant.get());
+if (cleanMetadata.getEarliestCommitToRetain() != null
+&&
!cleanMetadata.getEarliestCommitToRetain().trim().isEmpty()) {
+ oldestInstantToRetainForClean =
commitTimeline.findInstantsAfterOrEquals(
+ cleanMetadata.getEarliestCommitToRetain()).firstInstant();
+ log.info("Blocking archival based on ECTR {} from last clean {}",
Review Comment:
sure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] feat: Adding support to block archival on last known ECTR for v6 tables [hudi]
nsivabalan commented on code in PR #18380:
URL: https://github.com/apache/hudi/pull/18380#discussion_r3114309134
##
hudi-client/hudi-spark-client/src/test/java/org/apache/hudi/io/TestHoodieTimelineArchiver.java:
##
@@ -2189,4 +2192,544 @@ public void testArchivalMetricsWithMixedActionTypes()
throws Exception {
// Verify archival status is success
assertEquals(1L, metrics.get(ArchivalMetrics.ARCHIVAL_STATUS), "Archival
should succeed");
}
+
+ private void initTableToTestECTRBlock() throws IOException {
+HoodieTableType tableType = HoodieTableType.COPY_ON_WRITE;
+initPath();
+initSparkContexts();
+initTimelineService();
+Properties properties = new Properties();
+properties.setProperty(HoodieWriteConfig.WRITE_TABLE_VERSION.key(), "6");
+properties.setProperty(HoodieWriteConfig.AUTO_UPGRADE_VERSION.key(),
"false");
+initMetaClient(properties);
+storage = metaClient.getStorage();
+metaClient.getStorage().createDirectory(new StoragePath(basePath));
+metaClient = HoodieTestUtils.init(storageConf, basePath, tableType,
properties);
+ }
+
+ /**
+ * Tests archival blocking based on ECTR from last clean when config is
enabled.
+ * Verifies that commits with timestamp >= ECTR are not archived.
+ */
+ @Test
+ public void testArchivalBlocksOnCleanECTRWhenEnabled() throws Exception {
+initTableToTestECTRBlock();
+
+// Create config with ECTR blocking enabled
+HoodieWriteConfig writeConfig = HoodieWriteConfig.newBuilder()
+.withPath(basePath)
+.withSchema(HoodieTestDataGenerator.TRIP_EXAMPLE_SCHEMA)
+.withParallelism(2, 2)
+.withArchivalConfig(HoodieArchivalConfig.newBuilder()
+.archiveCommitsWith(2, 3)
+.withBlockArchivalOnCleanECTR(true) // Enable ECTR blocking
+.build())
+.withCleanConfig(HoodieCleanConfig.newBuilder()
+.retainCommits(1)
+.build())
+.withFileSystemViewConfig(FileSystemViewStorageConfig.newBuilder()
+.withRemoteServerPort(timelineServicePort)
+.build())
+.withMetadataConfig(HoodieMetadataConfig.newBuilder()
+.enable(false)
+.build())
+.forTable("test-trip-table")
+.build();
+
+HoodieTestTable testTable = HoodieTestTable.of(metaClient);
+
+// Create 5 commits: 0001, 0002, 0003, 0004, 0005
+for (int i = 1; i <= 5; i++) {
+ testTable.addCommit(String.format("%08d", i));
+}
+
+// Create a clean commit with ECTR pointing to commit 0003
+// This means commits 0003 and later should not be archived
+Map cleanStats = new HashMap<>();
+cleanStats.put("p1", 1);
+cleanStats.put("p2", 1);
+
+List cleanStatsList = new
ArrayList<>();
+cleanStatsList.add(new org.apache.hudi.common.HoodieCleanStat(
+HoodieCleaningPolicy.KEEP_LATEST_COMMITS,
+"p1",
+Collections.emptyList(),
+Collections.emptyList(),
+Collections.emptyList(),
+"0003", // ECTR
+"0005"
+));
+cleanStatsList.add(new org.apache.hudi.common.HoodieCleanStat(
+HoodieCleaningPolicy.KEEP_LATEST_COMMITS,
+"p2",
+Collections.emptyList(),
+Collections.emptyList(),
+Collections.emptyList(),
+"0003", // ECTR
+"0005"
+));
+
+org.apache.hudi.avro.model.HoodieCleanMetadata cleanMetadata =
+CleanerUtils.convertCleanMetadata("0006", Option.of(0L),
cleanStatsList, Collections.emptyMap());
+org.apache.hudi.avro.model.HoodieCleanerPlan cleanerPlan =
+new org.apache.hudi.avro.model.HoodieCleanerPlan(
+new org.apache.hudi.avro.model.HoodieActionInstant("0003",
CLEAN_ACTION, ""),
+"", "", new HashMap<>(), CleanMetadataV2MigrationHandler.VERSION,
new HashMap<>(), new ArrayList<>(), Collections.emptyMap());
+
+testTable.addClean("0006", cleanerPlan, cleanMetadata);
+
+// Reload metaClient to pick up the clean commit
+metaClient = HoodieTableMetaClient.reload(metaClient);
+
+// Trigger archival
+HoodieTable table = HoodieSparkTable.create(writeConfig, context,
metaClient);
+TimelineArchiverV1 archiver = new TimelineArchiverV1(writeConfig, table);
+archiver.archiveIfRequired(context);
+
+// Reload timeline and get active commits
+metaClient = HoodieTableMetaClient.reload(metaClient);
+HoodieActiveTimeline activeTimeline = metaClient.getActiveTimeline();
+List activeCommits =
activeTimeline.getCommitsTimeline().filterCompletedInstants().getInstants();
+
+// Verify that commits 0003, 0004, 0005 are still in active
timeline (not archived)
+List activeCommitTimes = activeCommits.stream()
+.map(HoodieInstant::requestedTime)
+.collect(Collectors.toList());
+
+assertTrue(activeCommitTimes.contains("0003"), "Commit 0003 (ECTR)
should not be ar
Re: [PR] feat: Adding support to block archival on last known ECTR for v6 tables [hudi]
nsivabalan commented on code in PR #18380:
URL: https://github.com/apache/hudi/pull/18380#discussion_r3114286516
##
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/timeline/versioning/v1/TimelineArchiverV1.java:
##
@@ -271,7 +272,31 @@ private Stream getCommitInstantsToArchive()
throws IOException {
Option oldestInstantToRetainForClustering =
ClusteringUtils.getEarliestInstantToRetainForClustering(table.getActiveTimeline(),
table.getMetaClient(), config.getCleanerPolicy());
+ // If enabled, block archival based on ECTR from the last completed
clean to ensure we don't archive
+ // commits that have data files that haven't been cleaned yet.
+ Option oldestInstantToRetainForClean = Option.empty();
+ if (config.shouldBlockArchivalOnCleanECTR()) {
Review Comment:
https://github.com/apache/hudi/issues/18536
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] feat: Adding support to block archival on last known ECTR for v6 tables [hudi]
nsivabalan commented on code in PR #18380:
URL: https://github.com/apache/hudi/pull/18380#discussion_r3114258044
##
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/config/HoodieWriteConfig.java:
##
@@ -1975,6 +1975,10 @@ public int getCommitArchivalBatchSize() {
return getInt(HoodieArchivalConfig.COMMITS_ARCHIVAL_BATCH_SIZE);
}
+ public boolean shouldBlockArchivalOnCleanECTR() {
Review Comment:
Its very lengthy name. by now, ECTR is widely used in hudi (similar to cow
and mor), so wanted to keep it that way
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] feat: Adding support to block archival on last known ECTR for v6 tables [hudi]
yihua commented on code in PR #18380:
URL: https://github.com/apache/hudi/pull/18380#discussion_r3113235154
##
hudi-client/hudi-spark-client/src/test/java/org/apache/hudi/io/TestHoodieTimelineArchiver.java:
##
@@ -2189,4 +2192,544 @@ public void testArchivalMetricsWithMixedActionTypes()
throws Exception {
// Verify archival status is success
assertEquals(1L, metrics.get(ArchivalMetrics.ARCHIVAL_STATUS), "Archival
should succeed");
}
+
+ private void initTableToTestECTRBlock() throws IOException {
+HoodieTableType tableType = HoodieTableType.COPY_ON_WRITE;
+initPath();
+initSparkContexts();
+initTimelineService();
+Properties properties = new Properties();
+properties.setProperty(HoodieWriteConfig.WRITE_TABLE_VERSION.key(), "6");
+properties.setProperty(HoodieWriteConfig.AUTO_UPGRADE_VERSION.key(),
"false");
+initMetaClient(properties);
+storage = metaClient.getStorage();
+metaClient.getStorage().createDirectory(new StoragePath(basePath));
+metaClient = HoodieTestUtils.init(storageConf, basePath, tableType,
properties);
+ }
+
+ /**
+ * Tests archival blocking based on ECTR from last clean when config is
enabled.
+ * Verifies that commits with timestamp >= ECTR are not archived.
+ */
+ @Test
+ public void testArchivalBlocksOnCleanECTRWhenEnabled() throws Exception {
+initTableToTestECTRBlock();
+
+// Create config with ECTR blocking enabled
+HoodieWriteConfig writeConfig = HoodieWriteConfig.newBuilder()
+.withPath(basePath)
+.withSchema(HoodieTestDataGenerator.TRIP_EXAMPLE_SCHEMA)
+.withParallelism(2, 2)
+.withArchivalConfig(HoodieArchivalConfig.newBuilder()
+.archiveCommitsWith(2, 3)
+.withBlockArchivalOnCleanECTR(true) // Enable ECTR blocking
+.build())
+.withCleanConfig(HoodieCleanConfig.newBuilder()
+.retainCommits(1)
+.build())
+.withFileSystemViewConfig(FileSystemViewStorageConfig.newBuilder()
+.withRemoteServerPort(timelineServicePort)
+.build())
+.withMetadataConfig(HoodieMetadataConfig.newBuilder()
+.enable(false)
+.build())
+.forTable("test-trip-table")
+.build();
+
+HoodieTestTable testTable = HoodieTestTable.of(metaClient);
+
+// Create 5 commits: 0001, 0002, 0003, 0004, 0005
+for (int i = 1; i <= 5; i++) {
+ testTable.addCommit(String.format("%08d", i));
+}
+
+// Create a clean commit with ECTR pointing to commit 0003
+// This means commits 0003 and later should not be archived
+Map cleanStats = new HashMap<>();
+cleanStats.put("p1", 1);
+cleanStats.put("p2", 1);
+
+List cleanStatsList = new
ArrayList<>();
+cleanStatsList.add(new org.apache.hudi.common.HoodieCleanStat(
+HoodieCleaningPolicy.KEEP_LATEST_COMMITS,
+"p1",
+Collections.emptyList(),
+Collections.emptyList(),
+Collections.emptyList(),
+"0003", // ECTR
+"0005"
+));
+cleanStatsList.add(new org.apache.hudi.common.HoodieCleanStat(
+HoodieCleaningPolicy.KEEP_LATEST_COMMITS,
+"p2",
+Collections.emptyList(),
+Collections.emptyList(),
+Collections.emptyList(),
+"0003", // ECTR
+"0005"
+));
+
+org.apache.hudi.avro.model.HoodieCleanMetadata cleanMetadata =
+CleanerUtils.convertCleanMetadata("0006", Option.of(0L),
cleanStatsList, Collections.emptyMap());
+org.apache.hudi.avro.model.HoodieCleanerPlan cleanerPlan =
+new org.apache.hudi.avro.model.HoodieCleanerPlan(
+new org.apache.hudi.avro.model.HoodieActionInstant("0003",
CLEAN_ACTION, ""),
+"", "", new HashMap<>(), CleanMetadataV2MigrationHandler.VERSION,
new HashMap<>(), new ArrayList<>(), Collections.emptyMap());
+
+testTable.addClean("0006", cleanerPlan, cleanMetadata);
+
+// Reload metaClient to pick up the clean commit
+metaClient = HoodieTableMetaClient.reload(metaClient);
+
+// Trigger archival
+HoodieTable table = HoodieSparkTable.create(writeConfig, context,
metaClient);
+TimelineArchiverV1 archiver = new TimelineArchiverV1(writeConfig, table);
+archiver.archiveIfRequired(context);
+
+// Reload timeline and get active commits
+metaClient = HoodieTableMetaClient.reload(metaClient);
+HoodieActiveTimeline activeTimeline = metaClient.getActiveTimeline();
+List activeCommits =
activeTimeline.getCommitsTimeline().filterCompletedInstants().getInstants();
+
+// Verify that commits 0003, 0004, 0005 are still in active
timeline (not archived)
+List activeCommitTimes = activeCommits.stream()
+.map(HoodieInstant::requestedTime)
+.collect(Collectors.toList());
+
+assertTrue(activeCommitTimes.contains("0003"), "Commit 0003 (ECTR)
should not be archive
Re: [PR] feat: Adding support to block archival on last known ECTR for v6 tables [hudi]
yihua commented on code in PR #18380:
URL: https://github.com/apache/hudi/pull/18380#discussion_r3112724584
##
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/timeline/versioning/v1/TimelineArchiverV1.java:
##
@@ -271,7 +272,31 @@ private Stream getCommitInstantsToArchive()
throws IOException {
Option oldestInstantToRetainForClustering =
ClusteringUtils.getEarliestInstantToRetainForClustering(table.getActiveTimeline(),
table.getMetaClient(), config.getCleanerPolicy());
+ // If enabled, block archival based on ECTR from the last completed
clean to ensure we don't archive
+ // commits that have data files that haven't been cleaned yet.
+ Option oldestInstantToRetainForClean = Option.empty();
+ if (config.shouldBlockArchivalOnCleanECTR()) {
+Option lastCleanInstant =
table.getCleanTimeline().filterCompletedInstants().lastInstant();
+if (lastCleanInstant.isPresent()) {
+ try {
+org.apache.hudi.avro.model.HoodieCleanMetadata cleanMetadata =
Review Comment:
nit: import `HoodieCleanMetadata`?
```suggestion
HoodieCleanMetadata cleanMetadata =
```
##
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/timeline/versioning/v1/TimelineArchiverV1.java:
##
@@ -271,7 +272,31 @@ private Stream getCommitInstantsToArchive()
throws IOException {
Option oldestInstantToRetainForClustering =
ClusteringUtils.getEarliestInstantToRetainForClustering(table.getActiveTimeline(),
table.getMetaClient(), config.getCleanerPolicy());
+ // If enabled, block archival based on ECTR from the last completed
clean to ensure we don't archive
+ // commits that have data files that haven't been cleaned yet.
+ Option oldestInstantToRetainForClean = Option.empty();
+ if (config.shouldBlockArchivalOnCleanECTR()) {
+Option lastCleanInstant =
table.getCleanTimeline().filterCompletedInstants().lastInstant();
+if (lastCleanInstant.isPresent()) {
+ try {
+org.apache.hudi.avro.model.HoodieCleanMetadata cleanMetadata =
+
table.getActiveTimeline().readCleanMetadata(lastCleanInstant.get());
+if (cleanMetadata.getEarliestCommitToRetain() != null
+&&
!cleanMetadata.getEarliestCommitToRetain().trim().isEmpty()) {
+ oldestInstantToRetainForClean =
commitTimeline.findInstantsAfterOrEquals(
+ cleanMetadata.getEarliestCommitToRetain()).firstInstant();
+ log.info("Blocking archival based on ECTR {} from last clean {}",
Review Comment:
```suggestion
log.info("Blocking archival based on earliest commit to retain
{} from last clean {}",
```
##
hudi-client/hudi-spark-client/src/test/java/org/apache/hudi/io/TestHoodieTimelineArchiver.java:
##
@@ -2189,4 +2192,544 @@ public void testArchivalMetricsWithMixedActionTypes()
throws Exception {
// Verify archival status is success
assertEquals(1L, metrics.get(ArchivalMetrics.ARCHIVAL_STATUS), "Archival
should succeed");
}
+
+ private void initTableToTestECTRBlock() throws IOException {
+HoodieTableType tableType = HoodieTableType.COPY_ON_WRITE;
+initPath();
+initSparkContexts();
+initTimelineService();
+Properties properties = new Properties();
+properties.setProperty(HoodieWriteConfig.WRITE_TABLE_VERSION.key(), "6");
+properties.setProperty(HoodieWriteConfig.AUTO_UPGRADE_VERSION.key(),
"false");
+initMetaClient(properties);
+storage = metaClient.getStorage();
+metaClient.getStorage().createDirectory(new StoragePath(basePath));
+metaClient = HoodieTestUtils.init(storageConf, basePath, tableType,
properties);
+ }
+
+ /**
+ * Tests archival blocking based on ECTR from last clean when config is
enabled.
+ * Verifies that commits with timestamp >= ECTR are not archived.
+ */
+ @Test
+ public void testArchivalBlocksOnCleanECTRWhenEnabled() throws Exception {
+initTableToTestECTRBlock();
+
+// Create config with ECTR blocking enabled
+HoodieWriteConfig writeConfig = HoodieWriteConfig.newBuilder()
+.withPath(basePath)
+.withSchema(HoodieTestDataGenerator.TRIP_EXAMPLE_SCHEMA)
+.withParallelism(2, 2)
+.withArchivalConfig(HoodieArchivalConfig.newBuilder()
+.archiveCommitsWith(2, 3)
+.withBlockArchivalOnCleanECTR(true) // Enable ECTR blocking
+.build())
+.withCleanConfig(HoodieCleanConfig.newBuilder()
+.retainCommits(1)
+.build())
+.withFileSystemViewConfig(FileSystemViewStorageConfig.newBuilder()
+.withRemoteServerPort(timelineServicePort)
+.build())
+.withMetadataConfig(HoodieMetadataConfig.newBuilder()
+.enable(false)
+.build())
+.forTable("test-trip-table")
+.build();
+
+HoodieTestT
Re: [PR] feat: Adding support to block archival on last known ECTR for v6 tables [hudi]
hudi-bot commented on PR #18380: URL: https://github.com/apache/hudi/pull/18380#issuecomment-4257262559 ## CI report: * c33f5100a0a238b77c5674383170d6ac54ad9c80 Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13294) Bot commands @hudi-bot supports the following commands: - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] feat: Adding support to block archival on last known ECTR for v6 tables [hudi]
codecov-commenter commented on PR #18380: URL: https://github.com/apache/hudi/pull/18380#issuecomment-4257245919 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18380?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `86.7%` with `4 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 68.85%. Comparing base ([`2f07364`](https://app.codecov.io/gh/apache/hudi/commit/2f073643dfe764d34fee5a139d95633df01d9292?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`c33f510`](https://app.codecov.io/gh/apache/hudi/commit/c33f5100a0a238b77c5674383170d6ac54ad9c80?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 62 commits behind head on master. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18380?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...ent/timeline/versioning/v1/TimelineArchiverV1.java](https://app.codecov.io/gh/apache/hudi/pull/18380?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv1%2FTimelineArchiverV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YxL1RpbWVsaW5lQXJjaGl2ZXJWMS5qYXZh) | 80.95% | [3 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18380?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18380 +/- ## + Coverage 68.36% 68.85% +0.48% - Complexity2756628223 +657 Files 2432 2460 +28 Lines133175 135290+2115 Branches 1602316399 +376 + Hits 9104793148+2101 + Misses3506834764 -304 - Partials 7060 7378 +318 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.59% <40.00%> (+0.27%)` | :arrow_up: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.86% <23.33%> (-0.29%)` | :arrow_down: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.61% <86.66%> (+0.04%)` | :arrow_up: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.92% <40.00%> (+0.22%)` | :arrow_up: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.50% <23.33%> (+0.11%)` | :arrow_up: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.23% <40.00%> (-0.30%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18380?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...a/org/apache/hudi/config/HoodieArchivalConfig.java
Re: [PR] feat: Adding support to block archival on last known ECTR for v6 tables [hudi]
codecov-commenter commented on PR #18380: URL: https://github.com/apache/hudi/pull/18380#issuecomment-4257240823 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18380?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `86.7%` with `4 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 68.85%. Comparing base ([`2f07364`](https://app.codecov.io/gh/apache/hudi/commit/2f073643dfe764d34fee5a139d95633df01d9292?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`c33f510`](https://app.codecov.io/gh/apache/hudi/commit/c33f5100a0a238b77c5674383170d6ac54ad9c80?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 62 commits behind head on master. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18380?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...ent/timeline/versioning/v1/TimelineArchiverV1.java](https://app.codecov.io/gh/apache/hudi/pull/18380?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv1%2FTimelineArchiverV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YxL1RpbWVsaW5lQXJjaGl2ZXJWMS5qYXZh) | 80.95% | [3 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18380?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18380 +/- ## + Coverage 68.36% 68.85% +0.48% - Complexity2756628223 +657 Files 2432 2460 +28 Lines133175 135290+2115 Branches 1602316399 +376 + Hits 9104793148+2101 + Misses3506834764 -304 - Partials 7060 7378 +318 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.59% <40.00%> (+0.27%)` | :arrow_up: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.86% <23.33%> (-0.29%)` | :arrow_down: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.61% <86.66%> (+0.04%)` | :arrow_up: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.89% <40.00%> (+0.19%)` | :arrow_up: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.50% <23.33%> (+0.11%)` | :arrow_up: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.23% <40.00%> (-0.30%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18380?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...a/org/apache/hudi/config/HoodieArchivalConfig.java
Re: [PR] feat: Adding support to block archival on last known ECTR for v6 tables [hudi]
codecov-commenter commented on PR #18380: URL: https://github.com/apache/hudi/pull/18380#issuecomment-4257230188 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18380?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `86.7%` with `4 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 68.85%. Comparing base ([`2f07364`](https://app.codecov.io/gh/apache/hudi/commit/2f073643dfe764d34fee5a139d95633df01d9292?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`c33f510`](https://app.codecov.io/gh/apache/hudi/commit/c33f5100a0a238b77c5674383170d6ac54ad9c80?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 61 commits behind head on master. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18380?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...ent/timeline/versioning/v1/TimelineArchiverV1.java](https://app.codecov.io/gh/apache/hudi/pull/18380?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv1%2FTimelineArchiverV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YxL1RpbWVsaW5lQXJjaGl2ZXJWMS5qYXZh) | 80.95% | [3 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18380?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18380 +/- ## + Coverage 68.36% 68.85% +0.48% - Complexity2756628223 +657 Files 2432 2460 +28 Lines133175 135290+2115 Branches 1602316399 +376 + Hits 9104793148+2101 + Misses3506834764 -304 - Partials 7060 7378 +318 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.59% <40.00%> (+0.27%)` | :arrow_up: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.86% <23.33%> (-0.29%)` | :arrow_down: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.61% <86.66%> (+0.04%)` | :arrow_up: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.89% <40.00%> (+0.19%)` | :arrow_up: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.50% <23.33%> (+0.11%)` | :arrow_up: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.23% <40.00%> (-0.30%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18380?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...a/org/apache/hudi/config/HoodieArchivalConfig.java
Re: [PR] feat: Adding support to block archival on last known ECTR for v6 tables [hudi]
codecov-commenter commented on PR #18380: URL: https://github.com/apache/hudi/pull/18380#issuecomment-4257204682 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18380?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `86.7%` with `4 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 68.84%. Comparing base ([`2f07364`](https://app.codecov.io/gh/apache/hudi/commit/2f073643dfe764d34fee5a139d95633df01d9292?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`c33f510`](https://app.codecov.io/gh/apache/hudi/commit/c33f5100a0a238b77c5674383170d6ac54ad9c80?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 60 commits behind head on master. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18380?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...ent/timeline/versioning/v1/TimelineArchiverV1.java](https://app.codecov.io/gh/apache/hudi/pull/18380?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv1%2FTimelineArchiverV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YxL1RpbWVsaW5lQXJjaGl2ZXJWMS5qYXZh) | 80.95% | [3 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18380?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18380 +/- ## + Coverage 68.36% 68.84% +0.48% - Complexity2756628223 +657 Files 2432 2460 +28 Lines133175 135290+2115 Branches 1602316399 +376 + Hits 9104793146+2099 + Misses3506834766 -302 - Partials 7060 7378 +318 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.59% <40.00%> (+0.27%)` | :arrow_up: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.86% <23.33%> (-0.29%)` | :arrow_down: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.61% <86.66%> (+0.04%)` | :arrow_up: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.86% <40.00%> (+0.15%)` | :arrow_up: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.50% <23.33%> (+0.11%)` | :arrow_up: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.23% <40.00%> (-0.30%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18380?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...a/org/apache/hudi/config/HoodieArchivalConfig.java
Re: [PR] feat: Adding support to block archival on last known ECTR for v6 tables [hudi]
codecov-commenter commented on PR #18380: URL: https://github.com/apache/hudi/pull/18380#issuecomment-4257193721 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18380?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `86.7%` with `4 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 68.84%. Comparing base ([`2f07364`](https://app.codecov.io/gh/apache/hudi/commit/2f073643dfe764d34fee5a139d95633df01d9292?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`c33f510`](https://app.codecov.io/gh/apache/hudi/commit/c33f5100a0a238b77c5674383170d6ac54ad9c80?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 60 commits behind head on master. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18380?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...ent/timeline/versioning/v1/TimelineArchiverV1.java](https://app.codecov.io/gh/apache/hudi/pull/18380?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv1%2FTimelineArchiverV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YxL1RpbWVsaW5lQXJjaGl2ZXJWMS5qYXZh) | 80.95% | [3 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18380?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18380 +/- ## + Coverage 68.36% 68.84% +0.47% - Complexity2756628222 +656 Files 2432 2460 +28 Lines133175 135290+2115 Branches 1602316399 +376 + Hits 9104793136+2089 + Misses3506834776 -292 - Partials 7060 7378 +318 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.59% <40.00%> (+0.27%)` | :arrow_up: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.86% <23.33%> (-0.29%)` | :arrow_down: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.61% <86.66%> (+0.04%)` | :arrow_up: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.81% <40.00%> (+0.11%)` | :arrow_up: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.50% <23.33%> (+0.11%)` | :arrow_up: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.23% <40.00%> (-0.30%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18380?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...a/org/apache/hudi/config/HoodieArchivalConfig.java
Re: [PR] feat: Adding support to block archival on last known ECTR for v6 tables [hudi]
codecov-commenter commented on PR #18380: URL: https://github.com/apache/hudi/pull/18380#issuecomment-4257191557 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18380?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `86.7%` with `4 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 68.84%. Comparing base ([`2f07364`](https://app.codecov.io/gh/apache/hudi/commit/2f073643dfe764d34fee5a139d95633df01d9292?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`c33f510`](https://app.codecov.io/gh/apache/hudi/commit/c33f5100a0a238b77c5674383170d6ac54ad9c80?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 60 commits behind head on master. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18380?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...ent/timeline/versioning/v1/TimelineArchiverV1.java](https://app.codecov.io/gh/apache/hudi/pull/18380?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv1%2FTimelineArchiverV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YxL1RpbWVsaW5lQXJjaGl2ZXJWMS5qYXZh) | 80.95% | [3 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18380?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18380 +/- ## + Coverage 68.36% 68.84% +0.47% - Complexity2756628222 +656 Files 2432 2460 +28 Lines133175 135290+2115 Branches 1602316399 +376 + Hits 9104793135+2088 + Misses3506834777 -291 - Partials 7060 7378 +318 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.59% <40.00%> (+0.27%)` | :arrow_up: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.86% <23.33%> (-0.29%)` | :arrow_down: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.61% <86.66%> (+0.04%)` | :arrow_up: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.81% <40.00%> (+0.11%)` | :arrow_up: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.50% <23.33%> (+0.11%)` | :arrow_up: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.23% <40.00%> (-0.30%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18380?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...a/org/apache/hudi/config/HoodieArchivalConfig.java
Re: [PR] feat: Adding support to block archival on last known ECTR for v6 tables [hudi]
codecov-commenter commented on PR #18380: URL: https://github.com/apache/hudi/pull/18380#issuecomment-4257189168 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18380?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `86.7%` with `4 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 68.77%. Comparing base ([`2f07364`](https://app.codecov.io/gh/apache/hudi/commit/2f073643dfe764d34fee5a139d95633df01d9292?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`c33f510`](https://app.codecov.io/gh/apache/hudi/commit/c33f5100a0a238b77c5674383170d6ac54ad9c80?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 60 commits behind head on master. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18380?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...ent/timeline/versioning/v1/TimelineArchiverV1.java](https://app.codecov.io/gh/apache/hudi/pull/18380?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv1%2FTimelineArchiverV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YxL1RpbWVsaW5lQXJjaGl2ZXJWMS5qYXZh) | 80.95% | [3 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18380?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18380 +/- ## + Coverage 68.36% 68.77% +0.40% - Complexity2756628177 +611 Files 2432 2460 +28 Lines133175 135290+2115 Branches 1602316399 +376 + Hits 9104793045+1998 + Misses3506834852 -216 - Partials 7060 7393 +333 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.59% <40.00%> (+0.27%)` | :arrow_up: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.86% <23.33%> (-0.29%)` | :arrow_down: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.61% <86.66%> (+0.04%)` | :arrow_up: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.68% <40.00%> (-0.02%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.50% <23.33%> (+0.11%)` | :arrow_up: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.23% <40.00%> (-0.30%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18380?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...a/org/apache/hudi/config/HoodieArchivalConfig.ja
Re: [PR] feat: Adding support to block archival on last known ECTR for v6 tables [hudi]
codecov-commenter commented on PR #18380: URL: https://github.com/apache/hudi/pull/18380#issuecomment-4257185652 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18380?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `86.7%` with `4 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 68.75%. Comparing base ([`2f07364`](https://app.codecov.io/gh/apache/hudi/commit/2f073643dfe764d34fee5a139d95633df01d9292?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`c33f510`](https://app.codecov.io/gh/apache/hudi/commit/c33f5100a0a238b77c5674383170d6ac54ad9c80?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 60 commits behind head on master. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18380?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...ent/timeline/versioning/v1/TimelineArchiverV1.java](https://app.codecov.io/gh/apache/hudi/pull/18380?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv1%2FTimelineArchiverV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YxL1RpbWVsaW5lQXJjaGl2ZXJWMS5qYXZh) | 80.95% | [3 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18380?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18380 +/- ## + Coverage 68.36% 68.75% +0.38% - Complexity2756628170 +604 Files 2432 2460 +28 Lines133175 135290+2115 Branches 1602316399 +376 + Hits 9104793015+1968 + Misses3506834881 -187 - Partials 7060 7394 +334 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.59% <40.00%> (+0.27%)` | :arrow_up: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.86% <23.33%> (-0.29%)` | :arrow_down: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.61% <86.66%> (+0.04%)` | :arrow_up: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.64% <40.00%> (-0.06%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.50% <23.33%> (+0.11%)` | :arrow_up: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.23% <40.00%> (-0.30%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18380?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...a/org/apache/hudi/config/HoodieArchivalConfig.ja
Re: [PR] feat: Adding support to block archival on last known ECTR for v6 tables [hudi]
codecov-commenter commented on PR #18380: URL: https://github.com/apache/hudi/pull/18380#issuecomment-4257184029 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18380?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `86.7%` with `4 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 68.72%. Comparing base ([`2f07364`](https://app.codecov.io/gh/apache/hudi/commit/2f073643dfe764d34fee5a139d95633df01d9292?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`c33f510`](https://app.codecov.io/gh/apache/hudi/commit/c33f5100a0a238b77c5674383170d6ac54ad9c80?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 60 commits behind head on master. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18380?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...ent/timeline/versioning/v1/TimelineArchiverV1.java](https://app.codecov.io/gh/apache/hudi/pull/18380?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv1%2FTimelineArchiverV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YxL1RpbWVsaW5lQXJjaGl2ZXJWMS5qYXZh) | 80.95% | [3 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18380?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18380 +/- ## + Coverage 68.36% 68.72% +0.35% - Complexity2756628164 +598 Files 2432 2460 +28 Lines133175 135290+2115 Branches 1602316399 +376 + Hits 9104792980+1933 + Misses3506834907 -161 - Partials 7060 7403 +343 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.59% <40.00%> (+0.27%)` | :arrow_up: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.86% <23.33%> (-0.29%)` | :arrow_down: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.61% <86.66%> (+0.04%)` | :arrow_up: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.57% <40.00%> (-0.13%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.50% <23.33%> (+0.11%)` | :arrow_up: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.23% <40.00%> (-0.30%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18380?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...a/org/apache/hudi/config/HoodieArchivalConfig.ja
Re: [PR] feat: Adding support to block archival on last known ECTR for v6 tables [hudi]
codecov-commenter commented on PR #18380: URL: https://github.com/apache/hudi/pull/18380#issuecomment-4257183041 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18380?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `86.7%` with `4 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 68.72%. Comparing base ([`2f07364`](https://app.codecov.io/gh/apache/hudi/commit/2f073643dfe764d34fee5a139d95633df01d9292?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`c33f510`](https://app.codecov.io/gh/apache/hudi/commit/c33f5100a0a238b77c5674383170d6ac54ad9c80?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 60 commits behind head on master. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18380?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...ent/timeline/versioning/v1/TimelineArchiverV1.java](https://app.codecov.io/gh/apache/hudi/pull/18380?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv1%2FTimelineArchiverV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YxL1RpbWVsaW5lQXJjaGl2ZXJWMS5qYXZh) | 80.95% | [3 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18380?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18380 +/- ## + Coverage 68.36% 68.72% +0.35% - Complexity2756628164 +598 Files 2432 2460 +28 Lines133175 135290+2115 Branches 1602316399 +376 + Hits 9104792980+1933 + Misses3506834907 -161 - Partials 7060 7403 +343 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.59% <40.00%> (+0.27%)` | :arrow_up: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.86% <23.33%> (-0.29%)` | :arrow_down: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.61% <86.66%> (+0.04%)` | :arrow_up: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.57% <40.00%> (-0.13%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.50% <23.33%> (+0.11%)` | :arrow_up: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.23% <40.00%> (-0.30%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18380?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...a/org/apache/hudi/config/HoodieArchivalConfig.ja
Re: [PR] feat: Adding support to block archival on last known ECTR for v6 tables [hudi]
codecov-commenter commented on PR #18380: URL: https://github.com/apache/hudi/pull/18380#issuecomment-4257180949 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18380?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `86.7%` with `4 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 68.51%. Comparing base ([`2f07364`](https://app.codecov.io/gh/apache/hudi/commit/2f073643dfe764d34fee5a139d95633df01d9292?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`c33f510`](https://app.codecov.io/gh/apache/hudi/commit/c33f5100a0a238b77c5674383170d6ac54ad9c80?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 60 commits behind head on master. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18380?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...ent/timeline/versioning/v1/TimelineArchiverV1.java](https://app.codecov.io/gh/apache/hudi/pull/18380?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv1%2FTimelineArchiverV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YxL1RpbWVsaW5lQXJjaGl2ZXJWMS5qYXZh) | 80.95% | [3 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18380?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18380 +/- ## + Coverage 68.36% 68.51% +0.15% - Complexity2756628037 +471 Files 2432 2460 +28 Lines133175 135290+2115 Branches 1602316399 +376 + Hits 9104792700+1653 - Misses3506835286 +218 - Partials 7060 7304 +244 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.59% <40.00%> (+0.27%)` | :arrow_up: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.86% <23.33%> (-0.29%)` | :arrow_down: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.61% <86.66%> (+0.04%)` | :arrow_up: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.57% <40.00%> (-0.13%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.19% <23.33%> (-0.20%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.23% <40.00%> (-0.30%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18380?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...a/org/apache/hudi/config/HoodieArchivalConfig.
Re: [PR] feat: Adding support to block archival on last known ECTR for v6 tables [hudi]
codecov-commenter commented on PR #18380: URL: https://github.com/apache/hudi/pull/18380#issuecomment-4257175756 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18380?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `86.7%` with `4 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 68.48%. Comparing base ([`2f07364`](https://app.codecov.io/gh/apache/hudi/commit/2f073643dfe764d34fee5a139d95633df01d9292?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`c33f510`](https://app.codecov.io/gh/apache/hudi/commit/c33f5100a0a238b77c5674383170d6ac54ad9c80?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 60 commits behind head on master. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18380?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...ent/timeline/versioning/v1/TimelineArchiverV1.java](https://app.codecov.io/gh/apache/hudi/pull/18380?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv1%2FTimelineArchiverV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YxL1RpbWVsaW5lQXJjaGl2ZXJWMS5qYXZh) | 80.95% | [3 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18380?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18380 +/- ## + Coverage 68.36% 68.48% +0.11% - Complexity2756628037 +471 Files 2432 2460 +28 Lines133175 135290+2115 Branches 1602316399 +376 + Hits 9104792654+1607 - Misses3506835299 +231 - Partials 7060 7337 +277 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.59% <40.00%> (+0.27%)` | :arrow_up: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.86% <23.33%> (-0.29%)` | :arrow_down: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.61% <86.66%> (+0.04%)` | :arrow_up: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.57% <40.00%> (-0.13%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.14% <23.33%> (-0.25%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.23% <40.00%> (-0.30%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18380?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...a/org/apache/hudi/config/HoodieArchivalConfig.
Re: [PR] feat: Adding support to block archival on last known ECTR for v6 tables [hudi]
codecov-commenter commented on PR #18380: URL: https://github.com/apache/hudi/pull/18380#issuecomment-4257171122 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18380?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `86.7%` with `4 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 67.12%. Comparing base ([`2f07364`](https://app.codecov.io/gh/apache/hudi/commit/2f073643dfe764d34fee5a139d95633df01d9292?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`c33f510`](https://app.codecov.io/gh/apache/hudi/commit/c33f5100a0a238b77c5674383170d6ac54ad9c80?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 60 commits behind head on master. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18380?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...ent/timeline/versioning/v1/TimelineArchiverV1.java](https://app.codecov.io/gh/apache/hudi/pull/18380?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv1%2FTimelineArchiverV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YxL1RpbWVsaW5lQXJjaGl2ZXJWMS5qYXZh) | 80.95% | [3 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18380?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18380 +/- ## - Coverage 68.36% 67.12% -1.25% + Complexity2756627446 -120 Files 2432 2460 +28 Lines133175 135290+2115 Branches 1602316399 +376 - Hits 9104790808 -239 - Misses3506837045+1977 - Partials 7060 7437 +377 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.59% <40.00%> (+0.27%)` | :arrow_up: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.86% <23.33%> (-0.29%)` | :arrow_down: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.61% <86.66%> (+0.04%)` | :arrow_up: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `40.69% <40.00%> (-8.01%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.14% <23.33%> (-0.25%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.23% <40.00%> (-0.30%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18380?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...a/org/apache/hudi/config/HoodieArchivalConfig.
Re: [PR] feat: Adding support to block archival on last known ECTR for v6 tables [hudi]
codecov-commenter commented on PR #18380: URL: https://github.com/apache/hudi/pull/18380#issuecomment-4257163796 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18380?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `86.7%` with `4 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 67.00%. Comparing base ([`2f07364`](https://app.codecov.io/gh/apache/hudi/commit/2f073643dfe764d34fee5a139d95633df01d9292?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`c33f510`](https://app.codecov.io/gh/apache/hudi/commit/c33f5100a0a238b77c5674383170d6ac54ad9c80?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 60 commits behind head on master. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18380?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...ent/timeline/versioning/v1/TimelineArchiverV1.java](https://app.codecov.io/gh/apache/hudi/pull/18380?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv1%2FTimelineArchiverV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YxL1RpbWVsaW5lQXJjaGl2ZXJWMS5qYXZh) | 80.95% | [3 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18380?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18380 +/- ## - Coverage 68.36% 67.00% -1.37% + Complexity2756627379 -187 Files 2432 2460 +28 Lines133175 135290+2115 Branches 1602316399 +376 - Hits 9104790648 -399 - Misses3506837252+2184 - Partials 7060 7390 +330 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.59% <40.00%> (+0.27%)` | :arrow_up: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.86% <23.33%> (-0.29%)` | :arrow_down: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.61% <86.66%> (+0.04%)` | :arrow_up: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `40.69% <40.00%> (-8.01%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.96% <23.33%> (-0.43%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.23% <40.00%> (-0.30%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18380?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...a/org/apache/hudi/config/HoodieArchivalConfig.
Re: [PR] feat: Adding support to block archival on last known ECTR for v6 tables [hudi]
codecov-commenter commented on PR #18380: URL: https://github.com/apache/hudi/pull/18380#issuecomment-4257157913 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18380?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `86.7%` with `4 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 65.96%. Comparing base ([`2f07364`](https://app.codecov.io/gh/apache/hudi/commit/2f073643dfe764d34fee5a139d95633df01d9292?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`c33f510`](https://app.codecov.io/gh/apache/hudi/commit/c33f5100a0a238b77c5674383170d6ac54ad9c80?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 60 commits behind head on master. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18380?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...ent/timeline/versioning/v1/TimelineArchiverV1.java](https://app.codecov.io/gh/apache/hudi/pull/18380?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv1%2FTimelineArchiverV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YxL1RpbWVsaW5lQXJjaGl2ZXJWMS5qYXZh) | 80.95% | [3 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18380?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18380 +/- ## - Coverage 68.36% 65.96% -2.41% + Complexity2756626988 -578 Files 2432 2460 +28 Lines133175 135290+2115 Branches 1602316399 +376 - Hits 9104789244-1803 - Misses3506838602+3534 - Partials 7060 7444 +384 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.59% <40.00%> (+0.27%)` | :arrow_up: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.86% <23.33%> (-0.29%)` | :arrow_down: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.61% <86.66%> (+0.04%)` | :arrow_up: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.38% <23.33%> (-16.33%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.96% <23.33%> (-0.43%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.23% <40.00%> (-0.30%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18380?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...a/org/apache/hudi/config/HoodieArchivalConfig
Re: [PR] feat: Adding support to block archival on last known ECTR for v6 tables [hudi]
codecov-commenter commented on PR #18380: URL: https://github.com/apache/hudi/pull/18380#issuecomment-4257149337 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18380?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `86.7%` with `4 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 61.38%. Comparing base ([`2f07364`](https://app.codecov.io/gh/apache/hudi/commit/2f073643dfe764d34fee5a139d95633df01d9292?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`c33f510`](https://app.codecov.io/gh/apache/hudi/commit/c33f5100a0a238b77c5674383170d6ac54ad9c80?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 60 commits behind head on master. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18380?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...ent/timeline/versioning/v1/TimelineArchiverV1.java](https://app.codecov.io/gh/apache/hudi/pull/18380?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv1%2FTimelineArchiverV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YxL1RpbWVsaW5lQXJjaGl2ZXJWMS5qYXZh) | 80.95% | [3 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18380?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | > :exclamation: There is a different number of reports uploaded between BASE (2f07364) and HEAD (c33f510). Click for more details. > > HEAD has 15 uploads less than BASE > >| Flag | BASE (2f07364) | HEAD (c33f510) | >|--|--|--| >|spark-scala-tests|10|5| >|spark-java-tests|15|5| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18380 +/- ## - Coverage 68.36% 61.38% -6.99% + Complexity2756625108-2458 Files 2432 2460 +28 Lines133175 135290+2115 Branches 1602316399 +376 - Hits 9104783048-7999 - Misses3506845259 +10191 + Partials 7060 6983 -77 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.59% <40.00%> (+0.27%)` | :arrow_up: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.86% <23.33%> (-0.29%)` | :arrow_down: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.61% <86.66%> (+0.04%)` | :arrow_up: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.38% <23.33%> (-16.33%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.57% <20.00%> (-12.82%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.23% <40.00%> (-0.30%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to
Re: [PR] feat: Adding support to block archival on last known ECTR for v6 tables [hudi]
codecov-commenter commented on PR #18380: URL: https://github.com/apache/hudi/pull/18380#issuecomment-4257147401 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18380?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `86.7%` with `4 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 61.38%. Comparing base ([`2f07364`](https://app.codecov.io/gh/apache/hudi/commit/2f073643dfe764d34fee5a139d95633df01d9292?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`c33f510`](https://app.codecov.io/gh/apache/hudi/commit/c33f5100a0a238b77c5674383170d6ac54ad9c80?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 60 commits behind head on master. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18380?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...ent/timeline/versioning/v1/TimelineArchiverV1.java](https://app.codecov.io/gh/apache/hudi/pull/18380?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv1%2FTimelineArchiverV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YxL1RpbWVsaW5lQXJjaGl2ZXJWMS5qYXZh) | 80.95% | [3 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18380?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | > :exclamation: There is a different number of reports uploaded between BASE (2f07364) and HEAD (c33f510). Click for more details. > > HEAD has 16 uploads less than BASE > >| Flag | BASE (2f07364) | HEAD (c33f510) | >|--|--|--| >|spark-scala-tests|10|5| >|spark-java-tests|15|4| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18380 +/- ## - Coverage 68.36% 61.38% -6.99% + Complexity2756625108-2458 Files 2432 2460 +28 Lines133175 135290+2115 Branches 1602316399 +376 - Hits 9104783048-7999 - Misses3506845259 +10191 + Partials 7060 6983 -77 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.59% <40.00%> (+0.27%)` | :arrow_up: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.86% <23.33%> (-0.29%)` | :arrow_down: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.61% <86.66%> (+0.04%)` | :arrow_up: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.38% <23.33%> (-16.33%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.57% <20.00%> (-12.82%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.23% <40.00%> (-0.30%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to
Re: [PR] feat: Adding support to block archival on last known ECTR for v6 tables [hudi]
codecov-commenter commented on PR #18380: URL: https://github.com/apache/hudi/pull/18380#issuecomment-4257143837 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18380?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `86.7%` with `4 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 58.88%. Comparing base ([`2f07364`](https://app.codecov.io/gh/apache/hudi/commit/2f073643dfe764d34fee5a139d95633df01d9292?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`c33f510`](https://app.codecov.io/gh/apache/hudi/commit/c33f5100a0a238b77c5674383170d6ac54ad9c80?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 60 commits behind head on master. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18380?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...ent/timeline/versioning/v1/TimelineArchiverV1.java](https://app.codecov.io/gh/apache/hudi/pull/18380?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv1%2FTimelineArchiverV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YxL1RpbWVsaW5lQXJjaGl2ZXJWMS5qYXZh) | 80.95% | [3 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18380?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | > :exclamation: There is a different number of reports uploaded between BASE (2f07364) and HEAD (c33f510). Click for more details. > > HEAD has 17 uploads less than BASE > >| Flag | BASE (2f07364) | HEAD (c33f510) | >|--|--|--| >|spark-scala-tests|10|5| >|spark-java-tests|15|4| >|utilities|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18380 +/- ## - Coverage 68.36% 58.88% -9.48% + Complexity2756624146-3420 Files 2432 2460 +28 Lines133175 135290+2115 Branches 1602316399 +376 - Hits 9104779670 -11377 - Misses3506848790 +13722 + Partials 7060 6830 -230 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.59% <40.00%> (+0.27%)` | :arrow_up: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.86% <23.33%> (-0.29%)` | :arrow_down: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.61% <86.66%> (+0.04%)` | :arrow_up: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.38% <23.33%> (-16.33%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.57% <20.00%> (-12.82%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
Re: [PR] feat: Adding support to block archival on last known ECTR for v6 tables [hudi]
codecov-commenter commented on PR #18380: URL: https://github.com/apache/hudi/pull/18380#issuecomment-4257141911 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18380?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `86.7%` with `4 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 58.86%. Comparing base ([`2f07364`](https://app.codecov.io/gh/apache/hudi/commit/2f073643dfe764d34fee5a139d95633df01d9292?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`c33f510`](https://app.codecov.io/gh/apache/hudi/commit/c33f5100a0a238b77c5674383170d6ac54ad9c80?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 60 commits behind head on master. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18380?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...ent/timeline/versioning/v1/TimelineArchiverV1.java](https://app.codecov.io/gh/apache/hudi/pull/18380?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv1%2FTimelineArchiverV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YxL1RpbWVsaW5lQXJjaGl2ZXJWMS5qYXZh) | 80.95% | [3 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18380?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | > :exclamation: There is a different number of reports uploaded between BASE (2f07364) and HEAD (c33f510). Click for more details. > > HEAD has 18 uploads less than BASE > >| Flag | BASE (2f07364) | HEAD (c33f510) | >|--|--|--| >|spark-scala-tests|10|5| >|spark-java-tests|15|3| >|utilities|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18380 +/- ## - Coverage 68.36% 58.86% -9.51% + Complexity2756624136-3430 Files 2432 2460 +28 Lines133175 135290+2115 Branches 1602316399 +376 - Hits 9104779636 -11411 - Misses3506848819 +13751 + Partials 7060 6835 -225 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.59% <40.00%> (+0.27%)` | :arrow_up: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.86% <23.33%> (-0.29%)` | :arrow_down: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.61% <86.66%> (+0.04%)` | :arrow_up: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.80% <23.33%> (-15.90%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.57% <20.00%> (-12.82%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
Re: [PR] feat: Adding support to block archival on last known ECTR for v6 tables [hudi]
codecov-commenter commented on PR #18380: URL: https://github.com/apache/hudi/pull/18380#issuecomment-4257140418 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18380?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `86.7%` with `4 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 48.14%. Comparing base ([`2f07364`](https://app.codecov.io/gh/apache/hudi/commit/2f073643dfe764d34fee5a139d95633df01d9292?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`c33f510`](https://app.codecov.io/gh/apache/hudi/commit/c33f5100a0a238b77c5674383170d6ac54ad9c80?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 60 commits behind head on master. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18380?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...ent/timeline/versioning/v1/TimelineArchiverV1.java](https://app.codecov.io/gh/apache/hudi/pull/18380?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv1%2FTimelineArchiverV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YxL1RpbWVsaW5lQXJjaGl2ZXJWMS5qYXZh) | 80.95% | [3 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18380?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | > :exclamation: There is a different number of reports uploaded between BASE (2f07364) and HEAD (c33f510). Click for more details. > > HEAD has 19 uploads less than BASE > >| Flag | BASE (2f07364) | HEAD (c33f510) | >|--|--|--| >|spark-scala-tests|10|5| >|spark-java-tests|15|3| >|common-and-other-modules|1|0| >|utilities|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18380 +/- ## = - Coverage 68.36% 48.14% -20.23% + Complexity2756616505-11061 = Files 2432 2004 -428 Lines133175 112266-20909 Branches 1602314257 -1766 = - Hits 9104754047-37000 - Misses3506852558+17490 + Partials 7060 5661 -1399 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.86% <23.33%> (-0.29%)` | :arrow_down: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.61% <86.66%> (+0.04%)` | :arrow_up: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.80% <23.33%> (-15.90%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.57% <20.00%> (-12.82%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to fi
Re: [PR] feat: Adding support to block archival on last known ECTR for v6 tables [hudi]
codecov-commenter commented on PR #18380: URL: https://github.com/apache/hudi/pull/18380#issuecomment-4257138461 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18380?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `86.7%` with `4 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 48.10%. Comparing base ([`2f07364`](https://app.codecov.io/gh/apache/hudi/commit/2f073643dfe764d34fee5a139d95633df01d9292?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`c33f510`](https://app.codecov.io/gh/apache/hudi/commit/c33f5100a0a238b77c5674383170d6ac54ad9c80?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 60 commits behind head on master. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18380?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...ent/timeline/versioning/v1/TimelineArchiverV1.java](https://app.codecov.io/gh/apache/hudi/pull/18380?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv1%2FTimelineArchiverV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YxL1RpbWVsaW5lQXJjaGl2ZXJWMS5qYXZh) | 80.95% | [3 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18380?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | > :exclamation: There is a different number of reports uploaded between BASE (2f07364) and HEAD (c33f510). Click for more details. > > HEAD has 20 uploads less than BASE > >| Flag | BASE (2f07364) | HEAD (c33f510) | >|--|--|--| >|spark-scala-tests|10|5| >|spark-java-tests|15|2| >|common-and-other-modules|1|0| >|utilities|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18380 +/- ## = - Coverage 68.36% 48.10% -20.27% + Complexity2756616494-11072 = Files 2432 2004 -428 Lines133175 112266-20909 Branches 1602314257 -1766 = - Hits 9104754004-37043 - Misses3506852591+17523 + Partials 7060 5671 -1389 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.86% <23.33%> (-0.29%)` | :arrow_down: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.61% <86.66%> (+0.04%)` | :arrow_up: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.17% <23.33%> (-15.53%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.57% <20.00%> (-12.82%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to fi
Re: [PR] feat: Adding support to block archival on last known ECTR for v6 tables [hudi]
codecov-commenter commented on PR #18380: URL: https://github.com/apache/hudi/pull/18380#issuecomment-4257135352 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18380?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `86.7%` with `4 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 48.05%. Comparing base ([`2f07364`](https://app.codecov.io/gh/apache/hudi/commit/2f073643dfe764d34fee5a139d95633df01d9292?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`c33f510`](https://app.codecov.io/gh/apache/hudi/commit/c33f5100a0a238b77c5674383170d6ac54ad9c80?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 60 commits behind head on master. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18380?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...ent/timeline/versioning/v1/TimelineArchiverV1.java](https://app.codecov.io/gh/apache/hudi/pull/18380?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv1%2FTimelineArchiverV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YxL1RpbWVsaW5lQXJjaGl2ZXJWMS5qYXZh) | 80.95% | [3 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18380?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | > :exclamation: There is a different number of reports uploaded between BASE (2f07364) and HEAD (c33f510). Click for more details. > > HEAD has 21 uploads less than BASE > >| Flag | BASE (2f07364) | HEAD (c33f510) | >|--|--|--| >|spark-scala-tests|10|5| >|spark-java-tests|15|1| >|common-and-other-modules|1|0| >|utilities|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18380 +/- ## = - Coverage 68.36% 48.05% -20.32% + Complexity2756616474-11092 = Files 2432 2004 -428 Lines133175 112266-20909 Branches 1602314257 -1766 = - Hits 9104753947-37100 - Misses3506852641+17573 + Partials 7060 5678 -1382 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.86% <23.33%> (-0.29%)` | :arrow_down: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.61% <86.66%> (+0.04%)` | :arrow_up: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.55% <23.33%> (-15.15%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.57% <20.00%> (-12.82%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to fi
Re: [PR] feat: Adding support to block archival on last known ECTR for v6 tables [hudi]
codecov-commenter commented on PR #18380: URL: https://github.com/apache/hudi/pull/18380#issuecomment-4257131459 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18380?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `86.7%` with `4 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 48.58%. Comparing base ([`2f07364`](https://app.codecov.io/gh/apache/hudi/commit/2f073643dfe764d34fee5a139d95633df01d9292?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`c33f510`](https://app.codecov.io/gh/apache/hudi/commit/c33f5100a0a238b77c5674383170d6ac54ad9c80?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 60 commits behind head on master. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18380?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...ent/timeline/versioning/v1/TimelineArchiverV1.java](https://app.codecov.io/gh/apache/hudi/pull/18380?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv1%2FTimelineArchiverV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YxL1RpbWVsaW5lQXJjaGl2ZXJWMS5qYXZh) | 80.95% | [3 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18380?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | > :exclamation: There is a different number of reports uploaded between BASE (2f07364) and HEAD (c33f510). Click for more details. > > HEAD has 22 uploads less than BASE > >| Flag | BASE (2f07364) | HEAD (c33f510) | >|--|--|--| >|spark-scala-tests|10|4| >|spark-java-tests|15|1| >|common-and-other-modules|1|0| >|utilities|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18380 +/- ## = - Coverage 68.36% 48.58% -19.79% + Complexity2756616262-11304 = Files 2432 1975 -457 Lines133175 109663-23512 Branches 1602313703 -2320 = - Hits 9104753281-37766 - Misses3506850869+15801 + Partials 7060 5513 -1547 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.86% <23.33%> (-0.29%)` | :arrow_down: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.61% <86.66%> (+0.04%)` | :arrow_up: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.55% <23.33%> (-15.15%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.70% <20.00%> (-12.69%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to fi
Re: [PR] feat: Adding support to block archival on last known ECTR for v6 tables [hudi]
codecov-commenter commented on PR #18380: URL: https://github.com/apache/hudi/pull/18380#issuecomment-4257128024 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18380?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `86.7%` with `4 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 45.76%. Comparing base ([`2f07364`](https://app.codecov.io/gh/apache/hudi/commit/2f073643dfe764d34fee5a139d95633df01d9292?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`c33f510`](https://app.codecov.io/gh/apache/hudi/commit/c33f5100a0a238b77c5674383170d6ac54ad9c80?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 60 commits behind head on master. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18380?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...ent/timeline/versioning/v1/TimelineArchiverV1.java](https://app.codecov.io/gh/apache/hudi/pull/18380?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv1%2FTimelineArchiverV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YxL1RpbWVsaW5lQXJjaGl2ZXJWMS5qYXZh) | 80.95% | [3 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18380?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | > :exclamation: There is a different number of reports uploaded between BASE (2f07364) and HEAD (c33f510). Click for more details. > > HEAD has 23 uploads less than BASE > >| Flag | BASE (2f07364) | HEAD (c33f510) | >|--|--|--| >|spark-scala-tests|10|4| >|spark-java-tests|15|0| >|common-and-other-modules|1|0| >|utilities|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18380 +/- ## = - Coverage 68.36% 45.76% -22.60% + Complexity2756615360-12206 = Files 2432 1975 -457 Lines133175 109663-23512 Branches 1602313703 -2320 = - Hits 9104750191-40856 - Misses3506854171+19103 + Partials 7060 5301 -1759 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.86% <23.33%> (-0.29%)` | :arrow_down: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.61% <86.66%> (+0.04%)` | :arrow_up: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.70% <20.00%> (-12.69%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with mis
Re: [PR] feat: Adding support to block archival on last known ECTR for v6 tables [hudi]
codecov-commenter commented on PR #18380: URL: https://github.com/apache/hudi/pull/18380#issuecomment-4257126966 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18380?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `86.7%` with `4 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 45.76%. Comparing base ([`2f07364`](https://app.codecov.io/gh/apache/hudi/commit/2f073643dfe764d34fee5a139d95633df01d9292?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`c33f510`](https://app.codecov.io/gh/apache/hudi/commit/c33f5100a0a238b77c5674383170d6ac54ad9c80?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 60 commits behind head on master. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18380?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...ent/timeline/versioning/v1/TimelineArchiverV1.java](https://app.codecov.io/gh/apache/hudi/pull/18380?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv1%2FTimelineArchiverV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YxL1RpbWVsaW5lQXJjaGl2ZXJWMS5qYXZh) | 80.95% | [3 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18380?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | > :exclamation: There is a different number of reports uploaded between BASE (2f07364) and HEAD (c33f510). Click for more details. > > HEAD has 23 uploads less than BASE > >| Flag | BASE (2f07364) | HEAD (c33f510) | >|--|--|--| >|spark-scala-tests|10|4| >|spark-java-tests|15|0| >|common-and-other-modules|1|0| >|utilities|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18380 +/- ## = - Coverage 68.36% 45.76% -22.60% + Complexity2756615360-12206 = Files 2432 1975 -457 Lines133175 109663-23512 Branches 1602313703 -2320 = - Hits 9104750191-40856 - Misses3506854171+19103 + Partials 7060 5301 -1759 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.86% <23.33%> (-0.29%)` | :arrow_down: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.61% <86.66%> (+0.04%)` | :arrow_up: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.70% <20.00%> (-12.69%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with mis
Re: [PR] feat: Adding support to block archival on last known ECTR for v6 tables [hudi]
codecov-commenter commented on PR #18380: URL: https://github.com/apache/hudi/pull/18380#issuecomment-4257121877 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18380?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `86.7%` with `4 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 46.31%. Comparing base ([`2f07364`](https://app.codecov.io/gh/apache/hudi/commit/2f073643dfe764d34fee5a139d95633df01d9292?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`c33f510`](https://app.codecov.io/gh/apache/hudi/commit/c33f5100a0a238b77c5674383170d6ac54ad9c80?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 60 commits behind head on master. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18380?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...ent/timeline/versioning/v1/TimelineArchiverV1.java](https://app.codecov.io/gh/apache/hudi/pull/18380?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv1%2FTimelineArchiverV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YxL1RpbWVsaW5lQXJjaGl2ZXJWMS5qYXZh) | 80.95% | [3 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18380?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | > :exclamation: There is a different number of reports uploaded between BASE (2f07364) and HEAD (c33f510). Click for more details. > > HEAD has 25 uploads less than BASE > >| Flag | BASE (2f07364) | HEAD (c33f510) | >|--|--|--| >|spark-scala-tests|10|2| >|spark-java-tests|15|0| >|common-and-other-modules|1|0| >|utilities|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18380 +/- ## = - Coverage 68.36% 46.31% -22.06% + Complexity2756615199-12367 = Files 2432 1958 -474 Lines133175 107313-25862 Branches 1602313195 -2828 = - Hits 9104749703-41344 - Misses3506852450+17382 + Partials 7060 5160 -1900 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.86% <23.33%> (-0.29%)` | :arrow_down: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.61% <86.66%> (+0.04%)` | :arrow_up: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.96% <20.00%> (-12.43%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with mis
Re: [PR] feat: Adding support to block archival on last known ECTR for v6 tables [hudi]
codecov-commenter commented on PR #18380: URL: https://github.com/apache/hudi/pull/18380#issuecomment-4257121444 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18380?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `86.7%` with `4 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 46.79%. Comparing base ([`2f07364`](https://app.codecov.io/gh/apache/hudi/commit/2f073643dfe764d34fee5a139d95633df01d9292?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`c33f510`](https://app.codecov.io/gh/apache/hudi/commit/c33f5100a0a238b77c5674383170d6ac54ad9c80?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 60 commits behind head on master. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18380?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...ent/timeline/versioning/v1/TimelineArchiverV1.java](https://app.codecov.io/gh/apache/hudi/pull/18380?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv1%2FTimelineArchiverV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YxL1RpbWVsaW5lQXJjaGl2ZXJWMS5qYXZh) | 80.95% | [3 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18380?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | > :exclamation: There is a different number of reports uploaded between BASE (2f07364) and HEAD (c33f510). Click for more details. > > HEAD has 26 uploads less than BASE > >| Flag | BASE (2f07364) | HEAD (c33f510) | >|--|--|--| >|spark-scala-tests|10|1| >|spark-java-tests|15|0| >|common-and-other-modules|1|0| >|utilities|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18380 +/- ## = - Coverage 68.36% 46.79% -21.57% + Complexity2756615036-12530 = Files 2432 1940 -492 Lines133175 104808-28367 Branches 1602312634 -3389 = - Hits 9104749050-41997 - Misses3506850720+15652 + Partials 7060 5038 -2022 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.86% <23.33%> (-0.29%)` | :arrow_down: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.61% <86.66%> (+0.04%)` | :arrow_up: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.11% <20.00%> (-12.28%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with mis
Re: [PR] feat: Adding support to block archival on last known ECTR for v6 tables [hudi]
codecov-commenter commented on PR #18380: URL: https://github.com/apache/hudi/pull/18380#issuecomment-4257112374 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18380?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `86.7%` with `4 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 54.10%. Comparing base ([`2f07364`](https://app.codecov.io/gh/apache/hudi/commit/2f073643dfe764d34fee5a139d95633df01d9292?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`c33f510`](https://app.codecov.io/gh/apache/hudi/commit/c33f5100a0a238b77c5674383170d6ac54ad9c80?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 60 commits behind head on master. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18380?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...ent/timeline/versioning/v1/TimelineArchiverV1.java](https://app.codecov.io/gh/apache/hudi/pull/18380?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv1%2FTimelineArchiverV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YxL1RpbWVsaW5lQXJjaGl2ZXJWMS5qYXZh) | 80.95% | [3 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18380?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | > :exclamation: There is a different number of reports uploaded between BASE (2f07364) and HEAD (c33f510). Click for more details. > > HEAD has 27 uploads less than BASE > >| Flag | BASE (2f07364) | HEAD (c33f510) | >|--|--|--| >|spark-scala-tests|10|0| >|spark-java-tests|15|0| >|common-and-other-modules|1|0| >|utilities|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18380 +/- ## = - Coverage 68.36% 54.10% -14.27% + Complexity2756612321-15245 = Files 2432 1425 -1007 Lines13317571059-62116 Branches 16023 8020 -8003 = - Hits 9104738443-52604 + Misses3506829177 -5891 + Partials 7060 3439 -3621 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.86% <23.33%> (-0.29%)` | :arrow_down: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.61% <86.66%> (+0.04%)` | :arrow_up: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/g
Re: [PR] feat: Adding support to block archival on last known ECTR for v6 tables [hudi]
codecov-commenter commented on PR #18380: URL: https://github.com/apache/hudi/pull/18380#issuecomment-4257039994 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18380?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `23.3%` with `23 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 44.86%. Comparing base ([`2f07364`](https://app.codecov.io/gh/apache/hudi/commit/2f073643dfe764d34fee5a139d95633df01d9292?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`c33f510`](https://app.codecov.io/gh/apache/hudi/commit/c33f5100a0a238b77c5674383170d6ac54ad9c80?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 60 commits behind head on master. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18380?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...ent/timeline/versioning/v1/TimelineArchiverV1.java](https://app.codecov.io/gh/apache/hudi/pull/18380?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv1%2FTimelineArchiverV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YxL1RpbWVsaW5lQXJjaGl2ZXJWMS5qYXZh) | 0.00% | [21 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18380?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...a/org/apache/hudi/config/HoodieArchivalConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18380?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2FHoodieArchivalConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVBcmNoaXZhbENvbmZpZy5qYXZh) | 75.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18380?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | > :exclamation: There is a different number of reports uploaded between BASE (2f07364) and HEAD (c33f510). Click for more details. > > HEAD has 28 uploads less than BASE > >| Flag | BASE (2f07364) | HEAD (c33f510) | >|--|--|--| >|spark-client-hadoop-common|1|0| >|spark-scala-tests|10|0| >|spark-java-tests|15|0| >|common-and-other-modules|1|0| >|utilities|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18380 +/- ## = - Coverage 68.36% 44.86% -23.51% + Complexity27566 8492-19074 = Files 2432 1196 -1236 Lines13317562071-71104 Branches 16023 6687 -9336 = - Hits 9104727847-63200 + Misses3506831185 -3883 + Partials 7060 3039 -4021 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.86% <23.33%> (-0.29%)` | :arrow_down: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src
Re: [PR] feat: Adding support to block archival on last known ECTR for v6 tables [hudi]
hudi-bot commented on PR #18380: URL: https://github.com/apache/hudi/pull/18380#issuecomment-4257008655 ## CI report: * 112973acbb3cb2969f8f4e335bd605ee4070a4ea Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13204) * c33f5100a0a238b77c5674383170d6ac54ad9c80 Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13294) Bot commands @hudi-bot supports the following commands: - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] feat: Adding support to block archival on last known ECTR for v6 tables [hudi]
nsivabalan commented on code in PR #18380:
URL: https://github.com/apache/hudi/pull/18380#discussion_r3090465309
##
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/timeline/versioning/v1/TimelineArchiverV1.java:
##
@@ -297,6 +322,10 @@ private Stream getCommitInstantsToArchive()
throws IOException {
oldestInstantToRetainForClustering.map(instantToRetain ->
compareTimestamps(s.requestedTime(), LESSER_THAN,
instantToRetain.requestedTime()))
.orElse(true)
+ ).filter(s ->
Review Comment:
The filter chain in this method is already readable with each concern as a
separate .filter() block, and extracting a helper for a 3-line lambda that's
used twice adds indirection without much gain.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] feat: Adding support to block archival on last known ECTR for v6 tables [hudi]
hudi-bot commented on PR #18380: URL: https://github.com/apache/hudi/pull/18380#issuecomment-4256997443 ## CI report: * 112973acbb3cb2969f8f4e335bd605ee4070a4ea Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13204) * c33f5100a0a238b77c5674383170d6ac54ad9c80 UNKNOWN Bot commands @hudi-bot supports the following commands: - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] feat: Adding support to block archival on last known ECTR for v6 tables [hudi]
hudi-bot commented on PR #18380: URL: https://github.com/apache/hudi/pull/18380#issuecomment-4225652614 ## CI report: * 112973acbb3cb2969f8f4e335bd605ee4070a4ea Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13204) Bot commands @hudi-bot supports the following commands: - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] feat: Adding support to block archival on last known ECTR for v6 tables [hudi]
codecov-commenter commented on PR #18380: URL: https://github.com/apache/hudi/pull/18380#issuecomment-4225549479 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18380?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `86.7%` with `4 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 68.82%. Comparing base ([`2f07364`](https://app.codecov.io/gh/apache/hudi/commit/2f073643dfe764d34fee5a139d95633df01d9292?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`112973a`](https://app.codecov.io/gh/apache/hudi/commit/112973acbb3cb2969f8f4e335bd605ee4070a4ea?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 49 commits behind head on master. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18380?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...ent/timeline/versioning/v1/TimelineArchiverV1.java](https://app.codecov.io/gh/apache/hudi/pull/18380?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv1%2FTimelineArchiverV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YxL1RpbWVsaW5lQXJjaGl2ZXJWMS5qYXZh) | 80.95% | [3 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18380?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18380 +/- ## + Coverage 68.36% 68.82% +0.46% - Complexity2756628173 +607 Files 2432 2459 +27 Lines133175 135125+1950 Branches 1602316382 +359 + Hits 9104793006+1959 + Misses3506834752 -316 - Partials 7060 7367 +307 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.52% <40.00%> (+0.20%)` | :arrow_up: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.83% <20.00%> (-0.32%)` | :arrow_down: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.59% <86.66%> (+0.02%)` | :arrow_up: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.85% <40.00%> (+0.15%)` | :arrow_up: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.48% <20.00%> (+0.09%)` | :arrow_up: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.23% <40.00%> (-0.30%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18380?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...a/org/apache/hudi/config/HoodieArchivalConfig.java
Re: [PR] feat: Adding support to block archival on last known ECTR for v6 tables [hudi]
codecov-commenter commented on PR #18380: URL: https://github.com/apache/hudi/pull/18380#issuecomment-4225534278 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18380?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `86.7%` with `4 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 68.82%. Comparing base ([`2f07364`](https://app.codecov.io/gh/apache/hudi/commit/2f073643dfe764d34fee5a139d95633df01d9292?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`112973a`](https://app.codecov.io/gh/apache/hudi/commit/112973acbb3cb2969f8f4e335bd605ee4070a4ea?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 49 commits behind head on master. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18380?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...ent/timeline/versioning/v1/TimelineArchiverV1.java](https://app.codecov.io/gh/apache/hudi/pull/18380?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv1%2FTimelineArchiverV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YxL1RpbWVsaW5lQXJjaGl2ZXJWMS5qYXZh) | 80.95% | [3 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18380?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18380 +/- ## + Coverage 68.36% 68.82% +0.46% - Complexity2756628172 +606 Files 2432 2459 +27 Lines133175 135125+1950 Branches 1602316382 +359 + Hits 9104793003+1956 + Misses3506834754 -314 - Partials 7060 7368 +308 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.52% <40.00%> (+0.20%)` | :arrow_up: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.83% <20.00%> (-0.32%)` | :arrow_down: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.59% <86.66%> (+0.02%)` | :arrow_up: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.81% <40.00%> (+0.10%)` | :arrow_up: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.48% <20.00%> (+0.09%)` | :arrow_up: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.23% <40.00%> (-0.30%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18380?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...a/org/apache/hudi/config/HoodieArchivalConfig.java
Re: [PR] feat: Adding support to block archival on last known ECTR for v6 tables [hudi]
codecov-commenter commented on PR #18380: URL: https://github.com/apache/hudi/pull/18380#issuecomment-4225533395 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18380?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `86.7%` with `4 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 68.82%. Comparing base ([`2f07364`](https://app.codecov.io/gh/apache/hudi/commit/2f073643dfe764d34fee5a139d95633df01d9292?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`112973a`](https://app.codecov.io/gh/apache/hudi/commit/112973acbb3cb2969f8f4e335bd605ee4070a4ea?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 49 commits behind head on master. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18380?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...ent/timeline/versioning/v1/TimelineArchiverV1.java](https://app.codecov.io/gh/apache/hudi/pull/18380?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv1%2FTimelineArchiverV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YxL1RpbWVsaW5lQXJjaGl2ZXJWMS5qYXZh) | 80.95% | [3 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18380?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18380 +/- ## + Coverage 68.36% 68.82% +0.46% - Complexity2756628172 +606 Files 2432 2459 +27 Lines133175 135125+1950 Branches 1602316382 +359 + Hits 9104793003+1956 + Misses3506834754 -314 - Partials 7060 7368 +308 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.52% <40.00%> (+0.20%)` | :arrow_up: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.83% <20.00%> (-0.32%)` | :arrow_down: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.59% <86.66%> (+0.02%)` | :arrow_up: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.81% <40.00%> (+0.10%)` | :arrow_up: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.48% <20.00%> (+0.09%)` | :arrow_up: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.23% <40.00%> (-0.30%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18380?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...a/org/apache/hudi/config/HoodieArchivalConfig.java
Re: [PR] feat: Adding support to block archival on last known ECTR for v6 tables [hudi]
codecov-commenter commented on PR #18380: URL: https://github.com/apache/hudi/pull/18380#issuecomment-4225545632 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18380?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `86.7%` with `4 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 68.82%. Comparing base ([`2f07364`](https://app.codecov.io/gh/apache/hudi/commit/2f073643dfe764d34fee5a139d95633df01d9292?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`112973a`](https://app.codecov.io/gh/apache/hudi/commit/112973acbb3cb2969f8f4e335bd605ee4070a4ea?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 49 commits behind head on master. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18380?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...ent/timeline/versioning/v1/TimelineArchiverV1.java](https://app.codecov.io/gh/apache/hudi/pull/18380?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv1%2FTimelineArchiverV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YxL1RpbWVsaW5lQXJjaGl2ZXJWMS5qYXZh) | 80.95% | [3 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18380?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18380 +/- ## + Coverage 68.36% 68.82% +0.46% - Complexity2756628173 +607 Files 2432 2459 +27 Lines133175 135125+1950 Branches 1602316382 +359 + Hits 9104793006+1959 + Misses3506834752 -316 - Partials 7060 7367 +307 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.52% <40.00%> (+0.20%)` | :arrow_up: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.83% <20.00%> (-0.32%)` | :arrow_down: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.59% <86.66%> (+0.02%)` | :arrow_up: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.84% <40.00%> (+0.14%)` | :arrow_up: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.48% <20.00%> (+0.09%)` | :arrow_up: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.23% <40.00%> (-0.30%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18380?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...a/org/apache/hudi/config/HoodieArchivalConfig.java
Re: [PR] feat: Adding support to block archival on last known ECTR for v6 tables [hudi]
codecov-commenter commented on PR #18380: URL: https://github.com/apache/hudi/pull/18380#issuecomment-4225516036 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18380?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `86.7%` with `4 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 68.05%. Comparing base ([`2f07364`](https://app.codecov.io/gh/apache/hudi/commit/2f073643dfe764d34fee5a139d95633df01d9292?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`112973a`](https://app.codecov.io/gh/apache/hudi/commit/112973acbb3cb2969f8f4e335bd605ee4070a4ea?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 49 commits behind head on master. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18380?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...ent/timeline/versioning/v1/TimelineArchiverV1.java](https://app.codecov.io/gh/apache/hudi/pull/18380?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv1%2FTimelineArchiverV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YxL1RpbWVsaW5lQXJjaGl2ZXJWMS5qYXZh) | 80.95% | [3 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18380?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18380 +/- ## - Coverage 68.36% 68.05% -0.32% - Complexity2756627868 +302 Files 2432 2459 +27 Lines133175 135125+1950 Branches 1602316382 +359 + Hits 9104791953 +906 - Misses3506835746 +678 - Partials 7060 7426 +366 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.52% <40.00%> (+0.20%)` | :arrow_up: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.83% <20.00%> (-0.32%)` | :arrow_down: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.59% <86.66%> (+0.02%)` | :arrow_up: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.29% <40.00%> (-3.42%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.48% <20.00%> (+0.09%)` | :arrow_up: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.23% <40.00%> (-0.30%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18380?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...a/org/apache/hudi/config/HoodieArchivalConfig.ja
Re: [PR] feat: Adding support to block archival on last known ECTR for v6 tables [hudi]
codecov-commenter commented on PR #18380: URL: https://github.com/apache/hudi/pull/18380#issuecomment-4225511576 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18380?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `86.7%` with `4 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 67.98%. Comparing base ([`2f07364`](https://app.codecov.io/gh/apache/hudi/commit/2f073643dfe764d34fee5a139d95633df01d9292?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`112973a`](https://app.codecov.io/gh/apache/hudi/commit/112973acbb3cb2969f8f4e335bd605ee4070a4ea?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 49 commits behind head on master. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18380?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...ent/timeline/versioning/v1/TimelineArchiverV1.java](https://app.codecov.io/gh/apache/hudi/pull/18380?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv1%2FTimelineArchiverV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YxL1RpbWVsaW5lQXJjaGl2ZXJWMS5qYXZh) | 80.95% | [3 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18380?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18380 +/- ## - Coverage 68.36% 67.98% -0.39% - Complexity2756627823 +257 Files 2432 2459 +27 Lines133175 135125+1950 Branches 1602316382 +359 + Hits 9104791862 +815 - Misses3506835822 +754 - Partials 7060 7441 +381 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.52% <40.00%> (+0.20%)` | :arrow_up: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.83% <20.00%> (-0.32%)` | :arrow_down: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.59% <86.66%> (+0.02%)` | :arrow_up: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.15% <40.00%> (-3.55%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.48% <20.00%> (+0.09%)` | :arrow_up: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.23% <40.00%> (-0.30%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18380?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...a/org/apache/hudi/config/HoodieArchivalConfig.ja
Re: [PR] feat: Adding support to block archival on last known ECTR for v6 tables [hudi]
codecov-commenter commented on PR #18380: URL: https://github.com/apache/hudi/pull/18380#issuecomment-4225508068 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18380?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `86.7%` with `4 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 67.96%. Comparing base ([`2f07364`](https://app.codecov.io/gh/apache/hudi/commit/2f073643dfe764d34fee5a139d95633df01d9292?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`112973a`](https://app.codecov.io/gh/apache/hudi/commit/112973acbb3cb2969f8f4e335bd605ee4070a4ea?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 49 commits behind head on master. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18380?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...ent/timeline/versioning/v1/TimelineArchiverV1.java](https://app.codecov.io/gh/apache/hudi/pull/18380?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv1%2FTimelineArchiverV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YxL1RpbWVsaW5lQXJjaGl2ZXJWMS5qYXZh) | 80.95% | [3 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18380?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18380 +/- ## - Coverage 68.36% 67.96% -0.41% - Complexity2756627816 +250 Files 2432 2459 +27 Lines133175 135125+1950 Branches 1602316382 +359 + Hits 9104791832 +785 - Misses3506835851 +783 - Partials 7060 7442 +382 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.52% <40.00%> (+0.20%)` | :arrow_up: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.83% <20.00%> (-0.32%)` | :arrow_down: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.59% <86.66%> (+0.02%)` | :arrow_up: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.12% <40.00%> (-3.59%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.48% <20.00%> (+0.09%)` | :arrow_up: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.23% <40.00%> (-0.30%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18380?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...a/org/apache/hudi/config/HoodieArchivalConfig.ja
Re: [PR] feat: Adding support to block archival on last known ECTR for v6 tables [hudi]
codecov-commenter commented on PR #18380: URL: https://github.com/apache/hudi/pull/18380#issuecomment-4225502655 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18380?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `86.7%` with `4 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 67.86%. Comparing base ([`2f07364`](https://app.codecov.io/gh/apache/hudi/commit/2f073643dfe764d34fee5a139d95633df01d9292?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`112973a`](https://app.codecov.io/gh/apache/hudi/commit/112973acbb3cb2969f8f4e335bd605ee4070a4ea?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 49 commits behind head on master. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18380?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...ent/timeline/versioning/v1/TimelineArchiverV1.java](https://app.codecov.io/gh/apache/hudi/pull/18380?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv1%2FTimelineArchiverV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YxL1RpbWVsaW5lQXJjaGl2ZXJWMS5qYXZh) | 80.95% | [3 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18380?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18380 +/- ## - Coverage 68.36% 67.86% -0.51% - Complexity2756627754 +188 Files 2432 2459 +27 Lines133175 135125+1950 Branches 1602316382 +359 + Hits 9104791700 +653 - Misses3506836028 +960 - Partials 7060 7397 +337 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.52% <40.00%> (+0.20%)` | :arrow_up: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.83% <20.00%> (-0.32%)` | :arrow_down: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.59% <86.66%> (+0.02%)` | :arrow_up: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.12% <40.00%> (-3.59%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.34% <20.00%> (-0.05%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.23% <40.00%> (-0.30%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18380?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...a/org/apache/hudi/config/HoodieArchivalConfig.
Re: [PR] feat: Adding support to block archival on last known ECTR for v6 tables [hudi]
codecov-commenter commented on PR #18380: URL: https://github.com/apache/hudi/pull/18380#issuecomment-4225500485 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18380?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `86.7%` with `4 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 67.86%. Comparing base ([`2f07364`](https://app.codecov.io/gh/apache/hudi/commit/2f073643dfe764d34fee5a139d95633df01d9292?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`112973a`](https://app.codecov.io/gh/apache/hudi/commit/112973acbb3cb2969f8f4e335bd605ee4070a4ea?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 49 commits behind head on master. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18380?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...ent/timeline/versioning/v1/TimelineArchiverV1.java](https://app.codecov.io/gh/apache/hudi/pull/18380?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv1%2FTimelineArchiverV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YxL1RpbWVsaW5lQXJjaGl2ZXJWMS5qYXZh) | 80.95% | [3 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18380?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18380 +/- ## - Coverage 68.36% 67.86% -0.51% - Complexity2756627754 +188 Files 2432 2459 +27 Lines133175 135125+1950 Branches 1602316382 +359 + Hits 9104791698 +651 - Misses3506836028 +960 - Partials 7060 7399 +339 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.52% <40.00%> (+0.20%)` | :arrow_up: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.83% <20.00%> (-0.32%)` | :arrow_down: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.59% <86.66%> (+0.02%)` | :arrow_up: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.12% <40.00%> (-3.59%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.34% <20.00%> (-0.06%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.23% <40.00%> (-0.30%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18380?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...a/org/apache/hudi/config/HoodieArchivalConfig.
Re: [PR] feat: Adding support to block archival on last known ECTR for v6 tables [hudi]
codecov-commenter commented on PR #18380: URL: https://github.com/apache/hudi/pull/18380#issuecomment-4225499086 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18380?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `86.7%` with `4 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 67.83%. Comparing base ([`2f07364`](https://app.codecov.io/gh/apache/hudi/commit/2f073643dfe764d34fee5a139d95633df01d9292?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`112973a`](https://app.codecov.io/gh/apache/hudi/commit/112973acbb3cb2969f8f4e335bd605ee4070a4ea?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 49 commits behind head on master. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18380?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...ent/timeline/versioning/v1/TimelineArchiverV1.java](https://app.codecov.io/gh/apache/hudi/pull/18380?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv1%2FTimelineArchiverV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YxL1RpbWVsaW5lQXJjaGl2ZXJWMS5qYXZh) | 80.95% | [3 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18380?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18380 +/- ## - Coverage 68.36% 67.83% -0.54% - Complexity2756627748 +182 Files 2432 2459 +27 Lines133175 135125+1950 Branches 1602316382 +359 + Hits 9104791663 +616 - Misses3506836054 +986 - Partials 7060 7408 +348 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.52% <40.00%> (+0.20%)` | :arrow_up: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.83% <20.00%> (-0.32%)` | :arrow_down: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.59% <86.66%> (+0.02%)` | :arrow_up: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.05% <40.00%> (-3.66%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.34% <20.00%> (-0.06%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.23% <40.00%> (-0.30%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18380?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...a/org/apache/hudi/config/HoodieArchivalConfig.
Re: [PR] feat: Adding support to block archival on last known ECTR for v6 tables [hudi]
codecov-commenter commented on PR #18380: URL: https://github.com/apache/hudi/pull/18380#issuecomment-4225494396 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18380?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `86.7%` with `4 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 66.20%. Comparing base ([`2f07364`](https://app.codecov.io/gh/apache/hudi/commit/2f073643dfe764d34fee5a139d95633df01d9292?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`112973a`](https://app.codecov.io/gh/apache/hudi/commit/112973acbb3cb2969f8f4e335bd605ee4070a4ea?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 49 commits behind head on master. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18380?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...ent/timeline/versioning/v1/TimelineArchiverV1.java](https://app.codecov.io/gh/apache/hudi/pull/18380?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv1%2FTimelineArchiverV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YxL1RpbWVsaW5lQXJjaGl2ZXJWMS5qYXZh) | 80.95% | [3 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18380?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18380 +/- ## - Coverage 68.36% 66.20% -2.16% + Complexity2756627074 -492 Files 2432 2459 +27 Lines133175 135125+1950 Branches 1602316382 +359 - Hits 9104789465-1582 - Misses3506838159+3091 - Partials 7060 7501 +441 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.52% <40.00%> (+0.20%)` | :arrow_up: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.83% <20.00%> (-0.32%)` | :arrow_down: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.59% <86.66%> (+0.02%)` | :arrow_up: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.41% <20.00%> (-16.30%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.34% <20.00%> (-0.06%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.23% <40.00%> (-0.30%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18380?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...a/org/apache/hudi/config/HoodieArchivalConfig
Re: [PR] feat: Adding support to block archival on last known ECTR for v6 tables [hudi]
codecov-commenter commented on PR #18380: URL: https://github.com/apache/hudi/pull/18380#issuecomment-4225487052 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18380?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `86.7%` with `4 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 66.06%. Comparing base ([`2f07364`](https://app.codecov.io/gh/apache/hudi/commit/2f073643dfe764d34fee5a139d95633df01d9292?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`112973a`](https://app.codecov.io/gh/apache/hudi/commit/112973acbb3cb2969f8f4e335bd605ee4070a4ea?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 49 commits behind head on master. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18380?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...ent/timeline/versioning/v1/TimelineArchiverV1.java](https://app.codecov.io/gh/apache/hudi/pull/18380?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv1%2FTimelineArchiverV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YxL1RpbWVsaW5lQXJjaGl2ZXJWMS5qYXZh) | 80.95% | [3 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18380?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18380 +/- ## - Coverage 68.36% 66.06% -2.31% + Complexity2756627007 -559 Files 2432 2459 +27 Lines133175 135125+1950 Branches 1602316382 +359 - Hits 9104789270-1777 - Misses3506838375+3307 - Partials 7060 7480 +420 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.52% <40.00%> (+0.20%)` | :arrow_up: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.83% <20.00%> (-0.32%)` | :arrow_down: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.59% <86.66%> (+0.02%)` | :arrow_up: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.41% <20.00%> (-16.30%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.12% <20.00%> (-0.27%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.23% <40.00%> (-0.30%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18380?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...a/org/apache/hudi/config/HoodieArchivalConfig
Re: [PR] feat: Adding support to block archival on last known ECTR for v6 tables [hudi]
codecov-commenter commented on PR #18380: URL: https://github.com/apache/hudi/pull/18380#issuecomment-4225469045 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18380?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `86.7%` with `4 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 65.94%. Comparing base ([`2f07364`](https://app.codecov.io/gh/apache/hudi/commit/2f073643dfe764d34fee5a139d95633df01d9292?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`112973a`](https://app.codecov.io/gh/apache/hudi/commit/112973acbb3cb2969f8f4e335bd605ee4070a4ea?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 49 commits behind head on master. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18380?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...ent/timeline/versioning/v1/TimelineArchiverV1.java](https://app.codecov.io/gh/apache/hudi/pull/18380?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv1%2FTimelineArchiverV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YxL1RpbWVsaW5lQXJjaGl2ZXJWMS5qYXZh) | 80.95% | [3 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18380?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18380 +/- ## - Coverage 68.36% 65.94% -2.43% + Complexity2756626940 -626 Files 2432 2459 +27 Lines133175 135125+1950 Branches 1602316382 +359 - Hits 9104789110-1937 - Misses3506838582+3514 - Partials 7060 7433 +373 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.52% <40.00%> (+0.20%)` | :arrow_up: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.83% <20.00%> (-0.32%)` | :arrow_down: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.59% <86.66%> (+0.02%)` | :arrow_up: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.41% <20.00%> (-16.30%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.95% <20.00%> (-0.44%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.23% <40.00%> (-0.30%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18380?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...a/org/apache/hudi/config/HoodieArchivalConfig
Re: [PR] feat: Adding support to block archival on last known ECTR for v6 tables [hudi]
codecov-commenter commented on PR #18380: URL: https://github.com/apache/hudi/pull/18380#issuecomment-4225453734 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18380?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `86.7%` with `4 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 61.36%. Comparing base ([`2f07364`](https://app.codecov.io/gh/apache/hudi/commit/2f073643dfe764d34fee5a139d95633df01d9292?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`112973a`](https://app.codecov.io/gh/apache/hudi/commit/112973acbb3cb2969f8f4e335bd605ee4070a4ea?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 49 commits behind head on master. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18380?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...ent/timeline/versioning/v1/TimelineArchiverV1.java](https://app.codecov.io/gh/apache/hudi/pull/18380?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv1%2FTimelineArchiverV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YxL1RpbWVsaW5lQXJjaGl2ZXJWMS5qYXZh) | 80.95% | [3 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18380?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | > :exclamation: There is a different number of reports uploaded between BASE (2f07364) and HEAD (112973a). Click for more details. > > HEAD has 15 uploads less than BASE > >| Flag | BASE (2f07364) | HEAD (112973a) | >|--|--|--| >|spark-scala-tests|10|5| >|spark-java-tests|15|5| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18380 +/- ## - Coverage 68.36% 61.36% -7.01% + Complexity2756625060-2506 Files 2432 2459 +27 Lines133175 135125+1950 Branches 1602316382 +359 - Hits 9104782914-8133 - Misses3506845239 +10171 + Partials 7060 6972 -88 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.52% <40.00%> (+0.20%)` | :arrow_up: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.83% <20.00%> (-0.32%)` | :arrow_down: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.59% <86.66%> (+0.02%)` | :arrow_up: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.41% <20.00%> (-16.30%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.54% <20.00%> (-12.85%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.23% <40.00%> (-0.30%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to
Re: [PR] feat: Adding support to block archival on last known ECTR for v6 tables [hudi]
codecov-commenter commented on PR #18380: URL: https://github.com/apache/hudi/pull/18380#issuecomment-4225451765 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18380?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `86.7%` with `4 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 54.42%. Comparing base ([`2f07364`](https://app.codecov.io/gh/apache/hudi/commit/2f073643dfe764d34fee5a139d95633df01d9292?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`112973a`](https://app.codecov.io/gh/apache/hudi/commit/112973acbb3cb2969f8f4e335bd605ee4070a4ea?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 49 commits behind head on master. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18380?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...ent/timeline/versioning/v1/TimelineArchiverV1.java](https://app.codecov.io/gh/apache/hudi/pull/18380?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv1%2FTimelineArchiverV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YxL1RpbWVsaW5lQXJjaGl2ZXJWMS5qYXZh) | 80.95% | [3 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18380?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | > :exclamation: There is a different number of reports uploaded between BASE (2f07364) and HEAD (112973a). Click for more details. > > HEAD has 16 uploads less than BASE > >| Flag | BASE (2f07364) | HEAD (112973a) | >|--|--|--| >|spark-scala-tests|10|5| >|spark-java-tests|15|5| >|common-and-other-modules|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18380 +/- ## = - Coverage 68.36% 54.42% -13.95% + Complexity2756618443 -9123 = Files 2432 2004 -428 Lines133175 112148-21027 Branches 1602314241 -1782 = - Hits 9104761033-30014 - Misses3506844859 +9791 + Partials 7060 6256 -804 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.83% <20.00%> (-0.32%)` | :arrow_down: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.59% <86.66%> (+0.02%)` | :arrow_up: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.41% <20.00%> (-16.30%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.54% <20.00%> (-12.85%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.23% <40.00%> (-0.30%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request
Re: [PR] feat: Adding support to block archival on last known ECTR for v6 tables [hudi]
codecov-commenter commented on PR #18380: URL: https://github.com/apache/hudi/pull/18380#issuecomment-4225450671 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18380?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `86.7%` with `4 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 54.42%. Comparing base ([`2f07364`](https://app.codecov.io/gh/apache/hudi/commit/2f073643dfe764d34fee5a139d95633df01d9292?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`112973a`](https://app.codecov.io/gh/apache/hudi/commit/112973acbb3cb2969f8f4e335bd605ee4070a4ea?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 49 commits behind head on master. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18380?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...ent/timeline/versioning/v1/TimelineArchiverV1.java](https://app.codecov.io/gh/apache/hudi/pull/18380?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv1%2FTimelineArchiverV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YxL1RpbWVsaW5lQXJjaGl2ZXJWMS5qYXZh) | 80.95% | [3 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18380?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | > :exclamation: There is a different number of reports uploaded between BASE (2f07364) and HEAD (112973a). Click for more details. > > HEAD has 17 uploads less than BASE > >| Flag | BASE (2f07364) | HEAD (112973a) | >|--|--|--| >|spark-scala-tests|10|5| >|spark-java-tests|15|4| >|common-and-other-modules|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18380 +/- ## = - Coverage 68.36% 54.42% -13.95% + Complexity2756618443 -9123 = Files 2432 2004 -428 Lines133175 112148-21027 Branches 1602314241 -1782 = - Hits 9104761033-30014 - Misses3506844859 +9791 + Partials 7060 6256 -804 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.83% <20.00%> (-0.32%)` | :arrow_down: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.59% <86.66%> (+0.02%)` | :arrow_up: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.41% <20.00%> (-16.30%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.54% <20.00%> (-12.85%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.23% <40.00%> (-0.30%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request
Re: [PR] feat: Adding support to block archival on last known ECTR for v6 tables [hudi]
codecov-commenter commented on PR #18380: URL: https://github.com/apache/hudi/pull/18380#issuecomment-4225448769 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18380?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `86.7%` with `4 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 54.41%. Comparing base ([`2f07364`](https://app.codecov.io/gh/apache/hudi/commit/2f073643dfe764d34fee5a139d95633df01d9292?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`112973a`](https://app.codecov.io/gh/apache/hudi/commit/112973acbb3cb2969f8f4e335bd605ee4070a4ea?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 49 commits behind head on master. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18380?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...ent/timeline/versioning/v1/TimelineArchiverV1.java](https://app.codecov.io/gh/apache/hudi/pull/18380?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv1%2FTimelineArchiverV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YxL1RpbWVsaW5lQXJjaGl2ZXJWMS5qYXZh) | 80.95% | [3 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18380?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | > :exclamation: There is a different number of reports uploaded between BASE (2f07364) and HEAD (112973a). Click for more details. > > HEAD has 18 uploads less than BASE > >| Flag | BASE (2f07364) | HEAD (112973a) | >|--|--|--| >|spark-scala-tests|10|5| >|spark-java-tests|15|3| >|common-and-other-modules|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18380 +/- ## = - Coverage 68.36% 54.41% -13.96% + Complexity2756618439 -9127 = Files 2432 2004 -428 Lines133175 112148-21027 Branches 1602314241 -1782 = - Hits 9104761024-30023 - Misses3506844866 +9798 + Partials 7060 6258 -802 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.83% <20.00%> (-0.32%)` | :arrow_down: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.59% <86.66%> (+0.02%)` | :arrow_up: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.78% <20.00%> (-15.93%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.54% <20.00%> (-12.85%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.23% <40.00%> (-0.30%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request
Re: [PR] feat: Adding support to block archival on last known ECTR for v6 tables [hudi]
codecov-commenter commented on PR #18380: URL: https://github.com/apache/hudi/pull/18380#issuecomment-4225437847 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18380?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `86.7%` with `4 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 54.37%. Comparing base ([`2f07364`](https://app.codecov.io/gh/apache/hudi/commit/2f073643dfe764d34fee5a139d95633df01d9292?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`112973a`](https://app.codecov.io/gh/apache/hudi/commit/112973acbb3cb2969f8f4e335bd605ee4070a4ea?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 49 commits behind head on master. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18380?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...ent/timeline/versioning/v1/TimelineArchiverV1.java](https://app.codecov.io/gh/apache/hudi/pull/18380?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv1%2FTimelineArchiverV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YxL1RpbWVsaW5lQXJjaGl2ZXJWMS5qYXZh) | 80.95% | [3 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18380?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | > :exclamation: There is a different number of reports uploaded between BASE (2f07364) and HEAD (112973a). Click for more details. > > HEAD has 19 uploads less than BASE > >| Flag | BASE (2f07364) | HEAD (112973a) | >|--|--|--| >|spark-scala-tests|10|5| >|spark-java-tests|15|2| >|common-and-other-modules|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18380 +/- ## = - Coverage 68.36% 54.37% -13.99% + Complexity2756618428 -9138 = Files 2432 2004 -428 Lines133175 112148-21027 Branches 1602314241 -1782 = - Hits 9104760985-30062 - Misses3506844901 +9833 + Partials 7060 6262 -798 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.83% <20.00%> (-0.32%)` | :arrow_down: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.59% <86.66%> (+0.02%)` | :arrow_up: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.18% <20.00%> (-15.52%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.54% <20.00%> (-12.85%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.23% <40.00%> (-0.30%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request
Re: [PR] feat: Adding support to block archival on last known ECTR for v6 tables [hudi]
codecov-commenter commented on PR #18380: URL: https://github.com/apache/hudi/pull/18380#issuecomment-4225428540 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18380?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `86.7%` with `4 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 48.08%. Comparing base ([`2f07364`](https://app.codecov.io/gh/apache/hudi/commit/2f073643dfe764d34fee5a139d95633df01d9292?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`112973a`](https://app.codecov.io/gh/apache/hudi/commit/112973acbb3cb2969f8f4e335bd605ee4070a4ea?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 49 commits behind head on master. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18380?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...ent/timeline/versioning/v1/TimelineArchiverV1.java](https://app.codecov.io/gh/apache/hudi/pull/18380?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv1%2FTimelineArchiverV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YxL1RpbWVsaW5lQXJjaGl2ZXJWMS5qYXZh) | 80.95% | [3 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18380?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | > :exclamation: There is a different number of reports uploaded between BASE (2f07364) and HEAD (112973a). Click for more details. > > HEAD has 20 uploads less than BASE > >| Flag | BASE (2f07364) | HEAD (112973a) | >|--|--|--| >|spark-scala-tests|10|5| >|spark-java-tests|15|2| >|common-and-other-modules|1|0| >|utilities|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18380 +/- ## = - Coverage 68.36% 48.08% -20.28% + Complexity2756616474-11092 = Files 2432 2004 -428 Lines133175 112148-21027 Branches 1602314241 -1782 = - Hits 9104753931-37116 - Misses3506852563+17495 + Partials 7060 5654 -1406 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.83% <20.00%> (-0.32%)` | :arrow_down: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.59% <86.66%> (+0.02%)` | :arrow_up: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.18% <20.00%> (-15.52%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.54% <20.00%> (-12.85%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to fi
Re: [PR] feat: Adding support to block archival on last known ECTR for v6 tables [hudi]
codecov-commenter commented on PR #18380: URL: https://github.com/apache/hudi/pull/18380#issuecomment-4225419638 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18380?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `86.7%` with `4 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 48.03%. Comparing base ([`2f07364`](https://app.codecov.io/gh/apache/hudi/commit/2f073643dfe764d34fee5a139d95633df01d9292?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`112973a`](https://app.codecov.io/gh/apache/hudi/commit/112973acbb3cb2969f8f4e335bd605ee4070a4ea?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 49 commits behind head on master. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18380?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...ent/timeline/versioning/v1/TimelineArchiverV1.java](https://app.codecov.io/gh/apache/hudi/pull/18380?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv1%2FTimelineArchiverV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YxL1RpbWVsaW5lQXJjaGl2ZXJWMS5qYXZh) | 80.95% | [3 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18380?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | > :exclamation: There is a different number of reports uploaded between BASE (2f07364) and HEAD (112973a). Click for more details. > > HEAD has 21 uploads less than BASE > >| Flag | BASE (2f07364) | HEAD (112973a) | >|--|--|--| >|spark-scala-tests|10|5| >|spark-java-tests|15|1| >|common-and-other-modules|1|0| >|utilities|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18380 +/- ## = - Coverage 68.36% 48.03% -20.34% + Complexity2756616461-11105 = Files 2432 2004 -428 Lines133175 112148-21027 Branches 1602314241 -1782 = - Hits 9104753871-37176 - Misses3506852613+17545 + Partials 7060 5664 -1396 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.83% <20.00%> (-0.32%)` | :arrow_down: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.59% <86.66%> (+0.02%)` | :arrow_up: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.52% <20.00%> (-15.18%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.54% <20.00%> (-12.85%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to fi
Re: [PR] feat: Adding support to block archival on last known ECTR for v6 tables [hudi]
codecov-commenter commented on PR #18380: URL: https://github.com/apache/hudi/pull/18380#issuecomment-4225409260 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18380?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `86.7%` with `4 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 46.77%. Comparing base ([`2f07364`](https://app.codecov.io/gh/apache/hudi/commit/2f073643dfe764d34fee5a139d95633df01d9292?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`112973a`](https://app.codecov.io/gh/apache/hudi/commit/112973acbb3cb2969f8f4e335bd605ee4070a4ea?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 49 commits behind head on master. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18380?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...ent/timeline/versioning/v1/TimelineArchiverV1.java](https://app.codecov.io/gh/apache/hudi/pull/18380?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv1%2FTimelineArchiverV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YxL1RpbWVsaW5lQXJjaGl2ZXJWMS5qYXZh) | 80.95% | [3 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18380?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | > :exclamation: There is a different number of reports uploaded between BASE (2f07364) and HEAD (112973a). Click for more details. > > HEAD has 26 uploads less than BASE > >| Flag | BASE (2f07364) | HEAD (112973a) | >|--|--|--| >|spark-scala-tests|10|1| >|spark-java-tests|15|0| >|common-and-other-modules|1|0| >|utilities|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18380 +/- ## = - Coverage 68.36% 46.77% -21.59% + Complexity2756615016-12550 = Files 2432 1940 -492 Lines133175 104690-28485 Branches 1602312618 -3405 = - Hits 9104748971-42076 - Misses3506850688+15620 + Partials 7060 5031 -2029 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.83% <20.00%> (-0.32%)` | :arrow_down: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.59% <86.66%> (+0.02%)` | :arrow_up: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.08% <20.00%> (-12.31%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with mis
Re: [PR] feat: Adding support to block archival on last known ECTR for v6 tables [hudi]
codecov-commenter commented on PR #18380: URL: https://github.com/apache/hudi/pull/18380#issuecomment-4225418401 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18380?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `86.7%` with `4 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 48.63%. Comparing base ([`2f07364`](https://app.codecov.io/gh/apache/hudi/commit/2f073643dfe764d34fee5a139d95633df01d9292?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`112973a`](https://app.codecov.io/gh/apache/hudi/commit/112973acbb3cb2969f8f4e335bd605ee4070a4ea?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 49 commits behind head on master. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18380?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...ent/timeline/versioning/v1/TimelineArchiverV1.java](https://app.codecov.io/gh/apache/hudi/pull/18380?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv1%2FTimelineArchiverV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YxL1RpbWVsaW5lQXJjaGl2ZXJWMS5qYXZh) | 80.95% | [3 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18380?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | > :exclamation: There is a different number of reports uploaded between BASE (2f07364) and HEAD (112973a). Click for more details. > > HEAD has 22 uploads less than BASE > >| Flag | BASE (2f07364) | HEAD (112973a) | >|--|--|--| >|spark-scala-tests|10|4| >|spark-java-tests|15|1| >|common-and-other-modules|1|0| >|utilities|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18380 +/- ## = - Coverage 68.36% 48.63% -19.74% + Complexity2756616300-11266 = Files 2432 1987 -445 Lines133175 109803-23372 Branches 1602313740 -2283 = - Hits 9104753404-37643 - Misses3506850877+15809 + Partials 7060 5522 -1538 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.83% <20.00%> (-0.32%)` | :arrow_down: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.59% <86.66%> (+0.02%)` | :arrow_up: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.52% <20.00%> (-15.18%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.81% <20.00%> (-12.58%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to fi
Re: [PR] feat: Adding support to block archival on last known ECTR for v6 tables [hudi]
codecov-commenter commented on PR #18380: URL: https://github.com/apache/hudi/pull/18380#issuecomment-4225414163 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18380?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `86.7%` with `4 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 46.30%. Comparing base ([`2f07364`](https://app.codecov.io/gh/apache/hudi/commit/2f073643dfe764d34fee5a139d95633df01d9292?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`112973a`](https://app.codecov.io/gh/apache/hudi/commit/112973acbb3cb2969f8f4e335bd605ee4070a4ea?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 49 commits behind head on master. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18380?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...ent/timeline/versioning/v1/TimelineArchiverV1.java](https://app.codecov.io/gh/apache/hudi/pull/18380?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv1%2FTimelineArchiverV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YxL1RpbWVsaW5lQXJjaGl2ZXJWMS5qYXZh) | 80.95% | [3 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18380?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | > :exclamation: There is a different number of reports uploaded between BASE (2f07364) and HEAD (112973a). Click for more details. > > HEAD has 24 uploads less than BASE > >| Flag | BASE (2f07364) | HEAD (112973a) | >|--|--|--| >|spark-scala-tests|10|3| >|spark-java-tests|15|0| >|common-and-other-modules|1|0| >|utilities|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18380 +/- ## = - Coverage 68.36% 46.30% -22.06% + Complexity2756615180-12386 = Files 2432 1958 -474 Lines133175 107200-25975 Branches 1602313186 -2837 = - Hits 9104749643-41404 - Misses3506852408+17340 + Partials 7060 5149 -1911 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.83% <20.00%> (-0.32%)` | :arrow_down: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.59% <86.66%> (+0.02%)` | :arrow_up: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.95% <20.00%> (-12.44%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with mis
Re: [PR] feat: Adding support to block archival on last known ECTR for v6 tables [hudi]
codecov-commenter commented on PR #18380: URL: https://github.com/apache/hudi/pull/18380#issuecomment-4225387999 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18380?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `86.7%` with `4 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 54.08%. Comparing base ([`2f07364`](https://app.codecov.io/gh/apache/hudi/commit/2f073643dfe764d34fee5a139d95633df01d9292?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`112973a`](https://app.codecov.io/gh/apache/hudi/commit/112973acbb3cb2969f8f4e335bd605ee4070a4ea?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 49 commits behind head on master. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18380?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...ent/timeline/versioning/v1/TimelineArchiverV1.java](https://app.codecov.io/gh/apache/hudi/pull/18380?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv1%2FTimelineArchiverV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YxL1RpbWVsaW5lQXJjaGl2ZXJWMS5qYXZh) | 80.95% | [3 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18380?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | > :exclamation: There is a different number of reports uploaded between BASE (2f07364) and HEAD (112973a). Click for more details. > > HEAD has 27 uploads less than BASE > >| Flag | BASE (2f07364) | HEAD (112973a) | >|--|--|--| >|spark-scala-tests|10|0| >|spark-java-tests|15|0| >|common-and-other-modules|1|0| >|utilities|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18380 +/- ## = - Coverage 68.36% 54.08% -14.29% + Complexity2756612303-15263 = Files 2432 1425 -1007 Lines13317570941-62234 Branches 16023 8004 -8019 = - Hits 9104738366-52681 + Misses3506829146 -5922 + Partials 7060 3429 -3631 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.83% <20.00%> (-0.32%)` | :arrow_down: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.59% <86.66%> (+0.02%)` | :arrow_up: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/g
Re: [PR] feat: Adding support to block archival on last known ECTR for v6 tables [hudi]
codecov-commenter commented on PR #18380: URL: https://github.com/apache/hudi/pull/18380#issuecomment-4225278707 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18380?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `20.0%` with `24 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 44.83%. Comparing base ([`2f07364`](https://app.codecov.io/gh/apache/hudi/commit/2f073643dfe764d34fee5a139d95633df01d9292?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`112973a`](https://app.codecov.io/gh/apache/hudi/commit/112973acbb3cb2969f8f4e335bd605ee4070a4ea?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 49 commits behind head on master. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18380?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...ent/timeline/versioning/v1/TimelineArchiverV1.java](https://app.codecov.io/gh/apache/hudi/pull/18380?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv1%2FTimelineArchiverV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YxL1RpbWVsaW5lQXJjaGl2ZXJWMS5qYXZh) | 0.00% | [21 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18380?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...a/org/apache/hudi/config/HoodieArchivalConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18380?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2FHoodieArchivalConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVBcmNoaXZhbENvbmZpZy5qYXZh) | 75.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18380?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...java/org/apache/hudi/config/HoodieWriteConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18380?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2FHoodieWriteConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVXcml0ZUNvbmZpZy5qYXZh) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18380?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | > :exclamation: There is a different number of reports uploaded between BASE (2f07364) and HEAD (112973a). Click for more details. > > HEAD has 28 uploads less than BASE > >| Flag | BASE (2f07364) | HEAD (112973a) | >|--|--|--| >|spark-client-hadoop-common|1|0| >|spark-scala-tests|10|0| >|spark-java-tests|15|0| >|common-and-other-modules|1|0| >|utilities|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18380 +/- ## = - Coverage 68.36% 44.83% -23.53% + Complexity27566 8479-19087 = Files 2432 1196 -1236 Lines13317561953-71222 Branches 16023 6671 -9352 = - Hits 9104727778-63269 + Misses3506831148 -3920 + Partials 7060 3027 -4033 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18380/fl
Re: [PR] feat: Adding support to block archival on last known ECTR for v6 tables [hudi]
hudi-bot commented on PR #18380: URL: https://github.com/apache/hudi/pull/18380#issuecomment-4225231836 ## CI report: * 7b2aa415d3a8db251165995e2d10a2551af1b815 Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13176) * 112973acbb3cb2969f8f4e335bd605ee4070a4ea Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13204) Bot commands @hudi-bot supports the following commands: - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] feat: Adding support to block archival on last known ECTR for v6 tables [hudi]
hudi-bot commented on PR #18380: URL: https://github.com/apache/hudi/pull/18380#issuecomment-4225213851 ## CI report: * 7b2aa415d3a8db251165995e2d10a2551af1b815 Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13176) * 112973acbb3cb2969f8f4e335bd605ee4070a4ea UNKNOWN Bot commands @hudi-bot supports the following commands: - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] feat: Adding support to block archival on last known ECTR for v6 tables [hudi]
nsivabalan commented on PR #18380: URL: https://github.com/apache/hudi/pull/18380#issuecomment-4225200616 @yihua : can you help land this once you are ok. if there are minor cosmetic suggestions, free free to address them and land them. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] feat: Adding support to block archival on last known ECTR for v6 tables [hudi]
nsivabalan commented on code in PR #18380:
URL: https://github.com/apache/hudi/pull/18380#discussion_r3065469347
##
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/timeline/versioning/v1/TimelineArchiverV1.java:
##
@@ -271,7 +272,31 @@ private Stream getCommitInstantsToArchive()
throws IOException {
Option oldestInstantToRetainForClustering =
ClusteringUtils.getEarliestInstantToRetainForClustering(table.getActiveTimeline(),
table.getMetaClient(), config.getCleanerPolicy());
+ // If enabled, block archival based on ECTR from the last completed
clean to ensure we don't archive
+ // commits that have data files that haven't been cleaned yet.
+ Option oldestInstantToRetainForClean = Option.empty();
+ if (config.shouldBlockArchivalOnCleanECTR()) {
+Option lastCleanInstant =
table.getCleanTimeline().filterCompletedInstants().lastInstant();
+if (lastCleanInstant.isPresent()) {
+ try {
+org.apache.hudi.avro.model.HoodieCleanMetadata cleanMetadata =
+
table.getActiveTimeline().readCleanMetadata(lastCleanInstant.get());
+if (cleanMetadata.getEarliestCommitToRetain() != null
+&&
!cleanMetadata.getEarliestCommitToRetain().trim().isEmpty()) {
Review Comment:
its internally cached. so, we should be good
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] feat: Adding support to block archival on last known ECTR for v6 tables [hudi]
nsivabalan commented on code in PR #18380:
URL: https://github.com/apache/hudi/pull/18380#discussion_r3065460021
##
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/timeline/versioning/v1/TimelineArchiverV1.java:
##
@@ -271,7 +271,30 @@ private Stream getCommitInstantsToArchive()
throws IOException {
Option oldestInstantToRetainForClustering =
ClusteringUtils.getEarliestInstantToRetainForClustering(table.getActiveTimeline(),
table.getMetaClient(), config.getCleanerPolicy());
+ // If enabled, block archival based on ECTR from the last completed
clean to ensure we don't archive
+ // commits that have data files that haven't been cleaned yet.
+ Option oldestInstantToRetainForClean = Option.empty();
+ if (config.shouldBlockArchivalOnCleanECTR()) {
+Option lastCleanInstant =
table.getCleanTimeline().filterCompletedInstants().lastInstant();
Review Comment:
yes, we should be good
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] feat: Adding support to block archival on last known ECTR for v6 tables [hudi]
yihua commented on code in PR #18380:
URL: https://github.com/apache/hudi/pull/18380#discussion_r3059931198
##
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/timeline/versioning/v1/TimelineArchiverV1.java:
##
@@ -271,7 +272,31 @@ private Stream getCommitInstantsToArchive()
throws IOException {
Option oldestInstantToRetainForClustering =
ClusteringUtils.getEarliestInstantToRetainForClustering(table.getActiveTimeline(),
table.getMetaClient(), config.getCleanerPolicy());
+ // If enabled, block archival based on ECTR from the last completed
clean to ensure we don't archive
+ // commits that have data files that haven't been cleaned yet.
+ Option oldestInstantToRetainForClean = Option.empty();
+ if (config.shouldBlockArchivalOnCleanECTR()) {
+Option lastCleanInstant =
table.getCleanTimeline().filterCompletedInstants().lastInstant();
+if (lastCleanInstant.isPresent()) {
+ try {
+org.apache.hudi.avro.model.HoodieCleanMetadata cleanMetadata =
+
table.getActiveTimeline().readCleanMetadata(lastCleanInstant.get());
+if (cleanMetadata.getEarliestCommitToRetain() != null
+&&
!cleanMetadata.getEarliestCommitToRetain().trim().isEmpty()) {
+ oldestInstantToRetainForClean =
commitTimeline.findInstantsAfterOrEquals(
+ cleanMetadata.getEarliestCommitToRetain()).firstInstant();
+ log.info("Blocking archival based on ECTR {} from last clean {}",
+ cleanMetadata.getEarliestCommitToRetain(),
lastCleanInstant.get().requestedTime());
+}
+ } catch (IOException e) {
Review Comment:
🤖 The log message says "skipping ECTR check" but then immediately throws a
`HoodieIOException`, which will abort archival entirely. These two actions
contradict each other. If the intent is fail-closed (safer — prevents
accidental archival), the log message should say something like "Failed to read
clean metadata, aborting archival" instead of "skipping". Or if the intent is
fail-open (allow archival to proceed), the throw should be removed. Could you
clarify which behavior is intended and align the log + control flow?
- Generated by an AI agent and may contain mistakes. Please verify
any suggestions before applying.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
