Re: [PR] feat: support customized metrics reporter [hudi]
HuangZhenQiu closed pull request #18710: feat: support customized metrics reporter URL: https://github.com/apache/hudi/pull/18710 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] feat: support customized metrics reporter [hudi]
HuangZhenQiu commented on PR #18710: URL: https://github.com/apache/hudi/pull/18710#issuecomment-4410249373 This change is not needed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] feat: support customized metrics reporter [hudi]
hudi-bot commented on PR #18710: URL: https://github.com/apache/hudi/pull/18710#issuecomment-4410179040 ## CI report: * fd52f6e7d0965171258da2795aa56cd5a1146323 Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13904) Bot commands @hudi-bot supports the following commands: - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] feat: support customized metrics reporter [hudi]
codecov-commenter commented on PR #18710: URL: https://github.com/apache/hudi/pull/18710#issuecomment-4410135186 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18710?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 68.15%. Comparing base ([`47bf4e4`](https://app.codecov.io/gh/apache/hudi/commit/47bf4e41342e4f1dab26a7fb1489f278fbd1226c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`fd52f6e`](https://app.codecov.io/gh/apache/hudi/commit/fd52f6e7d0965171258da2795aa56cd5a1146323?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). Additional details and impacted files ```diff @@Coverage Diff@@ ## master #18710 +/- ## = Coverage 68.14% 68.15% - Complexity2907729093 +16 = Files 2522 2522 Lines141177 141184+7 Branches 1751417512-2 = + Hits 9620896225 +17 + Misses3706137051 -10 Partials 7908 7908 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18710/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18710/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.43% <100.00%> (+<0.01%)` | :arrow_up: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18710/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.97% <12.50%> (-0.03%)` | :arrow_down: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18710/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.34% <12.50%> (-0.02%)` | :arrow_down: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18710/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `49.03% <100.00%> (+0.03%)` | :arrow_up: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18710/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.90% <12.50%> (-0.01%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18710/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.64% <12.50%> (+0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18710?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...pache/hudi/config/metrics/HoodieMetricsConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18710?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2Fmetrics%2FHoodieMetricsConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlnL21ldHJpY3MvSG9vZGllTWV0cmljc0NvbmZpZy5qYXZh) | `83.00% <100.00%> (+1.30%)` | :arrow_up: | | [...rg/apache/hudi/metrics/MetricsReporterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18710?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetrics%2FMetricsReporterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvbWV0cmljcy9NZXRyaWNzUmVwb3J0ZXJGYWN0b3J5LmphdmE=) | `93.33% <100.00%> (+1.22%)` | :arrow_up: | | [...a/org/apache/hudi/metrics/MetricsReporterType.java](https://app.codecov.io/gh/apache/hudi/pull/18710?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetrics%2FM
Re: [PR] feat: support customized metrics reporter [hudi]
codecov-commenter commented on PR #18710: URL: https://github.com/apache/hudi/pull/18710#issuecomment-4410117539 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18710?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 68.15%. Comparing base ([`47bf4e4`](https://app.codecov.io/gh/apache/hudi/commit/47bf4e41342e4f1dab26a7fb1489f278fbd1226c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`fd52f6e`](https://app.codecov.io/gh/apache/hudi/commit/fd52f6e7d0965171258da2795aa56cd5a1146323?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). Additional details and impacted files ```diff @@Coverage Diff@@ ## master #18710 +/- ## = Coverage 68.14% 68.15% - Complexity2907729093 +16 = Files 2522 2522 Lines141177 141184+7 Branches 1751417512-2 = + Hits 9620896225 +17 + Misses3706137051 -10 Partials 7908 7908 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18710/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18710/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.43% <100.00%> (+<0.01%)` | :arrow_up: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18710/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.97% <12.50%> (-0.03%)` | :arrow_down: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18710/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.34% <12.50%> (-0.02%)` | :arrow_down: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18710/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `49.03% <100.00%> (+0.03%)` | :arrow_up: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18710/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.90% <12.50%> (-0.01%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18710/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.64% <12.50%> (+0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18710?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...pache/hudi/config/metrics/HoodieMetricsConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18710?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2Fmetrics%2FHoodieMetricsConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlnL21ldHJpY3MvSG9vZGllTWV0cmljc0NvbmZpZy5qYXZh) | `83.00% <100.00%> (+1.30%)` | :arrow_up: | | [...rg/apache/hudi/metrics/MetricsReporterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18710?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetrics%2FMetricsReporterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvbWV0cmljcy9NZXRyaWNzUmVwb3J0ZXJGYWN0b3J5LmphdmE=) | `93.33% <100.00%> (+1.22%)` | :arrow_up: | | [...a/org/apache/hudi/metrics/MetricsReporterType.java](https://app.codecov.io/gh/apache/hudi/pull/18710?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetrics%2FM
Re: [PR] feat: support customized metrics reporter [hudi]
codecov-commenter commented on PR #18710: URL: https://github.com/apache/hudi/pull/18710#issuecomment-4410109072 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18710?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 68.15%. Comparing base ([`47bf4e4`](https://app.codecov.io/gh/apache/hudi/commit/47bf4e41342e4f1dab26a7fb1489f278fbd1226c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`fd52f6e`](https://app.codecov.io/gh/apache/hudi/commit/fd52f6e7d0965171258da2795aa56cd5a1146323?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). Additional details and impacted files ```diff @@Coverage Diff@@ ## master #18710 +/- ## = Coverage 68.14% 68.15% - Complexity2907729092 +15 = Files 2522 2522 Lines141177 141184+7 Branches 1751417512-2 = + Hits 9620896218 +10 + Misses3706137058-3 Partials 7908 7908 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18710/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18710/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.43% <100.00%> (+<0.01%)` | :arrow_up: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18710/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.97% <12.50%> (-0.03%)` | :arrow_down: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18710/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.34% <12.50%> (-0.02%)` | :arrow_down: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18710/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.99% <100.00%> (-0.01%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18710/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.90% <12.50%> (-0.01%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18710/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.64% <12.50%> (+0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18710?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...pache/hudi/config/metrics/HoodieMetricsConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18710?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2Fmetrics%2FHoodieMetricsConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlnL21ldHJpY3MvSG9vZGllTWV0cmljc0NvbmZpZy5qYXZh) | `83.00% <100.00%> (+1.30%)` | :arrow_up: | | [...rg/apache/hudi/metrics/MetricsReporterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18710?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetrics%2FMetricsReporterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvbWV0cmljcy9NZXRyaWNzUmVwb3J0ZXJGYWN0b3J5LmphdmE=) | `93.33% <100.00%> (+1.22%)` | :arrow_up: | | [...a/org/apache/hudi/metrics/MetricsReporterType.java](https://app.codecov.io/gh/apache/hudi/pull/18710?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetrics%2
Re: [PR] feat: support customized metrics reporter [hudi]
codecov-commenter commented on PR #18710: URL: https://github.com/apache/hudi/pull/18710#issuecomment-4410048844 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18710?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 68.14%. Comparing base ([`47bf4e4`](https://app.codecov.io/gh/apache/hudi/commit/47bf4e41342e4f1dab26a7fb1489f278fbd1226c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`fd52f6e`](https://app.codecov.io/gh/apache/hudi/commit/fd52f6e7d0965171258da2795aa56cd5a1146323?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). Additional details and impacted files ```diff @@Coverage Diff@@ ## master #18710 +/- ## = Coverage 68.14% 68.14% - Complexity2907729091 +14 = Files 2522 2522 Lines141177 141184+7 Branches 1751417512-2 = + Hits 9620896214+6 Misses3706137061 - Partials 7908 7909+1 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18710/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18710/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.43% <100.00%> (+<0.01%)` | :arrow_up: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18710/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.97% <12.50%> (-0.03%)` | :arrow_down: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18710/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.34% <12.50%> (-0.02%)` | :arrow_down: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18710/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.92% <100.00%> (-0.08%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18710/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.90% <12.50%> (-0.01%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18710/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.64% <12.50%> (+0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18710?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...pache/hudi/config/metrics/HoodieMetricsConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18710?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2Fmetrics%2FHoodieMetricsConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlnL21ldHJpY3MvSG9vZGllTWV0cmljc0NvbmZpZy5qYXZh) | `83.00% <100.00%> (+1.30%)` | :arrow_up: | | [...rg/apache/hudi/metrics/MetricsReporterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18710?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetrics%2FMetricsReporterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvbWV0cmljcy9NZXRyaWNzUmVwb3J0ZXJGYWN0b3J5LmphdmE=) | `93.33% <100.00%> (+1.22%)` | :arrow_up: | | [...a/org/apache/hudi/metrics/MetricsReporterType.java](https://app.codecov.io/gh/apache/hudi/pull/18710?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetrics%2
Re: [PR] feat: support customized metrics reporter [hudi]
codecov-commenter commented on PR #18710: URL: https://github.com/apache/hudi/pull/18710#issuecomment-4410051325 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18710?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 68.14%. Comparing base ([`47bf4e4`](https://app.codecov.io/gh/apache/hudi/commit/47bf4e41342e4f1dab26a7fb1489f278fbd1226c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`fd52f6e`](https://app.codecov.io/gh/apache/hudi/commit/fd52f6e7d0965171258da2795aa56cd5a1146323?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). Additional details and impacted files ```diff @@Coverage Diff@@ ## master #18710 +/- ## = Coverage 68.14% 68.14% - Complexity2907729092 +15 = Files 2522 2522 Lines141177 141184+7 Branches 1751417512-2 = + Hits 9620896216+8 + Misses3706137060-1 Partials 7908 7908 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18710/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18710/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.43% <100.00%> (+<0.01%)` | :arrow_up: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18710/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.97% <12.50%> (-0.03%)` | :arrow_down: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18710/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.34% <12.50%> (-0.02%)` | :arrow_down: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18710/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.94% <100.00%> (-0.06%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18710/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.90% <12.50%> (-0.01%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18710/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.64% <12.50%> (+0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18710?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...pache/hudi/config/metrics/HoodieMetricsConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18710?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2Fmetrics%2FHoodieMetricsConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlnL21ldHJpY3MvSG9vZGllTWV0cmljc0NvbmZpZy5qYXZh) | `83.00% <100.00%> (+1.30%)` | :arrow_up: | | [...rg/apache/hudi/metrics/MetricsReporterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18710?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetrics%2FMetricsReporterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvbWV0cmljcy9NZXRyaWNzUmVwb3J0ZXJGYWN0b3J5LmphdmE=) | `93.33% <100.00%> (+1.22%)` | :arrow_up: | | [...a/org/apache/hudi/metrics/MetricsReporterType.java](https://app.codecov.io/gh/apache/hudi/pull/18710?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetrics%2
Re: [PR] feat: support customized metrics reporter [hudi]
codecov-commenter commented on PR #18710: URL: https://github.com/apache/hudi/pull/18710#issuecomment-4410040837 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18710?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 67.39%. Comparing base ([`47bf4e4`](https://app.codecov.io/gh/apache/hudi/commit/47bf4e41342e4f1dab26a7fb1489f278fbd1226c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`fd52f6e`](https://app.codecov.io/gh/apache/hudi/commit/fd52f6e7d0965171258da2795aa56cd5a1146323?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18710 +/- ## - Coverage 68.14% 67.39% -0.76% + Complexity2907728786 -291 Files 2522 2522 Lines141177 141184 +7 Branches 1751417512 -2 - Hits 9620895150-1058 - Misses3706138064+1003 - Partials 7908 7970 +62 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18710/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18710/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.43% <100.00%> (+<0.01%)` | :arrow_up: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18710/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.97% <12.50%> (-0.03%)` | :arrow_down: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18710/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.34% <12.50%> (-0.02%)` | :arrow_down: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18710/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.53% <100.00%> (-3.47%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18710/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.90% <12.50%> (-0.01%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18710/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.64% <12.50%> (+0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18710?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...pache/hudi/config/metrics/HoodieMetricsConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18710?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2Fmetrics%2FHoodieMetricsConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlnL21ldHJpY3MvSG9vZGllTWV0cmljc0NvbmZpZy5qYXZh) | `83.00% <100.00%> (+1.30%)` | :arrow_up: | | [...rg/apache/hudi/metrics/MetricsReporterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18710?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetrics%2FMetricsReporterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvbWV0cmljcy9NZXRyaWNzUmVwb3J0ZXJGYWN0b3J5LmphdmE=) | `93.33% <100.00%> (+1.22%)` | :arrow_up: | | [...a/org/apache/hudi/metrics/MetricsReporterType.java](https://app.codecov.io/gh/apache/hudi/pull/18710?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2
Re: [PR] feat: support customized metrics reporter [hudi]
codecov-commenter commented on PR #18710: URL: https://github.com/apache/hudi/pull/18710#issuecomment-4410042005 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18710?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 68.14%. Comparing base ([`47bf4e4`](https://app.codecov.io/gh/apache/hudi/commit/47bf4e41342e4f1dab26a7fb1489f278fbd1226c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`fd52f6e`](https://app.codecov.io/gh/apache/hudi/commit/fd52f6e7d0965171258da2795aa56cd5a1146323?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18710 +/- ## - Coverage 68.14% 68.14% -0.01% - Complexity2907729090 +13 Files 2522 2522 Lines141177 141184 +7 Branches 1751417512 -2 + Hits 9620896210 +2 - Misses3706137062 +1 - Partials 7908 7912 +4 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18710/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18710/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.43% <100.00%> (+<0.01%)` | :arrow_up: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18710/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.97% <12.50%> (-0.03%)` | :arrow_down: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18710/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.34% <12.50%> (-0.02%)` | :arrow_down: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18710/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.88% <100.00%> (-0.12%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18710/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.90% <12.50%> (-0.01%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18710/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.64% <12.50%> (+0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18710?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...pache/hudi/config/metrics/HoodieMetricsConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18710?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2Fmetrics%2FHoodieMetricsConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlnL21ldHJpY3MvSG9vZGllTWV0cmljc0NvbmZpZy5qYXZh) | `83.00% <100.00%> (+1.30%)` | :arrow_up: | | [...rg/apache/hudi/metrics/MetricsReporterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18710?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetrics%2FMetricsReporterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvbWV0cmljcy9NZXRyaWNzUmVwb3J0ZXJGYWN0b3J5LmphdmE=) | `93.33% <100.00%> (+1.22%)` | :arrow_up: | | [...a/org/apache/hudi/metrics/MetricsReporterType.java](https://app.codecov.io/gh/apache/hudi/pull/18710?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2
Re: [PR] feat: support customized metrics reporter [hudi]
codecov-commenter commented on PR #18710: URL: https://github.com/apache/hudi/pull/18710#issuecomment-4410028166 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18710?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 67.32%. Comparing base ([`47bf4e4`](https://app.codecov.io/gh/apache/hudi/commit/47bf4e41342e4f1dab26a7fb1489f278fbd1226c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`fd52f6e`](https://app.codecov.io/gh/apache/hudi/commit/fd52f6e7d0965171258da2795aa56cd5a1146323?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18710 +/- ## - Coverage 68.14% 67.32% -0.82% + Complexity2907728751 -326 Files 2522 2522 Lines141177 141184 +7 Branches 1751417512 -2 - Hits 9620895058-1150 - Misses3706138163+1102 - Partials 7908 7963 +55 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18710/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18710/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.43% <100.00%> (+<0.01%)` | :arrow_up: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18710/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.97% <12.50%> (-0.03%)` | :arrow_down: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18710/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.34% <12.50%> (-0.02%)` | :arrow_down: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18710/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.27% <100.00%> (-3.73%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18710/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.90% <12.50%> (-0.01%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18710/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.64% <12.50%> (+0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18710?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...pache/hudi/config/metrics/HoodieMetricsConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18710?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2Fmetrics%2FHoodieMetricsConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlnL21ldHJpY3MvSG9vZGllTWV0cmljc0NvbmZpZy5qYXZh) | `83.00% <100.00%> (+1.30%)` | :arrow_up: | | [...rg/apache/hudi/metrics/MetricsReporterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18710?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetrics%2FMetricsReporterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvbWV0cmljcy9NZXRyaWNzUmVwb3J0ZXJGYWN0b3J5LmphdmE=) | `93.33% <100.00%> (+1.22%)` | :arrow_up: | | [...a/org/apache/hudi/metrics/MetricsReporterType.java](https://app.codecov.io/gh/apache/hudi/pull/18710?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2
Re: [PR] feat: support customized metrics reporter [hudi]
codecov-commenter commented on PR #18710: URL: https://github.com/apache/hudi/pull/18710#issuecomment-4410030667 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18710?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 67.32%. Comparing base ([`47bf4e4`](https://app.codecov.io/gh/apache/hudi/commit/47bf4e41342e4f1dab26a7fb1489f278fbd1226c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`fd52f6e`](https://app.codecov.io/gh/apache/hudi/commit/fd52f6e7d0965171258da2795aa56cd5a1146323?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18710 +/- ## - Coverage 68.14% 67.32% -0.82% + Complexity2907728751 -326 Files 2522 2522 Lines141177 141184 +7 Branches 1751417512 -2 - Hits 9620895058-1150 - Misses3706138163+1102 - Partials 7908 7963 +55 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18710/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18710/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.43% <100.00%> (+<0.01%)` | :arrow_up: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18710/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.97% <12.50%> (-0.03%)` | :arrow_down: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18710/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.34% <12.50%> (-0.02%)` | :arrow_down: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18710/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.27% <100.00%> (-3.73%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18710/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.90% <12.50%> (-0.01%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18710/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.64% <12.50%> (+0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18710?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...pache/hudi/config/metrics/HoodieMetricsConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18710?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2Fmetrics%2FHoodieMetricsConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlnL21ldHJpY3MvSG9vZGllTWV0cmljc0NvbmZpZy5qYXZh) | `83.00% <100.00%> (+1.30%)` | :arrow_up: | | [...rg/apache/hudi/metrics/MetricsReporterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18710?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetrics%2FMetricsReporterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvbWV0cmljcy9NZXRyaWNzUmVwb3J0ZXJGYWN0b3J5LmphdmE=) | `93.33% <100.00%> (+1.22%)` | :arrow_up: | | [...a/org/apache/hudi/metrics/MetricsReporterType.java](https://app.codecov.io/gh/apache/hudi/pull/18710?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2
Re: [PR] feat: support customized metrics reporter [hudi]
hudi-agent commented on code in PR #18710:
URL: https://github.com/apache/hudi/pull/18710#discussion_r3211477117
##
hudi-common/src/main/java/org/apache/hudi/config/metrics/HoodieMetricsConfig.java:
##
@@ -73,7 +73,10 @@ public class HoodieMetricsConfig extends HoodieConfig {
.defaultValue("")
.markAdvanced()
.sinceVersion("0.6.0")
- .withDocumentation("");
+ .withDocumentation("Fully qualified class name of a custom
MetricsReporter implementation. "
+ + "The class must extend MetricsReporter and support one of these
constructors (tried in order): "
+ + "(Properties, MetricRegistry), (HoodieMetricsConfig,
MetricRegistry), or no-arg. "
+ + "Set reporter.type=CUSTOM or leave it unset when using this
option.");
Review Comment:
🤖 The phrase "or leave it unset when using this option" doesn't match the
actual code behavior. `METRICS_REPORTER_TYPE_VALUE` defaults to `GRAPHITE` (not
unset), and even when it is null `createReporter` returns `Option.empty()` —
neither path will load the custom class. Users effectively must set
`reporter.type=CUSTOM`. Could you tighten this doc accordingly?
- AI-generated; verify before applying. React 👍/👎 to flag
quality.
##
hudi-common/src/main/java/org/apache/hudi/metrics/MetricsReporterFactory.java:
##
@@ -93,10 +80,35 @@ public static Option
createReporter(HoodieMetricsConfig metrics
case SLF4J:
reporter = new Slf4jMetricsReporter(registry);
break;
+ case CUSTOM:
+String reporterClassName = metricsConfig.getMetricReporterClassName();
+if (!StringUtils.isNullOrEmpty(reporterClassName)) {
Review Comment:
🤖 nit: could you invert this into a guard clause? Throwing first and then
falling through to the happy-path `return` removes the `else` branch and makes
the intent clearer — e.g. `if (StringUtils.isNullOrEmpty(reporterClassName)) {
throw …; } return Option.of(loadCustomReporter(…));`
- AI-generated; verify before applying. React 👍/👎 to flag
quality.
##
hudi-common/src/main/java/org/apache/hudi/metrics/MetricsReporterFactory.java:
##
@@ -93,10 +80,35 @@ public static Option
createReporter(HoodieMetricsConfig metrics
case SLF4J:
reporter = new Slf4jMetricsReporter(registry);
break;
+ case CUSTOM:
Review Comment:
🤖 This looks like a silent backward-incompatible change. Before this PR, if
a user set `hoodie.metrics.reporter.class=com.foo.MyReporter` without touching
`reporter.type`, the class-name check ran first and the custom reporter was
loaded. After this PR, since `METRICS_REPORTER_TYPE_VALUE` defaults to
`GRAPHITE`, the same config will silently fall into the `GRAPHITE` case and
ignore the user's custom class — they'll get a Graphite reporter (or a startup
failure) with no warning. Could you preserve the prior behavior — e.g., if
`reporter.class` is set and `reporter.type` is left at the default, treat it as
`CUSTOM` (or at least log a clear warning) so existing deployments aren't
silently broken? @yihua
- AI-generated; verify before applying. React 👍/👎 to flag
quality.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] feat: support customized metrics reporter [hudi]
codecov-commenter commented on PR #18710: URL: https://github.com/apache/hudi/pull/18710#issuecomment-4410017389 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18710?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 67.22%. Comparing base ([`47bf4e4`](https://app.codecov.io/gh/apache/hudi/commit/47bf4e41342e4f1dab26a7fb1489f278fbd1226c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`fd52f6e`](https://app.codecov.io/gh/apache/hudi/commit/fd52f6e7d0965171258da2795aa56cd5a1146323?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18710 +/- ## - Coverage 68.14% 67.22% -0.93% + Complexity2907728697 -380 Files 2522 2522 Lines141177 141184 +7 Branches 1751417512 -2 - Hits 9620894913-1295 - Misses3706138339+1278 - Partials 7908 7932 +24 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18710/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18710/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.43% <100.00%> (+<0.01%)` | :arrow_up: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18710/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.97% <12.50%> (-0.03%)` | :arrow_down: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18710/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.34% <12.50%> (-0.02%)` | :arrow_down: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18710/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.83% <100.00%> (-4.17%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18710/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.81% <12.50%> (-0.09%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18710/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.64% <12.50%> (+0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18710?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...pache/hudi/config/metrics/HoodieMetricsConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18710?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2Fmetrics%2FHoodieMetricsConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlnL21ldHJpY3MvSG9vZGllTWV0cmljc0NvbmZpZy5qYXZh) | `83.00% <100.00%> (+1.30%)` | :arrow_up: | | [...rg/apache/hudi/metrics/MetricsReporterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18710?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetrics%2FMetricsReporterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvbWV0cmljcy9NZXRyaWNzUmVwb3J0ZXJGYWN0b3J5LmphdmE=) | `93.33% <100.00%> (+1.22%)` | :arrow_up: | | [...a/org/apache/hudi/metrics/MetricsReporterType.java](https://app.codecov.io/gh/apache/hudi/pull/18710?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2
Re: [PR] feat: support customized metrics reporter [hudi]
codecov-commenter commented on PR #18710: URL: https://github.com/apache/hudi/pull/18710#issuecomment-4410019060 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18710?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 67.22%. Comparing base ([`47bf4e4`](https://app.codecov.io/gh/apache/hudi/commit/47bf4e41342e4f1dab26a7fb1489f278fbd1226c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`fd52f6e`](https://app.codecov.io/gh/apache/hudi/commit/fd52f6e7d0965171258da2795aa56cd5a1146323?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18710 +/- ## - Coverage 68.14% 67.22% -0.93% + Complexity2907728697 -380 Files 2522 2522 Lines141177 141184 +7 Branches 1751417512 -2 - Hits 9620894913-1295 - Misses3706138339+1278 - Partials 7908 7932 +24 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18710/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18710/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.43% <100.00%> (+<0.01%)` | :arrow_up: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18710/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.97% <12.50%> (-0.03%)` | :arrow_down: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18710/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.34% <12.50%> (-0.02%)` | :arrow_down: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18710/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.83% <100.00%> (-4.17%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18710/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.81% <12.50%> (-0.09%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18710/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.64% <12.50%> (+0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18710?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...pache/hudi/config/metrics/HoodieMetricsConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18710?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2Fmetrics%2FHoodieMetricsConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlnL21ldHJpY3MvSG9vZGllTWV0cmljc0NvbmZpZy5qYXZh) | `83.00% <100.00%> (+1.30%)` | :arrow_up: | | [...rg/apache/hudi/metrics/MetricsReporterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18710?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetrics%2FMetricsReporterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvbWV0cmljcy9NZXRyaWNzUmVwb3J0ZXJGYWN0b3J5LmphdmE=) | `93.33% <100.00%> (+1.22%)` | :arrow_up: | | [...a/org/apache/hudi/metrics/MetricsReporterType.java](https://app.codecov.io/gh/apache/hudi/pull/18710?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2
Re: [PR] feat: support customized metrics reporter [hudi]
codecov-commenter commented on PR #18710: URL: https://github.com/apache/hudi/pull/18710#issuecomment-4409991159 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18710?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 65.33%. Comparing base ([`47bf4e4`](https://app.codecov.io/gh/apache/hudi/commit/47bf4e41342e4f1dab26a7fb1489f278fbd1226c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`fd52f6e`](https://app.codecov.io/gh/apache/hudi/commit/fd52f6e7d0965171258da2795aa56cd5a1146323?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18710 +/- ## - Coverage 68.14% 65.33% -2.82% + Complexity2907727868-1209 Files 2522 2522 Lines141177 141184 +7 Branches 1751417512 -2 - Hits 9620892242-3966 - Misses3706140961+3900 - Partials 7908 7981 +73 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18710/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18710/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.43% <100.00%> (+<0.01%)` | :arrow_up: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18710/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.97% <12.50%> (-0.03%)` | :arrow_down: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18710/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.34% <12.50%> (-0.02%)` | :arrow_down: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18710/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `31.56% <12.50%> (-17.44%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18710/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.69% <12.50%> (-0.22%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18710/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.64% <12.50%> (+0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18710?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...pache/hudi/config/metrics/HoodieMetricsConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18710?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2Fmetrics%2FHoodieMetricsConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlnL21ldHJpY3MvSG9vZGllTWV0cmljc0NvbmZpZy5qYXZh) | `83.00% <100.00%> (+1.30%)` | :arrow_up: | | [...rg/apache/hudi/metrics/MetricsReporterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18710?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetrics%2FMetricsReporterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvbWV0cmljcy9NZXRyaWNzUmVwb3J0ZXJGYWN0b3J5LmphdmE=) | `93.33% <100.00%> (+1.22%)` | :arrow_up: | | [...a/org/apache/hudi/metrics/MetricsReporterType.java](https://app.codecov.io/gh/apache/hudi/pull/18710?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2
Re: [PR] feat: support customized metrics reporter [hudi]
codecov-commenter commented on PR #18710: URL: https://github.com/apache/hudi/pull/18710#issuecomment-4409977917 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18710?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 65.28%. Comparing base ([`47bf4e4`](https://app.codecov.io/gh/apache/hudi/commit/47bf4e41342e4f1dab26a7fb1489f278fbd1226c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`fd52f6e`](https://app.codecov.io/gh/apache/hudi/commit/fd52f6e7d0965171258da2795aa56cd5a1146323?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18710 +/- ## - Coverage 68.14% 65.28% -2.86% + Complexity2907727837-1240 Files 2522 2522 Lines141177 141184 +7 Branches 1751417512 -2 - Hits 9620892177-4031 - Misses3706141039+3978 - Partials 7908 7968 +60 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18710/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18710/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.43% <100.00%> (+<0.01%)` | :arrow_up: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18710/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.97% <12.50%> (-0.03%)` | :arrow_down: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18710/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.34% <12.50%> (-0.02%)` | :arrow_down: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18710/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `31.56% <12.50%> (-17.44%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18710/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.60% <12.50%> (-0.30%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18710/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.64% <12.50%> (+0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18710?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...pache/hudi/config/metrics/HoodieMetricsConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18710?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2Fmetrics%2FHoodieMetricsConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlnL21ldHJpY3MvSG9vZGllTWV0cmljc0NvbmZpZy5qYXZh) | `83.00% <100.00%> (+1.30%)` | :arrow_up: | | [...rg/apache/hudi/metrics/MetricsReporterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18710?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetrics%2FMetricsReporterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvbWV0cmljcy9NZXRyaWNzUmVwb3J0ZXJGYWN0b3J5LmphdmE=) | `93.33% <100.00%> (+1.22%)` | :arrow_up: | | [...a/org/apache/hudi/metrics/MetricsReporterType.java](https://app.codecov.io/gh/apache/hudi/pull/18710?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2
Re: [PR] feat: support customized metrics reporter [hudi]
codecov-commenter commented on PR #18710: URL: https://github.com/apache/hudi/pull/18710#issuecomment-4409963020 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18710?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 65.24%. Comparing base ([`47bf4e4`](https://app.codecov.io/gh/apache/hudi/commit/47bf4e41342e4f1dab26a7fb1489f278fbd1226c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`fd52f6e`](https://app.codecov.io/gh/apache/hudi/commit/fd52f6e7d0965171258da2795aa56cd5a1146323?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18710 +/- ## - Coverage 68.14% 65.24% -2.91% + Complexity2907727819-1258 Files 2522 2522 Lines141177 141184 +7 Branches 1751417512 -2 - Hits 9620892111-4097 - Misses3706141112+4051 - Partials 7908 7961 +53 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18710/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18710/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.43% <100.00%> (+<0.01%)` | :arrow_up: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18710/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.97% <12.50%> (-0.03%)` | :arrow_down: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18710/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.34% <12.50%> (-0.02%)` | :arrow_down: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18710/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `31.56% <12.50%> (-17.44%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18710/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.51% <12.50%> (-0.39%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18710/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.64% <12.50%> (+0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18710?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...pache/hudi/config/metrics/HoodieMetricsConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18710?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2Fmetrics%2FHoodieMetricsConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlnL21ldHJpY3MvSG9vZGllTWV0cmljc0NvbmZpZy5qYXZh) | `83.00% <100.00%> (+1.30%)` | :arrow_up: | | [...rg/apache/hudi/metrics/MetricsReporterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18710?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetrics%2FMetricsReporterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvbWV0cmljcy9NZXRyaWNzUmVwb3J0ZXJGYWN0b3J5LmphdmE=) | `93.33% <100.00%> (+1.22%)` | :arrow_up: | | [...a/org/apache/hudi/metrics/MetricsReporterType.java](https://app.codecov.io/gh/apache/hudi/pull/18710?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2
Re: [PR] feat: support customized metrics reporter [hudi]
codecov-commenter commented on PR #18710: URL: https://github.com/apache/hudi/pull/18710#issuecomment-4409954431 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18710?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 60.89%. Comparing base ([`47bf4e4`](https://app.codecov.io/gh/apache/hudi/commit/47bf4e41342e4f1dab26a7fb1489f278fbd1226c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`fd52f6e`](https://app.codecov.io/gh/apache/hudi/commit/fd52f6e7d0965171258da2795aa56cd5a1146323?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). > :exclamation: There is a different number of reports uploaded between BASE (47bf4e4) and HEAD (fd52f6e). Click for more details. > > HEAD has 18 uploads less than BASE > >| Flag | BASE (47bf4e4) | HEAD (fd52f6e) | >|--|--|--| >|spark-scala-tests|12|6| >|spark-java-tests|18|6| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18710 +/- ## - Coverage 68.14% 60.89% -7.26% + Complexity2907725966-3111 Files 2522 2522 Lines141177 141184 +7 Branches 1751417512 -2 - Hits 9620885969 -10239 - Misses3706147679 +10618 + Partials 7908 7536 -372 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18710/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18710/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.43% <100.00%> (+<0.01%)` | :arrow_up: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18710/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.97% <12.50%> (-0.03%)` | :arrow_down: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18710/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.34% <12.50%> (-0.02%)` | :arrow_down: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18710/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `31.56% <12.50%> (-17.44%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18710/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.72% <12.50%> (-12.18%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18710/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.64% <12.50%> (+0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18710?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...pache/hudi/config/metrics/HoodieMetricsConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18710?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2Fmetrics%2FHoodieMetricsConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlnL21ldHJpY3MvSG9vZGllTWV0cmljc0NvbmZpZy5qYXZh) | `83.00% <100.00%> (+1.30%)` | :arrow_up: | | [...rg/apache/hudi/metrics/MetricsReporterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18710?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetrics%2FMetricsReporterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=a
Re: [PR] feat: support customized metrics reporter [hudi]
codecov-commenter commented on PR #18710: URL: https://github.com/apache/hudi/pull/18710#issuecomment-4409941576 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18710?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 60.89%. Comparing base ([`47bf4e4`](https://app.codecov.io/gh/apache/hudi/commit/47bf4e41342e4f1dab26a7fb1489f278fbd1226c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`fd52f6e`](https://app.codecov.io/gh/apache/hudi/commit/fd52f6e7d0965171258da2795aa56cd5a1146323?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). > :exclamation: There is a different number of reports uploaded between BASE (47bf4e4) and HEAD (fd52f6e). Click for more details. > > HEAD has 19 uploads less than BASE > >| Flag | BASE (47bf4e4) | HEAD (fd52f6e) | >|--|--|--| >|spark-scala-tests|12|6| >|spark-java-tests|18|5| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18710 +/- ## - Coverage 68.14% 60.89% -7.26% + Complexity2907725966-3111 Files 2522 2522 Lines141177 141184 +7 Branches 1751417512 -2 - Hits 9620885969 -10239 - Misses3706147679 +10618 + Partials 7908 7536 -372 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18710/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18710/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.43% <100.00%> (+<0.01%)` | :arrow_up: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18710/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.97% <12.50%> (-0.03%)` | :arrow_down: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18710/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.34% <12.50%> (-0.02%)` | :arrow_down: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18710/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `31.56% <12.50%> (-17.44%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18710/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.72% <12.50%> (-12.18%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18710/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.64% <12.50%> (+0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18710?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...pache/hudi/config/metrics/HoodieMetricsConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18710?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2Fmetrics%2FHoodieMetricsConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlnL21ldHJpY3MvSG9vZGllTWV0cmljc0NvbmZpZy5qYXZh) | `83.00% <100.00%> (+1.30%)` | :arrow_up: | | [...rg/apache/hudi/metrics/MetricsReporterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18710?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetrics%2FMetricsReporterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=a
Re: [PR] feat: support customized metrics reporter [hudi]
codecov-commenter commented on PR #18710: URL: https://github.com/apache/hudi/pull/18710#issuecomment-4409939833 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18710?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `12.5%` with `14 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 53.90%. Comparing base ([`47bf4e4`](https://app.codecov.io/gh/apache/hudi/commit/47bf4e41342e4f1dab26a7fb1489f278fbd1226c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`fd52f6e`](https://app.codecov.io/gh/apache/hudi/commit/fd52f6e7d0965171258da2795aa56cd5a1146323?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18710?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...rg/apache/hudi/metrics/MetricsReporterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18710?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetrics%2FMetricsReporterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvbWV0cmljcy9NZXRyaWNzUmVwb3J0ZXJGYWN0b3J5LmphdmE=) | 0.00% | [14 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18710?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | > :exclamation: There is a different number of reports uploaded between BASE (47bf4e4) and HEAD (fd52f6e). Click for more details. > > HEAD has 20 uploads less than BASE > >| Flag | BASE (47bf4e4) | HEAD (fd52f6e) | >|--|--|--| >|spark-scala-tests|12|6| >|spark-java-tests|18|5| >|common-and-other-modules|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18710 +/- ## = - Coverage 68.14% 53.90% -14.25% + Complexity2907719082 -9995 = Files 2522 2049 -473 Lines141177 117176-24001 Branches 1751415235 -2279 = - Hits 9620863158-33050 - Misses3706147234+10173 + Partials 7908 6784 -1124 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18710/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18710/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18710/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.97% <12.50%> (-0.03%)` | :arrow_down: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18710/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.34% <12.50%> (-0.02%)` | :arrow_down: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18710/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `31.56% <12.50%> (-17.44%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18710/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.72% <12.50%> (-12.18%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18710/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.64% <12.50%> (+0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18710?dropdown=coverage&src=pr&el=tree&utm_medium=refe
Re: [PR] feat: support customized metrics reporter [hudi]
codecov-commenter commented on PR #18710: URL: https://github.com/apache/hudi/pull/18710#issuecomment-4409929866 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18710?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `12.5%` with `14 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 47.90%. Comparing base ([`47bf4e4`](https://app.codecov.io/gh/apache/hudi/commit/47bf4e41342e4f1dab26a7fb1489f278fbd1226c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`fd52f6e`](https://app.codecov.io/gh/apache/hudi/commit/fd52f6e7d0965171258da2795aa56cd5a1146323?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18710?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...rg/apache/hudi/metrics/MetricsReporterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18710?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetrics%2FMetricsReporterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvbWV0cmljcy9NZXRyaWNzUmVwb3J0ZXJGYWN0b3J5LmphdmE=) | 0.00% | [14 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18710?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | > :exclamation: There is a different number of reports uploaded between BASE (47bf4e4) and HEAD (fd52f6e). Click for more details. > > HEAD has 21 uploads less than BASE > >| Flag | BASE (47bf4e4) | HEAD (fd52f6e) | >|--|--|--| >|spark-scala-tests|12|6| >|spark-java-tests|18|5| >|common-and-other-modules|1|0| >|utilities|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18710 +/- ## = - Coverage 68.14% 47.90% -20.24% + Complexity2907717139-11938 = Files 2522 2049 -473 Lines141177 117176-24001 Branches 1751415235 -2279 = - Hits 9620856137-40071 - Misses3706154865+17804 + Partials 7908 6174 -1734 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18710/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18710/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18710/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.97% <12.50%> (-0.03%)` | :arrow_down: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18710/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.34% <12.50%> (-0.02%)` | :arrow_down: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18710/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `31.56% <12.50%> (-17.44%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18710/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.72% <12.50%> (-12.18%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18710/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18710?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_sourc
Re: [PR] feat: support customized metrics reporter [hudi]
codecov-commenter commented on PR #18710: URL: https://github.com/apache/hudi/pull/18710#issuecomment-4409928710 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18710?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `12.5%` with `14 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 47.90%. Comparing base ([`47bf4e4`](https://app.codecov.io/gh/apache/hudi/commit/47bf4e41342e4f1dab26a7fb1489f278fbd1226c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`fd52f6e`](https://app.codecov.io/gh/apache/hudi/commit/fd52f6e7d0965171258da2795aa56cd5a1146323?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18710?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...rg/apache/hudi/metrics/MetricsReporterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18710?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetrics%2FMetricsReporterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvbWV0cmljcy9NZXRyaWNzUmVwb3J0ZXJGYWN0b3J5LmphdmE=) | 0.00% | [14 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18710?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | > :exclamation: There is a different number of reports uploaded between BASE (47bf4e4) and HEAD (fd52f6e). Click for more details. > > HEAD has 21 uploads less than BASE > >| Flag | BASE (47bf4e4) | HEAD (fd52f6e) | >|--|--|--| >|spark-scala-tests|12|6| >|spark-java-tests|18|5| >|common-and-other-modules|1|0| >|utilities|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18710 +/- ## = - Coverage 68.14% 47.90% -20.24% + Complexity2907717139-11938 = Files 2522 2049 -473 Lines141177 117176-24001 Branches 1751415235 -2279 = - Hits 9620856137-40071 - Misses3706154865+17804 + Partials 7908 6174 -1734 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18710/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18710/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18710/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.97% <12.50%> (-0.03%)` | :arrow_down: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18710/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.34% <12.50%> (-0.02%)` | :arrow_down: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18710/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `31.56% <12.50%> (-17.44%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18710/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.72% <12.50%> (-12.18%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18710/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18710?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_sourc
Re: [PR] feat: support customized metrics reporter [hudi]
codecov-commenter commented on PR #18710: URL: https://github.com/apache/hudi/pull/18710#issuecomment-4409922627 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18710?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `12.5%` with `14 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 47.84%. Comparing base ([`47bf4e4`](https://app.codecov.io/gh/apache/hudi/commit/47bf4e41342e4f1dab26a7fb1489f278fbd1226c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`fd52f6e`](https://app.codecov.io/gh/apache/hudi/commit/fd52f6e7d0965171258da2795aa56cd5a1146323?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18710?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...rg/apache/hudi/metrics/MetricsReporterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18710?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetrics%2FMetricsReporterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvbWV0cmljcy9NZXRyaWNzUmVwb3J0ZXJGYWN0b3J5LmphdmE=) | 0.00% | [14 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18710?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | > :exclamation: There is a different number of reports uploaded between BASE (47bf4e4) and HEAD (fd52f6e). Click for more details. > > HEAD has 23 uploads less than BASE > >| Flag | BASE (47bf4e4) | HEAD (fd52f6e) | >|--|--|--| >|spark-scala-tests|12|6| >|spark-java-tests|18|3| >|common-and-other-modules|1|0| >|utilities|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18710 +/- ## = - Coverage 68.14% 47.84% -20.30% + Complexity2907717121-11956 = Files 2522 2049 -473 Lines141177 117176-24001 Branches 1751415235 -2279 = - Hits 9620856068-40140 - Misses3706154929+17868 + Partials 7908 6179 -1729 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18710/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18710/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18710/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.97% <12.50%> (-0.03%)` | :arrow_down: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18710/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.34% <12.50%> (-0.02%)` | :arrow_down: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18710/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.35% <12.50%> (-16.65%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18710/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.72% <12.50%> (-12.18%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18710/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18710?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_sourc
Re: [PR] feat: support customized metrics reporter [hudi]
codecov-commenter commented on PR #18710: URL: https://github.com/apache/hudi/pull/18710#issuecomment-4409918657 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18710?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `12.5%` with `14 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 48.33%. Comparing base ([`47bf4e4`](https://app.codecov.io/gh/apache/hudi/commit/47bf4e41342e4f1dab26a7fb1489f278fbd1226c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`fd52f6e`](https://app.codecov.io/gh/apache/hudi/commit/fd52f6e7d0965171258da2795aa56cd5a1146323?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18710?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...rg/apache/hudi/metrics/MetricsReporterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18710?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetrics%2FMetricsReporterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvbWV0cmljcy9NZXRyaWNzUmVwb3J0ZXJGYWN0b3J5LmphdmE=) | 0.00% | [14 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18710?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | > :exclamation: There is a different number of reports uploaded between BASE (47bf4e4) and HEAD (fd52f6e). Click for more details. > > HEAD has 25 uploads less than BASE > >| Flag | BASE (47bf4e4) | HEAD (fd52f6e) | >|--|--|--| >|spark-scala-tests|12|5| >|spark-java-tests|18|2| >|common-and-other-modules|1|0| >|utilities|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18710 +/- ## = - Coverage 68.14% 48.33% -19.81% + Complexity2907716896-12181 = Files 2522 2028 -494 Lines141177 114653-26524 Branches 1751414694 -2820 = - Hits 9620855420-40788 - Misses3706153233+16172 + Partials 7908 6000 -1908 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18710/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18710/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18710/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.97% <12.50%> (-0.03%)` | :arrow_down: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18710/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.34% <12.50%> (-0.02%)` | :arrow_down: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18710/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.71% <12.50%> (-16.29%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18710/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.91% <12.50%> (-11.99%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18710/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18710?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_sourc
Re: [PR] feat: support customized metrics reporter [hudi]
codecov-commenter commented on PR #18710: URL: https://github.com/apache/hudi/pull/18710#issuecomment-4409909563 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18710?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `12.5%` with `14 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 48.29%. Comparing base ([`47bf4e4`](https://app.codecov.io/gh/apache/hudi/commit/47bf4e41342e4f1dab26a7fb1489f278fbd1226c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`fd52f6e`](https://app.codecov.io/gh/apache/hudi/commit/fd52f6e7d0965171258da2795aa56cd5a1146323?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18710?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...rg/apache/hudi/metrics/MetricsReporterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18710?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetrics%2FMetricsReporterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvbWV0cmljcy9NZXRyaWNzUmVwb3J0ZXJGYWN0b3J5LmphdmE=) | 0.00% | [14 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18710?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | > :exclamation: There is a different number of reports uploaded between BASE (47bf4e4) and HEAD (fd52f6e). Click for more details. > > HEAD has 27 uploads less than BASE > >| Flag | BASE (47bf4e4) | HEAD (fd52f6e) | >|--|--|--| >|spark-scala-tests|12|4| >|spark-java-tests|18|1| >|common-and-other-modules|1|0| >|utilities|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18710 +/- ## = - Coverage 68.14% 48.29% -19.86% + Complexity2907716882-12195 = Files 2522 2028 -494 Lines141177 114648-26529 Branches 1751414688 -2826 = - Hits 9620855367-40841 - Misses3706153272+16211 + Partials 7908 6009 -1899 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18710/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18710/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18710/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.97% <12.50%> (-0.03%)` | :arrow_down: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18710/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.34% <12.50%> (-0.02%)` | :arrow_down: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18710/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.09% <12.50%> (-15.91%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18710/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.91% <12.50%> (-12.00%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18710/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18710?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_sourc
Re: [PR] feat: support customized metrics reporter [hudi]
codecov-commenter commented on PR #18710: URL: https://github.com/apache/hudi/pull/18710#issuecomment-4409917515 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18710?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `12.5%` with `14 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 48.33%. Comparing base ([`47bf4e4`](https://app.codecov.io/gh/apache/hudi/commit/47bf4e41342e4f1dab26a7fb1489f278fbd1226c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`fd52f6e`](https://app.codecov.io/gh/apache/hudi/commit/fd52f6e7d0965171258da2795aa56cd5a1146323?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18710?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...rg/apache/hudi/metrics/MetricsReporterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18710?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetrics%2FMetricsReporterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvbWV0cmljcy9NZXRyaWNzUmVwb3J0ZXJGYWN0b3J5LmphdmE=) | 0.00% | [14 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18710?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | > :exclamation: There is a different number of reports uploaded between BASE (47bf4e4) and HEAD (fd52f6e). Click for more details. > > HEAD has 25 uploads less than BASE > >| Flag | BASE (47bf4e4) | HEAD (fd52f6e) | >|--|--|--| >|spark-scala-tests|12|5| >|spark-java-tests|18|2| >|common-and-other-modules|1|0| >|utilities|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18710 +/- ## = - Coverage 68.14% 48.33% -19.81% + Complexity2907716896-12181 = Files 2522 2028 -494 Lines141177 114653-26524 Branches 1751414694 -2820 = - Hits 9620855420-40788 - Misses3706153233+16172 + Partials 7908 6000 -1908 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18710/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18710/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18710/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.97% <12.50%> (-0.03%)` | :arrow_down: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18710/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.34% <12.50%> (-0.02%)` | :arrow_down: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18710/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.71% <12.50%> (-16.29%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18710/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.91% <12.50%> (-11.99%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18710/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18710?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_sourc
Re: [PR] feat: support customized metrics reporter [hudi]
codecov-commenter commented on PR #18710: URL: https://github.com/apache/hudi/pull/18710#issuecomment-4409912485 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18710?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `12.5%` with `14 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 48.29%. Comparing base ([`47bf4e4`](https://app.codecov.io/gh/apache/hudi/commit/47bf4e41342e4f1dab26a7fb1489f278fbd1226c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`fd52f6e`](https://app.codecov.io/gh/apache/hudi/commit/fd52f6e7d0965171258da2795aa56cd5a1146323?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18710?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...rg/apache/hudi/metrics/MetricsReporterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18710?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetrics%2FMetricsReporterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvbWV0cmljcy9NZXRyaWNzUmVwb3J0ZXJGYWN0b3J5LmphdmE=) | 0.00% | [14 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18710?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | > :exclamation: There is a different number of reports uploaded between BASE (47bf4e4) and HEAD (fd52f6e). Click for more details. > > HEAD has 27 uploads less than BASE > >| Flag | BASE (47bf4e4) | HEAD (fd52f6e) | >|--|--|--| >|spark-scala-tests|12|4| >|spark-java-tests|18|1| >|common-and-other-modules|1|0| >|utilities|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18710 +/- ## = - Coverage 68.14% 48.29% -19.86% + Complexity2907716882-12195 = Files 2522 2028 -494 Lines141177 114648-26529 Branches 1751414688 -2826 = - Hits 9620855367-40841 - Misses3706153272+16211 + Partials 7908 6009 -1899 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18710/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18710/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18710/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.97% <12.50%> (-0.03%)` | :arrow_down: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18710/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.34% <12.50%> (-0.02%)` | :arrow_down: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18710/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.09% <12.50%> (-15.91%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18710/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.91% <12.50%> (-12.00%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18710/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18710?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_sourc
Re: [PR] feat: support customized metrics reporter [hudi]
codecov-commenter commented on PR #18710: URL: https://github.com/apache/hudi/pull/18710#issuecomment-4409891960 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18710?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `12.5%` with `14 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 46.42%. Comparing base ([`47bf4e4`](https://app.codecov.io/gh/apache/hudi/commit/47bf4e41342e4f1dab26a7fb1489f278fbd1226c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`fd52f6e`](https://app.codecov.io/gh/apache/hudi/commit/fd52f6e7d0965171258da2795aa56cd5a1146323?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18710?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...rg/apache/hudi/metrics/MetricsReporterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18710?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetrics%2FMetricsReporterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvbWV0cmljcy9NZXRyaWNzUmVwb3J0ZXJGYWN0b3J5LmphdmE=) | 0.00% | [14 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18710?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | > :exclamation: There is a different number of reports uploaded between BASE (47bf4e4) and HEAD (fd52f6e). Click for more details. > > HEAD has 30 uploads less than BASE > >| Flag | BASE (47bf4e4) | HEAD (fd52f6e) | >|--|--|--| >|spark-scala-tests|12|2| >|spark-java-tests|18|0| >|common-and-other-modules|1|0| >|utilities|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18710 +/- ## = - Coverage 68.14% 46.42% -21.73% + Complexity2907715515-13562 = Files 2522 1981 -541 Lines141177 109634-31543 Branches 1751413617 -3897 = - Hits 9620850896-45312 - Misses3706153342+16281 + Partials 7908 5396 -2512 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18710/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18710/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18710/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.97% <12.50%> (-0.03%)` | :arrow_down: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18710/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.34% <12.50%> (-0.02%)` | :arrow_down: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18710/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18710/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.14% <12.50%> (-11.77%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18710/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18710?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_camp
Re: [PR] feat: support customized metrics reporter [hudi]
codecov-commenter commented on PR #18710: URL: https://github.com/apache/hudi/pull/18710#issuecomment-4409871973 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18710?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `12.5%` with `14 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 46.81%. Comparing base ([`47bf4e4`](https://app.codecov.io/gh/apache/hudi/commit/47bf4e41342e4f1dab26a7fb1489f278fbd1226c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`fd52f6e`](https://app.codecov.io/gh/apache/hudi/commit/fd52f6e7d0965171258da2795aa56cd5a1146323?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18710?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...rg/apache/hudi/metrics/MetricsReporterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18710?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetrics%2FMetricsReporterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvbWV0cmljcy9NZXRyaWNzUmVwb3J0ZXJGYWN0b3J5LmphdmE=) | 0.00% | [14 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18710?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | > :exclamation: There is a different number of reports uploaded between BASE (47bf4e4) and HEAD (fd52f6e). Click for more details. > > HEAD has 31 uploads less than BASE > >| Flag | BASE (47bf4e4) | HEAD (fd52f6e) | >|--|--|--| >|spark-scala-tests|12|1| >|spark-java-tests|18|0| >|common-and-other-modules|1|0| >|utilities|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18710 +/- ## = - Coverage 68.14% 46.81% -21.34% + Complexity2907715294-13783 = Files 2522 1964 -558 Lines141177 107176-34001 Branches 1751413002 -4512 = - Hits 9620850171-46037 - Misses3706151760+14699 + Partials 7908 5245 -2663 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18710/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18710/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18710/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.97% <12.50%> (-0.03%)` | :arrow_down: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18710/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.34% <12.50%> (-0.02%)` | :arrow_down: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18710/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18710/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.20% <12.50%> (-11.71%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18710/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18710?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_camp
Re: [PR] feat: support customized metrics reporter [hudi]
codecov-commenter commented on PR #18710: URL: https://github.com/apache/hudi/pull/18710#issuecomment-4409730688 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18710?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `12.5%` with `14 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 44.97%. Comparing base ([`47bf4e4`](https://app.codecov.io/gh/apache/hudi/commit/47bf4e41342e4f1dab26a7fb1489f278fbd1226c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`fd52f6e`](https://app.codecov.io/gh/apache/hudi/commit/fd52f6e7d0965171258da2795aa56cd5a1146323?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18710?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...rg/apache/hudi/metrics/MetricsReporterFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18710?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetrics%2FMetricsReporterFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvbWV0cmljcy9NZXRyaWNzUmVwb3J0ZXJGYWN0b3J5LmphdmE=) | 0.00% | [14 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18710?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | > :exclamation: There is a different number of reports uploaded between BASE (47bf4e4) and HEAD (fd52f6e). Click for more details. > > HEAD has 33 uploads less than BASE > >| Flag | BASE (47bf4e4) | HEAD (fd52f6e) | >|--|--|--| >|spark-client-hadoop-common|1|0| >|spark-scala-tests|12|0| >|spark-java-tests|18|0| >|common-and-other-modules|1|0| >|utilities|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18710 +/- ## = - Coverage 68.14% 44.97% -23.17% + Complexity29077 8564-20513 = Files 2522 1202 -1320 Lines14117762811-78366 Branches 17514 6810-10704 = - Hits 9620828252-67956 + Misses3706131442 -5619 + Partials 7908 3117 -4791 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18710/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18710/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18710/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.97% <12.50%> (-0.03%)` | :arrow_down: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18710/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18710/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18710/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18710/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18710?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
Re: [PR] feat: support customized metrics reporter [hudi]
hudi-bot commented on PR #18710: URL: https://github.com/apache/hudi/pull/18710#issuecomment-4409705898 ## CI report: * fd52f6e7d0965171258da2795aa56cd5a1146323 Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13904) Bot commands @hudi-bot supports the following commands: - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] feat: support customized metrics reporter [hudi]
hudi-bot commented on PR #18710: URL: https://github.com/apache/hudi/pull/18710#issuecomment-4409681330 ## CI report: * fd52f6e7d0965171258da2795aa56cd5a1146323 UNKNOWN Bot commands @hudi-bot supports the following commands: - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
