Re: [PR] fix(flink): Handle bootstrap write metadata correctly after job resca… [hudi]
danny0405 merged PR #18485: URL: https://github.com/apache/hudi/pull/18485 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] fix(flink): Handle bootstrap write metadata correctly after job resca… [hudi]
codecov-commenter commented on PR #18485: URL: https://github.com/apache/hudi/pull/18485#issuecomment-4213086152 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18485?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 68.67%. Comparing base ([`0591933`](https://app.codecov.io/gh/apache/hudi/commit/0591933bc237ab9adb616f6961bbd780deff25a2?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`8deb66b`](https://app.codecov.io/gh/apache/hudi/commit/8deb66b18e035553493b74157c54128f6ce26635?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 6 commits behind head on master. Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18485 +/- ## - Coverage 68.77% 68.67% -0.10% + Complexity2811728087 -30 Files 2452 2459 +7 Lines135033 135137 +104 Branches 1637616384 +8 - Hits 9286992810 -59 - Misses3480135008 +207 + Partials 7363 7319 -44 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.53% <100.00%> (+0.10%)` | :arrow_up: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.84% <ø> (-0.03%)` | :arrow_down: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.43% <ø> (+0.03%)` | :arrow_up: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.88% <ø> (+0.01%)` | :arrow_up: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.30% <ø> (-0.20%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.20% <ø> (-0.01%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18485?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [.../hudi/sink/common/AbstractStreamWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18485?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fcommon%2FAbstractStreamWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9jb21tb24vQWJzdHJhY3RTdHJlYW1Xcml0ZUZ1bmN0aW9uLmphdmE=) | `90.00% <100.00%> (+0.25%)` | :arrow_up: | | [...org/apache/hudi/sink/event/WriteMetadataEvent.java](https://app.codecov.io/gh/apache/hudi/pull/18485?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fevent%2FWriteMetadataEvent.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9ldmVudC9Xcml0ZU1ldGFkYXRhRXZlbnQuamF2YQ==) | `94.20% <100.00%> (+0.35%)` | :arrow_up: | ... and [68
Re: [PR] fix(flink): Handle bootstrap write metadata correctly after job resca… [hudi]
hudi-bot commented on PR #18485: URL: https://github.com/apache/hudi/pull/18485#issuecomment-4213045646 ## CI report: * 8deb66b18e035553493b74157c54128f6ce26635 Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13182) Bot commands @hudi-bot supports the following commands: - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] fix(flink): Handle bootstrap write metadata correctly after job resca… [hudi]
codecov-commenter commented on PR #18485: URL: https://github.com/apache/hudi/pull/18485#issuecomment-4213005946 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18485?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 68.67%. Comparing base ([`0591933`](https://app.codecov.io/gh/apache/hudi/commit/0591933bc237ab9adb616f6961bbd780deff25a2?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`8deb66b`](https://app.codecov.io/gh/apache/hudi/commit/8deb66b18e035553493b74157c54128f6ce26635?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 6 commits behind head on master. Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18485 +/- ## - Coverage 68.77% 68.67% -0.10% + Complexity2811728087 -30 Files 2452 2459 +7 Lines135033 135137 +104 Branches 1637616384 +8 - Hits 9286992810 -59 - Misses3480135008 +207 + Partials 7363 7319 -44 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.53% <100.00%> (+0.10%)` | :arrow_up: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.84% <ø> (-0.03%)` | :arrow_down: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.43% <ø> (+0.03%)` | :arrow_up: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.85% <ø> (-0.02%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.30% <ø> (-0.20%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.20% <ø> (-0.01%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18485?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [.../hudi/sink/common/AbstractStreamWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18485?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fcommon%2FAbstractStreamWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9jb21tb24vQWJzdHJhY3RTdHJlYW1Xcml0ZUZ1bmN0aW9uLmphdmE=) | `90.00% <100.00%> (+0.25%)` | :arrow_up: | | [...org/apache/hudi/sink/event/WriteMetadataEvent.java](https://app.codecov.io/gh/apache/hudi/pull/18485?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fevent%2FWriteMetadataEvent.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9ldmVudC9Xcml0ZU1ldGFkYXRhRXZlbnQuamF2YQ==) | `94.20% <100.00%> (+0.35%)` | :arrow_up: | ... and [
Re: [PR] fix(flink): Handle bootstrap write metadata correctly after job resca… [hudi]
codecov-commenter commented on PR #18485: URL: https://github.com/apache/hudi/pull/18485#issuecomment-4212940445 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18485?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 68.67%. Comparing base ([`0591933`](https://app.codecov.io/gh/apache/hudi/commit/0591933bc237ab9adb616f6961bbd780deff25a2?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`8deb66b`](https://app.codecov.io/gh/apache/hudi/commit/8deb66b18e035553493b74157c54128f6ce26635?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 6 commits behind head on master. Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18485 +/- ## - Coverage 68.77% 68.67% -0.10% + Complexity2811728086 -31 Files 2452 2459 +7 Lines135033 135137 +104 Branches 1637616384 +8 - Hits 9286992806 -63 - Misses3480135011 +210 + Partials 7363 7320 -43 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.53% <100.00%> (+0.10%)` | :arrow_up: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.84% <ø> (-0.03%)` | :arrow_down: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.43% <ø> (+0.03%)` | :arrow_up: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.82% <ø> (-0.05%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.30% <ø> (-0.20%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.20% <ø> (-0.01%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18485?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [.../hudi/sink/common/AbstractStreamWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18485?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fcommon%2FAbstractStreamWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9jb21tb24vQWJzdHJhY3RTdHJlYW1Xcml0ZUZ1bmN0aW9uLmphdmE=) | `90.00% <100.00%> (+0.25%)` | :arrow_up: | | [...org/apache/hudi/sink/event/WriteMetadataEvent.java](https://app.codecov.io/gh/apache/hudi/pull/18485?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fevent%2FWriteMetadataEvent.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9ldmVudC9Xcml0ZU1ldGFkYXRhRXZlbnQuamF2YQ==) | `94.20% <100.00%> (+0.35%)` | :arrow_up: | ... and [
Re: [PR] fix(flink): Handle bootstrap write metadata correctly after job resca… [hudi]
codecov-commenter commented on PR #18485: URL: https://github.com/apache/hudi/pull/18485#issuecomment-4212920276 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18485?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 68.66%. Comparing base ([`0591933`](https://app.codecov.io/gh/apache/hudi/commit/0591933bc237ab9adb616f6961bbd780deff25a2?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`8deb66b`](https://app.codecov.io/gh/apache/hudi/commit/8deb66b18e035553493b74157c54128f6ce26635?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 6 commits behind head on master. Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18485 +/- ## - Coverage 68.77% 68.66% -0.11% + Complexity2811728083 -34 Files 2452 2459 +7 Lines135033 135137 +104 Branches 1637616384 +8 - Hits 9286992796 -73 - Misses3480135020 +219 + Partials 7363 7321 -42 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.53% <100.00%> (+0.10%)` | :arrow_up: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.84% <ø> (-0.03%)` | :arrow_down: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.43% <ø> (+0.03%)` | :arrow_up: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.78% <ø> (-0.09%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.30% <ø> (-0.20%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.20% <ø> (-0.01%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18485?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [.../hudi/sink/common/AbstractStreamWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18485?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fcommon%2FAbstractStreamWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9jb21tb24vQWJzdHJhY3RTdHJlYW1Xcml0ZUZ1bmN0aW9uLmphdmE=) | `90.00% <100.00%> (+0.25%)` | :arrow_up: | | [...org/apache/hudi/sink/event/WriteMetadataEvent.java](https://app.codecov.io/gh/apache/hudi/pull/18485?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fevent%2FWriteMetadataEvent.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9ldmVudC9Xcml0ZU1ldGFkYXRhRXZlbnQuamF2YQ==) | `94.20% <100.00%> (+0.35%)` | :arrow_up: | ... and [
Re: [PR] fix(flink): Handle bootstrap write metadata correctly after job resca… [hudi]
codecov-commenter commented on PR #18485: URL: https://github.com/apache/hudi/pull/18485#issuecomment-4212919250 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18485?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 68.66%. Comparing base ([`0591933`](https://app.codecov.io/gh/apache/hudi/commit/0591933bc237ab9adb616f6961bbd780deff25a2?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`8deb66b`](https://app.codecov.io/gh/apache/hudi/commit/8deb66b18e035553493b74157c54128f6ce26635?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 6 commits behind head on master. Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18485 +/- ## - Coverage 68.77% 68.66% -0.11% + Complexity2811728083 -34 Files 2452 2459 +7 Lines135033 135137 +104 Branches 1637616384 +8 - Hits 9286992796 -73 - Misses3480135020 +219 + Partials 7363 7321 -42 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.53% <100.00%> (+0.10%)` | :arrow_up: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.84% <ø> (-0.03%)` | :arrow_down: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.43% <ø> (+0.03%)` | :arrow_up: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.78% <ø> (-0.09%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.30% <ø> (-0.20%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.20% <ø> (-0.01%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18485?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [.../hudi/sink/common/AbstractStreamWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18485?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fcommon%2FAbstractStreamWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9jb21tb24vQWJzdHJhY3RTdHJlYW1Xcml0ZUZ1bmN0aW9uLmphdmE=) | `90.00% <100.00%> (+0.25%)` | :arrow_up: | | [...org/apache/hudi/sink/event/WriteMetadataEvent.java](https://app.codecov.io/gh/apache/hudi/pull/18485?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fevent%2FWriteMetadataEvent.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9ldmVudC9Xcml0ZU1ldGFkYXRhRXZlbnQuamF2YQ==) | `94.20% <100.00%> (+0.35%)` | :arrow_up: | ... and [
Re: [PR] fix(flink): Handle bootstrap write metadata correctly after job resca… [hudi]
codecov-commenter commented on PR #18485: URL: https://github.com/apache/hudi/pull/18485#issuecomment-4212907753 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18485?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 67.61%. Comparing base ([`0591933`](https://app.codecov.io/gh/apache/hudi/commit/0591933bc237ab9adb616f6961bbd780deff25a2?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`8deb66b`](https://app.codecov.io/gh/apache/hudi/commit/8deb66b18e035553493b74157c54128f6ce26635?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 6 commits behind head on master. Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18485 +/- ## - Coverage 68.77% 67.61% -1.17% + Complexity2811727610 -507 Files 2452 2459 +7 Lines135033 135137 +104 Branches 1637616384 +8 - Hits 9286991370-1499 - Misses3480136444+1643 + Partials 7363 7323 -40 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.53% <100.00%> (+0.10%)` | :arrow_up: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.84% <ø> (-0.03%)` | :arrow_down: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.43% <ø> (+0.03%)` | :arrow_up: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.10% <ø> (-3.77%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.76% <ø> (+0.26%)` | :arrow_up: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.20% <ø> (-0.01%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18485?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [.../hudi/sink/common/AbstractStreamWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18485?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fcommon%2FAbstractStreamWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9jb21tb24vQWJzdHJhY3RTdHJlYW1Xcml0ZUZ1bmN0aW9uLmphdmE=) | `90.00% <100.00%> (+0.25%)` | :arrow_up: | | [...org/apache/hudi/sink/event/WriteMetadataEvent.java](https://app.codecov.io/gh/apache/hudi/pull/18485?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fevent%2FWriteMetadataEvent.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9ldmVudC9Xcml0ZU1ldGFkYXRhRXZlbnQuamF2YQ==) | `94.20% <100.00%> (+0.35%)` | :arrow_up: | ... and [21
Re: [PR] fix(flink): Handle bootstrap write metadata correctly after job resca… [hudi]
codecov-commenter commented on PR #18485: URL: https://github.com/apache/hudi/pull/18485#issuecomment-4212895243 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18485?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 67.60%. Comparing base ([`0591933`](https://app.codecov.io/gh/apache/hudi/commit/0591933bc237ab9adb616f6961bbd780deff25a2?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`8deb66b`](https://app.codecov.io/gh/apache/hudi/commit/8deb66b18e035553493b74157c54128f6ce26635?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 6 commits behind head on master. Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18485 +/- ## - Coverage 68.77% 67.60% -1.17% + Complexity2811727610 -507 Files 2452 2459 +7 Lines135033 135137 +104 Branches 1637616384 +8 - Hits 9286991365-1504 - Misses3480136446+1645 + Partials 7363 7326 -37 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.53% <100.00%> (+0.10%)` | :arrow_up: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.84% <ø> (-0.03%)` | :arrow_down: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.43% <ø> (+0.03%)` | :arrow_up: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.10% <ø> (-3.77%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.76% <ø> (+0.25%)` | :arrow_up: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.20% <ø> (-0.01%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18485?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [.../hudi/sink/common/AbstractStreamWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18485?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fcommon%2FAbstractStreamWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9jb21tb24vQWJzdHJhY3RTdHJlYW1Xcml0ZUZ1bmN0aW9uLmphdmE=) | `90.00% <100.00%> (+0.25%)` | :arrow_up: | | [...org/apache/hudi/sink/event/WriteMetadataEvent.java](https://app.codecov.io/gh/apache/hudi/pull/18485?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fevent%2FWriteMetadataEvent.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9ldmVudC9Xcml0ZU1ldGFkYXRhRXZlbnQuamF2YQ==) | `94.20% <100.00%> (+0.35%)` | :arrow_up: | ... and [21
Re: [PR] fix(flink): Handle bootstrap write metadata correctly after job resca… [hudi]
codecov-commenter commented on PR #18485: URL: https://github.com/apache/hudi/pull/18485#issuecomment-421287 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18485?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 65.94%. Comparing base ([`0591933`](https://app.codecov.io/gh/apache/hudi/commit/0591933bc237ab9adb616f6961bbd780deff25a2?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`8deb66b`](https://app.codecov.io/gh/apache/hudi/commit/8deb66b18e035553493b74157c54128f6ce26635?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 6 commits behind head on master. Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18485 +/- ## - Coverage 68.77% 65.94% -2.83% + Complexity2811726924-1193 Files 2452 2459 +7 Lines135033 135137 +104 Branches 1637616384 +8 - Hits 9286989118-3751 - Misses3480138593+3792 - Partials 7363 7426 +63 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.53% <100.00%> (+0.10%)` | :arrow_up: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.84% <ø> (-0.03%)` | :arrow_down: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.43% <ø> (+0.03%)` | :arrow_up: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.34% <ø> (-16.53%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.76% <ø> (+0.25%)` | :arrow_up: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.20% <ø> (-0.01%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18485?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [.../hudi/sink/common/AbstractStreamWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18485?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fcommon%2FAbstractStreamWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9jb21tb24vQWJzdHJhY3RTdHJlYW1Xcml0ZUZ1bmN0aW9uLmphdmE=) | `90.00% <100.00%> (+0.25%)` | :arrow_up: | | [...org/apache/hudi/sink/event/WriteMetadataEvent.java](https://app.codecov.io/gh/apache/hudi/pull/18485?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fevent%2FWriteMetadataEvent.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9ldmVudC9Xcml0ZU1ldGFkYXRhRXZlbnQuamF2YQ==) | `94.20% <100.00%> (+0.35%)` | :arrow_up: | ... and [3
Re: [PR] fix(flink): Handle bootstrap write metadata correctly after job resca… [hudi]
codecov-commenter commented on PR #18485: URL: https://github.com/apache/hudi/pull/18485#issuecomment-4212875146 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18485?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 65.67%. Comparing base ([`0591933`](https://app.codecov.io/gh/apache/hudi/commit/0591933bc237ab9adb616f6961bbd780deff25a2?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`8deb66b`](https://app.codecov.io/gh/apache/hudi/commit/8deb66b18e035553493b74157c54128f6ce26635?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 6 commits behind head on master. Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18485 +/- ## - Coverage 68.77% 65.67% -3.10% + Complexity2811726807-1310 Files 2452 2459 +7 Lines135033 135123 +90 Branches 1637616382 +6 - Hits 9286988745-4124 - Misses3480139003+4202 - Partials 7363 7375 +12 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.53% <100.00%> (+0.10%)` | :arrow_up: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.84% <ø> (-0.03%)` | :arrow_down: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.43% <ø> (+0.03%)` | :arrow_up: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.34% <ø> (-16.53%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `46.11% <ø> (+0.61%)` | :arrow_up: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.20% <ø> (-0.01%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18485?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [.../hudi/sink/common/AbstractStreamWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18485?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fcommon%2FAbstractStreamWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9jb21tb24vQWJzdHJhY3RTdHJlYW1Xcml0ZUZ1bmN0aW9uLmphdmE=) | `90.00% <100.00%> (+0.25%)` | :arrow_up: | | [...org/apache/hudi/sink/event/WriteMetadataEvent.java](https://app.codecov.io/gh/apache/hudi/pull/18485?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fevent%2FWriteMetadataEvent.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9ldmVudC9Xcml0ZU1ldGFkYXRhRXZlbnQuamF2YQ==) | `94.20% <100.00%> (+0.35%)` | :arrow_up: | ... and [4
Re: [PR] fix(flink): Handle bootstrap write metadata correctly after job resca… [hudi]
codecov-commenter commented on PR #18485: URL: https://github.com/apache/hudi/pull/18485#issuecomment-4212868844 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18485?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 65.55%. Comparing base ([`0591933`](https://app.codecov.io/gh/apache/hudi/commit/0591933bc237ab9adb616f6961bbd780deff25a2?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`8deb66b`](https://app.codecov.io/gh/apache/hudi/commit/8deb66b18e035553493b74157c54128f6ce26635?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 6 commits behind head on master. Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18485 +/- ## - Coverage 68.77% 65.55% -3.22% + Complexity2811726740-1377 Files 2452 2459 +7 Lines135033 135123 +90 Branches 1637616382 +6 - Hits 9286988585-4284 - Misses3480139210+4409 + Partials 7363 7328 -35 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.53% <100.00%> (+0.10%)` | :arrow_up: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.84% <ø> (-0.03%)` | :arrow_down: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.43% <ø> (+0.03%)` | :arrow_up: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.34% <ø> (-16.53%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.93% <ø> (+0.43%)` | :arrow_up: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.20% <ø> (-0.01%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18485?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [.../hudi/sink/common/AbstractStreamWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18485?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fcommon%2FAbstractStreamWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9jb21tb24vQWJzdHJhY3RTdHJlYW1Xcml0ZUZ1bmN0aW9uLmphdmE=) | `90.00% <100.00%> (+0.25%)` | :arrow_up: | | [...org/apache/hudi/sink/event/WriteMetadataEvent.java](https://app.codecov.io/gh/apache/hudi/pull/18485?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fevent%2FWriteMetadataEvent.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9ldmVudC9Xcml0ZU1ldGFkYXRhRXZlbnQuamF2YQ==) | `94.20% <100.00%> (+0.35%)` | :arrow_up: | ... and [4
Re: [PR] fix(flink): Handle bootstrap write metadata correctly after job resca… [hudi]
codecov-commenter commented on PR #18485: URL: https://github.com/apache/hudi/pull/18485#issuecomment-4212846920 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18485?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 60.97%. Comparing base ([`0591933`](https://app.codecov.io/gh/apache/hudi/commit/0591933bc237ab9adb616f6961bbd780deff25a2?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`8deb66b`](https://app.codecov.io/gh/apache/hudi/commit/8deb66b18e035553493b74157c54128f6ce26635?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 6 commits behind head on master. > :exclamation: There is a different number of reports uploaded between BASE (0591933) and HEAD (8deb66b). Click for more details. > > HEAD has 18 uploads less than BASE > >| Flag | BASE (0591933) | HEAD (8deb66b) | >|--|--|--| >|spark-scala-tests|10|2| >|spark-java-tests|15|5| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18485 +/- ## - Coverage 68.77% 60.97% -7.81% + Complexity2811724857-3260 Files 2452 2459 +7 Lines135033 135123 +90 Branches 1637616382 +6 - Hits 9286982385 -10484 - Misses3480145871 +11070 + Partials 7363 6867 -496 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.53% <100.00%> (+0.10%)` | :arrow_up: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.84% <ø> (-0.03%)` | :arrow_down: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.43% <ø> (+0.03%)` | :arrow_up: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.34% <ø> (-16.53%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.95% <ø> (-12.55%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.20% <ø> (-0.01%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18485?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [.../hudi/sink/common/AbstractStreamWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18485?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fcommon%2FAbstractStreamWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9jb21tb24vQWJzdHJhY3RTdHJlYW1Xcml0ZUZ1bmN0aW9uLmphdmE=) | `90.00% <100.00%> (+0.25%)` | :arrow_up: | | [...org/apache/hudi/sink/event/WriteMetadataEvent.java](https://app.codecov.io/gh/apache/hudi/pull/18485?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fevent%2
Re: [PR] fix(flink): Handle bootstrap write metadata correctly after job resca… [hudi]
codecov-commenter commented on PR #18485: URL: https://github.com/apache/hudi/pull/18485#issuecomment-4212840841 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18485?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 58.46%. Comparing base ([`0591933`](https://app.codecov.io/gh/apache/hudi/commit/0591933bc237ab9adb616f6961bbd780deff25a2?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`8deb66b`](https://app.codecov.io/gh/apache/hudi/commit/8deb66b18e035553493b74157c54128f6ce26635?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 6 commits behind head on master. > :exclamation: There is a different number of reports uploaded between BASE (0591933) and HEAD (8deb66b). Click for more details. > > HEAD has 19 uploads less than BASE > >| Flag | BASE (0591933) | HEAD (8deb66b) | >|--|--|--| >|spark-scala-tests|10|2| >|spark-java-tests|15|5| >|utilities|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18485 +/- ## = - Coverage 68.77% 58.46% -10.32% + Complexity2811723890 -4227 = Files 2452 2459+7 Lines135033 135123 +90 Branches 1637616382+6 = - Hits 9286978995-13874 - Misses3480149414+14613 + Partials 7363 6714 -649 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.53% <100.00%> (+0.10%)` | :arrow_up: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.84% <ø> (-0.03%)` | :arrow_down: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.43% <ø> (+0.03%)` | :arrow_up: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.34% <ø> (-16.53%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.95% <ø> (-12.55%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18485?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [.../hudi/sink/common/AbstractStreamWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18485?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fcommon%2FAbstractStreamWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9jb21tb24vQWJzdHJhY3RTdHJlYW1Xcml0ZUZ1bmN0aW9uLmphdmE=) | `90.00% <100.00%> (+0.25%)` | :arrow_up: | | [...org/apache/hudi/sink/event/WriteMetadataEvent.java](https://app.codecov.io/gh/apache/hudi/pull/18485?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fevent
Re: [PR] fix(flink): Handle bootstrap write metadata correctly after job resca… [hudi]
codecov-commenter commented on PR #18485: URL: https://github.com/apache/hudi/pull/18485#issuecomment-4212830863 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18485?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 58.46%. Comparing base ([`0591933`](https://app.codecov.io/gh/apache/hudi/commit/0591933bc237ab9adb616f6961bbd780deff25a2?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`8deb66b`](https://app.codecov.io/gh/apache/hudi/commit/8deb66b18e035553493b74157c54128f6ce26635?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 6 commits behind head on master. > :exclamation: There is a different number of reports uploaded between BASE (0591933) and HEAD (8deb66b). Click for more details. > > HEAD has 20 uploads less than BASE > >| Flag | BASE (0591933) | HEAD (8deb66b) | >|--|--|--| >|spark-scala-tests|10|2| >|spark-java-tests|15|4| >|utilities|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18485 +/- ## = - Coverage 68.77% 58.46% -10.32% + Complexity2811723890 -4227 = Files 2452 2459+7 Lines135033 135123 +90 Branches 1637616382+6 = - Hits 9286978994-13875 - Misses3480149414+14613 + Partials 7363 6715 -648 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.53% <100.00%> (+0.10%)` | :arrow_up: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.84% <ø> (-0.03%)` | :arrow_down: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.43% <ø> (+0.03%)` | :arrow_up: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.34% <ø> (-16.53%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.95% <ø> (-12.55%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18485?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [.../hudi/sink/common/AbstractStreamWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18485?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fcommon%2FAbstractStreamWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9jb21tb24vQWJzdHJhY3RTdHJlYW1Xcml0ZUZ1bmN0aW9uLmphdmE=) | `90.00% <100.00%> (+0.25%)` | :arrow_up: | | [...org/apache/hudi/sink/event/WriteMetadataEvent.java](https://app.codecov.io/gh/apache/hudi/pull/18485?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fevent
Re: [PR] fix(flink): Handle bootstrap write metadata correctly after job resca… [hudi]
codecov-commenter commented on PR #18485: URL: https://github.com/apache/hudi/pull/18485#issuecomment-4212822977 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18485?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 47.61%. Comparing base ([`0591933`](https://app.codecov.io/gh/apache/hudi/commit/0591933bc237ab9adb616f6961bbd780deff25a2?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`8deb66b`](https://app.codecov.io/gh/apache/hudi/commit/8deb66b18e035553493b74157c54128f6ce26635?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 6 commits behind head on master. > :exclamation: There is a different number of reports uploaded between BASE (0591933) and HEAD (8deb66b). Click for more details. > > HEAD has 21 uploads less than BASE > >| Flag | BASE (0591933) | HEAD (8deb66b) | >|--|--|--| >|spark-scala-tests|10|2| >|spark-java-tests|15|4| >|common-and-other-modules|1|0| >|utilities|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18485 +/- ## = - Coverage 68.77% 47.61% -21.16% + Complexity2811716272-11845 = Files 2452 2004 -448 Lines135033 112141-22892 Branches 1637614235 -2141 = - Hits 9286953396-39473 - Misses3480153208+18407 + Partials 7363 5537 -1826 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.84% <ø> (-0.03%)` | :arrow_down: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.43% <ø> (+0.03%)` | :arrow_up: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.34% <ø> (-16.53%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.95% <ø> (-12.55%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. [see 1532 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18485/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) :rocket: New features to boost your workflow: - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] fix(flink): Handle bootstrap write metadata correctly after job resca… [hudi]
codecov-commenter commented on PR #18485: URL: https://github.com/apache/hudi/pull/18485#issuecomment-4212819066 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18485?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 48.35%. Comparing base ([`0591933`](https://app.codecov.io/gh/apache/hudi/commit/0591933bc237ab9adb616f6961bbd780deff25a2?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`8deb66b`](https://app.codecov.io/gh/apache/hudi/commit/8deb66b18e035553493b74157c54128f6ce26635?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 6 commits behind head on master. > :exclamation: There is a different number of reports uploaded between BASE (0591933) and HEAD (8deb66b). Click for more details. > > HEAD has 22 uploads less than BASE > >| Flag | BASE (0591933) | HEAD (8deb66b) | >|--|--|--| >|spark-scala-tests|10|2| >|spark-java-tests|15|3| >|common-and-other-modules|1|0| >|utilities|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18485 +/- ## = - Coverage 68.77% 48.35% -20.42% + Complexity2811716196-11921 = Files 2452 1986 -466 Lines135033 109766-25267 Branches 1637613729 -2647 = - Hits 9286953080-39789 - Misses3480151230+16429 + Partials 7363 5456 -1907 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.84% <ø> (-0.03%)` | :arrow_down: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.43% <ø> (+0.03%)` | :arrow_up: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.75% <ø> (-16.12%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.95% <ø> (-12.55%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. [see 1540 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18485/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) :rocket: New features to boost your workflow: - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] fix(flink): Handle bootstrap write metadata correctly after job resca… [hudi]
codecov-commenter commented on PR #18485: URL: https://github.com/apache/hudi/pull/18485#issuecomment-421288 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18485?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 49.11%. Comparing base ([`0591933`](https://app.codecov.io/gh/apache/hudi/commit/0591933bc237ab9adb616f6961bbd780deff25a2?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`8deb66b`](https://app.codecov.io/gh/apache/hudi/commit/8deb66b18e035553493b74157c54128f6ce26635?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 6 commits behind head on master. > :exclamation: There is a different number of reports uploaded between BASE (0591933) and HEAD (8deb66b). Click for more details. > > HEAD has 23 uploads less than BASE > >| Flag | BASE (0591933) | HEAD (8deb66b) | >|--|--|--| >|spark-scala-tests|10|2| >|spark-java-tests|15|2| >|common-and-other-modules|1|0| >|utilities|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18485 +/- ## = - Coverage 68.77% 49.11% -19.66% + Complexity2811716124-11993 = Files 2452 1969 -483 Lines135033 107277-27756 Branches 1637613171 -3205 = - Hits 9286952693-40176 - Misses3480149191+14390 + Partials 7363 5393 -1970 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.84% <ø> (-0.03%)` | :arrow_down: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.43% <ø> (+0.03%)` | :arrow_up: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.14% <ø> (-15.73%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.95% <ø> (-12.55%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. [see 1567 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18485/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) :rocket: New features to boost your workflow: - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] fix(flink): Handle bootstrap write metadata correctly after job resca… [hudi]
codecov-commenter commented on PR #18485: URL: https://github.com/apache/hudi/pull/18485#issuecomment-4212806131 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18485?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 49.08%. Comparing base ([`0591933`](https://app.codecov.io/gh/apache/hudi/commit/0591933bc237ab9adb616f6961bbd780deff25a2?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`8deb66b`](https://app.codecov.io/gh/apache/hudi/commit/8deb66b18e035553493b74157c54128f6ce26635?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 6 commits behind head on master. > :exclamation: There is a different number of reports uploaded between BASE (0591933) and HEAD (8deb66b). Click for more details. > > HEAD has 24 uploads less than BASE > >| Flag | BASE (0591933) | HEAD (8deb66b) | >|--|--|--| >|spark-scala-tests|10|2| >|spark-java-tests|15|1| >|common-and-other-modules|1|0| >|utilities|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18485 +/- ## = - Coverage 68.77% 49.08% -19.70% + Complexity2811716110-12007 = Files 2452 1969 -483 Lines135033 107277-27756 Branches 1637613171 -3205 = - Hits 9286952653-40216 - Misses3480149226+14425 + Partials 7363 5398 -1965 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.84% <ø> (-0.03%)` | :arrow_down: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.43% <ø> (+0.03%)` | :arrow_up: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.56% <ø> (-15.31%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.95% <ø> (-12.55%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. [see 1569 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18485/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) :rocket: New features to boost your workflow: - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] fix(flink): Handle bootstrap write metadata correctly after job resca… [hudi]
codecov-commenter commented on PR #18485: URL: https://github.com/apache/hudi/pull/18485#issuecomment-4212803989 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18485?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 46.18%. Comparing base ([`0591933`](https://app.codecov.io/gh/apache/hudi/commit/0591933bc237ab9adb616f6961bbd780deff25a2?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`8deb66b`](https://app.codecov.io/gh/apache/hudi/commit/8deb66b18e035553493b74157c54128f6ce26635?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 6 commits behind head on master. > :exclamation: There is a different number of reports uploaded between BASE (0591933) and HEAD (8deb66b). Click for more details. > > HEAD has 25 uploads less than BASE > >| Flag | BASE (0591933) | HEAD (8deb66b) | >|--|--|--| >|spark-scala-tests|10|2| >|spark-java-tests|15|0| >|common-and-other-modules|1|0| >|utilities|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18485 +/- ## = - Coverage 68.77% 46.18% -22.60% + Complexity2811715203-12914 = Files 2452 1969 -483 Lines135033 107277-27756 Branches 1637613171 -3205 = - Hits 9286949544-43325 - Misses3480152548+17747 + Partials 7363 5185 -2178 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.84% <ø> (-0.03%)` | :arrow_down: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.43% <ø> (+0.03%)` | :arrow_up: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.95% <ø> (-12.55%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. [see 1615 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18485/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) :rocket: New features to boost your workflow: - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] fix(flink): Handle bootstrap write metadata correctly after job resca… [hudi]
codecov-commenter commented on PR #18485: URL: https://github.com/apache/hudi/pull/18485#issuecomment-4212791882 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18485?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 46.69%. Comparing base ([`0591933`](https://app.codecov.io/gh/apache/hudi/commit/0591933bc237ab9adb616f6961bbd780deff25a2?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`8deb66b`](https://app.codecov.io/gh/apache/hudi/commit/8deb66b18e035553493b74157c54128f6ce26635?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 6 commits behind head on master. > :exclamation: There is a different number of reports uploaded between BASE (0591933) and HEAD (8deb66b). Click for more details. > > HEAD has 26 uploads less than BASE > >| Flag | BASE (0591933) | HEAD (8deb66b) | >|--|--|--| >|spark-scala-tests|10|1| >|spark-java-tests|15|0| >|common-and-other-modules|1|0| >|utilities|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18485 +/- ## = - Coverage 68.77% 46.69% -22.09% + Complexity2811714988-13129 = Files 2452 1940 -512 Lines135033 104660-30373 Branches 1637612614 -3762 = - Hits 9286948866-44003 - Misses3480150773+15972 + Partials 7363 5021 -2342 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.84% <ø> (-0.03%)` | :arrow_down: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.43% <ø> (+0.03%)` | :arrow_up: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.08% <ø> (-12.42%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. [see 1631 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18485/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) :rocket: New features to boost your workflow: - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] fix(flink): Handle bootstrap write metadata correctly after job resca… [hudi]
codecov-commenter commented on PR #18485: URL: https://github.com/apache/hudi/pull/18485#issuecomment-4212772915 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18485?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 53.95%. Comparing base ([`0591933`](https://app.codecov.io/gh/apache/hudi/commit/0591933bc237ab9adb616f6961bbd780deff25a2?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`8deb66b`](https://app.codecov.io/gh/apache/hudi/commit/8deb66b18e035553493b74157c54128f6ce26635?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 6 commits behind head on master. > :exclamation: There is a different number of reports uploaded between BASE (0591933) and HEAD (8deb66b). Click for more details. > > HEAD has 27 uploads less than BASE > >| Flag | BASE (0591933) | HEAD (8deb66b) | >|--|--|--| >|spark-scala-tests|10|0| >|spark-java-tests|15|0| >|common-and-other-modules|1|0| >|utilities|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18485 +/- ## = - Coverage 68.77% 53.95% -14.83% + Complexity2811712274-15843 = Files 2452 1425 -1027 Lines13503370911-64122 Branches 16376 8000 -8376 = - Hits 9286938258-54611 + Misses3480129233 -5568 + Partials 7363 3420 -3943 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.84% <ø> (-0.03%)` | :arrow_down: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.43% <ø> (+0.03%)` | :arrow_up: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. [see 1806 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18485/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) :rocket: New features to boost your workflow: - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] fix(flink): Handle bootstrap write metadata correctly after job resca… [hudi]
codecov-commenter commented on PR #18485: URL: https://github.com/apache/hudi/pull/18485#issuecomment-4212645467 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18485?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 44.84%. Comparing base ([`0591933`](https://app.codecov.io/gh/apache/hudi/commit/0591933bc237ab9adb616f6961bbd780deff25a2?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`8deb66b`](https://app.codecov.io/gh/apache/hudi/commit/8deb66b18e035553493b74157c54128f6ce26635?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 6 commits behind head on master. > :exclamation: There is a different number of reports uploaded between BASE (0591933) and HEAD (8deb66b). Click for more details. > > HEAD has 28 uploads less than BASE > >| Flag | BASE (0591933) | HEAD (8deb66b) | >|--|--|--| >|spark-client-hadoop-common|1|0| >|spark-scala-tests|10|0| >|spark-java-tests|15|0| >|common-and-other-modules|1|0| >|utilities|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18485 +/- ## = - Coverage 68.77% 44.84% -23.93% + Complexity28117 8477-19640 = Files 2452 1196 -1256 Lines13503361923-73110 Branches 16376 6667 -9709 = - Hits 9286927771-65098 + Misses3480131122 -3679 + Partials 7363 3030 -4333 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.84% <ø> (-0.03%)` | :arrow_down: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. [see 2058 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18485/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) :rocket: New features to boost your workflow: - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] fix(flink): Handle bootstrap write metadata correctly after job resca… [hudi]
hudi-bot commented on PR #18485: URL: https://github.com/apache/hudi/pull/18485#issuecomment-4212351978 ## CI report: * 0876fa48f8a7d65bc3b7080597185d5a18d26b29 Azure: [FAILURE](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13171) * 8deb66b18e035553493b74157c54128f6ce26635 Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13182) Bot commands @hudi-bot supports the following commands: - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] fix(flink): Handle bootstrap write metadata correctly after job resca… [hudi]
hudi-bot commented on PR #18485: URL: https://github.com/apache/hudi/pull/18485#issuecomment-4212332504 ## CI report: * 0876fa48f8a7d65bc3b7080597185d5a18d26b29 Azure: [FAILURE](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13171) * 8deb66b18e035553493b74157c54128f6ce26635 UNKNOWN Bot commands @hudi-bot supports the following commands: - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] fix(flink): Handle bootstrap write metadata correctly after job resca… [hudi]
cshuo commented on code in PR #18485:
URL: https://github.com/apache/hudi/pull/18485#discussion_r3056121200
##
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/sink/utils/EventBuffers.java:
##
@@ -231,6 +231,13 @@ public boolean allBootstrapEventsReceived() {
&& Arrays.stream(indexWriteEventBuffer).allMatch(event -> event !=
null && event.isBootstrap());
}
+/**
+ * Checks whether the buffer comes from job restart(bootstrap).
+ */
+public boolean isBootstrapEvents() {
+ return Arrays.stream(dataWriteEventBuffer).anyMatch(event -> event !=
null && event.isBootstrap());
+}
Review Comment:
removed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] fix(flink): Handle bootstrap write metadata correctly after job resca… [hudi]
cshuo commented on code in PR #18485:
URL: https://github.com/apache/hudi/pull/18485#discussion_r3056119758
##
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/sink/event/WriteMetadataEvent.java:
##
@@ -121,6 +121,21 @@ public void mergeWith(WriteMetadataEvent other) {
this.writeStatuses = mergeWriteStatuses(this.writeStatuses,
other.writeStatuses);
}
+ /**
+ * Merges this event with given {@link WriteMetadataEvent} {@code other}
with rescaling.
+ * The events usually come from different tasks.
+ *
+ * @param other The event to be merged
+ */
+ public WriteMetadataEvent mergeWithRescale(WriteMetadataEvent other) {
+// the instant time could be monotonically increasing
Review Comment:
It's aligned with `mergeWith` method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] fix(flink): Handle bootstrap write metadata correctly after job resca… [hudi]
danny0405 commented on code in PR #18485:
URL: https://github.com/apache/hudi/pull/18485#discussion_r3055707237
##
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/sink/utils/EventBuffers.java:
##
@@ -231,6 +231,13 @@ public boolean allBootstrapEventsReceived() {
&& Arrays.stream(indexWriteEventBuffer).allMatch(event -> event !=
null && event.isBootstrap());
}
+/**
+ * Checks whether the buffer comes from job restart(bootstrap).
+ */
+public boolean isBootstrapEvents() {
+ return Arrays.stream(dataWriteEventBuffer).anyMatch(event -> event !=
null && event.isBootstrap());
Review Comment:
we can put this fix in a separate PR, that is I'm not sure it is really a
issue, since once the commit fails because of heartbeat expiration, the job
failover will trigger and the task would resend the bootstrap events again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] fix(flink): Handle bootstrap write metadata correctly after job resca… [hudi]
codecov-commenter commented on PR #18485: URL: https://github.com/apache/hudi/pull/18485#issuecomment-4211651967 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18485?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 66.64%. Comparing base ([`0591933`](https://app.codecov.io/gh/apache/hudi/commit/0591933bc237ab9adb616f6961bbd780deff25a2?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`0876fa4`](https://app.codecov.io/gh/apache/hudi/commit/0876fa48f8a7d65bc3b7080597185d5a18d26b29?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 4 commits behind head on master. Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18485 +/- ## - Coverage 68.77% 66.64% -2.14% + Complexity2811727394 -723 Files 2452 2452 Lines135033 135067 +34 Branches 1637616381 +5 - Hits 9286990014-2855 - Misses3480137809+3008 + Partials 7363 7244 -119 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.40% <100.00%> (-7.03%)` | :arrow_down: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.85% <ø> (-0.02%)` | :arrow_down: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.39% <ø> (-0.01%)` | :arrow_down: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.87% <ø> (+<0.01%)` | :arrow_up: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.48% <ø> (-0.02%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.22% <ø> (+0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18485?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...ache/hudi/sink/StreamWriteOperatorCoordinator.java](https://app.codecov.io/gh/apache/hudi/pull/18485?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2FStreamWriteOperatorCoordinator.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9TdHJlYW1Xcml0ZU9wZXJhdG9yQ29vcmRpbmF0b3IuamF2YQ==) | `81.04% <100.00%> (+1.56%)` | :arrow_up: | | [.../hudi/sink/common/AbstractStreamWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18485?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fcommon%2FAbstractStreamWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9jb21tb24vQWJzdHJhY3RTdHJlYW1Xcml0ZUZ1bmN0aW9uLmphdmE=) | `90.00% <100.00%> (+0.25%)` | :arrow_up: |
Re: [PR] fix(flink): Handle bootstrap write metadata correctly after job resca… [hudi]
codecov-commenter commented on PR #18485: URL: https://github.com/apache/hudi/pull/18485#issuecomment-4211649260 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18485?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 66.64%. Comparing base ([`0591933`](https://app.codecov.io/gh/apache/hudi/commit/0591933bc237ab9adb616f6961bbd780deff25a2?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`0876fa4`](https://app.codecov.io/gh/apache/hudi/commit/0876fa48f8a7d65bc3b7080597185d5a18d26b29?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 4 commits behind head on master. Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18485 +/- ## - Coverage 68.77% 66.64% -2.14% + Complexity2811727394 -723 Files 2452 2452 Lines135033 135067 +34 Branches 1637616381 +5 - Hits 9286990014-2855 - Misses3480137809+3008 + Partials 7363 7244 -119 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.40% <100.00%> (-7.03%)` | :arrow_down: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.85% <ø> (-0.02%)` | :arrow_down: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.39% <ø> (-0.01%)` | :arrow_down: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.81% <ø> (-0.06%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.48% <ø> (-0.02%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.22% <ø> (+0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18485?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...ache/hudi/sink/StreamWriteOperatorCoordinator.java](https://app.codecov.io/gh/apache/hudi/pull/18485?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2FStreamWriteOperatorCoordinator.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9TdHJlYW1Xcml0ZU9wZXJhdG9yQ29vcmRpbmF0b3IuamF2YQ==) | `81.04% <100.00%> (+1.56%)` | :arrow_up: | | [.../hudi/sink/common/AbstractStreamWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18485?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fcommon%2FAbstractStreamWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9jb21tb24vQWJzdHJhY3RTdHJlYW1Xcml0ZUZ1bmN0aW9uLmphdmE=) | `90.00% <100.00%> (+0.25%)` | :arrow_up: |
Re: [PR] fix(flink): Handle bootstrap write metadata correctly after job resca… [hudi]
codecov-commenter commented on PR #18485: URL: https://github.com/apache/hudi/pull/18485#issuecomment-4211623864 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18485?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 66.63%. Comparing base ([`0591933`](https://app.codecov.io/gh/apache/hudi/commit/0591933bc237ab9adb616f6961bbd780deff25a2?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`0876fa4`](https://app.codecov.io/gh/apache/hudi/commit/0876fa48f8a7d65bc3b7080597185d5a18d26b29?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 4 commits behind head on master. Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18485 +/- ## - Coverage 68.77% 66.63% -2.14% + Complexity2811727393 -724 Files 2452 2452 Lines135033 135067 +34 Branches 1637616381 +5 - Hits 9286990008-2861 - Misses3480137812+3011 + Partials 7363 7247 -116 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.40% <100.00%> (-7.03%)` | :arrow_down: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.85% <ø> (-0.02%)` | :arrow_down: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.39% <ø> (-0.01%)` | :arrow_down: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.80% <ø> (-0.06%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.48% <ø> (-0.02%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.22% <ø> (+0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18485?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...ache/hudi/sink/StreamWriteOperatorCoordinator.java](https://app.codecov.io/gh/apache/hudi/pull/18485?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2FStreamWriteOperatorCoordinator.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9TdHJlYW1Xcml0ZU9wZXJhdG9yQ29vcmRpbmF0b3IuamF2YQ==) | `81.04% <100.00%> (+1.56%)` | :arrow_up: | | [.../hudi/sink/common/AbstractStreamWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18485?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fcommon%2FAbstractStreamWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9jb21tb24vQWJzdHJhY3RTdHJlYW1Xcml0ZUZ1bmN0aW9uLmphdmE=) | `90.00% <100.00%> (+0.25%)` | :arrow_up: |
Re: [PR] fix(flink): Handle bootstrap write metadata correctly after job resca… [hudi]
codecov-commenter commented on PR #18485: URL: https://github.com/apache/hudi/pull/18485#issuecomment-4211604258 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18485?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 66.63%. Comparing base ([`0591933`](https://app.codecov.io/gh/apache/hudi/commit/0591933bc237ab9adb616f6961bbd780deff25a2?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`0876fa4`](https://app.codecov.io/gh/apache/hudi/commit/0876fa48f8a7d65bc3b7080597185d5a18d26b29?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 4 commits behind head on master. Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18485 +/- ## - Coverage 68.77% 66.63% -2.14% + Complexity2811727393 -724 Files 2452 2452 Lines135033 135067 +34 Branches 1637616381 +5 - Hits 9286990008-2861 - Misses3480137812+3011 + Partials 7363 7247 -116 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.40% <100.00%> (-7.03%)` | :arrow_down: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.85% <ø> (-0.02%)` | :arrow_down: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.39% <ø> (-0.01%)` | :arrow_down: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.77% <ø> (-0.10%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.48% <ø> (-0.02%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.22% <ø> (+0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18485?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...ache/hudi/sink/StreamWriteOperatorCoordinator.java](https://app.codecov.io/gh/apache/hudi/pull/18485?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2FStreamWriteOperatorCoordinator.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9TdHJlYW1Xcml0ZU9wZXJhdG9yQ29vcmRpbmF0b3IuamF2YQ==) | `81.04% <100.00%> (+1.56%)` | :arrow_up: | | [.../hudi/sink/common/AbstractStreamWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18485?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fcommon%2FAbstractStreamWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9jb21tb24vQWJzdHJhY3RTdHJlYW1Xcml0ZUZ1bmN0aW9uLmphdmE=) | `90.00% <100.00%> (+0.25%)` | :arrow_up: |
Re: [PR] fix(flink): Handle bootstrap write metadata correctly after job resca… [hudi]
codecov-commenter commented on PR #18485: URL: https://github.com/apache/hudi/pull/18485#issuecomment-4211602642 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18485?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 66.63%. Comparing base ([`0591933`](https://app.codecov.io/gh/apache/hudi/commit/0591933bc237ab9adb616f6961bbd780deff25a2?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`0876fa4`](https://app.codecov.io/gh/apache/hudi/commit/0876fa48f8a7d65bc3b7080597185d5a18d26b29?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 4 commits behind head on master. Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18485 +/- ## - Coverage 68.77% 66.63% -2.14% + Complexity2811727393 -724 Files 2452 2452 Lines135033 135067 +34 Branches 1637616381 +5 - Hits 9286990008-2861 - Misses3480137812+3011 + Partials 7363 7247 -116 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.40% <100.00%> (-7.03%)` | :arrow_down: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.85% <ø> (-0.02%)` | :arrow_down: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.39% <ø> (-0.01%)` | :arrow_down: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.77% <ø> (-0.10%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.48% <ø> (-0.02%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.22% <ø> (+0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18485?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...ache/hudi/sink/StreamWriteOperatorCoordinator.java](https://app.codecov.io/gh/apache/hudi/pull/18485?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2FStreamWriteOperatorCoordinator.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9TdHJlYW1Xcml0ZU9wZXJhdG9yQ29vcmRpbmF0b3IuamF2YQ==) | `81.04% <100.00%> (+1.56%)` | :arrow_up: | | [.../hudi/sink/common/AbstractStreamWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18485?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fcommon%2FAbstractStreamWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9jb21tb24vQWJzdHJhY3RTdHJlYW1Xcml0ZUZ1bmN0aW9uLmphdmE=) | `90.00% <100.00%> (+0.25%)` | :arrow_up: |
Re: [PR] fix(flink): Handle bootstrap write metadata correctly after job resca… [hudi]
codecov-commenter commented on PR #18485: URL: https://github.com/apache/hudi/pull/18485#issuecomment-4211595503 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18485?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 65.79%. Comparing base ([`0591933`](https://app.codecov.io/gh/apache/hudi/commit/0591933bc237ab9adb616f6961bbd780deff25a2?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`0876fa4`](https://app.codecov.io/gh/apache/hudi/commit/0876fa48f8a7d65bc3b7080597185d5a18d26b29?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 4 commits behind head on master. Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18485 +/- ## - Coverage 68.77% 65.79% -2.99% + Complexity2811727040-1077 Files 2452 2452 Lines135033 135067 +34 Branches 1637616381 +5 - Hits 9286988861-4008 - Misses3480138883+4082 + Partials 7363 7323 -40 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.40% <100.00%> (-7.03%)` | :arrow_down: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.85% <ø> (-0.02%)` | :arrow_down: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.39% <ø> (-0.01%)` | :arrow_down: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.15% <ø> (-3.72%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.48% <ø> (-0.02%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.22% <ø> (+0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18485?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...ache/hudi/sink/StreamWriteOperatorCoordinator.java](https://app.codecov.io/gh/apache/hudi/pull/18485?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2FStreamWriteOperatorCoordinator.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9TdHJlYW1Xcml0ZU9wZXJhdG9yQ29vcmRpbmF0b3IuamF2YQ==) | `81.04% <100.00%> (+1.56%)` | :arrow_up: | | [.../hudi/sink/common/AbstractStreamWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18485?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fcommon%2FAbstractStreamWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9jb21tb24vQWJzdHJhY3RTdHJlYW1Xcml0ZUZ1bmN0aW9uLmphdmE=) | `90.00% <100.00%> (+0.25%)` | :arrow_up: |
Re: [PR] fix(flink): Handle bootstrap write metadata correctly after job resca… [hudi]
hudi-bot commented on PR #18485: URL: https://github.com/apache/hudi/pull/18485#issuecomment-4211592726 ## CI report: * 0876fa48f8a7d65bc3b7080597185d5a18d26b29 Azure: [FAILURE](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13171) Bot commands @hudi-bot supports the following commands: - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] fix(flink): Handle bootstrap write metadata correctly after job resca… [hudi]
codecov-commenter commented on PR #18485: URL: https://github.com/apache/hudi/pull/18485#issuecomment-4211594919 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18485?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 65.79%. Comparing base ([`0591933`](https://app.codecov.io/gh/apache/hudi/commit/0591933bc237ab9adb616f6961bbd780deff25a2?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`0876fa4`](https://app.codecov.io/gh/apache/hudi/commit/0876fa48f8a7d65bc3b7080597185d5a18d26b29?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 4 commits behind head on master. Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18485 +/- ## - Coverage 68.77% 65.79% -2.99% + Complexity2811727040-1077 Files 2452 2452 Lines135033 135067 +34 Branches 1637616381 +5 - Hits 9286988861-4008 - Misses3480138883+4082 + Partials 7363 7323 -40 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.40% <100.00%> (-7.03%)` | :arrow_down: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.85% <ø> (-0.02%)` | :arrow_down: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.39% <ø> (-0.01%)` | :arrow_down: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.15% <ø> (-3.72%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.48% <ø> (-0.02%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.22% <ø> (+0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18485?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...ache/hudi/sink/StreamWriteOperatorCoordinator.java](https://app.codecov.io/gh/apache/hudi/pull/18485?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2FStreamWriteOperatorCoordinator.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9TdHJlYW1Xcml0ZU9wZXJhdG9yQ29vcmRpbmF0b3IuamF2YQ==) | `81.04% <100.00%> (+1.56%)` | :arrow_up: | | [.../hudi/sink/common/AbstractStreamWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18485?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fcommon%2FAbstractStreamWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9jb21tb24vQWJzdHJhY3RTdHJlYW1Xcml0ZUZ1bmN0aW9uLmphdmE=) | `90.00% <100.00%> (+0.25%)` | :arrow_up: |
Re: [PR] fix(flink): Handle bootstrap write metadata correctly after job resca… [hudi]
codecov-commenter commented on PR #18485: URL: https://github.com/apache/hudi/pull/18485#issuecomment-4211584575 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18485?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 65.62%. Comparing base ([`0591933`](https://app.codecov.io/gh/apache/hudi/commit/0591933bc237ab9adb616f6961bbd780deff25a2?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`0876fa4`](https://app.codecov.io/gh/apache/hudi/commit/0876fa48f8a7d65bc3b7080597185d5a18d26b29?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 4 commits behind head on master. Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18485 +/- ## - Coverage 68.77% 65.62% -3.15% + Complexity2811726973-1144 Files 2452 2452 Lines135033 135067 +34 Branches 1637616381 +5 - Hits 9286988642-4227 - Misses3480139088+4287 + Partials 7363 7337 -26 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.40% <100.00%> (-7.03%)` | :arrow_down: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.85% <ø> (-0.02%)` | :arrow_down: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.39% <ø> (-0.01%)` | :arrow_down: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `42.39% <ø> (-6.48%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.48% <ø> (-0.02%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.22% <ø> (+0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18485?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...ache/hudi/sink/StreamWriteOperatorCoordinator.java](https://app.codecov.io/gh/apache/hudi/pull/18485?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2FStreamWriteOperatorCoordinator.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9TdHJlYW1Xcml0ZU9wZXJhdG9yQ29vcmRpbmF0b3IuamF2YQ==) | `81.04% <100.00%> (+1.56%)` | :arrow_up: | | [.../hudi/sink/common/AbstractStreamWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18485?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fcommon%2FAbstractStreamWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9jb21tb24vQWJzdHJhY3RTdHJlYW1Xcml0ZUZ1bmN0aW9uLmphdmE=) | `90.00% <100.00%> (+0.25%)` | :arrow_up: |
Re: [PR] fix(flink): Handle bootstrap write metadata correctly after job resca… [hudi]
codecov-commenter commented on PR #18485: URL: https://github.com/apache/hudi/pull/18485#issuecomment-4211581671 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18485?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 64.11%. Comparing base ([`0591933`](https://app.codecov.io/gh/apache/hudi/commit/0591933bc237ab9adb616f6961bbd780deff25a2?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`0876fa4`](https://app.codecov.io/gh/apache/hudi/commit/0876fa48f8a7d65bc3b7080597185d5a18d26b29?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 4 commits behind head on master. Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18485 +/- ## - Coverage 68.77% 64.11% -4.67% + Complexity2811726350-1767 Files 2452 2452 Lines135033 135067 +34 Branches 1637616381 +5 - Hits 9286986592-6277 - Misses3480141048+6247 - Partials 7363 7427 +64 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.40% <100.00%> (-7.03%)` | :arrow_down: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.85% <ø> (-0.02%)` | :arrow_down: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.39% <ø> (-0.01%)` | :arrow_down: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.35% <ø> (-16.51%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.48% <ø> (-0.02%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.22% <ø> (+0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18485?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...ache/hudi/sink/StreamWriteOperatorCoordinator.java](https://app.codecov.io/gh/apache/hudi/pull/18485?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2FStreamWriteOperatorCoordinator.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9TdHJlYW1Xcml0ZU9wZXJhdG9yQ29vcmRpbmF0b3IuamF2YQ==) | `81.04% <100.00%> (+1.56%)` | :arrow_up: | | [.../hudi/sink/common/AbstractStreamWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18485?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fcommon%2FAbstractStreamWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9jb21tb24vQWJzdHJhY3RTdHJlYW1Xcml0ZUZ1bmN0aW9uLmphdmE=) | `90.00% <100.00%> (+0.25%)` | :arrow_up: |
Re: [PR] fix(flink): Handle bootstrap write metadata correctly after job resca… [hudi]
codecov-commenter commented on PR #18485: URL: https://github.com/apache/hudi/pull/18485#issuecomment-4211580578 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18485?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 64.01%. Comparing base ([`0591933`](https://app.codecov.io/gh/apache/hudi/commit/0591933bc237ab9adb616f6961bbd780deff25a2?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`0876fa4`](https://app.codecov.io/gh/apache/hudi/commit/0876fa48f8a7d65bc3b7080597185d5a18d26b29?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 4 commits behind head on master. Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18485 +/- ## - Coverage 68.77% 64.01% -4.77% + Complexity2811726288-1829 Files 2452 2452 Lines135033 135067 +34 Branches 1637616381 +5 - Hits 9286986460-6409 - Misses3480141225+6424 - Partials 7363 7382 +19 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.40% <100.00%> (-7.03%)` | :arrow_down: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.85% <ø> (-0.02%)` | :arrow_down: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.39% <ø> (-0.01%)` | :arrow_down: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.35% <ø> (-16.51%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.33% <ø> (-0.17%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.22% <ø> (+0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18485?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...ache/hudi/sink/StreamWriteOperatorCoordinator.java](https://app.codecov.io/gh/apache/hudi/pull/18485?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2FStreamWriteOperatorCoordinator.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9TdHJlYW1Xcml0ZU9wZXJhdG9yQ29vcmRpbmF0b3IuamF2YQ==) | `81.04% <100.00%> (+1.56%)` | :arrow_up: | | [.../hudi/sink/common/AbstractStreamWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18485?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fcommon%2FAbstractStreamWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9jb21tb24vQWJzdHJhY3RTdHJlYW1Xcml0ZUZ1bmN0aW9uLmphdmE=) | `90.00% <100.00%> (+0.25%)` | :arrow_up: |
Re: [PR] fix(flink): Handle bootstrap write metadata correctly after job resca… [hudi]
codecov-commenter commented on PR #18485: URL: https://github.com/apache/hudi/pull/18485#issuecomment-4211579234 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18485?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 64.01%. Comparing base ([`0591933`](https://app.codecov.io/gh/apache/hudi/commit/0591933bc237ab9adb616f6961bbd780deff25a2?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`0876fa4`](https://app.codecov.io/gh/apache/hudi/commit/0876fa48f8a7d65bc3b7080597185d5a18d26b29?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 4 commits behind head on master. Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18485 +/- ## - Coverage 68.77% 64.01% -4.77% + Complexity2811726288-1829 Files 2452 2452 Lines135033 135067 +34 Branches 1637616381 +5 - Hits 9286986458-6411 - Misses3480141225+6424 - Partials 7363 7384 +21 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.40% <100.00%> (-7.03%)` | :arrow_down: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.85% <ø> (-0.02%)` | :arrow_down: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.39% <ø> (-0.01%)` | :arrow_down: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.35% <ø> (-16.51%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.33% <ø> (-0.17%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.22% <ø> (+0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18485?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...ache/hudi/sink/StreamWriteOperatorCoordinator.java](https://app.codecov.io/gh/apache/hudi/pull/18485?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2FStreamWriteOperatorCoordinator.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9TdHJlYW1Xcml0ZU9wZXJhdG9yQ29vcmRpbmF0b3IuamF2YQ==) | `81.04% <100.00%> (+1.56%)` | :arrow_up: | | [.../hudi/sink/common/AbstractStreamWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18485?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fcommon%2FAbstractStreamWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9jb21tb24vQWJzdHJhY3RTdHJlYW1Xcml0ZUZ1bmN0aW9uLmphdmE=) | `90.00% <100.00%> (+0.25%)` | :arrow_up: |
Re: [PR] fix(flink): Handle bootstrap write metadata correctly after job resca… [hudi]
codecov-commenter commented on PR #18485: URL: https://github.com/apache/hudi/pull/18485#issuecomment-4211572388 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18485?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 63.86%. Comparing base ([`0591933`](https://app.codecov.io/gh/apache/hudi/commit/0591933bc237ab9adb616f6961bbd780deff25a2?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`0876fa4`](https://app.codecov.io/gh/apache/hudi/commit/0876fa48f8a7d65bc3b7080597185d5a18d26b29?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 4 commits behind head on master. Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18485 +/- ## - Coverage 68.77% 63.86% -4.91% + Complexity2811726213-1904 Files 2452 2452 Lines135033 135067 +34 Branches 1637616381 +5 - Hits 9286986263-6606 - Misses3480141441+6640 Partials 7363 7363 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.40% <100.00%> (-7.03%)` | :arrow_down: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.85% <ø> (-0.02%)` | :arrow_down: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.39% <ø> (-0.01%)` | :arrow_down: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.35% <ø> (-16.51%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.12% <ø> (-0.38%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.22% <ø> (+0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18485?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...ache/hudi/sink/StreamWriteOperatorCoordinator.java](https://app.codecov.io/gh/apache/hudi/pull/18485?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2FStreamWriteOperatorCoordinator.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9TdHJlYW1Xcml0ZU9wZXJhdG9yQ29vcmRpbmF0b3IuamF2YQ==) | `81.04% <100.00%> (+1.56%)` | :arrow_up: | | [.../hudi/sink/common/AbstractStreamWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18485?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fcommon%2FAbstractStreamWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9jb21tb24vQWJzdHJhY3RTdHJlYW1Xcml0ZUZ1bmN0aW9uLmphdmE=) | `90.00% <100.00%> (+0.25%)` | :arrow_up: |
Re: [PR] fix(flink): Handle bootstrap write metadata correctly after job resca… [hudi]
codecov-commenter commented on PR #18485: URL: https://github.com/apache/hudi/pull/18485#issuecomment-4211563063 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18485?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 63.75%. Comparing base ([`0591933`](https://app.codecov.io/gh/apache/hudi/commit/0591933bc237ab9adb616f6961bbd780deff25a2?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`0876fa4`](https://app.codecov.io/gh/apache/hudi/commit/0876fa48f8a7d65bc3b7080597185d5a18d26b29?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 4 commits behind head on master. > :exclamation: There is a different number of reports uploaded between BASE (0591933) and HEAD (0876fa4). Click for more details. > > HEAD has 14 uploads less than BASE > >| Flag | BASE (0591933) | HEAD (0876fa4) | >|--|--|--| >|spark-scala-tests|10|6| >|spark-java-tests|15|5| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18485 +/- ## - Coverage 68.77% 63.75% -5.03% + Complexity2811726146-1971 Files 2452 2452 Lines135033 135053 +20 Branches 1637616379 +3 - Hits 9286986103-6766 - Misses3480141634+6833 + Partials 7363 7316 -47 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.40% <100.00%> (-7.03%)` | :arrow_down: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.85% <ø> (-0.02%)` | :arrow_down: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.39% <ø> (-0.01%)` | :arrow_down: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.35% <ø> (-16.51%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.94% <ø> (-0.56%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.22% <ø> (+0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18485?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...ache/hudi/sink/StreamWriteOperatorCoordinator.java](https://app.codecov.io/gh/apache/hudi/pull/18485?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2FStreamWriteOperatorCoordinator.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9TdHJlYW1Xcml0ZU9wZXJhdG9yQ29vcmRpbmF0b3IuamF2YQ==) | `81.04% <100.00%> (+1.56%)` | :arrow_up: | | [.../hudi/sink/common/AbstractStreamWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18485?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fcommon%2FAbstrac
Re: [PR] fix(flink): Handle bootstrap write metadata correctly after job resca… [hudi]
codecov-commenter commented on PR #18485: URL: https://github.com/apache/hudi/pull/18485#issuecomment-4211551552 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18485?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 59.16%. Comparing base ([`0591933`](https://app.codecov.io/gh/apache/hudi/commit/0591933bc237ab9adb616f6961bbd780deff25a2?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`0876fa4`](https://app.codecov.io/gh/apache/hudi/commit/0876fa48f8a7d65bc3b7080597185d5a18d26b29?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 4 commits behind head on master. > :exclamation: There is a different number of reports uploaded between BASE (0591933) and HEAD (0876fa4). Click for more details. > > HEAD has 15 uploads less than BASE > >| Flag | BASE (0591933) | HEAD (0876fa4) | >|--|--|--| >|spark-scala-tests|10|5| >|spark-java-tests|15|5| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18485 +/- ## - Coverage 68.77% 59.16% -9.62% + Complexity2811724267-3850 Files 2452 2452 Lines135033 135053 +20 Branches 1637616379 +3 - Hits 9286979904 -12965 - Misses3480148292 +13491 + Partials 7363 6857 -506 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.40% <100.00%> (-7.03%)` | :arrow_down: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.85% <ø> (-0.02%)` | :arrow_down: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.39% <ø> (-0.01%)` | :arrow_down: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.35% <ø> (-16.51%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.55% <ø> (-12.95%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.22% <ø> (+0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18485?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...ache/hudi/sink/StreamWriteOperatorCoordinator.java](https://app.codecov.io/gh/apache/hudi/pull/18485?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2FStreamWriteOperatorCoordinator.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9TdHJlYW1Xcml0ZU9wZXJhdG9yQ29vcmRpbmF0b3IuamF2YQ==) | `81.04% <100.00%> (+1.56%)` | :arrow_up: | | [.../hudi/sink/common/AbstractStreamWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18485?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fcommon%2FAbstra
Re: [PR] fix(flink): Handle bootstrap write metadata correctly after job resca… [hudi]
codecov-commenter commented on PR #18485: URL: https://github.com/apache/hudi/pull/18485#issuecomment-4211548554 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18485?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 54.77%. Comparing base ([`0591933`](https://app.codecov.io/gh/apache/hudi/commit/0591933bc237ab9adb616f6961bbd780deff25a2?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`0876fa4`](https://app.codecov.io/gh/apache/hudi/commit/0876fa48f8a7d65bc3b7080597185d5a18d26b29?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 4 commits behind head on master. > :exclamation: There is a different number of reports uploaded between BASE (0591933) and HEAD (0876fa4). Click for more details. > > HEAD has 16 uploads less than BASE > >| Flag | BASE (0591933) | HEAD (0876fa4) | >|--|--|--| >|spark-scala-tests|10|5| >|spark-java-tests|15|5| >|utilities|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18485 +/- ## = - Coverage 68.77% 54.77% -14.00% + Complexity2811722751 -5366 = Files 2452 2452 Lines135033 135053 +20 Branches 1637616379+3 = - Hits 9286973977-18892 - Misses3480154674+19873 + Partials 7363 6402 -961 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.40% <100.00%> (-7.03%)` | :arrow_down: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.85% <ø> (-0.02%)` | :arrow_down: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.39% <ø> (-0.01%)` | :arrow_down: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.35% <ø> (-16.51%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.55% <ø> (-12.95%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18485?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...ache/hudi/sink/StreamWriteOperatorCoordinator.java](https://app.codecov.io/gh/apache/hudi/pull/18485?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2FStreamWriteOperatorCoordinator.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9TdHJlYW1Xcml0ZU9wZXJhdG9yQ29vcmRpbmF0b3IuamF2YQ==) | `81.04% <100.00%> (+1.56%)` | :arrow_up: | | [.../hudi/sink/common/AbstractStreamWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18485?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fcommon%2FAb
Re: [PR] fix(flink): Handle bootstrap write metadata correctly after job resca… [hudi]
codecov-commenter commented on PR #18485: URL: https://github.com/apache/hudi/pull/18485#issuecomment-4211545096 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18485?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 54.74%. Comparing base ([`0591933`](https://app.codecov.io/gh/apache/hudi/commit/0591933bc237ab9adb616f6961bbd780deff25a2?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`0876fa4`](https://app.codecov.io/gh/apache/hudi/commit/0876fa48f8a7d65bc3b7080597185d5a18d26b29?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 4 commits behind head on master. > :exclamation: There is a different number of reports uploaded between BASE (0591933) and HEAD (0876fa4). Click for more details. > > HEAD has 17 uploads less than BASE > >| Flag | BASE (0591933) | HEAD (0876fa4) | >|--|--|--| >|spark-scala-tests|10|5| >|spark-java-tests|15|4| >|utilities|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18485 +/- ## = - Coverage 68.77% 54.74% -14.03% + Complexity2811722738 -5379 = Files 2452 2452 Lines135033 135053 +20 Branches 1637616379+3 = - Hits 9286973941-18928 - Misses3480154706+19905 + Partials 7363 6406 -957 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.40% <100.00%> (-7.03%)` | :arrow_down: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.85% <ø> (-0.02%)` | :arrow_down: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.39% <ø> (-0.01%)` | :arrow_down: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.74% <ø> (-16.13%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.55% <ø> (-12.95%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18485?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...ache/hudi/sink/StreamWriteOperatorCoordinator.java](https://app.codecov.io/gh/apache/hudi/pull/18485?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2FStreamWriteOperatorCoordinator.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9TdHJlYW1Xcml0ZU9wZXJhdG9yQ29vcmRpbmF0b3IuamF2YQ==) | `81.04% <100.00%> (+1.56%)` | :arrow_up: | | [.../hudi/sink/common/AbstractStreamWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18485?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fcommon%2FAb
Re: [PR] fix(flink): Handle bootstrap write metadata correctly after job resca… [hudi]
codecov-commenter commented on PR #18485: URL: https://github.com/apache/hudi/pull/18485#issuecomment-4211542553 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18485?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 55.31%. Comparing base ([`0591933`](https://app.codecov.io/gh/apache/hudi/commit/0591933bc237ab9adb616f6961bbd780deff25a2?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`0876fa4`](https://app.codecov.io/gh/apache/hudi/commit/0876fa48f8a7d65bc3b7080597185d5a18d26b29?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 4 commits behind head on master. > :exclamation: There is a different number of reports uploaded between BASE (0591933) and HEAD (0876fa4). Click for more details. > > HEAD has 19 uploads less than BASE > >| Flag | BASE (0591933) | HEAD (0876fa4) | >|--|--|--| >|spark-scala-tests|10|4| >|spark-java-tests|15|3| >|utilities|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18485 +/- ## = - Coverage 68.77% 55.31% -13.47% + Complexity2811722523 -5594 = Files 2452 2423 -29 Lines135033 132450 -2583 Branches 1637615825 -551 = - Hits 9286973264-19605 - Misses3480152941+18140 + Partials 7363 6245 -1118 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.40% <100.00%> (-7.03%)` | :arrow_down: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.85% <ø> (-0.02%)` | :arrow_down: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.39% <ø> (-0.01%)` | :arrow_down: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.17% <ø> (-15.70%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.67% <ø> (-12.83%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18485?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...ache/hudi/sink/StreamWriteOperatorCoordinator.java](https://app.codecov.io/gh/apache/hudi/pull/18485?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2FStreamWriteOperatorCoordinator.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9TdHJlYW1Xcml0ZU9wZXJhdG9yQ29vcmRpbmF0b3IuamF2YQ==) | `81.04% <100.00%> (+1.56%)` | :arrow_up: | | [.../hudi/sink/common/AbstractStreamWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18485?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fcommon%2FAb
Re: [PR] fix(flink): Handle bootstrap write metadata correctly after job resca… [hudi]
codecov-commenter commented on PR #18485: URL: https://github.com/apache/hudi/pull/18485#issuecomment-4211541950 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18485?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 55.31%. Comparing base ([`0591933`](https://app.codecov.io/gh/apache/hudi/commit/0591933bc237ab9adb616f6961bbd780deff25a2?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`0876fa4`](https://app.codecov.io/gh/apache/hudi/commit/0876fa48f8a7d65bc3b7080597185d5a18d26b29?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 4 commits behind head on master. > :exclamation: There is a different number of reports uploaded between BASE (0591933) and HEAD (0876fa4). Click for more details. > > HEAD has 19 uploads less than BASE > >| Flag | BASE (0591933) | HEAD (0876fa4) | >|--|--|--| >|spark-scala-tests|10|4| >|spark-java-tests|15|3| >|utilities|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18485 +/- ## = - Coverage 68.77% 55.31% -13.47% + Complexity2811722523 -5594 = Files 2452 2423 -29 Lines135033 132450 -2583 Branches 1637615825 -551 = - Hits 9286973264-19605 - Misses3480152941+18140 + Partials 7363 6245 -1118 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.40% <100.00%> (-7.03%)` | :arrow_down: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.85% <ø> (-0.02%)` | :arrow_down: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.39% <ø> (-0.01%)` | :arrow_down: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.17% <ø> (-15.70%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.67% <ø> (-12.83%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18485?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...ache/hudi/sink/StreamWriteOperatorCoordinator.java](https://app.codecov.io/gh/apache/hudi/pull/18485?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2FStreamWriteOperatorCoordinator.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9TdHJlYW1Xcml0ZU9wZXJhdG9yQ29vcmRpbmF0b3IuamF2YQ==) | `81.04% <100.00%> (+1.56%)` | :arrow_up: | | [.../hudi/sink/common/AbstractStreamWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18485?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fcommon%2FAb
Re: [PR] fix(flink): Handle bootstrap write metadata correctly after job resca… [hudi]
codecov-commenter commented on PR #18485: URL: https://github.com/apache/hudi/pull/18485#issuecomment-4211539519 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18485?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 55.26%. Comparing base ([`0591933`](https://app.codecov.io/gh/apache/hudi/commit/0591933bc237ab9adb616f6961bbd780deff25a2?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`0876fa4`](https://app.codecov.io/gh/apache/hudi/commit/0876fa48f8a7d65bc3b7080597185d5a18d26b29?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 4 commits behind head on master. > :exclamation: There is a different number of reports uploaded between BASE (0591933) and HEAD (0876fa4). Click for more details. > > HEAD has 21 uploads less than BASE > >| Flag | BASE (0591933) | HEAD (0876fa4) | >|--|--|--| >|spark-scala-tests|10|4| >|spark-java-tests|15|1| >|utilities|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18485 +/- ## = - Coverage 68.77% 55.26% -13.51% + Complexity2811722509 -5608 = Files 2452 2423 -29 Lines135033 132450 -2583 Branches 1637615825 -551 = - Hits 9286973203-19666 - Misses3480152989+18188 + Partials 7363 6258 -1105 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.40% <100.00%> (-7.03%)` | :arrow_down: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.85% <ø> (-0.02%)` | :arrow_down: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.39% <ø> (-0.01%)` | :arrow_down: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.47% <ø> (-15.39%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.67% <ø> (-12.83%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18485?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...ache/hudi/sink/StreamWriteOperatorCoordinator.java](https://app.codecov.io/gh/apache/hudi/pull/18485?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2FStreamWriteOperatorCoordinator.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9TdHJlYW1Xcml0ZU9wZXJhdG9yQ29vcmRpbmF0b3IuamF2YQ==) | `81.04% <100.00%> (+1.56%)` | :arrow_up: | | [.../hudi/sink/common/AbstractStreamWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18485?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fcommon%2FAb
Re: [PR] fix(flink): Handle bootstrap write metadata correctly after job resca… [hudi]
codecov-commenter commented on PR #18485: URL: https://github.com/apache/hudi/pull/18485#issuecomment-4211538518 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18485?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 55.26%. Comparing base ([`0591933`](https://app.codecov.io/gh/apache/hudi/commit/0591933bc237ab9adb616f6961bbd780deff25a2?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`0876fa4`](https://app.codecov.io/gh/apache/hudi/commit/0876fa48f8a7d65bc3b7080597185d5a18d26b29?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 4 commits behind head on master. > :exclamation: There is a different number of reports uploaded between BASE (0591933) and HEAD (0876fa4). Click for more details. > > HEAD has 21 uploads less than BASE > >| Flag | BASE (0591933) | HEAD (0876fa4) | >|--|--|--| >|spark-scala-tests|10|4| >|spark-java-tests|15|1| >|utilities|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18485 +/- ## = - Coverage 68.77% 55.26% -13.51% + Complexity2811722509 -5608 = Files 2452 2423 -29 Lines135033 132450 -2583 Branches 1637615825 -551 = - Hits 9286973203-19666 - Misses3480152989+18188 + Partials 7363 6258 -1105 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.40% <100.00%> (-7.03%)` | :arrow_down: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.85% <ø> (-0.02%)` | :arrow_down: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.39% <ø> (-0.01%)` | :arrow_down: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.47% <ø> (-15.39%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.67% <ø> (-12.83%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18485?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...ache/hudi/sink/StreamWriteOperatorCoordinator.java](https://app.codecov.io/gh/apache/hudi/pull/18485?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2FStreamWriteOperatorCoordinator.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9TdHJlYW1Xcml0ZU9wZXJhdG9yQ29vcmRpbmF0b3IuamF2YQ==) | `81.04% <100.00%> (+1.56%)` | :arrow_up: | | [.../hudi/sink/common/AbstractStreamWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18485?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fcommon%2FAb
Re: [PR] fix(flink): Handle bootstrap write metadata correctly after job resca… [hudi]
codecov-commenter commented on PR #18485: URL: https://github.com/apache/hudi/pull/18485#issuecomment-4211533735 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18485?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 53.42%. Comparing base ([`0591933`](https://app.codecov.io/gh/apache/hudi/commit/0591933bc237ab9adb616f6961bbd780deff25a2?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`0876fa4`](https://app.codecov.io/gh/apache/hudi/commit/0876fa48f8a7d65bc3b7080597185d5a18d26b29?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 4 commits behind head on master. > :exclamation: There is a different number of reports uploaded between BASE (0591933) and HEAD (0876fa4). Click for more details. > > HEAD has 23 uploads less than BASE > >| Flag | BASE (0591933) | HEAD (0876fa4) | >|--|--|--| >|spark-scala-tests|10|3| >|spark-java-tests|15|0| >|utilities|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18485 +/- ## = - Coverage 68.77% 53.42% -15.36% + Complexity2811721809 -6308 = Files 2452 2423 -29 Lines135033 132450 -2583 Branches 1637615825 -551 = - Hits 9286970761-22108 - Misses3480155584+20783 + Partials 7363 6105 -1258 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.40% <100.00%> (-7.03%)` | :arrow_down: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.85% <ø> (-0.02%)` | :arrow_down: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.39% <ø> (-0.01%)` | :arrow_down: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.67% <ø> (-12.83%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18485?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...ache/hudi/sink/StreamWriteOperatorCoordinator.java](https://app.codecov.io/gh/apache/hudi/pull/18485?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2FStreamWriteOperatorCoordinator.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9TdHJlYW1Xcml0ZU9wZXJhdG9yQ29vcmRpbmF0b3IuamF2YQ==) | `81.04% <100.00%> (+1.56%)` | :arrow_up: | | [.../hudi/sink/common/AbstractStreamWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18485?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fcommon%2FAbstractStreamWriteFunction.java&u
Re: [PR] fix(flink): Handle bootstrap write metadata correctly after job resca… [hudi]
codecov-commenter commented on PR #18485: URL: https://github.com/apache/hudi/pull/18485#issuecomment-4211529516 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18485?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 54.02%. Comparing base ([`0591933`](https://app.codecov.io/gh/apache/hudi/commit/0591933bc237ab9adb616f6961bbd780deff25a2?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`0876fa4`](https://app.codecov.io/gh/apache/hudi/commit/0876fa48f8a7d65bc3b7080597185d5a18d26b29?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 4 commits behind head on master. > :exclamation: There is a different number of reports uploaded between BASE (0591933) and HEAD (0876fa4). Click for more details. > > HEAD has 24 uploads less than BASE > >| Flag | BASE (0591933) | HEAD (0876fa4) | >|--|--|--| >|spark-scala-tests|10|2| >|spark-java-tests|15|0| >|utilities|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18485 +/- ## = - Coverage 68.77% 54.02% -14.76% + Complexity2811721648 -6469 = Files 2452 2406 -46 Lines135033 130091 -4942 Branches 1637615322 -1054 = - Hits 9286970281-22588 - Misses3480153845+19044 + Partials 7363 5965 -1398 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.40% <100.00%> (-7.03%)` | :arrow_down: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.85% <ø> (-0.02%)` | :arrow_down: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.39% <ø> (-0.01%)` | :arrow_down: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.94% <ø> (-12.56%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18485?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...ache/hudi/sink/StreamWriteOperatorCoordinator.java](https://app.codecov.io/gh/apache/hudi/pull/18485?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2FStreamWriteOperatorCoordinator.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9TdHJlYW1Xcml0ZU9wZXJhdG9yQ29vcmRpbmF0b3IuamF2YQ==) | `81.04% <100.00%> (+1.56%)` | :arrow_up: | | [.../hudi/sink/common/AbstractStreamWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18485?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fcommon%2FAbstractStreamWriteFunction.java&u
Re: [PR] fix(flink): Handle bootstrap write metadata correctly after job resca… [hudi]
codecov-commenter commented on PR #18485: URL: https://github.com/apache/hudi/pull/18485#issuecomment-4211522817 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18485?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 53.55%. Comparing base ([`0591933`](https://app.codecov.io/gh/apache/hudi/commit/0591933bc237ab9adb616f6961bbd780deff25a2?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`0876fa4`](https://app.codecov.io/gh/apache/hudi/commit/0876fa48f8a7d65bc3b7080597185d5a18d26b29?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 4 commits behind head on master. > :exclamation: There is a different number of reports uploaded between BASE (0591933) and HEAD (0876fa4). Click for more details. > > HEAD has 25 uploads less than BASE > >| Flag | BASE (0591933) | HEAD (0876fa4) | >|--|--|--| >|spark-scala-tests|10|1| >|spark-java-tests|15|0| >|utilities|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18485 +/- ## = - Coverage 68.77% 53.55% -15.22% + Complexity2811721476 -6641 = Files 2452 2406 -46 Lines135033 130074 -4959 Branches 1637615238 -1138 = - Hits 9286969666-23203 - Misses3480154559+19758 + Partials 7363 5849 -1514 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.40% <100.00%> (-7.03%)` | :arrow_down: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.85% <ø> (-0.02%)` | :arrow_down: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.39% <ø> (-0.01%)` | :arrow_down: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.08% <ø> (-12.42%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18485?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...ache/hudi/sink/StreamWriteOperatorCoordinator.java](https://app.codecov.io/gh/apache/hudi/pull/18485?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2FStreamWriteOperatorCoordinator.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9TdHJlYW1Xcml0ZU9wZXJhdG9yQ29vcmRpbmF0b3IuamF2YQ==) | `81.04% <100.00%> (+1.56%)` | :arrow_up: | | [.../hudi/sink/common/AbstractStreamWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18485?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fcommon%2FAbstractStreamWriteFunction.java&u
Re: [PR] fix(flink): Handle bootstrap write metadata correctly after job resca… [hudi]
yihua commented on code in PR #18485:
URL: https://github.com/apache/hudi/pull/18485#discussion_r3055469132
##
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/sink/event/WriteMetadataEvent.java:
##
@@ -121,6 +121,21 @@ public void mergeWith(WriteMetadataEvent other) {
this.writeStatuses = mergeWriteStatuses(this.writeStatuses,
other.writeStatuses);
}
+ /**
+ * Merges this event with given {@link WriteMetadataEvent} {@code other}
with rescaling.
+ * The events usually come from different tasks.
+ *
+ * @param other The event to be merged
+ */
+ public WriteMetadataEvent mergeWithRescale(WriteMetadataEvent other) {
+// the instant time could be monotonically increasing
Review Comment:
🤖 Taking `other.instantTime` unconditionally means in a `reduce`, the final
instant depends on the arbitrary iteration order of the redistributed
`ListState`. If events from different subtasks somehow carried different
instants (e.g. partial failure edge case), this could pick a stale instant
while merging write statuses from a newer one. Could you take the max instead,
e.g. `this.instantTime = this.instantTime.compareTo(other.instantTime) >= 0 ?
this.instantTime : other.instantTime`?
- Generated by an AI agent and may contain mistakes. Please verify
any suggestions before applying.
##
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/sink/common/AbstractStreamWriteFunction.java:
##
@@ -234,18 +234,20 @@ protected void sendBootstrapEvent(int attemptId, boolean
isRestored) throws Exce
if (isRestored) {
HoodieTimeline pendingTimeline =
this.metaClient.getActiveTimeline().filterPendingExcludingCompaction();
// if the task is initially started, resend the pending event.
-for (WriteMetadataEvent event : this.writeMetadataState.get()) {
- // Must filter out the completed instants in case it is a partial
failover,
- // the write status should not be accumulated in such case.
- if (pendingTimeline.containsInstant(event.getInstantTime())) {
-// Reset taskID for event
-event.setTaskID(taskID);
-// The checkpoint succeed but the meta does not commit,
-// re-commit the inflight instant
-sendWriteMetadataEvent(event);
-log.info("Send uncommitted write metadata event to coordinator,
task[{}].", taskID);
- }
-}
+StreamSupport.stream(this.writeMetadataState.get().spliterator(),
false)
Review Comment:
🤖 The old code iterated over all restored events and sent each one whose
instant was pending. The new code merges everything into a single event. Is it
guaranteed that all events in `writeMetadataState` after rescaling share the
same instant time? If not, merging write statuses across different instants
into one event could lead to write statuses being committed under the wrong
instant.
- Generated by an AI agent and may contain mistakes. Please verify
any suggestions before applying.
##
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/sink/utils/EventBuffers.java:
##
@@ -231,6 +231,13 @@ public boolean allBootstrapEventsReceived() {
&& Arrays.stream(indexWriteEventBuffer).allMatch(event -> event !=
null && event.isBootstrap());
}
+/**
+ * Checks whether the buffer comes from job restart(bootstrap).
+ */
+public boolean isBootstrapEvents() {
+ return Arrays.stream(dataWriteEventBuffer).anyMatch(event -> event !=
null && event.isBootstrap());
+}
Review Comment:
🤖 Using `anyMatch` means if even a single slot contains a bootstrap event
while other slots have real write events, the entire buffer is considered
bootstrap-only and skipped during checkpoint commit. Is it possible for a
buffer to have a mix of bootstrap and non-bootstrap data write events? If so,
should this be `allMatch` (with a null guard) instead?
- Generated by an AI agent and may contain mistakes. Please verify
any suggestions before applying.
##
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/sink/event/WriteMetadataEvent.java:
##
@@ -121,6 +121,21 @@ public void mergeWith(WriteMetadataEvent other) {
this.writeStatuses = mergeWriteStatuses(this.writeStatuses,
other.writeStatuses);
}
+ /**
+ * Merges this event with given {@link WriteMetadataEvent} {@code other}
with rescaling.
+ * The events usually come from different tasks.
+ *
+ * @param other The event to be merged
Review Comment:
🤖 This method mutates `this` and returns it, which works when used with a
sequential `Stream.reduce()` but technically violates the `BinaryOperator`
contract of `reduce` (should be side-effect free). If someone later switches to
a parallel stream or refactors the call site, this would break. A small comment
at the call site documenting the sequential-only contrac
Re: [PR] fix(flink): Handle bootstrap write metadata correctly after job resca… [hudi]
codecov-commenter commented on PR #18485: URL: https://github.com/apache/hudi/pull/18485#issuecomment-4211514665 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18485?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 47.53%. Comparing base ([`0591933`](https://app.codecov.io/gh/apache/hudi/commit/0591933bc237ab9adb616f6961bbd780deff25a2?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`0876fa4`](https://app.codecov.io/gh/apache/hudi/commit/0876fa48f8a7d65bc3b7080597185d5a18d26b29?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 4 commits behind head on master. > :exclamation: There is a different number of reports uploaded between BASE (0591933) and HEAD (0876fa4). Click for more details. > > HEAD has 26 uploads less than BASE > >| Flag | BASE (0591933) | HEAD (0876fa4) | >|--|--|--| >|spark-scala-tests|10|0| >|spark-java-tests|15|0| >|utilities|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18485 +/- ## = - Coverage 68.77% 47.53% -21.25% + Complexity2811719252 -8865 = Files 2452 2388 -64 Lines135033 127699 -7334 Branches 1637614732 -1644 = - Hits 9286960701-32168 - Misses3480162585+27784 + Partials 7363 4413 -2950 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.40% <100.00%> (-7.03%)` | :arrow_down: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.85% <ø> (-0.02%)` | :arrow_down: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.39% <ø> (-0.01%)` | :arrow_down: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18485?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...ache/hudi/sink/StreamWriteOperatorCoordinator.java](https://app.codecov.io/gh/apache/hudi/pull/18485?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2FStreamWriteOperatorCoordinator.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9TdHJlYW1Xcml0ZU9wZXJhdG9yQ29vcmRpbmF0b3IuamF2YQ==) | `81.04% <100.00%> (+1.56%)` | :arrow_up: | | [.../hudi/sink/common/AbstractStreamWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18485?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fcommon%2FAbstractStreamWriteFunction.java&utm_medium=referral&utm_source=gi
Re: [PR] fix(flink): Handle bootstrap write metadata correctly after job resca… [hudi]
codecov-commenter commented on PR #18485: URL: https://github.com/apache/hudi/pull/18485#issuecomment-4211504119 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18485?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 42.08%. Comparing base ([`0591933`](https://app.codecov.io/gh/apache/hudi/commit/0591933bc237ab9adb616f6961bbd780deff25a2?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`0876fa4`](https://app.codecov.io/gh/apache/hudi/commit/0876fa48f8a7d65bc3b7080597185d5a18d26b29?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 4 commits behind head on master. > :exclamation: There is a different number of reports uploaded between BASE (0591933) and HEAD (0876fa4). Click for more details. > > HEAD has 27 uploads less than BASE > >| Flag | BASE (0591933) | HEAD (0876fa4) | >|--|--|--| >|spark-client-hadoop-common|1|0| >|spark-scala-tests|10|0| >|spark-java-tests|15|0| >|utilities|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18485 +/- ## = - Coverage 68.77% 42.08% -26.69% + Complexity2811716718-11399 = Files 2452 2388 -64 Lines135033 127699 -7334 Branches 1637614732 -1644 = - Hits 9286953746-39123 - Misses3480169727+34926 + Partials 7363 4226 -3137 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.40% <100.00%> (-7.03%)` | :arrow_down: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.85% <ø> (-0.02%)` | :arrow_down: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18485?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...ache/hudi/sink/StreamWriteOperatorCoordinator.java](https://app.codecov.io/gh/apache/hudi/pull/18485?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2FStreamWriteOperatorCoordinator.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9TdHJlYW1Xcml0ZU9wZXJhdG9yQ29vcmRpbmF0b3IuamF2YQ==) | `81.04% <100.00%> (+1.56%)` | :arrow_up: | | [.../hudi/sink/common/AbstractStreamWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18485?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fcommon%2FAbstractStreamWriteFunction.java&utm_medium=referral&utm_sou
Re: [PR] fix(flink): Handle bootstrap write metadata correctly after job resca… [hudi]
codecov-commenter commented on PR #18485: URL: https://github.com/apache/hudi/pull/18485#issuecomment-4211437617 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18485?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 44.85%. Comparing base ([`0591933`](https://app.codecov.io/gh/apache/hudi/commit/0591933bc237ab9adb616f6961bbd780deff25a2?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`0876fa4`](https://app.codecov.io/gh/apache/hudi/commit/0876fa48f8a7d65bc3b7080597185d5a18d26b29?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 4 commits behind head on master. > :exclamation: There is a different number of reports uploaded between BASE (0591933) and HEAD (0876fa4). Click for more details. > > HEAD has 28 uploads less than BASE > >| Flag | BASE (0591933) | HEAD (0876fa4) | >|--|--|--| >|spark-client-hadoop-common|1|0| >|spark-scala-tests|10|0| >|spark-java-tests|15|0| >|common-and-other-modules|1|0| >|utilities|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18485 +/- ## = - Coverage 68.77% 44.85% -23.92% + Complexity28117 8477-19640 = Files 2452 1196 -1256 Lines13503361906-73127 Branches 16376 6664 -9712 = - Hits 9286927771-65098 + Misses3480131105 -3696 + Partials 7363 3030 -4333 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.85% <ø> (-0.02%)` | :arrow_down: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18485/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. [see 2058 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18485/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) :rocket: New features to boost your workflow: - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] fix(flink): Handle bootstrap write metadata correctly after job resca… [hudi]
yihua commented on code in PR #18485:
URL: https://github.com/apache/hudi/pull/18485#discussion_r3055461637
##
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/sink/event/WriteMetadataEvent.java:
##
@@ -121,6 +121,21 @@ public void mergeWith(WriteMetadataEvent other) {
this.writeStatuses = mergeWriteStatuses(this.writeStatuses,
other.writeStatuses);
}
+ /**
+ * Merges this event with given {@link WriteMetadataEvent} {@code other}
with rescaling.
+ * The events usually come from different tasks.
+ *
+ * @param other The event to be merged
+ */
+ public WriteMetadataEvent mergeWithRescale(WriteMetadataEvent other) {
+// the instant time could be monotonically increasing
+this.instantTime = other.instantTime;
Review Comment:
🤖 nit: the inline comments on lines 132 and 134 state what the code already
expresses clearly—consider removing them to reduce clutter.
- Generated by an AI agent and may contain mistakes. Please verify
any suggestions before applying.
##
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/sink/utils/EventBuffers.java:
##
@@ -231,6 +231,13 @@ public boolean allBootstrapEventsReceived() {
&& Arrays.stream(indexWriteEventBuffer).allMatch(event -> event !=
null && event.isBootstrap());
}
+/**
+ * Checks whether the buffer comes from job restart(bootstrap).
+ */
+public boolean isBootstrapEvents() {
+ return Arrays.stream(dataWriteEventBuffer).anyMatch(event -> event !=
null && event.isBootstrap());
Review Comment:
🤖 nit: the method name `isBootstrapEvents()` doesn't clearly indicate it
checks for ANY bootstrap event using `anyMatch()`. consider renaming to
`hasBootstrapEvent()` or clarify the javadoc to match the existence check
behavior.
- Generated by an AI agent and may contain mistakes. Please verify
any suggestions before applying.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] fix(flink): Handle bootstrap write metadata correctly after job resca… [hudi]
hudi-bot commented on PR #18485: URL: https://github.com/apache/hudi/pull/18485#issuecomment-4211415931 ## CI report: * 0876fa48f8a7d65bc3b7080597185d5a18d26b29 Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13171) Bot commands @hudi-bot supports the following commands: - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] fix(flink): Handle bootstrap write metadata correctly after job resca… [hudi]
hudi-bot commented on PR #18485: URL: https://github.com/apache/hudi/pull/18485#issuecomment-4211406277 ## CI report: * 0876fa48f8a7d65bc3b7080597185d5a18d26b29 UNKNOWN Bot commands @hudi-bot supports the following commands: - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
