Re: [PR] fix(table-services): When applying rollback metadata to metadata table (v6) do not rollback a metadata table deltacommit if it has been already rolled back by post-commit rollback [hudi]
prashantwason merged PR #18160: URL: https://github.com/apache/hudi/pull/18160 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] fix(table-services): When applying rollback metadata to metadata table (v6) do not rollback a metadata table deltacommit if it has been already rolled back by post-commit rollback [hudi]
hudi-bot commented on PR #18160: URL: https://github.com/apache/hudi/pull/18160#issuecomment-3982796637 ## CI report: * 433b7bcc69dabc9983fc6fedd1572b57ad7d9c9d Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12363) Bot commands @hudi-bot supports the following commands: - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] fix(table-services): When applying rollback metadata to metadata table (v6) do not rollback a metadata table deltacommit if it has been already rolled back by post-commit rollback [hudi]
codecov-commenter commented on PR #18160: URL: https://github.com/apache/hudi/pull/18160#issuecomment-3982753690 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18160?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 57.32%. Comparing base ([`1203b21`](https://app.codecov.io/gh/apache/hudi/commit/1203b215b03cb5c76fffb46a360efe0c4ce21fe0?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`433b7bc`](https://app.codecov.io/gh/apache/hudi/commit/433b7bcc69dabc9983fc6fedd1572b57ad7d9c9d?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). Additional details and impacted files ```diff @@Coverage Diff@@ ## master #18160 +/- ## = Coverage 57.31% 57.32% - Complexity1860218605+3 = Files 1948 1948 Lines106580 106580 Branches 1317413174 = + Hits 6108561095 +10 + Misses3973439727-7 + Partials 5761 5758-3 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18160/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18160/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.29% <0.00%> (-0.05%)` | :arrow_down: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18160/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `47.48% <100.00%> (+0.02%)` | :arrow_up: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18160/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.57% <0.00%> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18160?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...oodieBackedTableMetadataWriterTableVersionSix.java](https://app.codecov.io/gh/apache/hudi/pull/18160?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriterTableVersionSix.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXJUYWJsZVZlcnNpb25TaXguamF2YQ==) | `72.44% <100.00%> (ø)` | | ... and [6 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18160/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) :rocket: New features to boost your workflow: - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] fix(table-services): When applying rollback metadata to metadata table (v6) do not rollback a metadata table deltacommit if it has been already rolled back by post-commit rollback [hudi]
codecov-commenter commented on PR #18160: URL: https://github.com/apache/hudi/pull/18160#issuecomment-3982749880 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18160?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 57.32%. Comparing base ([`1203b21`](https://app.codecov.io/gh/apache/hudi/commit/1203b215b03cb5c76fffb46a360efe0c4ce21fe0?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`433b7bc`](https://app.codecov.io/gh/apache/hudi/commit/433b7bcc69dabc9983fc6fedd1572b57ad7d9c9d?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). Additional details and impacted files ```diff @@Coverage Diff@@ ## master #18160 +/- ## = Coverage 57.31% 57.32% - Complexity1860218604+2 = Files 1948 1948 Lines106580 106580 Branches 1317413174 = + Hits 6108561094+9 + Misses3973439728-6 + Partials 5761 5758-3 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18160/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18160/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.29% <0.00%> (-0.05%)` | :arrow_down: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18160/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `47.45% <100.00%> (-0.02%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18160/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.57% <0.00%> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18160?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...oodieBackedTableMetadataWriterTableVersionSix.java](https://app.codecov.io/gh/apache/hudi/pull/18160?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriterTableVersionSix.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXJUYWJsZVZlcnNpb25TaXguamF2YQ==) | `72.44% <100.00%> (ø)` | | ... and [7 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18160/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) :rocket: New features to boost your workflow: - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] fix(table-services): When applying rollback metadata to metadata table (v6) do not rollback a metadata table deltacommit if it has been already rolled back by post-commit rollback [hudi]
codecov-commenter commented on PR #18160: URL: https://github.com/apache/hudi/pull/18160#issuecomment-3982748400 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18160?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 57.32%. Comparing base ([`1203b21`](https://app.codecov.io/gh/apache/hudi/commit/1203b215b03cb5c76fffb46a360efe0c4ce21fe0?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`433b7bc`](https://app.codecov.io/gh/apache/hudi/commit/433b7bcc69dabc9983fc6fedd1572b57ad7d9c9d?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). Additional details and impacted files ```diff @@Coverage Diff@@ ## master #18160 +/- ## = Coverage 57.31% 57.32% - Complexity1860218604+2 = Files 1948 1948 Lines106580 106580 Branches 1317413174 = + Hits 6108561094+9 + Misses3973439728-6 + Partials 5761 5758-3 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18160/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18160/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.29% <0.00%> (-0.05%)` | :arrow_down: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18160/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `47.45% <100.00%> (-0.02%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18160/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.57% <0.00%> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18160?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...oodieBackedTableMetadataWriterTableVersionSix.java](https://app.codecov.io/gh/apache/hudi/pull/18160?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriterTableVersionSix.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXJUYWJsZVZlcnNpb25TaXguamF2YQ==) | `72.44% <100.00%> (ø)` | | ... and [7 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18160/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) :rocket: New features to boost your workflow: - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] fix(table-services): When applying rollback metadata to metadata table (v6) do not rollback a metadata table deltacommit if it has been already rolled back by post-commit rollback [hudi]
codecov-commenter commented on PR #18160: URL: https://github.com/apache/hudi/pull/18160#issuecomment-3982689162 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18160?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 55.50%. Comparing base ([`1203b21`](https://app.codecov.io/gh/apache/hudi/commit/1203b215b03cb5c76fffb46a360efe0c4ce21fe0?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`433b7bc`](https://app.codecov.io/gh/apache/hudi/commit/433b7bcc69dabc9983fc6fedd1572b57ad7d9c9d?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18160 +/- ## - Coverage 55.56% 55.50% -0.07% + Complexity1797817951 -27 Files 1948 1948 Lines106580 106580 Branches 1317413174 - Hits 5922459156 -68 - Misses4152641585 +59 - Partials 5830 5839 +9 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18160/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18160/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.29% <0.00%> (-0.05%)` | :arrow_down: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18160/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `43.38% <100.00%> (-0.11%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18160/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.57% <0.00%> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18160?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...oodieBackedTableMetadataWriterTableVersionSix.java](https://app.codecov.io/gh/apache/hudi/pull/18160?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriterTableVersionSix.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXJUYWJsZVZlcnNpb25TaXguamF2YQ==) | `57.14% <100.00%> (ø)` | | ... and [28 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18160/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) :rocket: New features to boost your workflow: - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] fix(table-services): When applying rollback metadata to metadata table (v6) do not rollback a metadata table deltacommit if it has been already rolled back by post-commit rollback [hudi]
codecov-commenter commented on PR #18160: URL: https://github.com/apache/hudi/pull/18160#issuecomment-3982691320 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18160?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 55.57%. Comparing base ([`1203b21`](https://app.codecov.io/gh/apache/hudi/commit/1203b215b03cb5c76fffb46a360efe0c4ce21fe0?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`433b7bc`](https://app.codecov.io/gh/apache/hudi/commit/433b7bcc69dabc9983fc6fedd1572b57ad7d9c9d?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). Additional details and impacted files ```diff @@Coverage Diff@@ ## master #18160 +/- ## = Coverage 55.56% 55.57% - Complexity1797817980+2 = Files 1948 1948 Lines106580 106580 Branches 1317413174 = + Hits 5922459229+5 + Misses4152641524-2 + Partials 5830 5827-3 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18160/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18160/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.29% <0.00%> (-0.05%)` | :arrow_down: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18160/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `43.51% <100.00%> (+0.01%)` | :arrow_up: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18160/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.57% <0.00%> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18160?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...oodieBackedTableMetadataWriterTableVersionSix.java](https://app.codecov.io/gh/apache/hudi/pull/18160?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriterTableVersionSix.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXJUYWJsZVZlcnNpb25TaXguamF2YQ==) | `57.14% <100.00%> (ø)` | | ... and [4 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18160/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) :rocket: New features to boost your workflow: - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] fix(table-services): When applying rollback metadata to metadata table (v6) do not rollback a metadata table deltacommit if it has been already rolled back by post-commit rollback [hudi]
codecov-commenter commented on PR #18160: URL: https://github.com/apache/hudi/pull/18160#issuecomment-3982682732 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18160?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 55.34%. Comparing base ([`1203b21`](https://app.codecov.io/gh/apache/hudi/commit/1203b215b03cb5c76fffb46a360efe0c4ce21fe0?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`433b7bc`](https://app.codecov.io/gh/apache/hudi/commit/433b7bcc69dabc9983fc6fedd1572b57ad7d9c9d?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18160 +/- ## - Coverage 55.56% 55.34% -0.23% + Complexity1797817917 -61 Files 1948 1948 Lines106580 106580 Branches 1317413174 - Hits 5922458984 -240 - Misses4152641778 +252 + Partials 5830 5818 -12 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18160/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18160/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.29% <0.00%> (-0.05%)` | :arrow_down: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18160/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `43.18% <100.00%> (-0.31%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18160/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.57% <0.00%> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18160?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...oodieBackedTableMetadataWriterTableVersionSix.java](https://app.codecov.io/gh/apache/hudi/pull/18160?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriterTableVersionSix.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXJUYWJsZVZlcnNpb25TaXguamF2YQ==) | `57.14% <100.00%> (ø)` | | ... and [45 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18160/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) :rocket: New features to boost your workflow: - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] fix(table-services): When applying rollback metadata to metadata table (v6) do not rollback a metadata table deltacommit if it has been already rolled back by post-commit rollback [hudi]
codecov-commenter commented on PR #18160: URL: https://github.com/apache/hudi/pull/18160#issuecomment-3982680152 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18160?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 55.29%. Comparing base ([`1203b21`](https://app.codecov.io/gh/apache/hudi/commit/1203b215b03cb5c76fffb46a360efe0c4ce21fe0?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`433b7bc`](https://app.codecov.io/gh/apache/hudi/commit/433b7bcc69dabc9983fc6fedd1572b57ad7d9c9d?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18160 +/- ## - Coverage 55.56% 55.29% -0.28% + Complexity1797817899 -79 Files 1948 1948 Lines106580 106580 Branches 1317413174 - Hits 5922458930 -294 - Misses4152641834 +308 + Partials 5830 5816 -14 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18160/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18160/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.29% <0.00%> (-0.05%)` | :arrow_down: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18160/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `43.18% <100.00%> (-0.31%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18160/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.48% <0.00%> (-0.09%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18160?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...oodieBackedTableMetadataWriterTableVersionSix.java](https://app.codecov.io/gh/apache/hudi/pull/18160?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriterTableVersionSix.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXJUYWJsZVZlcnNpb25TaXguamF2YQ==) | `57.14% <100.00%> (ø)` | | ... and [53 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18160/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) :rocket: New features to boost your workflow: - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] fix(table-services): When applying rollback metadata to metadata table (v6) do not rollback a metadata table deltacommit if it has been already rolled back by post-commit rollback [hudi]
codecov-commenter commented on PR #18160: URL: https://github.com/apache/hudi/pull/18160#issuecomment-3982675208 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18160?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 51.75%. Comparing base ([`1203b21`](https://app.codecov.io/gh/apache/hudi/commit/1203b215b03cb5c76fffb46a360efe0c4ce21fe0?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`433b7bc`](https://app.codecov.io/gh/apache/hudi/commit/433b7bcc69dabc9983fc6fedd1572b57ad7d9c9d?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18160 +/- ## - Coverage 55.56% 51.75% -3.81% + Complexity1797816592-1386 Files 1948 1948 Lines106580 106580 Branches 1317413174 - Hits 5922455165-4059 - Misses4152645467+3941 - Partials 5830 5948 +118 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18160/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18160/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.29% <0.00%> (-0.05%)` | :arrow_down: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18160/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.23% <100.00%> (-10.27%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18160/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.35% <0.00%> (-0.22%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18160?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...oodieBackedTableMetadataWriterTableVersionSix.java](https://app.codecov.io/gh/apache/hudi/pull/18160?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriterTableVersionSix.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXJUYWJsZVZlcnNpb25TaXguamF2YQ==) | `57.14% <100.00%> (ø)` | | ... and [394 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18160/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) :rocket: New features to boost your workflow: - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] fix(table-services): When applying rollback metadata to metadata table (v6) do not rollback a metadata table deltacommit if it has been already rolled back by post-commit rollback [hudi]
codecov-commenter commented on PR #18160: URL: https://github.com/apache/hudi/pull/18160#issuecomment-3982624933 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18160?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 43.49%. Comparing base ([`1203b21`](https://app.codecov.io/gh/apache/hudi/commit/1203b215b03cb5c76fffb46a360efe0c4ce21fe0?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`433b7bc`](https://app.codecov.io/gh/apache/hudi/commit/433b7bcc69dabc9983fc6fedd1572b57ad7d9c9d?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). Additional details and impacted files ```diff @@Coverage Diff@@ ## master #18160 +/- ## = Coverage 43.49% 43.49% Complexity1386213862 = Files 1948 1948 Lines106580 106580 Branches 1317413174 = + Hits 4636046361+1 Misses5490154901 + Partials 5319 5318-1 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18160/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18160/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.29% <0.00%> (-0.05%)` | :arrow_down: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18160/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.23% <100.00%> (+<0.01%)` | :arrow_up: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18160/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.16% <0.00%> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18160?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...oodieBackedTableMetadataWriterTableVersionSix.java](https://app.codecov.io/gh/apache/hudi/pull/18160?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriterTableVersionSix.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXJUYWJsZVZlcnNpb25TaXguamF2YQ==) | `57.14% <100.00%> (ø)` | | ... and [1 file with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18160/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) :rocket: New features to boost your workflow: - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] fix(table-services): When applying rollback metadata to metadata table (v6) do not rollback a metadata table deltacommit if it has been already rolled back by post-commit rollback [hudi]
codecov-commenter commented on PR #18160: URL: https://github.com/apache/hudi/pull/18160#issuecomment-3982621718 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18160?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 43.46%. Comparing base ([`1203b21`](https://app.codecov.io/gh/apache/hudi/commit/1203b215b03cb5c76fffb46a360efe0c4ce21fe0?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`433b7bc`](https://app.codecov.io/gh/apache/hudi/commit/433b7bcc69dabc9983fc6fedd1572b57ad7d9c9d?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18160 +/- ## - Coverage 43.49% 43.46% -0.04% + Complexity1386213852 -10 Files 1948 1948 Lines106580 106580 Branches 1317413174 - Hits 4636046325 -35 - Misses5490154933 +32 - Partials 5319 5322 +3 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18160/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18160/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.29% <0.00%> (-0.05%)` | :arrow_down: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18160/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.68% <100.00%> (+0.45%)` | :arrow_up: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18160/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.16% <0.00%> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18160?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...oodieBackedTableMetadataWriterTableVersionSix.java](https://app.codecov.io/gh/apache/hudi/pull/18160?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriterTableVersionSix.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXJUYWJsZVZlcnNpb25TaXguamF2YQ==) | `57.14% <100.00%> (ø)` | | ... and [8 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18160/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) :rocket: New features to boost your workflow: - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] fix(table-services): When applying rollback metadata to metadata table (v6) do not rollback a metadata table deltacommit if it has been already rolled back by post-commit rollback [hudi]
codecov-commenter commented on PR #18160: URL: https://github.com/apache/hudi/pull/18160#issuecomment-3982621297 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18160?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 43.46%. Comparing base ([`1203b21`](https://app.codecov.io/gh/apache/hudi/commit/1203b215b03cb5c76fffb46a360efe0c4ce21fe0?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`433b7bc`](https://app.codecov.io/gh/apache/hudi/commit/433b7bcc69dabc9983fc6fedd1572b57ad7d9c9d?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18160 +/- ## - Coverage 43.49% 43.46% -0.04% + Complexity1386213852 -10 Files 1948 1948 Lines106580 106580 Branches 1317413174 - Hits 4636046325 -35 - Misses5490154933 +32 - Partials 5319 5322 +3 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18160/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18160/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.29% <0.00%> (-0.05%)` | :arrow_down: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18160/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.68% <100.00%> (+0.45%)` | :arrow_up: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18160/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.16% <0.00%> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18160?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...oodieBackedTableMetadataWriterTableVersionSix.java](https://app.codecov.io/gh/apache/hudi/pull/18160?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriterTableVersionSix.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXJUYWJsZVZlcnNpb25TaXguamF2YQ==) | `57.14% <100.00%> (ø)` | | ... and [8 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18160/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) :rocket: New features to boost your workflow: - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] fix(table-services): When applying rollback metadata to metadata table (v6) do not rollback a metadata table deltacommit if it has been already rolled back by post-commit rollback [hudi]
codecov-commenter commented on PR #18160: URL: https://github.com/apache/hudi/pull/18160#issuecomment-3982609394 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18160?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `0%` with `1 line` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 39.68%. Comparing base ([`1203b21`](https://app.codecov.io/gh/apache/hudi/commit/1203b215b03cb5c76fffb46a360efe0c4ce21fe0?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`433b7bc`](https://app.codecov.io/gh/apache/hudi/commit/433b7bcc69dabc9983fc6fedd1572b57ad7d9c9d?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18160?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...oodieBackedTableMetadataWriterTableVersionSix.java](https://app.codecov.io/gh/apache/hudi/pull/18160?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriterTableVersionSix.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXJUYWJsZVZlcnNpb25TaXguamF2YQ==) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18160?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18160 +/- ## - Coverage 43.49% 39.68% -3.82% + Complexity1386212601-1261 Files 1948 1948 Lines106580 106580 Branches 1317413174 - Hits 4636042298-4062 - Misses5490159200+4299 + Partials 5319 5082 -237 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18160/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18160/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.29% <0.00%> (-0.05%)` | :arrow_down: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18160/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18160/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.16% <0.00%> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18160?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...oodieBackedTableMetadataWriterTableVersionSix.java](https://app.codecov.io/gh/apache/hudi/pull/18160?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriterTableVersionSix.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXJUYWJsZVZlcnNpb25TaXguamF2YQ==) | `29.59% <0.00%> (-27.56%)` | :arrow_down: | ... and [288 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18160/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) :rocket: New features to boost your workflow: - :snowflake:
Re: [PR] fix(table-services): When applying rollback metadata to metadata table (v6) do not rollback a metadata table deltacommit if it has been already rolled back by post-commit rollback [hudi]
codecov-commenter commented on PR #18160: URL: https://github.com/apache/hudi/pull/18160#issuecomment-3982604588 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18160?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `0%` with `1 line` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 40.49%. Comparing base ([`1203b21`](https://app.codecov.io/gh/apache/hudi/commit/1203b215b03cb5c76fffb46a360efe0c4ce21fe0?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`433b7bc`](https://app.codecov.io/gh/apache/hudi/commit/433b7bcc69dabc9983fc6fedd1572b57ad7d9c9d?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18160?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...oodieBackedTableMetadataWriterTableVersionSix.java](https://app.codecov.io/gh/apache/hudi/pull/18160?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriterTableVersionSix.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXJUYWJsZVZlcnNpb25TaXguamF2YQ==) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18160?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18160 +/- ## - Coverage 43.49% 40.49% -3.01% + Complexity1386212264-1598 Files 1948 1914 -34 Lines106580 101829-4751 Branches 1317412076-1098 - Hits 4636041234-5126 - Misses5490155748 +847 + Partials 5319 4847 -472 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18160/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18160/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.29% <0.00%> (-0.05%)` | :arrow_down: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18160/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18160/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.65% <0.00%> (+0.49%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18160?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...oodieBackedTableMetadataWriterTableVersionSix.java](https://app.codecov.io/gh/apache/hudi/pull/18160?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriterTableVersionSix.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXJUYWJsZVZlcnNpb25TaXguamF2YQ==) | `29.59% <0.00%> (-27.56%)` | :arrow_down: | ... and [355 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18160/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) :rocket: New features to boost your workflow:
Re: [PR] fix(table-services): When applying rollback metadata to metadata table (v6) do not rollback a metadata table deltacommit if it has been already rolled back by post-commit rollback [hudi]
codecov-commenter commented on PR #18160: URL: https://github.com/apache/hudi/pull/18160#issuecomment-3982520803 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18160?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `0%` with `1 line` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 45.29%. Comparing base ([`1203b21`](https://app.codecov.io/gh/apache/hudi/commit/1203b215b03cb5c76fffb46a360efe0c4ce21fe0?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`433b7bc`](https://app.codecov.io/gh/apache/hudi/commit/433b7bcc69dabc9983fc6fedd1572b57ad7d9c9d?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18160?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...oodieBackedTableMetadataWriterTableVersionSix.java](https://app.codecov.io/gh/apache/hudi/pull/18160?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriterTableVersionSix.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXJUYWJsZVZlcnNpb25TaXguamF2YQ==) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18160?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18160 +/- ## - Coverage 45.33% 45.29% -0.05% + Complexity 8393 8379 -14 Files 1180 1180 Lines 6055160551 Branches 6454 6454 - Hits 2745327428 -25 - Misses3011430144 +30 + Partials 2984 2979 -5 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18160/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18160/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.29% <0.00%> (-0.05%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18160?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...oodieBackedTableMetadataWriterTableVersionSix.java](https://app.codecov.io/gh/apache/hudi/pull/18160?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriterTableVersionSix.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXJUYWJsZVZlcnNpb25TaXguamF2YQ==) | `0.00% <0.00%> (ø)` | | ... and [7 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18160/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) :rocket: New features to boost your workflow: - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] fix(table-services): When applying rollback metadata to metadata table (v6) do not rollback a metadata table deltacommit if it has been already rolled back by post-commit rollback [hudi]
hudi-bot commented on PR #18160: URL: https://github.com/apache/hudi/pull/18160#issuecomment-3982487643 ## CI report: * 171f178fc04b3925ae532071c1d285f08e82515c Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12175) * 433b7bcc69dabc9983fc6fedd1572b57ad7d9c9d Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12363) Bot commands @hudi-bot supports the following commands: - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] fix(table-services): When applying rollback metadata to metadata table (v6) do not rollback a metadata table deltacommit if it has been already rolled back by post-commit rollback [hudi]
hudi-bot commented on PR #18160: URL: https://github.com/apache/hudi/pull/18160#issuecomment-3982479666 ## CI report: * 171f178fc04b3925ae532071c1d285f08e82515c Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12175) * 433b7bcc69dabc9983fc6fedd1572b57ad7d9c9d UNKNOWN Bot commands @hudi-bot supports the following commands: - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] fix(table-services) When applying rollback metadata to metadata table (v6) do not rollback a metadata table deltacommit if it has been already rolled back by post-commit rollback [hudi]
hudi-bot commented on PR #18160: URL: https://github.com/apache/hudi/pull/18160#issuecomment-3938062946 ## CI report: * 171f178fc04b3925ae532071c1d285f08e82515c Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12175) Bot commands @hudi-bot supports the following commands: - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] fix(table-services) When applying rollback metadata to metadata table (v6) do not rollback a metadata table deltacommit if it has been already rolled back by post-commit rollback [hudi]
hudi-bot commented on PR #18160: URL: https://github.com/apache/hudi/pull/18160#issuecomment-3937887410 ## CI report: * e282a3baacb71cc14c0d5299d04b052be9dc72e1 Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12094) * 171f178fc04b3925ae532071c1d285f08e82515c Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12175) Bot commands @hudi-bot supports the following commands: - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] fix(table-services) When applying rollback metadata to metadata table (v6) do not rollback a metadata table deltacommit if it has been already rolled back by post-commit rollback [hudi]
hudi-bot commented on PR #18160: URL: https://github.com/apache/hudi/pull/18160#issuecomment-3937884543 ## CI report: * e282a3baacb71cc14c0d5299d04b052be9dc72e1 Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12094) * 171f178fc04b3925ae532071c1d285f08e82515c UNKNOWN Bot commands @hudi-bot supports the following commands: - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] fix(table-services) When applying rollback metadata to metadata table (v6) do not rollback a metadata table deltacommit if it has been already rolled back by post-commit rollback [hudi]
nsivabalan commented on PR #18160: URL: https://github.com/apache/hudi/pull/18160#issuecomment-3928779156 hey @kbuci : can you follow up on CI failures -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] fix(table-services) When applying rollback metadata to metadata table (v6) do not rollback a metadata table deltacommit if it has been already rolled back by post-commit rollback [hudi]
kbuci commented on PR #18160: URL: https://github.com/apache/hudi/pull/18160#issuecomment-3923085307 > thanks for the explanation. > > would it be possible to write tests? seems very intricate one. just wanted to guard if someone tries to optimize this code in future. thanks added test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] fix(table-services) When applying rollback metadata to metadata table (v6) do not rollback a metadata table deltacommit if it has been already rolled back by post-commit rollback [hudi]
hudi-bot commented on PR #18160: URL: https://github.com/apache/hudi/pull/18160#issuecomment-3917507464 ## CI report: * e282a3baacb71cc14c0d5299d04b052be9dc72e1 Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12094) Bot commands @hudi-bot supports the following commands: - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] fix(table-services) When applying rollback metadata to metadata table (v6) do not rollback a metadata table deltacommit if it has been already rolled back by post-commit rollback [hudi]
hudi-bot commented on PR #18160: URL: https://github.com/apache/hudi/pull/18160#issuecomment-3917179276 ## CI report: * 5336e234c874aa1fb0251a7429e0aec5b0e75779 Azure: [FAILURE](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12008) * e282a3baacb71cc14c0d5299d04b052be9dc72e1 Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12094) Bot commands @hudi-bot supports the following commands: - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] fix(table-services) When applying rollback metadata to metadata table (v6) do not rollback a metadata table deltacommit if it has been already rolled back by post-commit rollback [hudi]
hudi-bot commented on PR #18160: URL: https://github.com/apache/hudi/pull/18160#issuecomment-3917168839 ## CI report: * 5336e234c874aa1fb0251a7429e0aec5b0e75779 Azure: [FAILURE](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12008) * e282a3baacb71cc14c0d5299d04b052be9dc72e1 UNKNOWN Bot commands @hudi-bot supports the following commands: - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] fix(table-services) When applying rollback metadata to metadata table (v6) do not rollback a metadata table deltacommit if it has been already rolled back by post-commit rollback [hudi]
hudi-bot commented on PR #18160: URL: https://github.com/apache/hudi/pull/18160#issuecomment-3894652564 ## CI report: * 5336e234c874aa1fb0251a7429e0aec5b0e75779 Azure: [FAILURE](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12008) Bot commands @hudi-bot supports the following commands: - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] fix(table-services) When applying rollback metadata to metadata table (v6) do not rollback a metadata table deltacommit if it has been already rolled back by post-commit rollback [hudi]
hudi-bot commented on PR #18160: URL: https://github.com/apache/hudi/pull/18160#issuecomment-3894502104 ## CI report: * ff7a5c1d85de5efba23ea8501231b18a1dcc962c Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=11885) * 5336e234c874aa1fb0251a7429e0aec5b0e75779 Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12008) Bot commands @hudi-bot supports the following commands: - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] fix(table-services) When applying rollback metadata to metadata table (v6) do not rollback a metadata table deltacommit if it has been already rolled back by post-commit rollback [hudi]
hudi-bot commented on PR #18160: URL: https://github.com/apache/hudi/pull/18160#issuecomment-3894496507 ## CI report: * ff7a5c1d85de5efba23ea8501231b18a1dcc962c Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=11885) * 5336e234c874aa1fb0251a7429e0aec5b0e75779 UNKNOWN Bot commands @hudi-bot supports the following commands: - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] fix(table-services) When applying rollback metadata to metadata table (v6) do not rollback a metadata table deltacommit if it has been already rolled back by post-commit rollback [hudi]
kbuci commented on PR #18160: URL: https://github.com/apache/hudi/pull/18160#issuecomment-3881836875 > Not sure I understand the exact sequence here. can you help me understand. > > Any write to mdt is guarded by data table lock and hence its fair to say, mdt is a single writer table. > > whenever we wanted to apply any commits or clean or rollback from data table to mdt, we instantiate a new mdt writer, apply the commit/clean/rollback and close it out. > > Which means, every new write to mdt, will always have updated mdt timeline. So, how come writer 2 could see a stale timeline in mdt, if writer 1 just happened to update mdt timeline. @nsivabalan Sure let me clarify, this isn't a multi-writer scenario actually. The scenario is: - The `processAndCommit` https://github.com/apache/hudi/pull/18160/changes#diff-65dd70e3cb912c49b3972598c897e47c8ef08f687789f86cb33f567006ef50e9R215 above runs - It indirectly calls `commitInternal` - Which then calls `metadataMetaClient = rollbackFailedWrites(dataWriteConfig, writeClient, metadataMetaClient);` And then rolls back inflight deltacommits in MDT timeline, including the target `deltaCommitInstant` of the rollback. Although this above rollback call reloads the MDT metaclient/timeline, when we get to https://github.com/apache/hudi/pull/18160/changes#diff-65dd70e3cb912c49b3972598c897e47c8ef08f687789f86cb33f567006ef50e9L218 we don't see this refreshed timeline. And hence we attempt to rollback a deltacommit in MDT timeline that was already rolled back. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] fix(table-services) When applying rollback metadata to metadata table (v6) do not rollback a metadata table deltacommit if it has been already rolled back by post-commit rollback [hudi]
hudi-bot commented on PR #18160: URL: https://github.com/apache/hudi/pull/18160#issuecomment-3876823856 ## CI report: * ff7a5c1d85de5efba23ea8501231b18a1dcc962c Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=11885) Bot commands @hudi-bot supports the following commands: - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] fix(table-services) When applying rollback metadata to metadata table (v6) do not rollback a metadata table deltacommit if it has been already rolled back by post-commit rollback [hudi]
hudi-bot commented on PR #18160: URL: https://github.com/apache/hudi/pull/18160#issuecomment-3875180051 ## CI report: * ff7a5c1d85de5efba23ea8501231b18a1dcc962c Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=11885) Bot commands @hudi-bot supports the following commands: - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] fix(table-services) When applying rollback metadata to metadata table (v6) do not rollback a metadata table deltacommit if it has been already rolled back by post-commit rollback [hudi]
hudi-bot commented on PR #18160: URL: https://github.com/apache/hudi/pull/18160#issuecomment-3875172975 ## CI report: * ff7a5c1d85de5efba23ea8501231b18a1dcc962c UNKNOWN Bot commands @hudi-bot supports the following commands: - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
