Re: [PR] fix: Skip pre-compaction rollback metadata reads in getValidInstantTimestamps [hudi]
yihua merged PR #18544: URL: https://github.com/apache/hudi/pull/18544 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] fix: Skip pre-compaction rollback metadata reads in getValidInstantTimestamps [hudi]
hudi-bot commented on PR #18544: URL: https://github.com/apache/hudi/pull/18544#issuecomment-4493038171 ## CI report: * f1bd5e62e2ca8a346f20d2e095864efea9297ba1 Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=14121) Bot commands @hudi-bot supports the following commands: - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] fix: Skip pre-compaction rollback metadata reads in getValidInstantTimestamps [hudi]
codecov-commenter commented on PR #18544: URL: https://github.com/apache/hudi/pull/18544#issuecomment-4493026069 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18544?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 68.19%. Comparing base ([`642d88c`](https://app.codecov.io/gh/apache/hudi/commit/642d88c594ff11048aeb6f5333f2eb01af47d40c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`f1bd5e6`](https://app.codecov.io/gh/apache/hudi/commit/f1bd5e62e2ca8a346f20d2e095864efea9297ba1?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18544 +/- ## - Coverage 68.20% 68.19% -0.01% - Complexity2923129243 +12 Files 2525 2525 Lines141667 141675 +8 Branches 1759117589 -2 Hits 9662196621 - Misses3709437101 +7 - Partials 7952 7953 +1 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.35% <100.00%> (+<0.01%)` | :arrow_up: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.98% <100.00%> (+<0.01%)` | :arrow_up: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.30% <100.00%> (+<0.01%)` | :arrow_up: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.84% <100.00%> (+0.01%)` | :arrow_up: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.94% <100.00%> (+<0.01%)` | :arrow_up: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.47% <100.00%> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18544?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [.../apache/hudi/metadata/HoodieTableMetadataUtil.java](https://app.codecov.io/gh/apache/hudi/pull/18544?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieTableMetadataUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvbWV0YWRhdGEvSG9vZGllVGFibGVNZXRhZGF0YVV0aWwuamF2YQ==) | `82.55% <100.00%> (+0.10%)` | :arrow_up: | ... and [10 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18544/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) :rocket: New features to boost your workflow: - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubs
Re: [PR] fix: Skip pre-compaction rollback metadata reads in getValidInstantTimestamps [hudi]
codecov-commenter commented on PR #18544: URL: https://github.com/apache/hudi/pull/18544#issuecomment-4493013383 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18544?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 68.19%. Comparing base ([`642d88c`](https://app.codecov.io/gh/apache/hudi/commit/642d88c594ff11048aeb6f5333f2eb01af47d40c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`f1bd5e6`](https://app.codecov.io/gh/apache/hudi/commit/f1bd5e62e2ca8a346f20d2e095864efea9297ba1?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18544 +/- ## - Coverage 68.20% 68.19% -0.01% - Complexity2923129242 +11 Files 2525 2525 Lines141667 141675 +8 Branches 1759117589 -2 - Hits 9662196619 -2 - Misses3709437102 +8 - Partials 7952 7954 +2 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.35% <100.00%> (+<0.01%)` | :arrow_up: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.98% <100.00%> (+<0.01%)` | :arrow_up: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.30% <100.00%> (+<0.01%)` | :arrow_up: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.83% <100.00%> (-0.01%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.94% <100.00%> (+<0.01%)` | :arrow_up: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.47% <100.00%> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18544?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [.../apache/hudi/metadata/HoodieTableMetadataUtil.java](https://app.codecov.io/gh/apache/hudi/pull/18544?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieTableMetadataUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvbWV0YWRhdGEvSG9vZGllVGFibGVNZXRhZGF0YVV0aWwuamF2YQ==) | `82.55% <100.00%> (+0.10%)` | :arrow_up: | ... and [10 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18544/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) :rocket: New features to boost your workflow: - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsu
Re: [PR] fix: Skip pre-compaction rollback metadata reads in getValidInstantTimestamps [hudi]
codecov-commenter commented on PR #18544: URL: https://github.com/apache/hudi/pull/18544#issuecomment-4493003149 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18544?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 68.19%. Comparing base ([`642d88c`](https://app.codecov.io/gh/apache/hudi/commit/642d88c594ff11048aeb6f5333f2eb01af47d40c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`f1bd5e6`](https://app.codecov.io/gh/apache/hudi/commit/f1bd5e62e2ca8a346f20d2e095864efea9297ba1?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18544 +/- ## - Coverage 68.20% 68.19% -0.01% - Complexity2923129242 +11 Files 2525 2525 Lines141667 141675 +8 Branches 1759117589 -2 - Hits 9662196619 -2 - Misses3709437102 +8 - Partials 7952 7954 +2 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.35% <100.00%> (+<0.01%)` | :arrow_up: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.98% <100.00%> (+<0.01%)` | :arrow_up: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.30% <100.00%> (+<0.01%)` | :arrow_up: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.80% <100.00%> (-0.04%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.94% <100.00%> (+<0.01%)` | :arrow_up: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.47% <100.00%> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18544?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [.../apache/hudi/metadata/HoodieTableMetadataUtil.java](https://app.codecov.io/gh/apache/hudi/pull/18544?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieTableMetadataUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvbWV0YWRhdGEvSG9vZGllVGFibGVNZXRhZGF0YVV0aWwuamF2YQ==) | `82.55% <100.00%> (+0.10%)` | :arrow_up: | ... and [10 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18544/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) :rocket: New features to boost your workflow: - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsu
Re: [PR] fix: Skip pre-compaction rollback metadata reads in getValidInstantTimestamps [hudi]
codecov-commenter commented on PR #18544: URL: https://github.com/apache/hudi/pull/18544#issuecomment-4492949042 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18544?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 68.19%. Comparing base ([`642d88c`](https://app.codecov.io/gh/apache/hudi/commit/642d88c594ff11048aeb6f5333f2eb01af47d40c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`f1bd5e6`](https://app.codecov.io/gh/apache/hudi/commit/f1bd5e62e2ca8a346f20d2e095864efea9297ba1?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18544 +/- ## - Coverage 68.20% 68.19% -0.01% - Complexity2923129241 +10 Files 2525 2525 Lines141667 141675 +8 Branches 1759117589 -2 - Hits 9662196616 -5 - Misses3709437104 +10 - Partials 7952 7955 +3 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.35% <100.00%> (+<0.01%)` | :arrow_up: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.98% <100.00%> (+<0.01%)` | :arrow_up: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.30% <100.00%> (+<0.01%)` | :arrow_up: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.76% <100.00%> (-0.07%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.94% <100.00%> (+<0.01%)` | :arrow_up: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.47% <100.00%> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18544?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [.../apache/hudi/metadata/HoodieTableMetadataUtil.java](https://app.codecov.io/gh/apache/hudi/pull/18544?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieTableMetadataUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvbWV0YWRhdGEvSG9vZGllVGFibGVNZXRhZGF0YVV0aWwuamF2YQ==) | `82.55% <100.00%> (+0.10%)` | :arrow_up: | ... and [13 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18544/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) :rocket: New features to boost your workflow: - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsu
Re: [PR] fix: Skip pre-compaction rollback metadata reads in getValidInstantTimestamps [hudi]
codecov-commenter commented on PR #18544: URL: https://github.com/apache/hudi/pull/18544#issuecomment-4492932873 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18544?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 68.16%. Comparing base ([`642d88c`](https://app.codecov.io/gh/apache/hudi/commit/642d88c594ff11048aeb6f5333f2eb01af47d40c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`f1bd5e6`](https://app.codecov.io/gh/apache/hudi/commit/f1bd5e62e2ca8a346f20d2e095864efea9297ba1?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18544 +/- ## - Coverage 68.20% 68.16% -0.05% + Complexity2923129218 -13 Files 2525 2525 Lines141667 141675 +8 Branches 1759117589 -2 - Hits 9662196566 -55 - Misses3709437161 +67 + Partials 7952 7948 -4 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.35% <100.00%> (+<0.01%)` | :arrow_up: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.98% <100.00%> (+<0.01%)` | :arrow_up: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.30% <100.00%> (+<0.01%)` | :arrow_up: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.76% <100.00%> (-0.07%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.86% <100.00%> (-0.09%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.47% <100.00%> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18544?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [.../apache/hudi/metadata/HoodieTableMetadataUtil.java](https://app.codecov.io/gh/apache/hudi/pull/18544?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieTableMetadataUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvbWV0YWRhdGEvSG9vZGllVGFibGVNZXRhZGF0YVV0aWwuamF2YQ==) | `82.55% <100.00%> (+0.10%)` | :arrow_up: | ... and [18 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18544/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) :rocket: New features to boost your workflow: - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-uns
Re: [PR] fix: Skip pre-compaction rollback metadata reads in getValidInstantTimestamps [hudi]
codecov-commenter commented on PR #18544: URL: https://github.com/apache/hudi/pull/18544#issuecomment-4492911284 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18544?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 68.12%. Comparing base ([`642d88c`](https://app.codecov.io/gh/apache/hudi/commit/642d88c594ff11048aeb6f5333f2eb01af47d40c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`f1bd5e6`](https://app.codecov.io/gh/apache/hudi/commit/f1bd5e62e2ca8a346f20d2e095864efea9297ba1?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18544 +/- ## - Coverage 68.20% 68.12% -0.09% + Complexity2923129203 -28 Files 2525 2525 Lines141667 141675 +8 Branches 1759117589 -2 - Hits 9662196512 -109 - Misses3709437220 +126 + Partials 7952 7943 -9 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.35% <100.00%> (+<0.01%)` | :arrow_up: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.98% <100.00%> (+<0.01%)` | :arrow_up: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.30% <100.00%> (+<0.01%)` | :arrow_up: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.74% <100.00%> (-0.09%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.77% <100.00%> (-0.17%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.47% <100.00%> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18544?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [.../apache/hudi/metadata/HoodieTableMetadataUtil.java](https://app.codecov.io/gh/apache/hudi/pull/18544?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieTableMetadataUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvbWV0YWRhdGEvSG9vZGllVGFibGVNZXRhZGF0YVV0aWwuamF2YQ==) | `82.55% <100.00%> (+0.10%)` | :arrow_up: | ... and [30 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18544/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) :rocket: New features to boost your workflow: - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-uns
Re: [PR] fix: Skip pre-compaction rollback metadata reads in getValidInstantTimestamps [hudi]
codecov-commenter commented on PR #18544: URL: https://github.com/apache/hudi/pull/18544#issuecomment-4492903259 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18544?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 68.10%. Comparing base ([`642d88c`](https://app.codecov.io/gh/apache/hudi/commit/642d88c594ff11048aeb6f5333f2eb01af47d40c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`f1bd5e6`](https://app.codecov.io/gh/apache/hudi/commit/f1bd5e62e2ca8a346f20d2e095864efea9297ba1?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18544 +/- ## - Coverage 68.20% 68.10% -0.10% + Complexity2923129196 -35 Files 2525 2525 Lines141667 141675 +8 Branches 1759117589 -2 - Hits 9662196494 -127 - Misses3709437242 +148 + Partials 7952 7939 -13 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.35% <100.00%> (+<0.01%)` | :arrow_up: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.98% <100.00%> (+<0.01%)` | :arrow_up: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.30% <100.00%> (+<0.01%)` | :arrow_up: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.71% <100.00%> (-0.13%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.77% <100.00%> (-0.17%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.47% <100.00%> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18544?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [.../apache/hudi/metadata/HoodieTableMetadataUtil.java](https://app.codecov.io/gh/apache/hudi/pull/18544?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieTableMetadataUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvbWV0YWRhdGEvSG9vZGllVGFibGVNZXRhZGF0YVV0aWwuamF2YQ==) | `82.55% <100.00%> (+0.10%)` | :arrow_up: | ... and [32 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18544/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) :rocket: New features to boost your workflow: - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-uns
Re: [PR] fix: Skip pre-compaction rollback metadata reads in getValidInstantTimestamps [hudi]
codecov-commenter commented on PR #18544: URL: https://github.com/apache/hudi/pull/18544#issuecomment-4492897724 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18544?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 67.97%. Comparing base ([`642d88c`](https://app.codecov.io/gh/apache/hudi/commit/642d88c594ff11048aeb6f5333f2eb01af47d40c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`f1bd5e6`](https://app.codecov.io/gh/apache/hudi/commit/f1bd5e62e2ca8a346f20d2e095864efea9297ba1?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18544 +/- ## - Coverage 68.20% 67.97% -0.23% + Complexity2923129105 -126 Files 2525 2525 Lines141667 141675 +8 Branches 1759117589 -2 - Hits 9662196303 -318 - Misses3709437431 +337 + Partials 7952 7941 -11 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.35% <100.00%> (+<0.01%)` | :arrow_up: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.98% <100.00%> (+<0.01%)` | :arrow_up: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.30% <100.00%> (+<0.01%)` | :arrow_up: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `46.08% <100.00%> (-2.76%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.77% <100.00%> (-0.17%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.47% <100.00%> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18544?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [.../apache/hudi/metadata/HoodieTableMetadataUtil.java](https://app.codecov.io/gh/apache/hudi/pull/18544?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieTableMetadataUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvbWV0YWRhdGEvSG9vZGllVGFibGVNZXRhZGF0YVV0aWwuamF2YQ==) | `82.47% <100.00%> (+0.03%)` | :arrow_up: | ... and [64 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18544/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) :rocket: New features to boost your workflow: - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-uns
Re: [PR] fix: Skip pre-compaction rollback metadata reads in getValidInstantTimestamps [hudi]
codecov-commenter commented on PR #18544: URL: https://github.com/apache/hudi/pull/18544#issuecomment-4492882717 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18544?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 67.22%. Comparing base ([`642d88c`](https://app.codecov.io/gh/apache/hudi/commit/642d88c594ff11048aeb6f5333f2eb01af47d40c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`f1bd5e6`](https://app.codecov.io/gh/apache/hudi/commit/f1bd5e62e2ca8a346f20d2e095864efea9297ba1?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18544 +/- ## - Coverage 68.20% 67.22% -0.98% + Complexity2923128796 -435 Files 2525 2525 Lines141667 141675 +8 Branches 1759117589 -2 - Hits 9662195240-1381 - Misses3709438438+1344 - Partials 7952 7997 +45 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.35% <100.00%> (+<0.01%)` | :arrow_up: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.98% <100.00%> (+<0.01%)` | :arrow_up: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.30% <100.00%> (+<0.01%)` | :arrow_up: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `42.49% <100.00%> (-6.35%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.77% <100.00%> (-0.17%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.47% <100.00%> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18544?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [.../apache/hudi/metadata/HoodieTableMetadataUtil.java](https://app.codecov.io/gh/apache/hudi/pull/18544?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieTableMetadataUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvbWV0YWRhdGEvSG9vZGllVGFibGVNZXRhZGF0YVV0aWwuamF2YQ==) | `81.77% <100.00%> (-0.67%)` | :arrow_down: | ... and [182 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18544/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) :rocket: New features to boost your workflow: - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-
Re: [PR] fix: Skip pre-compaction rollback metadata reads in getValidInstantTimestamps [hudi]
codecov-commenter commented on PR #18544: URL: https://github.com/apache/hudi/pull/18544#issuecomment-4492859817 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18544?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 67.10%. Comparing base ([`642d88c`](https://app.codecov.io/gh/apache/hudi/commit/642d88c594ff11048aeb6f5333f2eb01af47d40c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`f1bd5e6`](https://app.codecov.io/gh/apache/hudi/commit/f1bd5e62e2ca8a346f20d2e095864efea9297ba1?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18544 +/- ## - Coverage 68.20% 67.10% -1.10% + Complexity2923128724 -507 Files 2525 2525 Lines141667 141675 +8 Branches 1759117589 -2 - Hits 9662195075-1546 - Misses3709438619+1525 - Partials 7952 7981 +29 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.35% <100.00%> (+<0.01%)` | :arrow_up: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.98% <100.00%> (+<0.01%)` | :arrow_up: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.30% <100.00%> (+<0.01%)` | :arrow_up: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `42.12% <100.00%> (-6.71%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.77% <100.00%> (-0.17%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.47% <100.00%> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18544?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [.../apache/hudi/metadata/HoodieTableMetadataUtil.java](https://app.codecov.io/gh/apache/hudi/pull/18544?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieTableMetadataUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvbWV0YWRhdGEvSG9vZGllVGFibGVNZXRhZGF0YVV0aWwuamF2YQ==) | `81.77% <100.00%> (-0.67%)` | :arrow_down: | ... and [194 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18544/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) :rocket: New features to boost your workflow: - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-
Re: [PR] fix: Skip pre-compaction rollback metadata reads in getValidInstantTimestamps [hudi]
codecov-commenter commented on PR #18544: URL: https://github.com/apache/hudi/pull/18544#issuecomment-4492839025 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18544?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 67.06%. Comparing base ([`642d88c`](https://app.codecov.io/gh/apache/hudi/commit/642d88c594ff11048aeb6f5333f2eb01af47d40c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`f1bd5e6`](https://app.codecov.io/gh/apache/hudi/commit/f1bd5e62e2ca8a346f20d2e095864efea9297ba1?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18544 +/- ## - Coverage 68.20% 67.06% -1.14% + Complexity2923128709 -522 Files 2525 2525 Lines141667 141675 +8 Branches 1759117589 -2 - Hits 9662195013-1608 - Misses3709438678+1584 - Partials 7952 7984 +32 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.35% <100.00%> (+<0.01%)` | :arrow_up: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.98% <100.00%> (+<0.01%)` | :arrow_up: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.30% <100.00%> (+<0.01%)` | :arrow_up: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `41.91% <100.00%> (-6.93%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.75% <100.00%> (-0.19%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.47% <100.00%> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18544?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [.../apache/hudi/metadata/HoodieTableMetadataUtil.java](https://app.codecov.io/gh/apache/hudi/pull/18544?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieTableMetadataUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvbWV0YWRhdGEvSG9vZGllVGFibGVNZXRhZGF0YVV0aWwuamF2YQ==) | `81.77% <100.00%> (-0.67%)` | :arrow_down: | ... and [209 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18544/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) :rocket: New features to boost your workflow: - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-
Re: [PR] fix: Skip pre-compaction rollback metadata reads in getValidInstantTimestamps [hudi]
codecov-commenter commented on PR #18544: URL: https://github.com/apache/hudi/pull/18544#issuecomment-4492840559 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18544?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 67.06%. Comparing base ([`642d88c`](https://app.codecov.io/gh/apache/hudi/commit/642d88c594ff11048aeb6f5333f2eb01af47d40c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`f1bd5e6`](https://app.codecov.io/gh/apache/hudi/commit/f1bd5e62e2ca8a346f20d2e095864efea9297ba1?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18544 +/- ## - Coverage 68.20% 67.06% -1.14% + Complexity2923128709 -522 Files 2525 2525 Lines141667 141675 +8 Branches 1759117589 -2 - Hits 9662195013-1608 - Misses3709438678+1584 - Partials 7952 7984 +32 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.35% <100.00%> (+<0.01%)` | :arrow_up: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.98% <100.00%> (+<0.01%)` | :arrow_up: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.30% <100.00%> (+<0.01%)` | :arrow_up: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `41.91% <100.00%> (-6.93%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.75% <100.00%> (-0.19%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.47% <100.00%> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18544?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [.../apache/hudi/metadata/HoodieTableMetadataUtil.java](https://app.codecov.io/gh/apache/hudi/pull/18544?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieTableMetadataUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvbWV0YWRhdGEvSG9vZGllVGFibGVNZXRhZGF0YVV0aWwuamF2YQ==) | `81.77% <100.00%> (-0.67%)` | :arrow_down: | ... and [209 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18544/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) :rocket: New features to boost your workflow: - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-
Re: [PR] fix: Skip pre-compaction rollback metadata reads in getValidInstantTimestamps [hudi]
codecov-commenter commented on PR #18544: URL: https://github.com/apache/hudi/pull/18544#issuecomment-4492785684 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18544?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 60.78%. Comparing base ([`642d88c`](https://app.codecov.io/gh/apache/hudi/commit/642d88c594ff11048aeb6f5333f2eb01af47d40c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`f1bd5e6`](https://app.codecov.io/gh/apache/hudi/commit/f1bd5e62e2ca8a346f20d2e095864efea9297ba1?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). > :exclamation: There is a different number of reports uploaded between BASE (642d88c) and HEAD (f1bd5e6). Click for more details. > > HEAD has 18 uploads less than BASE > >| Flag | BASE (642d88c) | HEAD (f1bd5e6) | >|--|--|--| >|spark-java-tests|18|6| >|spark-scala-tests|12|6| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18544 +/- ## - Coverage 68.20% 60.78% -7.43% + Complexity2923126030-3201 Files 2525 2525 Lines141667 141675 +8 Branches 1759117589 -2 - Hits 9662186113 -10508 - Misses3709447999 +10905 + Partials 7952 7563 -389 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.35% <100.00%> (+<0.01%)` | :arrow_up: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.98% <100.00%> (+<0.01%)` | :arrow_up: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.30% <100.00%> (+<0.01%)` | :arrow_up: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `31.45% <100.00%> (-17.39%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.65% <100.00%> (-12.30%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.47% <100.00%> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18544?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [.../apache/hudi/metadata/HoodieTableMetadataUtil.java](https://app.codecov.io/gh/apache/hudi/pull/18544?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieTableMetadataUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvbWV0YWRhdGEvSG9vZGllVGFibGVNZXRhZGF0YVV0aWwuamF2YQ==) | `77.41% <100.00%> (-5.04%)` | :arrow_down: | ... and [561 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18544/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) :rocket: New features to boost your workflow: - :snowflake: [Test Analytics
Re: [PR] fix: Skip pre-compaction rollback metadata reads in getValidInstantTimestamps [hudi]
codecov-commenter commented on PR #18544: URL: https://github.com/apache/hudi/pull/18544#issuecomment-4492772377 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18544?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 60.54%. Comparing base ([`642d88c`](https://app.codecov.io/gh/apache/hudi/commit/642d88c594ff11048aeb6f5333f2eb01af47d40c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`f1bd5e6`](https://app.codecov.io/gh/apache/hudi/commit/f1bd5e62e2ca8a346f20d2e095864efea9297ba1?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). > :exclamation: There is a different number of reports uploaded between BASE (642d88c) and HEAD (f1bd5e6). Click for more details. > > HEAD has 20 uploads less than BASE > >| Flag | BASE (642d88c) | HEAD (f1bd5e6) | >|--|--|--| >|spark-java-tests|18|5| >|spark-scala-tests|12|5| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18544 +/- ## - Coverage 68.20% 60.54% -7.66% + Complexity2923125876-3355 Files 2525 2525 Lines141667 141675 +8 Branches 1759117589 -2 - Hits 9662185779 -10842 - Misses3709448435 +11341 + Partials 7952 7461 -491 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.35% <100.00%> (+<0.01%)` | :arrow_up: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.98% <100.00%> (+<0.01%)` | :arrow_up: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.30% <100.00%> (+<0.01%)` | :arrow_up: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `31.83% <100.00%> (-17.00%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.83% <100.00%> (-12.12%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.47% <100.00%> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18544?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [.../apache/hudi/metadata/HoodieTableMetadataUtil.java](https://app.codecov.io/gh/apache/hudi/pull/18544?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieTableMetadataUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvbWV0YWRhdGEvSG9vZGllVGFibGVNZXRhZGF0YVV0aWwuamF2YQ==) | `77.41% <100.00%> (-5.04%)` | :arrow_down: | ... and [563 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18544/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) :rocket: New features to boost your workflow: - :snowflake: [Test Analytics
Re: [PR] fix: Skip pre-compaction rollback metadata reads in getValidInstantTimestamps [hudi]
codecov-commenter commented on PR #18544: URL: https://github.com/apache/hudi/pull/18544#issuecomment-4492780818 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18544?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 60.56%. Comparing base ([`642d88c`](https://app.codecov.io/gh/apache/hudi/commit/642d88c594ff11048aeb6f5333f2eb01af47d40c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`f1bd5e6`](https://app.codecov.io/gh/apache/hudi/commit/f1bd5e62e2ca8a346f20d2e095864efea9297ba1?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). > :exclamation: There is a different number of reports uploaded between BASE (642d88c) and HEAD (f1bd5e6). Click for more details. > > HEAD has 19 uploads less than BASE > >| Flag | BASE (642d88c) | HEAD (f1bd5e6) | >|--|--|--| >|spark-java-tests|18|6| >|spark-scala-tests|12|5| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18544 +/- ## - Coverage 68.20% 60.56% -7.64% + Complexity2923125885-3346 Files 2525 2525 Lines141667 141675 +8 Branches 1759117589 -2 - Hits 9662185812 -10809 - Misses3709448406 +11312 + Partials 7952 7457 -495 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.35% <100.00%> (+<0.01%)` | :arrow_up: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.98% <100.00%> (+<0.01%)` | :arrow_up: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.30% <100.00%> (+<0.01%)` | :arrow_up: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `31.45% <100.00%> (-17.39%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.83% <100.00%> (-12.12%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.47% <100.00%> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18544?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [.../apache/hudi/metadata/HoodieTableMetadataUtil.java](https://app.codecov.io/gh/apache/hudi/pull/18544?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieTableMetadataUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvbWV0YWRhdGEvSG9vZGllVGFibGVNZXRhZGF0YVV0aWwuamF2YQ==) | `77.41% <100.00%> (-5.04%)` | :arrow_down: | ... and [563 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18544/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) :rocket: New features to boost your workflow: - :snowflake: [Test Analytics
Re: [PR] fix: Skip pre-compaction rollback metadata reads in getValidInstantTimestamps [hudi]
codecov-commenter commented on PR #18544: URL: https://github.com/apache/hudi/pull/18544#issuecomment-4492769587 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18544?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 60.54%. Comparing base ([`642d88c`](https://app.codecov.io/gh/apache/hudi/commit/642d88c594ff11048aeb6f5333f2eb01af47d40c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`f1bd5e6`](https://app.codecov.io/gh/apache/hudi/commit/f1bd5e62e2ca8a346f20d2e095864efea9297ba1?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). > :exclamation: There is a different number of reports uploaded between BASE (642d88c) and HEAD (f1bd5e6). Click for more details. > > HEAD has 20 uploads less than BASE > >| Flag | BASE (642d88c) | HEAD (f1bd5e6) | >|--|--|--| >|spark-java-tests|18|5| >|spark-scala-tests|12|5| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18544 +/- ## - Coverage 68.20% 60.54% -7.66% + Complexity2923125876-3355 Files 2525 2525 Lines141667 141675 +8 Branches 1759117589 -2 - Hits 9662185779 -10842 - Misses3709448435 +11341 + Partials 7952 7461 -491 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.35% <100.00%> (+<0.01%)` | :arrow_up: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.98% <100.00%> (+<0.01%)` | :arrow_up: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.30% <100.00%> (+<0.01%)` | :arrow_up: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `31.83% <100.00%> (-17.00%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.83% <100.00%> (-12.12%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.47% <100.00%> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18544?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [.../apache/hudi/metadata/HoodieTableMetadataUtil.java](https://app.codecov.io/gh/apache/hudi/pull/18544?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieTableMetadataUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvbWV0YWRhdGEvSG9vZGllVGFibGVNZXRhZGF0YVV0aWwuamF2YQ==) | `77.41% <100.00%> (-5.04%)` | :arrow_down: | ... and [563 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18544/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) :rocket: New features to boost your workflow: - :snowflake: [Test Analytics
Re: [PR] fix: Skip pre-compaction rollback metadata reads in getValidInstantTimestamps [hudi]
codecov-commenter commented on PR #18544: URL: https://github.com/apache/hudi/pull/18544#issuecomment-4492751303 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18544?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 54.79%. Comparing base ([`642d88c`](https://app.codecov.io/gh/apache/hudi/commit/642d88c594ff11048aeb6f5333f2eb01af47d40c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`f1bd5e6`](https://app.codecov.io/gh/apache/hudi/commit/f1bd5e62e2ca8a346f20d2e095864efea9297ba1?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). > :exclamation: There is a different number of reports uploaded between BASE (642d88c) and HEAD (f1bd5e6). Click for more details. > > HEAD has 25 uploads less than BASE > >| Flag | BASE (642d88c) | HEAD (f1bd5e6) | >|--|--|--| >|spark-java-tests|17|2| >|spark-scala-tests|12|3| >|common-and-other-modules|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18544 +/- ## = - Coverage 68.20% 54.79% -13.41% + Complexity2923118601-10630 = Files 2525 2006 -519 Lines141667 112603-29064 Branches 1759114223 -3368 = - Hits 9662161703-34918 - Misses3709444470 +7376 + Partials 7952 6430 -1522 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.98% <100.00%> (+<0.01%)` | :arrow_up: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.30% <100.00%> (+<0.01%)` | :arrow_up: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.60% <100.00%> (-16.24%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.79% <100.00%> (-12.15%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.47% <100.00%> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18544?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [.../apache/hudi/metadata/HoodieTableMetadataUtil.java](https://app.codecov.io/gh/apache/hudi/pull/18544?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieTableMetadataUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvbWV0YWRhdGEvSG9vZGllVGFibGVNZXRhZGF0YVV0aWwuamF2YQ==) | `77.25% <100.00%> (-5.19%)` | :arrow_down: | ... and [1464 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18544/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) :rocket: New features to boost your workflow: - :snowflake: [Te
Re: [PR] fix: Skip pre-compaction rollback metadata reads in getValidInstantTimestamps [hudi]
codecov-commenter commented on PR #18544: URL: https://github.com/apache/hudi/pull/18544#issuecomment-4492741341 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18544?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 48.55%. Comparing base ([`642d88c`](https://app.codecov.io/gh/apache/hudi/commit/642d88c594ff11048aeb6f5333f2eb01af47d40c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`f1bd5e6`](https://app.codecov.io/gh/apache/hudi/commit/f1bd5e62e2ca8a346f20d2e095864efea9297ba1?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). > :exclamation: There is a different number of reports uploaded between BASE (642d88c) and HEAD (f1bd5e6). Click for more details. > > HEAD has 26 uploads less than BASE > >| Flag | BASE (642d88c) | HEAD (f1bd5e6) | >|--|--|--| >|spark-java-tests|17|2| >|spark-scala-tests|12|3| >|utilities|1|0| >|common-and-other-modules|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18544 +/- ## = - Coverage 68.20% 48.55% -19.66% + Complexity2923116658-12573 = Files 2525 2006 -519 Lines141667 112603-29064 Branches 1759114223 -3368 = - Hits 9662154672-41949 - Misses3709452116+15022 + Partials 7952 5815 -2137 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.98% <100.00%> (+<0.01%)` | :arrow_up: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.30% <100.00%> (+<0.01%)` | :arrow_up: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.60% <100.00%> (-16.24%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.79% <100.00%> (-12.15%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18544?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [.../apache/hudi/metadata/HoodieTableMetadataUtil.java](https://app.codecov.io/gh/apache/hudi/pull/18544?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieTableMetadataUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvbWV0YWRhdGEvSG9vZGllVGFibGVNZXRhZGF0YVV0aWwuamF2YQ==) | `73.90% <100.00%> (-8.54%)` | :arrow_down: | ... and [1597 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18544/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) :rocket: New features to boost your workflow: - :snowflake: [T
Re: [PR] fix: Skip pre-compaction rollback metadata reads in getValidInstantTimestamps [hudi]
codecov-commenter commented on PR #18544: URL: https://github.com/apache/hudi/pull/18544#issuecomment-4492733862 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18544?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 48.43%. Comparing base ([`642d88c`](https://app.codecov.io/gh/apache/hudi/commit/642d88c594ff11048aeb6f5333f2eb01af47d40c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`f1bd5e6`](https://app.codecov.io/gh/apache/hudi/commit/f1bd5e62e2ca8a346f20d2e095864efea9297ba1?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). > :exclamation: There is a different number of reports uploaded between BASE (642d88c) and HEAD (f1bd5e6). Click for more details. > > HEAD has 26 uploads less than BASE > >| Flag | BASE (642d88c) | HEAD (f1bd5e6) | >|--|--|--| >|spark-java-tests|16|1| >|spark-scala-tests|12|3| >|utilities|1|0| >|common-and-other-modules|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18544 +/- ## = - Coverage 68.20% 48.43% -19.77% + Complexity2923116636-12595 = Files 2525 2006 -519 Lines141667 112586-29081 Branches 1759114136 -3455 = - Hits 9662154535-42086 - Misses3709452193+15099 + Partials 7952 5858 -2094 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.98% <100.00%> (+<0.01%)` | :arrow_up: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.30% <100.00%> (+<0.01%)` | :arrow_up: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.82% <100.00%> (-15.99%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.79% <100.00%> (-12.15%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18544?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [.../apache/hudi/metadata/HoodieTableMetadataUtil.java](https://app.codecov.io/gh/apache/hudi/pull/18544?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieTableMetadataUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvbWV0YWRhdGEvSG9vZGllVGFibGVNZXRhZGF0YVV0aWwuamF2YQ==) | `72.50% <100.00%> (-9.94%)` | :arrow_down: | ... and [1605 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18544/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) :rocket: New features to boost your workflow: - :snowflake: [T
Re: [PR] fix: Skip pre-compaction rollback metadata reads in getValidInstantTimestamps [hudi]
codecov-commenter commented on PR #18544: URL: https://github.com/apache/hudi/pull/18544#issuecomment-4492722305 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18544?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 45.74%. Comparing base ([`642d88c`](https://app.codecov.io/gh/apache/hudi/commit/642d88c594ff11048aeb6f5333f2eb01af47d40c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`f1bd5e6`](https://app.codecov.io/gh/apache/hudi/commit/f1bd5e62e2ca8a346f20d2e095864efea9297ba1?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). > :exclamation: There is a different number of reports uploaded between BASE (642d88c) and HEAD (f1bd5e6). Click for more details. > > HEAD has 27 uploads less than BASE > >| Flag | BASE (642d88c) | HEAD (f1bd5e6) | >|--|--|--| >|spark-java-tests|16|0| >|spark-scala-tests|12|3| >|utilities|1|0| >|common-and-other-modules|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18544 +/- ## = - Coverage 68.20% 45.74% -22.46% + Complexity2923115749-13482 = Files 2525 2006 -519 Lines141667 112586-29081 Branches 1759114136 -3455 = - Hits 9662151501-45120 - Misses3709455446+18352 + Partials 7952 5639 -2313 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.98% <100.00%> (+<0.01%)` | :arrow_up: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.30% <100.00%> (+<0.01%)` | :arrow_up: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.79% <100.00%> (-12.15%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18544?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [.../apache/hudi/metadata/HoodieTableMetadataUtil.java](https://app.codecov.io/gh/apache/hudi/pull/18544?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieTableMetadataUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvbWV0YWRhdGEvSG9vZGllVGFibGVNZXRhZGF0YVV0aWwuamF2YQ==) | `58.56% <100.00%> (-23.88%)` | :arrow_down: | ... and [1653 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18544/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) :rocket: New features to boost your workflow: - :snowflake: [Test Analytics](https://docs.codecov.
Re: [PR] fix: Skip pre-compaction rollback metadata reads in getValidInstantTimestamps [hudi]
codecov-commenter commented on PR #18544: URL: https://github.com/apache/hudi/pull/18544#issuecomment-4492707510 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18544?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 46.61%. Comparing base ([`642d88c`](https://app.codecov.io/gh/apache/hudi/commit/642d88c594ff11048aeb6f5333f2eb01af47d40c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`f1bd5e6`](https://app.codecov.io/gh/apache/hudi/commit/f1bd5e62e2ca8a346f20d2e095864efea9297ba1?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). > :exclamation: There is a different number of reports uploaded between BASE (642d88c) and HEAD (f1bd5e6). Click for more details. > > HEAD has 29 uploads less than BASE > >| Flag | BASE (642d88c) | HEAD (f1bd5e6) | >|--|--|--| >|spark-java-tests|16|0| >|spark-scala-tests|12|1| >|utilities|1|0| >|common-and-other-modules|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18544 +/- ## = - Coverage 68.20% 46.61% -21.60% + Complexity2923115324-13907 = Files 2525 1972 -553 Lines141667 107740-33927 Branches 1759113088 -4503 = - Hits 9662150218-46403 - Misses3709452264+15170 + Partials 7952 5258 -2694 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.98% <100.00%> (+<0.01%)` | :arrow_up: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.30% <100.00%> (+<0.01%)` | :arrow_up: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.05% <100.00%> (-11.89%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18544?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [.../apache/hudi/metadata/HoodieTableMetadataUtil.java](https://app.codecov.io/gh/apache/hudi/pull/18544?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieTableMetadataUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvbWV0YWRhdGEvSG9vZGllVGFibGVNZXRhZGF0YVV0aWwuamF2YQ==) | `58.56% <100.00%> (-23.88%)` | :arrow_down: | ... and [1672 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18544/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) :rocket: New features to boost your workflow: - :snowflake: [Test Analytics](https://docs.codecov.
Re: [PR] fix: Skip pre-compaction rollback metadata reads in getValidInstantTimestamps [hudi]
codecov-commenter commented on PR #18544: URL: https://github.com/apache/hudi/pull/18544#issuecomment-4492710419 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18544?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 46.19%. Comparing base ([`642d88c`](https://app.codecov.io/gh/apache/hudi/commit/642d88c594ff11048aeb6f5333f2eb01af47d40c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`f1bd5e6`](https://app.codecov.io/gh/apache/hudi/commit/f1bd5e62e2ca8a346f20d2e095864efea9297ba1?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). > :exclamation: There is a different number of reports uploaded between BASE (642d88c) and HEAD (f1bd5e6). Click for more details. > > HEAD has 28 uploads less than BASE > >| Flag | BASE (642d88c) | HEAD (f1bd5e6) | >|--|--|--| >|spark-java-tests|16|0| >|spark-scala-tests|12|2| >|utilities|1|0| >|common-and-other-modules|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18544 +/- ## = - Coverage 68.20% 46.19% -22.01% + Complexity2923115538-13693 = Files 2525 1989 -536 Lines141667 110126-31541 Branches 1759113600 -3991 = - Hits 9662150878-45743 - Misses3709453790+16696 + Partials 7952 5458 -2494 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.98% <100.00%> (+<0.01%)` | :arrow_up: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.30% <100.00%> (+<0.01%)` | :arrow_up: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.94% <100.00%> (-12.01%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18544?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [.../apache/hudi/metadata/HoodieTableMetadataUtil.java](https://app.codecov.io/gh/apache/hudi/pull/18544?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieTableMetadataUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvbWV0YWRhdGEvSG9vZGllVGFibGVNZXRhZGF0YVV0aWwuamF2YQ==) | `58.56% <100.00%> (-23.88%)` | :arrow_down: | ... and [1661 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18544/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) :rocket: New features to boost your workflow: - :snowflake: [Test Analytics](https://docs.codecov.
Re: [PR] fix: Skip pre-compaction rollback metadata reads in getValidInstantTimestamps [hudi]
codecov-commenter commented on PR #18544: URL: https://github.com/apache/hudi/pull/18544#issuecomment-4492691949 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18544?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 53.97%. Comparing base ([`642d88c`](https://app.codecov.io/gh/apache/hudi/commit/642d88c594ff11048aeb6f5333f2eb01af47d40c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`f1bd5e6`](https://app.codecov.io/gh/apache/hudi/commit/f1bd5e62e2ca8a346f20d2e095864efea9297ba1?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). > :exclamation: There is a different number of reports uploaded between BASE (642d88c) and HEAD (f1bd5e6). Click for more details. > > HEAD has 29 uploads less than BASE > >| Flag | BASE (642d88c) | HEAD (f1bd5e6) | >|--|--|--| >|spark-java-tests|15|0| >|spark-scala-tests|12|0| >|utilities|1|0| >|common-and-other-modules|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18544 +/- ## = - Coverage 68.20% 53.97% -14.23% + Complexity2923112461-16770 = Files 2525 1434 -1091 Lines14166772232-69435 Branches 17591 8256 -9335 = - Hits 9661938988-57631 + Misses3709529744 -7351 + Partials 7953 3500 -4453 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.98% <100.00%> (+<0.01%)` | :arrow_up: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.30% <100.00%> (+<0.01%)` | :arrow_up: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18544?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [.../apache/hudi/metadata/HoodieTableMetadataUtil.java](https://app.codecov.io/gh/apache/hudi/pull/18544?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieTableMetadataUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvbWV0YWRhdGEvSG9vZGllVGFibGVNZXRhZGF0YVV0aWwuamF2YQ==) | `55.52% <100.00%> (-26.92%)` | :arrow_down: | ... and [1870 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18544/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) :rocket: New features to boost your workflow: - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky
Re: [PR] fix: Skip pre-compaction rollback metadata reads in getValidInstantTimestamps [hudi]
codecov-commenter commented on PR #18544: URL: https://github.com/apache/hudi/pull/18544#issuecomment-4492563463 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18544?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 44.98%. Comparing base ([`642d88c`](https://app.codecov.io/gh/apache/hudi/commit/642d88c594ff11048aeb6f5333f2eb01af47d40c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`f1bd5e6`](https://app.codecov.io/gh/apache/hudi/commit/f1bd5e62e2ca8a346f20d2e095864efea9297ba1?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). > :exclamation: There is a different number of reports uploaded between BASE (642d88c) and HEAD (f1bd5e6). Click for more details. > > HEAD has 12 uploads less than BASE > >| Flag | BASE (642d88c) | HEAD (f1bd5e6) | >|--|--|--| >|spark-java-tests|6|0| >|spark-scala-tests|4|0| >|spark-client-hadoop-common|1|0| >|utilities|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18544 +/- ## - Coverage 53.08% 44.98% -8.10% + Complexity18799 8571 -10228 Files 2058 1202 -856 Lines11786162853 -55008 Branches 15347 6815-8532 - Hits 6256828276 -34292 + Misses4869631459 -17237 + Partials 6597 3118-3479 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.98% <100.00%> (+<0.01%)` | :arrow_up: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18544?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [.../apache/hudi/metadata/HoodieTableMetadataUtil.java](https://app.codecov.io/gh/apache/hudi/pull/18544?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieTableMetadataUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvbWV0YWRhdGEvSG9vZGllVGFibGVNZXRhZGF0YVV0aWwuamF2YQ==) | `44.15% <100.00%> (-33.04%)` | :arrow_down: | ... and [1494 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18544/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) :rocket: New features to boost your workflow: - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits
Re: [PR] fix: Skip pre-compaction rollback metadata reads in getValidInstantTimestamps [hudi]
hudi-bot commented on PR #18544: URL: https://github.com/apache/hudi/pull/18544#issuecomment-4492417722 ## CI report: * 67eac7ab767b5f7d059efd854b16f25a7b1241d0 Azure: [FAILURE](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13905) * f1bd5e62e2ca8a346f20d2e095864efea9297ba1 Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=14121) Bot commands @hudi-bot supports the following commands: - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] fix: Skip pre-compaction rollback metadata reads in getValidInstantTimestamps [hudi]
hudi-bot commented on PR #18544: URL: https://github.com/apache/hudi/pull/18544#issuecomment-4492394654 ## CI report: * 67eac7ab767b5f7d059efd854b16f25a7b1241d0 Azure: [FAILURE](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13905) * f1bd5e62e2ca8a346f20d2e095864efea9297ba1 UNKNOWN Bot commands @hudi-bot supports the following commands: - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] fix: Skip pre-compaction rollback metadata reads in getValidInstantTimestamps [hudi]
yihua commented on PR #18544: URL: https://github.com/apache/hudi/pull/18544#issuecomment-4492387524 The test is fixed now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] fix: Skip pre-compaction rollback metadata reads in getValidInstantTimestamps [hudi]
rahil-c commented on PR #18544: URL: https://github.com/apache/hudi/pull/18544#issuecomment-4480684281 lgtm once ci is green -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] fix: Skip pre-compaction rollback metadata reads in getValidInstantTimestamps [hudi]
voonhous commented on code in PR #18544: URL: https://github.com/apache/hudi/pull/18544#discussion_r3246015116 ## hudi-common/src/main/java/org/apache/hudi/metadata/HoodieTableMetadataUtil.java: ## @@ -2098,9 +2098,25 @@ public static Set getValidInstantTimestamps(HoodieTableMetaClient dataMe // For any rollbacks and restores, we cannot neglect the instants that they are rolling back. // The rollback instant should be more recent than the start of the timeline for it to have rolled back any // instant which we have a log block for. +// +// Only read rollback metadata for rollbacks newer than the latest MDT compaction. +// After compaction, rolled-back log blocks are already merged into base files, so pre-compaction +// rollback timestamps are no longer needed for log block filtering. This avoids sequential storage +// reads for old rollback instants that can cause long latency during metadata table reading. final String earliestInstantTime = validInstantTimestamps.isEmpty() ? SOLO_COMMIT_TIMESTAMP : Collections.min(validInstantTimestamps); +final String latestMdtCompactionTime = metadataMetaClient.getActiveTimeline() +.getCommitTimeline() Review Comment: Building ontop of this, if anything else ever writes a **COMMIT_ACTION** to MDT, this would silently treat that timestamp as a "compaction." It's worth being defensive, consider filtering explicitly on the compaction action. IIRC, **COMMIT_ACTION** writes to MDT are exclusively generated by compaction, so this is safe for now. The only problem that may arise in the future is if there's a change in contract API, and this becomes a regression. As of now, i don't think this should be a blocker, just want to highlight this. Feel free to create an issue to track this or if it's worth the effort to clean things up for new users to pick up. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] fix: Skip pre-compaction rollback metadata reads in getValidInstantTimestamps [hudi]
voonhous commented on code in PR #18544: URL: https://github.com/apache/hudi/pull/18544#discussion_r3246015116 ## hudi-common/src/main/java/org/apache/hudi/metadata/HoodieTableMetadataUtil.java: ## @@ -2098,9 +2098,25 @@ public static Set getValidInstantTimestamps(HoodieTableMetaClient dataMe // For any rollbacks and restores, we cannot neglect the instants that they are rolling back. // The rollback instant should be more recent than the start of the timeline for it to have rolled back any // instant which we have a log block for. +// +// Only read rollback metadata for rollbacks newer than the latest MDT compaction. +// After compaction, rolled-back log blocks are already merged into base files, so pre-compaction +// rollback timestamps are no longer needed for log block filtering. This avoids sequential storage +// reads for old rollback instants that can cause long latency during metadata table reading. final String earliestInstantTime = validInstantTimestamps.isEmpty() ? SOLO_COMMIT_TIMESTAMP : Collections.min(validInstantTimestamps); +final String latestMdtCompactionTime = metadataMetaClient.getActiveTimeline() +.getCommitTimeline() Review Comment: Building ontop of this, if anything else ever writes a **COMMIT_ACTION** to MDT, this would silently treat that timestamp as a "compaction." It's worth being defensive, consider filtering explicitly on the compaction action. IIRC, **COMMIT_ACTION** writes to MDT are exclusively generated by compaction, so this is safe for now. The only problem that may arise in the future is if there's a change in contract API, and this becomes a regression. As of now, i don't think this should be a blocker, just want to highlight this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] fix: Skip pre-compaction rollback metadata reads in getValidInstantTimestamps [hudi]
voonhous commented on code in PR #18544: URL: https://github.com/apache/hudi/pull/18544#discussion_r3246015116 ## hudi-common/src/main/java/org/apache/hudi/metadata/HoodieTableMetadataUtil.java: ## @@ -2098,9 +2098,25 @@ public static Set getValidInstantTimestamps(HoodieTableMetaClient dataMe // For any rollbacks and restores, we cannot neglect the instants that they are rolling back. // The rollback instant should be more recent than the start of the timeline for it to have rolled back any // instant which we have a log block for. +// +// Only read rollback metadata for rollbacks newer than the latest MDT compaction. +// After compaction, rolled-back log blocks are already merged into base files, so pre-compaction +// rollback timestamps are no longer needed for log block filtering. This avoids sequential storage +// reads for old rollback instants that can cause long latency during metadata table reading. final String earliestInstantTime = validInstantTimestamps.isEmpty() ? SOLO_COMMIT_TIMESTAMP : Collections.min(validInstantTimestamps); +final String latestMdtCompactionTime = metadataMetaClient.getActiveTimeline() +.getCommitTimeline() Review Comment: Building ontop of this, if anything else ever writes a **COMMIT_ACTION** to MDT, this would silently treat that timestamp as a "compaction." It's worth being defensive, consider filtering explicitly on the compaction action. IIRC, **COMMIT_ACTION** writes to MDT are exclusively generated by compaction, so this is safe for now. The only problem that may arise in the future is if there's a change in contract API, and this becomes a regression. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] fix: Skip pre-compaction rollback metadata reads in getValidInstantTimestamps [hudi]
codecov-commenter commented on PR #18544: URL: https://github.com/apache/hudi/pull/18544#issuecomment-4411301605 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18544?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 67.30%. Comparing base ([`47bf4e4`](https://app.codecov.io/gh/apache/hudi/commit/47bf4e41342e4f1dab26a7fb1489f278fbd1226c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`67eac7a`](https://app.codecov.io/gh/apache/hudi/commit/67eac7ab767b5f7d059efd854b16f25a7b1241d0?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18544 +/- ## - Coverage 68.14% 67.30% -0.84% + Complexity2907728665 -412 Files 2522 2522 Lines141177 141185 +8 Branches 1751417515 +1 - Hits 9620895028-1180 - Misses3706138148+1087 - Partials 7908 8009 +101 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.42% <100.00%> (+<0.01%)` | :arrow_up: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.01% <100.00%> (+<0.01%)` | :arrow_up: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `21.36% <0.00%> (-26.99%)` | :arrow_down: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `49.00% <100.00%> (+<0.01%)` | :arrow_up: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.91% <100.00%> (+<0.01%)` | :arrow_up: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.65% <100.00%> (+0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18544?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [.../apache/hudi/metadata/HoodieTableMetadataUtil.java](https://app.codecov.io/gh/apache/hudi/pull/18544?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieTableMetadataUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvbWV0YWRhdGEvSG9vZGllVGFibGVNZXRhZGF0YVV0aWwuamF2YQ==) | `82.08% <100.00%> (-0.28%)` | :arrow_down: | ... and [165 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18544/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) :rocket: New features to boost your workflow: - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-
Re: [PR] fix: Skip pre-compaction rollback metadata reads in getValidInstantTimestamps [hudi]
codecov-commenter commented on PR #18544: URL: https://github.com/apache/hudi/pull/18544#issuecomment-4411295850 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18544?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 67.30%. Comparing base ([`47bf4e4`](https://app.codecov.io/gh/apache/hudi/commit/47bf4e41342e4f1dab26a7fb1489f278fbd1226c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`67eac7a`](https://app.codecov.io/gh/apache/hudi/commit/67eac7ab767b5f7d059efd854b16f25a7b1241d0?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18544 +/- ## - Coverage 68.14% 67.30% -0.85% + Complexity2907728664 -413 Files 2522 2522 Lines141177 141185 +8 Branches 1751417515 +1 - Hits 9620895027-1181 - Misses3706138148+1087 - Partials 7908 8010 +102 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.42% <100.00%> (+<0.01%)` | :arrow_up: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.01% <100.00%> (+<0.01%)` | :arrow_up: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `21.36% <0.00%> (-26.99%)` | :arrow_down: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `49.00% <100.00%> (+<0.01%)` | :arrow_up: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.91% <100.00%> (+<0.01%)` | :arrow_up: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.65% <100.00%> (+0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18544?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [.../apache/hudi/metadata/HoodieTableMetadataUtil.java](https://app.codecov.io/gh/apache/hudi/pull/18544?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieTableMetadataUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvbWV0YWRhdGEvSG9vZGllVGFibGVNZXRhZGF0YVV0aWwuamF2YQ==) | `82.08% <100.00%> (-0.28%)` | :arrow_down: | ... and [165 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18544/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) :rocket: New features to boost your workflow: - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-
Re: [PR] fix: Skip pre-compaction rollback metadata reads in getValidInstantTimestamps [hudi]
codecov-commenter commented on PR #18544: URL: https://github.com/apache/hudi/pull/18544#issuecomment-4411290590 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18544?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 67.30%. Comparing base ([`47bf4e4`](https://app.codecov.io/gh/apache/hudi/commit/47bf4e41342e4f1dab26a7fb1489f278fbd1226c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`67eac7a`](https://app.codecov.io/gh/apache/hudi/commit/67eac7ab767b5f7d059efd854b16f25a7b1241d0?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18544 +/- ## - Coverage 68.14% 67.30% -0.85% + Complexity2907728664 -413 Files 2522 2522 Lines141177 141185 +8 Branches 1751417515 +1 - Hits 9620895027-1181 - Misses3706138148+1087 - Partials 7908 8010 +102 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.42% <100.00%> (+<0.01%)` | :arrow_up: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.01% <100.00%> (+<0.01%)` | :arrow_up: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `21.36% <0.00%> (-26.99%)` | :arrow_down: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.97% <100.00%> (-0.03%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.91% <100.00%> (+<0.01%)` | :arrow_up: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.65% <100.00%> (+0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18544?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [.../apache/hudi/metadata/HoodieTableMetadataUtil.java](https://app.codecov.io/gh/apache/hudi/pull/18544?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieTableMetadataUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvbWV0YWRhdGEvSG9vZGllVGFibGVNZXRhZGF0YVV0aWwuamF2YQ==) | `82.08% <100.00%> (-0.28%)` | :arrow_down: | ... and [165 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18544/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) :rocket: New features to boost your workflow: - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e
Re: [PR] fix: Skip pre-compaction rollback metadata reads in getValidInstantTimestamps [hudi]
codecov-commenter commented on PR #18544: URL: https://github.com/apache/hudi/pull/18544#issuecomment-4411260674 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18544?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 67.29%. Comparing base ([`47bf4e4`](https://app.codecov.io/gh/apache/hudi/commit/47bf4e41342e4f1dab26a7fb1489f278fbd1226c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`67eac7a`](https://app.codecov.io/gh/apache/hudi/commit/67eac7ab767b5f7d059efd854b16f25a7b1241d0?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18544 +/- ## - Coverage 68.14% 67.29% -0.85% + Complexity2907728664 -413 Files 2522 2522 Lines141177 141185 +8 Branches 1751417515 +1 - Hits 9620895016-1192 - Misses3706138158+1097 - Partials 7908 8011 +103 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.42% <100.00%> (+<0.01%)` | :arrow_up: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.01% <100.00%> (+<0.01%)` | :arrow_up: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `21.36% <0.00%> (-26.99%)` | :arrow_down: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.93% <100.00%> (-0.07%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.91% <100.00%> (+<0.01%)` | :arrow_up: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.65% <100.00%> (+0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18544?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [.../apache/hudi/metadata/HoodieTableMetadataUtil.java](https://app.codecov.io/gh/apache/hudi/pull/18544?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieTableMetadataUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvbWV0YWRhdGEvSG9vZGllVGFibGVNZXRhZGF0YVV0aWwuamF2YQ==) | `82.08% <100.00%> (-0.28%)` | :arrow_down: | ... and [168 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18544/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) :rocket: New features to boost your workflow: - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e
Re: [PR] fix: Skip pre-compaction rollback metadata reads in getValidInstantTimestamps [hudi]
codecov-commenter commented on PR #18544: URL: https://github.com/apache/hudi/pull/18544#issuecomment-4411261523 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18544?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 67.30%. Comparing base ([`47bf4e4`](https://app.codecov.io/gh/apache/hudi/commit/47bf4e41342e4f1dab26a7fb1489f278fbd1226c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`67eac7a`](https://app.codecov.io/gh/apache/hudi/commit/67eac7ab767b5f7d059efd854b16f25a7b1241d0?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18544 +/- ## - Coverage 68.14% 67.30% -0.85% + Complexity2907728664 -413 Files 2522 2522 Lines141177 141185 +8 Branches 1751417515 +1 - Hits 9620895018-1190 - Misses3706138157+1096 - Partials 7908 8010 +102 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.42% <100.00%> (+<0.01%)` | :arrow_up: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.01% <100.00%> (+<0.01%)` | :arrow_up: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `21.36% <0.00%> (-26.99%)` | :arrow_down: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.93% <100.00%> (-0.07%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.91% <100.00%> (+<0.01%)` | :arrow_up: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.65% <100.00%> (+0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18544?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [.../apache/hudi/metadata/HoodieTableMetadataUtil.java](https://app.codecov.io/gh/apache/hudi/pull/18544?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieTableMetadataUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvbWV0YWRhdGEvSG9vZGllVGFibGVNZXRhZGF0YVV0aWwuamF2YQ==) | `82.08% <100.00%> (-0.28%)` | :arrow_down: | ... and [166 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18544/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) :rocket: New features to boost your workflow: - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e
Re: [PR] fix: Skip pre-compaction rollback metadata reads in getValidInstantTimestamps [hudi]
codecov-commenter commented on PR #18544: URL: https://github.com/apache/hudi/pull/18544#issuecomment-4411255098 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18544?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 67.29%. Comparing base ([`47bf4e4`](https://app.codecov.io/gh/apache/hudi/commit/47bf4e41342e4f1dab26a7fb1489f278fbd1226c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`67eac7a`](https://app.codecov.io/gh/apache/hudi/commit/67eac7ab767b5f7d059efd854b16f25a7b1241d0?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18544 +/- ## - Coverage 68.14% 67.29% -0.86% + Complexity2907728663 -414 Files 2522 2522 Lines141177 141185 +8 Branches 1751417515 +1 - Hits 9620895012-1196 - Misses3706138160+1099 - Partials 7908 8013 +105 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.42% <100.00%> (+<0.01%)` | :arrow_up: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.01% <100.00%> (+<0.01%)` | :arrow_up: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `21.36% <0.00%> (-26.99%)` | :arrow_down: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.87% <100.00%> (-0.13%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.91% <100.00%> (+<0.01%)` | :arrow_up: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.65% <100.00%> (+0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18544?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [.../apache/hudi/metadata/HoodieTableMetadataUtil.java](https://app.codecov.io/gh/apache/hudi/pull/18544?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieTableMetadataUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvbWV0YWRhdGEvSG9vZGllVGFibGVNZXRhZGF0YVV0aWwuamF2YQ==) | `82.08% <100.00%> (-0.28%)` | :arrow_down: | ... and [168 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18544/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) :rocket: New features to boost your workflow: - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e
Re: [PR] fix: Skip pre-compaction rollback metadata reads in getValidInstantTimestamps [hudi]
codecov-commenter commented on PR #18544: URL: https://github.com/apache/hudi/pull/18544#issuecomment-4411253032 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18544?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 66.35%. Comparing base ([`47bf4e4`](https://app.codecov.io/gh/apache/hudi/commit/47bf4e41342e4f1dab26a7fb1489f278fbd1226c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`67eac7a`](https://app.codecov.io/gh/apache/hudi/commit/67eac7ab767b5f7d059efd854b16f25a7b1241d0?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18544 +/- ## - Coverage 68.14% 66.35% -1.80% + Complexity2907728258 -819 Files 2522 2522 Lines141177 141185 +8 Branches 1751417515 +1 - Hits 9620893685-2523 - Misses3706139429+2368 - Partials 7908 8071 +163 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.42% <100.00%> (+<0.01%)` | :arrow_up: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.01% <100.00%> (+<0.01%)` | :arrow_up: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `21.36% <0.00%> (-26.99%)` | :arrow_down: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.53% <100.00%> (-3.47%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.91% <100.00%> (+<0.01%)` | :arrow_up: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.65% <100.00%> (+0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18544?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [.../apache/hudi/metadata/HoodieTableMetadataUtil.java](https://app.codecov.io/gh/apache/hudi/pull/18544?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieTableMetadataUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvbWV0YWRhdGEvSG9vZGllVGFibGVNZXRhZGF0YVV0aWwuamF2YQ==) | `81.23% <100.00%> (-1.14%)` | :arrow_down: | ... and [277 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18544/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) :rocket: New features to boost your workflow: - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e
Re: [PR] fix: Skip pre-compaction rollback metadata reads in getValidInstantTimestamps [hudi]
codecov-commenter commented on PR #18544: URL: https://github.com/apache/hudi/pull/18544#issuecomment-4411250694 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18544?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 66.26%. Comparing base ([`47bf4e4`](https://app.codecov.io/gh/apache/hudi/commit/47bf4e41342e4f1dab26a7fb1489f278fbd1226c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`67eac7a`](https://app.codecov.io/gh/apache/hudi/commit/67eac7ab767b5f7d059efd854b16f25a7b1241d0?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18544 +/- ## - Coverage 68.14% 66.26% -1.89% + Complexity2907728211 -866 Files 2522 2522 Lines141177 141185 +8 Branches 1751417515 +1 - Hits 9620893551-2657 - Misses3706139582+2521 - Partials 7908 8052 +144 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.42% <100.00%> (+<0.01%)` | :arrow_up: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.01% <100.00%> (+<0.01%)` | :arrow_up: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `21.36% <0.00%> (-26.99%)` | :arrow_down: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.07% <100.00%> (-3.93%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.91% <100.00%> (+<0.01%)` | :arrow_up: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.65% <100.00%> (+0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18544?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [.../apache/hudi/metadata/HoodieTableMetadataUtil.java](https://app.codecov.io/gh/apache/hudi/pull/18544?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieTableMetadataUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvbWV0YWRhdGEvSG9vZGllVGFibGVNZXRhZGF0YVV0aWwuamF2YQ==) | `81.23% <100.00%> (-1.14%)` | :arrow_down: | ... and [293 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18544/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) :rocket: New features to boost your workflow: - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e
Re: [PR] fix: Skip pre-compaction rollback metadata reads in getValidInstantTimestamps [hudi]
codecov-commenter commented on PR #18544: URL: https://github.com/apache/hudi/pull/18544#issuecomment-4411248579 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18544?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 66.17%. Comparing base ([`47bf4e4`](https://app.codecov.io/gh/apache/hudi/commit/47bf4e41342e4f1dab26a7fb1489f278fbd1226c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`67eac7a`](https://app.codecov.io/gh/apache/hudi/commit/67eac7ab767b5f7d059efd854b16f25a7b1241d0?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18544 +/- ## - Coverage 68.14% 66.17% -1.98% + Complexity2907728143 -934 Files 2522 2522 Lines141177 141185 +8 Branches 1751417515 +1 - Hits 9620893425-2783 - Misses3706139725+2664 - Partials 7908 8035 +127 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.42% <100.00%> (+<0.01%)` | :arrow_up: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.01% <100.00%> (+<0.01%)` | :arrow_up: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `21.36% <0.00%> (-26.99%)` | :arrow_down: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.81% <100.00%> (-4.19%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.83% <100.00%> (-0.08%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.65% <100.00%> (+0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18544?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [.../apache/hudi/metadata/HoodieTableMetadataUtil.java](https://app.codecov.io/gh/apache/hudi/pull/18544?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieTableMetadataUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvbWV0YWRhdGEvSG9vZGllVGFibGVNZXRhZGF0YVV0aWwuamF2YQ==) | `81.23% <100.00%> (-1.14%)` | :arrow_down: | ... and [313 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18544/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) :rocket: New features to boost your workflow: - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,
Re: [PR] fix: Skip pre-compaction rollback metadata reads in getValidInstantTimestamps [hudi]
codecov-commenter commented on PR #18544: URL: https://github.com/apache/hudi/pull/18544#issuecomment-4411243688 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18544?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 64.09%. Comparing base ([`47bf4e4`](https://app.codecov.io/gh/apache/hudi/commit/47bf4e41342e4f1dab26a7fb1489f278fbd1226c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`67eac7a`](https://app.codecov.io/gh/apache/hudi/commit/67eac7ab767b5f7d059efd854b16f25a7b1241d0?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18544 +/- ## - Coverage 68.14% 64.09% -4.06% + Complexity2907727252-1825 Files 2522 2522 Lines141177 141185 +8 Branches 1751417515 +1 - Hits 9620890487-5721 - Misses3706142658+5597 - Partials 7908 8040 +132 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.42% <100.00%> (+<0.01%)` | :arrow_up: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.01% <100.00%> (+<0.01%)` | :arrow_up: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `21.36% <0.00%> (-26.99%)` | :arrow_down: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `31.57% <100.00%> (-17.43%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.83% <100.00%> (-0.08%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.65% <100.00%> (+0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18544?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [.../apache/hudi/metadata/HoodieTableMetadataUtil.java](https://app.codecov.io/gh/apache/hudi/pull/18544?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieTableMetadataUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvbWV0YWRhdGEvSG9vZGllVGFibGVNZXRhZGF0YVV0aWwuamF2YQ==) | `78.34% <100.00%> (-4.02%)` | :arrow_down: | ... and [488 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18544/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) :rocket: New features to boost your workflow: - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,
Re: [PR] fix: Skip pre-compaction rollback metadata reads in getValidInstantTimestamps [hudi]
codecov-commenter commented on PR #18544: URL: https://github.com/apache/hudi/pull/18544#issuecomment-4411239676 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18544?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 64.01%. Comparing base ([`47bf4e4`](https://app.codecov.io/gh/apache/hudi/commit/47bf4e41342e4f1dab26a7fb1489f278fbd1226c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`67eac7a`](https://app.codecov.io/gh/apache/hudi/commit/67eac7ab767b5f7d059efd854b16f25a7b1241d0?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18544 +/- ## - Coverage 68.14% 64.01% -4.14% + Complexity2907727220-1857 Files 2522 2522 Lines141177 141185 +8 Branches 1751417515 +1 - Hits 9620890377-5831 - Misses3706142757+5696 - Partials 7908 8051 +143 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.42% <100.00%> (+<0.01%)` | :arrow_up: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.01% <100.00%> (+<0.01%)` | :arrow_up: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `21.36% <0.00%> (-26.99%)` | :arrow_down: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `31.57% <100.00%> (-17.43%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.70% <100.00%> (-0.21%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.65% <100.00%> (+0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18544?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [.../apache/hudi/metadata/HoodieTableMetadataUtil.java](https://app.codecov.io/gh/apache/hudi/pull/18544?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieTableMetadataUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvbWV0YWRhdGEvSG9vZGllVGFibGVNZXRhZGF0YVV0aWwuamF2YQ==) | `78.34% <100.00%> (-4.02%)` | :arrow_down: | ... and [507 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18544/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) :rocket: New features to boost your workflow: - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,
Re: [PR] fix: Skip pre-compaction rollback metadata reads in getValidInstantTimestamps [hudi]
codecov-commenter commented on PR #18544: URL: https://github.com/apache/hudi/pull/18544#issuecomment-4411238724 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18544?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 63.96%. Comparing base ([`47bf4e4`](https://app.codecov.io/gh/apache/hudi/commit/47bf4e41342e4f1dab26a7fb1489f278fbd1226c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`67eac7a`](https://app.codecov.io/gh/apache/hudi/commit/67eac7ab767b5f7d059efd854b16f25a7b1241d0?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18544 +/- ## - Coverage 68.14% 63.96% -4.18% + Complexity2907727189-1888 Files 2522 2522 Lines141177 141185 +8 Branches 1751417515 +1 - Hits 9620890312-5896 - Misses3706142835+5774 - Partials 7908 8038 +130 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.42% <100.00%> (+<0.01%)` | :arrow_up: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.01% <100.00%> (+<0.01%)` | :arrow_up: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `21.36% <0.00%> (-26.99%)` | :arrow_down: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `31.57% <100.00%> (-17.43%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.61% <100.00%> (-0.29%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.65% <100.00%> (+0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18544?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [.../apache/hudi/metadata/HoodieTableMetadataUtil.java](https://app.codecov.io/gh/apache/hudi/pull/18544?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieTableMetadataUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvbWV0YWRhdGEvSG9vZGllVGFibGVNZXRhZGF0YVV0aWwuamF2YQ==) | `78.34% <100.00%> (-4.02%)` | :arrow_down: | ... and [511 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18544/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) :rocket: New features to boost your workflow: - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,
Re: [PR] fix: Skip pre-compaction rollback metadata reads in getValidInstantTimestamps [hudi]
codecov-commenter commented on PR #18544: URL: https://github.com/apache/hudi/pull/18544#issuecomment-4411231232 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18544?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 63.82%. Comparing base ([`47bf4e4`](https://app.codecov.io/gh/apache/hudi/commit/47bf4e41342e4f1dab26a7fb1489f278fbd1226c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`67eac7a`](https://app.codecov.io/gh/apache/hudi/commit/67eac7ab767b5f7d059efd854b16f25a7b1241d0?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18544 +/- ## - Coverage 68.14% 63.82% -4.33% + Complexity2907727123-1954 Files 2522 2522 Lines141177 141185 +8 Branches 1751417515 +1 - Hits 9620890112-6096 - Misses3706143037+5976 - Partials 7908 8036 +128 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.42% <100.00%> (+<0.01%)` | :arrow_up: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.01% <100.00%> (+<0.01%)` | :arrow_up: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `21.36% <0.00%> (-26.99%)` | :arrow_down: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `31.57% <100.00%> (-17.43%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.31% <100.00%> (-0.59%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.65% <100.00%> (+0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18544?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [.../apache/hudi/metadata/HoodieTableMetadataUtil.java](https://app.codecov.io/gh/apache/hudi/pull/18544?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieTableMetadataUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvbWV0YWRhdGEvSG9vZGllVGFibGVNZXRhZGF0YVV0aWwuamF2YQ==) | `78.34% <100.00%> (-4.02%)` | :arrow_down: | ... and [535 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18544/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) :rocket: New features to boost your workflow: - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,
Re: [PR] fix: Skip pre-compaction rollback metadata reads in getValidInstantTimestamps [hudi]
codecov-commenter commented on PR #18544: URL: https://github.com/apache/hudi/pull/18544#issuecomment-4411226388 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18544?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 59.28%. Comparing base ([`47bf4e4`](https://app.codecov.io/gh/apache/hudi/commit/47bf4e41342e4f1dab26a7fb1489f278fbd1226c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`67eac7a`](https://app.codecov.io/gh/apache/hudi/commit/67eac7ab767b5f7d059efd854b16f25a7b1241d0?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). > :exclamation: There is a different number of reports uploaded between BASE (47bf4e4) and HEAD (67eac7a). Click for more details. > > HEAD has 18 uploads less than BASE > >| Flag | BASE (47bf4e4) | HEAD (67eac7a) | >|--|--|--| >|spark-scala-tests|12|6| >|spark-java-tests|18|6| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18544 +/- ## - Coverage 68.14% 59.28% -8.87% + Complexity2907725186-3891 Files 2522 2522 Lines141177 141185 +8 Branches 1751417515 +1 - Hits 9620883695 -12513 - Misses3706149902 +12841 + Partials 7908 7588 -320 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.42% <100.00%> (+<0.01%)` | :arrow_up: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.01% <100.00%> (+<0.01%)` | :arrow_up: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `21.36% <0.00%> (-26.99%)` | :arrow_down: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `31.57% <100.00%> (-17.43%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.73% <100.00%> (-12.17%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.65% <100.00%> (+0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18544?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [.../apache/hudi/metadata/HoodieTableMetadataUtil.java](https://app.codecov.io/gh/apache/hudi/pull/18544?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieTableMetadataUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvbWV0YWRhdGEvSG9vZGllVGFibGVNZXRhZGF0YVV0aWwuamF2YQ==) | `76.24% <100.00%> (-6.13%)` | :arrow_down: | ... and [691 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18544/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) :rocket: New features to boost your workflow: - :snowflake:
Re: [PR] fix: Skip pre-compaction rollback metadata reads in getValidInstantTimestamps [hudi]
codecov-commenter commented on PR #18544: URL: https://github.com/apache/hudi/pull/18544#issuecomment-4411221780 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18544?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 56.67%. Comparing base ([`47bf4e4`](https://app.codecov.io/gh/apache/hudi/commit/47bf4e41342e4f1dab26a7fb1489f278fbd1226c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`67eac7a`](https://app.codecov.io/gh/apache/hudi/commit/67eac7ab767b5f7d059efd854b16f25a7b1241d0?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). > :exclamation: There is a different number of reports uploaded between BASE (47bf4e4) and HEAD (67eac7a). Click for more details. > > HEAD has 21 uploads less than BASE > >| Flag | BASE (47bf4e4) | HEAD (67eac7a) | >|--|--|--| >|spark-scala-tests|12|6| >|spark-java-tests|18|4| >|utilities|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18544 +/- ## = - Coverage 68.14% 56.67% -11.48% + Complexity2907724125 -4952 = Files 2522 2522 Lines141177 141185+8 Branches 1751417515+1 = - Hits 9620880016-16192 - Misses3706153749+16688 + Partials 7908 7420 -488 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.42% <100.00%> (+<0.01%)` | :arrow_up: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.01% <100.00%> (+<0.01%)` | :arrow_up: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `21.36% <0.00%> (-26.99%)` | :arrow_down: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `31.95% <100.00%> (-17.05%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.73% <100.00%> (-12.17%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18544?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [.../apache/hudi/metadata/HoodieTableMetadataUtil.java](https://app.codecov.io/gh/apache/hudi/pull/18544?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieTableMetadataUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvbWV0YWRhdGEvSG9vZGllVGFibGVNZXRhZGF0YVV0aWwuamF2YQ==) | `73.05% <100.00%> (-9.32%)` | :arrow_down: | ... and [816 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18544/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) :rocket: New features to boost your workflow: - :snowflake: [T
Re: [PR] fix: Skip pre-compaction rollback metadata reads in getValidInstantTimestamps [hudi]
codecov-commenter commented on PR #18544: URL: https://github.com/apache/hudi/pull/18544#issuecomment-4411224547 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18544?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 59.28%. Comparing base ([`47bf4e4`](https://app.codecov.io/gh/apache/hudi/commit/47bf4e41342e4f1dab26a7fb1489f278fbd1226c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`67eac7a`](https://app.codecov.io/gh/apache/hudi/commit/67eac7ab767b5f7d059efd854b16f25a7b1241d0?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). > :exclamation: There is a different number of reports uploaded between BASE (47bf4e4) and HEAD (67eac7a). Click for more details. > > HEAD has 19 uploads less than BASE > >| Flag | BASE (47bf4e4) | HEAD (67eac7a) | >|--|--|--| >|spark-scala-tests|12|6| >|spark-java-tests|18|5| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18544 +/- ## - Coverage 68.14% 59.28% -8.87% + Complexity2907725186-3891 Files 2522 2522 Lines141177 141185 +8 Branches 1751417515 +1 - Hits 9620883695 -12513 - Misses3706149902 +12841 + Partials 7908 7588 -320 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.42% <100.00%> (+<0.01%)` | :arrow_up: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.01% <100.00%> (+<0.01%)` | :arrow_up: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `21.36% <0.00%> (-26.99%)` | :arrow_down: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `31.57% <100.00%> (-17.43%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.73% <100.00%> (-12.17%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.65% <100.00%> (+0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18544?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [.../apache/hudi/metadata/HoodieTableMetadataUtil.java](https://app.codecov.io/gh/apache/hudi/pull/18544?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieTableMetadataUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvbWV0YWRhdGEvSG9vZGllVGFibGVNZXRhZGF0YVV0aWwuamF2YQ==) | `76.24% <100.00%> (-6.13%)` | :arrow_down: | ... and [691 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18544/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) :rocket: New features to boost your workflow: - :snowflake:
Re: [PR] fix: Skip pre-compaction rollback metadata reads in getValidInstantTimestamps [hudi]
codecov-commenter commented on PR #18544: URL: https://github.com/apache/hudi/pull/18544#issuecomment-4411220556 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18544?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 44.88%. Comparing base ([`47bf4e4`](https://app.codecov.io/gh/apache/hudi/commit/47bf4e41342e4f1dab26a7fb1489f278fbd1226c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`67eac7a`](https://app.codecov.io/gh/apache/hudi/commit/67eac7ab767b5f7d059efd854b16f25a7b1241d0?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). > :exclamation: There is a different number of reports uploaded between BASE (47bf4e4) and HEAD (67eac7a). Click for more details. > > HEAD has 22 uploads less than BASE > >| Flag | BASE (47bf4e4) | HEAD (67eac7a) | >|--|--|--| >|spark-scala-tests|12|6| >|spark-java-tests|18|4| >|common-and-other-modules|1|0| >|utilities|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18544 +/- ## = - Coverage 68.14% 44.88% -23.26% + Complexity2907715925-13152 = Files 2522 2049 -473 Lines141177 117177-24000 Branches 1751415238 -2276 = - Hits 9620852598-43610 - Misses3706158420+21359 + Partials 7908 6159 -1749 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.01% <100.00%> (+<0.01%)` | :arrow_up: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `21.36% <0.00%> (-26.99%)` | :arrow_down: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `31.95% <100.00%> (-17.05%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.73% <100.00%> (-12.17%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18544?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [.../apache/hudi/metadata/HoodieTableMetadataUtil.java](https://app.codecov.io/gh/apache/hudi/pull/18544?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieTableMetadataUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvbWV0YWRhdGEvSG9vZGllVGFibGVNZXRhZGF0YVV0aWwuamF2YQ==) | `72.66% <100.00%> (-9.71%)` | :arrow_down: | ... and [1705 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18544/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) :rocket: New features to boost your workflow: - :snowflake: [T
Re: [PR] fix: Skip pre-compaction rollback metadata reads in getValidInstantTimestamps [hudi]
codecov-commenter commented on PR #18544: URL: https://github.com/apache/hudi/pull/18544#issuecomment-4411224018 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18544?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 59.28%. Comparing base ([`47bf4e4`](https://app.codecov.io/gh/apache/hudi/commit/47bf4e41342e4f1dab26a7fb1489f278fbd1226c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`67eac7a`](https://app.codecov.io/gh/apache/hudi/commit/67eac7ab767b5f7d059efd854b16f25a7b1241d0?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). > :exclamation: There is a different number of reports uploaded between BASE (47bf4e4) and HEAD (67eac7a). Click for more details. > > HEAD has 19 uploads less than BASE > >| Flag | BASE (47bf4e4) | HEAD (67eac7a) | >|--|--|--| >|spark-scala-tests|12|6| >|spark-java-tests|18|5| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18544 +/- ## - Coverage 68.14% 59.28% -8.87% + Complexity2907725186-3891 Files 2522 2522 Lines141177 141185 +8 Branches 1751417515 +1 - Hits 9620883695 -12513 - Misses3706149902 +12841 + Partials 7908 7588 -320 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.42% <100.00%> (+<0.01%)` | :arrow_up: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.01% <100.00%> (+<0.01%)` | :arrow_up: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `21.36% <0.00%> (-26.99%)` | :arrow_down: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `31.57% <100.00%> (-17.43%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.73% <100.00%> (-12.17%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.65% <100.00%> (+0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18544?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [.../apache/hudi/metadata/HoodieTableMetadataUtil.java](https://app.codecov.io/gh/apache/hudi/pull/18544?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieTableMetadataUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvbWV0YWRhdGEvSG9vZGllVGFibGVNZXRhZGF0YVV0aWwuamF2YQ==) | `76.24% <100.00%> (-6.13%)` | :arrow_down: | ... and [691 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18544/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) :rocket: New features to boost your workflow: - :snowflake:
Re: [PR] fix: Skip pre-compaction rollback metadata reads in getValidInstantTimestamps [hudi]
codecov-commenter commented on PR #18544: URL: https://github.com/apache/hudi/pull/18544#issuecomment-4411218597 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18544?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 44.86%. Comparing base ([`47bf4e4`](https://app.codecov.io/gh/apache/hudi/commit/47bf4e41342e4f1dab26a7fb1489f278fbd1226c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`67eac7a`](https://app.codecov.io/gh/apache/hudi/commit/67eac7ab767b5f7d059efd854b16f25a7b1241d0?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). > :exclamation: There is a different number of reports uploaded between BASE (47bf4e4) and HEAD (67eac7a). Click for more details. > > HEAD has 23 uploads less than BASE > >| Flag | BASE (47bf4e4) | HEAD (67eac7a) | >|--|--|--| >|spark-scala-tests|12|6| >|spark-java-tests|18|3| >|common-and-other-modules|1|0| >|utilities|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18544 +/- ## = - Coverage 68.14% 44.86% -23.29% + Complexity2907715915-13162 = Files 2522 2049 -473 Lines141177 117177-24000 Branches 1751415238 -2276 = - Hits 9620852566-43642 - Misses3706158449+21388 + Partials 7908 6162 -1746 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.01% <100.00%> (+<0.01%)` | :arrow_up: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `21.36% <0.00%> (-26.99%)` | :arrow_down: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.36% <100.00%> (-16.64%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.73% <100.00%> (-12.17%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18544?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [.../apache/hudi/metadata/HoodieTableMetadataUtil.java](https://app.codecov.io/gh/apache/hudi/pull/18544?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieTableMetadataUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvbWV0YWRhdGEvSG9vZGllVGFibGVNZXRhZGF0YVV0aWwuamF2YQ==) | `72.66% <100.00%> (-9.71%)` | :arrow_down: | ... and [1705 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18544/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) :rocket: New features to boost your workflow: - :snowflake: [T
Re: [PR] fix: Skip pre-compaction rollback metadata reads in getValidInstantTimestamps [hudi]
codecov-commenter commented on PR #18544: URL: https://github.com/apache/hudi/pull/18544#issuecomment-4411214023 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18544?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 44.82%. Comparing base ([`47bf4e4`](https://app.codecov.io/gh/apache/hudi/commit/47bf4e41342e4f1dab26a7fb1489f278fbd1226c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`67eac7a`](https://app.codecov.io/gh/apache/hudi/commit/67eac7ab767b5f7d059efd854b16f25a7b1241d0?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). > :exclamation: There is a different number of reports uploaded between BASE (47bf4e4) and HEAD (67eac7a). Click for more details. > > HEAD has 24 uploads less than BASE > >| Flag | BASE (47bf4e4) | HEAD (67eac7a) | >|--|--|--| >|spark-scala-tests|12|6| >|spark-java-tests|18|2| >|common-and-other-modules|1|0| >|utilities|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18544 +/- ## = - Coverage 68.14% 44.82% -23.33% + Complexity2907715903-13174 = Files 2522 2049 -473 Lines141177 117177-24000 Branches 1751415238 -2276 = - Hits 9620852527-43681 - Misses3706158484+21423 + Partials 7908 6166 -1742 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.01% <100.00%> (+<0.01%)` | :arrow_up: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `21.36% <0.00%> (-26.99%)` | :arrow_down: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.73% <100.00%> (-16.27%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.73% <100.00%> (-12.17%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18544?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [.../apache/hudi/metadata/HoodieTableMetadataUtil.java](https://app.codecov.io/gh/apache/hudi/pull/18544?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieTableMetadataUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvbWV0YWRhdGEvSG9vZGllVGFibGVNZXRhZGF0YVV0aWwuamF2YQ==) | `72.66% <100.00%> (-9.71%)` | :arrow_down: | ... and [1706 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18544/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) :rocket: New features to boost your workflow: - :snowflake: [T
Re: [PR] fix: Skip pre-compaction rollback metadata reads in getValidInstantTimestamps [hudi]
codecov-commenter commented on PR #18544: URL: https://github.com/apache/hudi/pull/18544#issuecomment-4411210837 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18544?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 42.20%. Comparing base ([`47bf4e4`](https://app.codecov.io/gh/apache/hudi/commit/47bf4e41342e4f1dab26a7fb1489f278fbd1226c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`67eac7a`](https://app.codecov.io/gh/apache/hudi/commit/67eac7ab767b5f7d059efd854b16f25a7b1241d0?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). > :exclamation: There is a different number of reports uploaded between BASE (47bf4e4) and HEAD (67eac7a). Click for more details. > > HEAD has 29 uploads less than BASE > >| Flag | BASE (47bf4e4) | HEAD (67eac7a) | >|--|--|--| >|spark-scala-tests|12|3| >|spark-java-tests|18|0| >|common-and-other-modules|1|0| >|utilities|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18544 +/- ## = - Coverage 68.14% 42.20% -25.95% + Complexity2907714267-14810 = Files 2522 1998 -524 Lines141177 112007-29170 Branches 1751414130 -3384 = - Hits 9620847274-48934 - Misses3706159192+22131 + Partials 7908 5541 -2367 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.01% <100.00%> (+<0.01%)` | :arrow_up: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `21.36% <0.00%> (-26.99%)` | :arrow_down: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.97% <100.00%> (-11.94%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18544?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [.../apache/hudi/metadata/HoodieTableMetadataUtil.java](https://app.codecov.io/gh/apache/hudi/pull/18544?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieTableMetadataUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvbWV0YWRhdGEvSG9vZGllVGFibGVNZXRhZGF0YVV0aWwuamF2YQ==) | `57.00% <100.00%> (-25.36%)` | :arrow_down: | ... and [1790 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18544/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) :rocket: New features to boost your workflow: - :snowflake: [Test Analytics](https://docs.codecov.
Re: [PR] fix: Skip pre-compaction rollback metadata reads in getValidInstantTimestamps [hudi]
codecov-commenter commented on PR #18544: URL: https://github.com/apache/hudi/pull/18544#issuecomment-4411213763 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18544?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 45.15%. Comparing base ([`47bf4e4`](https://app.codecov.io/gh/apache/hudi/commit/47bf4e41342e4f1dab26a7fb1489f278fbd1226c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`67eac7a`](https://app.codecov.io/gh/apache/hudi/commit/67eac7ab767b5f7d059efd854b16f25a7b1241d0?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). > :exclamation: There is a different number of reports uploaded between BASE (47bf4e4) and HEAD (67eac7a). Click for more details. > > HEAD has 26 uploads less than BASE > >| Flag | BASE (47bf4e4) | HEAD (67eac7a) | >|--|--|--| >|spark-scala-tests|12|5| >|spark-java-tests|18|1| >|common-and-other-modules|1|0| >|utilities|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18544 +/- ## = - Coverage 68.14% 45.15% -22.99% + Complexity2907715652-13425 = Files 2522 2028 -494 Lines141177 114688-26489 Branches 1751414701 -2813 = - Hits 9620851790-44418 - Misses3706156920+19859 + Partials 7908 5978 -1930 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.01% <100.00%> (+<0.01%)` | :arrow_up: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `21.36% <0.00%> (-26.99%)` | :arrow_down: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.09% <100.00%> (-15.91%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.84% <100.00%> (-12.07%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18544?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [.../apache/hudi/metadata/HoodieTableMetadataUtil.java](https://app.codecov.io/gh/apache/hudi/pull/18544?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieTableMetadataUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvbWV0YWRhdGEvSG9vZGllVGFibGVNZXRhZGF0YVV0aWwuamF2YQ==) | `71.96% <100.00%> (-10.41%)` | :arrow_down: | ... and [1719 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18544/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) :rocket: New features to boost your workflow: - :snowflake: [
Re: [PR] fix: Skip pre-compaction rollback metadata reads in getValidInstantTimestamps [hudi]
codecov-commenter commented on PR #18544: URL: https://github.com/apache/hudi/pull/18544#issuecomment-4411212404 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18544?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 41.85%. Comparing base ([`47bf4e4`](https://app.codecov.io/gh/apache/hudi/commit/47bf4e41342e4f1dab26a7fb1489f278fbd1226c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`67eac7a`](https://app.codecov.io/gh/apache/hudi/commit/67eac7ab767b5f7d059efd854b16f25a7b1241d0?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). > :exclamation: There is a different number of reports uploaded between BASE (47bf4e4) and HEAD (67eac7a). Click for more details. > > HEAD has 27 uploads less than BASE > >| Flag | BASE (47bf4e4) | HEAD (67eac7a) | >|--|--|--| >|spark-scala-tests|12|5| >|spark-java-tests|18|0| >|common-and-other-modules|1|0| >|utilities|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18544 +/- ## = - Coverage 68.14% 41.85% -26.30% + Complexity2907714507-14570 = Files 2522 2028 -494 Lines141177 114688-26489 Branches 1751414701 -2813 = - Hits 9620848003-48205 - Misses3706160945+23884 + Partials 7908 5740 -2168 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.01% <100.00%> (+<0.01%)` | :arrow_up: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `21.36% <0.00%> (-26.99%)` | :arrow_down: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.84% <100.00%> (-12.07%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18544?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [.../apache/hudi/metadata/HoodieTableMetadataUtil.java](https://app.codecov.io/gh/apache/hudi/pull/18544?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieTableMetadataUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvbWV0YWRhdGEvSG9vZGllVGFibGVNZXRhZGF0YVV0aWwuamF2YQ==) | `57.00% <100.00%> (-25.36%)` | :arrow_down: | ... and [1772 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18544/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) :rocket: New features to boost your workflow: - :snowflake: [Test Analytics](https://docs.codecov.
Re: [PR] fix: Skip pre-compaction rollback metadata reads in getValidInstantTimestamps [hudi]
codecov-commenter commented on PR #18544: URL: https://github.com/apache/hudi/pull/18544#issuecomment-4411211423 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18544?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 42.20%. Comparing base ([`47bf4e4`](https://app.codecov.io/gh/apache/hudi/commit/47bf4e41342e4f1dab26a7fb1489f278fbd1226c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`67eac7a`](https://app.codecov.io/gh/apache/hudi/commit/67eac7ab767b5f7d059efd854b16f25a7b1241d0?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). > :exclamation: There is a different number of reports uploaded between BASE (47bf4e4) and HEAD (67eac7a). Click for more details. > > HEAD has 28 uploads less than BASE > >| Flag | BASE (47bf4e4) | HEAD (67eac7a) | >|--|--|--| >|spark-scala-tests|12|4| >|spark-java-tests|18|0| >|common-and-other-modules|1|0| >|utilities|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18544 +/- ## = - Coverage 68.14% 42.20% -25.94% + Complexity2907714267-14810 = Files 2522 1998 -524 Lines141177 112012-29165 Branches 1751414136 -3378 = - Hits 9620847280-48928 - Misses3706159194+22133 + Partials 7908 5538 -2370 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.01% <100.00%> (+<0.01%)` | :arrow_up: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `21.36% <0.00%> (-26.99%)` | :arrow_down: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.97% <100.00%> (-11.94%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18544?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [.../apache/hudi/metadata/HoodieTableMetadataUtil.java](https://app.codecov.io/gh/apache/hudi/pull/18544?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieTableMetadataUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvbWV0YWRhdGEvSG9vZGllVGFibGVNZXRhZGF0YVV0aWwuamF2YQ==) | `57.00% <100.00%> (-25.36%)` | :arrow_down: | ... and [1788 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18544/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) :rocket: New features to boost your workflow: - :snowflake: [Test Analytics](https://docs.codecov.
Re: [PR] fix: Skip pre-compaction rollback metadata reads in getValidInstantTimestamps [hudi]
codecov-commenter commented on PR #18544: URL: https://github.com/apache/hudi/pull/18544#issuecomment-4411205972 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18544?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 42.85%. Comparing base ([`47bf4e4`](https://app.codecov.io/gh/apache/hudi/commit/47bf4e41342e4f1dab26a7fb1489f278fbd1226c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`67eac7a`](https://app.codecov.io/gh/apache/hudi/commit/67eac7ab767b5f7d059efd854b16f25a7b1241d0?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). > :exclamation: There is a different number of reports uploaded between BASE (47bf4e4) and HEAD (67eac7a). Click for more details. > > HEAD has 31 uploads less than BASE > >| Flag | BASE (47bf4e4) | HEAD (67eac7a) | >|--|--|--| >|spark-scala-tests|12|1| >|spark-java-tests|18|0| >|common-and-other-modules|1|0| >|utilities|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18544 +/- ## = - Coverage 68.14% 42.85% -25.29% + Complexity2907713852-15225 = Files 2522 1963 -559 Lines141177 107101-34076 Branches 1751413050 -4464 = - Hits 9620845902-50306 - Misses3706156007+18946 + Partials 7908 5192 -2716 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.01% <100.00%> (+<0.01%)` | :arrow_up: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `21.36% <0.00%> (-26.99%)` | :arrow_down: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.20% <100.00%> (-11.71%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18544?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [.../apache/hudi/metadata/HoodieTableMetadataUtil.java](https://app.codecov.io/gh/apache/hudi/pull/18544?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieTableMetadataUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvbWV0YWRhdGEvSG9vZGllVGFibGVNZXRhZGF0YVV0aWwuamF2YQ==) | `57.00% <100.00%> (-25.36%)` | :arrow_down: | ... and [1833 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18544/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) :rocket: New features to boost your workflow: - :snowflake: [Test Analytics](https://docs.codecov.
Re: [PR] fix: Skip pre-compaction rollback metadata reads in getValidInstantTimestamps [hudi]
codecov-commenter commented on PR #18544: URL: https://github.com/apache/hudi/pull/18544#issuecomment-4411206404 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18544?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 42.58%. Comparing base ([`47bf4e4`](https://app.codecov.io/gh/apache/hudi/commit/47bf4e41342e4f1dab26a7fb1489f278fbd1226c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`67eac7a`](https://app.codecov.io/gh/apache/hudi/commit/67eac7ab767b5f7d059efd854b16f25a7b1241d0?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). > :exclamation: There is a different number of reports uploaded between BASE (47bf4e4) and HEAD (67eac7a). Click for more details. > > HEAD has 30 uploads less than BASE > >| Flag | BASE (47bf4e4) | HEAD (67eac7a) | >|--|--|--| >|spark-scala-tests|12|2| >|spark-java-tests|18|0| >|common-and-other-modules|1|0| >|utilities|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18544 +/- ## = - Coverage 68.14% 42.58% -25.57% + Complexity2907714061-15016 = Files 2522 1981 -541 Lines141177 109635-31542 Branches 1751413620 -3894 = - Hits 9620846688-49520 - Misses3706157591+20530 + Partials 7908 5356 -2552 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.01% <100.00%> (+<0.01%)` | :arrow_up: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `21.36% <0.00%> (-26.99%)` | :arrow_down: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.15% <100.00%> (-11.76%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18544?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [.../apache/hudi/metadata/HoodieTableMetadataUtil.java](https://app.codecov.io/gh/apache/hudi/pull/18544?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieTableMetadataUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvbWV0YWRhdGEvSG9vZGllVGFibGVNZXRhZGF0YVV0aWwuamF2YQ==) | `57.00% <100.00%> (-25.36%)` | :arrow_down: | ... and [1804 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18544/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) :rocket: New features to boost your workflow: - :snowflake: [Test Analytics](https://docs.codecov.
Re: [PR] fix: Skip pre-compaction rollback metadata reads in getValidInstantTimestamps [hudi]
codecov-commenter commented on PR #18544: URL: https://github.com/apache/hudi/pull/18544#issuecomment-4411139692 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18544?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 44.19%. Comparing base ([`47bf4e4`](https://app.codecov.io/gh/apache/hudi/commit/47bf4e41342e4f1dab26a7fb1489f278fbd1226c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`67eac7a`](https://app.codecov.io/gh/apache/hudi/commit/67eac7ab767b5f7d059efd854b16f25a7b1241d0?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). > :exclamation: There is a different number of reports uploaded between BASE (47bf4e4) and HEAD (67eac7a). Click for more details. > > HEAD has 32 uploads less than BASE > >| Flag | BASE (47bf4e4) | HEAD (67eac7a) | >|--|--|--| >|spark-scala-tests|12|0| >|spark-java-tests|18|0| >|common-and-other-modules|1|0| >|utilities|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18544 +/- ## = - Coverage 68.14% 44.19% -23.96% + Complexity29077 9963-19114 = Files 2522 1434 -1088 Lines14117772141-69036 Branches 17514 8239 -9275 = - Hits 9620831884-64324 - Misses3706137077 +16 + Partials 7908 3180 -4728 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.01% <100.00%> (+<0.01%)` | :arrow_up: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `21.36% <0.00%> (-26.99%)` | :arrow_down: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18544?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [.../apache/hudi/metadata/HoodieTableMetadataUtil.java](https://app.codecov.io/gh/apache/hudi/pull/18544?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieTableMetadataUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvbWV0YWRhdGEvSG9vZGllVGFibGVNZXRhZGF0YVV0aWwuamF2YQ==) | `53.81% <100.00%> (-28.56%)` | :arrow_down: | ... and [2048 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18544/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) :rocket: New features to boost your workflow: - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky
Re: [PR] fix: Skip pre-compaction rollback metadata reads in getValidInstantTimestamps [hudi]
hudi-agent commented on code in PR #18544:
URL: https://github.com/apache/hudi/pull/18544#discussion_r3212272767
##
hudi-common/src/main/java/org/apache/hudi/metadata/HoodieTableMetadataUtil.java:
##
@@ -2098,9 +2098,25 @@ public static Set
getValidInstantTimestamps(HoodieTableMetaClient dataMe
// For any rollbacks and restores, we cannot neglect the instants that
they are rolling back.
// The rollback instant should be more recent than the start of the
timeline for it to have rolled back any
// instant which we have a log block for.
+//
+// Only read rollback metadata for rollbacks newer than the latest MDT
compaction.
+// After compaction, rolled-back log blocks are already merged into base
files, so pre-compaction
+// rollback timestamps are no longer needed for log block filtering. This
avoids sequential storage
+// reads for old rollback instants that can cause long latency during
metadata table reading.
final String earliestInstantTime = validInstantTimestamps.isEmpty() ?
SOLO_COMMIT_TIMESTAMP : Collections.min(validInstantTimestamps);
+final String latestMdtCompactionTime =
metadataMetaClient.getActiveTimeline()
+.getCommitTimeline()
Review Comment:
🤖 The existing `HoodieBackedTableMetadata.getLatestCompactionTime()` (line
808) uses `getCommitAndReplaceTimeline()` which also includes
`REPLACE_COMMIT_ACTION` / `CLUSTERING_ACTION`, while this new code uses only
`getCommitTimeline()` (just `COMMIT_ACTION`). Was this intentional? It's safe
today since MDT only emits compaction commits as `COMMIT_ACTION`, but the
inconsistency is a small future-proofing risk if MDT ever gains
clustering/replace semantics — and reusing/sharing the existing helper would
also avoid the duplicated lookup logic.
- AI-generated; verify before applying. React 👍/👎 to flag
quality.
##
hudi-hadoop-common/src/test/java/org/apache/hudi/metadata/TestHoodieTableMetadataUtil.java:
##
@@ -869,4 +878,89 @@ private static Stream
mapKeyNoSeparatorToFileGroupIndexTestCases() {
)
);
}
+
+ /**
+ * Tests getValidInstantTimestamps rollback handling:
+ * - Without MDT compaction, all rollback metadata is read (rolled-back
commits appear in valid timestamps).
+ * - With MDT compaction, only post-compaction rollback metadata is read
(pre-compaction rollbacks are skipped
+ * because those log blocks are already merged into base files).
+ */
+ @Test
+ void testGetValidInstantTimestampsSkipsPreCompactionRollbacks() throws
Exception {
+HoodieTestTable testTable = HoodieTestTable.of(metaClient);
+
+String commit1 = "20260101010101000";
+String commit2 = "20260201010101000";
+String commit3 = "20260301010101000";
+String commit4 = "20260501010101000";
+String commit5 = "20260601010101000";
+testTable.addCommit(commit1);
+testTable.addCommit(commit2);
+testTable.addCommit(commit3);
+testTable.addCommit(commit4);
+testTable.addCommit(commit5);
+
+// Rollbacks before MDT compaction time
+addCompletedRollback(testTable, "20260202010101000", commit2);
+addCompletedRollback(testTable, "20260302010101000", commit3);
+// Rollback after MDT compaction time
+addCompletedRollback(testTable, "20260502010101000", commit4);
+
+// Delete rolled-back commit instants from the timeline to simulate real
rollback behavior.
+// In a real system, the commit instant file is removed when a rollback
completes, so the
+// only way these timestamps appear in validInstantTimestamps is via
rollback metadata reading.
+metaClient = HoodieTableMetaClient.reload(metaClient);
+for (String rolledBack : Arrays.asList(commit2, commit3, commit4)) {
+ HoodieInstant completedCommit = metaClient.getInstantGenerator()
+ .createNewInstant(HoodieInstant.State.COMPLETED,
HoodieTimeline.COMMIT_ACTION, rolledBack);
+
metaClient.getActiveTimeline().deleteInstantFileIfExists(completedCommit);
+}
+
+// Create MDT metaClient with NO compaction initially (only delta commits)
+String mdtBasePath =
HoodieTableMetadata.getMetadataTableBasePath(basePath);
+HoodieTestUtils.init(mdtBasePath, HoodieTableType.MERGE_ON_READ);
+HoodieTableMetaClient mdtMetaClient = HoodieTableMetaClient.builder()
+.setBasePath(mdtBasePath)
+.build();
+HoodieTestTable mdtTestTable = HoodieTestTable.of(mdtMetaClient);
+mdtTestTable.addDeltaCommit("20260101020101000");
+
+metaClient = HoodieTableMetaClient.reload(metaClient);
+mdtMetaClient = HoodieTableMetaClient.reload(mdtMetaClient);
+
+// Without MDT compaction, all rollback metadata is read — rolled-back
commits appear
+Set validTimestamps =
HoodieTableMetadataUtil.getValidInstantTimestamps(metaClient, mdtMetaClient);
+assertTrue(validTimestamps.contains(commit1), "commit1 should be in valid
timestamps");
+assertTrue(validTimestamps.contains(commit2)
Re: [PR] fix: Skip pre-compaction rollback metadata reads in getValidInstantTimestamps [hudi]
hudi-bot commented on PR #18544: URL: https://github.com/apache/hudi/pull/18544#issuecomment-4411133807 ## CI report: * 67eac7ab767b5f7d059efd854b16f25a7b1241d0 Azure: [FAILURE](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13905) Bot commands @hudi-bot supports the following commands: - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] fix: Skip pre-compaction rollback metadata reads in getValidInstantTimestamps [hudi]
hudi-bot commented on PR #18544: URL: https://github.com/apache/hudi/pull/18544#issuecomment-4411107675 ## CI report: * e32a6189c87891a2b1c24d69f7347a9f4f86fcf5 Azure: [FAILURE](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13426) * 67eac7ab767b5f7d059efd854b16f25a7b1241d0 Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13905) Bot commands @hudi-bot supports the following commands: - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] fix: Skip pre-compaction rollback metadata reads in getValidInstantTimestamps [hudi]
codecov-commenter commented on PR #18544: URL: https://github.com/apache/hudi/pull/18544#issuecomment-4411108046 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18544?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `0%` with `9 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 21.36%. Comparing base ([`47bf4e4`](https://app.codecov.io/gh/apache/hudi/commit/47bf4e41342e4f1dab26a7fb1489f278fbd1226c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`67eac7a`](https://app.codecov.io/gh/apache/hudi/commit/67eac7ab767b5f7d059efd854b16f25a7b1241d0?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18544?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [.../apache/hudi/metadata/HoodieTableMetadataUtil.java](https://app.codecov.io/gh/apache/hudi/pull/18544?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieTableMetadataUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvbWV0YWRhdGEvSG9vZGllVGFibGVNZXRhZGF0YVV0aWwuamF2YQ==) | 0.00% | [9 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18544?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | > :exclamation: There is a different number of reports uploaded between BASE (47bf4e4) and HEAD (67eac7a). Click for more details. > > HEAD has 33 uploads less than BASE > >| Flag | BASE (47bf4e4) | HEAD (67eac7a) | >|--|--|--| >|hadoop-mr-java-client|1|0| >|spark-scala-tests|12|0| >|spark-java-tests|18|0| >|common-and-other-modules|1|0| >|utilities|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18544 +/- ## = - Coverage 68.14% 21.36% -46.79% + Complexity29077 5084-23993 = Files 2522 1389 -1133 Lines14117771193-69984 Branches 17514 8172 -9342 = - Hits 9620815209-80999 - Misses3706154439+17378 + Partials 7908 1545 -6363 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `21.36% <0.00%> (-26.99%)` | :arrow_down: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18544?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverag
Re: [PR] fix: Skip pre-compaction rollback metadata reads in getValidInstantTimestamps [hudi]
hudi-bot commented on PR #18544: URL: https://github.com/apache/hudi/pull/18544#issuecomment-4411089329 ## CI report: * e32a6189c87891a2b1c24d69f7347a9f4f86fcf5 Azure: [FAILURE](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13426) * 67eac7ab767b5f7d059efd854b16f25a7b1241d0 UNKNOWN Bot commands @hudi-bot supports the following commands: - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] fix: Skip pre-compaction rollback metadata reads in getValidInstantTimestamps [hudi]
hudi-agent commented on code in PR #18544:
URL: https://github.com/apache/hudi/pull/18544#discussion_r3127506114
##
hudi-hadoop-common/src/test/java/org/apache/hudi/metadata/TestHoodieTableMetadataUtil.java:
##
@@ -869,4 +877,89 @@ private static Stream
mapKeyNoSeparatorToFileGroupIndexTestCases() {
)
);
}
+
+ /**
+ * Tests getValidInstantTimestamps rollback handling:
+ * - Without MDT compaction, all rollback metadata is read (rolled-back
commits appear in valid timestamps).
+ * - With MDT compaction, only post-compaction rollback metadata is read
(pre-compaction rollbacks are skipped
+ * because those log blocks are already merged into base files).
+ */
+ @Test
+ void testGetValidInstantTimestampsSkipsPreCompactionRollbacks() throws
Exception {
+HoodieTestTable testTable = HoodieTestTable.of(metaClient);
+
+String commit1 = "20260101010101000";
+String commit2 = "20260201010101000";
+String commit3 = "20260301010101000";
+String commit4 = "20260501010101000";
+String commit5 = "20260601010101000";
+testTable.addCommit(commit1);
+testTable.addCommit(commit2);
+testTable.addCommit(commit3);
+testTable.addCommit(commit4);
+testTable.addCommit(commit5);
+
+// Rollbacks before MDT compaction time
+addCompletedRollback(testTable, "20260202010101000", commit2);
+addCompletedRollback(testTable, "20260302010101000", commit3);
+// Rollback after MDT compaction time
+addCompletedRollback(testTable, "20260502010101000", commit4);
+
+// Delete rolled-back commit instants from the timeline to simulate real
rollback behavior.
+// In a real system, the commit instant file is removed when a rollback
completes, so the
+// only way these timestamps appear in validInstantTimestamps is via
rollback metadata reading.
+metaClient = HoodieTableMetaClient.reload(metaClient);
+for (String rolledBack : Arrays.asList(commit2, commit3, commit4)) {
+ HoodieInstant completedCommit = metaClient.getInstantGenerator()
+ .createNewInstant(HoodieInstant.State.COMPLETED,
HoodieTimeline.COMMIT_ACTION, rolledBack);
+
metaClient.getActiveTimeline().deleteInstantFileIfExists(completedCommit);
+}
+
+// Create MDT metaClient with NO compaction initially (only delta commits)
+String mdtBasePath =
HoodieTableMetadata.getMetadataTableBasePath(basePath);
+HoodieTestUtils.init(mdtBasePath, HoodieTableType.MERGE_ON_READ);
+HoodieTableMetaClient mdtMetaClient = HoodieTableMetaClient.builder()
+.setBasePath(mdtBasePath)
+.build();
+HoodieTestTable mdtTestTable = HoodieTestTable.of(mdtMetaClient);
+mdtTestTable.addDeltaCommit("20260101020101000");
+
+metaClient = HoodieTableMetaClient.reload(metaClient);
+mdtMetaClient = HoodieTableMetaClient.reload(mdtMetaClient);
+
+// Without MDT compaction, all rollback metadata is read — rolled-back
commits appear
Review Comment:
🤖 nit: this comment is cut off mid-sentence — could you finish it? Something
like `// Without MDT compaction, all rollback metadata is read — rolled-back
commits appear in validTimestamps` would complete the thought.
- Generated by an AI agent and may contain mistakes. Please verify
any suggestions before applying.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] fix: Skip pre-compaction rollback metadata reads in getValidInstantTimestamps [hudi]
hudi-bot commented on PR #18544: URL: https://github.com/apache/hudi/pull/18544#issuecomment-4293097030 ## CI report: * e32a6189c87891a2b1c24d69f7347a9f4f86fcf5 Azure: [FAILURE](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13426) Bot commands @hudi-bot supports the following commands: - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] fix: Skip pre-compaction rollback metadata reads in getValidInstantTimestamps [hudi]
hudi-bot commented on PR #18544: URL: https://github.com/apache/hudi/pull/18544#issuecomment-4293087809 ## CI report: * e32a6189c87891a2b1c24d69f7347a9f4f86fcf5 UNKNOWN Bot commands @hudi-bot supports the following commands: - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
