IMPALA-7043: HBase split failure should not fail dataload

HBase splitting can fail due to changes in HBase code. It
is useful to still do tests even if HBase splitting failed.
As it is today, buildall.sh will abort if
create-load-data.sh's invocation of split-hbase.sh fails.
No tests run, even though the HBase splitting affects only
a small portion of our tests.

This changes create-load-data.sh to keep going with
dataload if HBase splitting fails. It outputs the same
errors to the log as it would before this change.
It adds a message to explain that it is ignoring
the failure and there may be related test failures.

Change-Id: I7497fe8c9f1655a34b2743462d8b7248eb94554e
Reviewed-on: http://gerrit.cloudera.org:8080/10437
Reviewed-by: Philip Zeyliger <phi...@cloudera.com>
Tested-by: Impala Public Jenkins <impala-public-jenk...@cloudera.com>


Project: http://git-wip-us.apache.org/repos/asf/impala/repo
Commit: http://git-wip-us.apache.org/repos/asf/impala/commit/99e379dc
Tree: http://git-wip-us.apache.org/repos/asf/impala/tree/99e379dc
Diff: http://git-wip-us.apache.org/repos/asf/impala/diff/99e379dc

Branch: refs/heads/2.x
Commit: 99e379dc57e561f476b3d35e5c52c0ae0f8ac767
Parents: bf7e766
Author: Joe McDonnell <joemcdonn...@cloudera.com>
Authored: Wed May 16 14:41:37 2018 -0700
Committer: Impala Public Jenkins <impala-public-jenk...@gerrit.cloudera.org>
Committed: Thu May 17 22:03:02 2018 +0000

----------------------------------------------------------------------
 testdata/bin/create-load-data.sh | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/impala/blob/99e379dc/testdata/bin/create-load-data.sh
----------------------------------------------------------------------
diff --git a/testdata/bin/create-load-data.sh b/testdata/bin/create-load-data.sh
index a97a2e2..4d3928a 100755
--- a/testdata/bin/create-load-data.sh
+++ b/testdata/bin/create-load-data.sh
@@ -574,7 +574,11 @@ if [ "${TARGET_FILESYSTEM}" = "hdfs" ]; then
 
   # HBase splitting is only relevant for FE tests
   if [[ -z "$REMOTE_LOAD" ]]; then
-    run-step "Splitting HBase" create-hbase.log 
${IMPALA_HOME}/testdata/bin/split-hbase.sh
+    IGNORE_MSG="Ignoring this HBase splitting failure to allow dataload to 
complete and
+        tests to run. This failure will cause some frontend tests to fail, and 
it may
+        impact some HBase tests. Other tests are unaffected."
+    run-step "Splitting HBase" create-hbase.log 
${IMPALA_HOME}/testdata/bin/split-hbase.sh \
+        || echo ${IGNORE_MSG}
   fi
 
   run-step "Creating internal HBase table" create-internal-hbase-table.log \

Reply via email to