This is an automated email from the ASF dual-hosted git repository. danhaywood pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/isis.git
commit e0cb0853671a803c5356ef5ea8e1a884ddfebe78 Author: Dan Haywood <d...@haywood-associates.co.uk> AuthorDate: Wed Feb 14 14:27:19 2018 +0000 ISIS-1846: reinstates reflections as a non-optional compile-time dependency, since required for both compile and runtime. --- core/applib/pom.xml | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/core/applib/pom.xml b/core/applib/pom.xml index 596f0a9..2d84f74 100644 --- a/core/applib/pom.xml +++ b/core/applib/pom.xml @@ -122,7 +122,6 @@ <dependency> <groupId>org.axonframework</groupId> <artifactId>axon-core</artifactId> - <optional>true</optional> </dependency> <dependency> @@ -166,9 +165,11 @@ <dependency> <groupId>org.reflections</groupId> <artifactId>reflections</artifactId> - <!-- we enforce usage of internal reflective API, - only applib is allowed to access reflections directly --> - <optional>true</optional> + <!-- + ideally we would like to make this optional (to enforce usage of internal + reflective API, with only applib is allowed to access reflections directly. + HOWEVER, there is also a runtime dependency on org.reflections.vfs.Vfs.UrlType. --> + <optional>false</optional> </dependency> <!-- provides @Nullable --> -- To stop receiving notification emails like this one, please contact danhayw...@apache.org.