This is an automated email from the ASF dual-hosted git repository. danhaywood pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/isis.git.
from 1b19e6e ISIS-1810: fixes compile issues arising from merge add e29b26f ISIS-1852 allow local thread variable propagation to any child threads add 3706fa9 ISIS-1852 testcase backported to JDK 7 new 0d749ce ISIS-1852: fixes unit test new c149771 Merge branch 'ISIS-1852_parallel_stream_patch' add b958267 ISIS-1846 beginning with consolidation of internal utilities add c16086d Merge branch 'master' into ISIS-1846_internal_utils add c407760 ISIS-1846 consolidate utilities add 3ccfd33 ISIS-1846 deduplicate uses of asNaturalName2 and other add 44af17e ISIS-1846 deprecate StringPredicates and StringFunctions, refactoring any references to use the new $String utility class add 0622780 ISIS-1846 use mixin naming convention for package private support classes add bc59167 ISIS-1846 add missing license header add b6f8293 ISIS-1846 StringOperator: improved name for composing method add debea9f ISIS-1846 consolidate comparator algorithms into $Comparators add 47790a6 ISIS-1846 refactoring: less heap pollution on sequence compare add 25f8b31 ISIS-1846 underscore(_) instead of dollar($) prefix for internal classes add 7ba8fd6 ISIS-1845 fix EventBusServiceDefaultTest NPE add 8b865d6 ISIS-1845 fix all tests in ObjectReflectorDefaultTest_object add 4a90358 ISIS-1846 test cases added for new utility classes add 954c03d ISIS-1827 refactoring out some guava predicate usages yet without breaking API add c32e448 ISIS-1827 cleanup public API java-doc in RepositoryService add 890cff5 ISIS-1827 reflect API changes in RepositoryServiceInternalDefault add 03823d7 ISIS-1827 guava free drop-in replacement for all ExceptionRecognizers add 6631872 ISIS-1827 reflect applib changes in ExceptionRecognizerDocDefault add 77b179b ISIS-1846 add capitalize to new _String utility + tests, cleanup Enums add 463947d ISIS-1846 fix Enums copy paste error add 62c3f3b ISIS-1827 added tests for all ExceptionRecognizers to reflect applib additions add dd3029c ISIS-1827 mark some unused public static guava functions deprecated add 7613ee7 ISIS-1846 consolidate uses of capitalize add 996cf2980 ISIS-1846 another occurrence of capitalize consolidated add a5931f6 ISIS-1846 clarify corner cases for string splitting + tests add 70a5f0d ISIS-1846 introduces _Constants (internal API) add 286b2c5 ISIS-1846 consolidate uses of constants 'emptyObjects' + 'emptyClasses' add c09cffb ISIS-1846 make constants final add 3b9aded ISIS-1841 replace uses of deprecated Nullable with Java's Optional add 8b19f8a ISIS-1841 Nullable, Closure, IterableExtensions removed (after refactoring, no longer needed), tests removed or adapted add 9c2514c ISIS-1841 remove unused setter, that does nothing anyway add fe219d0 ISIS-1846 add _Exceptions to internal API add 7d5b538 ISIS-1841 cleanup some compiler warnings add 8e8b5f1 ISIS-1841 refactoring switch statements add 7743f0b ISIS-1846 java-doc: simplify warnings for internal API use add 3bb3683 ISIS-1846 major refactoring: introduces _Reflect (internal API) add da7b587 ISIS-1846 minor refactoring: introduces _Context (internal API) add 5dd9f73 ISIS-1846 improve java-doc add 71101fc ISIS-1846 put empty string array also in _Constants for convenience add 66cd1f2 ISIS-1846 java-doc improved add 62725eb ISIS-1846 added reviewer notes and questions add 8ebd313 ISIS-1846 thread-safe (atomic) writes to _Context (singleton-store) new e989ad9 Merge remote-tracking branch 'origin/ISIS-1846_internal_utils' new c1d0732 ISIS-1846: fixes unit test (had accidentally changed contract) new e0cb085 ISIS-1846: reinstates reflections as a non-optional compile-time dependency, since required for both compile and runtime. new 96a2a78 ISIS-1852: removes debug System.out.println The 6 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: core/applib/pom.xml | 23 +- .../java/org/apache/isis/applib/AppManifest.java | 120 +-------- .../apache/isis/applib/AppManifestAbstract.java | 3 +- .../org/apache/isis/applib/IsisApplibModule.java | 5 +- .../org/apache/isis/applib/ModuleAbstract.java | 4 +- .../fixturescripts/BuilderScriptAbstract.java | 4 +- .../applib/fixturescripts/ExecutionParameters.java | 6 +- .../applib/fixturescripts/FixtureResultList.java | 4 +- .../isis/applib/fixturescripts/FixtureScript.java | 41 +-- .../isis/applib/fixturescripts/FixtureScripts.java | 3 + .../isis/applib/fixturescripts/StringUtil.java | 79 ------ .../_Constants.java} | 45 ++-- .../{util/Casts.java => internal/base/_Casts.java} | 18 +- .../isis/applib/internal/base/_NullSafe.java} | 74 ++++-- .../apache/isis/applib/internal/base/_Strings.java | 232 +++++++++++++++++ .../internal/base/_Strings_NaturalNames.java | 94 +++++++ .../internal/base/_Strings_SplitIterator.java | 73 ++++++ .../isis/applib/internal/base}/package-info.java | 15 +- .../compare/_Comparators.java} | 37 +-- .../compare/_Comparators_SequenceCompare.java} | 53 ++-- .../applib/internal/compare}/package-info.java | 15 +- .../isis/applib/internal/context/_Context.java | 151 +++++++++++ .../applib/internal/context}/package-info.java | 15 +- .../applib/internal/exceptions/_Exceptions.java | 85 +++++++ .../applib/internal/exceptions}/package-info.java | 15 +- .../apache/isis/applib/internal}/package-info.java | 15 +- .../isis/applib/internal/reflection/_Reflect.java | 83 ++++++ .../internal/reflection/_Reflect_Discovery.java | 85 +++++++ .../internal/reflection/_Reflect_Manifest.java | 147 +++++++++++ .../applib/internal/reflection}/package-info.java | 15 +- .../layout/component/CollectionLayoutData.java | 3 +- .../isis/applib/layout/component/FieldSet.java | 2 +- .../applib/layout/grid/bootstrap3/BS3ClearFix.java | 1 + .../layout/grid/bootstrap3/BS3ElementAbstract.java | 1 + .../applib/layout/grid/bootstrap3/BS3Grid.java | 2 +- .../isis/applib/layout/grid/bootstrap3/BS3Tab.java | 4 +- .../applib/layout/menubars/MenuBarsAbstract.java | 1 + .../applib/layout/menubars/bootstrap3/BS3Menu.java | 5 - .../layout/menubars/bootstrap3/BS3MenuBars.java | 5 + .../java/org/apache/isis/applib/query/Query.java | 2 +- .../services/appfeat/ApplicationMemberType.java | 15 +- .../isis/applib/services/bookmark/Bookmark.java | 5 +- .../ClassDiscoveryServiceUsingReflections.java | 35 +-- .../isis/applib/services/dto/DtoMappingHelper.java | 6 +- .../services/eventbus/AbstractDomainEvent.java | 15 ++ .../exceprecog/ExceptionRecognizerAbstract.java | 57 ++++- .../exceprecog/ExceptionRecognizerForType.java | 1 + ...rType.java => ExceptionRecognizerForType2.java} | 63 ++--- ...xceptionRecognizerForJDODataStoreException.java | 4 +- ...traintViolationForeignKeyNoActionException.java | 17 +- ...ionRecognizerForJDOObjectNotFoundException.java | 5 +- ...yConstraintViolationUniqueOrIndexException.java | 17 +- .../isis/applib/services/jaxb/JaxbService.java | 10 +- .../queryresultscache/QueryResultsCache.java | 4 +- .../services/repository/RepositoryService.java | 26 +- .../isis/applib/spec/AbstractSpecification2.java | 4 +- .../java/org/apache/isis/applib/util/Enums.java | 40 +-- .../java/org/apache/isis/applib/util/JaxbUtil.java | 4 +- .../apache/isis/applib/util/ObjectContracts.java | 6 +- .../org/apache/isis/applib/util/TitleBuffer.java | 8 +- .../apache/isis/schema/utils/CommonDtoUtils.java | 20 +- .../isis/schema/utils/InteractionDtoUtils.java | 19 +- .../isis/schema/utils/MemberExecutionDtoUtils.java | 4 +- .../isis/applib/internal/base/NullSafeTest.java | 116 +++++++++ .../isis/applib/internal/base/StringsTest.java | 243 ++++++++++++++++++ .../applib/internal/compare/ComparatorsTest.java | 158 ++++++++++++ ...t.java => ExceptionRecognizerForType2Test.java} | 12 +- .../exceprecog/ExceptionRecognizerGeneralTest.java | 32 ++- .../core/commons/exceptions/ExceptionUtils.java | 6 +- .../org/apache/isis/core/commons/lang/Closure.java | 32 --- .../isis/core/commons/lang/IterableExtensions.java | 39 --- .../apache/isis/core/commons/lang/Nullable.java | 49 ---- .../isis/core/commons/lang/ObjectExtensions.java | 4 +- .../isis/core/commons/lang/StringExtensions.java | 70 +----- .../isis/core/commons/lang/StringFunctions.java | 7 +- .../isis/core/commons/lang/StringPredicates.java | 7 +- .../isis/core/commons/reflection/Reflect.java | 167 ------------- .../isis/core/metamodel/adapter/oid/Oid.java | 9 +- .../isis/core/metamodel/facetapi/FacetUtil.java | 10 +- .../core/metamodel/facets/MethodFinderUtils.java | 16 +- ...ctionInvocationFacetForDomainEventAbstract.java | 15 +- .../ActionDefaultsFacetViaMethodFactory.java | 3 +- .../facets/all/i18n/NamedFacetTranslated.java | 2 +- .../DomainObjectAnnotationFacetFactory.java | 9 +- .../AuditableFacetForDomainObjectAnnotation.java | 5 +- .../domainservice/DomainServiceMenuOrder.java | 5 +- .../ignore/javalang/RemoveMethodsFacetFactory.java | 3 +- .../MemberGroupLayoutFacetProperties.java | 25 +- .../recreatable/RecreatableObjectFacetFactory.java | 8 +- .../ActionParameterAutoCompleteFacetViaMethod.java | 3 +- ...rameterChoicesFacetDerivedFromChoicesFacet.java | 3 +- .../method/ActionChoicesFacetViaMethodFactory.java | 3 +- .../ActionParameterChoicesFacetViaMethod.java | 9 +- ...cetInvertedByNullableAnnotationOnParameter.java | 4 +- ...ropertyChoicesFacetDerivedFromChoicesFacet.java | 5 +- .../MemberOrderFacetComparator.java | 4 +- .../exceprecog/ExceptionRecognizerDocDefault.java | 7 +- .../services/grid/GridLoaderServiceDefault.java | 3 +- .../RepositoryServiceInternalDefault.java | 33 ++- .../core/metamodel/spec/feature/ObjectAction.java | 18 +- .../specloader/specimpl/ObjectActionDefault.java | 4 +- .../core/metamodel/util/DeweyOrderComparator.java | 51 +--- .../commons/lang/IterableExtensionsTest_fold.java | 45 ---- .../metamodel/facets/MethodFinderUtilsTest.java | 27 +- .../apache/isis/core/metamodel/facets/Utils.java | 3 +- core/pom.xml | 21 +- .../isis/core/runtime/headless/IsisSystem.java | 2 +- .../core/runtime/services/ServiceInstantiator.java | 6 +- .../services/ServicesInstallerFromAnnotation.java | 36 ++- .../core/runtime/system/context/IsisContext.java | 102 ++++---- .../system/session/IsisSessionFactoryBuilder.java | 8 +- .../IsisComponentProvider.java | 38 ++- .../objectstore/jdo/service/RegisterEntities.java | 39 +-- .../DummyAction.java | 3 +- .../runtime/services/ServiceInstantiatorTest.java | 278 ++++++++++++--------- .../eventbus/EventBusServiceDefaultTest.java | 22 +- .../core/specsupport/specs/CukeGlueAbstract.java | 16 +- core/unittestsupport/pom.xml | 1 + .../wicket/model/models/EntityCollectionModel.java | 44 ++-- .../models/LowestCommonSuperclassClosureTest.java | 33 ++- .../wicket/ui/components/layout/bs3/col/Col.java | 18 +- .../components/layout/bs3/tabs/TabGroupPanel.java | 29 +-- 122 files changed, 2507 insertions(+), 1433 deletions(-) delete mode 100644 core/applib/src/main/java/org/apache/isis/applib/fixturescripts/StringUtil.java copy core/applib/src/main/java/org/apache/isis/applib/{AbstractViewModel.java => internal/_Constants.java} (54%) rename core/applib/src/main/java/org/apache/isis/applib/{util/Casts.java => internal/base/_Casts.java} (72%) rename core/{metamodel/src/main/java/org/apache/isis/core/commons/lang/NullSafe.java => applib/src/main/java/org/apache/isis/applib/internal/base/_NullSafe.java} (64%) create mode 100644 core/applib/src/main/java/org/apache/isis/applib/internal/base/_Strings.java create mode 100644 core/applib/src/main/java/org/apache/isis/applib/internal/base/_Strings_NaturalNames.java create mode 100644 core/applib/src/main/java/org/apache/isis/applib/internal/base/_Strings_SplitIterator.java copy core/{runtime/src/main/java/org/apache/isis/core/runtime/fixtures => applib/src/main/java/org/apache/isis/applib/internal/base}/package-info.java (75%) rename core/applib/src/main/java/org/apache/isis/applib/{util/Streams.java => internal/compare/_Comparators.java} (53%) rename core/{metamodel/src/main/java/org/apache/isis/core/commons/compare/SequenceCompare.java => applib/src/main/java/org/apache/isis/applib/internal/compare/_Comparators_SequenceCompare.java} (62%) copy core/{runtime/src/main/java/org/apache/isis/core/runtime/fixtures => applib/src/main/java/org/apache/isis/applib/internal/compare}/package-info.java (75%) create mode 100644 core/applib/src/main/java/org/apache/isis/applib/internal/context/_Context.java copy core/{runtime/src/main/java/org/apache/isis/core/runtime/fixtures => applib/src/main/java/org/apache/isis/applib/internal/context}/package-info.java (75%) create mode 100644 core/applib/src/main/java/org/apache/isis/applib/internal/exceptions/_Exceptions.java copy core/{runtime/src/main/java/org/apache/isis/core/runtime/fixtures => applib/src/main/java/org/apache/isis/applib/internal/exceptions}/package-info.java (74%) copy core/{runtime/src/main/java/org/apache/isis/core/runtime/fixtures => applib/src/main/java/org/apache/isis/applib/internal}/package-info.java (75%) create mode 100644 core/applib/src/main/java/org/apache/isis/applib/internal/reflection/_Reflect.java create mode 100644 core/applib/src/main/java/org/apache/isis/applib/internal/reflection/_Reflect_Discovery.java create mode 100644 core/applib/src/main/java/org/apache/isis/applib/internal/reflection/_Reflect_Manifest.java copy core/{runtime/src/main/java/org/apache/isis/core/runtime/fixtures => applib/src/main/java/org/apache/isis/applib/internal/reflection}/package-info.java (74%) copy core/applib/src/main/java/org/apache/isis/applib/services/exceprecog/{ExceptionRecognizerForType.java => ExceptionRecognizerForType2.java} (73%) create mode 100644 core/applib/src/test/java/org/apache/isis/applib/internal/base/NullSafeTest.java create mode 100644 core/applib/src/test/java/org/apache/isis/applib/internal/base/StringsTest.java create mode 100644 core/applib/src/test/java/org/apache/isis/applib/internal/compare/ComparatorsTest.java copy core/applib/src/test/java/org/apache/isis/applib/services/exceprecog/{ExceptionRecognizerForTypeTest.java => ExceptionRecognizerForType2Test.java} (84%) delete mode 100644 core/metamodel/src/main/java/org/apache/isis/core/commons/lang/Closure.java delete mode 100644 core/metamodel/src/main/java/org/apache/isis/core/commons/lang/IterableExtensions.java delete mode 100644 core/metamodel/src/main/java/org/apache/isis/core/commons/lang/Nullable.java delete mode 100644 core/metamodel/src/main/java/org/apache/isis/core/commons/reflection/Reflect.java delete mode 100644 core/metamodel/src/test/java/org/apache/isis/core/commons/lang/IterableExtensionsTest_fold.java -- To stop receiving notification emails like this one, please contact danhayw...@apache.org.