svn commit: r1823944 - /jmeter/trunk/test/src/org/apache/jorphan/gui/ObjectTableSorterTest.java

[fschumacher]

Author: fschumacher
Date: Mon Feb 12 11:17:42 2018
New Revision: 1823944

URL: http://svn.apache.org/viewvc?rev=1823944&view=rev
Log:
Extract common code into a private helper.

Preparation to get line length down to 160 chars.
In preparation for #358 on github

Modified:
    jmeter/trunk/test/src/org/apache/jorphan/gui/ObjectTableSorterTest.java

Modified: 
jmeter/trunk/test/src/org/apache/jorphan/gui/ObjectTableSorterTest.java
URL: 
http://svn.apache.org/viewvc/jmeter/trunk/test/src/org/apache/jorphan/gui/ObjectTableSorterTest.java?rev=1823944&r1=1823943&r2=1823944&view=diff
==============================================================================
--- jmeter/trunk/test/src/org/apache/jorphan/gui/ObjectTableSorterTest.java 
(original)
+++ jmeter/trunk/test/src/org/apache/jorphan/gui/ObjectTableSorterTest.java Mon 
Feb 12 11:17:42 2018
@@ -150,34 +150,37 @@ public class ObjectTableSorterTest {
         assertRowOrderAndIndexes(expected);
     }
 
+    private ObjectTableModel createTableModel(final String name,
+            final Class<?> klass) {
+        return new ObjectTableModel(new String[] { name },
+                new Functor[] { null }, new Functor[] { null },
+                new Class<?>[] { klass });
+    }
+
     @Test
     public void getDefaultComparatorForNullClass() {
-        ObjectTableModel model = new ObjectTableModel(new String[] { "null" }, 
new Functor[] { null }, new Functor[] { null }, new Class<?>[] { null });
-        ObjectTableSorter sorter = new ObjectTableSorter(model);
+        ObjectTableSorter sorter = new 
ObjectTableSorter(createTableModel("null", null));
 
         assertThat(sorter.getValueComparator(0), is(nullValue()));
     }
 
     @Test
     public void getDefaultComparatorForStringClass() {
-        ObjectTableModel model = new ObjectTableModel(new String[] { "string" 
}, new Functor[] { null }, new Functor[] { null }, new Class<?>[] { 
String.class });
-        ObjectTableSorter sorter = new ObjectTableSorter(model);
+        ObjectTableSorter sorter = new 
ObjectTableSorter(createTableModel("string", String.class));
 
         assertThat(sorter.getValueComparator(0), 
is(CoreMatchers.notNullValue()));
     }
 
     @Test
     public void getDefaultComparatorForIntegerClass() {
-        ObjectTableModel model = new ObjectTableModel(new String[] { "integer" 
}, new Functor[] { null }, new Functor[] { null }, new Class<?>[] { 
Integer.class });
-        ObjectTableSorter sorter = new ObjectTableSorter(model);
+        ObjectTableSorter sorter = new 
ObjectTableSorter(createTableModel("integer", Integer.class));
 
         assertThat(sorter.getValueComparator(0), 
is(CoreMatchers.notNullValue()));
     }
 
     @Test
     public void getDefaultComparatorForObjectClass() {
-        ObjectTableModel model = new ObjectTableModel(new String[] { "integer" 
}, new Functor[] { null }, new Functor[] { null }, new Class<?>[] { 
Object.class });
-        ObjectTableSorter sorter = new ObjectTableSorter(model);
+        ObjectTableSorter sorter = new 
ObjectTableSorter(createTableModel("integer", Object.class));
 
         assertThat(sorter.getValueComparator(0), is(nullValue()));
     }