Re: [I] [kn-plugin-workflow] Specify gen-manifest dir name [incubator-kie-issues]
treblereel closed issue #1621: [kn-plugin-workflow] Specify gen-manifest dir name URL: https://github.com/apache/incubator-kie-issues/issues/1621 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [I] [kn-plugin-workflow] Specify gen-manifest dir name [incubator-kie-issues]
masayag commented on issue #1621: URL: https://github.com/apache/incubator-kie-issues/issues/1621#issuecomment-3072318871 > Personally, it feels like duplicate functionality (especially when it’s run from a script), but if you need it, let’s implement it We are on the same page with this. I don't think that there is a need to add this at all. All I said is that we can achieve the same functionality by the existing `kn-workflow deploy` command. This is already implemented. there isn't anything to add to it. This is fine on its own: ``` kn workflow deploy --custom-generated-manifests-dir= ``` And if there is a need for custom manifests, then the user will have to run 2 command which is fine by me, e.g.: ``` kn-workflow gen-manifest --profile=gitops --image=quay.io/org/repo:tag --custom-generated-manifests-dir=./manifests ``` followed by the command that referenced the previously folder of the custom generated manifests: ``` kn workflow deploy --custom-manifests-dir=./manifests ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [I] [kn-plugin-workflow] Specify gen-manifest dir name [incubator-kie-issues]
treblereel commented on issue #1621: URL: https://github.com/apache/incubator-kie-issues/issues/1621#issuecomment-3070804882 @masayag ok, did I understand correctly that when running ``` kn workflow deploy --custom-generated-manifests-dir= ``` you want to be able to configure the manifest in the same way as with `gen-manifest` (but only if the `--custom-generated-manifests-dir` option isn’t provided)? Personally, it feels like duplicate functionality (especially when it’s run from a script), but if you need it, let’s implement it -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [I] [kn-plugin-workflow] Specify gen-manifest dir name [incubator-kie-issues]
masayag commented on issue #1621: URL: https://github.com/apache/incubator-kie-issues/issues/1621#issuecomment-3058349064 From my side we only use ``` kn workflow gen-manifest --custom-generated-manifests-dir= ``` after we finished the workflow development and we are looking to test the workflow on a cluster. I don't see a need to include that for create/run commands since it will not provide any value that I can think of. --- When looking at the following command, this is nice to have to persist the manifests to a custom folder ``` kn workflow deploy --custom-generated-manifests-dir= ``` however, the generated manifests will not support all of the options as the ones created with `kn workflow gen-manifest` (that allows specifying the profile. But that can be compensated by: ``` kn workflow deploy --custom-manifests-dir= ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [I] [kn-plugin-workflow] Specify gen-manifest dir name [incubator-kie-issues]
ricardozanini commented on issue #1621: URL: https://github.com/apache/incubator-kie-issues/issues/1621#issuecomment-3057744571 > What’s the point of accepting a gen-manifest path in the kn workflow create command, when you can immediately run kn workflow gen-manifest afterward? It feels like duplicating the same functionality. To me, it seems a shortcut worth adding to the `kn workflow create` command. It can be a boolean flag to whether generate the manifests or not > The kn workflow run command is meant for running Quarkus locally in the current project to speed up development and debugging, there’s no need to supply a gen-manifest directory there. Not quarkus, but the workflow within a container. This I agree, no need to gen manifest while _running_ the app > The kn workflow deploy command already lets you point to a pre-generated manifest via the --custom-manifests-dir option. Again, `kn workflow deploy` should not have the `gen-manifest`. I agree to that. @masayag since you use this tool the most, mind weighing in? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [I] [kn-plugin-workflow] Specify gen-manifest dir name [incubator-kie-issues]
treblereel commented on issue #1621: URL: https://github.com/apache/incubator-kie-issues/issues/1621#issuecomment-3037200870 I’ve revisited the goals of this issue, and a few things strike me as odd: - What’s the point of accepting a `gen-manifest` path in the kn workflow create command, when you can immediately run `kn workflow gen-manifest` afterward? It feels like duplicating the same functionality. - The kn workflow run command is meant for running Quarkus locally in the current project to speed up development and debugging, there’s no need to supply a `gen-manifest` directory there. - The kn workflow deploy command already lets you point to a pre-generated manifest via the `--custom-manifests-dir option`. @yesamer @ricardozanini -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
