Re: [PR] [incubator-kie-issues#2029] Dependency management simplification [incubator-kie-drools]
gitgabrio merged PR #6633: URL: https://github.com/apache/incubator-kie-drools/pull/6633 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [incubator-kie-issues#2029] Dependency management simplification [incubator-kie-drools]
yesamer commented on code in PR #6633:
URL:
https://github.com/apache/incubator-kie-drools/pull/6633#discussion_r3279950930
##
kie-no-dependency-management-enforcer-rule/src/main/java/org/kie/nodependencymanagementrule/NoDependencyManagementRule.java:
##
@@ -0,0 +1,112 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.kie.nodependencymanagementrule;
+
+import java.util.Objects;
+
+import javax.inject.Inject;
+import javax.inject.Named;
+
+import java.util.Set;
+import org.apache.maven.enforcer.rule.api.AbstractEnforcerRule;
+import org.apache.maven.enforcer.rule.api.EnforcerRuleException;
+import org.apache.maven.model.DependencyManagement;
+import org.apache.maven.model.Profile;
+import org.apache.maven.project.MavenProject;
+
+/**
+ * No DependencyManagement Enforcer Rule
+ * This rule is meant to forbid dependencyManagement tag in pom
+ */
+@Named("noDependencyManagementRule")
+public class NoDependencyManagementRule extends AbstractEnforcerRule {
+
+// Inject needed Maven components
+private final MavenProject project;
+
+/**
+ * Set of allowed poms.
+ */
+private Set allowedPoms;
+
+@Inject
+public NoDependencyManagementRule(MavenProject project) {
+this.project = Objects.requireNonNull(project);
+}
+
+public void execute() throws EnforcerRuleException {
+if (!isAllowed(project.getGroupId(), project.getArtifactId())) {
+checkForDependencyManagement();
+}
+}
+
+void checkForDependencyManagement() throws EnforcerRuleException {
+checkDependencyManagementInProject();
+checkDependencyManagementInProfiles();
+}
+
+void checkDependencyManagementInProject() throws EnforcerRuleException {
+if (invalidDependencyManagement(project.getDependencyManagement())) {
// The getLocation("") retrieve the position, in the pom, of that specific
dependencyManagement element; it is null when such an element is inherited
+throw new EnforcerRuleException(String.format("The current pom
%s:%s:%s has dependencyManagement tag!", project.getGroupId(),
project.getArtifactId(), project.getVersion()));
+}
+}
+
+void checkDependencyManagementInProfiles() throws EnforcerRuleException {
+if (project.getModel().getProfiles() != null) {
+for (Profile profile : project.getModel().getProfiles()) {
+checkDependencyManagementInProfile(profile);
+}
+}
+}
+
+void checkDependencyManagementInProfile(Profile profile) throws
EnforcerRuleException {
Review Comment:
Minor: a tab should be removed for better formatting.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
Re: [PR] [incubator-kie-issues#2029] Dependency management simplification [incubator-kie-drools]
yesamer commented on code in PR #6633:
URL:
https://github.com/apache/incubator-kie-drools/pull/6633#discussion_r3279932100
##
kie-no-external-managed-dependency-enforcer-rule/pom.xml:
##
@@ -0,0 +1,150 @@
+
+
+http://maven.apache.org/POM/4.0.0";
+ xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
http://maven.apache.org/xsd/maven-4.0.0.xsd";>
+ 4.0.0
+
+org.kie
+drools-parent
+999-SNAPSHOT
+
+
+ kie-no-external-managed-dependency-enforcer-rule
+ Drools :: No External Managed Dependency Rule
+ Enforcer rule to forbid declaration of dependency management of
artifacts not being part of the current multi-module project.
+
+
+
+17
+17
+UTF-8
+3.6.2
+3.9.11
+1.0.0
+
+
+
+
+
+org.apache.maven.enforcer
+enforcer-api
+${version.enforcer.api}
+provided
+
+
+org.apache.maven
+maven-core
+${version.org.apache.maven}
+provided
+
+
+org.apache.maven
+maven-compat
+${version.org.apache.maven}
+provided
+
+
+javax.inject
+javax.inject
+1
Review Comment:
@gitgabrio This version could be moved in the properties block.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
Re: [PR] [incubator-kie-issues#2029] Dependency management simplification [incubator-kie-drools]
yesamer commented on code in PR #6633:
URL:
https://github.com/apache/incubator-kie-drools/pull/6633#discussion_r3279927817
##
kie-no-external-managed-dependency-enforcer-rule/pom.xml:
##
@@ -0,0 +1,150 @@
+
+
+http://maven.apache.org/POM/4.0.0";
+ xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
http://maven.apache.org/xsd/maven-4.0.0.xsd";>
+ 4.0.0
+
+org.kie
+drools-parent
+999-SNAPSHOT
+
+
+ kie-no-external-managed-dependency-enforcer-rule
+ Drools :: No External Managed Dependency Rule
+ Enforcer rule to forbid declaration of dependency management of
artifacts not being part of the current multi-module project.
+
+
+
+17
+17
+UTF-8
+3.6.2
+3.9.11
+1.0.0
+
+
+
+
+
+org.apache.maven.enforcer
+enforcer-api
+${version.enforcer.api}
+provided
+
+
+org.apache.maven
+maven-core
+${version.org.apache.maven}
+provided
+
+
+org.apache.maven
+maven-compat
+${version.org.apache.maven}
+provided
+
+
+javax.inject
+javax.inject
+1
+provided
+
+
+
+
+
+
+ org.apache.maven.enforcer
+ enforcer-api
+ provided
+
+
+ org.apache.maven
+ maven-core
+ provided
+
+
+ javax.inject
+ javax.inject
+ provided
+
+
+
+
+
+
+
+
+ org.eclipse.sisu
+ sisu-maven-plugin
+ ${version.sisu.maven.plugin}
+
+
+
+
+
+
+org.eclipse.sisu
+sisu-maven-plugin
+
+
+
+ main-index
+
+
+
+
+
+org.apache.maven.plugins
+maven-invoker-plugin
+
+ ${skipITs}
+ ${skipITs}
+
Review Comment:
@gitgabrio This could be removed, I guess (even in a future PR)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
Re: [PR] [incubator-kie-issues#2029] Dependency management simplification [incubator-kie-drools]
Copilot commented on code in PR #6633:
URL:
https://github.com/apache/incubator-kie-drools/pull/6633#discussion_r3239869211
##
kie-no-external-managed-dependency-enforcer-rule/src/main/java/org/kie/noexternalmanageddependencyrule/NoExternalManagedDependencyRule.java:
##
@@ -0,0 +1,211 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.kie.noexternalmanageddependencyrule;
+
+import java.io.File;
+import java.io.PrintWriter;
+import java.io.StringWriter;
+import java.util.HashSet;
+import java.util.Objects;
+
+import javax.inject.Inject;
+import javax.inject.Named;
+
+import java.util.Set;
+import org.apache.maven.enforcer.rule.api.AbstractEnforcerRule;
+import org.apache.maven.enforcer.rule.api.EnforcerRuleException;
+import org.apache.maven.execution.MavenSession;
+import org.apache.maven.model.Dependency;
+import org.apache.maven.model.DependencyManagement;
+import org.apache.maven.model.Profile;
+import org.apache.maven.project.MavenProject;
+import org.apache.maven.project.ProjectBuilder;
+
+/**
+ * No External Managed Dependency Enforcer Rule
+ * This rule is meant to forbid declaration of managed dependencies that are
not part of the current multi-module maven project.
+ */
+@Named("noExternalManagedDependencyRule")
+public class NoExternalManagedDependencyRule extends AbstractEnforcerRule {
+
+// Inject needed Maven components
+private final MavenProject project;
+private final ProjectBuilder projectBuilder;
+private final MavenSession mavenSession;
+
+/**
+ * Comma-separated set of group ids to check for
+ */
+private Set filteredGroupIds;
+
+/**
+ * Comma-separated set of group:artifact that are allowed
+ */
+private Set allowedGA;
+/**
+ * The relative path to the root of the current multimodule project.
+ */
+private String rootPom;
+
+@Inject
+public NoExternalManagedDependencyRule(MavenProject project,
ProjectBuilder projectBuilder, MavenSession mavenSession) {
+this.project = Objects.requireNonNull(project);
+this.projectBuilder = Objects.requireNonNull(projectBuilder);
+this.mavenSession = Objects.requireNonNull(mavenSession);
+}
+
+public void execute() throws EnforcerRuleException {
+if (rootPom == null || rootPom.isEmpty()) {
+throw new EnforcerRuleException("The rootPom parameter is required
and cannot be empty.");
+}
+if (filteredGroupIds == null || filteredGroupIds.isEmpty()) {
+throw new EnforcerRuleException("The filteredGroupIds parameter is
required and cannot be empty.");
+}
+if (project.getOriginalModel().getDependencyManagement() == null &&
(project.getOriginalModel().getProfiles() == null ||
project.getOriginalModel().getProfiles().stream().allMatch(profile ->
profile.getDependencyManagement() == null))) {
+// If there is no dependency management there is no need to check
for managed dependencies
+return;
+}
+checkForManagedDependencies();
+}
+
+private void checkForManagedDependencies() throws EnforcerRuleException {
+MavenProject rootMavenProject = getRootMavenProject();
+Set implementedDependencies =
getImplementedDependencies(rootMavenProject);
+checkForManagedDependenciesInProject(implementedDependencies);
+checkForManagedDependenciesInProfiles(implementedDependencies);
+}
+
+private void checkForManagedDependenciesInProject(Set
implementedDependencies) throws EnforcerRuleException {
+Set invalidManagedDependencies =
invalidManagedDependencies(project.getOriginalModel().getDependencyManagement(),
implementedDependencies);
+if (!invalidManagedDependencies.isEmpty()) {
+String invalidDependencies = String.join(",\r\n",
invalidManagedDependencies);
+throw new EnforcerRuleException(String.format("The current pom
%s:%s:%s has the following invalid managed dependencies:\n" +
+"%s", project.getGroupId(), project.getArtifactId(),
project.getVersion(), invalidDependencies));
+}
+}
+
+private void checkForManagedDependenciesInProfiles(Set
Re: [PR] [incubator-kie-issues#2029] Dependency management simplification [incubator-kie-drools]
gitgabrio commented on code in PR #6633:
URL:
https://github.com/apache/incubator-kie-drools/pull/6633#discussion_r3239702078
##
kie-parent/pom.xml:
##
@@ -0,0 +1,3330 @@
+
+
+http://maven.apache.org/POM/4.0.0";
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
http://maven.apache.org/xsd/maven-4.0.0.xsd";>
+ 4.0.0
+
+org.kie
+drools-parent
+999-SNAPSHOT
+
+ kie-parent
+ pom
+ Kie :: Parent
+
+
+org.kie:kie-parent
+
+
+build_logs
+
+false
+java
+.*
+true
+
false
+
+
+
+
none
+true
+true
+
+initialize
+false
+
+
+${project.root.dir}/target/jacoco.exec
+
+false
+0.9
+
+
+
notYetReleased
+MMddHHmm
+17
+17
+UTF-8
+
+${maven.multiModuleProjectDirectory}
+
+
+
+../pom.xml
+
+false
+1
+
+
+2.0.5
+2.7.7
+1.8.2
+
1.28.0
+1.4.0
+
+4.0.2
+0.9.1
+
2.0.0-RC.1
+1.10.1
+4.2.0
+
3.4.0
+2.0.1
+1.5.25
+2.21.1
+
2.21
+
2.21.1
+
2.21.1
+1.15.1
+
1.5.2
+3.27.0
+
+
4.9.8.3
+1.0-1
+4.37.0
+1.0
+2.13.2
+33.4.8-jre
+3.25.5
+
+24.3
+
24.0
+2.3.232
+2.3.232
+2.9.0
+
+3.7.4
+1.0.86
+
1.0.86
+3.2
+4.12.0
+2.0.2
+4.0.5
+4.0.5
+1.4.21
+1.14.0
+1.28.0
+1.3
+1.19.0
+3.2.2
+2.20.0
+1.1.1
+3.13.0
+1.0
+3.6.1
+1.0.1
+
+2.0.0
+1.3
+1.3.4
+1.5.0
+1.0
+22.0.0.2
+8.11.1
+0.18.0
+
1.7.4
+4.7.7
+3.0.0
+7.3.1
+
7.3.1
+1.76.0
+1.14.12
+4.1.132.Final
+1.0.0-alpha
+5.5.6
+3.13.4
+4.2.0
+4.0.12
+3.13.4
+3.4.0
+2.9.5
+4.0.12
+
4.28.0
+
3.21.3
+
+
1.1.1
+2.2.38
+2.1.34
+4.5.25
+8.5.11
+0.8.11
+2.0.3
+2.1.4
+3.0.0
+
4.1.0
+2.0.1
+1.1.7
+2.1.3
+3.0.1
+3.2.0
+2.0.1
+3.1.1
+3.1.0
+4.0.4
+1
+2.2
+
+2.0
+
+${maven.compiler.release}
+4.13.2
+1.0.0
+${version.org.apache.maven}
+3.9.11
Review Comment:
😊
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
Re: [PR] [incubator-kie-issues#2029] Dependency management simplification [incubator-kie-drools]
gitgabrio commented on code in PR #6633: URL: https://github.com/apache/incubator-kie-drools/pull/6633#discussion_r3239578217 ## kie-parent/pom.xml: ## @@ -0,0 +1,3330 @@ + + +http://maven.apache.org/POM/4.0.0"; xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd";> + 4.0.0 + +org.kie +drools-parent +999-SNAPSHOT + + kie-parent + pom + Kie :: Parent + + +org.kie:kie-parent + + +build_logs + +false +java +.* +true + false Review Comment: 😊 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [incubator-kie-issues#2029] Dependency management simplification [incubator-kie-drools]
tkobayas commented on PR #6633: URL: https://github.com/apache/incubator-kie-drools/pull/6633#issuecomment-4447234123 Thank you very much for the effort, @gitgabrio . One minor point, it's better to have test cases for the custom enforcer rules? Not opinionated. I leave the decision to you. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [incubator-kie-issues#2029] Dependency management simplification [incubator-kie-drools]
tkobayas commented on code in PR #6633:
URL:
https://github.com/apache/incubator-kie-drools/pull/6633#discussion_r3238909516
##
kie-parent/pom.xml:
##
@@ -0,0 +1,3330 @@
+
+
+http://maven.apache.org/POM/4.0.0";
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
http://maven.apache.org/xsd/maven-4.0.0.xsd";>
+ 4.0.0
+
+org.kie
+drools-parent
+999-SNAPSHOT
+
+ kie-parent
+ pom
+ Kie :: Parent
+
+
+org.kie:kie-parent
+
+
+build_logs
+
+false
+java
+.*
+true
+
false
+
+
+
+
none
+true
+true
+
+initialize
+false
+
+
+${project.root.dir}/target/jacoco.exec
+
+false
+0.9
+
+
+
notYetReleased
+MMddHHmm
+17
+17
+UTF-8
+
+${maven.multiModuleProjectDirectory}
+
+
+
+../pom.xml
+
+false
+1
+
+
+2.0.5
+2.7.7
+1.8.2
+
1.28.0
+1.4.0
+
+4.0.2
+0.9.1
+
2.0.0-RC.1
+1.10.1
+4.2.0
+
3.4.0
+2.0.1
+1.5.25
+2.21.1
+
2.21
+
2.21.1
+
2.21.1
+1.15.1
+
1.5.2
+3.27.0
+
+
4.9.8.3
+1.0-1
+4.37.0
+1.0
+2.13.2
+33.4.8-jre
+3.25.5
+
+24.3
+
24.0
+2.3.232
+2.3.232
+2.9.0
+
+3.7.4
+1.0.86
+
1.0.86
+3.2
+4.12.0
+2.0.2
+4.0.5
+4.0.5
+1.4.21
+1.14.0
+1.28.0
+1.3
+1.19.0
+3.2.2
+2.20.0
+1.1.1
+3.13.0
+1.0
+3.6.1
+1.0.1
+
+2.0.0
+1.3
+1.3.4
+1.5.0
+1.0
+22.0.0.2
+8.11.1
+0.18.0
+
1.7.4
+4.7.7
+3.0.0
+7.3.1
+
7.3.1
+1.76.0
+1.14.12
+4.1.132.Final
+1.0.0-alpha
+5.5.6
+3.13.4
+4.2.0
+4.0.12
+3.13.4
+3.4.0
+2.9.5
+4.0.12
+
4.28.0
+
3.21.3
+
+
1.1.1
+2.2.38
+2.1.34
+4.5.25
+8.5.11
+0.8.11
+2.0.3
+2.1.4
+3.0.0
+
4.1.0
+2.0.1
+1.1.7
+2.1.3
+3.0.1
+3.2.0
+2.0.1
+3.1.1
+3.1.0
+4.0.4
+1
+2.2
+
+2.0
+
+${maven.compiler.release}
+4.13.2
+1.0.0
+${version.org.apache.maven}
+3.9.11
Review Comment:
duplication :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
Re: [PR] [incubator-kie-issues#2029] Dependency management simplification [incubator-kie-drools]
tkobayas commented on code in PR #6633: URL: https://github.com/apache/incubator-kie-drools/pull/6633#discussion_r3238904712 ## kie-parent/pom.xml: ## @@ -0,0 +1,3330 @@ + + +http://maven.apache.org/POM/4.0.0"; xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd";> + 4.0.0 + +org.kie +drools-parent +999-SNAPSHOT + + kie-parent + pom + Kie :: Parent + + +org.kie:kie-parent + + +build_logs + +false +java +.* +true + false Review Comment: duplication :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [incubator-kie-issues#2029] Dependency management simplification [incubator-kie-drools]
gitgabrio commented on code in PR #6633:
URL:
https://github.com/apache/incubator-kie-drools/pull/6633#discussion_r3233661787
##
drools-test-coverage/drools-test-coverage-jars/drools-test-coverage-jars-with-invoker/pom.xml:
##
@@ -69,6 +60,7 @@
maven-invoker-plugin
${project.build.directory}/it
+ ${path.to.buildlog.directory}
Review Comment:
ACtually, it is related to that error ->
> **[ERROR] Failed to execute goal
org.apache.maven.plugins:maven-clean-plugin:3.3.2:clean (default-clean) on
project drools-test-coverage-jars-with-invoker: Failed to clean project: Failed
to delete
D:\a\incubator-kie-drools\incubator-kie-drools\apache_incubator-kie-drools\drools-test-coverage\drools-test-coverage-jars\drools-test-coverage-jars-with-invoker\target\it\only-jar-pojo-not-kjar-no-kmodule\build.log
-> [Help 1]**
so I reintroduced it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
Re: [PR] [incubator-kie-issues#2029] Dependency management simplification [incubator-kie-drools]
gitgabrio commented on code in PR #6633:
URL:
https://github.com/apache/incubator-kie-drools/pull/6633#discussion_r3233160512
##
kie-maven-plugin/src/it/kie-maven-plugin-test-kjar-3/src/test/java-filtered/org/kie/maven/plugin/ittests/AdditionalPropertiesIntegrationTestIT.java:
##
@@ -29,13 +29,15 @@
public class AdditionalPropertiesIntegrationTestIT {
+private final String buildLogsDir = "${buildlog.directory}";
@Test
public void testAdditionalPropertiesCorrectlySet() throws Exception {
// additional properties are logged during debug (-X) build
// following string is created directly inside the KIE Maven plugin
execution (the property names and values
// are logged multiple by maven itself as well, so we should check
directly against that string)
final URL targetLocation =
AdditionalPropertiesIntegrationTestIT.class.getProtectionDomain().getCodeSource().getLocation();
-final File basedir = new
File(targetLocation.getFile().replace("/target/test-classes/", ""));
+System.out.println("buildLogsDir: " + buildLogsDir);
Review Comment:
nope 😄
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
Re: [PR] [incubator-kie-issues#2029] Dependency management simplification [incubator-kie-drools]
gitgabrio commented on code in PR #6633:
URL:
https://github.com/apache/incubator-kie-drools/pull/6633#discussion_r3233152652
##
drools-test-coverage/drools-test-coverage-jars/drools-test-coverage-jars-with-invoker/pom.xml:
##
@@ -69,6 +60,7 @@
maven-invoker-plugin
${project.build.directory}/it
+ ${path.to.buildlog.directory}
Review Comment:
yup
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
Re: [PR] [incubator-kie-issues#2029] Dependency management simplification [incubator-kie-drools]
gitgabrio commented on code in PR #6633:
URL:
https://github.com/apache/incubator-kie-drools/pull/6633#discussion_r3233135976
##
.github/workflows/pr-downstream.yml:
##
@@ -68,6 +68,7 @@ jobs:
name: ${{ matrix.job_name }} (${{ matrix.os }} / Java-${{
matrix.java-version }} / Maven-${{ matrix.maven-version }})
env:
DEPENDENCY_TREE_FILE: 'mvn_dependency_tree_${{ matrix.job_name }}_${{
matrix.os }}.txt'
+ BUILD_LOGS_DIR: 'build_logs'
Review Comment:
Sorry, leftover...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
Re: [PR] [incubator-kie-issues#2029] Dependency management simplification [incubator-kie-drools]
yesamer commented on code in PR #6633:
URL:
https://github.com/apache/incubator-kie-drools/pull/6633#discussion_r3233008458
##
drools-test-coverage/drools-test-coverage-jars/drools-test-coverage-jars-with-invoker/pom.xml:
##
@@ -69,6 +60,7 @@
maven-invoker-plugin
${project.build.directory}/it
+ ${path.to.buildlog.directory}
Review Comment:
@gitgabrio I guess it is related to the first comment ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
Re: [PR] [incubator-kie-issues#2029] Dependency management simplification [incubator-kie-drools]
yesamer commented on code in PR #6633:
URL:
https://github.com/apache/incubator-kie-drools/pull/6633#discussion_r3232992645
##
bom/drools-bom/pom.xml:
##
@@ -1045,11 +1045,12 @@
default-kiesession
${project.version}
-
+
+
Review Comment:
@gitgabrio Can we remove that?
##
drools-test-coverage/drools-test-coverage-jars/drools-test-coverage-jars-with-invoker/pom.xml:
##
@@ -69,6 +60,7 @@
maven-invoker-plugin
${project.build.directory}/it
+ ${path.to.buildlog.directory}
Review Comment:
@gitgabrio Same, I guess it is related?
##
kie-maven-plugin/src/it/kie-maven-plugin-test-kjar-3/src/test/java-filtered/org/kie/maven/plugin/ittests/AdditionalPropertiesIntegrationTestIT.java:
##
@@ -29,13 +29,15 @@
public class AdditionalPropertiesIntegrationTestIT {
+private final String buildLogsDir = "${buildlog.directory}";
@Test
public void testAdditionalPropertiesCorrectlySet() throws Exception {
// additional properties are logged during debug (-X) build
// following string is created directly inside the KIE Maven plugin
execution (the property names and values
// are logged multiple by maven itself as well, so we should check
directly against that string)
final URL targetLocation =
AdditionalPropertiesIntegrationTestIT.class.getProtectionDomain().getCodeSource().getLocation();
-final File basedir = new
File(targetLocation.getFile().replace("/target/test-classes/", ""));
+System.out.println("buildLogsDir: " + buildLogsDir);
Review Comment:
@gitgabrio Is this System.out.println still needed?
##
.github/workflows/pr-downstream.yml:
##
@@ -68,6 +68,7 @@ jobs:
name: ${{ matrix.job_name }} (${{ matrix.os }} / Java-${{
matrix.java-version }} / Maven-${{ matrix.maven-version }})
env:
DEPENDENCY_TREE_FILE: 'mvn_dependency_tree_${{ matrix.job_name }}_${{
matrix.os }}.txt'
+ BUILD_LOGS_DIR: 'build_logs'
Review Comment:
@gitgabrio Why this change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
