Make synchronized variables final
Project: http://git-wip-us.apache.org/repos/asf/logging-chainsaw/repo Commit: http://git-wip-us.apache.org/repos/asf/logging-chainsaw/commit/ba10849c Tree: http://git-wip-us.apache.org/repos/asf/logging-chainsaw/tree/ba10849c Diff: http://git-wip-us.apache.org/repos/asf/logging-chainsaw/diff/ba10849c Branch: refs/heads/master Commit: ba10849ccce6898b49ddff4b7726973dbc2645dc Parents: 3250bb1 Author: Matt Sicker <boa...@gmail.com> Authored: Tue Mar 13 01:24:51 2018 -0500 Committer: Matt Sicker <boa...@gmail.com> Committed: Tue Mar 13 01:24:51 2018 -0500 ---------------------------------------------------------------------- .../java/org/apache/log4j/chainsaw/LogPanelPreferenceModel.java | 2 +- src/main/java/org/apache/log4j/chainsaw/LogUI.java | 2 +- .../java/org/apache/log4j/chainsaw/layout/EventDetailLayout.java | 2 +- .../java/org/apache/log4j/chainsaw/prefs/LoadSettingsEvent.java | 2 +- .../org/apache/log4j/chainsaw/vfs/VFSLogFilePatternReceiver.java | 2 +- .../java/org/apache/log4j/chainsaw/zeroconf/ZeroConfPlugin.java | 2 +- src/main/java/org/apache/log4j/net/MulticastReceiver.java | 2 +- src/main/java/org/apache/log4j/net/SocketHubReceiver.java | 2 +- src/main/java/org/apache/log4j/net/SocketNode13.java | 2 +- src/main/java/org/apache/log4j/net/SocketReceiver.java | 2 +- src/main/java/org/apache/log4j/net/UDPReceiver.java | 2 +- 11 files changed, 11 insertions(+), 11 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/logging-chainsaw/blob/ba10849c/src/main/java/org/apache/log4j/chainsaw/LogPanelPreferenceModel.java ---------------------------------------------------------------------- diff --git a/src/main/java/org/apache/log4j/chainsaw/LogPanelPreferenceModel.java b/src/main/java/org/apache/log4j/chainsaw/LogPanelPreferenceModel.java index 74f9702..360820c 100644 --- a/src/main/java/org/apache/log4j/chainsaw/LogPanelPreferenceModel.java +++ b/src/main/java/org/apache/log4j/chainsaw/LogPanelPreferenceModel.java @@ -51,7 +51,7 @@ public class LogPanelPreferenceModel implements Serializable{ Properties properties = SettingsManager.getInstance().getDefaultSettings(); for (Map.Entry<Object, Object> objectObjectEntry : properties.entrySet()) { - Map.Entry entry = (Map.Entry) objectObjectEntry; + Map.Entry entry = objectObjectEntry; if (entry.getKey().toString().startsWith("DateFormat")) { list.add(entry.getValue()); http://git-wip-us.apache.org/repos/asf/logging-chainsaw/blob/ba10849c/src/main/java/org/apache/log4j/chainsaw/LogUI.java ---------------------------------------------------------------------- diff --git a/src/main/java/org/apache/log4j/chainsaw/LogUI.java b/src/main/java/org/apache/log4j/chainsaw/LogUI.java index 7454f89..cbaee9a 100644 --- a/src/main/java/org/apache/log4j/chainsaw/LogUI.java +++ b/src/main/java/org/apache/log4j/chainsaw/LogUI.java @@ -178,7 +178,7 @@ public class LogUI extends JFrame implements ChainsawViewer, SettingsListener { * until notified. */ private boolean isGUIFullyInitialized = false; - private Object initializationLock = new Object(); + private final Object initializationLock = new Object(); /** * The shutdownAction is called when the user requests to exit Chainsaw, and http://git-wip-us.apache.org/repos/asf/logging-chainsaw/blob/ba10849c/src/main/java/org/apache/log4j/chainsaw/layout/EventDetailLayout.java ---------------------------------------------------------------------- diff --git a/src/main/java/org/apache/log4j/chainsaw/layout/EventDetailLayout.java b/src/main/java/org/apache/log4j/chainsaw/layout/EventDetailLayout.java index 87c5945..a1801ff 100644 --- a/src/main/java/org/apache/log4j/chainsaw/layout/EventDetailLayout.java +++ b/src/main/java/org/apache/log4j/chainsaw/layout/EventDetailLayout.java @@ -38,7 +38,7 @@ import org.apache.log4j.spi.LoggingEvent; * @author Paul Smith <psm...@apache.org> */ public class EventDetailLayout extends Layout { - private EnhancedPatternLayout patternLayout = new EnhancedPatternLayout(); + private final EnhancedPatternLayout patternLayout = new EnhancedPatternLayout(); public EventDetailLayout() { } http://git-wip-us.apache.org/repos/asf/logging-chainsaw/blob/ba10849c/src/main/java/org/apache/log4j/chainsaw/prefs/LoadSettingsEvent.java ---------------------------------------------------------------------- diff --git a/src/main/java/org/apache/log4j/chainsaw/prefs/LoadSettingsEvent.java b/src/main/java/org/apache/log4j/chainsaw/prefs/LoadSettingsEvent.java index 19df785..d0b8f0b 100644 --- a/src/main/java/org/apache/log4j/chainsaw/prefs/LoadSettingsEvent.java +++ b/src/main/java/org/apache/log4j/chainsaw/prefs/LoadSettingsEvent.java @@ -66,7 +66,7 @@ public class LoadSettingsEvent extends SettingsEvent { Collection c = new ArrayList(); for (Map.Entry<Object, Object> objectObjectEntry : properties.entrySet()) { - Map.Entry entry = (Map.Entry) objectObjectEntry; + Map.Entry entry = objectObjectEntry; if (entry.getKey().toString().startsWith(string)) { c.add(entry.getValue()); } http://git-wip-us.apache.org/repos/asf/logging-chainsaw/blob/ba10849c/src/main/java/org/apache/log4j/chainsaw/vfs/VFSLogFilePatternReceiver.java ---------------------------------------------------------------------- diff --git a/src/main/java/org/apache/log4j/chainsaw/vfs/VFSLogFilePatternReceiver.java b/src/main/java/org/apache/log4j/chainsaw/vfs/VFSLogFilePatternReceiver.java index 8b4470d..4a733ef 100644 --- a/src/main/java/org/apache/log4j/chainsaw/vfs/VFSLogFilePatternReceiver.java +++ b/src/main/java/org/apache/log4j/chainsaw/vfs/VFSLogFilePatternReceiver.java @@ -167,7 +167,7 @@ public class VFSLogFilePatternReceiver extends LogFilePatternReceiver implements private boolean promptForUserInfo = false; private Container container; - private Object waitForContainerLock = new Object(); + private final Object waitForContainerLock = new Object(); private boolean autoReconnect; private VFSReader vfsReader; http://git-wip-us.apache.org/repos/asf/logging-chainsaw/blob/ba10849c/src/main/java/org/apache/log4j/chainsaw/zeroconf/ZeroConfPlugin.java ---------------------------------------------------------------------- diff --git a/src/main/java/org/apache/log4j/chainsaw/zeroconf/ZeroConfPlugin.java b/src/main/java/org/apache/log4j/chainsaw/zeroconf/ZeroConfPlugin.java index 89c16a5..93b69f9 100644 --- a/src/main/java/org/apache/log4j/chainsaw/zeroconf/ZeroConfPlugin.java +++ b/src/main/java/org/apache/log4j/chainsaw/zeroconf/ZeroConfPlugin.java @@ -88,7 +88,7 @@ public class ZeroConfPlugin extends GUIPluginSkeleton { private ZeroConfPreferenceModel preferenceModel; - private Map serviceInfoToReceiveMap = new HashMap(); + private final Map serviceInfoToReceiveMap = new HashMap(); private JMenu connectToMenu = new JMenu("Connect to"); private JMenuItem helpItem = new JMenuItem(new AbstractAction("Learn more about ZeroConf...", http://git-wip-us.apache.org/repos/asf/logging-chainsaw/blob/ba10849c/src/main/java/org/apache/log4j/net/MulticastReceiver.java ---------------------------------------------------------------------- diff --git a/src/main/java/org/apache/log4j/net/MulticastReceiver.java b/src/main/java/org/apache/log4j/net/MulticastReceiver.java index 5e4f283..f0a542f 100644 --- a/src/main/java/org/apache/log4j/net/MulticastReceiver.java +++ b/src/main/java/org/apache/log4j/net/MulticastReceiver.java @@ -174,7 +174,7 @@ public class MulticastReceiver extends Receiver implements PortBased, } class MulticastHandlerThread extends Thread { - private List list = new ArrayList(); + private final List list = new ArrayList(); public MulticastHandlerThread() { setDaemon(true); http://git-wip-us.apache.org/repos/asf/logging-chainsaw/blob/ba10849c/src/main/java/org/apache/log4j/net/SocketHubReceiver.java ---------------------------------------------------------------------- diff --git a/src/main/java/org/apache/log4j/net/SocketHubReceiver.java b/src/main/java/org/apache/log4j/net/SocketHubReceiver.java index 73f88e5..5bef1e1 100644 --- a/src/main/java/org/apache/log4j/net/SocketHubReceiver.java +++ b/src/main/java/org/apache/log4j/net/SocketHubReceiver.java @@ -85,7 +85,7 @@ extends Receiver implements SocketNodeEventListener, PortBased { /** * Listener list. */ - private List listenerList = Collections.synchronizedList(new ArrayList()); + private final List listenerList = Collections.synchronizedList(new ArrayList()); private boolean advertiseViaMulticastDNS; private ZeroConfSupport zeroConf; http://git-wip-us.apache.org/repos/asf/logging-chainsaw/blob/ba10849c/src/main/java/org/apache/log4j/net/SocketNode13.java ---------------------------------------------------------------------- diff --git a/src/main/java/org/apache/log4j/net/SocketNode13.java b/src/main/java/org/apache/log4j/net/SocketNode13.java index fb7a585..1d5d77c 100644 --- a/src/main/java/org/apache/log4j/net/SocketNode13.java +++ b/src/main/java/org/apache/log4j/net/SocketNode13.java @@ -74,7 +74,7 @@ public class SocketNode13 extends ComponentBase implements Runnable, Pauseable { /** * List of listeners. */ - private List listenerList = Collections.synchronizedList(new ArrayList()); + private final List listenerList = Collections.synchronizedList(new ArrayList()); http://git-wip-us.apache.org/repos/asf/logging-chainsaw/blob/ba10849c/src/main/java/org/apache/log4j/net/SocketReceiver.java ---------------------------------------------------------------------- diff --git a/src/main/java/org/apache/log4j/net/SocketReceiver.java b/src/main/java/org/apache/log4j/net/SocketReceiver.java index 6c482f0..821935f 100644 --- a/src/main/java/org/apache/log4j/net/SocketReceiver.java +++ b/src/main/java/org/apache/log4j/net/SocketReceiver.java @@ -87,7 +87,7 @@ public class SocketReceiver extends Receiver implements Runnable, PortBased, /** * Listeners. */ - private List listenerList = Collections.synchronizedList(new ArrayList()); + private final List listenerList = Collections.synchronizedList(new ArrayList()); private boolean advertiseViaMulticastDNS; private ZeroConfSupport zeroConf; http://git-wip-us.apache.org/repos/asf/logging-chainsaw/blob/ba10849c/src/main/java/org/apache/log4j/net/UDPReceiver.java ---------------------------------------------------------------------- diff --git a/src/main/java/org/apache/log4j/net/UDPReceiver.java b/src/main/java/org/apache/log4j/net/UDPReceiver.java index bc927ab..562d495 100644 --- a/src/main/java/org/apache/log4j/net/UDPReceiver.java +++ b/src/main/java/org/apache/log4j/net/UDPReceiver.java @@ -171,7 +171,7 @@ public class UDPReceiver extends Receiver implements PortBased, Pauseable { } class UDPHandlerThread extends Thread { - private List list = new ArrayList(); + private final List list = new ArrayList(); public UDPHandlerThread() { setDaemon(true);
