Repository: logging-log4j2 Updated Branches: refs/heads/master 92b26b41f -> d5c79c707
LOG4J2-1590 added unit test Project: http://git-wip-us.apache.org/repos/asf/logging-log4j2/repo Commit: http://git-wip-us.apache.org/repos/asf/logging-log4j2/commit/d5c79c70 Tree: http://git-wip-us.apache.org/repos/asf/logging-log4j2/tree/d5c79c70 Diff: http://git-wip-us.apache.org/repos/asf/logging-log4j2/diff/d5c79c70 Branch: refs/heads/master Commit: d5c79c70784a1fc40248ef6a7cdf829868e93444 Parents: 92b26b4 Author: rpopma <rpo...@apache.org> Authored: Sun Sep 18 17:28:47 2016 +0900 Committer: rpopma <rpo...@apache.org> Committed: Sun Sep 18 17:28:47 2016 +0900 ---------------------------------------------------------------------- .../log4j/core/filter/AbstractFilterTest.java | 88 ++++++++++++++++++++ 1 file changed, 88 insertions(+) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/logging-log4j2/blob/d5c79c70/log4j-core/src/test/java/org/apache/logging/log4j/core/filter/AbstractFilterTest.java ---------------------------------------------------------------------- diff --git a/log4j-core/src/test/java/org/apache/logging/log4j/core/filter/AbstractFilterTest.java b/log4j-core/src/test/java/org/apache/logging/log4j/core/filter/AbstractFilterTest.java new file mode 100644 index 0000000..e23a7a6 --- /dev/null +++ b/log4j-core/src/test/java/org/apache/logging/log4j/core/filter/AbstractFilterTest.java @@ -0,0 +1,88 @@ +package org.apache.logging.log4j.core.filter; +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache license, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the license for the specific language governing permissions and + * limitations under the license. + */ + +import org.apache.logging.log4j.Level; +import org.apache.logging.log4j.Marker; +import org.apache.logging.log4j.core.Filter; +import org.apache.logging.log4j.core.LogEvent; +import org.apache.logging.log4j.core.Logger; +import org.apache.logging.log4j.message.Message; +import org.junit.Test; + +import static org.junit.Assert.*; + +/** + * Tests the AbstractFilter test. + */ +public class AbstractFilterTest { + + @Test + public void testUnrolledBackwardsCompatible() { + ConcreteFilter filter = new ConcreteFilter(); + Filter.Result expected = Filter.Result.DENY; + verify(filter, Filter.Result.DENY); + + filter.testResult = Filter.Result.ACCEPT; + verify(filter, Filter.Result.ACCEPT); + } + + private void verify(final ConcreteFilter filter, final Filter.Result expected) { + Logger logger = null; + Level level = null; + Marker marker = null; + assertEquals(expected, filter.filter(logger, level, marker, "", 1)); + assertEquals(expected, filter.filter(logger, level, marker, "", 1, 2)); + assertEquals(expected, filter.filter(logger, level, marker, "", 1, 2, 3)); + assertEquals(expected, filter.filter(logger, level, marker, "", 1, 2, 3, 4)); + assertEquals(expected, filter.filter(logger, level, marker, "", 1, 2, 3, 4, 5)); + assertEquals(expected, filter.filter(logger, level, marker, "", 1, 2, 3, 4, 5, 6)); + assertEquals(expected, filter.filter(logger, level, marker, "", 1, 2, 3, 4, 5, 6, 7)); + assertEquals(expected, filter.filter(logger, level, marker, "", 1, 2, 3, 4, 5, 6, 7, 8)); + assertEquals(expected, filter.filter(logger, level, marker, "", 1, 2, 3, 4, 5, 6, 7, 8, 9)); + assertEquals(expected, filter.filter(logger, level, marker, "", 1, 2, 3, 4, 5, 6, 7, 8, 9, 10)); + } + + /** + * Concreted filter class that does not override the methods with unrolled varargs. + */ + static class ConcreteFilter extends AbstractFilter { + Result testResult = Result.DENY; + @Override + public Result filter(final LogEvent event) { + return testResult; + } + + @Override + public Result filter(final Logger logger, final Level level, final Marker marker, final Message msg, + final Throwable t) { + return testResult; + } + + @Override + public Result filter(final Logger logger, final Level level, final Marker marker, final Object msg, + final Throwable t) { + return testResult; + } + + @Override + public Result filter(final Logger logger, final Level level, final Marker marker, final String msg, + final Object... params) { + return testResult; + } + } +} \ No newline at end of file
