[46/50] [abbrv] maven git commit: Reduce number of global checkstyle rule violations

2018-02-17 Thread khmarbaise
http://git-wip-us.apache.org/repos/asf/maven/blob/d9250817/maven-core/src/main/java/org/apache/maven/artifact/repository/MavenArtifactRepository.java
--
diff --git 
a/maven-core/src/main/java/org/apache/maven/artifact/repository/MavenArtifactRepository.java
 
b/maven-core/src/main/java/org/apache/maven/artifact/repository/MavenArtifactRepository.java
index 9765c73..d4c64f0 100644
--- 
a/maven-core/src/main/java/org/apache/maven/artifact/repository/MavenArtifactRepository.java
+++ 
b/maven-core/src/main/java/org/apache/maven/artifact/repository/MavenArtifactRepository.java
@@ -28,6 +28,10 @@ import org.apache.maven.artifact.metadata.ArtifactMetadata;
 import org.apache.maven.artifact.repository.layout.ArtifactRepositoryLayout;
 import org.apache.maven.repository.Proxy;
 
+/**
+ * Abstraction of an artifact repository. Artifact repositories can be remote, 
local, or even build reactor or
+ * IDE workspace.
+ */
 //TODO completely separate local and remote artifact repositories
 public class MavenArtifactRepository
 implements ArtifactRepository

http://git-wip-us.apache.org/repos/asf/maven/blob/d9250817/maven-core/src/main/java/org/apache/maven/artifact/repository/metadata/RepositoryMetadataManager.java
--
diff --git 
a/maven-core/src/main/java/org/apache/maven/artifact/repository/metadata/RepositoryMetadataManager.java
 
b/maven-core/src/main/java/org/apache/maven/artifact/repository/metadata/RepositoryMetadataManager.java
index 35626e5..0caeeb5 100644
--- 
a/maven-core/src/main/java/org/apache/maven/artifact/repository/metadata/RepositoryMetadataManager.java
+++ 
b/maven-core/src/main/java/org/apache/maven/artifact/repository/metadata/RepositoryMetadataManager.java
@@ -25,6 +25,9 @@ import org.apache.maven.artifact.metadata.ArtifactMetadata;
 import org.apache.maven.artifact.repository.ArtifactRepository;
 import org.apache.maven.artifact.repository.RepositoryRequest;
 
+/**
+ * RepositoryMetadataManager
+ */
 public interface RepositoryMetadataManager
 {
 

http://git-wip-us.apache.org/repos/asf/maven/blob/d9250817/maven-core/src/main/java/org/apache/maven/artifact/resolver/ResolutionNode.java
--
diff --git 
a/maven-core/src/main/java/org/apache/maven/artifact/resolver/ResolutionNode.java
 
b/maven-core/src/main/java/org/apache/maven/artifact/resolver/ResolutionNode.java
index cd824c4..a156871 100644
--- 
a/maven-core/src/main/java/org/apache/maven/artifact/resolver/ResolutionNode.java
+++ 
b/maven-core/src/main/java/org/apache/maven/artifact/resolver/ResolutionNode.java
@@ -32,6 +32,9 @@ import 
org.apache.maven.artifact.resolver.filter.ArtifactFilter;
 import org.apache.maven.artifact.versioning.ArtifactVersion;
 import org.apache.maven.artifact.versioning.OverConstrainedVersionException;
 
+/**
+ * ResolutionNode
+ */
 public class ResolutionNode
 {
 private Artifact artifact;

http://git-wip-us.apache.org/repos/asf/maven/blob/d9250817/maven-core/src/main/java/org/apache/maven/bridge/MavenRepositorySystem.java
--
diff --git 
a/maven-core/src/main/java/org/apache/maven/bridge/MavenRepositorySystem.java 
b/maven-core/src/main/java/org/apache/maven/bridge/MavenRepositorySystem.java
index 9331710..84ad93c 100644
--- 
a/maven-core/src/main/java/org/apache/maven/bridge/MavenRepositorySystem.java
+++ 
b/maven-core/src/main/java/org/apache/maven/bridge/MavenRepositorySystem.java
@@ -76,13 +76,13 @@ public class MavenRepositorySystem
 // DefaultProjectBuilder
 public Artifact createArtifact( String groupId, String artifactId, String 
version, String scope, String type )
 {
-return XcreateArtifact( groupId, artifactId, version, scope, type );
+return createArtifactX( groupId, artifactId, version, scope, type );
 }
 
 // DefaultProjectBuilder
 public Artifact createProjectArtifact( String groupId, String artifactId, 
String metaVersionId )
 {
-return XcreateProjectArtifact( groupId, artifactId, metaVersionId );
+return createProjectArtifactX( groupId, artifactId, metaVersionId );
 }
 
 // DefaultProjectBuilder
@@ -104,7 +104,7 @@ public class MavenRepositorySystem
 }
 
 Artifact artifact =
-XcreateDependencyArtifact( d.getGroupId(), d.getArtifactId(), 
versionRange, d.getType(),
+createDependencyArtifactX( d.getGroupId(), d.getArtifactId(), 
versionRange, d.getType(),
   d.getClassifier(), 
d.getScope(), d.isOptional() );
 
 if ( Artifact.SCOPE_SYSTEM.equals( d.getScope() ) && d.getSystemPath() 
!= null )
@@ -140,13 +140,13 @@ public class MavenRepositorySystem
 return null;
 }
 
-return XcreateExtensionArtifact( groupId, artifactId, 

[46/50] [abbrv] maven git commit: Reduce number of global checkstyle rule violations

2018-02-17 Thread khmarbaise
http://git-wip-us.apache.org/repos/asf/maven/blob/d9250817/maven-core/src/main/java/org/apache/maven/artifact/repository/MavenArtifactRepository.java
--
diff --git 
a/maven-core/src/main/java/org/apache/maven/artifact/repository/MavenArtifactRepository.java
 
b/maven-core/src/main/java/org/apache/maven/artifact/repository/MavenArtifactRepository.java
index 9765c73..d4c64f0 100644
--- 
a/maven-core/src/main/java/org/apache/maven/artifact/repository/MavenArtifactRepository.java
+++ 
b/maven-core/src/main/java/org/apache/maven/artifact/repository/MavenArtifactRepository.java
@@ -28,6 +28,10 @@ import org.apache.maven.artifact.metadata.ArtifactMetadata;
 import org.apache.maven.artifact.repository.layout.ArtifactRepositoryLayout;
 import org.apache.maven.repository.Proxy;
 
+/**
+ * Abstraction of an artifact repository. Artifact repositories can be remote, 
local, or even build reactor or
+ * IDE workspace.
+ */
 //TODO completely separate local and remote artifact repositories
 public class MavenArtifactRepository
 implements ArtifactRepository

http://git-wip-us.apache.org/repos/asf/maven/blob/d9250817/maven-core/src/main/java/org/apache/maven/artifact/repository/metadata/RepositoryMetadataManager.java
--
diff --git 
a/maven-core/src/main/java/org/apache/maven/artifact/repository/metadata/RepositoryMetadataManager.java
 
b/maven-core/src/main/java/org/apache/maven/artifact/repository/metadata/RepositoryMetadataManager.java
index 35626e5..0caeeb5 100644
--- 
a/maven-core/src/main/java/org/apache/maven/artifact/repository/metadata/RepositoryMetadataManager.java
+++ 
b/maven-core/src/main/java/org/apache/maven/artifact/repository/metadata/RepositoryMetadataManager.java
@@ -25,6 +25,9 @@ import org.apache.maven.artifact.metadata.ArtifactMetadata;
 import org.apache.maven.artifact.repository.ArtifactRepository;
 import org.apache.maven.artifact.repository.RepositoryRequest;
 
+/**
+ * RepositoryMetadataManager
+ */
 public interface RepositoryMetadataManager
 {
 

http://git-wip-us.apache.org/repos/asf/maven/blob/d9250817/maven-core/src/main/java/org/apache/maven/artifact/resolver/ResolutionNode.java
--
diff --git 
a/maven-core/src/main/java/org/apache/maven/artifact/resolver/ResolutionNode.java
 
b/maven-core/src/main/java/org/apache/maven/artifact/resolver/ResolutionNode.java
index cd824c4..a156871 100644
--- 
a/maven-core/src/main/java/org/apache/maven/artifact/resolver/ResolutionNode.java
+++ 
b/maven-core/src/main/java/org/apache/maven/artifact/resolver/ResolutionNode.java
@@ -32,6 +32,9 @@ import 
org.apache.maven.artifact.resolver.filter.ArtifactFilter;
 import org.apache.maven.artifact.versioning.ArtifactVersion;
 import org.apache.maven.artifact.versioning.OverConstrainedVersionException;
 
+/**
+ * ResolutionNode
+ */
 public class ResolutionNode
 {
 private Artifact artifact;

http://git-wip-us.apache.org/repos/asf/maven/blob/d9250817/maven-core/src/main/java/org/apache/maven/bridge/MavenRepositorySystem.java
--
diff --git 
a/maven-core/src/main/java/org/apache/maven/bridge/MavenRepositorySystem.java 
b/maven-core/src/main/java/org/apache/maven/bridge/MavenRepositorySystem.java
index 9331710..84ad93c 100644
--- 
a/maven-core/src/main/java/org/apache/maven/bridge/MavenRepositorySystem.java
+++ 
b/maven-core/src/main/java/org/apache/maven/bridge/MavenRepositorySystem.java
@@ -76,13 +76,13 @@ public class MavenRepositorySystem
 // DefaultProjectBuilder
 public Artifact createArtifact( String groupId, String artifactId, String 
version, String scope, String type )
 {
-return XcreateArtifact( groupId, artifactId, version, scope, type );
+return createArtifactX( groupId, artifactId, version, scope, type );
 }
 
 // DefaultProjectBuilder
 public Artifact createProjectArtifact( String groupId, String artifactId, 
String metaVersionId )
 {
-return XcreateProjectArtifact( groupId, artifactId, metaVersionId );
+return createProjectArtifactX( groupId, artifactId, metaVersionId );
 }
 
 // DefaultProjectBuilder
@@ -104,7 +104,7 @@ public class MavenRepositorySystem
 }
 
 Artifact artifact =
-XcreateDependencyArtifact( d.getGroupId(), d.getArtifactId(), 
versionRange, d.getType(),
+createDependencyArtifactX( d.getGroupId(), d.getArtifactId(), 
versionRange, d.getType(),
   d.getClassifier(), 
d.getScope(), d.isOptional() );
 
 if ( Artifact.SCOPE_SYSTEM.equals( d.getScope() ) && d.getSystemPath() 
!= null )
@@ -140,13 +140,13 @@ public class MavenRepositorySystem
 return null;
 }
 
-return XcreateExtensionArtifact( groupId, artifactId, 

[46/50] [abbrv] maven git commit: Reduce number of global checkstyle rule violations

2018-02-17 Thread khmarbaise
http://git-wip-us.apache.org/repos/asf/maven/blob/d9250817/maven-core/src/main/java/org/apache/maven/artifact/repository/MavenArtifactRepository.java
--
diff --git 
a/maven-core/src/main/java/org/apache/maven/artifact/repository/MavenArtifactRepository.java
 
b/maven-core/src/main/java/org/apache/maven/artifact/repository/MavenArtifactRepository.java
index 9765c73..d4c64f0 100644
--- 
a/maven-core/src/main/java/org/apache/maven/artifact/repository/MavenArtifactRepository.java
+++ 
b/maven-core/src/main/java/org/apache/maven/artifact/repository/MavenArtifactRepository.java
@@ -28,6 +28,10 @@ import org.apache.maven.artifact.metadata.ArtifactMetadata;
 import org.apache.maven.artifact.repository.layout.ArtifactRepositoryLayout;
 import org.apache.maven.repository.Proxy;
 
+/**
+ * Abstraction of an artifact repository. Artifact repositories can be remote, 
local, or even build reactor or
+ * IDE workspace.
+ */
 //TODO completely separate local and remote artifact repositories
 public class MavenArtifactRepository
 implements ArtifactRepository

http://git-wip-us.apache.org/repos/asf/maven/blob/d9250817/maven-core/src/main/java/org/apache/maven/artifact/repository/metadata/RepositoryMetadataManager.java
--
diff --git 
a/maven-core/src/main/java/org/apache/maven/artifact/repository/metadata/RepositoryMetadataManager.java
 
b/maven-core/src/main/java/org/apache/maven/artifact/repository/metadata/RepositoryMetadataManager.java
index 35626e5..0caeeb5 100644
--- 
a/maven-core/src/main/java/org/apache/maven/artifact/repository/metadata/RepositoryMetadataManager.java
+++ 
b/maven-core/src/main/java/org/apache/maven/artifact/repository/metadata/RepositoryMetadataManager.java
@@ -25,6 +25,9 @@ import org.apache.maven.artifact.metadata.ArtifactMetadata;
 import org.apache.maven.artifact.repository.ArtifactRepository;
 import org.apache.maven.artifact.repository.RepositoryRequest;
 
+/**
+ * RepositoryMetadataManager
+ */
 public interface RepositoryMetadataManager
 {
 

http://git-wip-us.apache.org/repos/asf/maven/blob/d9250817/maven-core/src/main/java/org/apache/maven/artifact/resolver/ResolutionNode.java
--
diff --git 
a/maven-core/src/main/java/org/apache/maven/artifact/resolver/ResolutionNode.java
 
b/maven-core/src/main/java/org/apache/maven/artifact/resolver/ResolutionNode.java
index cd824c4..a156871 100644
--- 
a/maven-core/src/main/java/org/apache/maven/artifact/resolver/ResolutionNode.java
+++ 
b/maven-core/src/main/java/org/apache/maven/artifact/resolver/ResolutionNode.java
@@ -32,6 +32,9 @@ import 
org.apache.maven.artifact.resolver.filter.ArtifactFilter;
 import org.apache.maven.artifact.versioning.ArtifactVersion;
 import org.apache.maven.artifact.versioning.OverConstrainedVersionException;
 
+/**
+ * ResolutionNode
+ */
 public class ResolutionNode
 {
 private Artifact artifact;

http://git-wip-us.apache.org/repos/asf/maven/blob/d9250817/maven-core/src/main/java/org/apache/maven/bridge/MavenRepositorySystem.java
--
diff --git 
a/maven-core/src/main/java/org/apache/maven/bridge/MavenRepositorySystem.java 
b/maven-core/src/main/java/org/apache/maven/bridge/MavenRepositorySystem.java
index 9331710..84ad93c 100644
--- 
a/maven-core/src/main/java/org/apache/maven/bridge/MavenRepositorySystem.java
+++ 
b/maven-core/src/main/java/org/apache/maven/bridge/MavenRepositorySystem.java
@@ -76,13 +76,13 @@ public class MavenRepositorySystem
 // DefaultProjectBuilder
 public Artifact createArtifact( String groupId, String artifactId, String 
version, String scope, String type )
 {
-return XcreateArtifact( groupId, artifactId, version, scope, type );
+return createArtifactX( groupId, artifactId, version, scope, type );
 }
 
 // DefaultProjectBuilder
 public Artifact createProjectArtifact( String groupId, String artifactId, 
String metaVersionId )
 {
-return XcreateProjectArtifact( groupId, artifactId, metaVersionId );
+return createProjectArtifactX( groupId, artifactId, metaVersionId );
 }
 
 // DefaultProjectBuilder
@@ -104,7 +104,7 @@ public class MavenRepositorySystem
 }
 
 Artifact artifact =
-XcreateDependencyArtifact( d.getGroupId(), d.getArtifactId(), 
versionRange, d.getType(),
+createDependencyArtifactX( d.getGroupId(), d.getArtifactId(), 
versionRange, d.getType(),
   d.getClassifier(), 
d.getScope(), d.isOptional() );
 
 if ( Artifact.SCOPE_SYSTEM.equals( d.getScope() ) && d.getSystemPath() 
!= null )
@@ -140,13 +140,13 @@ public class MavenRepositorySystem
 return null;
 }
 
-return XcreateExtensionArtifact( groupId, artifactId, 

[46/50] [abbrv] maven git commit: Reduce number of global checkstyle rule violations

2018-02-17 Thread khmarbaise
http://git-wip-us.apache.org/repos/asf/maven/blob/d9250817/maven-core/src/main/java/org/apache/maven/artifact/repository/MavenArtifactRepository.java
--
diff --git 
a/maven-core/src/main/java/org/apache/maven/artifact/repository/MavenArtifactRepository.java
 
b/maven-core/src/main/java/org/apache/maven/artifact/repository/MavenArtifactRepository.java
index 9765c73..d4c64f0 100644
--- 
a/maven-core/src/main/java/org/apache/maven/artifact/repository/MavenArtifactRepository.java
+++ 
b/maven-core/src/main/java/org/apache/maven/artifact/repository/MavenArtifactRepository.java
@@ -28,6 +28,10 @@ import org.apache.maven.artifact.metadata.ArtifactMetadata;
 import org.apache.maven.artifact.repository.layout.ArtifactRepositoryLayout;
 import org.apache.maven.repository.Proxy;
 
+/**
+ * Abstraction of an artifact repository. Artifact repositories can be remote, 
local, or even build reactor or
+ * IDE workspace.
+ */
 //TODO completely separate local and remote artifact repositories
 public class MavenArtifactRepository
 implements ArtifactRepository

http://git-wip-us.apache.org/repos/asf/maven/blob/d9250817/maven-core/src/main/java/org/apache/maven/artifact/repository/metadata/RepositoryMetadataManager.java
--
diff --git 
a/maven-core/src/main/java/org/apache/maven/artifact/repository/metadata/RepositoryMetadataManager.java
 
b/maven-core/src/main/java/org/apache/maven/artifact/repository/metadata/RepositoryMetadataManager.java
index 35626e5..0caeeb5 100644
--- 
a/maven-core/src/main/java/org/apache/maven/artifact/repository/metadata/RepositoryMetadataManager.java
+++ 
b/maven-core/src/main/java/org/apache/maven/artifact/repository/metadata/RepositoryMetadataManager.java
@@ -25,6 +25,9 @@ import org.apache.maven.artifact.metadata.ArtifactMetadata;
 import org.apache.maven.artifact.repository.ArtifactRepository;
 import org.apache.maven.artifact.repository.RepositoryRequest;
 
+/**
+ * RepositoryMetadataManager
+ */
 public interface RepositoryMetadataManager
 {
 

http://git-wip-us.apache.org/repos/asf/maven/blob/d9250817/maven-core/src/main/java/org/apache/maven/artifact/resolver/ResolutionNode.java
--
diff --git 
a/maven-core/src/main/java/org/apache/maven/artifact/resolver/ResolutionNode.java
 
b/maven-core/src/main/java/org/apache/maven/artifact/resolver/ResolutionNode.java
index cd824c4..a156871 100644
--- 
a/maven-core/src/main/java/org/apache/maven/artifact/resolver/ResolutionNode.java
+++ 
b/maven-core/src/main/java/org/apache/maven/artifact/resolver/ResolutionNode.java
@@ -32,6 +32,9 @@ import 
org.apache.maven.artifact.resolver.filter.ArtifactFilter;
 import org.apache.maven.artifact.versioning.ArtifactVersion;
 import org.apache.maven.artifact.versioning.OverConstrainedVersionException;
 
+/**
+ * ResolutionNode
+ */
 public class ResolutionNode
 {
 private Artifact artifact;

http://git-wip-us.apache.org/repos/asf/maven/blob/d9250817/maven-core/src/main/java/org/apache/maven/bridge/MavenRepositorySystem.java
--
diff --git 
a/maven-core/src/main/java/org/apache/maven/bridge/MavenRepositorySystem.java 
b/maven-core/src/main/java/org/apache/maven/bridge/MavenRepositorySystem.java
index 9331710..84ad93c 100644
--- 
a/maven-core/src/main/java/org/apache/maven/bridge/MavenRepositorySystem.java
+++ 
b/maven-core/src/main/java/org/apache/maven/bridge/MavenRepositorySystem.java
@@ -76,13 +76,13 @@ public class MavenRepositorySystem
 // DefaultProjectBuilder
 public Artifact createArtifact( String groupId, String artifactId, String 
version, String scope, String type )
 {
-return XcreateArtifact( groupId, artifactId, version, scope, type );
+return createArtifactX( groupId, artifactId, version, scope, type );
 }
 
 // DefaultProjectBuilder
 public Artifact createProjectArtifact( String groupId, String artifactId, 
String metaVersionId )
 {
-return XcreateProjectArtifact( groupId, artifactId, metaVersionId );
+return createProjectArtifactX( groupId, artifactId, metaVersionId );
 }
 
 // DefaultProjectBuilder
@@ -104,7 +104,7 @@ public class MavenRepositorySystem
 }
 
 Artifact artifact =
-XcreateDependencyArtifact( d.getGroupId(), d.getArtifactId(), 
versionRange, d.getType(),
+createDependencyArtifactX( d.getGroupId(), d.getArtifactId(), 
versionRange, d.getType(),
   d.getClassifier(), 
d.getScope(), d.isOptional() );
 
 if ( Artifact.SCOPE_SYSTEM.equals( d.getScope() ) && d.getSystemPath() 
!= null )
@@ -140,13 +140,13 @@ public class MavenRepositorySystem
 return null;
 }
 
-return XcreateExtensionArtifact( groupId, artifactId,