Repository: mesos Updated Branches: refs/heads/master 06d8d759a -> c526016e8
Added to a comment in master.cpp. Adds an additional example to a comment explaining a seemingly duplicate registration attempt of a slave. Review: https://reviews.apache.org/r/66164/ Project: http://git-wip-us.apache.org/repos/asf/mesos/repo Commit: http://git-wip-us.apache.org/repos/asf/mesos/commit/1e2af373 Tree: http://git-wip-us.apache.org/repos/asf/mesos/tree/1e2af373 Diff: http://git-wip-us.apache.org/repos/asf/mesos/diff/1e2af373 Branch: refs/heads/master Commit: 1e2af373a39a39ee015c1994ff36161eb29c79dd Parents: 06d8d75 Author: Till Toenshoff <toensh...@me.com> Authored: Fri Apr 6 20:05:36 2018 +0200 Committer: Alexander Rukletsov <al...@apache.org> Committed: Fri Apr 6 20:07:28 2018 +0200 ---------------------------------------------------------------------- src/master/master.cpp | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/mesos/blob/1e2af373/src/master/master.cpp ---------------------------------------------------------------------- diff --git a/src/master/master.cpp b/src/master/master.cpp index 18382fa..f7da675 100644 --- a/src/master/master.cpp +++ b/src/master/master.cpp @@ -6475,9 +6475,12 @@ void Master::_registerSlave( if (Slave* slave = slaves.registered.get(pid)) { if (!slave->connected) { // The slave was previously disconnected but it is now trying - // to register as a new slave. This could happen if the slave - // failed recovery and hence registering as a new slave before - // the master removed the old slave from its map. + // to register as a new slave. + // There are several possible reasons for this to happen: + // - If the slave failed recovery and hence registering as a new + // slave before the master removed the old slave from its map. + // - If the slave was shutting down while it had a registration + // retry scheduled. See MESOS-8463. LOG(INFO) << "Removing old disconnected agent " << *slave << " because a registration attempt occurred";
