[GitHub] viebboy commented on issue #7642: Max norm regularization

2018-02-02 Thread GitBox
viebboy commented on issue #7642: Max norm regularization URL: https://github.com/apache/incubator-mxnet/issues/7642#issuecomment-362570173 Have you figured out how to implement max norm regularization yet? This is an

[GitHub] KineticCookie commented on issue #9361: infer_shape error for 'resnet-152'

2018-02-02 Thread GitBox
KineticCookie commented on issue #9361: infer_shape error for 'resnet-152' URL: https://github.com/apache/incubator-mxnet/issues/9361#issuecomment-362577135 @kevinthesun thanks for the detailed explanation. ? This is an

[GitHub] szha commented on issue #8529: What is the functionality of OrderMutation

2018-02-02 Thread GitBox
szha commented on issue #8529: What is the functionality of OrderMutation URL: https://github.com/apache/incubator-mxnet/issues/8529#issuecomment-362573098 @apache/mxnet-committers: This issue has been inactive for the past 90 days. It has no label and needs triage. For general

[GitHub] KellenSunderland commented on issue #9612: CUDNN_STATUS_SUCCESS (4 vs. 0) cuDNN: CUDNN_STATUS_INTERNAL_ERROR on jetson TX2

2018-02-02 Thread GitBox
KellenSunderland commented on issue #9612: CUDNN_STATUS_SUCCESS (4 vs. 0) cuDNN: CUDNN_STATUS_INTERNAL_ERROR on jetson TX2 URL: https://github.com/apache/incubator-mxnet/issues/9612#issuecomment-36259 Thanks again for iterating on this. The guide is updated with a build that should

[GitHub] benqua commented on issue #8245: Use argmax instead of argmax_channel in Accuracy to keep dimention

2018-02-02 Thread GitBox
benqua commented on issue #8245: Use argmax instead of argmax_channel in Accuracy to keep dimention URL: https://github.com/apache/incubator-mxnet/pull/8245#issuecomment-362581380 @yzhliu Can you check and merge if ok? This

[GitHub] KellenSunderland commented on issue #9552: [REQUEST FOR REVIEW | DO NOT MERGE] Model Quantization with Calibration

2018-02-02 Thread GitBox
KellenSunderland commented on issue #9552: [REQUEST FOR REVIEW | DO NOT MERGE] Model Quantization with Calibration URL: https://github.com/apache/incubator-mxnet/pull/9552#issuecomment-362572156 Hey @reminisce, looking forward to this one on the edge team (if you can't tell). If you're

[GitHub] KellenSunderland commented on a change in pull request #9671: Exp backoff for downloads.

2018-02-02 Thread GitBox
KellenSunderland commented on a change in pull request #9671: Exp backoff for downloads. URL: https://github.com/apache/incubator-mxnet/pull/9671#discussion_r165642736 ## File path: python/mxnet/gluon/utils.py ## @@ -61,13 +52,13 @@ def split_data(data, num_slice,

[GitHub] larroy opened a new pull request #9685: Script to install on a python virtualenv for development

2018-02-02 Thread GitBox
larroy opened a new pull request #9685: Script to install on a python virtualenv for development URL: https://github.com/apache/incubator-mxnet/pull/9685 This is an automated message from the Apache Git Service. To respond

[GitHub] pengzhao-intel commented on a change in pull request #9552: [REQUEST FOR REVIEW | DO NOT MERGE] Model Quantization with Calibration

2018-02-02 Thread GitBox
pengzhao-intel commented on a change in pull request #9552: [REQUEST FOR REVIEW | DO NOT MERGE] Model Quantization with Calibration URL: https://github.com/apache/incubator-mxnet/pull/9552#discussion_r165646442 ## File path: src/operator/quantization/quantized_conv.cc ##

[GitHub] KineticCookie closed issue #9361: infer_shape error for 'resnet-152'

2018-02-02 Thread GitBox
KineticCookie closed issue #9361: infer_shape error for 'resnet-152' URL: https://github.com/apache/incubator-mxnet/issues/9361 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] KellenSunderland commented on a change in pull request #9671: Exp backoff for downloads.

2018-02-02 Thread GitBox
KellenSunderland commented on a change in pull request #9671: Exp backoff for downloads. URL: https://github.com/apache/incubator-mxnet/pull/9671#discussion_r165642736 ## File path: python/mxnet/gluon/utils.py ## @@ -61,13 +52,13 @@ def split_data(data, num_slice,

[GitHub] marcoabreu commented on a change in pull request #9684: Enable dp4a for the CI

2018-02-02 Thread GitBox
marcoabreu commented on a change in pull request #9684: Enable dp4a for the CI URL: https://github.com/apache/incubator-mxnet/pull/9684#discussion_r165696114 ## File path: tests/ci_build/ci_build.sh ## @@ -176,7 +180,7 @@ ${DOCKER_BINARY} run --rm --pid=host \ -e

[GitHub] reminisce commented on issue #9552: [REQUEST FOR REVIEW | DO NOT MERGE] Model Quantization with Calibration

2018-02-02 Thread GitBox
reminisce commented on issue #9552: [REQUEST FOR REVIEW | DO NOT MERGE] Model Quantization with Calibration URL: https://github.com/apache/incubator-mxnet/pull/9552#issuecomment-362642270 @KellenSunderland Thank you for the note. I will either cherry pick the PR or rebased with the master

[GitHub] reminisce commented on issue #9552: [REQUEST FOR REVIEW | DO NOT MERGE] Model Quantization with Calibration

2018-02-02 Thread GitBox
reminisce commented on issue #9552: [REQUEST FOR REVIEW | DO NOT MERGE] Model Quantization with Calibration URL: https://github.com/apache/incubator-mxnet/pull/9552#issuecomment-362662671 @pengzhao-intel Thank you guys for implementing quantized ops for CPU computing. We look forward to

[GitHub] zhanghang1989 commented on a change in pull request #7938: instance norm and reflection padding

2018-02-02 Thread GitBox
zhanghang1989 commented on a change in pull request #7938: instance norm and reflection padding URL: https://github.com/apache/incubator-mxnet/pull/7938#discussion_r165713203 ## File path: python/mxnet/gluon/nn/conv_layers.py ## @@ -1007,3 +1008,37 @@ def __init__(self,

[GitHub] nswamy commented on issue #9678: [First cut] Scala Inference APIs

2018-02-02 Thread GitBox
nswamy commented on issue #9678: [First cut] Scala Inference APIs URL: https://github.com/apache/incubator-mxnet/pull/9678#issuecomment-362641760 Unit Tests are failing for a requirement(number of dimensions in shape match the number of elements in layout) I put into the DataDesc. I will

[GitHub] nswamy commented on issue #9678: [First cut] Scala Inference APIs

2018-02-02 Thread GitBox
nswamy commented on issue #9678: [First cut] Scala Inference APIs URL: https://github.com/apache/incubator-mxnet/pull/9678#issuecomment-362641862 @lupesko please review. This is an automated message from the Apache Git

[GitHub] eric-haibin-lin commented on issue #9666: [scala-package][master] bump up project version

2018-02-02 Thread GitBox
eric-haibin-lin commented on issue #9666: [scala-package][master] bump up project version URL: https://github.com/apache/incubator-mxnet/pull/9666#issuecomment-362664186 I?m not sure about that. For MXNet it is required. On 2018?2?1?, at 13:04, Nan Zhu

[GitHub] nswamy commented on issue #9678: [First cut] Scala Inference APIs

2018-02-02 Thread GitBox
nswamy commented on issue #9678: [First cut] Scala Inference APIs URL: https://github.com/apache/incubator-mxnet/pull/9678#issuecomment-362641862 @calumleslie @yizhi @lupesko @jesterhazy This is an automated message from the

[GitHub] nswamy commented on issue #9678: [First cut] Scala Inference APIs

2018-02-02 Thread GitBox
nswamy commented on issue #9678: [First cut] Scala Inference APIs URL: https://github.com/apache/incubator-mxnet/pull/9678#issuecomment-362641465 @marcoabreu, this package needs to pull in the core package under dmlc, so i prefer to keep it under dmlc. I would prefer to have a separate

[GitHub] piiswrong closed pull request #9683: gluon block.py typo

2018-02-02 Thread GitBox
piiswrong closed pull request #9683: gluon block.py typo URL: https://github.com/apache/incubator-mxnet/pull/9683 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request

[incubator-mxnet] branch master updated: typo (#9683)

2018-02-02 Thread jxie
This is an automated email from the ASF dual-hosted git repository. jxie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-mxnet.git The following commit(s) were added to refs/heads/master by this push: new 8ee3177 typo (#9683) 8ee3177 is

[GitHub] piiswrong commented on a change in pull request #9681: Better Exception Handling for Operators

2018-02-02 Thread GitBox
piiswrong commented on a change in pull request #9681: Better Exception Handling for Operators URL: https://github.com/apache/incubator-mxnet/pull/9681#discussion_r165727816 ## File path: src/engine/threaded_engine.h ## @@ -175,6 +175,8 @@ class ThreadedVar final

[GitHub] piiswrong closed pull request #9674: Fix test_sparse_operator failures due to out-of-bounds ref.

2018-02-02 Thread GitBox
piiswrong closed pull request #9674: Fix test_sparse_operator failures due to out-of-bounds ref. URL: https://github.com/apache/incubator-mxnet/pull/9674 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[GitHub] anirudh2290 commented on a change in pull request #9681: Better Exception Handling for Operators

2018-02-02 Thread GitBox
anirudh2290 commented on a change in pull request #9681: Better Exception Handling for Operators URL: https://github.com/apache/incubator-mxnet/pull/9681#discussion_r165772505 ## File path: tests/python/unittest/test_exc_handling.py ## @@ -0,0 +1,112 @@ +# Licensed to the

[GitHub] piiswrong commented on a change in pull request #9681: Better Exception Handling for Operators

2018-02-02 Thread GitBox
piiswrong commented on a change in pull request #9681: Better Exception Handling for Operators URL: https://github.com/apache/incubator-mxnet/pull/9681#discussion_r165726239 ## File path: src/engine/threaded_engine.cc ## @@ -403,7 +417,11 @@ inline void

[GitHub] piiswrong commented on a change in pull request #9681: Better Exception Handling for Operators

2018-02-02 Thread GitBox
piiswrong commented on a change in pull request #9681: Better Exception Handling for Operators URL: https://github.com/apache/incubator-mxnet/pull/9681#discussion_r165726063 ## File path: src/engine/threaded_engine.cc ## @@ -391,6 +400,11 @@ void

[GitHub] piiswrong commented on a change in pull request #9681: Better Exception Handling for Operators

2018-02-02 Thread GitBox
piiswrong commented on a change in pull request #9681: Better Exception Handling for Operators URL: https://github.com/apache/incubator-mxnet/pull/9681#discussion_r165728359 ## File path: src/engine/threaded_engine.h ## @@ -338,33 +346,46 @@ class ThreadedEngine : public

[GitHub] piiswrong commented on a change in pull request #9681: Better Exception Handling for Operators

2018-02-02 Thread GitBox
piiswrong commented on a change in pull request #9681: Better Exception Handling for Operators URL: https://github.com/apache/incubator-mxnet/pull/9681#discussion_r165728531 ## File path: src/engine/threaded_engine.h ## @@ -338,33 +346,46 @@ class ThreadedEngine : public

[GitHub] piiswrong commented on a change in pull request #9681: Better Exception Handling for Operators

2018-02-02 Thread GitBox
piiswrong commented on a change in pull request #9681: Better Exception Handling for Operators URL: https://github.com/apache/incubator-mxnet/pull/9681#discussion_r165731112 ## File path: src/storage/gpu_device_storage.h ## @@ -62,7 +62,7 @@ inline void*

[incubator-mxnet] branch master updated: Fix test_sparse_operator failures due to out-of-bounds ref. (#9674)

2018-02-02 Thread jxie
This is an automated email from the ASF dual-hosted git repository. jxie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-mxnet.git The following commit(s) were added to refs/heads/master by this push: new 51776aa Fix test_sparse_operator

[GitHub] piiswrong commented on a change in pull request #9681: Better Exception Handling for Operators

2018-02-02 Thread GitBox
piiswrong commented on a change in pull request #9681: Better Exception Handling for Operators URL: https://github.com/apache/incubator-mxnet/pull/9681#discussion_r165731530 ## File path: src/engine/threaded_engine.h ## @@ -476,6 +507,9 @@ class ThreadedEngine : public

[GitHub] szha commented on a change in pull request #7938: instance norm and reflection padding

2018-02-02 Thread GitBox
szha commented on a change in pull request #7938: instance norm and reflection padding URL: https://github.com/apache/incubator-mxnet/pull/7938#discussion_r165726019 ## File path: python/mxnet/gluon/nn/conv_layers.py ## @@ -1007,3 +1008,37 @@ def __init__(self,

[GitHub] piiswrong commented on a change in pull request #9681: Better Exception Handling for Operators

2018-02-02 Thread GitBox
piiswrong commented on a change in pull request #9681: Better Exception Handling for Operators URL: https://github.com/apache/incubator-mxnet/pull/9681#discussion_r165725747 ## File path: src/engine/threaded_engine.cc ## @@ -356,7 +357,11 @@ void

[GitHub] piiswrong commented on a change in pull request #9681: Better Exception Handling for Operators

2018-02-02 Thread GitBox
piiswrong commented on a change in pull request #9681: Better Exception Handling for Operators URL: https://github.com/apache/incubator-mxnet/pull/9681#discussion_r165726063 ## File path: src/engine/threaded_engine.cc ## @@ -391,6 +400,11 @@ void

[GitHub] piiswrong commented on a change in pull request #9681: Better Exception Handling for Operators

2018-02-02 Thread GitBox
piiswrong commented on a change in pull request #9681: Better Exception Handling for Operators URL: https://github.com/apache/incubator-mxnet/pull/9681#discussion_r165727071 ## File path: src/engine/threaded_engine.cc ## @@ -403,7 +417,11 @@ inline void

[GitHub] reminisce commented on a change in pull request #9681: Better Exception Handling for Operators

2018-02-02 Thread GitBox
reminisce commented on a change in pull request #9681: Better Exception Handling for Operators URL: https://github.com/apache/incubator-mxnet/pull/9681#discussion_r165574053 ## File path: include/mxnet/engine.h ## @@ -182,7 +182,7 @@ class MXNET_API Engine {

[GitHub] reminisce commented on a change in pull request #9681: Better Exception Handling for Operators

2018-02-02 Thread GitBox
reminisce commented on a change in pull request #9681: Better Exception Handling for Operators URL: https://github.com/apache/incubator-mxnet/pull/9681#discussion_r165574890 ## File path: tests/python/unittest/test_exc_handling.py ## @@ -0,0 +1,112 @@ +# Licensed to the

[GitHub] reminisce commented on a change in pull request #9681: Better Exception Handling for Operators

2018-02-02 Thread GitBox
reminisce commented on a change in pull request #9681: Better Exception Handling for Operators URL: https://github.com/apache/incubator-mxnet/pull/9681#discussion_r165574175 ## File path: src/engine/naive_engine.cc ## @@ -73,7 +73,7 @@ class NaiveEngine final : public

[GitHub] reminisce commented on a change in pull request #9681: Better Exception Handling for Operators

2018-02-02 Thread GitBox
reminisce commented on a change in pull request #9681: Better Exception Handling for Operators URL: https://github.com/apache/incubator-mxnet/pull/9681#discussion_r165574204 ## File path: src/engine/naive_engine.cc ## @@ -125,7 +125,7 @@ class NaiveEngine final : public

[GitHub] szha closed pull request #9653: Set the autotune default to 1 in docs

2018-02-02 Thread GitBox
szha closed pull request #9653: Set the autotune default to 1 in docs URL: https://github.com/apache/incubator-mxnet/pull/9653 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign

[incubator-mxnet] branch master updated: Set the autotune default to 1 in docs (#9653)

2018-02-02 Thread zhasheng
This is an automated email from the ASF dual-hosted git repository. zhasheng pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-mxnet.git The following commit(s) were added to refs/heads/master by this push: new 95095e4 Set the autotune default to

[GitHub] chsin commented on issue #9028: How to use the C API to train simple a Softmax in pure C?

2018-02-02 Thread GitBox
chsin commented on issue #9028: How to use the C API to train simple a Softmax in pure C? URL: https://github.com/apache/incubator-mxnet/issues/9028#issuecomment-362707675 No, they're just going to ignore this for 90 days and then close it.

[GitHub] szha opened a new issue #9686: APIs that might be a good idea to remove in 2.0

2018-02-02 Thread GitBox
szha opened a new issue #9686: APIs that might be a good idea to remove in 2.0 URL: https://github.com/apache/incubator-mxnet/issues/9686 Now that we decided to follow semantic versioning for releases, it would be a good idea to coordinate features and API changes to make the best use of

[GitHub] piiswrong commented on issue #9676: [Feature Request] Cross Product Operation

2018-02-02 Thread GitBox
piiswrong commented on issue #9676: [Feature Request] Cross Product Operation URL: https://github.com/apache/incubator-mxnet/issues/9676#issuecomment-362682999 Could you give a mathematical description or a reference paper?

[GitHub] piiswrong commented on a change in pull request #9681: Better Exception Handling for Operators

2018-02-02 Thread GitBox
piiswrong commented on a change in pull request #9681: Better Exception Handling for Operators URL: https://github.com/apache/incubator-mxnet/pull/9681#discussion_r165727071 ## File path: src/engine/threaded_engine.cc ## @@ -403,7 +417,11 @@ inline void

[GitHub] piiswrong commented on a change in pull request #9681: Better Exception Handling for Operators

2018-02-02 Thread GitBox
piiswrong commented on a change in pull request #9681: Better Exception Handling for Operators URL: https://github.com/apache/incubator-mxnet/pull/9681#discussion_r165727071 ## File path: src/engine/threaded_engine.cc ## @@ -403,7 +417,11 @@ inline void

[GitHub] zhanghang1989 commented on a change in pull request #7938: instance norm and reflection padding

2018-02-02 Thread GitBox
zhanghang1989 commented on a change in pull request #7938: instance norm and reflection padding URL: https://github.com/apache/incubator-mxnet/pull/7938#discussion_r165729982 ## File path: python/mxnet/gluon/nn/conv_layers.py ## @@ -1007,3 +1008,37 @@ def __init__(self,

[GitHub] ShownX commented on issue #9676: [Feature Request] Cross Product Operation

2018-02-02 Thread GitBox
ShownX commented on issue #9676: [Feature Request] Cross Product Operation URL: https://github.com/apache/incubator-mxnet/issues/9676#issuecomment-362717027 Numpy: https://github.com/numpy/numpy/blob/v1.12.0/numpy/core/numeric.py#L1640-L1838 PyTorch:

[GitHub] anirudh2290 commented on a change in pull request #9681: Better Exception Handling for Operators

2018-02-02 Thread GitBox
anirudh2290 commented on a change in pull request #9681: Better Exception Handling for Operators URL: https://github.com/apache/incubator-mxnet/pull/9681#discussion_r165772677 ## File path: include/mxnet/engine.h ## @@ -182,7 +182,7 @@ class MXNET_API Engine {

[GitHub] anirudh2290 commented on a change in pull request #9681: Better Exception Handling for Operators

2018-02-02 Thread GitBox
anirudh2290 commented on a change in pull request #9681: Better Exception Handling for Operators URL: https://github.com/apache/incubator-mxnet/pull/9681#discussion_r165772731 ## File path: src/engine/threaded_engine.cc ## @@ -356,7 +357,11 @@ void

[GitHub] reminisce commented on issue #9552: [REQUEST FOR REVIEW | DO NOT MERGE] Model Quantization with Calibration

2018-02-02 Thread GitBox
reminisce commented on issue #9552: [REQUEST FOR REVIEW | DO NOT MERGE] Model Quantization with Calibration URL: https://github.com/apache/incubator-mxnet/pull/9552#issuecomment-362779633 @pengzhao-intel I will definitely let you know if there are breaking changes. For testing

[GitHub] piiswrong commented on a change in pull request #9688: bilinear upsample from PyTorch

2018-02-02 Thread GitBox
piiswrong commented on a change in pull request #9688: bilinear upsample from PyTorch URL: https://github.com/apache/incubator-mxnet/pull/9688#discussion_r165805852 ## File path: src/operator/bilinear_upsample-inl.h ## @@ -0,0 +1,162 @@ +/* + * Licensed to the Apache

[GitHub] piiswrong commented on a change in pull request #9688: bilinear upsample from PyTorch

2018-02-02 Thread GitBox
piiswrong commented on a change in pull request #9688: bilinear upsample from PyTorch URL: https://github.com/apache/incubator-mxnet/pull/9688#discussion_r165805825 ## File path: src/operator/bilinear_upsample.cu ## @@ -0,0 +1,217 @@ +/* + * Licensed to the Apache

[GitHub] pengzhao-intel commented on issue #2986: [call for contribution] Improving CPU performance

2018-02-02 Thread GitBox
pengzhao-intel commented on issue #2986: [call for contribution] Improving CPU performance URL: https://github.com/apache/incubator-mxnet/issues/2986#issuecomment-362783687 FYI, MKL-DNN integration is done and will be merged soon in #9677. You can find the performance data in #8302

[GitHub] szha commented on a change in pull request #9662: Gluon PReLU, ELU, SELU, Swish

2018-02-02 Thread GitBox
szha commented on a change in pull request #9662: Gluon PReLU, ELU, SELU, Swish URL: https://github.com/apache/incubator-mxnet/pull/9662#discussion_r165807547 ## File path: src/operator/leaky_relu-inl.h ## @@ -177,9 +182,20 @@ class LeakyReLUOp : public Operator {

[GitHub] 315386775 commented on issue #7778: float16 has no performance improvement

2018-02-02 Thread GitBox
315386775 commented on issue #7778: float16 has no performance improvement URL: https://github.com/apache/incubator-mxnet/issues/7778#issuecomment-362234020 @hfutxrg how to use fp16 with the pre-train model. python /image-classification/fine-tune.py

[GitHub] piiswrong commented on issue #9688: bilinear upsample from PyTorch

2018-02-02 Thread GitBox
piiswrong commented on issue #9688: bilinear upsample from PyTorch URL: https://github.com/apache/incubator-mxnet/pull/9688#issuecomment-362782532 We prefer a rewrite based on mxnet utilities instead of copy paste if possible. The current code doesn't use openmp for cpu

[incubator-mxnet] branch master updated: Fix warning in sequence_last-inl.h (#9687)

2018-02-02 Thread jxie
This is an automated email from the ASF dual-hosted git repository. jxie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-mxnet.git The following commit(s) were added to refs/heads/master by this push: new ec76003 Fix warning in

[GitHub] anirudh2290 closed issue #8699: Temporary workspace for operators can only be allocated once

2018-02-02 Thread GitBox
anirudh2290 closed issue #8699: Temporary workspace for operators can only be allocated once URL: https://github.com/apache/incubator-mxnet/issues/8699 This is an automated message from the Apache Git Service. To respond to

[GitHub] kice opened a new issue #9689: How to use gluon to train GAN network on multiple GPUs?

2018-02-02 Thread GitBox
kice opened a new issue #9689: How to use gluon to train GAN network on multiple GPUs? URL: https://github.com/apache/incubator-mxnet/issues/9689 I come up with a solution, but it trains discriminator for an epoch and then uses the same thing to train the generator. ``` def

[GitHub] piiswrong commented on a change in pull request #9688: bilinear upsample from PyTorch

2018-02-02 Thread GitBox
piiswrong commented on a change in pull request #9688: bilinear upsample from PyTorch URL: https://github.com/apache/incubator-mxnet/pull/9688#discussion_r165805897 ## File path: src/operator/bilinear_upsample-inl.h ## @@ -0,0 +1,162 @@ +/* + * Licensed to the Apache

[GitHub] piiswrong commented on a change in pull request #9688: bilinear upsample from PyTorch

2018-02-02 Thread GitBox
piiswrong commented on a change in pull request #9688: bilinear upsample from PyTorch URL: https://github.com/apache/incubator-mxnet/pull/9688#discussion_r165805891 ## File path: src/operator/bilinear_upsample-inl.h ## @@ -0,0 +1,162 @@ +/* + * Licensed to the Apache

[GitHub] piiswrong closed pull request #9687: Fix warning in sequence_last-inl.h

2018-02-02 Thread GitBox
piiswrong closed pull request #9687: Fix warning in sequence_last-inl.h URL: https://github.com/apache/incubator-mxnet/pull/9687 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a

[GitHub] szha commented on issue #9662: Gluon PReLU, ELU, SELU, Swish

2018-02-02 Thread GitBox
szha commented on issue #9662: Gluon PReLU, ELU, SELU, Swish URL: https://github.com/apache/incubator-mxnet/pull/9662#issuecomment-362786409 @piiswrong addressed the infer shape issue. Let me know if you have more comments.

[GitHub] szha commented on a change in pull request #9662: Gluon PReLU, ELU, SELU, Swish

2018-02-02 Thread GitBox
szha commented on a change in pull request #9662: Gluon PReLU, ELU, SELU, Swish URL: https://github.com/apache/incubator-mxnet/pull/9662#discussion_r165807578 ## File path: src/operator/leaky_relu-inl.h ## @@ -177,9 +182,20 @@ class LeakyReLUOp : public Operator {

[incubator-mxnet] branch master updated: instance norm and reflection padding (#7938)

2018-02-02 Thread zhasheng
This is an automated email from the ASF dual-hosted git repository. zhasheng pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-mxnet.git The following commit(s) were added to refs/heads/master by this push: new d452162 instance norm and

[GitHub] szha closed pull request #7938: instance norm and reflection padding

2018-02-02 Thread GitBox
szha closed pull request #7938: instance norm and reflection padding URL: https://github.com/apache/incubator-mxnet/pull/7938 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign

[GitHub] 315386775 commented on issue #7778: float16 has no performance improvement

2018-02-02 Thread GitBox
315386775 commented on issue #7778: float16 has no performance improvement URL: https://github.com/apache/incubator-mxnet/issues/7778#issuecomment-362788373 @hfutxrg I run resnet-v1 but it does have impressive performance improvement if large --data-nthreads N is used. Actually. The speed

[GitHub] piiswrong commented on a change in pull request #9681: Better Exception Handling for Operators

2018-02-02 Thread GitBox
piiswrong commented on a change in pull request #9681: Better Exception Handling for Operators URL: https://github.com/apache/incubator-mxnet/pull/9681#discussion_r165725474 ## File path: include/mxnet/engine.h ## @@ -182,7 +182,7 @@ class MXNET_API Engine {

[GitHub] piiswrong commented on a change in pull request #9681: Better Exception Handling for Operators

2018-02-02 Thread GitBox
piiswrong commented on a change in pull request #9681: Better Exception Handling for Operators URL: https://github.com/apache/incubator-mxnet/pull/9681#discussion_r165731019 ## File path: src/storage/cpu_device_storage.h ## @@ -61,10 +61,10 @@ inline void*

[GitHub] piiswrong commented on a change in pull request #9681: Better Exception Handling for Operators

2018-02-02 Thread GitBox
piiswrong commented on a change in pull request #9681: Better Exception Handling for Operators URL: https://github.com/apache/incubator-mxnet/pull/9681#discussion_r165730863 ## File path: src/engine/threaded_engine.h ## @@ -338,33 +346,46 @@ class ThreadedEngine : public

[GitHub] piiswrong commented on a change in pull request #9688: bilinear upsample from PyTorch

2018-02-02 Thread GitBox
piiswrong commented on a change in pull request #9688: bilinear upsample from PyTorch URL: https://github.com/apache/incubator-mxnet/pull/9688#discussion_r165805994 ## File path: src/operator/bilinear_upsample.cc ## @@ -0,0 +1,185 @@ +/* + * Licensed to the Apache

[GitHub] piiswrong commented on a change in pull request #9688: bilinear upsample from PyTorch

2018-02-02 Thread GitBox
piiswrong commented on a change in pull request #9688: bilinear upsample from PyTorch URL: https://github.com/apache/incubator-mxnet/pull/9688#discussion_r165805994 ## File path: src/operator/bilinear_upsample.cc ## @@ -0,0 +1,185 @@ +/* + * Licensed to the Apache

[GitHub] piiswrong commented on a change in pull request #9688: bilinear upsample from PyTorch

2018-02-02 Thread GitBox
piiswrong commented on a change in pull request #9688: bilinear upsample from PyTorch URL: https://github.com/apache/incubator-mxnet/pull/9688#discussion_r165806013 ## File path: src/operator/bilinear_upsample.cc ## @@ -0,0 +1,185 @@ +/* + * Licensed to the Apache

[incubator-mxnet] branch master updated: Fix DataBatch.__str__ for cases where we don't have labels. (#9645)

2018-02-02 Thread zhasheng
This is an automated email from the ASF dual-hosted git repository. zhasheng pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-mxnet.git The following commit(s) were added to refs/heads/master by this push: new fe5b56e Fix DataBatch.__str__ for

[GitHub] szha closed pull request #9645: Fix DataBatch.__str__ for cases where we don't have labels.

2018-02-02 Thread GitBox
szha closed pull request #9645: Fix DataBatch.__str__ for cases where we don't have labels. URL: https://github.com/apache/incubator-mxnet/pull/9645 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance:

[GitHub] szha commented on a change in pull request #9671: Exp backoff for downloads.

2018-02-02 Thread GitBox
szha commented on a change in pull request #9671: Exp backoff for downloads. URL: https://github.com/apache/incubator-mxnet/pull/9671#discussion_r165807962 ## File path: python/mxnet/utils.py ## @@ -0,0 +1,151 @@ +# Licensed to the Apache Software Foundation (ASF) under

[GitHub] anirudh2290 commented on a change in pull request #9681: Better Exception Handling for Operators

2018-02-02 Thread GitBox
anirudh2290 commented on a change in pull request #9681: Better Exception Handling for Operators URL: https://github.com/apache/incubator-mxnet/pull/9681#discussion_r165774551 ## File path: src/engine/threaded_engine.h ## @@ -338,33 +346,46 @@ class ThreadedEngine :

[GitHub] anirudh2290 commented on a change in pull request #9681: Better Exception Handling for Operators

2018-02-02 Thread GitBox
anirudh2290 commented on a change in pull request #9681: Better Exception Handling for Operators URL: https://github.com/apache/incubator-mxnet/pull/9681#discussion_r165774834 ## File path: include/mxnet/engine.h ## @@ -182,7 +182,7 @@ class MXNET_API Engine {

[GitHub] anirudh2290 commented on a change in pull request #9681: Better Exception Handling for Operators

2018-02-02 Thread GitBox
anirudh2290 commented on a change in pull request #9681: Better Exception Handling for Operators URL: https://github.com/apache/incubator-mxnet/pull/9681#discussion_r165773582 ## File path: src/engine/threaded_engine.h ## @@ -175,6 +175,8 @@ class ThreadedVar final

[GitHub] zhreshold commented on a change in pull request #8582: Yolo2 operator

2018-02-02 Thread GitBox
zhreshold commented on a change in pull request #8582: Yolo2 operator URL: https://github.com/apache/incubator-mxnet/pull/8582#discussion_r165778530 ## File path: src/operator/contrib/yolo_output-inl.h ## @@ -0,0 +1,703 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] eric-haibin-lin commented on issue #9675: Add contrib.compute_accidental_hits operator for candidate sampling

2018-02-02 Thread GitBox
eric-haibin-lin commented on issue #9675: Add contrib.compute_accidental_hits operator for candidate sampling URL: https://github.com/apache/incubator-mxnet/pull/9675#issuecomment-362741701 Requires https://github.com/dmlc/mshadow/pull/324

[GitHub] chsin commented on issue #9647: Gluon in Core API

2018-02-02 Thread GitBox
chsin commented on issue #9647: Gluon in Core API URL: https://github.com/apache/incubator-mxnet/issues/9647#issuecomment-362746458 I would also like more attention on the C/C++ API. Most of the focus has been on Python, which results in the other supported languages being overlooked to

[GitHub] DickJC123 commented on issue #9674: Fix test_sparse_operator failures due to out-of-bounds ref.

2018-02-02 Thread GitBox
DickJC123 commented on issue #9674: Fix test_sparse_operator failures due to out-of-bounds ref. URL: https://github.com/apache/incubator-mxnet/pull/9674#issuecomment-362760136 To prove that the prior code referenced uninitialized data, substitute the following 4 lines for the single line

[GitHub] zhanghang1989 commented on a change in pull request #7938: instance norm and reflection padding

2018-02-02 Thread GitBox
zhanghang1989 commented on a change in pull request #7938: instance norm and reflection padding URL: https://github.com/apache/incubator-mxnet/pull/7938#discussion_r165799668 ## File path: python/mxnet/gluon/nn/basic_layers.py ## @@ -480,6 +480,88 @@ def __repr__(self):

[GitHub] zhanghang1989 commented on a change in pull request #7938: instance norm and reflection padding

2018-02-02 Thread GitBox
zhanghang1989 commented on a change in pull request #7938: instance norm and reflection padding URL: https://github.com/apache/incubator-mxnet/pull/7938#discussion_r165799668 ## File path: python/mxnet/gluon/nn/basic_layers.py ## @@ -480,6 +480,88 @@ def __repr__(self):

[GitHub] reminisce commented on issue #9552: [REQUEST FOR REVIEW | DO NOT MERGE] Model Quantization with Calibration

2018-02-02 Thread GitBox
reminisce commented on issue #9552: [REQUEST FOR REVIEW | DO NOT MERGE] Model Quantization with Calibration URL: https://github.com/apache/incubator-mxnet/pull/9552#issuecomment-362742835 @marcoabreu It looks like the cuDNN version (5.0) is too low for building quantization

[GitHub] anirudh2290 commented on a change in pull request #9681: Better Exception Handling for Operators

2018-02-02 Thread GitBox
anirudh2290 commented on a change in pull request #9681: Better Exception Handling for Operators URL: https://github.com/apache/incubator-mxnet/pull/9681#discussion_r165792490 ## File path: src/engine/threaded_engine.cc ## @@ -391,6 +400,11 @@ void

[GitHub] szha commented on issue #8427: Bug: ThreadedEnginePerDevice: speed variation with mixed Mxnet API and Amalgamation API

2018-02-02 Thread GitBox
szha commented on issue #8427: Bug: ThreadedEnginePerDevice: speed variation with mixed Mxnet API and Amalgamation API URL: https://github.com/apache/incubator-mxnet/issues/8427#issuecomment-362750470 @apache/mxnet-committers: This issue has been inactive for the past 90 days. It has no

[GitHub] szha commented on issue #8424: windows binaries

2018-02-02 Thread GitBox
szha commented on issue #8424: windows binaries URL: https://github.com/apache/incubator-mxnet/issues/8424#issuecomment-362750466 @apache/mxnet-committers: This issue has been inactive for the past 90 days. It has no label and needs triage. For general "how-to" questions, our

[GitHub] szha commented on issue #8530: Fatal JVM Error due to Exception in CustomOpProp#inferTypeEntry

2018-02-02 Thread GitBox
szha commented on issue #8530: Fatal JVM Error due to Exception in CustomOpProp#inferTypeEntry URL: https://github.com/apache/incubator-mxnet/issues/8530#issuecomment-362750469 @apache/mxnet-committers: This issue has been inactive for the past 90 days. It has no label and needs triage.

[GitHub] zhanghang1989 commented on issue #9138: I cannot make mxnet.ndarray.UpSampling work with bilinear interpolation

2018-02-02 Thread GitBox
zhanghang1989 commented on issue #9138: I cannot make mxnet.ndarray.UpSampling work with bilinear interpolation URL: https://github.com/apache/incubator-mxnet/issues/9138#issuecomment-362766186 Thanks @feevos! A new bilinear upsample operator is coming in the PR

[GitHub] zhanghang1989 opened a new pull request #9688: bilinear upsample from PyTorch

2018-02-02 Thread GitBox
zhanghang1989 opened a new pull request #9688: bilinear upsample from PyTorch URL: https://github.com/apache/incubator-mxnet/pull/9688 ## Description ## Add an operator of bilinear upsample. Also provide a convenient interface for converting code from PyTorch in `device-tensor.h`.

[GitHub] anirudh2290 commented on a change in pull request #9681: Better Exception Handling for Operators

2018-02-02 Thread GitBox
anirudh2290 commented on a change in pull request #9681: Better Exception Handling for Operators URL: https://github.com/apache/incubator-mxnet/pull/9681#discussion_r165772898 ## File path: src/engine/threaded_engine.cc ## @@ -403,7 +417,11 @@ inline void

[GitHub] anirudh2290 commented on a change in pull request #9681: Better Exception Handling for Operators

2018-02-02 Thread GitBox
anirudh2290 commented on a change in pull request #9681: Better Exception Handling for Operators URL: https://github.com/apache/incubator-mxnet/pull/9681#discussion_r165772820 ## File path: src/engine/threaded_engine.cc ## @@ -391,6 +400,11 @@ void

[GitHub] anirudh2290 commented on a change in pull request #9681: Better Exception Handling for Operators

2018-02-02 Thread GitBox
anirudh2290 commented on a change in pull request #9681: Better Exception Handling for Operators URL: https://github.com/apache/incubator-mxnet/pull/9681#discussion_r165773086 ## File path: src/engine/threaded_engine.cc ## @@ -403,7 +417,11 @@ inline void

[GitHub] anirudh2290 commented on a change in pull request #9681: Better Exception Handling for Operators

2018-02-02 Thread GitBox
anirudh2290 commented on a change in pull request #9681: Better Exception Handling for Operators URL: https://github.com/apache/incubator-mxnet/pull/9681#discussion_r165773869 ## File path: src/engine/threaded_engine.h ## @@ -338,33 +346,46 @@ class ThreadedEngine :

[GitHub] anirudh2290 commented on a change in pull request #9681: Better Exception Handling for Operators

2018-02-02 Thread GitBox
anirudh2290 commented on a change in pull request #9681: Better Exception Handling for Operators URL: https://github.com/apache/incubator-mxnet/pull/9681#discussion_r165774874 ## File path: tests/python/unittest/test_exc_handling.py ## @@ -0,0 +1,112 @@ +# Licensed to the

[GitHub] anirudh2290 commented on a change in pull request #9681: Better Exception Handling for Operators

2018-02-02 Thread GitBox
anirudh2290 commented on a change in pull request #9681: Better Exception Handling for Operators URL: https://github.com/apache/incubator-mxnet/pull/9681#discussion_r165775147 ## File path: src/storage/gpu_device_storage.h ## @@ -62,7 +62,7 @@ inline void*

  1   2   >