[GitHub] rahul003 commented on a change in pull request #9933: Adding support to profile kvstore server during distributed training

2018-03-01 Thread GitBox
rahul003 commented on a change in pull request #9933: Adding support to profile kvstore server during distributed training URL: https://github.com/apache/incubator-mxnet/pull/9933#discussion_r171483669 ## File path: src/kvstore/kvstore_dist_server.h ## @@ -159,6 +163,19

[GitHub] rahul003 commented on a change in pull request #9933: Adding support to profile kvstore server during distributed training

2018-03-01 Thread GitBox
rahul003 commented on a change in pull request #9933: Adding support to profile kvstore server during distributed training URL: https://github.com/apache/incubator-mxnet/pull/9933#discussion_r171484328 ## File path: src/kvstore/kvstore_dist_server.h ## @@ -170,6 +187,33

[GitHub] rahul003 commented on a change in pull request #9933: Adding support to profile kvstore server during distributed training

2018-03-01 Thread GitBox
rahul003 commented on a change in pull request #9933: Adding support to profile kvstore server during distributed training URL: https://github.com/apache/incubator-mxnet/pull/9933#discussion_r171484625 ## File path: src/kvstore/kvstore_dist_server.h ## @@ -170,6 +187,33

[GitHub] rahul003 commented on a change in pull request #9933: Adding support to profile kvstore server during distributed training

2018-03-01 Thread GitBox
rahul003 commented on a change in pull request #9933: Adding support to profile kvstore server during distributed training URL: https://github.com/apache/incubator-mxnet/pull/9933#discussion_r171484371 ## File path: src/kvstore/kvstore_dist_server.h ## @@ -170,6 +187,33

[GitHub] eric-haibin-lin commented on a change in pull request #9887: Non-blocking row_sparse_pull

2018-03-01 Thread GitBox
eric-haibin-lin commented on a change in pull request #9887: Non-blocking row_sparse_pull URL: https://github.com/apache/incubator-mxnet/pull/9887#discussion_r171483977 ## File path: src/kvstore/kvstore_dist.h ## @@ -279,24 +279,20 @@ class KVStoreDist : public

[GitHub] rahul003 commented on a change in pull request #9933: Adding support to profile kvstore server during distributed training

2018-03-01 Thread GitBox
rahul003 commented on a change in pull request #9933: Adding support to profile kvstore server during distributed training URL: https://github.com/apache/incubator-mxnet/pull/9933#discussion_r171484354 ## File path: src/kvstore/kvstore_dist_server.h ## @@ -170,6 +187,33

[GitHub] rahul003 commented on a change in pull request #9933: Adding support to profile kvstore server during distributed training

2018-03-01 Thread GitBox
rahul003 commented on a change in pull request #9933: Adding support to profile kvstore server during distributed training URL: https://github.com/apache/incubator-mxnet/pull/9933#discussion_r171481290 ## File path: src/kvstore/kvstore_dist_server.h ## @@ -125,6 +127,7 @@

[GitHub] rahul003 commented on a change in pull request #9933: Adding support to profile kvstore server during distributed training

2018-03-01 Thread GitBox
rahul003 commented on a change in pull request #9933: Adding support to profile kvstore server during distributed training URL: https://github.com/apache/incubator-mxnet/pull/9933#discussion_r171484625 ## File path: src/kvstore/kvstore_dist_server.h ## @@ -170,6 +187,33

[GitHub] rahul003 commented on a change in pull request #9933: Adding support to profile kvstore server during distributed training

2018-03-01 Thread GitBox
rahul003 commented on a change in pull request #9933: Adding support to profile kvstore server during distributed training URL: https://github.com/apache/incubator-mxnet/pull/9933#discussion_r171483655 ## File path: src/kvstore/kvstore_dist.h ## @@ -92,6 +92,14 @@ class

[GitHub] rahul003 commented on a change in pull request #9933: Adding support to profile kvstore server during distributed training

2018-03-01 Thread GitBox
rahul003 commented on a change in pull request #9933: Adding support to profile kvstore server during distributed training URL: https://github.com/apache/incubator-mxnet/pull/9933#discussion_r171484371 ## File path: src/kvstore/kvstore_dist_server.h ## @@ -170,6 +187,33

[GitHub] rahul003 commented on a change in pull request #9933: Adding support to profile kvstore server during distributed training

2018-03-01 Thread GitBox
rahul003 commented on a change in pull request #9933: Adding support to profile kvstore server during distributed training URL: https://github.com/apache/incubator-mxnet/pull/9933#discussion_r171483611 ## File path: include/mxnet/c_api.h ## @@ -2005,6 +2005,16 @@

[GitHub] rahul003 commented on a change in pull request #9933: Adding support to profile kvstore server during distributed training

2018-03-01 Thread GitBox
rahul003 commented on a change in pull request #9933: Adding support to profile kvstore server during distributed training URL: https://github.com/apache/incubator-mxnet/pull/9933#discussion_r171483991 ## File path: src/kvstore/kvstore_dist_server.h ## @@ -170,6 +187,33

[GitHub] rahul003 commented on issue #9933: Adding support to profile kvstore server during distributed training

2018-03-01 Thread GitBox
rahul003 commented on issue #9933: Adding support to profile kvstore server during distributed training URL: https://github.com/apache/incubator-mxnet/pull/9933#issuecomment-369509785 Thanks for your comments Chris This is

[GitHub] rahul003 commented on a change in pull request #9933: Adding support to profile kvstore server during distributed training

2018-03-01 Thread GitBox
rahul003 commented on a change in pull request #9933: Adding support to profile kvstore server during distributed training URL: https://github.com/apache/incubator-mxnet/pull/9933#discussion_r171485730 ## File path: src/kvstore/kvstore_dist_server.h ## @@ -170,6 +187,33

[GitHub] eric-haibin-lin commented on issue #9651: Improve sparse adagrad update

2018-03-01 Thread GitBox
eric-haibin-lin commented on issue #9651: Improve sparse adagrad update URL: https://github.com/apache/incubator-mxnet/pull/9651#issuecomment-369512187 Hi everyone, Considering the `wd` term is implemented inconsistently in many other optimizers (see

[GitHub] rahul003 commented on a change in pull request #9932: Fixing couple of bugs in profiler

2018-03-01 Thread GitBox
rahul003 commented on a change in pull request #9932: Fixing couple of bugs in profiler URL: https://github.com/apache/incubator-mxnet/pull/9932#discussion_r171491867 ## File path: src/profiler/profiler.h ## @@ -131,8 +131,9 @@ struct ProfileStat { size_t process_id_ =

[GitHub] rahul003 commented on a change in pull request #9932: Fixing couple of bugs in profiler

2018-03-01 Thread GitBox
rahul003 commented on a change in pull request #9932: Fixing couple of bugs in profiler URL: https://github.com/apache/incubator-mxnet/pull/9932#discussion_r171491842 ## File path: src/profiler/profiler.h ## @@ -131,8 +131,9 @@ struct ProfileStat { size_t process_id_ =

[GitHub] rahul003 commented on a change in pull request #9932: Fixing couple of bugs in profiler

2018-03-01 Thread GitBox
rahul003 commented on a change in pull request #9932: Fixing couple of bugs in profiler URL: https://github.com/apache/incubator-mxnet/pull/9932#discussion_r171491867 ## File path: src/profiler/profiler.h ## @@ -131,8 +131,9 @@ struct ProfileStat { size_t process_id_ =

[GitHub] rahul003 commented on a change in pull request #9887: Non-blocking row_sparse_pull

2018-03-01 Thread GitBox
rahul003 commented on a change in pull request #9887: Non-blocking row_sparse_pull URL: https://github.com/apache/incubator-mxnet/pull/9887#discussion_r171509114 ## File path: src/kvstore/kvstore_utils.cc ## @@ -28,15 +28,18 @@ namespace mxnet { namespace kvstore { -

[GitHub] XiaotaoChen commented on issue #9611: program can't finished normally in dist_sync mode

2018-03-01 Thread GitBox
XiaotaoChen commented on issue #9611: program can't finished normally in dist_sync mode URL: https://github.com/apache/incubator-mxnet/issues/9611#issuecomment-369552199 And then, how to solve the problem that the total iteration of each worker is different in the current version?

[GitHub] rahul003 commented on a change in pull request #9933: Adding support to profile kvstore server during distributed training

2018-03-01 Thread GitBox
rahul003 commented on a change in pull request #9933: Adding support to profile kvstore server during distributed training URL: https://github.com/apache/incubator-mxnet/pull/9933#discussion_r171483611 ## File path: include/mxnet/c_api.h ## @@ -2005,6 +2005,16 @@

[GitHub] rahul003 commented on a change in pull request #9933: Adding support to profile kvstore server during distributed training

2018-03-01 Thread GitBox
rahul003 commented on a change in pull request #9933: Adding support to profile kvstore server during distributed training URL: https://github.com/apache/incubator-mxnet/pull/9933#discussion_r171484354 ## File path: src/kvstore/kvstore_dist_server.h ## @@ -170,6 +187,33

[GitHub] rahul003 commented on a change in pull request #9933: Adding support to profile kvstore server during distributed training

2018-03-01 Thread GitBox
rahul003 commented on a change in pull request #9933: Adding support to profile kvstore server during distributed training URL: https://github.com/apache/incubator-mxnet/pull/9933#discussion_r171481290 ## File path: src/kvstore/kvstore_dist_server.h ## @@ -125,6 +127,7 @@

[GitHub] eric-haibin-lin commented on issue #9887: Non-blocking row_sparse_pull

2018-03-01 Thread GitBox
eric-haibin-lin commented on issue #9887: Non-blocking row_sparse_pull URL: https://github.com/apache/incubator-mxnet/pull/9887#issuecomment-369508992 @reminisce could you help review? This is an automated message from the

[GitHub] rahul003 commented on a change in pull request #9933: Adding support to profile kvstore server during distributed training

2018-03-01 Thread GitBox
rahul003 commented on a change in pull request #9933: Adding support to profile kvstore server during distributed training URL: https://github.com/apache/incubator-mxnet/pull/9933#discussion_r171483991 ## File path: src/kvstore/kvstore_dist_server.h ## @@ -170,6 +187,33

[GitHub] rahul003 commented on a change in pull request #9933: Adding support to profile kvstore server during distributed training

2018-03-01 Thread GitBox
rahul003 commented on a change in pull request #9933: Adding support to profile kvstore server during distributed training URL: https://github.com/apache/incubator-mxnet/pull/9933#discussion_r171484328 ## File path: src/kvstore/kvstore_dist_server.h ## @@ -170,6 +187,33

[GitHub] rahul003 commented on a change in pull request #9933: Adding support to profile kvstore server during distributed training

2018-03-01 Thread GitBox
rahul003 commented on a change in pull request #9933: Adding support to profile kvstore server during distributed training URL: https://github.com/apache/incubator-mxnet/pull/9933#discussion_r171483655 ## File path: src/kvstore/kvstore_dist.h ## @@ -92,6 +92,14 @@ class

[GitHub] rahul003 commented on a change in pull request #9933: Adding support to profile kvstore server during distributed training

2018-03-01 Thread GitBox
rahul003 commented on a change in pull request #9933: Adding support to profile kvstore server during distributed training URL: https://github.com/apache/incubator-mxnet/pull/9933#discussion_r171483669 ## File path: src/kvstore/kvstore_dist_server.h ## @@ -159,6 +163,19

[GitHub] pengzhao-intel commented on issue #9862: Fix a race condition in converting data layouts in MKLDNN.

2018-03-01 Thread GitBox
pengzhao-intel commented on issue #9862: Fix a race condition in converting data layouts in MKLDNN. URL: https://github.com/apache/incubator-mxnet/pull/9862#issuecomment-369549769 The testing is done. There is **NO** coverage and performance regression issue from our tests. I think the

[GitHub] rahul003 commented on a change in pull request #9933: Adding support to profile kvstore server during distributed training

2018-03-01 Thread GitBox
rahul003 commented on a change in pull request #9933: Adding support to profile kvstore server during distributed training URL: https://github.com/apache/incubator-mxnet/pull/9933#discussion_r171485618 ## File path: src/kvstore/kvstore_dist_server.h ## @@ -170,6 +187,33

[GitHub] rahul003 commented on a change in pull request #9933: Adding support to profile kvstore server during distributed training

2018-03-01 Thread GitBox
rahul003 commented on a change in pull request #9933: Adding support to profile kvstore server during distributed training URL: https://github.com/apache/incubator-mxnet/pull/9933#discussion_r171485687 ## File path: src/kvstore/kvstore_dist_server.h ## @@ -170,6 +187,33

[GitHub] rahul003 commented on a change in pull request #9933: Adding support to profile kvstore server during distributed training

2018-03-01 Thread GitBox
rahul003 commented on a change in pull request #9933: Adding support to profile kvstore server during distributed training URL: https://github.com/apache/incubator-mxnet/pull/9933#discussion_r171485657 ## File path: src/kvstore/kvstore_dist_server.h ## @@ -170,6 +187,33

[GitHub] eric-haibin-lin commented on issue #9921: [DISCUSSION] module.contrib.SparseModule API

2018-03-01 Thread GitBox
eric-haibin-lin commented on issue #9921: [DISCUSSION] module.contrib.SparseModule API URL: https://github.com/apache/incubator-mxnet/issues/9921#issuecomment-369513724 Hi @anirudh2290 Thanks for the comments!! 1. My intention for the following code is that

[GitHub] rahul003 commented on a change in pull request #9933: Adding support to profile kvstore server during distributed training

2018-03-01 Thread GitBox
rahul003 commented on a change in pull request #9933: Adding support to profile kvstore server during distributed training URL: https://github.com/apache/incubator-mxnet/pull/9933#discussion_r171485409 ## File path: src/kvstore/kvstore_dist.h ## @@ -92,6 +92,14 @@ class

[GitHub] rahul003 commented on a change in pull request #9933: Adding support to profile kvstore server during distributed training

2018-03-01 Thread GitBox
rahul003 commented on a change in pull request #9933: Adding support to profile kvstore server during distributed training URL: https://github.com/apache/incubator-mxnet/pull/9933#discussion_r171485428 ## File path: src/kvstore/kvstore_dist_server.h ## @@ -159,6 +163,19

[GitHub] rahul003 commented on a change in pull request #9933: Adding support to profile kvstore server during distributed training

2018-03-01 Thread GitBox
rahul003 commented on a change in pull request #9933: Adding support to profile kvstore server during distributed training URL: https://github.com/apache/incubator-mxnet/pull/9933#discussion_r171485393 ## File path: src/kvstore/kvstore_dist_server.h ## @@ -202,12 +203,12

[GitHub] rahul003 commented on a change in pull request #9933: Adding support to profile kvstore server during distributed training

2018-03-01 Thread GitBox
rahul003 commented on a change in pull request #9933: Adding support to profile kvstore server during distributed training URL: https://github.com/apache/incubator-mxnet/pull/9933#discussion_r171485319 ## File path: include/mxnet/c_api.h ## @@ -2005,6 +2005,16 @@

[GitHub] phizaz commented on issue #7653: ipython, The kernel appears to have died. It will restart automatically.

2018-03-01 Thread GitBox
phizaz commented on issue #7653: ipython, The kernel appears to have died. It will restart automatically. URL: https://github.com/apache/incubator-mxnet/issues/7653#issuecomment-369537980 Using `np.float16` causes it to die. ``` import mxnet as mx import numpy as np x

[GitHub] eric-haibin-lin commented on issue #9919: Update PR Template

2018-03-01 Thread GitBox
eric-haibin-lin commented on issue #9919: Update PR Template URL: https://github.com/apache/incubator-mxnet/pull/9919#issuecomment-369508658 +1 on sheng's comment This is an automated message from the Apache Git Service. To

[GitHub] feiyuvl commented on issue #9611: program can't finished normally in dist_sync mode

2018-03-01 Thread GitBox
feiyuvl commented on issue #9611: program can't finished normally in dist_sync mode URL: https://github.com/apache/incubator-mxnet/issues/9611#issuecomment-369529615 @XiaotaoChen sorry, mxnet has removed the epoch-size arg, which only exists in old version

[GitHub] marcoabreu closed issue #9820: Flaky test_gluon_model_zoo_gpu.test_training @ Python3: MKLDNN-GPU

2018-03-01 Thread GitBox
marcoabreu closed issue #9820: Flaky test_gluon_model_zoo_gpu.test_training @ Python3: MKLDNN-GPU URL: https://github.com/apache/incubator-mxnet/issues/9820 This is an automated message from the Apache Git Service. To

[GitHub] ZiyueHuang opened a new pull request #9942: add SameType as default type inference function in imperative mode

2018-03-01 Thread GitBox
ZiyueHuang opened a new pull request #9942: add SameType as default type inference function in imperative mode URL: https://github.com/apache/incubator-mxnet/pull/9942 ## Description ## Add SameType as default type inference function in imperative mode (this is the same way in symbolic

[GitHub] lebeg commented on issue #9646: Android build broken

2018-03-01 Thread GitBox
lebeg commented on issue #9646: Android build broken URL: https://github.com/apache/incubator-mxnet/issues/9646#issuecomment-369585556 The android build is fixed. This is an automated message from the Apache Git Service. To

[GitHub] lebeg closed issue #9646: Android build broken

2018-03-01 Thread GitBox
lebeg closed issue #9646: Android build broken URL: https://github.com/apache/incubator-mxnet/issues/9646 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the

[GitHub] iblis17 commented on issue #8727: jenkins: julia build script

2018-03-01 Thread GitBox
iblis17 commented on issue #8727: jenkins: julia build script URL: https://github.com/apache/incubator-mxnet/pull/8727#issuecomment-369611903 > As for documents, sphinx might work but there might be some extra work to make the dynamically generated doc work. Also I see a much less

[GitHub] lebeg commented on issue #9919: Update PR Template

2018-03-01 Thread GitBox
lebeg commented on issue #9919: Update PR Template URL: https://github.com/apache/incubator-mxnet/pull/9919#issuecomment-369590607 Could we add a note that not applicable items should be removed from the description? It's sometimes hard to see the actual message between the default text

[GitHub] qingyuanxingsi opened a new issue #9944: MXNet MinGW-w64 build error

2018-03-01 Thread GitBox
qingyuanxingsi opened a new issue #9944: MXNet MinGW-w64 build error URL: https://github.com/apache/incubator-mxnet/issues/9944 ## Description Trying to build mxnet cpp package in Windows 7 using MinGW-w64, meeting following error. ## Environment info (Required) Windows 7

[GitHub] lebeg commented on a change in pull request #9943: [Don't MERGE] CI 2.0, revamp ci scripts and dockerfiles, integrate IoT builds

2018-03-01 Thread GitBox
lebeg commented on a change in pull request #9943: [Don't MERGE] CI 2.0, revamp ci scripts and dockerfiles, integrate IoT builds URL: https://github.com/apache/incubator-mxnet/pull/9943#discussion_r171567030 ## File path: ci/build_functions.sh ## @@ -0,0 +1,254 @@

[GitHub] lebeg commented on a change in pull request #9943: [Don't MERGE] CI 2.0, revamp ci scripts and dockerfiles, integrate IoT builds

2018-03-01 Thread GitBox
lebeg commented on a change in pull request #9943: [Don't MERGE] CI 2.0, revamp ci scripts and dockerfiles, integrate IoT builds URL: https://github.com/apache/incubator-mxnet/pull/9943#discussion_r171564247 ## File path: ci/build.py ## @@ -0,0 +1,181 @@ +#!/usr/bin/env

[GitHub] lebeg commented on a change in pull request #9943: [Don't MERGE] CI 2.0, revamp ci scripts and dockerfiles, integrate IoT builds

2018-03-01 Thread GitBox
lebeg commented on a change in pull request #9943: [Don't MERGE] CI 2.0, revamp ci scripts and dockerfiles, integrate IoT builds URL: https://github.com/apache/incubator-mxnet/pull/9943#discussion_r171566271 ## File path: ci/build.py ## @@ -0,0 +1,181 @@ +#!/usr/bin/env

[GitHub] lebeg commented on a change in pull request #9943: [Don't MERGE] CI 2.0, revamp ci scripts and dockerfiles, integrate IoT builds

2018-03-01 Thread GitBox
lebeg commented on a change in pull request #9943: [Don't MERGE] CI 2.0, revamp ci scripts and dockerfiles, integrate IoT builds URL: https://github.com/apache/incubator-mxnet/pull/9943#discussion_r171568102 ## File path: ci/build_functions.sh ## @@ -0,0 +1,254 @@

[GitHub] lebeg commented on a change in pull request #9943: [Don't MERGE] CI 2.0, revamp ci scripts and dockerfiles, integrate IoT builds

2018-03-01 Thread GitBox
lebeg commented on a change in pull request #9943: [Don't MERGE] CI 2.0, revamp ci scripts and dockerfiles, integrate IoT builds URL: https://github.com/apache/incubator-mxnet/pull/9943#discussion_r171565134 ## File path: ci/build.py ## @@ -0,0 +1,181 @@ +#!/usr/bin/env

[GitHub] lebeg commented on a change in pull request #9943: [Don't MERGE] CI 2.0, revamp ci scripts and dockerfiles, integrate IoT builds

2018-03-01 Thread GitBox
lebeg commented on a change in pull request #9943: [Don't MERGE] CI 2.0, revamp ci scripts and dockerfiles, integrate IoT builds URL: https://github.com/apache/incubator-mxnet/pull/9943#discussion_r171564876 ## File path: ci/build.py ## @@ -0,0 +1,181 @@ +#!/usr/bin/env

[GitHub] marcoabreu commented on issue #9820: Flaky test_gluon_model_zoo_gpu.test_training @ Python3: MKLDNN-GPU

2018-03-01 Thread GitBox
marcoabreu commented on issue #9820: Flaky test_gluon_model_zoo_gpu.test_training @ Python3: MKLDNN-GPU URL: https://github.com/apache/incubator-mxnet/issues/9820#issuecomment-369555218 Fixed as of #9862 This is an

[GitHub] wkcn commented on a change in pull request #9939: add multi proposal operator (cpu version) and fix the bug in proposal op (gpu version)

2018-03-01 Thread GitBox
wkcn commented on a change in pull request #9939: add multi proposal operator (cpu version) and fix the bug in proposal op (gpu version) URL: https://github.com/apache/incubator-mxnet/pull/9939#discussion_r171544927 ## File path: src/operator/contrib/proposal.cu ## @@

[GitHub] edmBernard commented on issue #9646: Android build broken

2018-03-01 Thread GitBox
edmBernard commented on issue #9646: Android build broken URL: https://github.com/apache/incubator-mxnet/issues/9646#issuecomment-369587385 cool This is an automated message from the Apache Git Service. To respond to the

[GitHub] eric-haibin-lin commented on a change in pull request #9887: Non-blocking row_sparse_pull

2018-03-01 Thread GitBox
eric-haibin-lin commented on a change in pull request #9887: Non-blocking row_sparse_pull URL: https://github.com/apache/incubator-mxnet/pull/9887#discussion_r171536218 ## File path: src/kvstore/kvstore_utils.cc ## @@ -28,15 +28,18 @@ namespace mxnet { namespace

[GitHub] wkcn commented on a change in pull request #9939: add multi proposal operator (cpu version) and fix the bug in proposal op (gpu version)

2018-03-01 Thread GitBox
wkcn commented on a change in pull request #9939: add multi proposal operator (cpu version) and fix the bug in proposal op (gpu version) URL: https://github.com/apache/incubator-mxnet/pull/9939#discussion_r171544927 ## File path: src/operator/contrib/proposal.cu ## @@

[GitHub] XiaotaoChen opened a new issue #9941: how to set epoch_size for distributed training in the current version?

2018-03-01 Thread GitBox
XiaotaoChen opened a new issue #9941: how to set epoch_size for distributed training in the current version? URL: https://github.com/apache/incubator-mxnet/issues/9941 [this docs](http://newdocs.readthedocs.io/en/latest/distributed_training.html) says it's better to set epoch_size

[incubator-mxnet] branch master updated: Fix a race condition in converting data layouts in MKLDNN. (#9862)

2018-03-01 Thread marcoabreu
This is an automated email from the ASF dual-hosted git repository. marcoabreu pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-mxnet.git The following commit(s) were added to refs/heads/master by this push: new f9c2689 Fix a race condition in

[GitHub] marcoabreu commented on issue #9862: Fix a race condition in converting data layouts in MKLDNN.

2018-03-01 Thread GitBox
marcoabreu commented on issue #9862: Fix a race condition in converting data layouts in MKLDNN. URL: https://github.com/apache/incubator-mxnet/pull/9862#issuecomment-369555038 Thanks a lot everybody! This is an automated

[GitHub] feiyuvl commented on issue #9911: The different between rescale_grad on optimizer and normalization in loss layer.

2018-03-01 Thread GitBox
feiyuvl commented on issue #9911: The different between rescale_grad on optimizer and normalization in loss layer. URL: https://github.com/apache/incubator-mxnet/issues/9911#issuecomment-369562599 Yes? it will rescale twice

[GitHub] juliusshufan commented on issue #9862: Fix a race condition in converting data layouts in MKLDNN.

2018-03-01 Thread GitBox
juliusshufan commented on issue #9862: Fix a race condition in converting data layouts in MKLDNN. URL: https://github.com/apache/incubator-mxnet/pull/9862#issuecomment-369564041 Update the inference perf comparison, a slight drop on ResNet network, no outstanding changes on other

[GitHub] juliusshufan commented on issue #9862: Fix a race condition in converting data layouts in MKLDNN.

2018-03-01 Thread GitBox
juliusshufan commented on issue #9862: Fix a race condition in converting data layouts in MKLDNN. URL: https://github.com/apache/incubator-mxnet/pull/9862#issuecomment-369564041 Update the inference perf comparison, a slight drop on ResNet network, no outstanding changes on other

[GitHub] ZiyueHuang commented on a change in pull request #9939: add multi proposal operator (cpu version) and fix the bug in proposal op (gpu version)

2018-03-01 Thread GitBox
ZiyueHuang commented on a change in pull request #9939: add multi proposal operator (cpu version) and fix the bug in proposal op (gpu version) URL: https://github.com/apache/incubator-mxnet/pull/9939#discussion_r171543450 ## File path: src/operator/contrib/proposal.cu ##

[GitHub] lebeg commented on issue #8917: Build using android.arm64 android.armv7 dockers fails, while arm64 and arm7 dockers work

2018-03-01 Thread GitBox
lebeg commented on issue #8917: Build using android.arm64 android.armv7 dockers fails, while arm64 and arm7 dockers work URL: https://github.com/apache/incubator-mxnet/issues/8917#issuecomment-369585284 The build should be stable now.

[GitHub] larroy opened a new pull request #9943: [Don't MERGE] CI 2.0, revamp ci scripts and dockerfiles, integrate IoT builds

2018-03-01 Thread GitBox
larroy opened a new pull request #9943: [Don't MERGE] CI 2.0, revamp ci scripts and dockerfiles, integrate IoT builds URL: https://github.com/apache/incubator-mxnet/pull/9943 ## Description ## ## Checklist ## ### Essentials ### - [ ] Passed code style checking (`make lint`)

[GitHub] wkcn commented on a change in pull request #9939: add multi proposal operator (cpu version) and fix the bug in proposal op (gpu version)

2018-03-01 Thread GitBox
wkcn commented on a change in pull request #9939: add multi proposal operator (cpu version) and fix the bug in proposal op (gpu version) URL: https://github.com/apache/incubator-mxnet/pull/9939#discussion_r171544927 ## File path: src/operator/contrib/proposal.cu ## @@

[GitHub] lebeg commented on issue #9859: How to run model trained with mxnet 1.0 on android

2018-03-01 Thread GitBox
lebeg commented on issue #9859: How to run model trained with mxnet 1.0 on android URL: https://github.com/apache/incubator-mxnet/issues/9859#issuecomment-369586279 The Android build should be fixed now, so you could build and use the latest version.

[GitHub] edmBernard commented on issue #9646: Android build broken

2018-03-01 Thread GitBox
edmBernard commented on issue #9646: Android build broken URL: https://github.com/apache/incubator-mxnet/issues/9646#issuecomment-369587385 cool This is an automated message from the Apache Git Service. To respond to the

[GitHub] cjolivier01 commented on a change in pull request #9799: Cleaned up image classification cpp example

2018-03-01 Thread GitBox
cjolivier01 commented on a change in pull request #9799: Cleaned up image classification cpp example URL: https://github.com/apache/incubator-mxnet/pull/9799#discussion_r171591209 ## File path: example/image-classification/predict-cpp/CMakeLists.txt ## @@ -1,34 +1,28 @@

[GitHub] cjolivier01 closed pull request #9923: Removed MXNET_USE_MKLDNN definition when option USE_MKLDNN is disabled

2018-03-01 Thread GitBox
cjolivier01 closed pull request #9923: Removed MXNET_USE_MKLDNN definition when option USE_MKLDNN is disabled URL: https://github.com/apache/incubator-mxnet/pull/9923 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the

[GitHub] cjolivier01 commented on issue #9799: Cleaned up image classification cpp example

2018-03-01 Thread GitBox
cjolivier01 commented on issue #9799: Cleaned up image classification cpp example URL: https://github.com/apache/incubator-mxnet/pull/9799#issuecomment-369625751 Can you please summarize the "cleaning up" items in the description? It's a little hard to follow what the added value is from

[GitHub] marcoabreu commented on a change in pull request #9943: [Don't MERGE] CI 2.0, revamp ci scripts and dockerfiles, integrate IoT builds

2018-03-01 Thread GitBox
marcoabreu commented on a change in pull request #9943: [Don't MERGE] CI 2.0, revamp ci scripts and dockerfiles, integrate IoT builds URL: https://github.com/apache/incubator-mxnet/pull/9943#discussion_r171594544 ## File path: ci/build.py ## @@ -0,0 +1,181 @@

[GitHub] marcoabreu commented on a change in pull request #9943: [Don't MERGE] CI 2.0, revamp ci scripts and dockerfiles, integrate IoT builds

2018-03-01 Thread GitBox
marcoabreu commented on a change in pull request #9943: [Don't MERGE] CI 2.0, revamp ci scripts and dockerfiles, integrate IoT builds URL: https://github.com/apache/incubator-mxnet/pull/9943#discussion_r171600359 ## File path: ci/build.py ## @@ -0,0 +1,181 @@

[GitHub] cjolivier01 commented on a change in pull request #9799: Cleaned up image classification cpp example

2018-03-01 Thread GitBox
cjolivier01 commented on a change in pull request #9799: Cleaned up image classification cpp example URL: https://github.com/apache/incubator-mxnet/pull/9799#discussion_r171613189 ## File path: example/image-classification/predict-cpp/CMakeLists.txt ## @@ -1,34 +1,28 @@

[GitHub] cjolivier01 commented on issue #9940: remove set CMAKE_GENERATOR_TOOLSET

2018-03-01 Thread GitBox
cjolivier01 commented on issue #9940: remove set CMAKE_GENERATOR_TOOLSET URL: https://github.com/apache/incubator-mxnet/pull/9940#issuecomment-369640999 now tim build with CUDA, you must specify a -T option? This is an

[GitHub] marcoabreu opened a new pull request #9946: [DO NOT MERGE] Start CI docker revamp

2018-03-01 Thread GitBox
marcoabreu opened a new pull request #9946: [DO NOT MERGE] Start CI docker revamp URL: https://github.com/apache/incubator-mxnet/pull/9946 TODO This is an automated message from the Apache Git Service. To respond to the

[GitHub] marcoabreu commented on issue #9943: [Don't MERGE] CI 2.0, revamp ci scripts and dockerfiles, integrate IoT builds

2018-03-01 Thread GitBox
marcoabreu commented on issue #9943: [Don't MERGE] CI 2.0, revamp ci scripts and dockerfiles, integrate IoT builds URL: https://github.com/apache/incubator-mxnet/pull/9943#issuecomment-369641900 I created a new PR at https://github.com/apache/incubator-mxnet/pull/9946 as I don't have

[GitHub] cjolivier01 commented on issue #9940: remove set CMAKE_GENERATOR_TOOLSET

2018-03-01 Thread GitBox
cjolivier01 commented on issue #9940: remove set CMAKE_GENERATOR_TOOLSET URL: https://github.com/apache/incubator-mxnet/pull/9940#issuecomment-369641097 to build* This is an automated message from the Apache Git Service. To

[GitHub] cjolivier01 commented on issue #9940: remove set CMAKE_GENERATOR_TOOLSET

2018-03-01 Thread GitBox
cjolivier01 commented on issue #9940: remove set CMAKE_GENERATOR_TOOLSET URL: https://github.com/apache/incubator-mxnet/pull/9940#issuecomment-369640999 now to build with CUDA, you must specify a -T option? This is an

[GitHub] cjolivier01 commented on issue #9918: Update mkldnn to the newest & Add clang build test with mkldnn.

2018-03-01 Thread GitBox
cjolivier01 commented on issue #9918: Update mkldnn to the newest & Add clang build test with mkldnn. URL: https://github.com/apache/incubator-mxnet/pull/9918#issuecomment-369645660 Does this add two more full builds to CI? How does that affect CI performance? What's the reasoning for

[GitHub] cjolivier01 commented on issue #9799: Cleaned up image classification cpp example

2018-03-01 Thread GitBox
cjolivier01 commented on issue #9799: Cleaned up image classification cpp example URL: https://github.com/apache/incubator-mxnet/pull/9799#issuecomment-369649887 Also, is this used in any of the unit tests or nightly tests? If not, probably we should be running at least one test with it.

[GitHub] lebeg commented on issue #9799: Cleaned up image classification cpp example

2018-03-01 Thread GitBox
lebeg commented on issue #9799: Cleaned up image classification cpp example URL: https://github.com/apache/incubator-mxnet/pull/9799#issuecomment-369650992 @cjolivier01 for now this is not tested on ci, but I will ingerate this as the base for valgrind memcheck tests

[GitHub] huyangc commented on issue #9911: The different between rescale_grad on optimizer and normalization in loss layer.

2018-03-01 Thread GitBox
huyangc commented on issue #9911: The different between rescale_grad on optimizer and normalization in loss layer. URL: https://github.com/apache/incubator-mxnet/issues/9911#issuecomment-369616680 orz, if so, I think it is a little hard to just rescale some specific layers' gradient.

[GitHub] eric-haibin-lin opened a new issue #9945: Improve dot(csr, row_sparse) on CPU

2018-03-01 Thread GitBox
eric-haibin-lin opened a new issue #9945: Improve dot(csr, row_sparse) on CPU URL: https://github.com/apache/incubator-mxnet/issues/9945 The following benchmark results shows that dot(csr, row_sparse) is slow when non-zeros spread out (credit to Saswata) ### Setup * instance

[GitHub] marcoabreu commented on a change in pull request #9943: [Don't MERGE] CI 2.0, revamp ci scripts and dockerfiles, integrate IoT builds

2018-03-01 Thread GitBox
marcoabreu commented on a change in pull request #9943: [Don't MERGE] CI 2.0, revamp ci scripts and dockerfiles, integrate IoT builds URL: https://github.com/apache/incubator-mxnet/pull/9943#discussion_r171604671 ## File path: ci/build_functions.sh ## @@ -0,0 +1,254 @@

[GitHub] ZiyueHuang commented on issue #9945: Improve dot(csr, row_sparse) on CPU

2018-03-01 Thread GitBox
ZiyueHuang commented on issue #9945: Improve dot(csr, row_sparse) on CPU URL: https://github.com/apache/incubator-mxnet/issues/9945#issuecomment-369637978 working on it This is an automated message from the Apache Git

[GitHub] KishoreKarunakaran commented on issue #9938: mxnet installation issue on Win 10 - module gluon.data.dataset has no attribute DownloadedDataset

2018-03-01 Thread GitBox
KishoreKarunakaran commented on issue #9938: mxnet installation issue on Win 10 - module gluon.data.dataset has no attribute DownloadedDataset URL: https://github.com/apache/incubator-mxnet/issues/9938#issuecomment-369622883 I fixed it by first uninstalling current mxnet packages and

[GitHub] KishoreKarunakaran commented on issue #8671: Discussion and troubleshooting on PyPI (pip) installation

2018-03-01 Thread GitBox
KishoreKarunakaran commented on issue #8671: Discussion and troubleshooting on PyPI (pip) installation URL: https://github.com/apache/incubator-mxnet/issues/8671#issuecomment-369623389 @szha when can we get cu91 for win ?

[GitHub] KishoreKarunakaran closed issue #9938: mxnet installation issue on Win 10 - module gluon.data.dataset has no attribute DownloadedDataset

2018-03-01 Thread GitBox
KishoreKarunakaran closed issue #9938: mxnet installation issue on Win 10 - module gluon.data.dataset has no attribute DownloadedDataset URL: https://github.com/apache/incubator-mxnet/issues/9938 This is an automated

[GitHub] cjolivier01 commented on a change in pull request #9799: Cleaned up image classification cpp example

2018-03-01 Thread GitBox
cjolivier01 commented on a change in pull request #9799: Cleaned up image classification cpp example URL: https://github.com/apache/incubator-mxnet/pull/9799#discussion_r171591500 ## File path: example/image-classification/predict-cpp/image-classification-predict.cc ##

[incubator-mxnet] branch master updated: Removed MXNET_USE_MKLDNN definition when option USE_MKLDNN is disabled (#9923)

2018-03-01 Thread cjolivier01
This is an automated email from the ASF dual-hosted git repository. cjolivier01 pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-mxnet.git The following commit(s) were added to refs/heads/master by this push: new 40da6cc Removed MXNET_USE_MKLDNN

[GitHub] lebeg commented on a change in pull request #9799: Cleaned up image classification cpp example

2018-03-01 Thread GitBox
lebeg commented on a change in pull request #9799: Cleaned up image classification cpp example URL: https://github.com/apache/incubator-mxnet/pull/9799#discussion_r171600623 ## File path: example/image-classification/predict-cpp/image-classification-predict.cc ## @@

[GitHub] marcoabreu commented on a change in pull request #9943: [Don't MERGE] CI 2.0, revamp ci scripts and dockerfiles, integrate IoT builds

2018-03-01 Thread GitBox
marcoabreu commented on a change in pull request #9943: [Don't MERGE] CI 2.0, revamp ci scripts and dockerfiles, integrate IoT builds URL: https://github.com/apache/incubator-mxnet/pull/9943#discussion_r171605100 ## File path: ci/build_functions.sh ## @@ -0,0 +1,254 @@

[GitHub] cjolivier01 commented on a change in pull request #9932: Fixing couple of bugs in profiler

2018-03-01 Thread GitBox
cjolivier01 commented on a change in pull request #9932: Fixing couple of bugs in profiler URL: https://github.com/apache/incubator-mxnet/pull/9932#discussion_r171709894 ## File path: src/profiler/profiler.h ## @@ -131,8 +131,9 @@ struct ProfileStat { size_t

[GitHub] rahul003 opened a new pull request #9953: add clarifications for environment variables

2018-03-01 Thread GitBox
rahul003 opened a new pull request #9953: add clarifications for environment variables URL: https://github.com/apache/incubator-mxnet/pull/9953 ## Description ## Doc changes ## Checklist ## ### Essentials ### - [ ] Passed code style checking (`make lint`) - [ ] Changes

[GitHub] szha commented on a change in pull request #9934: [Gluon] Support variable sequence length in gluon.RecurrentCell

2018-03-01 Thread GitBox
szha commented on a change in pull request #9934: [Gluon] Support variable sequence length in gluon.RecurrentCell URL: https://github.com/apache/incubator-mxnet/pull/9934#discussion_r171707307 ## File path: python/mxnet/gluon/rnn/rnn_cell.py ## @@ -83,15 +83,28 @@ def

[GitHub] aaronmarkham opened a new issue #9949: Mac build from source script validation fails

2018-03-01 Thread GitBox
aaronmarkham opened a new issue #9949: Mac build from source script validation fails URL: https://github.com/apache/incubator-mxnet/issues/9949 ## Description The installation instructions for Mac, refer you to this script:

[GitHub] marcoabreu commented on issue #9932: Fixing couple of bugs in profiler

2018-03-01 Thread GitBox
marcoabreu commented on issue #9932: Fixing couple of bugs in profiler URL: https://github.com/apache/incubator-mxnet/pull/9932#issuecomment-369739888 Yes it's flaky unfortunately. Please just push a new commit to trigger CI

  1   2   3   >