[GitHub] cjolivier01 commented on issue #10078: [MXNET-92] Support float16 in L2Normalization operator

2018-03-13 Thread GitBox
cjolivier01 commented on issue #10078: [MXNET-92] Support float16 in L2Normalization operator URL: https://github.com/apache/incubator-mxnet/pull/10078#issuecomment-372773464 JIRA: https://issues.apache.org/jira/browse/MXNET-92

[GitHub] yzhliu commented on a change in pull request #9678: [MXNET-50] Scala Inference APIs

2018-03-13 Thread GitBox
yzhliu commented on a change in pull request #9678: [MXNET-50] Scala Inference APIs URL: https://github.com/apache/incubator-mxnet/pull/9678#discussion_r174244994 ## File path: scala-package/infer/src/main/scala/ml/dmlc/mxnet/infer/Predictor.scala ## @@ -0,0 +1,188 @@

[GitHub] szha closed issue #9865: Confusing behavior of some evaluation metrics

2018-03-13 Thread GitBox
szha closed issue #9865: Confusing behavior of some evaluation metrics URL: https://github.com/apache/incubator-mxnet/issues/9865 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] yzhliu commented on a change in pull request #9678: [MXNET-50] Scala Inference APIs

2018-03-13 Thread GitBox
yzhliu commented on a change in pull request #9678: [MXNET-50] Scala Inference APIs URL: https://github.com/apache/incubator-mxnet/pull/9678#discussion_r174241847 ## File path: scala-package/infer/src/main/scala/ml/dmlc/mxnet/infer/Classifier.scala ## @@ -0,0 +1,167 @@

[incubator-mxnet] branch master updated: Support single array input for metric (#9930)

2018-03-13 Thread zhasheng
This is an automated email from the ASF dual-hosted git repository. zhasheng pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-mxnet.git The following commit(s) were added to refs/heads/master by this push: new dd1f21b Support single array input

[GitHub] szha closed pull request #9930: Support single array input for metric

2018-03-13 Thread GitBox
szha closed pull request #9930: Support single array input for metric URL: https://github.com/apache/incubator-mxnet/pull/9930 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign

[GitHub] yzhliu commented on a change in pull request #9678: [MXNET-50] Scala Inference APIs

2018-03-13 Thread GitBox
yzhliu commented on a change in pull request #9678: [MXNET-50] Scala Inference APIs URL: https://github.com/apache/incubator-mxnet/pull/9678#discussion_r174218503 ## File path: scala-package/infer/src/main/scala/ml/dmlc/mxnet/infer/Classifier.scala ## @@ -0,0 +1,167 @@

[GitHub] nswamy commented on a change in pull request #9678: [MXNET-50] Scala Inference APIs

2018-03-13 Thread GitBox
nswamy commented on a change in pull request #9678: [MXNET-50] Scala Inference APIs URL: https://github.com/apache/incubator-mxnet/pull/9678#discussion_r174247041 ## File path: scala-package/infer/src/main/scala/ml/dmlc/mxnet/infer/Classifier.scala ## @@ -0,0 +1,167 @@

[GitHub] anirudh2290 commented on a change in pull request #10078: [MXNET-92] Support float16 in L2Normalization operator

2018-03-13 Thread GitBox
anirudh2290 commented on a change in pull request #10078: [MXNET-92] Support float16 in L2Normalization operator URL: https://github.com/apache/incubator-mxnet/pull/10078#discussion_r174246995 ## File path: tests/python/unittest/test_operator.py ## @@ -2396,21 +2396,22 @@

[GitHub] anirudh2290 commented on a change in pull request #10081: [MXNET-82] [WIP] Sparse op tutorial for developers

2018-03-13 Thread GitBox
anirudh2290 commented on a change in pull request #10081: [MXNET-82] [WIP] Sparse op tutorial for developers URL: https://github.com/apache/incubator-mxnet/pull/10081#discussion_r174248908 ## File path: docs/how_to/add_sparse_op_in_backend.md ## @@ -0,0 +1,457 @@ +# TODO

[GitHub] reminisce commented on a change in pull request #10078: Support float16 in L2Normalization operator

2018-03-13 Thread GitBox
reminisce commented on a change in pull request #10078: Support float16 in L2Normalization operator URL: https://github.com/apache/incubator-mxnet/pull/10078#discussion_r174235637 ## File path: src/operator/l2_normalization-inl.h ## @@ -235,6 +247,19 @@ class

[GitHub] robbig2871 opened a new issue #10088: can not install

2018-03-13 Thread GitBox
robbig2871 opened a new issue #10088: can not install URL: https://github.com/apache/incubator-mxnet/issues/10088 > cran <- getOption("repos") > cran["dmlc"] <- "https://apache-mxnet.s3-accelerate.dualstack.amazonaws.com/R/CRAN/; > options(repos = cran) > install.packages("mxnet")

[GitHub] cjolivier01 commented on issue #9996: add softsign operator to v1.1.0

2018-03-13 Thread GitBox
cjolivier01 commented on issue #9996: add softsign operator to v1.1.0 URL: https://github.com/apache/incubator-mxnet/pull/9996#issuecomment-372775775 I have no idea. I just see an open PR without a JIRA. This is an automated

[GitHub] yzhliu commented on a change in pull request #9678: [MXNET-50] Scala Inference APIs

2018-03-13 Thread GitBox
yzhliu commented on a change in pull request #9678: [MXNET-50] Scala Inference APIs URL: https://github.com/apache/incubator-mxnet/pull/9678#discussion_r174218993 ## File path: scala-package/infer/src/main/scala/ml/dmlc/mxnet/infer/Classifier.scala ## @@ -0,0 +1,167 @@

[GitHub] cjolivier01 commented on a change in pull request #10078: [MXNET-92] Support float16 in L2Normalization operator

2018-03-13 Thread GitBox
cjolivier01 commented on a change in pull request #10078: [MXNET-92] Support float16 in L2Normalization operator URL: https://github.com/apache/incubator-mxnet/pull/10078#discussion_r174248453 ## File path: src/operator/l2_normalization.cc ## @@ -26,13 +26,22 @@

[GitHub] cjolivier01 commented on issue #10042: [MXNET-86] Gluon dataloader crash on speech recognition training

2018-03-13 Thread GitBox
cjolivier01 commented on issue #10042: [MXNET-86] Gluon dataloader crash on speech recognition training URL: https://github.com/apache/incubator-mxnet/issues/10042#issuecomment-372801771 This script just freezes for me without doing anything. In Connection._recv, it seems., What is it

[GitHub] cjolivier01 commented on issue #10042: [MXNET-86] Gluon dataloader crash on speech recognition training

2018-03-13 Thread GitBox
cjolivier01 commented on issue #10042: [MXNET-86] Gluon dataloader crash on speech recognition training URL: https://github.com/apache/incubator-mxnet/issues/10042#issuecomment-372804704 On which epoch/batch does it occur?

[GitHub] cjolivier01 commented on issue #10042: [MXNET-86] Gluon dataloader crash on speech recognition training

2018-03-13 Thread GitBox
cjolivier01 commented on issue #10042: [MXNET-86] Gluon dataloader crash on speech recognition training URL: https://github.com/apache/incubator-mxnet/issues/10042#issuecomment-372801771 This script just freezes for me without doing anything. In Connection._recv, it seems., What is it

[GitHub] cjolivier01 commented on issue #10042: [MXNET-86] Gluon dataloader crash on speech recognition training

2018-03-13 Thread GitBox
cjolivier01 commented on issue #10042: [MXNET-86] Gluon dataloader crash on speech recognition training URL: https://github.com/apache/incubator-mxnet/issues/10042#issuecomment-372804704 On which epoch/batch does it occur?

[GitHub] eric-haibin-lin commented on issue #10084: which optimizer to support sparse update except adam, ftrl, sgd?

2018-03-13 Thread GitBox
eric-haibin-lin commented on issue #10084: which optimizer to support sparse update except adam, ftrl, sgd? URL: https://github.com/apache/incubator-mxnet/issues/10084#issuecomment-372560412 Also sparse adagrad. Note that GPU optimizer performance can be further improved if applied with

[GitHub] KellenSunderland commented on issue #10075: Fix CMake build issue with MKL.

2018-03-13 Thread GitBox
KellenSunderland commented on issue #10075: Fix CMake build issue with MKL. URL: https://github.com/apache/incubator-mxnet/pull/10075#issuecomment-372569505 @pengzhao-intel Would also be great if you could review the PR. Does it look ok from you POV?

[GitHub] chinakook commented on issue #10085: Ordering operators do not support kNullOp

2018-03-13 Thread GitBox
chinakook commented on issue #10085: Ordering operators do not support kNullOp URL: https://github.com/apache/incubator-mxnet/issues/10085#issuecomment-372569521 @sxjscience thanks. This is an automated message from the

[GitHub] CoinCheung commented on issue #10000: [MXNET-80] Fix average pooling kernel size assignment error

2018-03-13 Thread GitBox
CoinCheung commented on issue #1: [MXNET-80] Fix average pooling kernel size assignment error URL: https://github.com/apache/incubator-mxnet/pull/1#issuecomment-372572675 @sxjscience But I did not see logic error in this function. From the printed error message, I see no

[GitHub] jinhuang415 commented on issue #9993: cmake cannot build mxnet

2018-03-13 Thread GitBox
jinhuang415 commented on issue #9993: cmake cannot build mxnet URL: https://github.com/apache/incubator-mxnet/issues/9993#issuecomment-372580279 @jacky4323 your issue should be the same with https://github.com/apache/incubator-mxnet/issues/10072, would you try to patch the related

[GitHub] pengzhao-intel commented on issue #8974: MXNET compatibility with MKL libraries bundled in Microsoft R Open

2018-03-13 Thread GitBox
pengzhao-intel commented on issue #8974: MXNET compatibility with MKL libraries bundled in Microsoft R Open URL: https://github.com/apache/incubator-mxnet/issues/8974#issuecomment-372562963 @mjmg The MKLML has been replaced by MKL-DNN. Could you try again?

[GitHub] chinakook opened a new issue #10085: Topk op cannot run!

2018-03-13 Thread GitBox
chinakook opened a new issue #10085: Topk op cannot run! URL: https://github.com/apache/incubator-mxnet/issues/10085 When testing ```python a = mx.sym.var("data", shape=(6,7,8)) adata= nd.random.uniform(shape=(6,7,8), ctx=mx.gpu(0)) _, inds = mx.sym.topk(a, axis=-1, k=5,

[GitHub] sxjscience commented on issue #10085: Ordering operators do not support kNullOp

2018-03-13 Thread GitBox
sxjscience commented on issue #10085: Ordering operators do not support kNullOp URL: https://github.com/apache/incubator-mxnet/issues/10085#issuecomment-372565456 @chinakook You can get both values using the following code: ```python values, inds = mx.sym.topk(a, axis=-1, k=5,

[GitHub] sxjscience commented on issue #10000: [MXNET-80] Fix average pooling kernel size assignment error

2018-03-13 Thread GitBox
sxjscience commented on issue #1: [MXNET-80] Fix average pooling kernel size assignment error URL: https://github.com/apache/incubator-mxnet/pull/1#issuecomment-372573233 I think it has not handled the case when kernel.ndim()=0 Get Outlook for iOS

[GitHub] moveforever commented on issue #10084: which optimizer to support sparse update except adam, ftrl, sgd?

2018-03-13 Thread GitBox
moveforever commented on issue #10084: which optimizer to support sparse update except adam, ftrl, sgd? URL: https://github.com/apache/incubator-mxnet/issues/10084#issuecomment-372557589 Just a question on what sparse optimizer was implemented, tks

[GitHub] pengzhao-intel commented on issue #8874: mxnet installation from source: C++ linkage error on HPC

2018-03-13 Thread GitBox
pengzhao-intel commented on issue #8874: mxnet installation from source: C++ linkage error on HPC URL: https://github.com/apache/incubator-mxnet/issues/8874#issuecomment-372561464 @jerrin92 does the issue resolved? This is

[GitHub] sxjscience commented on issue #10085: Ordering operators do not support kNullOp

2018-03-13 Thread GitBox
sxjscience commented on issue #10085: Ordering operators do not support kNullOp URL: https://github.com/apache/incubator-mxnet/issues/10085#issuecomment-372563598 The error also occurs in other ordering operators like Sort, ArgSort.

[GitHub] pengzhao-intel commented on issue #10075: Fix CMake build issue with MKL.

2018-03-13 Thread GitBox
pengzhao-intel commented on issue #10075: Fix CMake build issue with MKL. URL: https://github.com/apache/incubator-mxnet/pull/10075#issuecomment-372565487 > Not sure. At this point, I really don't know what's going on with the mkl build, what works with what, does mkldnn use mklml or mkl?

[GitHub] KellenSunderland commented on issue #10075: Fix CMake build issue with MKL.

2018-03-13 Thread GitBox
KellenSunderland commented on issue #10075: Fix CMake build issue with MKL. URL: https://github.com/apache/incubator-mxnet/pull/10075#issuecomment-372569505 @pengzhao-intel Would also be great if you could review the PR. Does it look ok from your point of view?

[GitHub] eric-haibin-lin commented on issue #10084: which optimizer to support sparse update except adam, ftrl, sgd?

2018-03-13 Thread GitBox
eric-haibin-lin commented on issue #10084: which optimizer to support sparse update except adam, ftrl, sgd? URL: https://github.com/apache/incubator-mxnet/issues/10084#issuecomment-372556099 Is it a question on what sparse optimizer was implemented, or what welcomes contribution?

[GitHub] reminisce commented on a change in pull request #9552: [REQUEST FOR REVIEW | DO NOT MERGE] Model Quantization with Calibration

2018-03-13 Thread GitBox
reminisce commented on a change in pull request #9552: [REQUEST FOR REVIEW | DO NOT MERGE] Model Quantization with Calibration URL: https://github.com/apache/incubator-mxnet/pull/9552#discussion_r174032235 ## File path: tests/ci_build/Dockerfile.build_cuda8_cudnn7 ## @@

[GitHub] pengzhao-intel commented on issue #8881: Intel MKL FATAL ERROR: Cannot load libmkl_avx512_mic.so or libmkl_def.so.

2018-03-13 Thread GitBox
pengzhao-intel commented on issue #8881: Intel MKL FATAL ERROR: Cannot load libmkl_avx512_mic.so or libmkl_def.so. URL: https://github.com/apache/incubator-mxnet/issues/8881#issuecomment-372562280 Resolved by #9112 and the mklml has been replaced by MKL-DNN. This should be closed.

[GitHub] sxjscience commented on issue #10000: [MXNET-80] Fix average pooling kernel size assignment error

2018-03-13 Thread GitBox
sxjscience commented on issue #1: [MXNET-80] Fix average pooling kernel size assignment error URL: https://github.com/apache/incubator-mxnet/pull/1#issuecomment-372566536 We may also need to revise the shape assignment logic:

[GitHub] pengzhao-intel commented on issue #8881: Intel MKL FATAL ERROR: Cannot load libmkl_avx512_mic.so or libmkl_def.so.

2018-03-13 Thread GitBox
pengzhao-intel commented on issue #8881: Intel MKL FATAL ERROR: Cannot load libmkl_avx512_mic.so or libmkl_def.so. URL: https://github.com/apache/incubator-mxnet/issues/8881#issuecomment-372562280 Resolved by #9112 and the mklml has been replaced by MKL-DNN. This should be closed.

[GitHub] sxjscience commented on issue #10085: Topk op cannot run!

2018-03-13 Thread GitBox
sxjscience commented on issue #10085: Topk op cannot run! URL: https://github.com/apache/incubator-mxnet/issues/10085#issuecomment-372562351 It's because the first argument is set as `_`, which gives `req[0]=kNullOp`. If you only needs the indices, a temporary workaround is to use `inds =

[GitHub] sxjscience commented on issue #10085: Ordering operators do not support kNullOp

2018-03-13 Thread GitBox
sxjscience commented on issue #10085: Ordering operators do not support kNullOp URL: https://github.com/apache/incubator-mxnet/issues/10085#issuecomment-372563935 @chinakook I'll fix it tomorrow. This is an automated message

[GitHub] chinakook commented on issue #10085: Ordering operators do not support kNullOp

2018-03-13 Thread GitBox
chinakook commented on issue #10085: Ordering operators do not support kNullOp URL: https://github.com/apache/incubator-mxnet/issues/10085#issuecomment-372564930 Yes, It's only support indices only. Thanks for your help!

[GitHub] jinhuang415 commented on issue #9993: cmake cannot build mxnet

2018-03-13 Thread GitBox
jinhuang415 commented on issue #9993: cmake cannot build mxnet URL: https://github.com/apache/incubator-mxnet/issues/9993#issuecomment-372580279 @jacky4323 your issue should be the same with https://github.com/apache/incubator-mxnet/issues/10072, would you try to patch the related PR in

[incubator-mxnet] branch master updated: Adding back comments to index.md that cause nightly test to fail (#10058)

2018-03-13 Thread jxie
This is an automated email from the ASF dual-hosted git repository. jxie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-mxnet.git The following commit(s) were added to refs/heads/master by this push: new 0bcf334 Adding back comments to

[GitHub] piiswrong commented on issue #10074: Add vocabulary and embedding

2018-03-13 Thread GitBox
piiswrong commented on issue #10074: Add vocabulary and embedding URL: https://github.com/apache/incubator-mxnet/pull/10074#issuecomment-372623377 This should be in gluon. If we put vocab and embedding in mxnet.text and textdataset in gluon it's going to be really confusing

[GitHub] piiswrong closed pull request #10058: Adding back comments to index.md that cause nightly test to fail

2018-03-13 Thread GitBox
piiswrong closed pull request #10058: Adding back comments to index.md that cause nightly test to fail URL: https://github.com/apache/incubator-mxnet/pull/10058 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[GitHub] marcoabreu commented on a change in pull request #9552: [REQUEST FOR REVIEW | DO NOT MERGE] Model Quantization with Calibration

2018-03-13 Thread GitBox
marcoabreu commented on a change in pull request #9552: [REQUEST FOR REVIEW | DO NOT MERGE] Model Quantization with Calibration URL: https://github.com/apache/incubator-mxnet/pull/9552#discussion_r174076331 ## File path: tests/ci_build/Dockerfile.build_cuda8_cudnn7 ## @@

[GitHub] marcoabreu commented on a change in pull request #9552: [REQUEST FOR REVIEW | DO NOT MERGE] Model Quantization with Calibration

2018-03-13 Thread GitBox
marcoabreu commented on a change in pull request #9552: [REQUEST FOR REVIEW | DO NOT MERGE] Model Quantization with Calibration URL: https://github.com/apache/incubator-mxnet/pull/9552#discussion_r174076331 ## File path: tests/ci_build/Dockerfile.build_cuda8_cudnn7 ## @@

[GitHub] piiswrong commented on a change in pull request #10078: Support float16 in L2Normalization operator

2018-03-13 Thread GitBox
piiswrong commented on a change in pull request #10078: Support float16 in L2Normalization operator URL: https://github.com/apache/incubator-mxnet/pull/10078#discussion_r174083179 ## File path: src/operator/l2_normalization.cc ## @@ -26,13 +26,22 @@ namespace mxnet {

[GitHub] AndreGuerra123 commented on issue #9967: Error in output.shape[[output.names]]

2018-03-13 Thread GitBox
AndreGuerra123 commented on issue #9967: Error in output.shape[[output.names]] URL: https://github.com/apache/incubator-mxnet/issues/9967#issuecomment-372597352 The number of observations is the same. (Edited above) What do you mean as a label passed as the y argument? I have a vector of

[GitHub] CoinCheung commented on issue #10000: [MXNET-80] Fix average pooling kernel size assignment error

2018-03-13 Thread GitBox
CoinCheung commented on issue #1: [MXNET-80] Fix average pooling kernel size assignment error URL: https://github.com/apache/incubator-mxnet/pull/1#issuecomment-372624274 I tried but failed. So what should be the correct behavior when kernel.ndim() is 0? @sxjscience

[GitHub] pengzhao-intel commented on issue #8532: mxnet-mkl (v0.12.0) crash when using (conda-installed) numpy with MKL

2018-03-13 Thread GitBox
pengzhao-intel commented on issue #8532: mxnet-mkl (v0.12.0) crash when using (conda-installed) numpy with MKL URL: https://github.com/apache/incubator-mxnet/issues/8532#issuecomment-372671112 @fhieber we have tried the latest release the problem is gone. Would you mind to try again?

[GitHub] pengzhao-intel commented on issue #8532: mxnet-mkl (v0.12.0) crash when using (conda-installed) numpy with MKL

2018-03-13 Thread GitBox
pengzhao-intel commented on issue #8532: mxnet-mkl (v0.12.0) crash when using (conda-installed) numpy with MKL URL: https://github.com/apache/incubator-mxnet/issues/8532#issuecomment-372671112 @fhieber we have tried the latest release the problem is gone. Would you mind to try again?

[GitHub] marcoabreu opened a new issue #10086: test_autograd.test_unary_func @ Python3: MKLDNN-CPU

2018-03-13 Thread GitBox
marcoabreu opened a new issue #10086: test_autograd.test_unary_func @ Python3: MKLDNN-CPU URL: https://github.com/apache/incubator-mxnet/issues/10086 http://jenkins.mxnet-ci.amazon-ml.com/blue/organizations/jenkins/incubator-mxnet/detail/master/474/pipeline/485/ ``` [INFO]

[GitHub] tqchen commented on issue #10083: [TENSOR] Fix DLTensor conversion for int64

2018-03-13 Thread GitBox
tqchen commented on issue #10083: [TENSOR] Fix DLTensor conversion for int64 URL: https://github.com/apache/incubator-mxnet/pull/10083#issuecomment-372718542 layer norm testcase is not related to changes introduced here. This

[GitHub] tqchen commented on issue #10083: [TENSOR] Fix DLTensor conversion for int64

2018-03-13 Thread GitBox
tqchen commented on issue #10083: [TENSOR] Fix DLTensor conversion for int64 URL: https://github.com/apache/incubator-mxnet/pull/10083#issuecomment-372719428 cc @sxjscience who introduces the test, here is the old error log

[GitHub] kobenaxie commented on a change in pull request #10074: Add vocabulary and embedding

2018-03-13 Thread GitBox
kobenaxie commented on a change in pull request #10074: Add vocabulary and embedding URL: https://github.com/apache/incubator-mxnet/pull/10074#discussion_r174160853 ## File path: python/mxnet/text/embedding.py ## @@ -38,8 +38,12 @@ def register(embedding_cls):

[GitHub] tqchen commented on issue #10083: [TENSOR] Fix DLTensor conversion for int64

2018-03-13 Thread GitBox
tqchen commented on issue #10083: [TENSOR] Fix DLTensor conversion for int64 URL: https://github.com/apache/incubator-mxnet/pull/10083#issuecomment-372719428 cc @sxjscience who introduces the test This is an automated message

[GitHub] marcoabreu commented on a change in pull request #9963: [MXNET-34] Onnx Module to import onnx models into mxnet

2018-03-13 Thread GitBox
marcoabreu commented on a change in pull request #9963: [MXNET-34] Onnx Module to import onnx models into mxnet URL: https://github.com/apache/incubator-mxnet/pull/9963#discussion_r174191440 ## File path: tests/python-pytest/onnx/onnx_test.py ## @@ -0,0 +1,138 @@ +#

[GitHub] marcoabreu commented on a change in pull request #9963: [MXNET-34] Onnx Module to import onnx models into mxnet

2018-03-13 Thread GitBox
marcoabreu commented on a change in pull request #9963: [MXNET-34] Onnx Module to import onnx models into mxnet URL: https://github.com/apache/incubator-mxnet/pull/9963#discussion_r174191587 ## File path: tests/python-pytest/onnx/onnx_test.py ## @@ -0,0 +1,138 @@ +#

[GitHub] haojin2 commented on a change in pull request #10078: Support float16 in L2Normalization operator

2018-03-13 Thread GitBox
haojin2 commented on a change in pull request #10078: Support float16 in L2Normalization operator URL: https://github.com/apache/incubator-mxnet/pull/10078#discussion_r174202873 ## File path: src/operator/l2_normalization.cc ## @@ -26,13 +26,22 @@ namespace mxnet {

[GitHub] marcoabreu commented on a change in pull request #9963: [MXNET-34] Onnx Module to import onnx models into mxnet

2018-03-13 Thread GitBox
marcoabreu commented on a change in pull request #9963: [MXNET-34] Onnx Module to import onnx models into mxnet URL: https://github.com/apache/incubator-mxnet/pull/9963#discussion_r174206407 ## File path: tests/python-pytest/onnx/onnx_test.py ## @@ -0,0 +1,133 @@ +#

[GitHub] marcoabreu commented on a change in pull request #9963: [MXNET-34] Onnx Module to import onnx models into mxnet

2018-03-13 Thread GitBox
marcoabreu commented on a change in pull request #9963: [MXNET-34] Onnx Module to import onnx models into mxnet URL: https://github.com/apache/incubator-mxnet/pull/9963#discussion_r174206700 ## File path: tests/python-pytest/onnx/onnx_test.py ## @@ -0,0 +1,133 @@ +#

[GitHub] sxjscience commented on issue #10083: [TENSOR] Fix DLTensor conversion for int64

2018-03-13 Thread GitBox
sxjscience commented on issue #10083: [TENSOR] Fix DLTensor conversion for int64 URL: https://github.com/apache/incubator-mxnet/pull/10083#issuecomment-372725480 I need to revise the gradient test of layer norm This is an

[GitHub] Jerryzcn commented on a change in pull request #10090: [MXNET-86] Revert to pre-profile-changes copy code

2018-03-13 Thread GitBox
Jerryzcn commented on a change in pull request #10090: [MXNET-86] Revert to pre-profile-changes copy code URL: https://github.com/apache/incubator-mxnet/pull/10090#discussion_r174306619 ## File path: tests/python/unittest/test_gluon_data.py ## @@ -112,6 +117,76 @@ def

[GitHub] cjolivier01 commented on a change in pull request #10090: [MXNET-86] Revert to pre-profile-changes copy code

2018-03-13 Thread GitBox
cjolivier01 commented on a change in pull request #10090: [MXNET-86] Revert to pre-profile-changes copy code URL: https://github.com/apache/incubator-mxnet/pull/10090#discussion_r174307840 ## File path: tests/python/unittest/test_gluon_data.py ## @@ -112,6 +117,76 @@ def

[GitHub] cjolivier01 commented on a change in pull request #8972: Profiling enhancements, python API, vtune and chrome tracing objects, etc.

2018-03-13 Thread GitBox
cjolivier01 commented on a change in pull request #8972: Profiling enhancements, python API, vtune and chrome tracing objects, etc. URL: https://github.com/apache/incubator-mxnet/pull/8972#discussion_r174309509 ## File path: python/mxnet/profiler.py ## @@ -35,13 +68,16 @@

[GitHub] rahul003 commented on issue #9916: precision bug in batchnorm.

2018-03-13 Thread GitBox
rahul003 commented on issue #9916: precision bug in batchnorm. URL: https://github.com/apache/incubator-mxnet/issues/9916#issuecomment-372847814 Relevant suggestion https://github.com/apache/incubator-mxnet/issues/8509 This

[GitHub] rahul003 commented on issue #9916: precision bug in batchnorm.

2018-03-13 Thread GitBox
rahul003 commented on issue #9916: precision bug in batchnorm. URL: https://github.com/apache/incubator-mxnet/issues/9916#issuecomment-372847814 Relevant comment https://github.com/apache/incubator-mxnet/issues/8509 This is

[GitHub] rahul003 commented on issue #8509: test_operator_gpu.py:test_batchnorm_with_type robustness

2018-03-13 Thread GitBox
rahul003 commented on issue #8509: test_operator_gpu.py:test_batchnorm_with_type robustness URL: https://github.com/apache/incubator-mxnet/issues/8509#issuecomment-372849471 That looks like something we can look into if similar issues persist. But for now, we believe this is because of

[GitHub] Roshrini commented on a change in pull request #9963: [MXNET-34] Onnx Module to import onnx models into mxnet

2018-03-13 Thread GitBox
Roshrini commented on a change in pull request #9963: [MXNET-34] Onnx Module to import onnx models into mxnet URL: https://github.com/apache/incubator-mxnet/pull/9963#discussion_r174315641 ## File path: python/mxnet/contrib/onnx/_import/import_helper.py ## @@ -0,0 +1,105

[GitHub] Roshrini commented on a change in pull request #9963: [MXNET-34] Onnx Module to import onnx models into mxnet

2018-03-13 Thread GitBox
Roshrini commented on a change in pull request #9963: [MXNET-34] Onnx Module to import onnx models into mxnet URL: https://github.com/apache/incubator-mxnet/pull/9963#discussion_r174316786 ## File path: python/mxnet/contrib/onnx/_import/import_model.py ## @@ -0,0 +1,46 @@

[GitHub] zheng-da opened a new pull request #10089: enable all activations in MKLDNN.

2018-03-13 Thread GitBox
zheng-da opened a new pull request #10089: enable all activations in MKLDNN. URL: https://github.com/apache/incubator-mxnet/pull/10089 ## Description ## Previously, some activation types in MKLDNN aren't used because there was a precision problem. This is to enable all activations

[GitHub] cjolivier01 commented on a change in pull request #10089: enable all activations in MKLDNN.

2018-03-13 Thread GitBox
cjolivier01 commented on a change in pull request #10089: enable all activations in MKLDNN. URL: https://github.com/apache/incubator-mxnet/pull/10089#discussion_r174294065 ## File path: src/operator/nn/mkldnn/mkldnn_act.cc ## @@ -45,11 +45,9 @@ namespace op { bool

[GitHub] cjolivier01 commented on a change in pull request #10090: [MXNET-86] Revert to pre-profile-changes copy code

2018-03-13 Thread GitBox
cjolivier01 commented on a change in pull request #10090: [MXNET-86] Revert to pre-profile-changes copy code URL: https://github.com/apache/incubator-mxnet/pull/10090#discussion_r174300231 ## File path: src/ndarray/ndarray_function.cc ## @@ -26,35 +26,24 @@ #include

[GitHub] cjolivier01 commented on a change in pull request #10090: [MXNET-86] Revert to pre-profile-changes copy code

2018-03-13 Thread GitBox
cjolivier01 commented on a change in pull request #10090: [MXNET-86] Revert to pre-profile-changes copy code URL: https://github.com/apache/incubator-mxnet/pull/10090#discussion_r174307193 ## File path: tests/python/unittest/test_gluon_data.py ## @@ -112,6 +117,76 @@ def

[GitHub] cjolivier01 commented on a change in pull request #10090: [MXNET-86] Revert to pre-profile-changes copy code

2018-03-13 Thread GitBox
cjolivier01 commented on a change in pull request #10090: [MXNET-86] Revert to pre-profile-changes copy code URL: https://github.com/apache/incubator-mxnet/pull/10090#discussion_r174307538 ## File path: src/ndarray/ndarray_function.cc ## @@ -26,35 +26,24 @@ #include

[GitHub] cjolivier01 commented on a change in pull request #10090: [MXNET-86] Revert to pre-profile-changes copy code

2018-03-13 Thread GitBox
cjolivier01 commented on a change in pull request #10090: [MXNET-86] Revert to pre-profile-changes copy code URL: https://github.com/apache/incubator-mxnet/pull/10090#discussion_r174307840 ## File path: tests/python/unittest/test_gluon_data.py ## @@ -112,6 +117,76 @@ def

[GitHub] sxjscience commented on a change in pull request #10090: [MXNET-86] Revert to pre-profile-changes copy code

2018-03-13 Thread GitBox
sxjscience commented on a change in pull request #10090: [MXNET-86] Revert to pre-profile-changes copy code URL: https://github.com/apache/incubator-mxnet/pull/10090#discussion_r174308148 ## File path: src/ndarray/ndarray_function.cc ## @@ -26,35 +26,24 @@ #include

[GitHub] eric-haibin-lin commented on a change in pull request #8972: Profiling enhancements, python API, vtune and chrome tracing objects, etc.

2018-03-13 Thread GitBox
eric-haibin-lin commented on a change in pull request #8972: Profiling enhancements, python API, vtune and chrome tracing objects, etc. URL: https://github.com/apache/incubator-mxnet/pull/8972#discussion_r174309219 ## File path: python/mxnet/profiler.py ## @@ -35,13

[GitHub] eric-haibin-lin commented on a change in pull request #8972: Profiling enhancements, python API, vtune and chrome tracing objects, etc.

2018-03-13 Thread GitBox
eric-haibin-lin commented on a change in pull request #8972: Profiling enhancements, python API, vtune and chrome tracing objects, etc. URL: https://github.com/apache/incubator-mxnet/pull/8972#discussion_r174309219 ## File path: python/mxnet/profiler.py ## @@ -35,13

[GitHub] sxjscience commented on issue #10085: Ordering operators do not support kNullOp

2018-03-13 Thread GitBox
sxjscience commented on issue #10085: Ordering operators do not support kNullOp URL: https://github.com/apache/incubator-mxnet/issues/10085#issuecomment-372845417 Sorry that I'm too busy with other stuffs. Can anyone help solve the bug? If not, I will solve it later.

[GitHub] rahul003 commented on issue #8529: What is the functionality of OrderMutation

2018-03-13 Thread GitBox
rahul003 commented on issue #8529: What is the functionality of OrderMutation URL: https://github.com/apache/incubator-mxnet/issues/8529#issuecomment-372847594 @eric-haibin-lin please add the labels Doc, Question This is an

[GitHub] marcoabreu commented on a change in pull request #10090: [MXNET-86] Revert to pre-profile-changes copy code

2018-03-13 Thread GitBox
marcoabreu commented on a change in pull request #10090: [MXNET-86] Revert to pre-profile-changes copy code URL: https://github.com/apache/incubator-mxnet/pull/10090#discussion_r174312690 ## File path: src/ndarray/ndarray_function.cc ## @@ -26,35 +26,24 @@ #include

[GitHub] reminisce opened a new pull request #10091: Add quadratic op for the tutorial of adding ops in backend

2018-03-13 Thread GitBox
reminisce opened a new pull request #10091: Add quadratic op for the tutorial of adding ops in backend URL: https://github.com/apache/incubator-mxnet/pull/10091 ## Description ## The operator `quadratic` is used as an example of this

[GitHub] marcoabreu commented on a change in pull request #10090: [MXNET-86] Revert to pre-profile-changes copy code

2018-03-13 Thread GitBox
marcoabreu commented on a change in pull request #10090: [MXNET-86] Revert to pre-profile-changes copy code URL: https://github.com/apache/incubator-mxnet/pull/10090#discussion_r174313685 ## File path: tests/python/unittest/test_gluon_data.py ## @@ -112,6 +117,76 @@ def

[GitHub] marcoabreu commented on a change in pull request #10090: [MXNET-86] Revert to pre-profile-changes copy code

2018-03-13 Thread GitBox
marcoabreu commented on a change in pull request #10090: [MXNET-86] Revert to pre-profile-changes copy code URL: https://github.com/apache/incubator-mxnet/pull/10090#discussion_r174314312 ## File path: tests/python/unittest/test_gluon_data.py ## @@ -112,6 +117,76 @@ def

[GitHub] marcoabreu commented on a change in pull request #10089: enable all activations in MKLDNN.

2018-03-13 Thread GitBox
marcoabreu commented on a change in pull request #10089: enable all activations in MKLDNN. URL: https://github.com/apache/incubator-mxnet/pull/10089#discussion_r174304740 ## File path: src/operator/nn/mkldnn/mkldnn_act.cc ## @@ -45,11 +45,9 @@ namespace op { bool

[GitHub] Roshrini commented on a change in pull request #9963: [MXNET-34] Onnx Module to import onnx models into mxnet

2018-03-13 Thread GitBox
Roshrini commented on a change in pull request #9963: [MXNET-34] Onnx Module to import onnx models into mxnet URL: https://github.com/apache/incubator-mxnet/pull/9963#discussion_r174317953 ## File path: python/mxnet/contrib/onnx/_import/import_helper.py ## @@ -0,0 +1,105

[GitHub] Roshrini commented on a change in pull request #9963: [MXNET-34] Onnx Module to import onnx models into mxnet

2018-03-13 Thread GitBox
Roshrini commented on a change in pull request #9963: [MXNET-34] Onnx Module to import onnx models into mxnet URL: https://github.com/apache/incubator-mxnet/pull/9963#discussion_r174316464 ## File path: python/mxnet/contrib/onnx/_import/import_model.py ## @@ -0,0 +1,46 @@

[GitHub] Jerryzcn commented on issue #10042: [MXNET-86] Gluon dataloader crash on speech recognition training

2018-03-13 Thread GitBox
Jerryzcn commented on issue #10042: [MXNET-86] Gluon dataloader crash on speech recognition training URL: https://github.com/apache/incubator-mxnet/issues/10042#issuecomment-372816606 The error output only happens when you train on the actual data. When you use the test script, it will

[GitHub] Jerryzcn commented on issue #10042: [MXNET-86] Gluon dataloader crash on speech recognition training

2018-03-13 Thread GitBox
Jerryzcn commented on issue #10042: [MXNET-86] Gluon dataloader crash on speech recognition training URL: https://github.com/apache/incubator-mxnet/issues/10042#issuecomment-372817360 there seems to be other issues as well, after training for 1 day or so i got segfault. This does not

[GitHub] sxjscience commented on issue #10042: [MXNET-86] Gluon dataloader crash on speech recognition training

2018-03-13 Thread GitBox
sxjscience commented on issue #10042: [MXNET-86] Gluon dataloader crash on speech recognition training URL: https://github.com/apache/incubator-mxnet/issues/10042#issuecomment-372817252 @cjolivier01 Before the commit it will not freeze and print the data.

[GitHub] sxjscience commented on issue #10042: [MXNET-86] Gluon dataloader crash on speech recognition training

2018-03-13 Thread GitBox
sxjscience commented on issue #10042: [MXNET-86] Gluon dataloader crash on speech recognition training URL: https://github.com/apache/incubator-mxnet/issues/10042#issuecomment-372817252 @cjolivier01 Before the commit it will not freeze and will print the data instead.

[GitHub] marcoabreu commented on a change in pull request #9928: host doc on s3

2018-03-13 Thread GitBox
marcoabreu commented on a change in pull request #9928: host doc on s3 URL: https://github.com/apache/incubator-mxnet/pull/9928#discussion_r174286591 ## File path: tests/ci_build/deploy/ci_deploy_doc.sh ## @@ -0,0 +1,35 @@ +#!/usr/bin/env bash + +# Licensed to the Apache

[GitHub] marcoabreu commented on issue #9919: Update PR Template

2018-03-13 Thread GitBox
marcoabreu commented on issue #9919: Update PR Template URL: https://github.com/apache/incubator-mxnet/pull/9919#issuecomment-372826823 Could we also add an item to remind people linking the JIRA issue? This is an automated

[GitHub] marcoabreu commented on issue #10089: enable all activations in MKLDNN.

2018-03-13 Thread GitBox
marcoabreu commented on issue #10089: enable all activations in MKLDNN. URL: https://github.com/apache/incubator-mxnet/pull/10089#issuecomment-372827762 How have the precision problems been resolved? Is there a test? This is

[GitHub] cjolivier01 commented on a change in pull request #10090: [MXNET-86] Revert to pre-profile-changes copy code

2018-03-13 Thread GitBox
cjolivier01 commented on a change in pull request #10090: [MXNET-86] Revert to pre-profile-changes copy code URL: https://github.com/apache/incubator-mxnet/pull/10090#discussion_r174295660 ## File path: src/ndarray/ndarray_function.cc ## @@ -26,35 +26,24 @@ #include

[GitHub] cjolivier01 commented on a change in pull request #10090: [MXNET-86] Revert to pre-profile-changes copy code

2018-03-13 Thread GitBox
cjolivier01 commented on a change in pull request #10090: [MXNET-86] Revert to pre-profile-changes copy code URL: https://github.com/apache/incubator-mxnet/pull/10090#discussion_r174295804 ## File path: src/ndarray/ndarray_function.cc ## @@ -26,35 +26,24 @@ #include

[GitHub] sxjscience commented on a change in pull request #10090: [MXNET-86] Revert to pre-profile-changes copy code

2018-03-13 Thread GitBox
sxjscience commented on a change in pull request #10090: [MXNET-86] Revert to pre-profile-changes copy code URL: https://github.com/apache/incubator-mxnet/pull/10090#discussion_r174296439 ## File path: src/ndarray/ndarray_function.cc ## @@ -26,35 +26,24 @@ #include

[GitHub] cjolivier01 commented on a change in pull request #10090: [MXNET-86] Revert to pre-profile-changes copy code

2018-03-13 Thread GitBox
cjolivier01 commented on a change in pull request #10090: [MXNET-86] Revert to pre-profile-changes copy code URL: https://github.com/apache/incubator-mxnet/pull/10090#discussion_r174300231 ## File path: src/ndarray/ndarray_function.cc ## @@ -26,35 +26,24 @@ #include

  1   2   3   >