[GitHub] anirudh2290 commented on issue #10545: Add NEWS and README

2018-04-16 Thread GitBox
anirudh2290 commented on issue #10545: Add NEWS and README URL: https://github.com/apache/incubator-mxnet/pull/10545#issuecomment-381691400 @KellenSunderland You raised a good point! Thanks. I have squashed all the README related changes into a single commit. I think this PR should now be

[GitHub] zheng-da commented on a change in pull request #10433: [MXNET-290] MKLDNN support for model quantization

2018-04-16 Thread GitBox
zheng-da commented on a change in pull request #10433: [MXNET-290] MKLDNN support for model quantization URL: https://github.com/apache/incubator-mxnet/pull/10433#discussion_r181830262 ## File path: ci/docker/runtime_functions.sh ## @@ -407,26 +405,28 @@

[GitHub] zheng-da commented on a change in pull request #10433: [MXNET-290] MKLDNN support for model quantization

2018-04-16 Thread GitBox
zheng-da commented on a change in pull request #10433: [MXNET-290] MKLDNN support for model quantization URL: https://github.com/apache/incubator-mxnet/pull/10433#discussion_r181830262 ## File path: ci/docker/runtime_functions.sh ## @@ -407,26 +405,28 @@

[GitHub] lebeg commented on issue #9940: [MXNET-46]remove set CMAKE_GENERATOR_TOOLSET

2018-04-16 Thread GitBox
lebeg commented on issue #9940: [MXNET-46]remove set CMAKE_GENERATOR_TOOLSET URL: https://github.com/apache/incubator-mxnet/pull/9940#issuecomment-381669082 I think this is indeed a very good change. I am sure that there are alternatives to hardcoding things into CMakeLists.txt with

[GitHub] lebeg commented on issue #10564: Simplified CUDA language detection in cmake

2018-04-16 Thread GitBox
lebeg commented on issue #10564: Simplified CUDA language detection in cmake URL: https://github.com/apache/incubator-mxnet/pull/10564#issuecomment-381675939 It seems that it's failing due to not picking up MSHADOW_USE_F16C on windows, which should be accoring to

[GitHub] marcoabreu commented on issue #10564: Simplified CUDA language detection in cmake

2018-04-16 Thread GitBox
marcoabreu commented on issue #10564: Simplified CUDA language detection in cmake URL: https://github.com/apache/incubator-mxnet/pull/10564#issuecomment-381685928 @lebeg I granted you the permission This is an automated

[GitHub] sbodenstein commented on issue #10553: Build error for OSX with CUDA support

2018-04-16 Thread GitBox
sbodenstein commented on issue #10553: Build error for OSX with CUDA support URL: https://github.com/apache/incubator-mxnet/issues/10553#issuecomment-381634695 Attached are my building log and config file. Running `echo $NVCC` after building returns empty. Its not defined.

[GitHub] sbodenstein commented on issue #10553: Build error for OSX with CUDA support

2018-04-16 Thread GitBox
sbodenstein commented on issue #10553: Build error for OSX with CUDA support URL: https://github.com/apache/incubator-mxnet/issues/10553#issuecomment-381634695 Attached are my build log and config file. Running `echo $NVCC` after building returns empty. Its not defined.

[GitHub] lebeg closed pull request #10561: Simplified CUDA language detection in cmake

2018-04-16 Thread GitBox
lebeg closed pull request #10561: Simplified CUDA language detection in cmake URL: https://github.com/apache/incubator-mxnet/pull/10561 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a

[GitHub] lebeg opened a new pull request #10564: Simplified CUDA language detection in cmake

2018-04-16 Thread GitBox
lebeg opened a new pull request #10564: Simplified CUDA language detection in cmake URL: https://github.com/apache/incubator-mxnet/pull/10564 ## Description ## The version checking of cmake was buggy and confusing. ## Checklist ## ### Essentials ### - [x] The PR title

[GitHub] sergeykolychev commented on a change in pull request #10555: MXNET-296 [Perl] Parity with Python Gluon Loss classes.

2018-04-16 Thread GitBox
sergeykolychev commented on a change in pull request #10555: MXNET-296 [Perl] Parity with Python Gluon Loss classes. URL: https://github.com/apache/incubator-mxnet/pull/10555#discussion_r181799668 ## File path: perl-package/AI-MXNet/lib/AI/MXNet/Gluon/Loss.pm ## @@ -75,19

[GitHub] CodingCat commented on a change in pull request #10462: [MXNET-62] add test against spark integration

2018-04-16 Thread GitBox
CodingCat commented on a change in pull request #10462: [MXNET-62] add test against spark integration URL: https://github.com/apache/incubator-mxnet/pull/10462#discussion_r181759639 ## File path: scala-package/spark/bin/run-mnist-example.sh ## @@ -72,8 +71,8 @@ fi

[GitHub] ShootingSpace closed issue #10527: Save best performance in save_params()

2018-04-16 Thread GitBox
ShootingSpace closed issue #10527: Save best performance in save_params() URL: https://github.com/apache/incubator-mxnet/issues/10527 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] KellenSunderland commented on issue #10553: Build error for OSX with CUDA support

2018-04-16 Thread GitBox
KellenSunderland commented on issue #10553: Build error for OSX with CUDA support URL: https://github.com/apache/incubator-mxnet/issues/10553#issuecomment-381604136 Hey @sbodenstein thanks for the report. I've just finished building locally and all seems well for me using the same

[GitHub] xinyu-intel commented on issue #10365: [MXNET-261]Update MKLDNN & Add CPP Test

2018-04-16 Thread GitBox
xinyu-intel commented on issue #10365: [MXNET-261]Update MKLDNN & Add CPP Test URL: https://github.com/apache/incubator-mxnet/pull/10365#issuecomment-381584456 @nihui Can you please help double check base on the following code in incubator-mxnet/tests/python/unittest/test_operator.py:

[GitHub] marcoabreu commented on a change in pull request #10555: MXNET-296 [Perl] Parity with Python Gluon Loss classes.

2018-04-16 Thread GitBox
marcoabreu commented on a change in pull request #10555: MXNET-296 [Perl] Parity with Python Gluon Loss classes. URL: https://github.com/apache/incubator-mxnet/pull/10555#discussion_r181695218 ## File path: perl-package/AI-MXNet/lib/AI/MXNet/Gluon/Loss.pm ## @@ -75,19

[GitHub] KellenSunderland commented on issue #10553: Build error for OSX with CUDA support

2018-04-16 Thread GitBox
KellenSunderland commented on issue #10553: Build error for OSX with CUDA support URL: https://github.com/apache/incubator-mxnet/issues/10553#issuecomment-381562435 Taking a look ... This is an automated message from the

[GitHub] marcoabreu commented on issue #10545: Add NEWS and README

2018-04-16 Thread GitBox
marcoabreu commented on issue #10545: Add NEWS and README URL: https://github.com/apache/incubator-mxnet/pull/10545#issuecomment-381568599 I'd be in favour of the second approach. The news get squashed and merged and the backports get rebased and merged.

[GitHub] xinyu-intel commented on issue #10365: [MXNET-261]Update MKLDNN & Add CPP Test

2018-04-16 Thread GitBox
xinyu-intel commented on issue #10365: [MXNET-261]Update MKLDNN & Add CPP Test URL: https://github.com/apache/incubator-mxnet/pull/10365#issuecomment-381584456 @nihui Can you please help double check base on the following code: ``` dev = default_context()

[GitHub] marcoabreu commented on issue #10553: Build error for OSX with CUDA support

2018-04-16 Thread GitBox
marcoabreu commented on issue #10553: Build error for OSX with CUDA support URL: https://github.com/apache/incubator-mxnet/issues/10553#issuecomment-381561599 https://github.com/apache/incubator-mxnet/commit/0fd29698a11c0c77180aefdcf8264e063158a2c0 @KellenSunderland

[GitHub] FoConrad opened a new issue #10563: Suboptimal performance implementing PPO with Adam Optimizer

2018-04-16 Thread GitBox
FoConrad opened a new issue #10563: Suboptimal performance implementing PPO with Adam Optimizer URL: https://github.com/apache/incubator-mxnet/issues/10563 ## Description We noticed our gluon/MXNet [Proximal Policy Optimization](https://arxiv.org/abs/1707.06347) (PPO) implementation

[GitHub] ThomasDelteil commented on issue #10528: [MXNET-316] Remove empty buckets causing index errors

2018-04-16 Thread GitBox
ThomasDelteil commented on issue #10528: [MXNET-316] Remove empty buckets causing index errors URL: https://github.com/apache/incubator-mxnet/pull/10528#issuecomment-381716212 Thanks @harusametime ! I do not have merge rights. So if I understand correctly you modified the test so that

[GitHub] ThomasDelteil opened a new pull request #10565: [MXNET-307] Add utility to get im2rec.py path

2018-04-16 Thread GitBox
ThomasDelteil opened a new pull request #10565: [MXNET-307] Add utility to get im2rec.py path URL: https://github.com/apache/incubator-mxnet/pull/10565 ## Description ## Add a utility to get the path to the `im2rec.py` tool update the basic/data.md tutorial ## Checklist ##

[GitHub] ashokei commented on issue #10021: [MXNET-33] SSD example not working with mkl-dnn

2018-04-16 Thread GitBox
ashokei commented on issue #10021: [MXNET-33] SSD example not working with mkl-dnn URL: https://github.com/apache/incubator-mxnet/pull/10021#issuecomment-371638503 @marcoabreu @TaoLv @zheng-da Unit-tests currently do not seem to test backward/training mode for pooling very well. Below is

[GitHub] anirudh2290 commented on issue #10565: [MXNET-307] Add utility to get im2rec.py path

2018-04-16 Thread GitBox
anirudh2290 commented on issue #10565: [MXNET-307] Add utility to get im2rec.py path URL: https://github.com/apache/incubator-mxnet/pull/10565#issuecomment-381727582 @eric-haibin-lin would you be able to take a look ? This needs to go in for the release.

[GitHub] thomelane commented on a change in pull request #10537: [MX-307] Add .md tutorials to .ipynb for CI integration

2018-04-16 Thread GitBox
thomelane commented on a change in pull request #10537: [MX-307] Add .md tutorials to .ipynb for CI integration URL: https://github.com/apache/incubator-mxnet/pull/10537#discussion_r181871411 ## File path: docs/tutorials/python/data_augmentation.md ## @@ -49,13 +47,21 @@

[GitHub] thomelane commented on a change in pull request #10537: [MX-307] Add .md tutorials to .ipynb for CI integration

2018-04-16 Thread GitBox
thomelane commented on a change in pull request #10537: [MX-307] Add .md tutorials to .ipynb for CI integration URL: https://github.com/apache/incubator-mxnet/pull/10537#discussion_r181873160 ## File path: docs/tutorials/speech_recognition/ctc.md ## @@ -1,5 +1,11 @@ #

[GitHub] eric-haibin-lin commented on a change in pull request #10415: [MXNET-284] Update release version text to 1.2.0

2018-04-16 Thread GitBox
eric-haibin-lin commented on a change in pull request #10415: [MXNET-284] Update release version text to 1.2.0 URL: https://github.com/apache/incubator-mxnet/pull/10415#discussion_r181873930 ## File path: docs/_static/mxnet-theme/index.html ## @@ -21,21 +21,21 @@

[GitHub] ThomasDelteil commented on a change in pull request #10537: [MX-307] Add .md tutorials to .ipynb for CI integration

2018-04-16 Thread GitBox
ThomasDelteil commented on a change in pull request #10537: [MX-307] Add .md tutorials to .ipynb for CI integration URL: https://github.com/apache/incubator-mxnet/pull/10537#discussion_r181877584 ## File path: docs/tutorials/python/data_augmentation.md ## @@ -49,13 +47,21

[incubator-mxnet] branch master updated: fix NNPACK header file position error (#10525)

2018-04-16 Thread jxie
This is an automated email from the ASF dual-hosted git repository. jxie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-mxnet.git The following commit(s) were added to refs/heads/master by this push: new fb72ee7 fix NNPACK header file position

[GitHub] piiswrong closed pull request #10525: Fix NNPACK header file position error

2018-04-16 Thread GitBox
piiswrong closed pull request #10525: Fix NNPACK header file position error URL: https://github.com/apache/incubator-mxnet/pull/10525 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a

[GitHub] piiswrong commented on issue #10525: Fix NNPACK header file position error

2018-04-16 Thread GitBox
piiswrong commented on issue #10525: Fix NNPACK header file position error URL: https://github.com/apache/incubator-mxnet/pull/10525#issuecomment-381735354 in any case i'll merge this first since it doesn't do any harm This

[GitHub] zheng-da commented on a change in pull request #10433: [MXNET-290] MKLDNN support for model quantization

2018-04-16 Thread GitBox
zheng-da commented on a change in pull request #10433: [MXNET-290] MKLDNN support for model quantization URL: https://github.com/apache/incubator-mxnet/pull/10433#discussion_r181842955 ## File path: src/operator/nn/pooling.cc ## @@ -368,7 +368,11 @@ height, width)*. })

[GitHub] KellenSunderland commented on issue #10553: Build error for OSX with CUDA support

2018-04-16 Thread GitBox
KellenSunderland commented on issue #10553: Build error for OSX with CUDA support URL: https://github.com/apache/incubator-mxnet/issues/10553#issuecomment-381729362 Thanks for the report @sbodenstein. I see what the issue is and will open a PR, it should be reasonably easy to fix.

[GitHub] KellenSunderland opened a new pull request #10566: [MXNET-324] Use default nvcc when configured nvcc not present.

2018-04-16 Thread GitBox
KellenSunderland opened a new pull request #10566: [MXNET-324] Use default nvcc when configured nvcc not present. URL: https://github.com/apache/incubator-mxnet/pull/10566 ## Description ## This fixes an issue with the nvcc path resolution logic in the Makefile (#10553). In prior

[GitHub] marcoabreu commented on a change in pull request #10566: [MXNET-324] Use default nvcc when configured nvcc not present.

2018-04-16 Thread GitBox
marcoabreu commented on a change in pull request #10566: [MXNET-324] Use default nvcc when configured nvcc not present. URL: https://github.com/apache/incubator-mxnet/pull/10566#discussion_r181875332 ## File path: Makefile ## @@ -255,11 +255,26 @@ ifneq ($(ADD_LDFLAGS),

[GitHub] marcoabreu commented on a change in pull request #10566: [MXNET-324] Use default nvcc when configured nvcc not present.

2018-04-16 Thread GitBox
marcoabreu commented on a change in pull request #10566: [MXNET-324] Use default nvcc when configured nvcc not present. URL: https://github.com/apache/incubator-mxnet/pull/10566#discussion_r181875019 ## File path: Makefile ## @@ -255,11 +255,26 @@ ifneq ($(ADD_LDFLAGS),

[GitHub] ThomasDelteil commented on a change in pull request #10537: [MX-307] Add .md tutorials to .ipynb for CI integration

2018-04-16 Thread GitBox
ThomasDelteil commented on a change in pull request #10537: [MX-307] Add .md tutorials to .ipynb for CI integration URL: https://github.com/apache/incubator-mxnet/pull/10537#discussion_r181875085 ## File path: docs/tutorials/speech_recognition/ctc.md ## @@ -1,5 +1,11 @@

[GitHub] ThomasDelteil commented on a change in pull request #10537: [MX-307] Add .md tutorials to .ipynb for CI integration

2018-04-16 Thread GitBox
ThomasDelteil commented on a change in pull request #10537: [MX-307] Add .md tutorials to .ipynb for CI integration URL: https://github.com/apache/incubator-mxnet/pull/10537#discussion_r181875579 ## File path: docs/tutorials/gluon/datasets.md ## @@ -175,58 +180,51 @@ for

[GitHub] ThomasDelteil commented on a change in pull request #10537: [MX-307] Add .md tutorials to .ipynb for CI integration

2018-04-16 Thread GitBox
ThomasDelteil commented on a change in pull request #10537: [MX-307] Add .md tutorials to .ipynb for CI integration URL: https://github.com/apache/incubator-mxnet/pull/10537#discussion_r181875787 ## File path: docs/tutorials/python/types_of_data_augmentation.md ## @@

[GitHub] eric-haibin-lin commented on a change in pull request #10477: [MXNET-299] Adding the Download page and linking it to the Install page

2018-04-16 Thread GitBox
eric-haibin-lin commented on a change in pull request #10477: [MXNET-299] Adding the Download page and linking it to the Install page URL: https://github.com/apache/incubator-mxnet/pull/10477#discussion_r181875755 ## File path: docs/install/index.md ## @@ -1743,4 +1744,10

[GitHub] ThomasDelteil commented on a change in pull request #10537: [MX-307] Add .md tutorials to .ipynb for CI integration

2018-04-16 Thread GitBox
ThomasDelteil commented on a change in pull request #10537: [MX-307] Add .md tutorials to .ipynb for CI integration URL: https://github.com/apache/incubator-mxnet/pull/10537#discussion_r181875817 ## File path: docs/tutorials/vision/large_scale_classification.md ## @@

[GitHub] KellenSunderland commented on a change in pull request #10566: [MXNET-324] Use default nvcc when configured nvcc not present.

2018-04-16 Thread GitBox
KellenSunderland commented on a change in pull request #10566: [MXNET-324] Use default nvcc when configured nvcc not present. URL: https://github.com/apache/incubator-mxnet/pull/10566#discussion_r181879227 ## File path: Makefile ## @@ -255,11 +255,26 @@ ifneq

[GitHub] ThomasDelteil commented on issue #10565: [MXNET-307] Add utility to get im2rec.py path

2018-04-16 Thread GitBox
ThomasDelteil commented on issue #10565: [MXNET-307] Add utility to get im2rec.py path URL: https://github.com/apache/incubator-mxnet/pull/10565#issuecomment-381719166 @anirudh2290 fix we discussed This is an automated

[GitHub] marcoabreu commented on a change in pull request #10566: [MXNET-324] Use default nvcc when configured nvcc not present.

2018-04-16 Thread GitBox
marcoabreu commented on a change in pull request #10566: [MXNET-324] Use default nvcc when configured nvcc not present. URL: https://github.com/apache/incubator-mxnet/pull/10566#discussion_r181874738 ## File path: Makefile ## @@ -255,11 +255,26 @@ ifneq ($(ADD_LDFLAGS),

[GitHub] ZiyueHuang commented on issue #10377: Inconsistency between ndarray and symbol when performing division

2018-04-16 Thread GitBox
ZiyueHuang commented on issue #10377: Inconsistency between ndarray and symbol when performing division URL: https://github.com/apache/incubator-mxnet/issues/10377#issuecomment-381706135 @szhengac I think it is due to the immutability of `symbol` so that one cannot use `sym +=

[GitHub] thomelane commented on a change in pull request #10537: [MX-307] Add .md tutorials to .ipynb for CI integration

2018-04-16 Thread GitBox
thomelane commented on a change in pull request #10537: [MX-307] Add .md tutorials to .ipynb for CI integration URL: https://github.com/apache/incubator-mxnet/pull/10537#discussion_r181873340 ## File path: docs/tutorials/vision/large_scale_classification.md ## @@ -11,6

[GitHub] thomelane commented on a change in pull request #10537: [MX-307] Add .md tutorials to .ipynb for CI integration

2018-04-16 Thread GitBox
thomelane commented on a change in pull request #10537: [MX-307] Add .md tutorials to .ipynb for CI integration URL: https://github.com/apache/incubator-mxnet/pull/10537#discussion_r181872254 ## File path: docs/tutorials/python/types_of_data_augmentation.md ## @@ -335,7

[GitHub] thomelane commented on a change in pull request #10537: [MX-307] Add .md tutorials to .ipynb for CI integration

2018-04-16 Thread GitBox
thomelane commented on a change in pull request #10537: [MX-307] Add .md tutorials to .ipynb for CI integration URL: https://github.com/apache/incubator-mxnet/pull/10537#discussion_r181869552 ## File path: docs/tutorials/gluon/datasets.md ## @@ -175,58 +180,51 @@ for

[GitHub] thomelane commented on a change in pull request #10537: [MX-307] Add .md tutorials to .ipynb for CI integration

2018-04-16 Thread GitBox
thomelane commented on a change in pull request #10537: [MX-307] Add .md tutorials to .ipynb for CI integration URL: https://github.com/apache/incubator-mxnet/pull/10537#discussion_r181869689 ## File path: docs/tutorials/gluon/datasets.md ## @@ -245,7 +243,7 @@ As with

[GitHub] ThomasDelteil commented on a change in pull request #10537: [MX-307] Add .md tutorials to .ipynb for CI integration

2018-04-16 Thread GitBox
ThomasDelteil commented on a change in pull request #10537: [MX-307] Add .md tutorials to .ipynb for CI integration URL: https://github.com/apache/incubator-mxnet/pull/10537#discussion_r181875420 ## File path: docs/tutorials/gluon/datasets.md ## @@ -245,7 +243,7 @@ As

[GitHub] sxjscience commented on issue #10563: Suboptimal performance implementing PPO with Adam Optimizer

2018-04-16 Thread GitBox
sxjscience commented on issue #10563: Suboptimal performance implementing PPO with Adam Optimizer URL: https://github.com/apache/incubator-mxnet/issues/10563#issuecomment-381756955 I've run the code and have seen similar phenomena. Still not sure what caused the problem. I think Adam

[GitHub] indhub commented on a change in pull request #10568: [WIP] [MXNET-325] Model parallelism tutorial.

2018-04-16 Thread GitBox
indhub commented on a change in pull request #10568: [WIP] [MXNET-325] Model parallelism tutorial. URL: https://github.com/apache/incubator-mxnet/pull/10568#discussion_r181894869 ## File path: docs/tutorials/gluon/model_parallelism.md ## @@ -0,0 +1,373 @@ + +# Model

[GitHub] indhub commented on a change in pull request #10568: [WIP] [MXNET-325] Model parallelism tutorial.

2018-04-16 Thread GitBox
indhub commented on a change in pull request #10568: [WIP] [MXNET-325] Model parallelism tutorial. URL: https://github.com/apache/incubator-mxnet/pull/10568#discussion_r181895001 ## File path: docs/tutorials/gluon/model_parallelism.md ## @@ -0,0 +1,373 @@ + +# Model

[GitHub] indhub commented on a change in pull request #10568: [WIP] [MXNET-325] Model parallelism tutorial.

2018-04-16 Thread GitBox
indhub commented on a change in pull request #10568: [WIP] [MXNET-325] Model parallelism tutorial. URL: https://github.com/apache/incubator-mxnet/pull/10568#discussion_r181895035 ## File path: docs/tutorials/gluon/model_parallelism.md ## @@ -0,0 +1,373 @@ + +# Model

[GitHub] indhub commented on a change in pull request #10568: [WIP] [MXNET-325] Model parallelism tutorial.

2018-04-16 Thread GitBox
indhub commented on a change in pull request #10568: [WIP] [MXNET-325] Model parallelism tutorial. URL: https://github.com/apache/incubator-mxnet/pull/10568#discussion_r181894899 ## File path: docs/tutorials/gluon/model_parallelism.md ## @@ -0,0 +1,373 @@ + +# Model

[GitHub] ThomasDelteil commented on a change in pull request #10568: [WIP] [MXNET-325] Model parallelism tutorial.

2018-04-16 Thread GitBox
ThomasDelteil commented on a change in pull request #10568: [WIP] [MXNET-325] Model parallelism tutorial. URL: https://github.com/apache/incubator-mxnet/pull/10568#discussion_r181892587 ## File path: docs/tutorials/gluon/model_parallelism.md ## @@ -0,0 +1,373 @@ + +#

[GitHub] temoc commented on issue #8319: [WIP-NewFeature] ONNX support for MXNet

2018-04-16 Thread GitBox
temoc commented on issue #8319: [WIP-NewFeature] ONNX support for MXNet URL: https://github.com/apache/incubator-mxnet/issues/8319#issuecomment-381768096 @Roshrini I was wondering what the plans are for exporting an MxNet model to ONNX?

[GitHub] thomelane opened a new issue #10571: Gluon not mentioned in Symbol API tutorial

2018-04-16 Thread GitBox
thomelane opened a new issue #10571: Gluon not mentioned in Symbol API tutorial URL: https://github.com/apache/incubator-mxnet/issues/10571 Gluon mention in Symbol API tutorial. http://mxnet.incubator.apache.org/tutorials/basic/symbol.html Given Symbol API is being used by

[GitHub] KellenSunderland commented on a change in pull request #10566: [MXNET-324] Use default nvcc when configured nvcc not present.

2018-04-16 Thread GitBox
KellenSunderland commented on a change in pull request #10566: [MXNET-324] Use default nvcc when configured nvcc not present. URL: https://github.com/apache/incubator-mxnet/pull/10566#discussion_r181880161 ## File path: Makefile ## @@ -255,11 +255,26 @@ ifneq

[GitHub] anirudh2290 commented on a change in pull request #10415: [MXNET-284] Update release version text to 1.2.0

2018-04-16 Thread GitBox
anirudh2290 commented on a change in pull request #10415: [MXNET-284] Update release version text to 1.2.0 URL: https://github.com/apache/incubator-mxnet/pull/10415#discussion_r181881564 ## File path: docs/_static/mxnet-theme/index.html ## @@ -21,21 +21,21 @@

[GitHub] ThomasDelteil opened a new issue #10567: [Feature Request] Cache the CUDNN convolution optimization result

2018-04-16 Thread GitBox
ThomasDelteil opened a new issue #10567: [Feature Request] Cache the CUDNN convolution optimization result URL: https://github.com/apache/incubator-mxnet/issues/10567 On every script run, I get the CUDNN convolution optimization algorithm running. This can take a few seconds, I wonder if

[GitHub] ThomasDelteil commented on a change in pull request #10568: [WIP] [MXNET-325] Model parallelism tutorial.

2018-04-16 Thread GitBox
ThomasDelteil commented on a change in pull request #10568: [WIP] [MXNET-325] Model parallelism tutorial. URL: https://github.com/apache/incubator-mxnet/pull/10568#discussion_r181891347 ## File path: docs/tutorials/gluon/model_parallelism.md ## @@ -0,0 +1,373 @@ + +#

[GitHub] ThomasDelteil commented on a change in pull request #10568: [WIP] [MXNET-325] Model parallelism tutorial.

2018-04-16 Thread GitBox
ThomasDelteil commented on a change in pull request #10568: [WIP] [MXNET-325] Model parallelism tutorial. URL: https://github.com/apache/incubator-mxnet/pull/10568#discussion_r181892587 ## File path: docs/tutorials/gluon/model_parallelism.md ## @@ -0,0 +1,373 @@ + +#

[GitHub] ThomasDelteil commented on a change in pull request #10568: [WIP] [MXNET-325] Model parallelism tutorial.

2018-04-16 Thread GitBox
ThomasDelteil commented on a change in pull request #10568: [WIP] [MXNET-325] Model parallelism tutorial. URL: https://github.com/apache/incubator-mxnet/pull/10568#discussion_r18171 ## File path: docs/tutorials/gluon/model_parallelism.md ## @@ -0,0 +1,373 @@ + +#

[GitHub] ThomasDelteil commented on a change in pull request #10568: [WIP] [MXNET-325] Model parallelism tutorial.

2018-04-16 Thread GitBox
ThomasDelteil commented on a change in pull request #10568: [WIP] [MXNET-325] Model parallelism tutorial. URL: https://github.com/apache/incubator-mxnet/pull/10568#discussion_r181891114 ## File path: docs/tutorials/gluon/model_parallelism.md ## @@ -0,0 +1,373 @@ + +#

[GitHub] ThomasDelteil commented on a change in pull request #10568: [WIP] [MXNET-325] Model parallelism tutorial.

2018-04-16 Thread GitBox
ThomasDelteil commented on a change in pull request #10568: [WIP] [MXNET-325] Model parallelism tutorial. URL: https://github.com/apache/incubator-mxnet/pull/10568#discussion_r181889923 ## File path: docs/tutorials/gluon/model_parallelism.md ## @@ -0,0 +1,373 @@ + +#

[GitHub] ThomasDelteil commented on a change in pull request #10568: [WIP] [MXNET-325] Model parallelism tutorial.

2018-04-16 Thread GitBox
ThomasDelteil commented on a change in pull request #10568: [WIP] [MXNET-325] Model parallelism tutorial. URL: https://github.com/apache/incubator-mxnet/pull/10568#discussion_r181890470 ## File path: docs/tutorials/gluon/model_parallelism.md ## @@ -0,0 +1,373 @@ + +#

[GitHub] ThomasDelteil commented on a change in pull request #10568: [WIP] [MXNET-325] Model parallelism tutorial.

2018-04-16 Thread GitBox
ThomasDelteil commented on a change in pull request #10568: [WIP] [MXNET-325] Model parallelism tutorial. URL: https://github.com/apache/incubator-mxnet/pull/10568#discussion_r181889258 ## File path: docs/tutorials/gluon/model_parallelism.md ## @@ -0,0 +1,373 @@ + +#

[GitHub] ThomasDelteil commented on a change in pull request #10568: [WIP] [MXNET-325] Model parallelism tutorial.

2018-04-16 Thread GitBox
ThomasDelteil commented on a change in pull request #10568: [WIP] [MXNET-325] Model parallelism tutorial. URL: https://github.com/apache/incubator-mxnet/pull/10568#discussion_r181889519 ## File path: docs/tutorials/gluon/model_parallelism.md ## @@ -0,0 +1,373 @@ + +#

[GitHub] indhub commented on a change in pull request #10568: [WIP] [MXNET-325] Model parallelism tutorial.

2018-04-16 Thread GitBox
indhub commented on a change in pull request #10568: [WIP] [MXNET-325] Model parallelism tutorial. URL: https://github.com/apache/incubator-mxnet/pull/10568#discussion_r181894788 ## File path: docs/tutorials/gluon/model_parallelism.md ## @@ -0,0 +1,373 @@ + +# Model

[GitHub] indhub commented on a change in pull request #10568: [WIP] [MXNET-325] Model parallelism tutorial.

2018-04-16 Thread GitBox
indhub commented on a change in pull request #10568: [WIP] [MXNET-325] Model parallelism tutorial. URL: https://github.com/apache/incubator-mxnet/pull/10568#discussion_r181894770 ## File path: docs/tutorials/gluon/model_parallelism.md ## @@ -0,0 +1,373 @@ + +# Model

[GitHub] KellenSunderland closed issue #10072: Default CMake build failure.

2018-04-16 Thread GitBox
KellenSunderland closed issue #10072: Default CMake build failure. URL: https://github.com/apache/incubator-mxnet/issues/10072 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] KellenSunderland closed issue #10341: Deadlock during ThreadedEnginePerDevice destructor after CuDNNConvolutionOp::SelectAlgo called.

2018-04-16 Thread GitBox
KellenSunderland closed issue #10341: Deadlock during ThreadedEnginePerDevice destructor after CuDNNConvolutionOp::SelectAlgo called. URL: https://github.com/apache/incubator-mxnet/issues/10341 This is an automated message

[GitHub] piiswrong commented on issue #10570: Add Gluon crash course into frontpage

2018-04-16 Thread GitBox
piiswrong commented on issue #10570: Add Gluon crash course into frontpage URL: https://github.com/apache/incubator-mxnet/pull/10570#issuecomment-381773084 Where would this show up? How about putting this beside Apache MXNet instead of putting it in news?

[GitHub] piiswrong commented on issue #10570: Add Gluon crash course into frontpage

2018-04-16 Thread GitBox
piiswrong commented on issue #10570: Add Gluon crash course into frontpage URL: https://github.com/apache/incubator-mxnet/pull/10570#issuecomment-381773084 Where would this show up? This is an automated message from the

[GitHub] indhub opened a new pull request #10568: [WIP] [MXNET-325] Model parallelism tutorial.

2018-04-16 Thread GitBox
indhub opened a new pull request #10568: [WIP] [MXNET-325] Model parallelism tutorial. URL: https://github.com/apache/incubator-mxnet/pull/10568 ## Description ## I'm working on a tutorial to show how model parallelism can be done in Gluon. The tutorial builds a stacked LSTM with

[GitHub] anirudh2290 commented on issue #10545: [WIP] Add NEWS and README

2018-04-16 Thread GitBox
anirudh2290 commented on issue #10545: [WIP] Add NEWS and README URL: https://github.com/apache/incubator-mxnet/pull/10545#issuecomment-381750401 Moved this back to WIP since need to add some more PRs for the release: #10477 #10415 #10565

[GitHub] KellenSunderland opened a new pull request #10569: Use default nvcc when configured nvcc not present.

2018-04-16 Thread GitBox
KellenSunderland opened a new pull request #10569: Use default nvcc when configured nvcc not present. URL: https://github.com/apache/incubator-mxnet/pull/10569 ## Description ## This fixes an issue with the nvcc path resolution logic in the Makefile (#10553). In prior releases the

[GitHub] sxjscience commented on issue #10563: Suboptimal performance implementing PPO with Adam Optimizer

2018-04-16 Thread GitBox
sxjscience commented on issue #10563: Suboptimal performance implementing PPO with Adam Optimizer URL: https://github.com/apache/incubator-mxnet/issues/10563#issuecomment-381756955 I've run the code and can verify the phenomena mentioned in the issue. Still not sure what caused the

[GitHub] ThomasDelteil commented on a change in pull request #10568: [WIP] [MXNET-325] Model parallelism tutorial.

2018-04-16 Thread GitBox
ThomasDelteil commented on a change in pull request #10568: [WIP] [MXNET-325] Model parallelism tutorial. URL: https://github.com/apache/incubator-mxnet/pull/10568#discussion_r181889258 ## File path: docs/tutorials/gluon/model_parallelism.md ## @@ -0,0 +1,373 @@ + +#

[GitHub] ThomasDelteil commented on a change in pull request #10568: [WIP] [MXNET-325] Model parallelism tutorial.

2018-04-16 Thread GitBox
ThomasDelteil commented on a change in pull request #10568: [WIP] [MXNET-325] Model parallelism tutorial. URL: https://github.com/apache/incubator-mxnet/pull/10568#discussion_r181889923 ## File path: docs/tutorials/gluon/model_parallelism.md ## @@ -0,0 +1,373 @@ + +#

[GitHub] sxjscience commented on issue #10563: Suboptimal performance implementing PPO with Adam Optimizer

2018-04-16 Thread GitBox
sxjscience commented on issue #10563: Suboptimal performance implementing PPO with Adam Optimizer URL: https://github.com/apache/incubator-mxnet/issues/10563#issuecomment-381756955 I've run the code and can verify the phenomena mentioned in the issue. Still not sure what caused the

[GitHub] indhub commented on issue #10568: [WIP] [MXNET-325] Model parallelism tutorial.

2018-04-16 Thread GitBox
indhub commented on issue #10568: [WIP] [MXNET-325] Model parallelism tutorial. URL: https://github.com/apache/incubator-mxnet/pull/10568#issuecomment-381759191 @ThomasDelteil Thanks for the review. Like mentioned in the description, I haven't 'tutorialized' the code yet. I created a PR

[GitHub] indhub commented on a change in pull request #10568: [WIP] [MXNET-325] Model parallelism tutorial.

2018-04-16 Thread GitBox
indhub commented on a change in pull request #10568: [WIP] [MXNET-325] Model parallelism tutorial. URL: https://github.com/apache/incubator-mxnet/pull/10568#discussion_r181895239 ## File path: docs/tutorials/gluon/model_parallelism.md ## @@ -0,0 +1,373 @@ + +# Model

[GitHub] harusametime commented on issue #10528: [MXNET-316] Remove empty buckets causing index errors

2018-04-16 Thread GitBox
harusametime commented on issue #10528: [MXNET-316] Remove empty buckets causing index errors URL: https://github.com/apache/incubator-mxnet/pull/10528#issuecomment-381775912 @ThomasDelteil I agree to your suggestion on making two buckets empty with `-1`. The previous test evaluates the

[GitHub] harusametime commented on issue #10528: [MXNET-316] Remove empty buckets causing index errors

2018-04-16 Thread GitBox
harusametime commented on issue #10528: [MXNET-316] Remove empty buckets causing index errors URL: https://github.com/apache/incubator-mxnet/pull/10528#issuecomment-381775912 @ThomasDelteil I agree to your suggestion on making two buckets empty with `-1`. The previous test evaluates the

[GitHub] KellenSunderland commented on a change in pull request #10566: [MXNET-324] Use default nvcc when configured nvcc not present.

2018-04-16 Thread GitBox
KellenSunderland commented on a change in pull request #10566: [MXNET-324] Use default nvcc when configured nvcc not present. URL: https://github.com/apache/incubator-mxnet/pull/10566#discussion_r181880161 ## File path: Makefile ## @@ -255,11 +255,26 @@ ifneq

[GitHub] piiswrong closed pull request #10565: [MXNET-307] Add utility to get im2rec.py path

2018-04-16 Thread GitBox
piiswrong closed pull request #10565: [MXNET-307] Add utility to get im2rec.py path URL: https://github.com/apache/incubator-mxnet/pull/10565 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As

[GitHub] indhub commented on issue #10568: [WIP] [MXNET-325] Model parallelism tutorial.

2018-04-16 Thread GitBox
indhub commented on issue #10568: [WIP] [MXNET-325] Model parallelism tutorial. URL: https://github.com/apache/incubator-mxnet/pull/10568#issuecomment-381751322 @safrooze @Ishitori @thomelane @ThomasDelteil This is an

[incubator-mxnet] branch master updated: [MXNET-307] Add utility to get im2rec.py path (#10565)

2018-04-16 Thread jxie
This is an automated email from the ASF dual-hosted git repository. jxie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-mxnet.git The following commit(s) were added to refs/heads/master by this push: new 12cbcea [MXNET-307] Add utility to get

[GitHub] mli opened a new pull request #10570: Add Gluon crash course into frontpage

2018-04-16 Thread GitBox
mli opened a new pull request #10570: Add Gluon crash course into frontpage URL: https://github.com/apache/incubator-mxnet/pull/10570 ## Description ## (Brief description on what this PR is about) ## Checklist ## ### Essentials ### Please feel free to remove inapplicable

[GitHub] lionel92 opened a new issue #10560: It gets blocked when executing python binding during installation from source

2018-04-16 Thread GitBox
lionel92 opened a new issue #10560: It gets blocked when executing python binding during installation from source URL: https://github.com/apache/incubator-mxnet/issues/10560 Note: Providing complete information in the most concise form is the best way to get help. This issue template

[GitHub] nihui commented on issue #10365: [MXNET-261]Update MKLDNN & Add CPP Test

2018-04-16 Thread GitBox
nihui commented on issue #10365: [MXNET-261]Update MKLDNN & Add CPP Test URL: https://github.com/apache/incubator-mxnet/pull/10365#issuecomment-381515285 @xinyu-intel hello I just played with the latest code

[GitHub] YeWenting commented on issue #5013: there appear nan in convolution weight

2018-04-16 Thread GitBox
YeWenting commented on issue #5013: there appear nan in convolution weight URL: https://github.com/apache/incubator-mxnet/issues/5013#issuecomment-381514833 @moveforever , I have checked my data but seemed to be ok. If you could tell me your scenario, it might help me to solve my

[GitHub] nihui commented on issue #10365: [MXNET-261]Update MKLDNN & Add CPP Test

2018-04-16 Thread GitBox
nihui commented on issue #10365: [MXNET-261]Update MKLDNN & Add CPP Test URL: https://github.com/apache/incubator-mxnet/pull/10365#issuecomment-381515285 @xinyu-intel hello I just played with the latest code

[GitHub] chinakook commented on issue #10560: It gets blocked when executing python binding during installation from source

2018-04-16 Thread GitBox
chinakook commented on issue #10560: It gets blocked when executing python binding during installation from source URL: https://github.com/apache/incubator-mxnet/issues/10560#issuecomment-381514559 Set 'USE_OPERATOR_TUNING = 0', It sometimes block executing in Ubuntu and always block

[GitHub] lionel92 closed issue #10560: It gets blocked when executing python binding during installation from source

2018-04-16 Thread GitBox
lionel92 closed issue #10560: It gets blocked when executing python binding during installation from source URL: https://github.com/apache/incubator-mxnet/issues/10560 This is an automated message from the Apache Git

[GitHub] lionel92 commented on issue #10560: It gets blocked when executing python binding during installation from source

2018-04-16 Thread GitBox
lionel92 commented on issue #10560: It gets blocked when executing python binding during installation from source URL: https://github.com/apache/incubator-mxnet/issues/10560#issuecomment-381521078 @chinakook You really helps a lot!

[GitHub] piiswrong closed pull request #10573: Fix gluon error message.

2018-04-16 Thread GitBox
piiswrong closed pull request #10573: Fix gluon error message. URL: https://github.com/apache/incubator-mxnet/pull/10573 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull

  1   2   >