[GitHub] [incubator-mxnet] pengzhao-intel commented on issue #17980: When compiled with MKL, fully_connected calls DNNL while dot and batch_dot call MKL

2020-04-07 Thread GitBox
pengzhao-intel commented on issue #17980: When compiled with MKL, fully_connected calls DNNL while dot and batch_dot call MKL URL: https://github.com/apache/incubator-mxnet/issues/17980#issuecomment-610395459 @bartekkuncer please help take a look for this issue as well

[GitHub] [incubator-mxnet] ptrendx commented on issue #17937: Fix for handling negative indices in the fusion of slice

2020-04-07 Thread GitBox
ptrendx commented on issue #17937: Fix for handling negative indices in the fusion of slice URL: https://github.com/apache/incubator-mxnet/pull/17937#issuecomment-610454793 @szha @ChaiBapchya Is anybody looking at this hang after e.g. `test_np_empty` tests? It would be really useful for

[GitHub] [incubator-mxnet] pengzhao-intel commented on issue #17971: DOT product too slow on CPU and GPU compared to np and pytorch

2020-04-07 Thread GitBox
pengzhao-intel commented on issue #17971: DOT product too slow on CPU and GPU compared to np and pytorch URL: https://github.com/apache/incubator-mxnet/issues/17971#issuecomment-610396391 @anko-intel please help take a look for this issue, thanks.

[GitHub] [incubator-mxnet] pengzhao-intel commented on issue #17898: LSTM and GRU layers without DNNL enabled give wrong gradients

2020-04-07 Thread GitBox
pengzhao-intel commented on issue #17898: LSTM and GRU layers without DNNL enabled give wrong gradients URL: https://github.com/apache/incubator-mxnet/issues/17898#issuecomment-610397083 @bgawrych please help take a look if you can reproduce this issue and if there is a case to catch

[GitHub] [incubator-mxnet] emfomenk commented on issue #17980: When compiled with MKL, fully_connected calls DNNL while dot and batch_dot call MKL

2020-04-07 Thread GitBox
emfomenk commented on issue #17980: When compiled with MKL, fully_connected calls DNNL while dot and batch_dot call MKL URL: https://github.com/apache/incubator-mxnet/issues/17980#issuecomment-610441396 > Do you think that enabling this option can improve the performance of inner product

[GitHub] [incubator-mxnet] ChaiBapchya commented on issue #17937: Fix for handling negative indices in the fusion of slice

2020-04-07 Thread GitBox
ChaiBapchya commented on issue #17937: Fix for handling negative indices in the fusion of slice URL: https://github.com/apache/incubator-mxnet/pull/17937#issuecomment-610474354 Yes. Getting a stacktrace as it hangs needs to be done before the instance is shut down by the autoscaler [as it

[GitHub] [incubator-mxnet] ptrendx commented on issue #17989: [Gradient Addto] Very serious bug of grad_req='add'

2020-04-07 Thread GitBox
ptrendx commented on issue #17989: [Gradient Addto] Very serious bug of grad_req='add' URL: https://github.com/apache/incubator-mxnet/issues/17989#issuecomment-610480017 Sure This is an automated message from the Apache Git

[GitHub] [incubator-mxnet] hananawi commented on issue #5947: imread read blank (None) image for file: *.jpg

2020-04-07 Thread GitBox
hananawi commented on issue #5947: imread read blank (None) image for file: *.jpg URL: https://github.com/apache/incubator-mxnet/issues/5947#issuecomment-610462216 I also encount this problem, and I find that my path contain Chinese then I change it to English, then it works

[GitHub] [incubator-mxnet] szha commented on issue #17989: [Gradient Addto] Very serious bug of grad_req='add'

2020-04-07 Thread GitBox
szha commented on issue #17989: [Gradient Addto] Very serious bug of grad_req='add' URL: https://github.com/apache/incubator-mxnet/issues/17989#issuecomment-610466779 @ptrendx both this issue and the #16708 seem to be GPU-specific. Would you mind taking a look?

[GitHub] [incubator-mxnet] mxnet-bot commented on issue #17991: Get DNNL v1.2.2 back to master branch

2020-04-07 Thread GitBox
mxnet-bot commented on issue #17991: Get DNNL v1.2.2 back to master branch URL: https://github.com/apache/incubator-mxnet/pull/17991#issuecomment-610290305 Hey @TaoLv , Thanks for submitting the PR All tests are already queued to run once. If tests fail, you can trigger one or more

[GitHub] [incubator-mxnet] TaoLv opened a new pull request #17991: Get DNNL v1.2.2 back to master branch

2020-04-07 Thread GitBox
TaoLv opened a new pull request #17991: Get DNNL v1.2.2 back to master branch URL: https://github.com/apache/incubator-mxnet/pull/17991 ## Description ## 3rdparty/mkldnn was down graded from v1.2.2 to v1.1.2 by accident in #17084. This PR gets the right version back. ## Checklist

[GitHub] [incubator-mxnet] TaoLv closed pull request #17986: Revert "[numpy] add op median (#17084)"

2020-04-07 Thread GitBox
TaoLv closed pull request #17986: Revert "[numpy] add op median (#17084)" URL: https://github.com/apache/incubator-mxnet/pull/17986 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [incubator-mxnet] TaoLv commented on issue #17084: [numpy] add op median

2020-04-07 Thread GitBox
TaoLv commented on issue #17084: [numpy] add op median URL: https://github.com/apache/incubator-mxnet/pull/17084#issuecomment-610290830 Creating https://github.com/apache/incubator-mxnet/pull/17991 to fix and closing the reverting PR https://github.com/apache/incubator-mxnet/pull/17986.

[GitHub] [incubator-mxnet] wkcn commented on issue #17952: 1bit gradient compression

2020-04-07 Thread GitBox
wkcn commented on issue #17952: 1bit gradient compression URL: https://github.com/apache/incubator-mxnet/pull/17952#issuecomment-610323453 Hi @rahul003 , could you please help take a review? Thank you! This is an automated

[GitHub] [incubator-mxnet] chinakook commented on issue #17917: fix UnicodeDecodeError: 'utf-8' codec can't decode bytes in position …

2020-04-07 Thread GitBox
chinakook commented on issue #17917: fix UnicodeDecodeError: 'utf-8' codec can't decode bytes in position … URL: https://github.com/apache/incubator-mxnet/pull/17917#issuecomment-610329014 @hzfan I compiled mxnet by myself on windows, and then typed ```import mxnet``` in python. The

[incubator-mxnet-site] branch asf-site updated: Bump the publish timestamp.

2020-04-07 Thread aaronmarkham
This is an automated email from the ASF dual-hosted git repository. aaronmarkham pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/incubator-mxnet-site.git The following commit(s) were added to refs/heads/asf-site by this push: new 687e916 Bump the

[GitHub] [incubator-mxnet] TaoLv commented on issue #17986: Revert "[numpy] add op median (#17084)"

2020-04-07 Thread GitBox
TaoLv commented on issue #17986: Revert "[numpy] add op median (#17084)" URL: https://github.com/apache/incubator-mxnet/pull/17986#issuecomment-610291126 Fix in https://github.com/apache/incubator-mxnet/pull/17991 This is an

[GitHub] [incubator-mxnet] tobecontinued commented on issue #17977: Relaxing type requirements for broadcast_like

2020-04-07 Thread GitBox
tobecontinued commented on issue #17977: Relaxing type requirements for broadcast_like URL: https://github.com/apache/incubator-mxnet/pull/17977#issuecomment-610374126 @mxnet-bot run ci [unix-gpu] This is an automated

[GitHub] [incubator-mxnet] mxnet-bot commented on issue #17977: Relaxing type requirements for broadcast_like

2020-04-07 Thread GitBox
mxnet-bot commented on issue #17977: Relaxing type requirements for broadcast_like URL: https://github.com/apache/incubator-mxnet/pull/17977#issuecomment-610374194 Jenkins CI successfully triggered : [unix-gpu] This is an

[GitHub] [incubator-mxnet] hzfan commented on issue #17917: fix UnicodeDecodeError: 'utf-8' codec can't decode bytes in position …

2020-04-07 Thread GitBox
hzfan commented on issue #17917: fix UnicodeDecodeError: 'utf-8' codec can't decode bytes in position … URL: https://github.com/apache/incubator-mxnet/pull/17917#issuecomment-610293177 @chinakook Could you elaborate about how to reproduce `…73-74: invalid continuation byte`?

[GitHub] [incubator-mxnet] leezu commented on issue #17988: Row-sparse constant initializer accesses out of bound elements

2020-04-07 Thread GitBox
leezu commented on issue #17988: Row-sparse constant initializer accesses out of bound elements URL: https://github.com/apache/incubator-mxnet/issues/17988#issuecomment-610520256 Also affects `test_rsp_const_init` in the Perl test suite

[incubator-mxnet-site] branch asf-site updated: Bump the publish timestamp.

2020-04-07 Thread aaronmarkham
This is an automated email from the ASF dual-hosted git repository. aaronmarkham pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/incubator-mxnet-site.git The following commit(s) were added to refs/heads/asf-site by this push: new 0485a5d Bump the

[GitHub] [incubator-mxnet] stu1130 commented on issue #17872: Fix issue of zeros gradients w.r.t. RNN bias when num_layers > 1

2020-04-07 Thread GitBox
stu1130 commented on issue #17872: Fix issue of zeros gradients w.r.t. RNN bias when num_layers > 1 URL: https://github.com/apache/incubator-mxnet/pull/17872#issuecomment-610514553 @zixuanweeei Thanks for your contribution, could you also cherry-pick the commit to 1.7? DJL LSTM model

[GitHub] [incubator-mxnet] leezu opened a new issue #17992: MKLDNNConvolutionBackward accesses out of bound elements

2020-04-07 Thread GitBox
leezu opened a new issue #17992: MKLDNNConvolutionBackward accesses out of bound elements URL: https://github.com/apache/incubator-mxnet/issues/17992 ## Description CI with updated toolchain (ie #17984) catches the bug. `vector: :_M_range_check: __n (which is 2) >= this->size()

[GitHub] [incubator-mxnet] leezu commented on issue #17937: Fix for handling negative indices in the fusion of slice

2020-04-07 Thread GitBox
leezu commented on issue #17937: Fix for handling negative indices in the fusion of slice URL: https://github.com/apache/incubator-mxnet/pull/17937#issuecomment-61052 @ChaiBapchya the hang occurs after ~10 minutes but the instance will remain available until timeout happens (3 hours).

[GitHub] [incubator-mxnet] ChaiBapchya commented on issue #17993: fix R error; backport 1 line from #17228

2020-04-07 Thread GitBox
ChaiBapchya commented on issue #17993: fix R error; backport 1 line from #17228 URL: https://github.com/apache/incubator-mxnet/pull/17993#issuecomment-610542718 @mxnet-bot run ci [unix-cpu] This is an automated message from

[GitHub] [incubator-mxnet] aaronmarkham commented on issue #17927: update ruby & jekyll, remove incompatible plugins

2020-04-07 Thread GitBox
aaronmarkham commented on issue #17927: update ruby & jekyll, remove incompatible plugins URL: https://github.com/apache/incubator-mxnet/pull/17927#issuecomment-610560438 @mxnet-bot run ci [unix-gpu] This is an automated

[GitHub] [incubator-mxnet] mxnet-bot commented on issue #17927: update ruby & jekyll, remove incompatible plugins

2020-04-07 Thread GitBox
mxnet-bot commented on issue #17927: update ruby & jekyll, remove incompatible plugins URL: https://github.com/apache/incubator-mxnet/pull/17927#issuecomment-610560513 Jenkins CI successfully triggered : [unix-gpu] This is

[GitHub] [incubator-mxnet] aaronmarkham commented on issue #17959: [MKLDNN] Add LSTMP to v1.6.x

2020-04-07 Thread GitBox
aaronmarkham commented on issue #17959: [MKLDNN] Add LSTMP to v1.6.x URL: https://github.com/apache/incubator-mxnet/pull/17959#issuecomment-610517907 > The issue related to R package test is fixed with importing the function first, using `library(methods)` > I've made the change to

[GitHub] [incubator-mxnet] sxjscience commented on issue #17989: [Gradient Addto] Very serious bug of grad_req='add'

2020-04-07 Thread GitBox
sxjscience commented on issue #17989: [Gradient Addto] Very serious bug of grad_req='add' URL: https://github.com/apache/incubator-mxnet/issues/17989#issuecomment-610595164 @ptrendx @zhreshold @szha I tried to run with MXNet==1.0.0 but it give me another error. The earliest version I can

[GitHub] [incubator-mxnet] ChaiBapchya edited a comment on issue #17937: Fix for handling negative indices in the fusion of slice

2020-04-07 Thread GitBox
ChaiBapchya edited a comment on issue #17937: Fix for handling negative indices in the fusion of slice URL: https://github.com/apache/incubator-mxnet/pull/17937#issuecomment-610474354 Yes. Getting a stacktrace as it hangs needs to be done before the instance is shut down by the autoscaler

[GitHub] [incubator-mxnet] ChaiBapchya commented on issue #17920: R docs generation error

2020-04-07 Thread GitBox
ChaiBapchya commented on issue #17920: R docs generation error URL: https://github.com/apache/incubator-mxnet/issues/17920#issuecomment-610501295 Add that patch on v1.6.x Testing it locally first. If it passes, will create a PR to fix the issue.

[GitHub] [incubator-mxnet] ChaiBapchya edited a comment on issue #17920: R docs generation error

2020-04-07 Thread GitBox
ChaiBapchya edited a comment on issue #17920: R docs generation error URL: https://github.com/apache/incubator-mxnet/issues/17920#issuecomment-610501295 Added that patch on v1.6.x Testing it locally first. If it passes, will create a PR to fix the issue.

[GitHub] [incubator-mxnet] rondogency commented on issue #17762: Custom Operator Random Number Generator Support

2020-04-07 Thread GitBox
rondogency commented on issue #17762: Custom Operator Random Number Generator Support URL: https://github.com/apache/incubator-mxnet/pull/17762#issuecomment-610516730 @mxnet-bot run ci [unix-gpu, windows-gpu] This is an

[GitHub] [incubator-mxnet] mxnet-bot commented on issue #17762: Custom Operator Random Number Generator Support

2020-04-07 Thread GitBox
mxnet-bot commented on issue #17762: Custom Operator Random Number Generator Support URL: https://github.com/apache/incubator-mxnet/pull/17762#issuecomment-610516774 Jenkins CI successfully triggered : [windows-gpu, unix-gpu]

[GitHub] [incubator-mxnet] leezu commented on issue #17992: MKLDNNConvolutionBackward accesses out of bound elements

2020-04-07 Thread GitBox
leezu commented on issue #17992: MKLDNNConvolutionBackward accesses out of bound elements URL: https://github.com/apache/incubator-mxnet/issues/17992#issuecomment-610524257 Notice that there are also other issues with this test https://github.com/apache/incubator-mxnet/pull/15631

[GitHub] [incubator-mxnet] ChaiBapchya opened a new pull request #17993: fix R error; backport 1 line from #17228

2020-04-07 Thread GitBox
ChaiBapchya opened a new pull request #17993: fix R error; backport 1 line from #17228 URL: https://github.com/apache/incubator-mxnet/pull/17993 Fix setRefClass not found issue by adding import of library `methods` This is

[GitHub] [incubator-mxnet] mxnet-bot commented on issue #17993: fix R error; backport 1 line from #17228

2020-04-07 Thread GitBox
mxnet-bot commented on issue #17993: fix R error; backport 1 line from #17228 URL: https://github.com/apache/incubator-mxnet/pull/17993#issuecomment-610541518 Hey @ChaiBapchya , Thanks for submitting the PR All tests are already queued to run once. If tests fail, you can trigger one or

[GitHub] [incubator-mxnet] D-Roberts commented on issue #17851: [Numpy] np.linalg.qr forward implementation

2020-04-07 Thread GitBox
D-Roberts commented on issue #17851: [Numpy] np.linalg.qr forward implementation URL: https://github.com/apache/incubator-mxnet/pull/17851#issuecomment-610550941 @mxnet-bot run ci [all] This is an automated message from the

[GitHub] [incubator-mxnet] mxnet-bot commented on issue #17851: [Numpy] np.linalg.qr forward implementation

2020-04-07 Thread GitBox
mxnet-bot commented on issue #17851: [Numpy] np.linalg.qr forward implementation URL: https://github.com/apache/incubator-mxnet/pull/17851#issuecomment-610551042 Jenkins CI successfully triggered : [centos-gpu, sanity, unix-gpu, miscellaneous, edge, centos-cpu, website, unix-cpu, clang,

[GitHub] [incubator-mxnet] sxjscience commented on issue #17989: [Gradient Addto] Very serious bug of grad_req='add'

2020-04-07 Thread GitBox
sxjscience commented on issue #17989: [Gradient Addto] Very serious bug of grad_req='add' URL: https://github.com/apache/incubator-mxnet/issues/17989#issuecomment-610591835 @ptrendx @szha @zhreshold I find that the bug also exists in 1.5.0, 1.4.0, 1.3.1, 1.2.1. In fact, results on both

[GitHub] [incubator-mxnet] ChaiBapchya commented on issue #17959: [MKLDNN] Add LSTMP to v1.6.x

2020-04-07 Thread GitBox
ChaiBapchya commented on issue #17959: [MKLDNN] Add LSTMP to v1.6.x URL: https://github.com/apache/incubator-mxnet/pull/17959#issuecomment-610502426 The issue related to R package test is fixed with importing the function first, using `library(methods)` I've made the change to v1.6.x

[GitHub] [incubator-mxnet] gaurav1086 commented on issue #17934: Remove duplicate condition

2020-04-07 Thread GitBox
gaurav1086 commented on issue #17934: Remove duplicate condition URL: https://github.com/apache/incubator-mxnet/pull/17934#issuecomment-610511798 @mxnet-bot run ci [unix-gpu] This is an automated message from the Apache Git

[GitHub] [incubator-mxnet] mxnet-bot commented on issue #17934: Remove duplicate condition

2020-04-07 Thread GitBox
mxnet-bot commented on issue #17934: Remove duplicate condition URL: https://github.com/apache/incubator-mxnet/pull/17934#issuecomment-610511873 Jenkins CI successfully triggered : [unix-gpu] This is an automated message from

[GitHub] [incubator-mxnet] ptrendx commented on issue #17989: [Gradient Addto] Very serious bug of grad_req='add'

2020-04-07 Thread GitBox
ptrendx commented on issue #17989: [Gradient Addto] Very serious bug of grad_req='add' URL: https://github.com/apache/incubator-mxnet/issues/17989#issuecomment-610591415 Hmm, I just tried the latest script from @sxjscience and I got exactly opposite results - gpu working as expected and

[incubator-mxnet] branch master updated (002d4f1 -> 79c576b)

2020-04-07 Thread skm
This is an automated email from the ASF dual-hosted git repository. skm pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-mxnet.git. from 002d4f1 * impl - FFi for linalg op (#17795) add 79c576b [ONNX export] Fixing spatial export for

[incubator-mxnet] branch master updated (a960f5a -> f906a02)

2020-04-07 Thread haoj
This is an automated email from the ASF dual-hosted git repository. haoj pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-mxnet.git. from a960f5a ffi_array_split, v/h/dsplit (#17873) add f906a02 ffi_atleast_1/2/3d (#17897) No new revisions

[incubator-mxnet] branch master updated (a960f5a -> f906a02)

2020-04-07 Thread haoj
This is an automated email from the ASF dual-hosted git repository. haoj pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-mxnet.git. from a960f5a ffi_array_split, v/h/dsplit (#17873) add f906a02 ffi_atleast_1/2/3d (#17897) No new revisions

[GitHub] [incubator-mxnet] shuokay commented on issue #17944: How to split symbol?

2020-04-07 Thread GitBox
shuokay commented on issue #17944: How to split symbol? URL: https://github.com/apache/incubator-mxnet/issues/17944#issuecomment-610693985 I think `mx.sym.slice` is what you need. This is an automated message from the Apache

[GitHub] [incubator-mxnet] mxnet-bot commented on issue #17885: [WIP] MXNet Extensions enhancements

2020-04-07 Thread GitBox
mxnet-bot commented on issue #17885: [WIP] MXNet Extensions enhancements URL: https://github.com/apache/incubator-mxnet/pull/17885#issuecomment-610630046 Jenkins CI successfully triggered : [sanity] This is an automated

[GitHub] [incubator-mxnet] samskalicky commented on issue #17885: [WIP] MXNet Extensions enhancements

2020-04-07 Thread GitBox
samskalicky commented on issue #17885: [WIP] MXNet Extensions enhancements URL: https://github.com/apache/incubator-mxnet/pull/17885#issuecomment-610629994 @mxnet-bot run ci [sanity] This is an automated message from

[incubator-mxnet-site] branch asf-site updated: Bump the publish timestamp.

2020-04-07 Thread aaronmarkham
This is an automated email from the ASF dual-hosted git repository. aaronmarkham pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/incubator-mxnet-site.git The following commit(s) were added to refs/heads/asf-site by this push: new 9029c98 Bump the

[GitHub] [incubator-mxnet] samskalicky commented on issue #17885: [WIP] MXNet Extensions enhancements

2020-04-07 Thread GitBox
samskalicky commented on issue #17885: [WIP] MXNet Extensions enhancements URL: https://github.com/apache/incubator-mxnet/pull/17885#issuecomment-610693459 @mxnet-bot run ci [sanity] This is an automated message from

[GitHub] [incubator-mxnet] mxnet-bot commented on issue #17885: [WIP] MXNet Extensions enhancements

2020-04-07 Thread GitBox
mxnet-bot commented on issue #17885: [WIP] MXNet Extensions enhancements URL: https://github.com/apache/incubator-mxnet/pull/17885#issuecomment-610693482 Jenkins CI successfully triggered : [sanity] This is an automated

[GitHub] [incubator-mxnet] blchu opened a new pull request #17994: Tensor cores used only for fp16 in interleaved multihead attention

2020-04-07 Thread GitBox
blchu opened a new pull request #17994: Tensor cores used only for fp16 in interleaved multihead attention URL: https://github.com/apache/incubator-mxnet/pull/17994 ## Description ## Fixed issue where fp32 inputs use tensor cores for the interleaved multihead attention operators,

[GitHub] [incubator-mxnet] mxnet-bot commented on issue #17994: Tensor cores used only for fp16 in interleaved multihead attention

2020-04-07 Thread GitBox
mxnet-bot commented on issue #17994: Tensor cores used only for fp16 in interleaved multihead attention URL: https://github.com/apache/incubator-mxnet/pull/17994#issuecomment-610624507 Hey @blchu , Thanks for submitting the PR All tests are already queued to run once. If tests fail,

[GitHub] [incubator-mxnet] ptrendx commented on issue #17989: [Autograd] Very serious bug of grad_req='add'

2020-04-07 Thread GitBox
ptrendx commented on issue #17989: [Autograd] Very serious bug of grad_req='add' URL: https://github.com/apache/incubator-mxnet/issues/17989#issuecomment-610639500 @zhreshold And for any op that you check you introduce the elemwisesum node in the backward pass that aggregates the

[GitHub] [incubator-mxnet] ptrendx commented on a change in pull request #17977: Relaxing type requirements for broadcast_like

2020-04-07 Thread GitBox
ptrendx commented on a change in pull request #17977: Relaxing type requirements for broadcast_like URL: https://github.com/apache/incubator-mxnet/pull/17977#discussion_r405177613 ## File path: src/operator/tensor/broadcast_reduce_op_value.cc ## @@ -138,7 +138,16 @@

[incubator-mxnet] branch master updated (a960f5a -> f906a02)

2020-04-07 Thread haoj
This is an automated email from the ASF dual-hosted git repository. haoj pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-mxnet.git. from a960f5a ffi_array_split, v/h/dsplit (#17873) add f906a02 ffi_atleast_1/2/3d (#17897) No new revisions

[incubator-mxnet] branch master updated (892f982 -> a960f5a)

2020-04-07 Thread haoj
This is an automated email from the ASF dual-hosted git repository. haoj pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-mxnet.git. from 892f982 * impl - linalg.lstsq for cpu (#17950) add a960f5a ffi_array_split, v/h/dsplit (#17873) No

[GitHub] [incubator-mxnet] sxjscience commented on issue #17989: [Gradient Addto] Very serious bug of grad_req='add'

2020-04-07 Thread GitBox
sxjscience commented on issue #17989: [Gradient Addto] Very serious bug of grad_req='add' URL: https://github.com/apache/incubator-mxnet/issues/17989#issuecomment-610596656 @ptrendx I'm using a compiled version of master. Are you able to reproduce it using the script I attached at the

[GitHub] [incubator-mxnet] ptrendx commented on issue #17989: [Autograd] Very serious bug of grad_req='add'

2020-04-07 Thread GitBox
ptrendx commented on issue #17989: [Autograd] Very serious bug of grad_req='add' URL: https://github.com/apache/incubator-mxnet/issues/17989#issuecomment-610598084 I first tried on our container (which is based on 1.6.0), since that is the easiest thing for me to try first. When I tried

[GitHub] [incubator-mxnet] ptrendx commented on issue #17989: [Autograd] Very serious bug of grad_req='add'

2020-04-07 Thread GitBox
ptrendx commented on issue #17989: [Autograd] Very serious bug of grad_req='add' URL: https://github.com/apache/incubator-mxnet/issues/17989#issuecomment-610604273 It is ElementwiseSum, although I'm not sure why after 7 repeats you get correct result again. The code of ElementwiseSum

[incubator-mxnet] branch master updated (002d4f1 -> 79c576b)

2020-04-07 Thread skm
This is an automated email from the ASF dual-hosted git repository. skm pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-mxnet.git. from 002d4f1 * impl - FFi for linalg op (#17795) add 79c576b [ONNX export] Fixing spatial export for

[incubator-mxnet] branch master updated (002d4f1 -> 79c576b)

2020-04-07 Thread skm
This is an automated email from the ASF dual-hosted git repository. skm pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-mxnet.git. from 002d4f1 * impl - FFi for linalg op (#17795) add 79c576b [ONNX export] Fixing spatial export for

[GitHub] [incubator-mxnet] emfomenk commented on issue #17980: When compiled with MKL, fully_connected calls DNNL while dot and batch_dot call MKL

2020-04-07 Thread GitBox
emfomenk commented on issue #17980: When compiled with MKL, fully_connected calls DNNL while dot and batch_dot call MKL URL: https://github.com/apache/incubator-mxnet/issues/17980#issuecomment-610648623 > I tried single-threaded (OMP_NUM_THREADS=1) and still saw a performance drop. There

[GitHub] [incubator-mxnet] haojin2 merged pull request #17950: [Numpy] Add op linalg.lstsq

2020-04-07 Thread GitBox
haojin2 merged pull request #17950: [Numpy] Add op linalg.lstsq URL: https://github.com/apache/incubator-mxnet/pull/17950 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [incubator-mxnet] ptrendx commented on issue #17989: [Autograd] Very serious bug of grad_req='add'

2020-04-07 Thread GitBox
ptrendx commented on issue #17989: [Autograd] Very serious bug of grad_req='add' URL: https://github.com/apache/incubator-mxnet/issues/17989#issuecomment-610605942 It does not explain why it does the right thing for nrepeat=8 forward. There has to be something else going on there that

[GitHub] [incubator-mxnet] sandeep-krishnamurthy merged pull request #17711: [ONNX export] Fixing spatial export for batchnorm

2020-04-07 Thread GitBox
sandeep-krishnamurthy merged pull request #17711: [ONNX export] Fixing spatial export for batchnorm URL: https://github.com/apache/incubator-mxnet/pull/17711 This is an automated message from the Apache Git Service. To

[GitHub] [incubator-mxnet] zhreshold commented on issue #17989: [Autograd] Very serious bug of grad_req='add'

2020-04-07 Thread GitBox
zhreshold commented on issue #17989: [Autograd] Very serious bug of grad_req='add' URL: https://github.com/apache/incubator-mxnet/issues/17989#issuecomment-610623359 I don't think it's related to particular op implementation, it's something may not be working at all when autograd is

[GitHub] [incubator-mxnet] D-Roberts commented on issue #17851: [Numpy] np.linalg.qr forward implementation

2020-04-07 Thread GitBox
D-Roberts commented on issue #17851: [Numpy] np.linalg.qr forward implementation URL: https://github.com/apache/incubator-mxnet/pull/17851#issuecomment-610648177 @mxnet-bot run ci [unix-gpu] This is an automated message from

[GitHub] [incubator-mxnet] mxnet-bot commented on issue #17851: [Numpy] np.linalg.qr forward implementation

2020-04-07 Thread GitBox
mxnet-bot commented on issue #17851: [Numpy] np.linalg.qr forward implementation URL: https://github.com/apache/incubator-mxnet/pull/17851#issuecomment-610648212 Jenkins CI successfully triggered : [unix-gpu] This is an

[GitHub] [incubator-mxnet] mxnet-bot commented on issue #17995: Fix ElemwiseSum for more than 4 inputs

2020-04-07 Thread GitBox
mxnet-bot commented on issue #17995: Fix ElemwiseSum for more than 4 inputs URL: https://github.com/apache/incubator-mxnet/pull/17995#issuecomment-610661204 Hey @ptrendx , Thanks for submitting the PR All tests are already queued to run once. If tests fail, you can trigger one or more

[GitHub] [incubator-mxnet] ptrendx opened a new pull request #17995: Fix ElemwiseSum for more than 4 inputs

2020-04-07 Thread GitBox
ptrendx opened a new pull request #17995: Fix ElemwiseSum for more than 4 inputs URL: https://github.com/apache/incubator-mxnet/pull/17995 ## Description ## Fixes #17989 It was caused by a bug in `ElemwiseSum` which for more than 4 inputs and `kAddTo` req was counting gradients

[GitHub] [incubator-mxnet] samskalicky edited a comment on issue #17885: [WIP] MXNet Extensions enhancements

2020-04-07 Thread GitBox
samskalicky edited a comment on issue #17885: [WIP] MXNet Extensions enhancements URL: https://github.com/apache/incubator-mxnet/pull/17885#issuecomment-610669060 @mxnet-bot run ci [sanity] This is an automated

[GitHub] [incubator-mxnet] mxnet-bot commented on issue #17885: [WIP] MXNet Extensions enhancements

2020-04-07 Thread GitBox
mxnet-bot commented on issue #17885: [WIP] MXNet Extensions enhancements URL: https://github.com/apache/incubator-mxnet/pull/17885#issuecomment-610669252 Jenkins CI successfully triggered : [sanity] This is an automated

[GitHub] [incubator-mxnet] samskalicky commented on issue #17885: [WIP] MXNet Extensions enhancements

2020-04-07 Thread GitBox
samskalicky commented on issue #17885: [WIP] MXNet Extensions enhancements URL: https://github.com/apache/incubator-mxnet/pull/17885#issuecomment-610669060 Jenkins CI successfully triggered : [sanity] This is an

[incubator-mxnet] branch master updated (892f982 -> a960f5a)

2020-04-07 Thread haoj
This is an automated email from the ASF dual-hosted git repository. haoj pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-mxnet.git. from 892f982 * impl - linalg.lstsq for cpu (#17950) add a960f5a ffi_array_split, v/h/dsplit (#17873) No

[incubator-mxnet] branch master updated (79c576b -> 892f982)

2020-04-07 Thread haoj
This is an automated email from the ASF dual-hosted git repository. haoj pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-mxnet.git. from 79c576b [ONNX export] Fixing spatial export for batchnorm (#17711) add 892f982 * impl - linalg.lstsq

[GitHub] [incubator-mxnet] kpu commented on issue #17980: When compiled with MKL, fully_connected calls DNNL while dot and batch_dot call MKL

2020-04-07 Thread GitBox
kpu commented on issue #17980: When compiled with MKL, fully_connected calls DNNL while dot and batch_dot call MKL URL: https://github.com/apache/incubator-mxnet/issues/17980#issuecomment-610643813 > If Intel MKL is linked MKL was linked in both cases and in fact called in both

[GitHub] [incubator-mxnet] sxjscience commented on issue #17989: [Autograd] Very serious bug of grad_req='add'

2020-04-07 Thread GitBox
sxjscience commented on issue #17989: [Autograd] Very serious bug of grad_req='add' URL: https://github.com/apache/incubator-mxnet/issues/17989#issuecomment-610643223 @ptrendx After checking the source code, I think it's due to the `MXNET_EXEC_INPLACE_GRAD_SUM_CAP` setting to 8 by

[GitHub] [incubator-mxnet] ptrendx commented on issue #17989: [Autograd] Very serious bug of grad_req='add'

2020-04-07 Thread GitBox
ptrendx commented on issue #17989: [Autograd] Very serious bug of grad_req='add' URL: https://github.com/apache/incubator-mxnet/issues/17989#issuecomment-610646412 Yup, setting that env variable (undocumented BTW ;-) ) to higher value makes the test fail for the higher cases too.

[incubator-mxnet] branch master updated (79c576b -> 892f982)

2020-04-07 Thread haoj
This is an automated email from the ASF dual-hosted git repository. haoj pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-mxnet.git. from 79c576b [ONNX export] Fixing spatial export for batchnorm (#17711) add 892f982 * impl - linalg.lstsq

[GitHub] [incubator-mxnet] haojin2 merged pull request #17897: [Numpy] FFI: atleast_1/2/3d

2020-04-07 Thread GitBox
haojin2 merged pull request #17897: [Numpy] FFI: atleast_1/2/3d URL: https://github.com/apache/incubator-mxnet/pull/17897 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [incubator-mxnet] haojin2 merged pull request #17873: [Numpy] FFI: array_split, v/h/dsplit

2020-04-07 Thread GitBox
haojin2 merged pull request #17873: [Numpy] FFI: array_split, v/h/dsplit URL: https://github.com/apache/incubator-mxnet/pull/17873 This is an automated message from the Apache Git Service. To respond to the message, please

[incubator-mxnet] branch master updated (f906a02 -> 16ddc6d)

2020-04-07 Thread lausen
This is an automated email from the ASF dual-hosted git repository. lausen pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-mxnet.git. from f906a02 ffi_atleast_1/2/3d (#17897) add 16ddc6d Custom Operator Random Number Generator Support

[GitHub] [incubator-mxnet] leezu merged pull request #17762: Custom Operator Random Number Generator Support

2020-04-07 Thread GitBox
leezu merged pull request #17762: Custom Operator Random Number Generator Support URL: https://github.com/apache/incubator-mxnet/pull/17762 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [incubator-mxnet] pengzhao-intel commented on issue #17872: Fix issue of zeros gradients w.r.t. RNN bias when num_layers > 1

2020-04-07 Thread GitBox
pengzhao-intel commented on issue #17872: Fix issue of zeros gradients w.r.t. RNN bias when num_layers > 1 URL: https://github.com/apache/incubator-mxnet/pull/17872#issuecomment-610691835 > @zixuanweeei Thanks for your contribution, could you also cherry-pick the commit to 1.7? DJL LSTM

[GitHub] [incubator-mxnet] sxjscience commented on issue #17989: [Autograd] Very serious bug of grad_req='add'

2020-04-07 Thread GitBox
sxjscience commented on issue #17989: [Autograd] Very serious bug of grad_req='add' URL: https://github.com/apache/incubator-mxnet/issues/17989#issuecomment-610599468 May be it's not related to specific implementation in the GPU side.

[GitHub] [incubator-mxnet] sxjscience commented on issue #17989: [Autograd] Very serious bug of grad_req='add'

2020-04-07 Thread GitBox
sxjscience commented on issue #17989: [Autograd] Very serious bug of grad_req='add' URL: https://github.com/apache/incubator-mxnet/issues/17989#issuecomment-610605521 @ptrendx Thanks! I think that explains the cause. This

[GitHub] [incubator-mxnet] ptrendx commented on issue #17989: [Autograd] Very serious bug of grad_req='add'

2020-04-07 Thread GitBox
ptrendx commented on issue #17989: [Autograd] Very serious bug of grad_req='add' URL: https://github.com/apache/incubator-mxnet/issues/17989#issuecomment-610605392 I don't see this issue in our (not yet released) container because I changed ElementwiseSum implementation to be vectorized,

[GitHub] [incubator-mxnet] leezu commented on issue #17995: Fix ElemwiseSum for more than 4 inputs

2020-04-07 Thread GitBox
leezu commented on issue #17995: Fix ElemwiseSum for more than 4 inputs URL: https://github.com/apache/incubator-mxnet/pull/17995#issuecomment-610666920 Should we add a test case in the style of https://github.com/apache/incubator-mxnet/issues/17989#issuecomment-610591835 to ensure no

[GitHub] [incubator-mxnet] ptrendx commented on issue #17984: Raise toolchain requirements for MXNet 2

2020-04-07 Thread GitBox
ptrendx commented on issue #17984: Raise toolchain requirements for MXNet 2 URL: https://github.com/apache/incubator-mxnet/pull/17984#issuecomment-610675875 Note: With this we will be able to change shared_ptr here:

[GitHub] [incubator-mxnet] haojin2 commented on a change in pull request #17904: [Numpy] add: numpy op trilindices

2020-04-07 Thread GitBox
haojin2 commented on a change in pull request #17904: [Numpy] add: numpy op trilindices URL: https://github.com/apache/incubator-mxnet/pull/17904#discussion_r405196267 ## File path: src/operator/numpy/np_matrix_op-inl.h ## @@ -287,6 +287,106 @@ void

[GitHub] [incubator-mxnet] haojin2 commented on a change in pull request #17904: [Numpy] add: numpy op trilindices

2020-04-07 Thread GitBox
haojin2 commented on a change in pull request #17904: [Numpy] add: numpy op trilindices URL: https://github.com/apache/incubator-mxnet/pull/17904#discussion_r405196087 ## File path: src/operator/numpy/np_matrix_op.cc ## @@ -1115,6 +1115,66 @@

[GitHub] [incubator-mxnet] haojin2 commented on a change in pull request #17904: [Numpy] add: numpy op trilindices

2020-04-07 Thread GitBox
haojin2 commented on a change in pull request #17904: [Numpy] add: numpy op trilindices URL: https://github.com/apache/incubator-mxnet/pull/17904#discussion_r405196183 ## File path: src/operator/numpy/np_matrix_op.cc ## @@ -1115,6 +1115,66 @@

[GitHub] [incubator-mxnet] pengzhao-intel commented on issue #17980: When compiled with MKL, fully_connected calls DNNL while dot and batch_dot call MKL

2020-04-07 Thread GitBox
pengzhao-intel commented on issue #17980: When compiled with MKL, fully_connected calls DNNL while dot and batch_dot call MKL URL: https://github.com/apache/incubator-mxnet/issues/17980#issuecomment-610706449 Thanks @emfomenk & @TaoLv to identify the issue. Our team will follow up on

[GitHub] [incubator-mxnet] djaym7 closed issue #17939: Ways of Freezing part of parameter and not the whole layer.

2020-04-07 Thread GitBox
djaym7 closed issue #17939: Ways of Freezing part of parameter and not the whole layer. URL: https://github.com/apache/incubator-mxnet/issues/17939 This is an automated message from the Apache Git Service. To respond to the

[incubator-mxnet] branch master updated: [mkldnn] optimize for mkldnn batchnorm backward (#17902)

2020-04-07 Thread patriczhao
This is an automated email from the ASF dual-hosted git repository. patriczhao pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-mxnet.git The following commit(s) were added to refs/heads/master by this push: new 13841dd [mkldnn] optimize for

[GitHub] [incubator-mxnet] mxnet-bot commented on issue #17974: Add instructions on distributed MXNet with Horovod on Kubernetes

2020-04-07 Thread GitBox
mxnet-bot commented on issue #17974: Add instructions on distributed MXNet with Horovod on Kubernetes URL: https://github.com/apache/incubator-mxnet/pull/17974#issuecomment-610698797 Jenkins CI successfully triggered : [clang, centos-cpu, website, windows-gpu, sanity, windows-cpu, edge,

  1   2   >