larroy commented on a change in pull request #8398: fix topk with big shape
URL: https://github.com/apache/incubator-mxnet/pull/8398#discussion_r180082288
##########
File path: tests/python/unittest/test_ndarray.py
##########
@@ -593,6 +593,10 @@ def gt_topk(dat, axis, ret_typ, k, is_ascend):
nd_ret_argsort = mx.nd.argsort(a_nd, axis=None, is_ascend=False).asnumpy()
gt = gt_topk(a_npy, axis=None, ret_typ="indices", k=5*5*5*5,
is_ascend=False)
assert_almost_equal(nd_ret_argsort, gt)
+
+ # test topk with a big shape
+ a = mx.nd.arange(0, 54686454, step=1, repeat=1)
Review comment:
Is not clear what was the problem and how the fix works.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
