[GitHub] [incubator-mxnet] ChaiBapchya commented on a change in pull request #17309: adding docs for 64bit C APIs of large tensor and removing not required int64 C APIs
ChaiBapchya commented on a change in pull request #17309: adding docs for 64bit C APIs of large tensor and removing not required int64 C APIs URL: https://github.com/apache/incubator-mxnet/pull/17309#discussion_r366608184 ## File path: include/mxnet/c_api.h ## @@ -1784,28 +1884,14 @@ MXNET_DLL int MXSymbolInferShapePartial(SymbolHandle sym, const uint32_t ***aux_shape_data, int *complete); -MXNET_DLL int MXSymbolInferShapePartial64(SymbolHandle sym, - uint32_t num_args, - const char** keys, - const int64_t *arg_ind_ptr, - const int64_t *arg_shape_data, - size_t *in_shape_size, - const int **in_shape_ndim, - const int64_t ***in_shape_data, - size_t *out_shape_size, - const int **out_shape_ndim, - const int64_t ***out_shape_data, - size_t *aux_shape_size, - const int **aux_shape_ndim, - const int64_t ***aux_shape_data, - int *complete); - /*! * \brief partially infer shape of unknown input shapes given the known one. * * Return partially inferred results if not all shapes could be inferred. * The shapes are packed into a CSR matrix represented by arg_ind_ptr and arg_shape_data * The call will be treated as a kwargs call if key != nullptr or num_args==0, otherwise it is positional. + * This api is available when MXNet is built with flag + * USE_INT64_TENSOR_SIZE=0 (by default) * * \param sym symbol handle * \param num_args numbe of input arguments. Review comment: ```suggestion * \param num_args number of input arguments. ``` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-mxnet] ChaiBapchya commented on a change in pull request #17309: adding docs for 64bit C APIs of large tensor and removing not required int64 C APIs
ChaiBapchya commented on a change in pull request #17309: adding docs for 64bit C APIs of large tensor and removing not required int64 C APIs URL: https://github.com/apache/incubator-mxnet/pull/17309#discussion_r366607671 ## File path: include/mxnet/c_api.h ## @@ -1840,6 +1926,32 @@ MXNET_DLL int MXSymbolInferShapePartialEx(SymbolHandle sym, const int ***aux_shape_data, int *complete); +/*! + * \brief partially infer shape of unknown input shapes given the known one. + * + * Return partially inferred results if not all shapes could be inferred. + * The shapes are packed into a CSR matrix represented by arg_ind_ptr and arg_shape_data + * The call will be treated as a kwargs call if key != nullptr or num_args==0, otherwise it is positional. + * This api is available when MXNet is built with flag + * USE_INT64_TENSOR_SIZE=1 (not default) i.e. Large Tensor Support + * + * \param sym symbol handle + * \param num_args numbe of input arguments. Review comment: ```suggestion * \param num_args number of input arguments. ``` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-mxnet] ChaiBapchya commented on a change in pull request #17309: adding docs for 64bit C APIs of large tensor and removing not required int64 C APIs
ChaiBapchya commented on a change in pull request #17309: adding docs for 64bit C APIs of large tensor and removing not required int64 C APIs URL: https://github.com/apache/incubator-mxnet/pull/17309#discussion_r366608014 ## File path: include/mxnet/c_api.h ## @@ -1673,27 +1765,12 @@ MXNET_DLL int MXSymbolInferShape(SymbolHandle sym, const uint32_t ***aux_shape_data, int *complete); -MXNET_DLL int MXSymbolInferShape64(SymbolHandle sym, - uint32_t num_args, - const char** keys, - const int64_t *arg_ind_ptr, - const int64_t *arg_shape_data, - size_t *in_shape_size, - const int **in_shape_ndim, - const int64_t ***in_shape_data, - size_t *out_shape_size, - const int **out_shape_ndim, - const int64_t ***out_shape_data, - size_t *aux_shape_size, - const int **aux_shape_ndim, - const int64_t ***aux_shape_data, - int *complete); - /*! * \brief infer shape of unknown input shapes given the known one. * The shapes are packed into a CSR matrix represented by arg_ind_ptr and arg_shape_data * The call will be treated as a kwargs call if key != nullptr or num_args==0, otherwise it is positional. - * + * This api is available when MXNet is built with flag + * USE_INT64_TENSOR_SIZE=0 (by default) * \param sym symbol handle * \param num_args numbe of input arguments. Review comment: ```suggestion * \param num_args number of input arguments. ``` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-mxnet] ChaiBapchya commented on a change in pull request #17309: adding docs for 64bit C APIs of large tensor and removing not required int64 C APIs
ChaiBapchya commented on a change in pull request #17309: adding docs for 64bit C APIs of large tensor and removing not required int64 C APIs URL: https://github.com/apache/incubator-mxnet/pull/17309#discussion_r366606053 ## File path: include/mxnet/c_api.h ## @@ -1840,6 +1926,32 @@ MXNET_DLL int MXSymbolInferShapePartialEx(SymbolHandle sym, const int ***aux_shape_data, int *complete); +/*! + * \brief partially infer shape of unknown input shapes given the known one. + * + * Return partially inferred results if not all shapes could be inferred. + * The shapes are packed into a CSR matrix represented by arg_ind_ptr and arg_shape_data + * The call will be treated as a kwargs call if key != nullptr or num_args==0, otherwise it is positional. + * This api is available when MXNet is built with flag + * USE_INT64_TENSOR_SIZE=1 (not default) i.e. Large Tensor Support + * + * \param sym symbol handle + * \param num_args numbe of input arguments. + * \param keys the key of keyword args (optional) + * \param arg_ind_ptr the head pointer of the rows in CSR + * \param arg_shape_data the content of the CSR + * \param in_shape_size sizeof the returning array of in_shapes + * \param in_shape_ndim returning array of shape dimensions of eachs input shape. + * \param in_shape_data returning array of pointers to head of the input shape. + * \param out_shape_size sizeof the returning array of out_shapes + * \param out_shape_ndim returning array of shape dimensions of eachs input shape. + * \param out_shape_data returning array of pointers to head of the input shape. + * \param aux_shape_size sizeof the returning array of aux_shapes Review comment: ```suggestion * \param aux_shape_size size of the returning array of aux_shapes ``` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-mxnet] ChaiBapchya commented on a change in pull request #17309: adding docs for 64bit C APIs of large tensor and removing not required int64 C APIs
ChaiBapchya commented on a change in pull request #17309: adding docs for 64bit C APIs of large tensor and removing not required int64 C APIs URL: https://github.com/apache/incubator-mxnet/pull/17309#discussion_r366606476 ## File path: include/mxnet/c_api.h ## @@ -1727,6 +1804,29 @@ MXNET_DLL int MXSymbolInferShapeEx(SymbolHandle sym, const int ***aux_shape_data, int *complete); +/*! + * \brief infer shape of unknown input shapes given the known one. + * The shapes are packed into a CSR matrix represented by arg_ind_ptr and arg_shape_data + * The call will be treated as a kwargs call if key != nullptr or num_args==0, otherwise it is positional. + * This api is available when MXNet is built with flag + * USE_INT64_TENSOR_SIZE=1 (not default) i.e. Large Tensor Support + * \param sym symbol handle + * \param num_args numbe of input arguments. Review comment: ```suggestion * \param num_args number of input arguments. ``` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-mxnet] ChaiBapchya commented on a change in pull request #17309: adding docs for 64bit C APIs of large tensor and removing not required int64 C APIs
ChaiBapchya commented on a change in pull request #17309: adding docs for 64bit C APIs of large tensor and removing not required int64 C APIs URL: https://github.com/apache/incubator-mxnet/pull/17309#discussion_r366606351 ## File path: include/mxnet/c_api.h ## @@ -1727,6 +1804,29 @@ MXNET_DLL int MXSymbolInferShapeEx(SymbolHandle sym, const int ***aux_shape_data, int *complete); +/*! + * \brief infer shape of unknown input shapes given the known one. + * The shapes are packed into a CSR matrix represented by arg_ind_ptr and arg_shape_data + * The call will be treated as a kwargs call if key != nullptr or num_args==0, otherwise it is positional. + * This api is available when MXNet is built with flag + * USE_INT64_TENSOR_SIZE=1 (not default) i.e. Large Tensor Support + * \param sym symbol handle + * \param num_args numbe of input arguments. + * \param keys the key of keyword args (optional) + * \param arg_ind_ptr the head pointer of the rows in CSR + * \param arg_shape_data the content of the CSR + * \param in_shape_size sizeof the returning array of in_shapes + * \param in_shape_ndim returning array of shape dimensions of eachs input shape. + * \param in_shape_data returning array of pointers to head of the input shape. + * \param out_shape_size sizeof the returning array of out_shapes + * \param out_shape_ndim returning array of shape dimensions of eachs input shape. + * \param out_shape_data returning array of pointers to head of the input shape. Review comment: ```suggestion * \param out_shape_data returning array of pointers to head of the output shape. ``` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-mxnet] ChaiBapchya commented on a change in pull request #17309: adding docs for 64bit C APIs of large tensor and removing not required int64 C APIs
ChaiBapchya commented on a change in pull request #17309: adding docs for 64bit C APIs of large tensor and removing not required int64 C APIs URL: https://github.com/apache/incubator-mxnet/pull/17309#discussion_r366606283 ## File path: include/mxnet/c_api.h ## @@ -1727,6 +1804,29 @@ MXNET_DLL int MXSymbolInferShapeEx(SymbolHandle sym, const int ***aux_shape_data, int *complete); +/*! + * \brief infer shape of unknown input shapes given the known one. + * The shapes are packed into a CSR matrix represented by arg_ind_ptr and arg_shape_data + * The call will be treated as a kwargs call if key != nullptr or num_args==0, otherwise it is positional. + * This api is available when MXNet is built with flag + * USE_INT64_TENSOR_SIZE=1 (not default) i.e. Large Tensor Support + * \param sym symbol handle + * \param num_args numbe of input arguments. + * \param keys the key of keyword args (optional) + * \param arg_ind_ptr the head pointer of the rows in CSR + * \param arg_shape_data the content of the CSR + * \param in_shape_size sizeof the returning array of in_shapes + * \param in_shape_ndim returning array of shape dimensions of eachs input shape. + * \param in_shape_data returning array of pointers to head of the input shape. + * \param out_shape_size sizeof the returning array of out_shapes + * \param out_shape_ndim returning array of shape dimensions of eachs input shape. Review comment: ```suggestion * \param out_shape_ndim returning array of shape dimensions of each output shape. ``` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-mxnet] ChaiBapchya commented on a change in pull request #17309: adding docs for 64bit C APIs of large tensor and removing not required int64 C APIs
ChaiBapchya commented on a change in pull request #17309: adding docs for 64bit C APIs of large tensor and removing not required int64 C APIs URL: https://github.com/apache/incubator-mxnet/pull/17309#discussion_r366605962 ## File path: include/mxnet/c_api.h ## @@ -1840,6 +1926,32 @@ MXNET_DLL int MXSymbolInferShapePartialEx(SymbolHandle sym, const int ***aux_shape_data, int *complete); +/*! + * \brief partially infer shape of unknown input shapes given the known one. + * + * Return partially inferred results if not all shapes could be inferred. + * The shapes are packed into a CSR matrix represented by arg_ind_ptr and arg_shape_data + * The call will be treated as a kwargs call if key != nullptr or num_args==0, otherwise it is positional. + * This api is available when MXNet is built with flag + * USE_INT64_TENSOR_SIZE=1 (not default) i.e. Large Tensor Support + * + * \param sym symbol handle + * \param num_args numbe of input arguments. + * \param keys the key of keyword args (optional) + * \param arg_ind_ptr the head pointer of the rows in CSR + * \param arg_shape_data the content of the CSR + * \param in_shape_size sizeof the returning array of in_shapes + * \param in_shape_ndim returning array of shape dimensions of eachs input shape. + * \param in_shape_data returning array of pointers to head of the input shape. + * \param out_shape_size sizeof the returning array of out_shapes + * \param out_shape_ndim returning array of shape dimensions of eachs input shape. + * \param out_shape_data returning array of pointers to head of the input shape. Review comment: ```suggestion * \param out_shape_data returning array of pointers to head of the output shape. ``` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-mxnet] ChaiBapchya commented on a change in pull request #17309: adding docs for 64bit C APIs of large tensor and removing not required int64 C APIs
ChaiBapchya commented on a change in pull request #17309: adding docs for 64bit C APIs of large tensor and removing not required int64 C APIs URL: https://github.com/apache/incubator-mxnet/pull/17309#discussion_r366605886 ## File path: include/mxnet/c_api.h ## @@ -1840,6 +1926,32 @@ MXNET_DLL int MXSymbolInferShapePartialEx(SymbolHandle sym, const int ***aux_shape_data, int *complete); +/*! + * \brief partially infer shape of unknown input shapes given the known one. + * + * Return partially inferred results if not all shapes could be inferred. + * The shapes are packed into a CSR matrix represented by arg_ind_ptr and arg_shape_data + * The call will be treated as a kwargs call if key != nullptr or num_args==0, otherwise it is positional. + * This api is available when MXNet is built with flag + * USE_INT64_TENSOR_SIZE=1 (not default) i.e. Large Tensor Support + * + * \param sym symbol handle + * \param num_args numbe of input arguments. + * \param keys the key of keyword args (optional) + * \param arg_ind_ptr the head pointer of the rows in CSR + * \param arg_shape_data the content of the CSR + * \param in_shape_size sizeof the returning array of in_shapes + * \param in_shape_ndim returning array of shape dimensions of eachs input shape. + * \param in_shape_data returning array of pointers to head of the input shape. + * \param out_shape_size sizeof the returning array of out_shapes + * \param out_shape_ndim returning array of shape dimensions of eachs input shape. Review comment: ```suggestion * \param out_shape_ndim returning array of shape dimensions of eachs output shape. ``` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
