[GitHub] [incubator-mxnet] TaoLv commented on issue #15849: [mkldnn-v1.0] Rebase the feature branch to the latest master
TaoLv commented on issue #15849: [mkldnn-v1.0] Rebase the feature branch to the latest master URL: https://github.com/apache/incubator-mxnet/pull/15849#issuecomment-520870857 @pengzhao-intel Please review and approve if possible. Thanks! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-mxnet] TaoLv commented on issue #15849: [mkldnn-v1.0] Rebase the feature branch to the latest master
TaoLv commented on issue #15849: [mkldnn-v1.0] Rebase the feature branch to the latest master URL: https://github.com/apache/incubator-mxnet/pull/15849#issuecomment-520666233 > Either rebase and merge or merge commit. I'd recommend you to make a copy of the target branch and try out both methods. Then you will see the difference. "merge commit" is disabled for this repository. "rebase and merge" has conflicts per my experiment. So we just have the last option: "squash and merge". :( This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-mxnet] TaoLv commented on issue #15849: [mkldnn-v1.0] Rebase the feature branch to the latest master
TaoLv commented on issue #15849: [mkldnn-v1.0] Rebase the feature branch to the latest master URL: https://github.com/apache/incubator-mxnet/pull/15849#issuecomment-520242245 BTW, which option is preferred when merging this PR to the feature branch, "squash and merge" or "rebase and merge"? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-mxnet] TaoLv commented on issue #15849: [mkldnn-v1.0] Rebase the feature branch to the latest master
TaoLv commented on issue #15849: [mkldnn-v1.0] Rebase the feature branch to the latest master URL: https://github.com/apache/incubator-mxnet/pull/15849#issuecomment-520242089 @marcoabreu, just force pushed to the PR branch. Hope it looks good to you now. :) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-mxnet] TaoLv commented on issue #15849: [mkldnn-v1.0] Rebase the feature branch to the latest master
TaoLv commented on issue #15849: [mkldnn-v1.0] Rebase the feature branch to the latest master URL: https://github.com/apache/incubator-mxnet/pull/15849#issuecomment-520241377 Thank you @marcoabreu. I didn't know which one is a better practice. But I see the commit ids in the PR are exactly the same as they are in the master history. Anyway I will try your suggestion right now. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
