[GitHub] [incubator-mxnet] TaoLv commented on issue #17906: Optimize AddTakeGrad Tensor Sum

2020-04-05 Thread GitBox
TaoLv commented on issue #17906: Optimize AddTakeGrad Tensor Sum
URL: https://github.com/apache/incubator-mxnet/pull/17906#issuecomment-609430145
 
 
   > Sorry for the late reply.
   I tried to use opperf, but it doesn't work, some error throwed out when I 
was using it:
   File "/incubator-mxnet/benchmark/opperf/rules/default_params.py", line 606, 
in 
  "axis_shape": DEFAULT_AXIS_SHAPE,
   NameError: name 'DEFAULT_AXIS_SHAPE' is not defined
   
   FYI, @ChaiBapchya.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-mxnet] TaoLv commented on issue #17906: Optimize AddTakeGrad Tensor Sum

2020-04-05 Thread GitBox
TaoLv commented on issue #17906: Optimize AddTakeGrad Tensor Sum
URL: https://github.com/apache/incubator-mxnet/pull/17906#issuecomment-609429305
 
 
   @ElaineBao  Thank you. Impressive speedup!


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-mxnet] TaoLv commented on issue #17906: Optimize AddTakeGrad Tensor Sum

2020-04-04 Thread GitBox
TaoLv commented on issue #17906: Optimize AddTakeGrad Tensor Sum
URL: https://github.com/apache/incubator-mxnet/pull/17906#issuecomment-609039636
 
 
   The CI issue should be already addressed. Please rebase your PR and resolve 
the comments. Thanks.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-mxnet] TaoLv commented on issue #17906: Optimize AddTakeGrad Tensor Sum

2020-03-25 Thread GitBox
TaoLv commented on issue #17906: Optimize AddTakeGrad Tensor Sum
URL: https://github.com/apache/incubator-mxnet/pull/17906#issuecomment-604180544
 
 
   @ElaineBao Could you please share a benchmarking script so we can verify the 
effect of this optimization? opperf may help: 
https://github.com/apache/incubator-mxnet/tree/master/benchmark/opperf.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services