[GitHub] [incubator-mxnet] adis300 commented on issue #15303: Fix amalgamation failure.

2019-11-21 Thread GitBox
adis300 commented on issue #15303: Fix amalgamation failure. URL: https://github.com/apache/incubator-mxnet/pull/15303#issuecomment-557404304 @marcoabreu @TaoLv I have just rebased the feature onto the latest master branch and resolved related conflicts.

[GitHub] [incubator-mxnet] adis300 commented on issue #15303: Fix amalgamation failure.

2019-09-12 Thread GitBox
adis300 commented on issue #15303: Fix amalgamation failure. URL: https://github.com/apache/incubator-mxnet/pull/15303#issuecomment-531023979 Thanks @marcoabreu . @TaoLv I will try to rebase this branch and test in the next few days. Since it is very behind now. Hope the

[GitHub] [incubator-mxnet] adis300 commented on issue #15303: Fix amalgamation failure.

2019-08-26 Thread GitBox
adis300 commented on issue #15303: Fix amalgamation failure. URL: https://github.com/apache/incubator-mxnet/pull/15303#issuecomment-525051218 @TaoLv It's been a month since this branch is rebased. I am pretty sure this feature branch fixes amalgamation failure and there is currently not

[GitHub] [incubator-mxnet] adis300 commented on issue #15303: Fix amalgamation failure.

2019-08-01 Thread GitBox
adis300 commented on issue #15303: Fix amalgamation failure. URL: https://github.com/apache/incubator-mxnet/pull/15303#issuecomment-517397947 @TaoLv I rebased the branch. Windows test failed because installing `numpy` failed. This is not caused by the codes I changed. Everything else

[GitHub] [incubator-mxnet] adis300 commented on issue #15303: Fix amalgamation failure.

2019-08-01 Thread GitBox
adis300 commented on issue #15303: Fix amalgamation failure. URL: https://github.com/apache/incubator-mxnet/pull/15303#issuecomment-517319241 @TaoLv Any updates? This is an automated message from the Apache Git Service. To

[GitHub] [incubator-mxnet] adis300 commented on issue #15303: Fix amalgamation failure.

2019-07-08 Thread GitBox
adis300 commented on issue #15303: Fix amalgamation failure. URL: https://github.com/apache/incubator-mxnet/pull/15303#issuecomment-509428179 @eric-haibin-lin Can you please take a look at this PR. It is an important bug fix and has been there for half a month. The current master branch

[GitHub] [incubator-mxnet] adis300 commented on issue #15303: Fix amalgamation failure.

2019-07-03 Thread GitBox
adis300 commented on issue #15303: Fix amalgamation failure. URL: https://github.com/apache/incubator-mxnet/pull/15303#issuecomment-508158218 @TaoLv We just tried a general mxnet build with make and most works are on amalgamation without MKL-DNN. Because we want to run our python generated

[GitHub] [incubator-mxnet] adis300 commented on issue #15303: Fix amalgamation failure.

2019-07-03 Thread GitBox
adis300 commented on issue #15303: Fix amalgamation failure. URL: https://github.com/apache/incubator-mxnet/pull/15303#issuecomment-508151864 @TaoLv Check out our work at (BrainCoTech/mxnet-prebuild)[https://github.com/BrainCoTech/mxnet-prebuild/releases]. It's still at early stage but

[GitHub] [incubator-mxnet] adis300 commented on issue #15303: Fix amalgamation failure.

2019-07-03 Thread GitBox
adis300 commented on issue #15303: Fix amalgamation failure. URL: https://github.com/apache/incubator-mxnet/pull/15303#issuecomment-508145629 To reproduce the error. Simply load a model and perform forward prediction on Mac with amalgamation static/shared build. Basically, it doesn't work.

[GitHub] [incubator-mxnet] adis300 commented on issue #15303: Fix amalgamation failure.

2019-07-03 Thread GitBox
adis300 commented on issue #15303: Fix amalgamation failure. URL: https://github.com/apache/incubator-mxnet/pull/15303#issuecomment-508144343 @TaoLv I think amalgamation does need a lot of unit testing. Because it is basically broken right now. We did a lot of bash script to modify the

[GitHub] [incubator-mxnet] adis300 commented on issue #15303: Fix amalgamation failure.

2019-07-02 Thread GitBox
adis300 commented on issue #15303: Fix amalgamation failure. URL: https://github.com/apache/incubator-mxnet/pull/15303#issuecomment-507764369 @Roshrini @pengzhao-intel Please review this change as soon as possible. This is an important fix.

[GitHub] [incubator-mxnet] adis300 commented on issue #15303: Fix amalgamation failure.

2019-06-21 Thread GitBox
adis300 commented on issue #15303: Fix amalgamation failure. URL: https://github.com/apache/incubator-mxnet/pull/15303#issuecomment-504328204 Solution to the problem: add. #include "src/nnvm/plan_memory.cc" to mxnet_predict0.cc Refactor PlanMemory -> MXPlanMemory in mxnet/src/nnvm