[GitHub] [incubator-mxnet] bgawrych commented on pull request #18320: Improve log_softmax op performance by using DNNL support

2020-06-01 Thread GitBox 


bgawrych commented on pull request #18320:
URL: https://github.com/apache/incubator-mxnet/pull/18320#issuecomment-636803290


   @pengzhao-intel @TaoLv 
   Is this change gonna be merged or need more approves?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [incubator-mxnet] bgawrych commented on pull request #18320: Improve log_softmax op performance by using DNNL support

2020-05-25 Thread GitBox 


bgawrych commented on pull request #18320:
URL: https://github.com/apache/incubator-mxnet/pull/18320#issuecomment-633512830


   I have tested accuracy of Tree LSTM model to make sure MKLDNN log_softmax
   doesn't cause accuracy drop. 
   Trainings was done on the same dataset and the same seed.
   
   Tree LSTM model accuracy with MKLDNN log_softmax
   |  epoch | pearsonr | mse |
   |---|---|---|
   | 0  | 0,097245 | 1,096977 |
   | 1 | 0,100926  | 1,051807 |
   | 2 | 0,124511  | 1,039598 |
   | 3 | 0,104311  | 1,040804 |
   | 4 | 0,095321  | 1,04387   |
   | 5 | 0,126679  | 1,040978 |
   | 6 | 0,108294  | 1,043001 |
   | 7 | 0,068355  | 1,048689 |
   | 8 | 0,11179| 1,04342   |
   | 9 | 0,089656  | 1,044691 |
   
   Tree LSTM model accuracy with native log_softmax
   |  epoch | pearsonr | mse |
   |---|---|---|
   | 0  | 0,097245 | **1,096978** |
   | 1 | **0,100925**  | 1,051807 |
   | 2 | **0,124513** | 1,039598 |
   | 3 | **0,104312**  | 1,040804 |
   | 4 | 0,095321  | 1,04387   |
   | 5 | **0,126685**  | 1,040978 |
   | 6 | 0,108294  | 1,043001 |
   | 7 | 0,068355  | 1,048689 |
   | 8 | **0,111792**  | 1,04342   |
   | 9 | 0,089656  | 1,044691 |
   
   There are some slightly differences (bolded), but overall it looks like 
floating point precision issue.
   CC: @TaoLv 
   @pengzhao-intel 
   
   > Please add the new op into our list
   > https://mxnet.apache.org/versions/1.5.0/tutorials/mkldnn/operator_list.html
   
   Is this message to me or someone from amazon? Because I can't find any file 
responsible for this page



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [incubator-mxnet] bgawrych commented on pull request #18320: Improve log_softmax op performance by using DNNL support

2020-05-20 Thread GitBox 


bgawrych commented on pull request #18320:
URL: https://github.com/apache/incubator-mxnet/pull/18320#issuecomment-631329598


   @mxnet-bot run ci [miscellaneous]



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [incubator-mxnet] bgawrych commented on pull request #18320: Improve log_softmax op performance by using DNNL support

2020-05-20 Thread GitBox 


bgawrych commented on pull request #18320:
URL: https://github.com/apache/incubator-mxnet/pull/18320#issuecomment-631263232


   @mxnet-bot run ci [miscellaneous]



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [incubator-mxnet] bgawrych commented on pull request #18320: Improve log_softmax op performance by using DNNL support

2020-05-18 Thread GitBox 


bgawrych commented on pull request #18320:
URL: https://github.com/apache/incubator-mxnet/pull/18320#issuecomment-629973269


   @TaoLv @pengzhao-intel Can you look at this and ping interested people also?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [incubator-mxnet] bgawrych commented on pull request #18320: Improve log_softmax op performance by using DNNL support

2020-05-15 Thread GitBox 


bgawrych commented on pull request #18320:
URL: https://github.com/apache/incubator-mxnet/pull/18320#issuecomment-629132092


   @mxnet-bot run ci [centos-cpu, unix-cpu]



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org