[GitHub] [incubator-mxnet] leezu commented on issue #17889: Re-enable coverage on CI for GCC CPU builds

2020-03-25 Thread GitBox
leezu commented on issue #17889: Re-enable coverage on CI for GCC CPU builds URL: https://github.com/apache/incubator-mxnet/pull/17889#issuecomment-604158958 Given that's it may take significant effort and no effort was spent yet, I don't think it's realistic to expect existing test cases w

[GitHub] [incubator-mxnet] leezu commented on issue #17889: Re-enable coverage on CI for GCC CPU builds

2020-03-25 Thread GitBox
leezu commented on issue #17889: Re-enable coverage on CI for GCC CPU builds URL: https://github.com/apache/incubator-mxnet/pull/17889#issuecomment-604148386 Was there any prior effort on reducing the coverage variance during the past years? I think data was collected silently until a few m

[GitHub] [incubator-mxnet] leezu commented on issue #17889: Re-enable coverage on CI for GCC CPU builds

2020-03-25 Thread GitBox
leezu commented on issue #17889: Re-enable coverage on CI for GCC CPU builds URL: https://github.com/apache/incubator-mxnet/pull/17889#issuecomment-604128434 Thanks for explaining the reasoning. We can enable it, without marking it as required. This will expose the problem and make it ea

[GitHub] [incubator-mxnet] leezu commented on issue #17889: Re-enable coverage on CI for GCC CPU builds

2020-03-25 Thread GitBox
leezu commented on issue #17889: Re-enable coverage on CI for GCC CPU builds URL: https://github.com/apache/incubator-mxnet/pull/17889#issuecomment-604087122 @marcoabreu would it make sense to add a coverage check to the status checks listed by Github? Currently we only list CI success / fa

[GitHub] [incubator-mxnet] leezu commented on issue #17889: Re-enable coverage on CI for GCC CPU builds

2020-03-25 Thread GitBox
leezu commented on issue #17889: Re-enable coverage on CI for GCC CPU builds URL: https://github.com/apache/incubator-mxnet/pull/17889#issuecomment-604086310 @mxnet-bot run ci [windows-gpu] This is an automated message from th

[GitHub] [incubator-mxnet] leezu commented on issue #17889: Re-enable coverage on CI for GCC CPU builds

2020-03-25 Thread GitBox
leezu commented on issue #17889: Re-enable coverage on CI for GCC CPU builds URL: https://github.com/apache/incubator-mxnet/pull/17889#issuecomment-604026943 @mxnet-bot run ci [windows-gpu] This is an automated message from th

[GitHub] [incubator-mxnet] leezu commented on issue #17889: Re-enable coverage on CI for GCC CPU builds

2020-03-25 Thread GitBox
leezu commented on issue #17889: Re-enable coverage on CI for GCC CPU builds URL: https://github.com/apache/incubator-mxnet/pull/17889#issuecomment-603965017 @mxnet-bot run ci [windows-gpu] This is an automated message from th