[GitHub] [incubator-mxnet] leezu commented on issue #17906: Optimize AddTakeGrad Tensor Sum

2020-04-05 Thread GitBox
leezu commented on issue #17906: Optimize AddTakeGrad Tensor Sum
URL: https://github.com/apache/incubator-mxnet/pull/17906#issuecomment-609459052
 
 
   Opperf to be fixed by https://github.com/apache/incubator-mxnet/pull/17894


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-mxnet] leezu commented on issue #17906: Optimize AddTakeGrad Tensor Sum

2020-03-25 Thread GitBox
leezu commented on issue #17906: Optimize AddTakeGrad Tensor Sum
URL: https://github.com/apache/incubator-mxnet/pull/17906#issuecomment-604173004
 
 
   @ElaineBao do you expect this to be true at other places where tensor-level 
summation is used? If so, how about removing the tensor-level summation feature 
from mshadow and fix all places in the mxnet codebase?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-mxnet] leezu commented on issue #17906: Optimize AddTakeGrad Tensor Sum

2020-03-25 Thread GitBox
leezu commented on issue #17906: Optimize AddTakeGrad Tensor Sum
URL: https://github.com/apache/incubator-mxnet/pull/17906#issuecomment-603968342
 
 
   Is tensor-level summation slow as the compiler fails to optimize the mshadow 
implementation? Or what is the reason?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services