[GitHub] [incubator-mxnet] leezu commented on pull request #18379: change _Pragma to #pragma

2020-05-26 Thread GitBox
leezu commented on pull request #18379: URL: https://github.com/apache/incubator-mxnet/pull/18379#issuecomment-634416400 @yajiedesign please clarify how you plan to address the CI CD discrepancy? This is an automated message

[GitHub] [incubator-mxnet] leezu commented on pull request #18379: change _Pragma to #pragma

2020-05-22 Thread GitBox
leezu commented on pull request #18379: URL: https://github.com/apache/incubator-mxnet/pull/18379#issuecomment-632996894 Yes, that's an option. I'm not convinced though that only fixing this current incompatibility without introducing any mechanism of preventing future problems is helpful.

[GitHub] [incubator-mxnet] leezu commented on pull request #18379: change _Pragma to #pragma

2020-05-22 Thread GitBox
leezu commented on pull request #18379: URL: https://github.com/apache/incubator-mxnet/pull/18379#issuecomment-632974522 MXNet 2 will be released after Cuda 11 release, so there is no Cuda 9 support in MXNet 2 currently This

[GitHub] [incubator-mxnet] leezu commented on pull request #18379: change _Pragma to #pragma

2020-05-22 Thread GitBox
leezu commented on pull request #18379: URL: https://github.com/apache/incubator-mxnet/pull/18379#issuecomment-632964034 (Soon Cuda 11 will be released and we'll drop Cuda 9 support in any case) This is an automated message

[GitHub] [incubator-mxnet] leezu commented on pull request #18379: change _Pragma to #pragma

2020-05-22 Thread GitBox
leezu commented on pull request #18379: URL: https://github.com/apache/incubator-mxnet/pull/18379#issuecomment-632963894 Thanks for clarifying. In that case, should we either drop the old Cuda versions for MXNet 2 or switch the CI to an older MSVC version? What do you think? ---