[GitHub] [incubator-mxnet] lostella commented on a change in pull request #17876: Backport #17509
lostella commented on a change in pull request #17876: Backport #17509 URL: https://github.com/apache/incubator-mxnet/pull/17876#discussion_r398124506 ## File path: CMakeLists.txt ## @@ -118,7 +118,9 @@ endif() #Switch off modern thread local for dmlc-core, please see: https://github.com/dmlc/dmlc-core/issues/571#issuecomment-543467484 add_definitions(-DDMLC_MODERN_THREAD_LOCAL=0) - +# disable stack trace in exception by default. +add_definitions(-DDMLC_LOG_STACK_TRACE_SIZE=0) Review comment: (I assumed the same comment applied to the Makefile) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-mxnet] lostella commented on a change in pull request #17876: Backport #17509
lostella commented on a change in pull request #17876: Backport #17509 URL: https://github.com/apache/incubator-mxnet/pull/17876#discussion_r398124165 ## File path: CMakeLists.txt ## @@ -118,7 +118,9 @@ endif() #Switch off modern thread local for dmlc-core, please see: https://github.com/dmlc/dmlc-core/issues/571#issuecomment-543467484 add_definitions(-DDMLC_MODERN_THREAD_LOCAL=0) - +# disable stack trace in exception by default. +add_definitions(-DDMLC_LOG_STACK_TRACE_SIZE=0) Review comment: Sure, updated This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
