[GitHub] [incubator-mxnet] ys2843 commented on pull request #18288: Website global search feature

2020-05-18 Thread GitBox
ys2843 commented on pull request #18288: URL: https://github.com/apache/incubator-mxnet/pull/18288#issuecomment-630562320 @mxnet-bot run ci [unix-cpu, website] This is an automated message from the Apache Git Service. To

[GitHub] [incubator-mxnet] ys2843 commented on pull request #18288: Website global search feature

2020-05-18 Thread GitBox
ys2843 commented on pull request #18288: URL: https://github.com/apache/incubator-mxnet/pull/18288#issuecomment-630468052 > Should the version dropdown been made consistent with the global version dropdown? I mean at least default to the same version number as used in the global version

[GitHub] [incubator-mxnet] ys2843 commented on pull request #18288: Website global search feature

2020-05-18 Thread GitBox
ys2843 commented on pull request #18288: URL: https://github.com/apache/incubator-mxnet/pull/18288#issuecomment-630436025 > Thank you! > > Is it intended that the search queries entered while on the master version of the website yield results on 1.6 branch? I think it's better to be

[GitHub] [incubator-mxnet] ys2843 commented on pull request #18288: Website global search feature

2020-05-17 Thread GitBox
ys2843 commented on pull request #18288: URL: https://github.com/apache/incubator-mxnet/pull/18288#issuecomment-629832169 @mxnet-label-bot add [website] This is an automated message from the Apache Git Service. To respond to

[GitHub] [incubator-mxnet] ys2843 commented on pull request #18288: Website global search feature

2020-05-16 Thread GitBox
ys2843 commented on pull request #18288: URL: https://github.com/apache/incubator-mxnet/pull/18288#issuecomment-629681651 @mxnet-bot run ci [unix-cpu] This is an automated message from the Apache Git Service. To respond to

[GitHub] [incubator-mxnet] ys2843 commented on pull request #18288: Website global search feature

2020-05-15 Thread GitBox
ys2843 commented on pull request #18288: URL: https://github.com/apache/incubator-mxnet/pull/18288#issuecomment-629589289 @mxnet-bot run ci [unix-cpu] This is an automated message from the Apache Git Service. To respond to

[GitHub] [incubator-mxnet] ys2843 commented on pull request #18288: Website global search feature

2020-05-15 Thread GitBox
ys2843 commented on pull request #18288: URL: https://github.com/apache/incubator-mxnet/pull/18288#issuecomment-629557829 @mxnet-bot run ci [unix-cpu] This is an automated message from the Apache Git Service. To respond to

[GitHub] [incubator-mxnet] ys2843 commented on pull request #18288: Website global search feature

2020-05-15 Thread GitBox
ys2843 commented on pull request #18288: URL: https://github.com/apache/incubator-mxnet/pull/18288#issuecomment-629441115 > Very nice. Thank you @ys2843 This will be very helpful for the community. > Please update the release manager checklist for changing the defaults. > > Should

[GitHub] [incubator-mxnet] ys2843 commented on pull request #18288: Website global search feature

2020-05-14 Thread GitBox
ys2843 commented on pull request #18288: URL: https://github.com/apache/incubator-mxnet/pull/18288#issuecomment-628990327 > Looks good. > > * Should we use offsite js files or host locally? > * Should the API key be in a js file are can it be in a config file so we keep this

[GitHub] [incubator-mxnet] ys2843 commented on pull request #18288: Website global search feature

2020-05-14 Thread GitBox
ys2843 commented on pull request #18288: URL: https://github.com/apache/incubator-mxnet/pull/18288#issuecomment-628867702 > Search feature looks great. > Nice to see we leveraging third-party to solve our search problem. > Q1. This feature is currently only for landing page right?